summaryrefslogtreecommitdiffstats
path: root/src/core/hle/kernel (follow)
Commit message (Collapse)AuthorAgeFilesLines
* hle: kernel: Cleanup shutdown of persistent kernel objects.bunnei2021-05-061-14/+12
|
* hle: kernel: Migrate KPort, KClientPort, and KServerPort to KAutoObject.bunnei2021-05-0617-138/+413
|
* hle: kernel: Migrate KServerPort to KAutoObject.bunnei2021-05-064-37/+53
|
* hle: kernel: Migrate KClientPort to KAutoObject.bunnei2021-05-069-47/+72
|
* hle: kernel: HandleTable: Remove deprecated APIs.bunnei2021-05-065-106/+23
|
* hle: kernel: Migrate KResourceLimit to KAutoObject.bunnei2021-05-0613-122/+197
|
* hle: kernel: svc: Migrate WaitSynchronization.bunnei2021-05-062-47/+78
|
* hle: kernel: svc: Use new handle table API for Process.bunnei2021-05-062-16/+17
|
* hle: kernel: Migrate KTransferMemory to KAutoObject.bunnei2021-05-068-53/+192
|
* hle: kernel: Migrate KSession, KClientSession, and KServerSession to KAutoObject.bunnei2021-05-0621-316/+384
|
* hle: kernel: svc: Migrate GetThreadContext, GetThreadCoreMask.bunnei2021-05-061-2/+59
|
* hle: kernel: svc: Migrate GetProcessId, CancelSynchronization, SetThreadActivity.bunnei2021-05-061-13/+67
|
* hle: kernel: KThread: Remove incorrect resource release.bunnei2021-05-061-2/+1
|
* hle: kernel: svc_results: Update naming..bunnei2021-05-068-42/+43
|
* hle: kernel: KThread: Add missing resource hint release.bunnei2021-05-061-1/+1
|
* hle: kernel: Migrate KReadableEvent and KWritableEvent to KAutoObject.bunnei2021-05-069-107/+129
|
* hle: kernel: Move slab heaps to their own container.bunnei2021-05-062-10/+16
|
* hle: kernel: Refactor several threads/events/sharedmemory to use slab heaps.bunnei2021-05-066-51/+41
|
* hle: kernel: Move slab heap management to KernelCore.bunnei2021-05-067-64/+106
|
* hle: kernel: Ensure all kernel objects with KAutoObject are properly created.bunnei2021-05-062-0/+8
|
* hle: kernel: Use unique_ptr for suspend and dummy threads.bunnei2021-05-061-8/+8
|
* hle: kernel: Migrate KEvent to KAutoObject.bunnei2021-05-066-19/+56
|
* hle: kernel: Migrate KSharedMemory to KAutoObject.bunnei2021-05-069-72/+116
|
* hle: kernel: Migrate KProcess to KAutoObject.bunnei2021-05-0611-47/+68
|
* hle: kernel: Refactor IPC interfaces to not use std::shared_ptr.bunnei2021-05-065-17/+22
|
* hle: kernel: Migrate more of KThread to KAutoObject.bunnei2021-05-0616-289/+442
|
* hle: kernel: svc: Migrate GetThreadPriority, StartThread, and ExitThread.bunnei2021-05-061-21/+12
|
* hle: kernel: svc: Migrate CreateThread.bunnei2021-05-061-14/+21
|
* hle: kernel: Migrate idle threads.bunnei2021-05-062-13/+9
|
* hle: kernel: Migrate KThread to KAutoObject.bunnei2021-05-062-109/+91
|
* hle: kernel: Add initial impl. of slab setup.bunnei2021-05-062-0/+225
|
* hle: kernel: Refactor out various KThread std::shared_ptr usage.bunnei2021-05-069-54/+26
|
* hle: kernel: Add initial impl. of KLinkedList.bunnei2021-05-061-0/+233
|
* hle: kernel: Add initial impl. of KSlabAllocated.bunnei2021-05-061-0/+152
|
* hle: kernel: Add initial impl. of KAutoObjectWithListContainer.bunnei2021-05-062-0/+107
|
* hle: kernel: Add initial impl. of KAutoObject.bunnei2021-05-062-0/+304
|
* hid: Implement SevenSixAxis and ConsoleSixAxisSensorgerman772021-04-242-0/+7
|
* hle_ipc: Add helper functions to get copy/move handlesMorph2021-04-152-2/+16
|
* Merge pull request #6196 from bunnei/asserts-settingbunnei2021-04-151-1/+1
|\ | | | | core: settings: Add setting for debug assertions and disable by default.
| * common: Move settings to common from core.bunnei2021-04-151-1/+1
| | | | | | | | - Removes a dependency on core and input_common from common.
* | k_resource_limit: Minor cleanup of member variables/headersameerj2021-04-144-21/+13
| |
* | Merge pull request #6185 from ameerj/process-reslimitbunnei2021-04-142-38/+27
|\ \ | |/ |/| kernel/process: Replace process resource limit instance with the kernel's resource limit
| * kernel/process: Replace process resource limit instance with the kernel's resource limitameerj2021-04-122-38/+27
| | | | | | | | This commit addresses the inaccurate behavior of kernel processes creating their own resource limit, rather than utilizing the kernel's system-wide resource limit instance.
* | k_thread: Remove [[nodiscard]] attribute from ClearWaitCancelled()Lioncash2021-04-121-1/+1
|/ | | | | This function has a void return value, so this attribute doesn't apply to it.
* Merge pull request #6099 from bunnei/derive-membunnei2021-04-1023-172/+2087
|\ | | | | Kernel Rework: Derive memory regions from board layout.
| * hle: kernel: Breakup InitializeMemoryLayout.bunnei2021-03-241-3/+7
| |
| * hle: kernel: k_memory_region_type: Minor code cleanup.bunnei2021-03-241-13/+12
| |
| * hle: kernel: k_memory_region: Minor code cleanup.bunnei2021-03-241-7/+5
| |
| * hle: kernel: k_memory_layout: Use pair instead of tuple.bunnei2021-03-241-2/+4
| |
| * hle: kernel: k_system_control: Remove unnecessary inline.bunnei2021-03-241-4/+4
| |
| * common: common_sizes: Move sizes to the Common namespace.bunnei2021-03-244-45/+46
| |
| * hle: kernel: Merge KMemoryRegionAttr and KMemoryRegionType.bunnei2021-03-212-11/+9
| | | | | | | | - Fixes clang errors with mixed enum arithmetic.
| * hle: kernel: Remove unused variable.bunnei2021-03-211-1/+0
| |
| * hle: kernel: k_memory_region_type: Remove extra ".bunnei2021-03-211-1/+1
| |
| * hle: kernel: k_memory_layout: Move KMemoryRegionAllocator out of global.bunnei2021-03-213-35/+47
| |
| * hle: kernel: k_memory_layout: Derive memory regions based on board layout.bunnei2021-03-215-56/+1031
| |
| * common: common_sizes: Move Invalid to Size_* prefix and add missing values.bunnei2021-03-211-14/+14
| |
| * hle: kernel: k_memory_region: Refactor to simplify code.bunnei2021-03-212-83/+89
| |
| * hle: kernel: board: k_system_control: Extend to include memory region sizes.bunnei2021-03-212-1/+125
| |
| * hle: kernel: board: Add secure_monitor module.bunnei2021-03-211-0/+26
| |
| * common: Move common sizes to their own header for code reuse.bunnei2021-03-211-13/+1
| |
| * hle: kernel: k_address_space_info: Cleanup.bunnei2021-03-211-9/+9
| |
| * hle: kernel: Add k_trace module.bunnei2021-03-211-0/+12
| |
| * hle: kernel: KSystemControl: Update to reflect board-specific behavior.bunnei2021-03-213-9/+39
| |
| * hle: kernel: KMemoryManager: Add CalculateManagementOverheadSize.bunnei2021-03-212-0/+26
| |
| * hle: kernel: KMemoryManager: Add aliases.bunnei2021-03-211-0/+4
| |
| * hle: kernel: Add architecture and board specific memory regions.bunnei2021-03-212-0/+72
| |
| * hle: kernel: KMemoryRegion: Derive region values.bunnei2021-03-211-0/+327
| |
| * hle: kernel: Migrate some code from Common::SpinLock to KSpinLock.bunnei2021-03-215-25/+25
| |
| * hle: kernel: Add initial KMemoryRegionType module.bunnei2021-03-212-18/+40
| |
| * hle: kernel: Move KMemoryRegion to its own module and update.bunnei2021-03-213-31/+321
| |
* | Merge pull request #6156 from lioncash/lock-discardbunnei2021-04-103-9/+12
|\ \ | | | | | | kernel: Mark lock helper classes as [[nodiscard]]
| * | Amend bizarre clang-format suggestionsLioncash2021-04-073-5/+5
| | |
| * | k_scoped_scheduler_lock_and_sleep: Mark class as [[nodiscard]]Lioncash2021-04-071-1/+1
| | | | | | | | | | | | Prevents logic bugs from slipping through.
| * | k_scoped_lock: delete copy and move assignment operatorsLioncash2021-04-071-2/+5
| | | | | | | | | | | | | | | | | | If we delete the copy and move constructor, we should also be deleting the copy and move assignment operators (and even if this were intended, it would be pretty odd to not document why it's done this way).
| * | k_scoped_lock: Mark class as [[nodiscard]]Lioncash2021-04-071-1/+1
| | | | | | | | | | | | | | | Prevents logic bugs of the kind described in the previous commit from slipping through.
| * | k_scheduler: Mark KScopedSchedulerLock as [[nodiscard]]Lioncash2021-04-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevents logic bugs like: KScopedSchedulerLock{kernel}; instead of: KScopedSchedulerLock lk{kernel}; from slipping through.
* | | Merge pull request #6155 from ameerj/kernel-12-rescntbunnei2021-04-091-2/+2
|\ \ \ | | | | | | | | kernel: Increase event and session counts
| * | | kernel: Increase event and session countsameerj2021-04-071-2/+2
| |/ / | | | | | | | | | 12.x increased the number of available sessions and event resource counts
* | | Merge pull request #6154 from lioncash/svcrange2bunnei2021-04-081-0/+132
|\ \ \ | | | | | | | | svc: Expand SVC tables
| * | | svc: Expand SVC tablesLioncash2021-04-071-0/+132
| |/ / | | | | | | | | | | | | 12.x expanded the range of SVC entries from 0x7F to 0xBF (with all new entries being unused), so we can expand it to also match.
* / / process_capability: Handle extended SVC rangeLioncash2021-04-072-6/+1
|/ / | | | | | | | | | | | | | | 12.x extended the range of SVC IDs, so we need to expand the range of bits that need to be tested. The upside of this is that we can eliminate a range check, given the whole range is used.
* / hle: kernel: Initialize preemption task after schedulers.bunnei2021-03-271-1/+1
|/ | | | - Fixes a startup crash that occurs if CoreTiming tries to preempt before kernel initialization completes.
* common: Fiber: use a reference for YieldTo.bunnei2021-03-071-8/+3
| | | | - Fixes another small leak.
* hle: kernel: KThread: Rework dummy threads & fix memory leak.bunnei2021-03-066-36/+65
| | | | | - Dummy threads are created on thread local storage for all host threads. - Fixes a leak by removing creation of fibers, which are not applicable here.
* Revert "core: Switch to unique_ptr for usage of Common::Fiber."bunnei2021-03-065-24/+23
|
* core: Switch to unique_ptr for usage of Common::Fiber.bunnei2021-02-275-23/+24
| | | | | - With using unique_ptr instead of shared_ptr, we have more explicit ownership of the context. - Fixes a memory leak due to circular reference of the shared pointer.
* Merge pull request #5953 from bunnei/memory-refactor-1bunnei2021-02-2734-1156/+1367
|\ | | | | Kernel Rework: Memory updates and refactoring (Part 1)
| * hle: kernel: Migrate PageHeap/PageTable to KPageHeap/KPageTable.bunnei2021-02-1913-130/+115
| |
| * hle: kernel: Migrate MemoryManager to KMemoryManager.bunnei2021-02-197-45/+46
| |
| * hle: kernel: Migrate PageLinkedList to KPageLinkedList.bunnei2021-02-197-37/+40
| |
| * hle: kernel: Migrate to KMemoryBlock, KMemoryBlockManager, and others.bunnei2021-02-1916-461/+465
| |
| * hle: kernel: Migrate SlabHeap to KSlabHeap.bunnei2021-02-193-21/+20
| |
| * hle: kernel: Migrate MemoryLayout to KMemoryLayout.bunnei2021-02-194-30/+29
| |
| * hle: kernel: Migrate AddressSpaceInfo to KAddressSpaceInfo.bunnei2021-02-193-57/+52
| |
| * hle: kernel: memory_manager: Rename AllocateContinuous to AllocateContinuous.bunnei2021-02-192-4/+28
| |
| * hle: kernel: KSystemControl does not belong in Memory namespace.bunnei2021-02-195-27/+34
| |
| * hle: kernel: memory: PageHeap: Migrate to KPageBitmap class.bunnei2021-02-194-197/+23
| |
| * hle: kernel: Add KPageBitmap class.bunnei2021-02-191-0/+279
| |
| * hle: kernel: system_control: Add function GenerateRandomU64.bunnei2021-02-192-3/+5
| |
| * hle: kernel: Add KSpinLock implementation.bunnei2021-02-192-0/+87
| |
| * hle: kernel: Rename SharedMemory to KSharedMemory.bunnei2021-02-195-40/+40
| |
* | kernel: Fix resource release exception on exitameerj2021-02-211-2/+7
|/ | | | | After rewriting the resource limit, objects releasing reserved resources require a live kernel instance. This commit fixes exceptions that occur due to the kernel being destroyed before some objects released their resources, allowing for a graceful exit.
* kernel: More accurately reserve and release resourcesameerj2021-02-136-14/+42
|
* kernel: KScopedReservation implementationameerj2021-02-135-26/+151
| | | | This implements KScopedReservation, allowing resource limit reservations to be more HW accurate, and release upon failure without requiring too many conditionals.
* kernel: Unify result codes (#5890)Chloe2021-02-1319-251/+219
| | | | | | | | | * kernel: Unify result codes Drop the usage of ERR_NAME convention in kernel for ResultName. Removed seperation between svc_results.h & errors.h as we mainly include both most of the time anyways. * oops * rename errors to svc_results
* Merge pull request #5872 from lioncash/svc-errorChloe2021-02-081-59/+188
|\ | | | | svc: Provide more detailed error logs for svc functions
| * svc: Provide more detailed error logs for svc functionsLioncash2021-02-061-59/+188
| | | | | | | | | | Allows SVC calls to have much more informative information during error cases. This also doesn't hide control flow returns from the reader.
* | k_address_arbiter: Unfold R_UNLESS macrosLioncash2021-02-061-5/+8
| | | | | | | | | | Allows for more descriptive error messages and also doesn't hide control-path exit returns from the reader.
* | k_address_arbiter: Remove unnecessary usages of std::addressofLioncash2021-02-061-10/+10
| | | | | | | | | | | | This is a useful function in a generic context or with types that overload unary operator&. However, primitives and pointers will never do this, so we can opt for a more straightforward syntax.
* | k_address_arbiter: Remove dead codeLioncash2021-02-061-40/+13
|/ | | | | This code is never used, so we can remove it. It's in version control, so it can always be brought back when needed.
* Merge pull request #5862 from bunnei/keventbunnei2021-02-0621-291/+386
|\ | | | | Kernel Rework: Refactor KEvent/KReadableEvent/KWritableEvent
| * hle: kernel: Drop R_UNLESS_NOLOG in favor of expanded if-statement.bunnei2021-02-052-3/+11
| |
| * hle: kernel: KAddressArbiter: Remove noisy error log.bunnei2021-02-051-1/+1
| |
| * hle: kernel: svc: Cleanup KEvent/KReadableEvent/KWritableEvent SVCs.bunnei2021-02-055-69/+89
| |
| * hle: kernel: Reimplement KReadableEvent and KWritableEvent.bunnei2021-02-059-104/+82
| |
| * hle: kernel: Implement KEvent.bunnei2021-02-052-0/+89
| |
| * hle: kernel: KAddressArbiter: Use R_UNLESS_NOLOG where applicable.bunnei2021-02-051-1/+1
| |
| * hle: kernel: Rename WritableEvent to KWritableEvent.bunnei2021-02-056-21/+21
| |
| * hle: kernel: Rename ReadableEvent to KReadableEvent.bunnei2021-02-057-23/+23
| |
* | Merge pull request #5875 from lioncash/identifierbunnei2021-02-061-9/+9
|\ \ | |/ |/| k_priority_queue: Minor cleanup
| * k_priority_queue: Unfold several declval usagesLioncash2021-02-041-5/+5
| | | | | | | | | | | | | | | | Given these are only used as function existence checks, we can simplify some usages of declval, given they aren't particularly useful here. Reduces a few template instantiations, which at most reduces compile times a tiny bit.
| * k_priority_queue: Simplify affinity mask type aliasLioncash2021-02-041-2/+2
| | | | | | | | | | We can make use of the _t variants of the templates to cut down on a little bit of verbosity.
| * k_priority_queue: Resolved reserved identifierLioncash2021-02-041-2/+2
| | | | | | | | | | | | | | | | | | | | An identifier containing a starting underscore followed by a capital letter is reserved by the standard. It's trivial to avoid this by moving the underscore to the end of the identifier. While the likelihood of clashing here being minimal, we can turn a "should not break" scenario into a definitive "will not break" one, so why not?.
* | k_affinity_mask: Avoid implicit truncation to boolLioncash2021-02-041-1/+1
|/ | | | | This can cause compiler warnings. Instead, we can explicitly add a boolean expression around it to naturally turn the result into a bool.
* Simplify limitableresource namesChloe Marcec2021-02-036-36/+29
|
* Compile errorChloe Marcec2021-02-021-1/+1
|
* Address issuesChloe Marcec2021-02-023-19/+15
|
* fix compile errorChloe Marcec2021-01-301-1/+1
|
* cleanup commentingChloe Marcec2021-01-301-2/+2
|
* Drop m_ from lockChloe Marcec2021-01-302-9/+9
|
* Move to GetGlobalTimeNs, fix GetTotalPhysicalMemoryAvailableChloe Marcec2021-01-303-9/+7
|
* kernel: Rewrite resource limit to be more accurateChloe Marcec2021-01-3012-229/+354
| | | | Matches closer to hardware
* hle: kernel: KLightLock: Fix several bugs.bunnei2021-01-291-3/+3
|
* hle: kernel: KThread: Release thread resource on thread exit.bunnei2021-01-291-0/+1
|
* yuzu: debugger: Ignore HLE threads.bunnei2021-01-292-7/+13
|
* hle: kernel: process: Add state lock.bunnei2021-01-293-6/+15
|
* hle: kernel: threading: Fix bug with host thread naming.bunnei2021-01-291-3/+2
|
* hle: kernel: k_scheduler_lock: Cleanup.bunnei2021-01-291-3/+3
|
* hle: kernel: Allocate a dummy KThread for each host thread, and use it for scheduling.bunnei2021-01-297-41/+45
|
* hle: kernel: k_scheduler: Use atomics for current_thread, etc.bunnei2021-01-292-26/+28
|
* hle: kernel: k_scheduler: Fix for single core mode.bunnei2021-01-291-1/+2
|
* kernel: Fix build errors.bunnei2021-01-292-4/+9
|
* hle: kernel: KScheduler: Introduce thread context_guard.bunnei2021-01-292-3/+16
|
* hle: kernel: Recode implementation of KThread to be more accurate.bunnei2021-01-2912-767/+1553
|
* kernel: svc_types: Add ThreadActivity.bunnei2021-01-291-0/+5
|
* kernel: KSchedulerPriorityQueue: Lowest priority should be LowestThreadPriority.bunnei2021-01-291-1/+1
|
* kernel: k_light_lock: Simplify EmuThreadHandle implementation.bunnei2021-01-294-23/+25
|
* hle: kernel: TimeManager: Simplify to not rely on previous EmuThreadHandle implementation.bunnei2021-01-296-69/+25
|
* core: hle: kernel: object: Implement Finalize() virtual method.bunnei2021-01-2915-6/+29
|
* core: hle: kernel: svc_results: Populate with several missing error codes.bunnei2021-01-291-0/+3
|
* core: hle: kernel: Implement KLightLock.bunnei2021-01-292-0/+171
|
* core: hle: kernel: Implement KThreadQueue.bunnei2021-01-291-0/+81
|
* hle: kernel: KThread: Clean up thread priorities.bunnei2021-01-299-75/+41
|
* hle: kernel: KThread: Reorganize thread priority defaults.bunnei2021-01-297-27/+27
|
* hle: kernel: KThread: Fix ThreadType definition.bunnei2021-01-295-11/+12
|
* hle: kernel: Move single core "phantom mode" out of KThread.bunnei2021-01-293-10/+24
| | | | - This is a workaround that does not belong in a kernel primitive.
* hle: kernel: KThread: Remove thread types that do not exist.bunnei2021-01-294-44/+27
|
* core: hle: kernel: Rename Thread to KThread.bunnei2021-01-2930-238/+237
|
* hle_ipc: Add Can(Read, Write)BufferMorph2021-01-282-0/+28
| | | | Allows us to test whether a buffer can be read from or written to memory
* common/bit_util: Replace CLZ/CTZ operations with standardized onesLioncash2021-01-154-8/+12
| | | | Makes for less code that we need to maintain.
* hle: kernel: thread: Preserve thread wait reason for debugging only.bunnei2021-01-117-1/+34
| | | | - This is decoupled from core functionality and used for debugging only.
* hle: kernel: k_scheduler_lock: Fix shadowing errors.bunnei2021-01-111-1/+1
|
* core: hle: Integrate new KConditionVariable and KAddressArbiter implementations.bunnei2021-01-1113-1173/+503
|
* core: hle: kernel: Update KAddressArbiter.bunnei2021-01-112-0/+435
|
* core: hle: kernel: Update KConditionVariable.bunnei2021-01-113-0/+411
|
* core: hle: kernel: Begin moving common SVC defintions to its own header.bunnei2021-01-111-0/+13
|
* hle: kernel: Remove unnecessary AddressArbiter definition.bunnei2021-01-111-1/+0
|
* hle: kernel: k_scheduler: Cleanup OnThreadPriorityChanged.bunnei2021-01-112-6/+3
|
* hle: kernel: Rename thread "status" to "state".bunnei2021-01-111-2/+2
|
* hle: kernel: thread: Replace ThreadStatus/ThreadSchedStatus with a single ThreadState.bunnei2021-01-1111-127/+97
| | | | - This is how the real kernel works, and is more accurate and simpler.
* core: hle: kernel: Add some useful functions for checking kernel addresses.bunnei2021-01-111-0/+19
|
* core: hle: kernel: svc_types: Add type definitions for KAddressArbiter.bunnei2021-01-111-0/+12
|
* core: hle: kernel: Update KSynchronizationObject.bunnei2021-01-1129-596/+377
|
* core: hle: kernel: Begin moving common SVC results to its own header.bunnei2021-01-111-0/+20
|
* core: Silence warnings when compiling without assertsReinUsesLisp2021-01-051-0/+2
|
* general: Fix various spelling errorsMorph2021-01-023-15/+15
|
* Merge pull request #5249 from ReinUsesLisp/lock-free-pagesbunnei2021-01-011-1/+1
|\ | | | | core/memory: Read and write page table atomically
| * core/memory: Read and write page table atomicallyReinUsesLisp2020-12-301-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Squash attributes into the pointer's integer, making them an uintptr_t pair containing 2 bits at the bottom and then the pointer. These bits are currently unused thanks to alignment requirements. Configure Dynarmic to mask out these bits on pointer reads. While we are at it, remove some unused attributes carried over from Citra. Read/Write and other hot functions use a two step unpacking process that is less readable to stop MSVC from emitting an extra AND instruction in the hot path: mov rdi,rcx shr rdx,0Ch mov r8,qword ptr [rax+8] mov rax,qword ptr [r8+rdx*8] mov rdx,rax -and al,3 and rdx,0FFFFFFFFFFFFFFFCh je Core::Memory::Memory::Impl::Read<unsigned char> mov rax,qword ptr [vaddr] movzx eax,byte ptr [rdx+rax]
* | Merge pull request #5208 from bunnei/service-threadsbunnei2020-12-318-126/+237
|\ \ | | | | | | Service threads
| * | hle: kernel: service_thread: Make thread naming more consistent.bunnei2020-12-301-1/+1
| | |
| * | hle: kernel: Manage service threads on another thread.bunnei2020-12-301-9/+20
| | | | | | | | | | | | - This is to allow service threads to defer destruction of themselves.
| * | hle: kernel: Manage host thread IDs using TLS.bunnei2020-12-301-46/+31
| | | | | | | | | | | | - Avoids the need to have a large map of host to guest thread IDs.
| * | hle: kernel: Move ServiceThread ownership to KernelCore.bunnei2020-12-294-5/+48
| | | | | | | | | | | | - Fixes a circular dependency which prevented threads from being released on shutdown.
| * | hle: kernel: service_thread: Add thread name and take weak_ptr of ServerSession.bunnei2020-12-293-11/+22
| | |
| * | core: hle: kernel: Clear process list on boot.bunnei2020-12-291-2/+2
| | |
| * | core: kernel: Clear process list earlier.bunnei2020-12-291-2/+2
| | |
| * | hle: kernel: hle_ipc: Remove SleepClientThread.bunnei2020-12-292-54/+0
| | | | | | | | | | | | - This was kind of hacky, and no longer is necessary with service threads.
| * | hle: kernel: service_thread: Add parameter for thread pool size.bunnei2020-12-293-7/+7
| | |
| * | core: hle: server_session: Use separate threads for each service connection.bunnei2020-12-295-23/+138
| | |
* | | Merge pull request #5247 from comex/xx-conceptsbunnei2020-12-301-3/+5
|\ \ \ | | | | | | | | k_priority_queue: Fix concepts use
| * | | k_priority_queue: Fix concepts usecomex2020-12-291-3/+5
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - For `std::same_as`, add missing include of `<concepts>`. - For `std::convertible_to`, create a replacement in `common/concepts.h` and use that instead. This would also be found in `<concepts>`, but unlike `std::same_as`, `std::convertible_to` is not yet implemented in libc++, LLVM's STL implementation - not even in master. (In fact, `std::same_as` is the *only* concept currently implemented. For some reason.)
* | | Merge pull request #5246 from comex/xx-includebunnei2020-12-301-0/+1
|\ \ \ | |_|/ |/| | Add missing include of "core/hle/kernel/kernel.h"
| * | Add missing include of "core/hle/kernel/kernel.h"comex2020-12-291-0/+1
| |/ | | | | | | This is needed as the header invokes methods on KernelCore.
* / svc: demote SleepThread log to LOG_TRACEameerj2020-12-291-1/+1
|/ | | | This log is called often, and introduces a lot of noise when debug logging is enabled, making it difficult to see other debug logs.
* Merge pull request #5131 from bunnei/scheduler-rewritebunnei2020-12-2128-1371/+2040
|\ | | | | Rewrite Kernel scheduler based on Atmosphere
| * hle: kernel: Process: Various style fixes based on code review feedback.bunnei2020-12-061-2/+2
| |
| * hle: kernel: Thread: Various style fixes based on code review feedback.bunnei2020-12-061-22/+25
| |
| * hle: kernel: KScopedSchedulerLockAndSleep: Various style fixes based on code review feedback.bunnei2020-12-061-6/+6
| |
| * hle: kernel: KScopedLock: Various style fixes based on code review feedback.bunnei2020-12-061-6/+8
| |
| * hle: kernel: KAbstractSchedulerLock: Various style fixes based on code review feedback.bunnei2020-12-061-9/+7
| |
| * hle: kernel: KScheduler: Various style fixes based on code review feedback.bunnei2020-12-062-50/+41
| |
| * hle: kernel: KPriorityQueue: Various style fixes based on code review feedback.bunnei2020-12-061-29/+36
| |
| * hle: kernel: KAffinityMask: Various style fixes based on code review feedback.bunnei2020-12-061-17/+13
| |
| * hle: kernel: GlobalSchedulerContext: Various style fixes based on code review feedback.bunnei2020-12-062-5/+10
| |
| * hle: kernel: Use C++ style comments in KScheduler, etc.bunnei2020-12-064-152/+136
| |
| * kernel: KScopedSchedulerLockAndSleep: Remove unused ctor.bunnei2020-12-061-13/+7
| |
| * kernel: time_manager: Add missing lock guards.bunnei2020-12-061-3/+10
| |
| * hle: kernel: Migrate to KScopedSchedulerLock.bunnei2020-12-0614-48/+91
| |
| * hle: kernel: Separate KScopedSchedulerLockAndSleep from k_scheduler.bunnei2020-12-0610-69/+71
| |
| * hle: kernel: Separate KScheduler from GlobalSchedulerContext class.bunnei2020-12-064-118/+138
| |
| * hle: kernel: Rewrite scheduler implementation based on Mesopshere.bunnei2020-12-0619-1145/+1178
| |
| * hle: kernel: physical_core: Clear exclusive state after each run.bunnei2020-12-061-0/+1
| | | | | | | | - This is closer to pre-multicore behavior, and works a bit better.
| * hle: kernel: Port KAbstractSchedulerLock from Mesosphere.bunnei2020-12-061-0/+76
| |
| * hle: kernel: svc: Remove reschedule on svcBreak.bunnei2020-12-061-5/+0
| | | | | | | | - This breaks things, and is unnecessary, since emulation will be done at this point.
| * hle: kernel: process: Add schedule count tracking, to be used for yield impl.bunnei2020-12-061-0/+13
| |
| * hle: kernel: svc: Remove unnecessary hack in svcSleep.bunnei2020-12-061-7/+0
| |
| * common: Port KPriorityQueue from Mesosphere.bunnei2020-12-061-0/+443
| |
| * hle: kernel: Port KAffinityMask from Mesosphere.bunnei2020-12-065-14/+77
| |
* | Merge pull request #5172 from lioncash/svc-widebunnei2020-12-121-35/+25
|\ \ | | | | | | svc: Remove unnecessary casts
| * | svc: Remove unnecessary castsLioncash2020-12-081-35/+25
| | | | | | | | | | | | | | | | | | Simplifies and removes some casts. In all cases, these were generally widening from a 32-bit unsigned type to a 64-bit unsigned type, so no information would be lost from the conversion.
* | | core: Remove unnecessary enum casts in log callsLioncash2020-12-083-5/+4
|/ / | | | | | | | | Follows the video core PR. fmt doesn't require casts for enum classes anymore, so we can remove quite a few casts.
* | Merge pull request #5148 from comex/xx-unused-fieldsbunnei2020-12-071-2/+2
|\ \ | | | | | | core: Mark unused fields as [[maybe_unused]]
| * | core: Mark unused fields as [[maybe_unused]]comex2020-12-071-2/+2
| |/
* | Merge pull request #5136 from lioncash/video-shadow3LC2020-12-071-3/+3
|\ \ | | | | | | video_core: Resolve more variable shadowing scenarios pt.3
| * | video_core: Resolve more variable shadowing scenarios pt.3Lioncash2020-12-051-3/+3
| |/ | | | | | | | | Cleans out the rest of the occurrences of variable shadowing and makes any further occurrences of shadowing compiler errors.
* / Fix "explicitly defaulted but implicitly deleted" warningcomex2020-12-071-1/+1
|/ | | | | | | | | | `PhysicalCore`'s move assignment operator was declared as `= default`, but was implicitly deleted because `PhysicalCore` has fields of reference type. Switch to explicitly deleting it to avoid a Clang warning. The move *constructor* is still defaulted, and is required to exist due to the use of `std::vector<PhysicalCore>`.
* kernel: scheduler: Minor cleanup to remove duplicated code.bunnei2020-11-292-46/+14
|
* kernel: time_manager: Protect access with a mutex.bunnei2020-11-292-1/+5
|
* hle: kernel: thread: Remove unused "Running" state.bunnei2020-11-292-6/+0
|
* core: arm: Implement InvalidateCacheRange for CPU cache invalidation.bunnei2020-11-294-5/+21
|
* hle: kernel: time_manager: Avoid a crash on process exit.bunnei2020-11-291-1/+4
|
* hle: kernel: AddressArbiter: Remove unused code.bunnei2020-11-292-9/+0
|
* hle: kernel: SynchronizationObject: Use atomic_bool for is_signaled.bunnei2020-11-291-1/+2
|
* common: fiber: Use boost::context instead of native fibers on Windows.bunnei2020-11-291-1/+1
|
* hle: kernel: multicore: Replace n-JITs impl. with 4 JITs.bunnei2020-11-298-57/+97
|
* svc: Remove unnecessary [[maybe_unused]] tagLioncash2020-11-231-1/+1
| | | | | The parameter is used in this function, so this suppression isn't necessary.
* ipc_helpers: Remove usage of the global system instanceLioncash2020-11-081-0/+6
| | | | | | | | | Resolves numerous deprecation warnings throughout the codebase due to inclusion of this header. Now building core should be significantly less noisy (and also relying on less global state). This also uncovered quite a few modules that were relying on indirect includes, which have also been fixed.
* core: Remove usage of unicornLioncash2020-11-042-28/+5
| | | | | | | | Unicorn long-since lost most of its use, due to dynarmic gaining support for handling most instructions. At this point any further issues encountered should be used to make dynarmic better. This also allows us to remove our dependency on Python.
* kernel/process: Add missing <ctime> includeMorph2020-10-291-0/+1
| | | | Fixes compilation on MSVC
* Merge pull request #4835 from lat9nq/rng-default-timebunnei2020-10-291-1/+1
|\ | | | | kernel: Use the current time as the default RNG seed
| * kernel: Use the current time as the default RNG seedlat9nq2020-10-271-1/+1
| | | | | | | | Use the current time, not zero, as the default RNG seed.
* | hle/kernel: Remove unused registered_core_threads to fix data racesReinUsesLisp2020-10-271-5/+0
|/ | | | | This member was only used on asserts and it triggered data races. Remove it to fix them.
* Revert "core: Fix clang build"bunnei2020-10-2118-114/+74
|
* kernel: Fix build with recent compiler flag changesLioncash2020-10-211-4/+8
| | | | | This slipped through the cracks due to another change being merged before the compiler flag changes.
* Merge pull request #4796 from lioncash/clangLC2020-10-2118-74/+114
|\ | | | | core: Fix clang build
| * core: Fix clang buildLioncash2020-10-1818-74/+114
| | | | | | | | | | | | | | Recent changes to the build system that made more warnings be flagged as errors caused building via clang to break. Fixes #4795
* | Merge pull request #4788 from ReinUsesLisp/lockfree-host-threadbunnei2020-10-201-28/+38
|\ \ | |/ |/| kernel: Implement host thread register methods without locking
| * kernel: Implement host thread register methods without lockingReinUsesLisp2020-10-131-28/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | Locks on GetCurrentHostThreadID were causing performance issues according to Visual Studio's profiler. It was consuming twice the time as arm_interface.Run(). The cost was not in the function itself but in the lockinig it required. Reimplement these functions using atomics and static storage instead of an unordered_map. This is a side effect to avoid locking and using linked lists for reads. Replace unordered_map with a linear search.
* | core/CMakeLists: Make some warnings errorsLioncash2020-10-132-6/+6
|/ | | | | | | | | Makes our error coverage a little more consistent across the board by applying it to Linux side of things as well. This also makes it more consistent with the warning settings in other libraries in the project. This also updates httplib to 0.7.9, as there are several warning cleanups made that allow us to enable several warnings as errors.
* kernel: Remove all dependencies on the global system instanceLioncash2020-09-145-11/+20
| | | | | With this, the kernel finally doesn't depend directly on the global system instance anymore.
* Merge pull request #4323 from ReinUsesLisp/no-spinbunnei2020-09-121-1/+1
|\ | | | | kernel/scheduler: Use std::mutex instead of spin lock
| * kernel/scheduler: Use std::mutex instead of spin lockReinUsesLisp2020-07-131-1/+1
| | | | | | | | | | | | | | | | Profiling shows that this is a highly contested mutex, causing dimishing results compared to a OS lock. std::mutex implementations can spin for a while before falling back to an OS lock. This avoids wasting precious CPU cycles in a no-op.
* | Merge pull request #4590 from ReinUsesLisp/tsan-schedbunnei2020-09-031-2/+6
|\ \ | | | | | | hle/scheduler: Fix data race in is_context_switch_pending
| * | hle/scheduler: Fix data race in is_context_switch_pendingReinUsesLisp2020-08-261-2/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As reported by tsan, SelectThreads could write to is_context_switch_pending holding a mutex while SwitchToCurrent reads it without holding any. It is assumed that the author didn't want an atomic here, so the code is reordered so that whenever is_context_switch_pending is read inside SwitchToContext, the mutex is locked.
* | | hle/kernel: Fix data race in GetCurrentHostThreadIDReinUsesLisp2020-08-261-1/+2
|/ / | | | | | | | | | | | | | | As reported by tsan, host_thread_ids could be read while any of the RegisterHostThread variants were called. To fix this, lock the register mutex when yuzu is running in multicore mode and GetCurrentHostThreadID is called.
* | Merge pull request #4492 from lioncash/linkagebunnei2020-08-152-15/+11
|\ \ | | | | | | system_control: Make functions internally linked where applicable
| * | system_control: Make functions internally linked where applicableLioncash2020-08-052-15/+11
| | | | | | | | | | | | | | | These functions are only ever used internally as implementation details for GenerateRandomRange(), so these can be given internal linkage.
* | | kernel/scheduler: Mark SchedulerLock constructor as nodiscardLioncash2020-08-141-1/+1
| | | | | | | | | | | | | | | | | | Allows the compiler to warn about cases where the constructor is used but then immediately discarded, which is a potential cause of locking/unlocking bugs.
* | | General: Tidy up clang-format warnings part 2Lioncash2020-08-132-30/+38
| | |
* | | Merge pull request #4491 from lioncash/unused-varsbunnei2020-08-102-18/+11
|\ \ \ | | | | | | | | kernel: Remove unused variables
| * | | kernel: Remove unused variablesLioncash2020-08-052-18/+11
| |/ / | | | | | | | | | Resolves a few compiler warnings.
* | | scheduler: Resolve sign conversion warningLioncash2020-08-051-1/+2
| | |
* | | address_arbiter: Resolve sign conversion warningLioncash2020-08-051-1/+1
|/ / | | | | | | Makes our type conversion explicit.
* | ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer (#4465)David2020-08-031-14/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | * ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer With the support of C++20, we can use concepts to deduce if a type is an STL container or not. * More agressive concept for stl containers * Add -fconcepts * Move to common namespace * Add Common::IsBaseOf
* | core_timing: Make use of uintptr_t to represent user_dataLioncash2020-07-283-8/+10
| | | | | | | | Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
* | Merge pull request #4348 from lioncash/nanobunnei2020-07-183-8/+11
|\ \ | | | | | | core_timing: Make usage of nanoseconds more consistent in the interface
| * | core_timing: Make TimedCallback take std::chrono::nanosecondsLioncash2020-07-163-3/+3
| | | | | | | | | | | | Enforces our desired time units directly with a concrete type.
| * | core_timing: Make use of std::chrono with ScheduleEventLioncash2020-07-163-5/+8
| |/
* | Merge pull request #4357 from lioncash/unused4David2020-07-173-7/+2
|\ \ | | | | | | kernel: Remove unused variables
| * | kernel: Remove unused variablesLioncash2020-07-163-7/+2
| | | | | | | | | | | | Resolves some compiler warnings in the Linux build.
* | | Merge pull request #4358 from lioncash/unused5David2020-07-171-2/+0
|\ \ \ | | | | | | | | kernel/thread: Remove unimplemented function prototype
| * | | kernel/thread: Remove unimplemented function prototypeLioncash2020-07-161-2/+0
| |/ / | | | | | | | | | This isn't used, so it can be removed.
* | | Merge pull request #4327 from lioncash/desig2Rodrigo Locatti2020-07-162-58/+38
|\ \ \ | |/ / |/| | address_space_info: Make use of designated initializers
| * | address_space_info: Use type alias to simplify codeLioncash2020-07-131-14/+13
| | | | | | | | | | | | | | | We can define an alias for the index arrays and then just reuse it to make the code nicer to read.
| * | address_space_info: Make use of designated initializersLioncash2020-07-132-46/+27
| |/ | | | | | | | | We can alter the structure so that we can use designated initializers in the array, eliminating the comments that indicate their field names.
* | kernel: Add missing includeLioncash2020-07-161-0/+1
| |
* | cpu_manager: Mark function getters as staticLioncash2020-07-163-7/+8
| | | | | | | | | | All these do are return std::function instances of static functions, so these can be used without an instance of the CPU manager.
* | Merge pull request #4346 from lioncash/threadDavid2020-07-167-35/+26
|\ \ | | | | | | kernel/handle_table: Remove usages of the global system instance
| * | kernel/process: Move name and system context to the bottom of the member listLioncash2020-07-151-6/+6
| | | | | | | | | | | | | | | | | | These aren't directly important or commonly used within the process, so we can move these to the bottom to allow everything else to be more likely to be within a cache line.
| * | kernel/handle_table: Remove usages of the global system instanceLioncash2020-07-154-8/+15
| | | | | | | | | | | | | | | | | | Removes even more usages of the global system instance, trimming away more dependencies on global variables and making them explicit in the interface.
| * | kernel/thread: Remove global GetCurrentThread()Lioncash2020-07-153-23/+7
| |/ | | | | | | | | This is only used in one place, so we can fold it into the calling code, eliminating a place for the global system instance to be used.
* / memory_layout: Remove unused data memberLioncash2020-07-131-2/+0
|/ | | | | This isn't used, so it can be removed entirely, shrinking the structure size by 8 bytes.
* configuration: implement per-game configurations (#4098)lat9nq2020-07-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Switch game settings to use a pointer In order to add full per-game settings, we need to be able to tell yuzu to switch to using either the global or game configuration. Using a pointer makes it easier to switch. * configuration: add new UI without changing existing funcitonality The new UI also adds General, System, Graphics, Advanced Graphics, and Audio tabs, but as yet they do nothing. This commit keeps yuzu to the same functionality as originally branched. * configuration: Rename files These weren't included in the last commit. Now they are. * configuration: setup global configuration checkbox Global config checkbox now enables/disables the appropriate tabs in the game properties dialog. The use global configuration setting is now saved to the config, defaulting to true. This also addresses some changes requested in the PR. * configuration: swap to per-game config memory for properties dialog Does not set memory going in-game. Swaps to game values when opening the properties dialog, then swaps back when closing it. Uses a `memcpy` to swap. Also implements saving config files, limited to certain groups of configurations so as to not risk setting unsafe configurations. * configuration: change config interfaces to use config-specific pointers When a game is booted, we need to be able to open the configuration dialogs without changing the settings pointer in the game's emualtion. A new pointer specific to just the configuration dialogs can be used to separate changes to just those config dialogs without affecting the emulation. * configuration: boot a game using per-game settings Swaps values where needed to boot a game. * configuration: user correct config during emulation Creates a new pointer specifically for modifying the configuration while emulation is in progress. Both the regular configuration dialog and the game properties dialog now use the pointer Settings::config_values to focus edits to the correct struct. * settings: split Settings::values into two different structs By splitting the settings into two mutually exclusive structs, it becomes easier, as a developer, to determine how to use the Settings structs after per-game configurations is merged. Other benefits include only duplicating the required settings in memory. * settings: move use_docked_mode to Controls group `use_docked_mode` is set in the input settings and cannot be accessed from the system settings. Grouping it with system settings causes it to be saved with per-game settings, which may make transferring configs more difficult later on, especially since docked mode cannot be set from within the game properties dialog. * configuration: Fix the other yuzu executables and a regression In main.cpp, we have to get the title ID before the ROM is loaded, else the renderer will reflect only the global settings and now the user's game specific settings. * settings: use a template to duplicate memory for each setting Replaces the type of each variable in the Settings::Values struct with a new class that allows basic data reading and writing. The new struct Settings::Setting duplicates the data in memory and can manage global overrides per each setting. * configuration: correct add-ons config and swap settings when apropriate Any add-ons interaction happens directly through the global values struct. Swapping bewteen structs now also includes copying the necessary global configs that cannot be changed nor saved in per-game settings. General and System config menus now update based on whether it is viewing the global or per-game settings. * settings: restore old values struct No longer needed with the Settings::Setting class template. * configuration: implement hierarchical game properties dialog This sets the apropriate global or local data in each setting. * clang format * clang format take 2 can the docker container save this? * address comments and style issues * config: read and write settings with global awareness Adds new functions to read and write settings while keeping the global state in focus. Files now generated per-game are much smaller since often they only need address the global state. * settings: restore global state when necessary Upon closing a game or the game properties dialog, we need to restore all global settings to the original global state so that we can properly open the configuration dialog or boot a different game. * configuration: guard setting values incorrectly This disables setting values while a game is running if the setting is overwritten by a per game setting. * config: don't write local settings in the global config Simple guards to prevent writing the wrong settings in the wrong files. * configuration: add comments, assume less, and clang format No longer assumes that a disabled UI element means the global state is turned off, instead opting to directly answer that question. Still however assumes a game is running if it is in that state. * configuration: fix a logic error Should not be negated * restore settings' global state regardless of accept/cancel Fixes loading a properties dialog and causing the global config dialog to show local settings. * fix more logic errors Fixed the frame limit would set the global setting from the game properties dialog. Also strengthened the Settings::Setting member variables and simplified the logic in config reading (ReadSettingGlobal). * fix another logic error In my efforts to guard RestoreGlobalState, I accidentally negated the IsPowered condition. * configure_audio: set toggle_stretched_audio to tristate * fixed custom rtc and rng seed overwriting the global value * clang format * rebased * clang format take 4 * address my own review Basically revert unintended changes * settings: literal instead of casting "No need to cast, use 1U instead" Thanks, Morph! Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com> * Revert "settings: literal instead of casting " This reverts commit 95e992a87c898f3e882ffdb415bb0ef9f80f613f. * main: fix status buttons reporting wrong settings after stop emulation * settings: Log UseDockedMode in the Controls group This should have happened when use_docked_mode was moved over to the controls group internally. This just reflects this in the log. * main: load settings if the file has a title id In other words, don't exit if the loader has trouble getting a title id. * use a zero * settings: initalize resolution factor with constructor instead of casting * Revert "settings: initalize resolution factor with constructor instead of casting" This reverts commit 54c35ecb46a29953842614620f9b7de1aa9d5dc8. * configure_graphics: guard device selector when Vulkan is global Prevents the user from editing the device selector if Vulkan is the global renderer backend. Also resets the vulkan_device variable when the users switches back-and-forth between global and Vulkan. * address reviewer concerns Changes function variables to const wherever they don't need to be changed. Sets Settings::Setting to final as it should not be inherited from. Sets ConfigurationShared::use_global_text to static. Co-Authored-By: VolcaEM <volcaem@users.noreply.github.com> * main: load per-game settings after LoadROM This prevents `Restart Emulation` from restoring the global settings *after* the per-game settings were applied. Thanks to BSoDGamingYT for finding this bug. * Revert "main: load per-game settings after LoadROM" This reverts commit 9d0d48c52d2dcf3bfb1806cc8fa7d5a271a8a804. * main: only restore global settings when necessary Loading the per-game settings cannot happen after the ROM is loaded, so we have to specify when to restore the global state. Again thanks to BSoD for finding the bug. * configuration_shared: address reviewer concerns except operator overrides Dropping operator override usage in next commit. Co-Authored-By: LC <lioncash@users.noreply.github.com> * settings: Drop operator overrides from Setting template Requires using GetValue and SetValue explicitly. Also reverts a change that broke title ID formatting in the game properties dialog. * complete rebase * configuration_shared: translate "Use global configuration" Uses ConfigurePerGame to do so, since its usage, at least as of now, corresponds with ConfigurationShared. * configure_per_game: address reviewer concern As far as I understand, it prevents the program from unnecessarily copying strings. Co-Authored-By: LC <lioncash@users.noreply.github.com> Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com> Co-authored-by: VolcaEM <volcaem@users.noreply.github.com> Co-authored-by: LC <lioncash@users.noreply.github.com>
* core_timing,scheduler: Use std::scoped_lock when possibleReinUsesLisp2020-06-291-11/+10
| | | | | Simplifies the cognitive load of procedures using locks and makes locks safe against exceptions.
* Core/Common: Address Feedback.Fernando Sahmkow2020-06-285-16/+17
|
* SVC: Implement 32-bits wrappers and update Dynarmic.Fernando Sahmkow2020-06-272-30/+273
|
* SVC: Add GetCurrentProcessorNumber32, CreateTransferMemory32, SetMemoryAttribute32Fernando Sahmkow2020-06-272-6/+39
|
* SVC: Add GetThreadPriority32 & SetThreadPriority32Fernando Sahmkow2020-06-272-2/+30
|
* Common/Kernel: Corrections and small bug fixing.Fernando Sahmkow2020-06-271-2/+2
|
* Kernel: Correct Host Context on Threads and Scheduler.Fernando Sahmkow2020-06-274-11/+11
|
* Clang Format.Fernando Sahmkow2020-06-274-12/+11
|
* General: Cleanup legacy code.Fernando Sahmkow2020-06-278-253/+5
|
* Kernel/svcBreak: Implement CacheInvalidation for Singlecore and correct svcBreak.Fernando Sahmkow2020-06-272-3/+13
|
* HLE_IPC: Correct HLE Event behavior on timeout.Fernando Sahmkow2020-06-273-1/+19
|
* SingleCore: Improve Cycle timing Behavior and replace mutex in global scheduler for spinlock.Fernando Sahmkow2020-06-272-2/+3
|
* SingleCore: Use Cycle Timing instead of Host Timing.Fernando Sahmkow2020-06-272-4/+13
|
* Scheduler: Correct Reload/UnloadFernando Sahmkow2020-06-272-3/+5
|
* Thread: Release the ARM Interface on exitting.Fernando Sahmkow2020-06-273-1/+8
|
* General: Move ARM_Interface into Threads.Fernando Sahmkow2020-06-278-119/+88
|
* Core: Refactor ARM Interface.Fernando Sahmkow2020-06-273-24/+43
|
* SVC/ARM: Correct svcSendSyncRequest and cache ticks on arm interface.Fernando Sahmkow2020-06-271-1/+1
|
* SingleCore: Move Host Timing from a sepparate thread to main cpu thread.Fernando Sahmkow2020-06-272-1/+10
|
* ARM: Addapt to new Exclusive Monitor Interface.Fernando Sahmkow2020-06-272-9/+4
|
* Scheduler: Correct yielding interaction with SetThreadActivity.Fernando Sahmkow2020-06-271-0/+15
|
* General: Fix microprofile on dynarmic/svc, fix wait tree showing which threads were running.Fernando Sahmkow2020-06-275-3/+51
|
* General: Fix Stop functionFernando Sahmkow2020-06-272-3/+20
|
* Kernel: Rewind on SVC change.Fernando Sahmkow2020-06-273-5/+16
|
* Kernel: Preempt Single core on redudant yields.Fernando Sahmkow2020-06-275-19/+40
|
* CPU_Manager: Unload/Reload threads on preemption on SingleCoreFernando Sahmkow2020-06-272-0/+52
|
* Synchronization: Correct wide Assertion.Fernando Sahmkow2020-06-271-2/+4
|
* General: Initial Setup for Single Core.Fernando Sahmkow2020-06-272-0/+22
|
* Scheduler: Set last running time on thread.Fernando Sahmkow2020-06-272-4/+2
|
* Kernel: Corrections to TimeManager, Scheduler and Mutex.Fernando Sahmkow2020-06-273-5/+5
|
* Kernel: Fixes, corrections and asserts to scheduler and different svcs.Fernando Sahmkow2020-06-278-38/+38
|
* Scheduler: Correct yields.Fernando Sahmkow2020-06-272-7/+25
|
* Mutex: Revert workaround due to poor exclusive memory.Fernando Sahmkow2020-06-271-9/+2
|
* ARM/Memory: Correct Exclusive Monitor and Implement Exclusive Memory Writes.Fernando Sahmkow2020-06-274-9/+10
|
* SVC: WaitSynchronization add Termination Pending Result.Fernando Sahmkow2020-06-272-1/+5
|
* Scheduler: Remove arm_interface lock and a few corrections.Fernando Sahmkow2020-06-271-7/+3
|
* SVC: Correct SetThreadActivity.Fernando Sahmkow2020-06-274-38/+59
|
* SCC: Small corrections to CancelSynchronizationFernando Sahmkow2020-06-273-2/+14
|
* Scheduler: Correct locking for hle threads.Fernando Sahmkow2020-06-271-1/+2
|
* Scheduler: Fix HLE Threads on guardFernando Sahmkow2020-06-271-4/+6
|
* Scheduler: Protect on closed threads.Fernando Sahmkow2020-06-271-7/+17
|
* Scheduler: Correct assert.Fernando Sahmkow2020-06-271-4/+2
|
* Core: Correct rebase.Fernando Sahmkow2020-06-271-6/+5
|
* Scheduler: Release old thread fiber before trying to switch to the next thread fiber.Fernando Sahmkow2020-06-272-11/+35
|
* Mutex: Correct Result writting to clear exclusivity.Fernando Sahmkow2020-06-271-3/+11
|
* SVC: Correct svcWaitForAddress and svcSignalToAddress.Fernando Sahmkow2020-06-274-68/+161
|
* Scheduler: Correct Select Threads Step 2.Fernando Sahmkow2020-06-271-0/+1
|
* Kernel: Corrections to Scheduling.Fernando Sahmkow2020-06-273-14/+15
|
* Kernel: Correct Signal on Thread Death and Setup Sync Objects on Thread for DebuggingFernando Sahmkow2020-06-273-15/+17
|
* Core: Correct HLE Event Callbacks and other issues.Fernando Sahmkow2020-06-275-37/+39
|
* Process: Protect TLS region and Modules.Fernando Sahmkow2020-06-271-0/+4
|
* General: Add AssertsFernando Sahmkow2020-06-273-0/+20
|
* General: Add better safety for JIT use.Fernando Sahmkow2020-06-272-1/+8
|
* SVC: Correct races on physical core switching.Fernando Sahmkow2020-06-271-5/+4
|
* SVC: Add locks to the memory management.Fernando Sahmkow2020-06-271-0/+21
|
* SVC: Correct WaitSynchronization, WaitProcessWideKey, SignalProcessWideKey.Fernando Sahmkow2020-06-279-33/+84
|
* SVC: Cleanup old methods.Fernando Sahmkow2020-06-271-13/+9
|
* CPU_Manager: Reconfigre guest threads for dynamrmic downsidesFernando Sahmkow2020-06-272-0/+5
|
* SVC: Correct SendSyncRequest.Fernando Sahmkow2020-06-277-52/+115
|
* SVC: Correct ArbitrateUnlockFernando Sahmkow2020-06-273-33/+37
|
* SVC: Correct SignalEvent, ClearEvent, ResetSignal, WaitSynchronization, CancelSynchronization, ArbitrateLockFernando Sahmkow2020-06-278-90/+134
|
* SVC: Remove global HLE Lock.Fernando Sahmkow2020-06-271-3/+0
|
* SVC: Correct GetThreadPriority, SetThreadPriority, GetThreadCoreMask, SetThreadCoreMask, GetCurrentProcessorNumberFernando Sahmkow2020-06-273-15/+11
|
* SVC: Correct CreateThread, StartThread, ExitThread, SleepThread.Fernando Sahmkow2020-06-273-37/+31
|
* General: Recover Prometheus project from harddrive failure Fernando Sahmkow2020-06-2711-344/+679
| | | | | | | This commit: Implements CPU Interrupts, Replaces Cycle Timing for Host Timing, Reworks the Kernel's Scheduler, Introduce Idle State and Suspended State, Recreates the bootmanager, Initializes Multicore system.
* Merge pull request #4152 from ogniK5377/ipc-errbunnei2020-06-271-25/+22
|\ | | | | Mark invalid IPC buffers as ASSERT_OR_EXECUTE_MSG
| * Mark invalid IPC buffers as ASSERT_OR_EXECUTE_MSGDavid Marcec2020-06-241-25/+22
| | | | | | | | Previously if applications would send faulty buffers(example homebrew) it would lead to us returning uninitalized data. Switching from ASSERT_MSG to ASSERT_OR_EXECUTE_MSG allows us to have a fail safe to prevent crashes but also continue execution without introducing undefined behavior
* | memory_manager: Remove useless assertionDavid Marcec2020-06-251-1/+0
|/ | | | num_pages is an std::size_t. It will always be >= 0
* memory_manager: Explicitly specifcy std::min<size_t>MerryMage2020-06-181-2/+2
|
* Merge pull request #4069 from ogniK5377/total-phys-membunnei2020-06-141-2/+4
|\ | | | | kernel: Account for system resource size for memory usage
| * kernel: Account for system resource size for memory usageDavid Marcec2020-06-101-2/+4
| | | | | | | | GetTotalPhysicalMemoryAvailableWithoutSystemResource & GetTotalPhysicalMemoryUsedWithoutSystemResource seem to subtract the resource size from the usage.
* | Merge pull request #4010 from ogniK5377/reserve-always-breakbunnei2020-06-131-5/+1
|\ \ | |/ |/| kernel: ResourceLimit::Reserve remove useless while loop
| * kernel: ResourceLimit::Reserve remove useless while loopDavid Marcec2020-05-291-5/+1
| | | | | | | | Timeout is a u64, it will always be >= 0
* | Downgrade "handle not signaled" error to traceDavid Marcec2020-06-041-1/+1
|/ | | | clogs logs quite a bit
* Merge pull request #3879 from lioncash/global2bunnei2020-05-083-10/+16
|\ | | | | hle_ipc: Eliminate core memory globals
| * hle_ipc: Eliminate core memory globalsLioncash2020-05-033-10/+16
| | | | | | | | | | We can just pass the required instances into the constructor of the request, eliminating all usages of the global system accessor.
* | Merge pull request #3881 from lioncash/mem-warningbunnei2020-05-0511-23/+11
|\ \ | | | | | | kernel/memory: Resolve several compiler warnings
| * | kernel/memory: Remove #pragma once within cpp fileLioncash2020-05-031-2/+0
| | | | | | | | | | | | This isn't necessary in a cpp file and will cause warnings on clang.
| * | kernel/memory: Remove unused includesLioncash2020-05-037-8/+1
| | | | | | | | | | | | | | | Prevents header churn and needing to recompile these files if these headers are ever changed in the future.
| * | kernel/memory: Remove unused variables in memory_block_managerLioncash2020-05-031-3/+0
| | | | | | | | | | | | Prevents unused variable warnings.
| * | kernel/memory: Make use of std::array consistently in address_space_infoLioncash2020-05-031-6/+6
| | | | | | | | | | | | | | | This allows tuning standard library implementations to enable or disable range checks at runtime, which is nicer for debugging.
| * | kernel/memory: Resolve -Wshadow warningsLioncash2020-05-031-4/+4
| |/ | | | | | | Prevents variable name clashing.
* / kernel/memory: Amend potential encoding warningsLioncash2020-05-036-12/+12
|/ | | | | | | While èis generally representable in some language encodings, in some it isn't and will result in compilation warnings occurring. To remain friendly with other language's codepages on Windows, we normalize it to an ASCII e.
* readable_event: Remove unnecessary semicolon in Signal()Lioncash2020-05-021-4/+6
| | | | | | | Resolves a -Wextra-semi warning. While we're at it, we can invert the branch to form a guard clause, unindenting all of the contained code.
* kernel: Don't fail silentlyDavid Marcec2020-04-297-0/+51
|
* Merge pull request #3783 from lioncash/pointerMat M2020-04-291-1/+3
|\ | | | | physical_core: Make use of std::make_unique instead of std::make_shared in ctor
| * physical_core: Make use of std::make_unique instead of std::make_shared in ctorLioncash2020-04-241-1/+3
| | | | | | | | | | | | | | We can also allow unicorn to be constructed in 32-bit mode or 64-bit mode to satisfy the need for both interpreter instances. Allows this code to compile successfully of non x86-64 architectures.
* | kernel: Bad GetInfo ids should not be marked as stubsDavid Marcec2020-04-281-2/+2
| | | | | | | | As we currently match hardware and don't return a successful result, these should be marked as errors instead of warnings and as stubs.
* | Merge pull request #3780 from lioncash/processbunnei2020-04-251-2/+138
|\ \ | | | | | | svc: Re-add MapProcessCodeMemory/UnmapProcessCodeMemory
| * | svc: Re-add MapProcessCodeMemory/UnmapProcessCodeMemoryLioncash2020-04-241-2/+138
| |/ | | | | | | These were lost in the re-implementation of the virtual memory manager.
* | Merge pull request #3777 from lioncash/warnRodrigo Locatti2020-04-241-2/+2
|\ \ | | | | | | page_table: Remove unused captures
| * | page_table: Remove unused capturesLioncash2020-04-231-2/+2
| |/ | | | | | | | | | | Any time the lambda function is called, the permission being used in the capture would be passed in as an argument to the lambda, so the capture is unnecessary.
* | Merge pull request #3778 from lioncash/unused-varRodrigo Locatti2020-04-241-3/+0
|\ \ | | | | | | svc: Remove unused variable
| * | svc: Remove unused variableLioncash2020-04-231-3/+0
| |/ | | | | | | Since the VMM refactor, this is no longer used or needed.
* / shared_memory: Amend doxygen referenceLioncash2020-04-242-5/+5
|/ | | | | | Amends the parameter to match the documentation reference. Resolves a -Wdocumentation warning with clang.
* kernel: memory: Improve implementation of device shared memory. (#3707)bunnei2020-04-235-3/+105
| | | | | | | * kernel: memory: Improve implementation of device shared memory. * fixup! kernel: memory: Improve implementation of device shared memory. * fixup! kernel: memory: Improve implementation of device shared memory.
* Merge pull request #3725 from MerryMage/fpcrbunnei2020-04-231-2/+1
|\ | | | | thread: FPCR.FZ is likely not 1 (and FPCR.RMode = TieAway and FPCR.DN = 0)
| * thread: FPCR.FZ is likely not 1MerryMage2020-04-191-2/+1
| |
* | Merge pull request #3696 from lioncash/cast-sizebunnei2020-04-192-21/+23
|\ \ | | | | | | hle_ipc: Remove std::size_t casts where applicable
| * | hle_ipc: Remove std::size_t casts where applicableLioncash2020-04-172-21/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | These were added in the change that enabled -Wextra on linux builds so as not to introduce interface changes in the same change as a build-system flag addition. Now that the flags are enabled, we can freely change the interface to make these unnecessary.
* | | memory/slab_heap: Make use of static_cast over reinterpret_castLioncash2020-04-181-2/+2
| | | | | | | | | | | | | | | Casting from void* with static_cast is permitted by the standard, so we can just make use of that instead.
* | | core: hle: Address various feedback & code cleanup.bunnei2020-04-179-236/+139
| | | | | | | | | | | | - Should be no functional changes.
* | | memory: Add copyright notice for Atmosphere where applicable.bunnei2020-04-176-0/+18
| | |
* | | kernel: Remove old VMManager class.bunnei2020-04-172-1971/+0
| | |
* | | kernel: memory: page_table: Simplify GetPhysicalAddr impl.bunnei2020-04-172-5/+3
| | |
* | | kernel: svc: Updates for new VMM.bunnei2020-04-171-488/+116
| | | | | | | | | | | | - Includes removing some SVC impls. that are untested.
* | | kernel: process: Updates for new VMM.bunnei2020-04-172-79/+151
| | |
* | | kernel: resource_limit: Reserve physical memory.bunnei2020-04-171-1/+6
| | |
* | | kernel: Initialize memory layout for new VMM.bunnei2020-04-172-0/+159
| | |
* | | core: system: Rename GetDeviceManager -> DeviceManager.bunnei2020-04-171-1/+1
| | | | | | | | | | | | - More consistent with other system components.
* | | kernel: transfer_memory: Refactor for new VMM.bunnei2020-04-172-130/+16
| | |
* | | kernel: shared_memory: Refactor for new VMM.bunnei2020-04-172-220/+58
| | |
* | | kernel: errors: Add ERR_OUT_OF_RESOURCES.bunnei2020-04-171-0/+1
| | |
* | | kernel: process_capability: Update to use Memory::PageTable.bunnei2020-04-172-23/+25
| | |
* | | kernel: memory: Add PageTable class, to manage process address space.bunnei2020-04-172-0/+1508
| | |
* | | kernel: memory: Add MemoryLayout class, to build physical memory layout.bunnei2020-04-171-0/+73
| | |
* | | kernel: memory: Add MemoryManager class, to manage page heaps.bunnei2020-04-172-0/+274
| | |
* | | kernel: memory: Add MemoryBlockManager class, to manage memory blocks.bunnei2020-04-172-0/+254
| | |
* | | kernel: memory: Add PageHeap class, to manage a heap of pages.bunnei2020-04-172-0/+481
| | |
* | | kernel: memory: Add PageLinkedList class, to manage a list of pages.bunnei2020-04-171-0/+93
| | |
* | | kernel: memory: Add system_control code, which will be used for ASLR support.bunnei2020-04-172-0/+59
| | |
* | | physical_memory: Add missing include for <vector>.bunnei2020-04-171-0/+2
| | |
* | | kernel: memory: Add MemoryBlock class, for managing memory blocks and their state.bunnei2020-04-171-0/+315
| | |
* | | kernel: memory: Add memory_types.h, for things that are commonly used in memory code.bunnei2020-04-171-0/+18
| | |
* | | kernel: memory: Add SlabHeap class, for managing memory heaps.bunnei2020-04-171-0/+161
| | | | | | | | | | | | - This will be used for TLS pages, among other things.
* | | kernel: memory: Add AddressSpaceInfo class, for managing the memory address space.bunnei2020-04-172-0/+164
| | |
* | | core: memory: Move to Core::Memory namespace.bunnei2020-04-178-25/+29
| | | | | | | | | | | | - helpful to disambiguate Kernel::Memory namespace.
* | | core: kernel: Add svc_types header to include SVC-specific types.bunnei2020-04-172-0/+69
| | |
* | | core: kernel: Move SVC to its own namesapce.bunnei2020-04-172-6/+6
| | |
* | | kernel: resource_limit: Improvements to implementation.bunnei2020-04-172-12/+50
| | |
* | | process: SetupMainThread: Zero out argument on process start.bunnei2020-04-171-0/+2
| | |
* | | Merge pull request #3671 from lioncash/switchbunnei2020-04-171-0/+2
|\ \ \ | |/ / |/| | kernel/thread: Resolve -Wswitch warnings
| * | kernel/thread: Resolve -Wswitch warningsLioncash2020-04-151-0/+2
| |/
* | CMakeLists: Specify -Wextra on linux buildsLioncash2020-04-161-12/+12
| | | | | | | | | | | | | | | | | | | | | | Allows reporting more cases where logic errors may exist, such as implicit fallthrough cases, etc. We currently ignore unused parameters, since we currently have many cases where this is intentional (virtual interfaces). While we're at it, we can also tidy up any existing code that causes warnings. This also uncovered a few bugs as well.
* | CMakeLists: Make -Wreorder a compile-time errorLioncash2020-04-151-1/+1
|/ | | | | | This can result in silent logic bugs within code, and given the amount of times these kind of warnings are caused, they should be flagged at compile-time so no new code is submitted with them.
* core: hle: Implement separate A32/A64 SVC interfaces.bunnei2020-03-032-107/+380
|
* core: Implement separate A32/A64 ARM interfaces.bunnei2020-03-038-36/+73
|
* Scheduler: Inline global scheduler in Scheduler Lock.Fernando Sahmkow2020-02-221-4/+2
|
* Kernel: Correct pending feedback.Fernando Sahmkow2020-02-221-3/+4
|
* Kernel: Address Feedback.Fernando Sahmkow2020-02-226-30/+47
|
* Kernel: Implement Scheduler locksFernando Sahmkow2020-02-222-0/+89
|
* Kernel: Implement Time Manager.Fernando Sahmkow2020-02-224-1/+96
|
* Kernel: Rename ThreadCallbackHandleTable and Setup Thread Ids on Kernel.Fernando Sahmkow2020-02-224-24/+105
|
* Kernel: Make global scheduler depend on KernelCoreFernando Sahmkow2020-02-224-8/+24
|
* Merge pull request #3401 from FernandoS27/synchronizationbunnei2020-02-1425-166/+314
|\ | | | | Set of refactors for Kernel Synchronization and Hardware Constants
| * Core: Address FeedbackFernando Sahmkow2020-02-145-16/+27
| |
| * Core: Set all hardware emulation constants in a single file.Fernando Sahmkow2020-02-123-19/+21
| |
| * Kernel: Refactor synchronization to better match REFernando Sahmkow2020-02-1122-80/+210
| |
| * Kernel: Change WaitObject to Synchronization object. In order to better reflect RE.Fernando Sahmkow2020-02-1119-71/+76
| |
* | address_arbiter: Collapse loops in InsertThread() and RemoveThread()Lioncash2020-02-121-19/+17
| | | | | | | | | | Same behavior, but without the need to explicitly loop through everything manually.
* | address_arbiter: Simplify GetThreadsWaitingOnAddress()Lioncash2020-02-122-10/+9
| | | | | | | | | | Simplifies the overall function and also allows for it to become a const-qualified member function.
* | kernel/thread: Remove trivial usages of the global system accessorLioncash2020-02-121-2/+2
|/ | | | | We can just use the kernel member variable directly instead of going through the system to obtain the same thing.
* Merge pull request #3381 from bunnei/ipc-fixbunnei2020-02-071-8/+42
|\ | | | | hle: services: Fix prepo IPC, and add better error checking.
| * hle_ipc: Add error checking to read/write buffer access.bunnei2020-02-061-8/+42
| |
* | kernel: transfer_memory: Properly reserve and reset memory region.bunnei2020-02-065-40/+116
| |
* | wait_object: Make wait behavior only require one object to signal.Zach Hilman2020-02-061-11/+2
|/ | | | - This was holdover from citra.
* kernel/physical_core: Make use of std::unique_ptrLioncash2020-01-312-4/+10
| | | | | | | | | | | | | | | | | | shared_ptr was used in 2d1984c20c75e03ec79eeb3806b12efa1679b977 due to a misunderstanding of how the language generates move constructors and move assignment operators. If a destructor is user-provided, then the compiler won't generate the move constructor and move assignment operators by default--they must be explicitly opted into. The reason for the compilation errors is due to the fact that the language will fall back to attempting to use the copy constructor/copy assignment operators if the respective move constructor or move assignment operator is unavailable. Given that we explicitly opt into them now, the the move constructor and move assignment operators will be generated as expected.
* kernel/physical_core: Remove unused kernel reference member variableLioncash2020-01-313-11/+7
| | | | | | | This isn't used within the class, so it can be removed to simplify the overall interface. While we're in the same area, we can simplify a unique_ptr reset() call.
* System: Address FeedbackFernando Sahmkow2020-01-274-10/+20
|
* Kernel: Remove a few global instances from the kernel.Fernando Sahmkow2020-01-262-2/+2
|
* Core: Refactor CpuCoreManager to CpuManager and Cpu to Core Manager.Fernando Sahmkow2020-01-265-6/+2
| | | | This commit instends on better naming the new purpose of this classes.
* ArmInterface: Delegate Exclusive monitor factory to exclusive monitor interfasce.Fernando Sahmkow2020-01-261-15/+2
|
* Core: Refactor CPU Management.Fernando Sahmkow2020-01-254-12/+127
| | | | This commit moves ARM Interface and Scheduler handling into the kernel.
* Kernel: Implement Physical Core.Fernando Sahmkow2020-01-242-0/+81
|
* core/memory: Create a special MapMemoryRegion for physical memory.Markus Wick2020-01-182-3/+5
| | | | This allows us to create a fastmem arena within the memory.cpp helpers.
* core/hle: Simplify PhysicalMemory usage in vm_manager.Markus Wick2020-01-181-23/+11
|
* core/kernel: Fix GetTotalPhysicalMemoryUsed.Markus Wick2020-01-111-2/+2
| | | | | | | | | module._memory was already moved over to a new shared_ptr. So code_memory_size was not increased at all. This lowers the heap space and so saves a bit of memory, usually between 50 to 100 MB. This fixes a regression of c0a01f3adc466d07fc27020048e82cca60988970
* Merge pull request #3214 from lioncash/svc-funcbunnei2019-12-132-9/+6
|\ | | | | kernel/svc: Amend function signature of SignalProcessWideKey
| * kernel/svc: Correct function signature of SignalProcessWideKeyLioncash2019-12-112-9/+6
| | | | | | | | | | This function doesn't actually return a result code, so we can amend the signature of it to match.
* | Kernel: Correct behavior of Address Arbiter threads. (#3165)Fernando Sahmkow2019-12-113-24/+67
|/ | | | | | | | | | | * Kernel: Correct behavior of Address Arbiter threads. This corrects arbitration threads to behave just like in Horizon OS. They are added into a container and released according to what priority they had when added. Horizon OS does not reorder them if their priority changes. * Kernel: Address Feedback.
* Merge pull request #3201 from lioncash/dumpbunnei2019-12-112-2/+24
|\ | | | | kernel/svc: Provide implementations for svcDumpInfo/svcDumpInfoNew
| * kernel/svc: Provide implementations for svcDumpInfo/svcDumpInfoNewLioncash2019-12-082-2/+24
| | | | | | | | | | | | | | | | | | These are fairly trivial to implement, we can just do nothing. This also provides a spot for us to potentially dump out any relevant info in the future (e.g. for debugging purposes with homebrew, etc). While we're at it, we can also correct the names of both of these supervisor calls.
* | kernel: Remove unnecessary includesLioncash2019-12-0815-11/+17
|/ | | | | | Over the course of the changes to the kernel code, a few includes are no longer necessary, particularly with the change over to std::shared_ptr from Boost's intrusive_ptr.
* CpuCore: Clear exclusive state after doing a run in dynarmic.Fernando Sahmkow2019-12-051-1/+0
| | | | | | This commit corrects an error in which a Core could remain with an exclusive state after running, leaving space for possible race conditions between changing cores.
* kernel: Implement a more accurate IPC dispatch.bunnei2019-11-2812-142/+214
|
* core/memory; Migrate over SetCurrentPageTable() to the Memory classLioncash2019-11-271-7/+11
| | | | | | | Now that literally every other API function is converted over to the Memory class, we can just move the file-local page table into the Memory implementation class, finally getting rid of global state within the memory code.
* core/memory: Migrate over Write{8, 16, 32, 64, Block} to the Memory classLioncash2019-11-274-21/+25
| | | | | | | | | The Write functions are used slightly less than the Read functions, which make these a bit nicer to move over. The only adjustments we really need to make here are to Dynarmic's exclusive monitor instance. We need to keep a reference to the currently active memory instance to perform exclusive read/write operations.
* core/memory: Migrate over Read{8, 16, 32, 64, Block} to the Memory classLioncash2019-11-274-22/+36
| | | | | | | | | | | | | | With all of the trivial parts of the memory interface moved over, we can get right into moving over the bits that are used. Note that this does require the use of GetInstance from the global system instance to be used within hle_ipc.cpp and the gdbstub. This is fine for the time being, as they both already rely on the global system instance in other functions. These will be removed in a change directed at both of these respectively. For now, it's sufficient, as it still accomplishes the goal of de-globalizing the memory code.
* core/memory: Migrate over ReadCString() to the Memory classLioncash2019-11-271-2/+4
| | | | | This only had one usage spot, so this is fairly straightforward to convert over.
* core/memory: Migrate over GetPointer()Lioncash2019-11-271-1/+2
| | | | | With all of the interfaces ready for migration, it's trivial to migrate over GetPointer().
* core: Prepare various classes for memory read/write migrationLioncash2019-11-275-6/+18
| | | | | | | | | | Amends a few interfaces to be able to handle the migration over to the new Memory class by passing the class by reference as a function parameter where necessary. Notably, within the filesystem services, this eliminates two ReadBlock() calls by using the helper functions of HLERequestContext to do that for us.
* core/memory: Migrate over address checking functions to the new Memory classLioncash2019-11-273-8/+8
| | | | | | | | | A fairly straightforward migration. These member functions can just be mostly moved verbatim with minor changes. We already have the necessary plumbing in places that they're used. IsKernelVirtualAddress() can remain a non-member function, since it doesn't rely on class state in any form.
* core/memory: Migrate over memory mapping functions to the new Memory classLioncash2019-11-271-6/+7
| | | | | | Migrates all of the direct mapping facilities over to the new memory class. In the process, this also obsoletes the need for memory_setup.h, so we can remove it entirely from the project.
* core_timing: Use better reference tracking for EventType. (#3159)bunnei2019-11-272-7/+8
| | | | | | | * core_timing: Use better reference tracking for EventType. - Moves ownership of the event to the caller, ensuring we don't fire events for destroyed objects. - Removes need for unique names - we won't be using this for save states anyways.
* kernel: Fix reference management for client/server session.bunnei2019-11-263-20/+18
| | | | - Fixes shutdown crash and crash in Pokemon SwSh.
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. (#3154)bunnei2019-11-2536-299/+301
| | | | | | * kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. - See https://github.com/citra-emu/citra/pull/4710 for details.
* Update svc.cppbunnei2019-11-231-0/+1
|
* svc: GetSystemTick should return cntpct_el0, not core ticks.bunnei2019-11-231-1/+3
|
* Merge pull request #3114 from FernandoS27/cond-varbunnei2019-11-235-22/+74
|\ | | | | Kernel: Correct behavior of Condition Variables to be more similar to real hardware.
| * Kernel: Optimize condition variable threads management.Fernando Sahmkow2019-11-214-24/+21
| |
| * Kernel: Correct SignalProcessWideKeyFernando Sahmkow2019-11-211-6/+2
| | | | | | | | When the target is 0, all threads must be processed.
| * Kernel: Correct behavior of Condition Variables to be more similar to real hardware.Fernando Sahmkow2019-11-215-15/+74
| | | | | | | | | | | | | | This commit ensures cond var threads act exactly as they do in the real console. The original implementation uses an RBTree and the behavior of cond var threads is that at the same priority level they act like a FIFO.
* | Merge pull request #3130 from FernandoS27/cancel-syncbunnei2019-11-233-2/+19
|\ \ | |/ |/| Kernel: Correct Cancel Synchronization.
| * Kernel: Correct Cancel Synchronization.Fernando Sahmkow2019-11-163-2/+19
| | | | | | | | | | | | This commit corrects the behavior of cancel synchronization when the thread is running/ready and ensures the next wait is cancelled as it's suppose to.
* | kernel: Resolve sign conversion warningsLioncash2019-11-124-72/+60
|/ | | | | | | | | Uncovered a bug within Thread's SetCoreAndAffinityMask() where an unsigned variable (ideal_core) was being compared against "< 0", which would always be a false condition. We can also get rid of an unused function (GetNextProcessorId) which contained a sign mismatch warning.
* kernel: readable_event: Signal only once.bunnei2019-11-031-2/+4
|
* kernel: events: Remove ResetType::Automatic.bunnei2019-11-037-29/+4
| | | | | | | | - This does not actually seem to exist in the real kernel - games reset these automatically. # Conflicts: # src/core/hle/service/am/applets/applets.cpp # src/core/hle/service/filesystem/fsp_srv.cpp
* kernel: readable_event: Initialize members.bunnei2019-11-031-1/+1
|
* scheduler: Mark parameter of AskForReselectionOrMarkRedundant() as constLioncash2019-10-282-5/+5
| | | | This is only compared against, so it can be made const.
* scheduler: Silence sign conversion warningsLioncash2019-10-281-5/+5
|
* scheduler: Initialize class members directly where applicableLioncash2019-10-282-6/+4
| | | | Reduces the overall amount of code.
* scheduler: Amend documentation commentsLioncash2019-10-282-75/+59
| | | | | Adjusts the formatting of a few of the comments an ensures they get recognized as proper Doxygen comments.
* Kernel Thread: Cleanup THREADPROCESSORID_DONT_UPDATE.Fernando Sahmkow2019-10-152-4/+1
|
* Kernel: Address Feedback 2Fernando Sahmkow2019-10-152-9/+6
|
* Kernel: Clang FormatFernando Sahmkow2019-10-152-5/+5
|
* Kernel: Reverse global accessor removal.Fernando Sahmkow2019-10-154-23/+9
|
* Kernel: Address Feedback.Fernando Sahmkow2019-10-156-67/+98
|
* Kernel Scheduler: Make sure the global scheduler shutdowns correctly.Fernando Sahmkow2019-10-153-0/+17
|
* Kernel_Thread: Eliminate most global accessors.Fernando Sahmkow2019-10-151-11/+11
|
* KernelSVC: Assert that condition variable address is aligned to 4 bytes.Fernando Sahmkow2019-10-151-0/+4
|
* Kernel: Correct Paused schedulingFernando Sahmkow2019-10-151-3/+1
|
* Kernel: Corrections to Wait Objects clearing in which a thread could still be signalled after a timeout or a cancel.Fernando Sahmkow2019-10-153-3/+4
|
* Kernel: Correct redundant yields to only advance time forward.Fernando Sahmkow2019-10-151-3/+5
|
* Kernel: Corrections to ModifyByWaitingCountAndSignalToAddressIfEqualFernando Sahmkow2019-10-151-5/+13
|
* Kernel: Correct Results in Condition Variables and MutexesFernando Sahmkow2019-10-153-24/+17
|
* Kernel: Clang FormatFernando Sahmkow2019-10-152-2/+3
|
* Kernel: Remove global system accessor from WaitObjectFernando Sahmkow2019-10-154-2/+17
|
* Scheduler: Implement Yield Count and Core migration on Thread Preemption.Fernando Sahmkow2019-10-152-5/+85
|
* Scheduler: Corrections to YieldAndBalanceLoad and Yield bombing protection.Fernando Sahmkow2019-10-152-8/+8
|
* Kernel: Initial implementation of thread preemption.Fernando Sahmkow2019-10-153-0/+30
|
* Scheduler: Add protections for Yield bombingFernando Sahmkow2019-10-155-24/+31
| | | | | | In case of redundant yields, the scheduler will now idle the core for it's timeslice, in order to avoid continuously yielding the same thing over and over.
* Kernel: Style and CorrectionsFernando Sahmkow2019-10-158-90/+130
|
* Correct PrepareRescheduleFernando Sahmkow2019-10-153-37/+20
|
* Comment and reorganize the schedulerFernando Sahmkow2019-10-152-98/+104
|
* Add PrepareReschedule where required.Fernando Sahmkow2019-10-153-16/+18
|
* Correct compiling errors and addapt to the new interface.Fernando Sahmkow2019-10-151-4/+1
|
* Correct Supervisor Calls to work with the new scheduler,Fernando Sahmkow2019-10-151-26/+41
|
* Add interfacing to the Global SchedulerFernando Sahmkow2019-10-152-0/+17
|
* Addapt thread class to the new SchedulerFernando Sahmkow2019-10-152-60/+237
|
* Implement a new Core SchedulerFernando Sahmkow2019-10-152-258/+411
|
* core: Remove Core::CurrentProcess()Lioncash2019-10-061-1/+1
| | | | | | This only encourages the use of the global system instance (which will be phased out long-term). Instead, we use the direct system function call directly to remove the appealing but discouraged short-hand.
* kernel/vm_manager: Correct doxygen comment parameter tags for MapPhysicalMemory/UnmapPhysicalMemoryLioncash2019-09-051-4/+4
| | | | | Corrects the parameter names within the doxygen comments so that they resolve properly.
* kernel/vm_manager: Move variables closer to usage spots in MapPhysicalMemory/UnmapPhysicalMemoryLioncash2019-09-051-16/+10
| | | | Narrows the scope of variables down to where they're only necessary.
* kernel/vm_manager: Correct behavior in failure case of UnmapPhysicalMemory()Lioncash2019-08-301-0/+2
| | | | | | If an unmapping operation fails, we shouldn't be decrementing the amount of memory mapped and returning that the operation was successful. We should actually be returning the error code in this case.
* kernel/vm_manager: Reserve memory ahead of time for slow path in MergeAdjacentVMALioncash2019-08-301-1/+4
| | | | | | | Avoids potentially expensive (depending on the size of the memory block) allocations by reserving the necessary memory before performing both insertions. This avoids scenarios where the second insert may cause a reallocation to occur.
* kernel/vm_manager: std::move shared_ptr instance in MergeAdjacentVMALioncash2019-08-301-1/+1
| | | | Avoids an unnecessary atomic reference count increment and decrement.
* kernel/vm_manager: Deduplicate iterator creation in MergeAdjacentVMALioncash2019-08-301-7/+10
| | | | | | Avoids needing to read the same long sequence of code in both code paths. Also makes it slightly nicer to read and debug, as the locals will be able to be shown in the debugger.
* kernel/vm_manager: Simplify some std::vector constructor callsLioncash2019-08-301-2/+2
| | | | Same behavior, one less magic constant to read.
* kernel/vm_manager: Simplify some assertion messagesLioncash2019-08-301-10/+10
| | | | | Assertions already log out the function name, so there's no need to manually include the function name in the assertion strings.
* Kernel: Address FeedbackFernando Sahmkow2019-07-192-3/+9
|
* VM_Manager: Align allocated memory to 256bytesFernando Sahmkow2019-07-199-26/+42
| | | | | | This commit ensures that all backing memory allocated for the Guest CPU is aligned to 256 bytes. This due to how gpu memory works and the heavy constraints it has in the alignment of physical memory.
* Merge pull request #2687 from lioncash/tls-processbunnei2019-07-183-14/+30
|\ | | | | kernel/process: Allocate the process' TLS region during initialization
| * kernel/process: Allocate the process' TLS region during initializationLioncash2019-07-073-3/+14
| | | | | | | | | | | | | | | | | | | | | | Prior to execution within a process beginning, the process establishes its own TLS region for uses (as far as I can tell) related to exception handling. Now that TLS creation was decoupled from threads themselves, we can add this behavior to our Process class. This is also good, as it allows us to remove a stub within svcGetInfo, namely querying the address of that region.
| * kernel/process: Move main thread stack allocation to its own functionLioncash2019-07-072-12/+17
| | | | | | | | Keeps this particular set of behavior isolated to its own function.
* | Kernel: Downgrade WaitForAddress and SignalToAddress messages to Trace.Fernando Sahmkow2019-07-181-4/+4
| | | | | | | | | | This messages were originally set as warnning since few games used these svcs and it was needed for debugging. This is no longer the case.
* | Merge pull request #2690 from SciresM/physmem_fixesFernando Sahmkow2019-07-146-40/+470
|\ \ | | | | | | Implement MapPhysicalMemory/UnmapPhysicalMemory
| * | Remove unicorn mappings/unmappingsMichael Scire2019-07-121-19/+0
| | |
| * | Prevent merging of device mapped memory blocks.Michael Scire2019-07-091-0/+5
| | | | | | | | | | | | | | | | | | | | | This sets the DeviceMapped attribute for GPU-mapped memory blocks, and prevents merging device mapped blocks. This prevents memory mapped from the gpu from having its backing address changed by block coalesce.
| * | Remove unused member function declarationMichael Scire2019-07-071-9/+0
| | |
| * | physmem: add helpers, cleanup logic.Michael Scire2019-07-072-171/+170
| | |
| * | clang-format fixesMichael Scire2019-07-072-3/+3
| | |
| * | address review commentaryMichael Scire2019-07-075-36/+42
| | |
| * | Implement MapPhysicalMemory/UnmapPhysicalMemoryMichael Scire2019-07-076-20/+468
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This implements svcMapPhysicalMemory/svcUnmapPhysicalMemory for Yuzu, which can be used to map memory at a desired address by games since 3.0.0. It also properly parses SystemResourceSize from NPDM, and makes information available via svcGetInfo. This is needed for games like Super Smash Bros. and Diablo 3 -- this PR's implementation does not run into the "ASCII reads" issue mentioned in the comments of #2626, which was caused by the following bugs in Yuzu's memory management that this PR also addresses: * Yuzu's memory coalescing does not properly merge blocks. This results in a polluted address space/svcQueryMemory results that would be impossible to replicate on hardware, which can lead to game code making the wrong assumptions about memory layout. * This implements better merging for AllocatedMemoryBlocks. * Yuzu's implementation of svcMirrorMemory unprotected the entire virtual memory range containing the range being mirrored. This could lead to games attempting to map data at that unprotected range/attempting to access that range after yuzu improperly unmapped it. * This PR fixes it by simply calling ReprotectRange instead of Reprotect.
* | Merge pull request #2717 from SciresM/unmirror_memorybunnei2019-07-111-1/+8
|\ \ | | | | | | Restore memory perms on svcUnmapMemory/UnloadNro
| * | Restore memory perms on svcUnmapMemory/UnloadNroMichael Scire2019-07-111-1/+8
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prior to PR, Yuzu did not restore memory to RW- on unmap of mirrored memory or unloading of NRO. (In fact, in the NRO case, the memory was unmapped instead of reprotected to --- on Load, so it was actually lost entirely...) This PR addresses that, and restores memory to RW- as it should. This fixes a crash in Super Smash Bros when creating a World of Light save for the first time, and possibly other games/circumstances.
* / core/arm: Remove obsolete Unicorn memory mappingLioncash2019-07-111-20/+0
|/ | | | | | | | This was initially necessary when AArch64 JIT emulation was in its infancy and all memory-related instructions weren't implemented. Given the JIT now has all of these facilities implemented, we can remove these functions from the CPU interface.
* kernel/vm_manager: Rename 'new map' to 'stack'Lioncash2019-07-063-37/+37
| | | | | | Provides a more accurate name for the memory region and also disambiguates between the map and new map regions of memory, making it easier to understand.
* kernel/vm_manager: Handle stack/TLS IO region placement betterLioncash2019-07-061-2/+13
| | | | | | | | | | | | | | | Handles the placement of the stack a little nicer compared to the previous code, which was off in a few ways. e.g. The stack (new map) region, shouldn't be the width of the entire address space if the size of the region calculation ends up being zero. It should be placed at the same location as the TLS IO region and also have the same size. In the event the TLS IO region contains a size of zero, we should also be doing the same thing. This fixes our memory layout a little bit and also resolves some cases where assertions can trigger due to the memory layout being incorrect.
* kernel/process: Default initialize all member variablesLioncash2019-07-041-2/+2
| | | | | Ensures a Process instance is always created with a deterministic initial state.
* kernel/process: Decouple TLS handling from threadsLioncash2019-07-044-66/+97
| | | | | | | | | | | Extracts out all of the thread local storage management from thread instances themselves and makes the owning process handle the management of the memory. This brings the memory management slightly more in line with how the kernel handles these allocations. Furthermore, this also makes the TLS page management a little more readable compared to the lingering implementation that was carried over from Citra.
* kernel/vm_manager: Add overload of FindFreeRegion() that operates on a boundaryLioncash2019-07-042-13/+49
| | | | | | | | | | This will be necessary for making our TLS slot management slightly more straightforward. This can also be utilized for other purposes in the future. We can implement the existing simpler overload in terms of this one anyways, we just pass the beginning and end of the ASLR region as the boundaries.
* Merge pull request #2583 from FernandoS27/core-timing-safebunnei2019-06-301-3/+3
|\ | | | | Core_Timing: Make core_timing threadsafe by default.
| * Core_Timing: Make core_timing threadsafe by default.Fernando Sahmkow2019-06-161-3/+3
| | | | | | | | | | | | The old implementation had faulty Threadsafe methods where events could be missing. This implementation unifies unsafe/safe methods and makes core timing thread safe overall.
* | Merge pull request #2575 from DarkLordZach/process-id-typesbunnei2019-06-214-8/+25
|\ \ | | | | | | kernel: Differentiate kernel and user processes when picking ID
| * | kernel: Differentiate kernel and user processes when picking IDZach Hilman2019-06-104-8/+25
| |/ | | | | | | This allows kernel internal type processes to be assigned IDs in the KIP range while userland processes are assigned in the user range.
* | Merge pull request #2482 from DarkLordZach/prepobunnei2019-06-211-1/+7
|\ \ | | | | | | core: Add detailed local reporting feature for development
| * | svc: Save report on call to svcBreakZach Hilman2019-05-251-1/+7
| | |
* | | kernel/vm_manager: Remove redundant Reset call in destructorLioncash2019-06-121-3/+1
| |/ |/| | | | | | | | | | | | | | | This is performing more work than would otherwise be necessary during VMManager's destruction. All we actually want to occur in this scenario is for any allocated memory to be freed, which will happen automatically as the VMManager instance goes out of scope. Anything else being done is simply unnecessary work.
* | Merge pull request #2571 from lioncash/refZach Hilman2019-06-102-2/+2
|\ \ | | | | | | kernel/process: Make Create()'s name parameter be taken by value
| * | kernel/process: Make Create()'s name parameter be taken by valueLioncash2019-06-102-2/+2
| | | | | | | | | | | | | | | Makes the interface more flexible in terms of how Create() may be called, while still allowing the parameter itself to be moved into.
* | | kernel/svc: Implement TotalMemoryUsedWithoutMmHeap/TotalMemoryAvailableWithoutMmHeapLioncash2019-06-103-2/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | Given we don't currently implement the personal heap yet, the existing memory querying functions are essentially doing what the memory querying types introduced in 6.0.0 do. So, we can build the necessary machinery over the top of those and just use them as part of info types.
* | | kernel/svc: Amend naming for TotalMemoryUsage in svcGetInfo()Lioncash2019-06-103-6/+6
| | | | | | | | | | | | | | | Disambiguates and makes the name a little more consistent with TotalPhysicalMemoryUsed.
* | | kernel/svc: Remove duplicate enum entry in svcGetInfo()Lioncash2019-06-101-2/+1
|/ /
* | Merge pull request #2549 from lioncash/headerZach Hilman2019-06-061-1/+0
|\ \ | | | | | | kernel/process: Remove unused boost header include
| * | kernel/process: Remove unused boost header includeLioncash2019-06-051-1/+0
| |/ | | | | | | | | Boost headers typically include a lot of other headers, so removing this can prevent a bit of unnecessary compiler churn when building.
* / core/core_timing_util: Use std::chrono types for specifying time unitsLioncash2019-06-051-2/+2
|/ | | | | Makes the interface more type-safe and consistent in terms of return values.
* Merge pull request #2489 from FearlessTobi/port-4716bunnei2019-05-253-8/+9
|\ | | | | Port citra-emu/citra#4716: "HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThread"
| * Address review commentTobias2019-05-191-1/+1
| | | | | | Co-Authored-By: Mat M. <mathew1800@gmail.com>
| * HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThreadWeiyi Wang2019-05-183-8/+9
| | | | | | | | This reduces the boilerplate that services have to write out the current thread explicitly. Using current thread instead of client thread is also semantically incorrect, and will be a problem when we implement multicore (at which time there will be multiple current threads)
* | Merge pull request #2410 from lioncash/affinitybunnei2019-05-192-42/+58
|\ \ | | | | | | kernel/svc: Reorganize and fix up the initial handling of svcSetThreadCoreMask()
| * | kernel/svc: Make svcCreateThread/svcStartThread/svcSleepThread/svcExitThread calls show up in the debug logLioncash2019-04-291-4/+4
| | | | | | | | | | | | | | | | | | These are actually quite important indicators of thread lifetimes, so they should be going into the debug log, rather than being treated as misc info and delegated to the trace log.
| * | kernel/svc: Reorganize svcSetThreadCoreMask()Lioncash2019-04-291-32/+39
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes the code much nicer to follow in terms of behavior and control flow. It also fixes a few bugs in the implementation. Notably, the thread's owner process shouldn't be accessed in order to retrieve the core mask or ideal core. This should be done through the current running process. The only reason this bug wasn't encountered yet is because we currently only support running one process, and thus every owner process will be the current process. We also weren't checking against the process' CPU core mask to see if an allowed core is specified or not. With this out of the way, it'll be less noisy to implement proper handling of the affinity flags internally within the kernel thread instances.
| * | kernel/thread: Update thread processor ID flagsLioncash2019-04-292-7/+16
| | | | | | | | | | | | Adds the missing flags to the enum and documents them.
* | | Merge pull request #2486 from lioncash/resetnameSebastian Valle2019-05-194-5/+6
|\ \ \ | | | | | | | | core/kernel/object: Rename ResetType enum members for clarity
| * | | core/kernel/object: Rename ResetType enum membersLioncash2019-05-184-5/+6
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Renames the members to more accurately indicate what they signify. "OneShot" and "Sticky" are kind of ambiguous identifiers for the reset types, and can be kind of misleading. Automatic and Manual communicate the kind of reset type in a clearer manner. Either the event is automatically reset, or it isn't and must be manually cleared. The "OneShot" and "Sticky" terminology is just a hold-over from Citra where the kernel had a third type of event reset type known as "Pulse". Given the Switch kernel only has two forms of event reset types, we don't need to keep the old terminology around anymore.
* / | kernel/svc: Mark GetThreadList() and UnmapProcessCodeMemory() as internally linkedLioncash2019-05-191-4/+4
|/ / | | | | | | | | | | These are only used from within this translation unit, so they don't need to have external linkage. They were intended to be marked with this anyways to be consistent with the other service functions.
* | Merge pull request #2412 from lioncash/systembunnei2019-04-293-7/+11
|\ \ | | | | | | kernel/vm_manager: Remove usages of global system accessors
| * | kernel/vm_manager: Remove usages of global system accessorsLioncash2019-04-173-7/+11
| | | | | | | | | | | | | | | Makes the dependency on the system instance explicit within VMManager's interface.
* | | Merge pull request #2416 from lioncash/waitbunnei2019-04-256-44/+50
|\ \ \ | | | | | | | | kernel/svc: Clean up wait synchronization related functionality
| * | | kernel/thread: Unify wait synchronization typesLioncash2019-04-176-38/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a holdover from Citra, where the 3DS has both WaitSynchronization1 and WaitSynchronizationN. The switch only has one form of wait synchronizing (literally WaitSynchonization). This allows us to throw out code that doesn't apply at all to the Switch kernel. Because of this unnecessary dichotomy within the wait synchronization utilities, we were also neglecting to properly handle waiting on multiple objects. While we're at it, we can also scrub out any lingering references to WaitSynchronization1/WaitSynchronizationN in comments, and change them to WaitSynchronization (or remove them if the mention no longer applies).
| * | | kernel/svc: Migrate svcCancelSynchronization behavior to a thread functionLioncash2019-04-173-7/+17
| |/ / | | | | | | | | | | | | | | | | | | The actual behavior of this function is slightly more complex than what we're currently doing within the supervisor call. To avoid dumping most of this behavior in the supervisor call itself, we can migrate this to another function.
* | | Merge pull request #2415 from lioncash/constbunnei2019-04-202-2/+2
|\ \ \ | | | | | | | | kernel/wait_object: Make GetHighestPriorityReadyThread() a const member function
| * | | kernel/wait_object: Make GetHighestPriorityReadyThread() a const member functionLioncash2019-04-172-2/+2
| |/ / | | | | | | | | | | | | This doesn't actually modify internal state of a wait object, so it can be const qualified.
* | | Merge pull request #2421 from lioncash/svc-callbunnei2019-04-201-1/+1
|\ \ \ | | | | | | | | kernel/svc: Name supervisor call 0x36
| * | | kernel/svc: Name supervisor call 0x36Lioncash2019-04-191-1/+1
| | | | | | | | | | | | | | | | | | | | This call was added to the SVC handlers in the 8.0.0 kernel, so we can finally give it a name.
* | | | Merge pull request #2374 from lioncash/pagetablebunnei2019-04-203-14/+17
|\ \ \ \ | |/ / / |/| | | core: Reorganize boot order
| * | | core/core: Move process execution start to System's Load()Lioncash2019-04-122-8/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This gives us significantly more control over where in the initialization process we start execution of the main process. Previously we were running the main process before the CPU or GPU threads were initialized (not good). This amends execution to start after all of our threads are properly set up.
| * | | core/process: Remove unideal page table setting from LoadFromMetadata()Lioncash2019-04-121-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Initially required due to the split codepath with how the initial main process instance was initialized. We used to initialize the process like: Init() { main_process = Process::Create(...); kernel.MakeCurrentProcess(main_process.get()); } Load() { const auto load_result = loader.Load(*kernel.GetCurrentProcess()); if (load_result != Loader::ResultStatus::Success) { // Handle error here. } ... } which presented a problem. Setting a created process as the main process would set the page table for that process as the main page table. This is fine... until we get to the part that the page table can have its size changed in the Load() function via NPDM metadata, which can dictate either a 32-bit, 36-bit, or 39-bit usable address space. Now that we have full control over the process' creation in load, we can simply set the initial process as the main process after all the loading is done, reflecting the potential page table changes without any special-casing behavior. We can also remove the cache flushing within LoadModule(), as execution wouldn't have even begun yet during all usages of this function, now that we have the initialization order cleaned up.
| * | | core/cpu_core_manager: Create threads separately from initialization.Lioncash2019-04-122-2/+7
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our initialization process is a little wonky than one would expect when it comes to code flow. We initialize the CPU last, as opposed to hardware, where the CPU obviously needs to be first, otherwise nothing else would work, and we have code that adds checks to get around this. For example, in the page table setting code, we check to see if the system is turned on before we even notify the CPU instances of a page table switch. This results in dead code (at the moment), because the only time a page table switch will occur is when the system is *not* running, preventing the emulated CPU instances from being notified of a page table switch in a convenient manner (technically the code path could be taken, but we don't emulate the process creation svc handlers yet). This moves the threads creation into its own member function of the core manager and restores a little order (and predictability) to our initialization process. Previously, in the multi-threaded cases, we'd kick off several threads before even the main kernel process was created and ready to execute (gross!). Now the initialization process is like so: Initialization: 1. Timers 2. CPU 3. Kernel 4. Filesystem stuff (kind of gross, but can be amended trivially) 5. Applet stuff (ditto in terms of being kind of gross) 6. Main process (will be moved into the loading step in a following change) 7. Telemetry (this should be initialized last in the future). 8. Services (4 and 5 should ideally be alongside this). 9. GDB (gross. Uses namespace scope state. Needs to be refactored into a class or booted altogether). 10. Renderer 11. GPU (will also have its threads created in a separate step in a following change). Which... isn't *ideal* per-se, however getting rid of the wonky intertwining of CPU state initialization out of this mix gets rid of most of the footguns when it comes to our initialization process.
* | | Merge pull request #2397 from lioncash/thread-unusedbunnei2019-04-183-18/+17
|\ \ \ | |_|/ |/| | kernel/thread: Remove unused guest_handle member variable
| * | svc: Specify handle value in thread's nameLioncash2019-04-152-2/+10
| | | | | | | | | | | | Allows the handle to be seen alongside the entry point.
| * | kernel/thread: Remove unused guest_handle member variableLioncash2019-04-143-16/+7
| |/ | | | | | | | | | | This member variable is entirely unused. It was only set but never actually utilized. Given that, we can remove it to get rid of noise in the thread interface.
* | Merge pull request #2393 from lioncash/svcbunnei2019-04-164-2/+274
|\ \ | | | | | | kernel/svc: Implement svcMapProcessCodeMemory/svcUnmapProcessCodeMemory
| * | kernel/svc: Implement svcUnmapProcessCodeMemoryLioncash2019-04-133-1/+143
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Essentially performs the inverse of svcMapProcessCodeMemory. This unmaps the aliasing region first, then restores the general traits of the aliased memory. What this entails, is: - Restoring Read/Write permissions to the VMA. - Restoring its memory state to reflect it as a general heap memory region. - Clearing the memory attributes on the region.
| * | kernel/svc: Implement svcMapProcessCodeMemoryLioncash2019-04-134-1/+131
| |/ | | | | | | | | This is utilized for mapping code modules into memory. Notably, the ldr service would call this in order to map objects into memory.
* / kernel/thread: Remove BoostPriority()Lioncash2019-04-152-11/+0
|/ | | | | This is a holdover from Citra that currently remains unused, so it can be removed from the Thread interface.
* Merge pull request #2360 from lioncash/svc-globalbunnei2019-04-123-322/+373
|\ | | | | kernel/svc: Deglobalize the supervisor call handlers
| * kernel/svc: Deglobalize the supervisor call handlersLioncash2019-04-083-322/+373
| | | | | | | | | | | | | | | | | | | | | | Adjusts the interface of the wrappers to take a system reference, which allows accessing a system instance without using the global accessors. This also allows getting rid of all global accessors within the supervisor call handling code. While this does make the wrappers themselves slightly more noisy, this will be further cleaned up in a follow-up. This eliminates the global system accessors in the current code while preserving the existing interface.
* | Merge pull request #2388 from lioncash/constexprbunnei2019-04-1210-10/+10
|\ \ | | | | | | kernel: Make handle type declarations constexpr
| * | kernel: Make handle type declarations constexprLioncash2019-04-1110-10/+10
| | | | | | | | | | | | | | | | | | | | | Some objects declare their handle type as const, while others declare it as constexpr. This makes the const ones constexpr for consistency, and prevent unexpected compilation errors if these happen to be attempted to be used within a constexpr context.
* | | kernel/server_session: Remove obsolete TODOsLioncash2019-04-101-7/+2
|/ / | | | | | | These are holdovers from Citra.
* / kernel/process: Set page table when page table resizes occur.Lioncash2019-04-091-0/+2
|/ | | | | | | | | We need to ensure dynarmic gets a valid pointer if the page table is resized (the relevant pointers would be invalidated in this scenario). In this scenario, the page table can be resized depending on what kind of address space is specified within the NPDM metadata (if it's present).
* Merge pull request #2361 from lioncash/pagetablebunnei2019-04-073-4/+2
|\ | | | | core/memory: Minor simplifications to page table management
| * kernel: Handle page table switching within MakeCurrentProcess()Lioncash2019-04-073-4/+2
| | | | | | | | | | Centralizes the page table switching to one spot, rather than making calling code deal with it everywhere.
* | kernel/server_session: Return a std::pair from CreateSessionPair()Lioncash2019-04-063-8/+7
| | | | | | | | | | | | Keeps the return type consistent with the function name. While we're at it, we can also reduce the amount of boilerplate involved with handling these by using structured bindings.
* | kernel/server_port: Return a std::pair from CreatePortPair()Lioncash2019-04-062-7/+7
|/ | | | Returns the same type that the function name describes.
* Merge pull request #2325 from lioncash/namebunnei2019-04-061-0/+4
|\ | | | | kernel/server_session: Provide a GetName() override
| * kernel/server_session: Provide a GetName() overrideLioncash2019-04-031-0/+4
| | | | | | | | | | | | Given server sessions can be given a name, we should allow retrieving it instead of using the default implementation of GetName(), which would just return "[UNKNOWN KERNEL OBJECT]".
* | Merge pull request #2329 from lioncash/sanitizebunnei2019-04-061-0/+14
|\ \ | | | | | | kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomic
| * | kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomicLioncash2019-04-041-0/+14
| | | | | | | | | | | | | | | | | | We need to be checking whether or not the given address is within the kernel address space or if the given address isn't word-aligned and bail in these scenarios instead of trashing any kernel state.
* | | Merge pull request #2328 from lioncash/transferbunnei2019-04-042-11/+31
|\ \ \ | | | | | | | | service/am: Correct behavior of CreateTransferMemoryStorage()
| * | | kernel/transfer_memory: Add accessors to data and sizesLioncash2019-04-032-11/+31
| |/ / | | | | | | | | | Also amend erroneous use of size_t. We should be using u64 here.
* | | Merge pull request #2324 from lioncash/enum-unusedbunnei2019-04-042-2/+0
|\ \ \ | |/ / |/| | kernel/object: Remove unused handle type entry
| * | kernel/object: Remove unused handle type entryLioncash2019-04-032-2/+0
| |/ | | | | | | | | | | | | | | The AddressArbiter type isn't actually used, given the arbiter itself isn't a direct kernel object (or object that implements the wait object facilities). Given this, we can remove the enum entry entirely.
* | Merge pull request #2305 from lioncash/sharedbunnei2019-04-033-5/+18
|\ \ | | | | | | kernel/shared_memory: Sanitize supplied size when unmapping
| * | kernel/shared_memory: Remove unused core/memory.h includeLioncash2019-03-291-1/+0
| | | | | | | | | | | | | | | Nothing from this header is used, so we can remove this include, getting rid of a dependency on it.
| * | kernel/shared_memory: Sanitize supplied size when unmappingLioncash2019-03-293-4/+18
| | | | | | | | | | | | | | | | | | | | | | | | The kernel makes sure that the given size to unmap is always the same size as the entire region managed by the shared memory instance, otherwise it returns an error code signifying an invalid size. This is similarly done for transfer memory (which we already check for).
* | | Merge pull request #2314 from lioncash/constbunnei2019-04-0311-18/+18
|\ \ \ | |_|/ |/| | kernel/thread: Minor interface cleanup
| * | kernel/thread: Make AllWaitObjectsReady() a const qualified member functionLioncash2019-04-022-2/+2
| | | | | | | | | | | | | | | | | | Now that ShouldWait() is a const qualified member function, this one can be made const qualified as well, since it can handle passing a const qualified this pointer to ShouldWait().
| * | kernel/wait_object: Make ShouldWait() take thread members by pointer-to-constLioncash2019-04-0211-11/+11
| | | | | | | | | | | | | | | Given this is intended as a querying function, it doesn't make sense to allow the implementer to modify the state of the given thread.
| * | kernel/thread: Avoid sign conversion within GetCommandBufferAddress()Lioncash2019-04-011-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously this was performing a u64 + int sign conversion. When dealing with addresses, we should generally be keeping the arithmetic in the same signedness type. This also gets rid of the static lifetime of the constant, as there's no need to make a trivial type like this potentially live for the entire duration of the program.
| * | kernel/thread: Make parameter of GetWaitObjectIndex() const qualifiedLioncash2019-04-012-3/+3
| | | | | | | | | | | | | | | The pointed to member is never actually modified, so it can be made const.
* | | Merge pull request #2270 from lioncash/plistbunnei2019-04-037-2/+123
|\ \ \ | | | | | | | | kernel/svc: Implement svcGetProcessList and svcGetThreadList
| * | | kernel/svc: Implement svcGetThreadListLioncash2019-04-024-1/+70
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Similarly like svcGetProcessList, this retrieves the list of threads from the current process. In the kernel itself, a process instance maintains a list of threads, which are used within this function. Threads are registered to a process' thread list at thread initialization, and unregistered from the list upon thread destruction (if said thread has a non-null owning process). We assert on the debug event case, as we currently don't implement kernel debug objects.
| * | | kernel/svc: Implement svcGetProcessListLioncash2019-04-024-1/+53
| | | | | | | | | | | | | | | | | | | | | | | | This service function simply copies out a specified number of kernel process IDs, while simultaneously reporting the total number of processes.
* | | | Merge pull request #2313 from lioncash/reslimitbunnei2019-04-023-14/+6
|\ \ \ \ | |/ / / |/| | | kernel/resource_limit: Remove the name member from resource limits
| * | | kernel/resource_limit: Remove the name member from resource limitsLioncash2019-04-013-14/+6
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This doesn't really provide any benefit to the resource limit interface. There's no way for callers to any of the service functions for resource limits to provide a custom name, so all created instances of resource limits other than the system resource limit would have a name of "Unknown". The system resource limit itself is already trivially identifiable from its limit values, so there's no real need to take up space in the object to identify one object meaningfully out of N total objects.
* | | process: Fix up compilationReinUsesLisp2019-04-021-1/+1
| | |
* | | Merge pull request #2281 from lioncash/memorybunnei2019-04-022-4/+5
|\ \ \ | |/ / |/| | kernel/codeset: Make CodeSet's memory data member a regular std::vector
| * | kernel/codeset: Make CodeSet's memory data member a regular std::vectorLioncash2019-03-222-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The use of a shared_ptr is an implementation detail of the VMManager itself when mapping memory. Because of that, we shouldn't require all users of the CodeSet to have to allocate the shared_ptr ahead of time. It's intended that CodeSet simply pass in the required direct data, and that the memory manager takes care of it from that point on. This means we just do the shared pointer allocation in a single place, when loading modules, as opposed to in each loader.
* | | general: Use deducation guides for std::lock_guard and std::unique_lockLioncash2019-04-012-2/+2
| | | | | | | | | | | | | | | | | | | | | Since C++17, the introduction of deduction guides for locking facilities means that we no longer need to hardcode the mutex type into the locks themselves, making it easier to switch mutex types, should it ever be necessary in the future.
* | | Merge pull request #2304 from lioncash/memsizebunnei2019-03-313-9/+28
|\ \ \ | | | | | | | | kernel/process: Report total physical memory used to svcGetInfo slightly better
| * | | kernel/process: Report total physical memory used to svcGetInfoLioncash2019-03-293-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Reports the (mostly) correct size through svcGetInfo now for queries to total used physical memory. This still doesn't correctly handle memory allocated via svcMapPhysicalMemory, however, we don't currently handle that case anyways.
| * | | kernel/process: Store the total size of the code memory loadedLioncash2019-03-292-0/+5
| | | | | | | | | | | | | | | | | | | | This will be necessary to properly report the used memory size in svcGetInfo.
| * | | kernel/process: Store the main thread stack size to a data memberLioncash2019-03-282-4/+7
| | | | | | | | | | | | | | | | | | | | This will be necessary in order to properly report memory usage within svcGetInfo.
| * | | kernel/process: Make Run's stack size parameter a u64Lioncash2019-03-282-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | This will make operating with the process-related SVC commands much nicer in the future (the parameter representing the stack size in svcStartProcess is a 64-bit value).
| * | | kernel/process: Ensure that given stack size is always page-alignedLioncash2019-03-281-0/+4
| | | | | | | | | | | | | | | | | | | | The kernel always makes sure that the given stack size is aligned to page boundaries.
* | | | kernel/scheduler: Remove unused parameter to AddThread()Lioncash2019-03-303-4/+4
| | | | | | | | | | | | | | | | | | | | This was made unused in b404fcdf1443b91ac9994c05ad1fe039fcd9675e, but the parameter itself wasn't removed.
* | | | kernel/scheduler: Use deduction guides on mutex locksLioncash2019-03-301-8/+8
| |_|/ |/| | | | | | | | | | | | | | Since C++17, we no longer need to explicitly specify the type of the mutex within the lock_guard. The type system can now deduce these with deduction guides.
* | | Merge pull request #2266 from FernandoS27/arbitrationbunnei2019-03-295-14/+18
|\ \ \ | | | | | | | | Kernel: Fixes to Arbitration and SignalProcessWideKey Management
| * | | Fix small bug that kept a thread as a condvar thread after being signalled.Fernando Sahmkow2019-03-202-6/+8
| | | |
| * | | Add CondVar Thread State.Fernando Sahmkow2019-03-204-4/+6
| | | |
| * | | Small fixes to address_arbiter to better match the IDB.Fernando Sahmkow2019-03-202-5/+5
| | | |
* | | | Merge pull request #2265 from FernandoS27/multilevelqueuebunnei2019-03-292-19/+27
|\ \ \ \ | |_|/ / |/| | | Replace old Thread Queue for a new Multi Level Queue
| * | | Fixes and corrections on formatting.Fernando Sahmkow2019-03-271-6/+9
| | | |
| * | | Use MultiLevelQueue instead of old ThreadQueueListFernando Sahmkow2019-03-272-19/+24
| | | |
* | | | Merge pull request #2284 from lioncash/heap-allocbunnei2019-03-283-59/+81
|\ \ \ \ | |/ / / |/| | | kernel/vm_manager: Unify heap allocation/freeing functions
| * | | kernel/vm_manager: Handle shrinking of the heap size within SetHeapSize()Lioncash2019-03-242-24/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One behavior that we weren't handling properly in our heap allocation process was the ability for the heap to be shrunk down in size if a larger size was previously requested. This adds the basic behavior to do so and also gets rid of HeapFree, as it's no longer necessary now that we have allocations and deallocations going through the same API function. While we're at it, fully document the behavior that this function performs.
| * | | kernel/vm_manager: Rename HeapAllocate to SetHeapSizeLioncash2019-03-243-4/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes it more obvious that this function is intending to stand in for the actual supervisor call itself, and not acting as a general heap allocation function. Also the following change will merge the freeing behavior of HeapFree into this function, so leaving it as HeapAllocate would be misleading.
| * | | kernel/vm_manager: Handle case of identical calls to HeapAllocateLioncash2019-03-241-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In cases where HeapAllocate is called with the same size of the current heap, we can simply do nothing and return successfully. This avoids doing work where we otherwise don't have to. This is also what the kernel itself does in this scenario.
| * | | kernel/vm_manager: Remove unused class variablesLioncash2019-03-241-3/+0
| | | | | | | | | | | | | | | | | | | | Over time these have fallen out of use due to refactoring, so these can be removed.
| * | | kernel/vm_manager: Remove unnecessary heap_used data memberLioncash2019-03-243-13/+2
| | | | | | | | | | | | | | | | | | | | This isn't required anymore, as all the kernel ever queries is the size of the current heap, not the total usage of it.
| * | | kernel/vm_manager: Tidy up heap allocation codeLioncash2019-03-243-27/+37
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Another holdover from citra that can be tossed out is the notion of the heap needing to be allocated in different addresses. On the switch, the base address of the heap will always be managed by the memory allocator in the kernel, so this doesn't need to be specified in the function's interface itself. The heap on the switch is always allocated with read/write permissions, so we don't need to add specifying the memory permissions as part of the heap allocation itself either. This also corrects the error code returned from within the function. If the size of the heap is larger than the entire heap region, then the kernel will report an out of memory condition.
* | | Merge pull request #2285 from lioncash/unused-structbunnei2019-03-261-8/+0
|\ \ \ | | | | | | | | kernel/process: Remove unused AddressMapping struct
| * | | kernel/process: Remove unused AddressMapping structLioncash2019-03-241-8/+0
| | | | | | | | | | | | | | | | Another leftover from citra that's now no longer necessary.
* | | | Merge pull request #2287 from lioncash/coretiming-cbbunnei2019-03-261-1/+1
|\ \ \ \ | | | | | | | | | | core/core_timing: Make callback parameters consistent
| * | | | core/core_timing: Make callback parameters consistentLioncash2019-03-241-1/+1
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some cases, our callbacks were using s64 as a parameter, and in other cases, they were using an int, which is inconsistent. To make all callbacks consistent, we can just use an s64 as the type for late cycles, given it gets rid of the need to cast internally. While we're at it, also resolve some signed/unsigned conversions that were occurring related to the callback registration.
* / / / kernel/kernel: Remove unnecessary forward declarationLioncash2019-03-241-3/+0
|/ / / | | | | | | | | | | | | This is no longer necessary, as ResultVal isn't used anywhere in the header.
* | | Merge pull request #2232 from lioncash/transfer-memorybunnei2019-03-245-6/+280
|\ \ \ | |/ / |/| | core/hle/kernel: Split transfer memory handling out into its own class
| * | core/hle/kernel/svc: Implement svcUnmapTransferMemoryLioncash2019-03-131-1/+48
| | | | | | | | | | | | | | | Similarly, like svcMapTransferMemory, we can also implement svcUnmapTransferMemory fairly trivially as well.
| * | core/hle/kernel/svc: Implement svcMapTransferMemoryLioncash2019-03-131-1/+57
| | | | | | | | | | | | | | | Now that transfer memory handling is separated from shared memory, we can implement svcMapTransferMemory pretty trivially.
| * | core/hle/kernel: Split transfer memory handling out into its own classLioncash2019-03-135-4/+175
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Within the kernel, shared memory and transfer memory facilities exist as completely different kernel objects. They also have different validity checking as well. Therefore, we shouldn't be treating the two as the same kind of memory. They also differ in terms of their behavioral aspect as well. Shared memory is intended for sharing memory between processes, while transfer memory is intended to be for transferring memory to other processes. This breaks out the handling for transfer memory into its own class and treats it as its own kernel object. This is also important when we consider resource limits as well. Particularly because transfer memory is limited by the resource limit value set for it. While we currently don't handle resource limit testing against objects yet (but we do allow setting them), this will make implementing that behavior much easier in the future, as we don't need to distinguish between shared memory and transfer memory allocations in the same place.
* | | Merge pull request #2234 from lioncash/mutexbunnei2019-03-225-29/+62
|\ \ \ | | | | | | | | core/hle/kernel: Make Mutex a per-process class.
| * | | core/hle/kernel/mutex: Remove usages of global system accessorsLioncash2019-03-151-11/+15
| | | | | | | | | | | | | | | | | | | | Removes the use of global system accessors, and instead uses the explicit interface provided.
| * | | core/hle/kernel: Make Mutex a per-process class.Lioncash2019-03-155-18/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes it an instantiable class like it is in the actual kernel. This will also allow removing reliance on global accessors in a following change, now that we can encapsulate a reference to the system instance in the class.
* | | | Merge pull request #2275 from lioncash/memflagsbunnei2019-03-223-17/+17
|\ \ \ \ | | | | | | | | | | kernel/vm_manager: Amend flag value for code data
| * | | | kernel/vm_manager: Rename CodeStatic/CodeMutable to Code and CodeData respectivelyLioncash2019-03-213-17/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes it more evident that one is for actual code and one is for actual data. Mutable and static are less than ideal terms here, because read-only data is technically not mutable, but we were mapping it with that label.
| * | | | kernel/vm_manager: Amend flag values for CodeMutableLioncash2019-03-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | This should actually be using the data flags, rather than the code flags.
* | | | | Merge pull request #1933 from DarkLordZach/cheat-enginebunnei2019-03-221-0/+3
|\ \ \ \ \ | |/ / / / |/| | | | file_sys: Implement parser and interpreter for game memory cheats
| * | | | vm_manager: Remove cheat-specific ranges from VMManagerZach Hilman2019-03-052-25/+0
| | | | |
| * | | | vm_manager: Add support for storing and getting main code regionZach Hilman2019-03-052-0/+28
| | | | | | | | | | | | | | | | | | | | Used as root for one region of cheats, set by loader
* | | | | Merge pull request #2268 from lioncash/codesetbunnei2019-03-214-45/+106
|\ \ \ \ \ | | | | | | | | | | | | core/kernel: Migrate CodeSet to its own source files
| * | | | | kernel/process: Make MapSegment lambda reference parameter constLioncash2019-03-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | The segment itself isn't actually modified.
| * | | | | kernel: Move CodeSet structure to its own source filesLioncash2019-03-204-44/+105
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Given this is utilized by the loaders, this allows avoiding inclusion of the kernel process definitions where avoidable. This also keeps the loading format for all executable data separate from the kernel objects.
* / | | | Fix crash caused by 2238.Fernando Sahmkow2019-03-201-1/+2
|/ / / /
* | | | Merge pull request #2238 from lioncash/threadbunnei2019-03-182-21/+41
|\ \ \ \ | | | | | | | | | | kernel/thread: Amend conditional test and assignment within UpdatePriority()
| * | | | kernel/thread: Expand documentation of nominal_priority and current_priorityLioncash2019-03-162-3/+11
| | | | | | | | | | | | | | | | | | | | | | | | | Aims to disambiguate why each priority instance exists a little bit. While we're at it, also add an explanatory comment to UpdatePriority().
| * | | | kernel/thread: Make bracing consistent within UpdatePriority()Lioncash2019-03-161-2/+4
| | | | |
| * | | | kernel/thread: Amend condition within UpdatePriority()Lioncash2019-03-161-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This condition was checking against the nominal thread priority, whereas the kernel itself checks against the current priority instead. We were also assigning the nominal priority, when we should be assigning current_priority, which takes priority inheritance into account. This can lead to the incorrect priority being assigned to a thread. Given we recursively update the relevant threads, we don't need to go through the whole mutex waiter list. This matches what the kernel does as well (only accessing the first entry within the waiting list).
| * | | | kernel/thread: Maintain priority ordering of added mutex waiting threadsLioncash2019-03-161-14/+24
| | |_|/ | |/| | | | | | | | | | | | | | The kernel keeps the internal waiting list ordered by priority. This is trivial to do with std::find_if followed by an insertion.
* | | | Merge pull request #2252 from bunnei/move-page-tablebunnei2019-03-174-9/+10
|\ \ \ \ | | | | | | | | | | core: Move PageTable struct into Common.
| * | | | core: Move PageTable struct into Common.bunnei2019-03-174-9/+10
| | | | |
* | | | | kernel/thread: Actually remove the definition of ExitCurrentThread()Lioncash2019-03-161-6/+0
|/ / / / | | | | | | | | | | | | | | | | | | | | This was intended to be removed in 51d7f6bffcc0498a47abc7de27bf0906fc523dae, but I guess I forgot to actually save the file like a dingus.
* | | | Merge pull request #2242 from lioncash/thread-fnbunnei2019-03-164-33/+31
|\ \ \ \ | |_|_|/ |/| | | kernel/thread: Remove WaitCurrentThread_Sleep() and ExitCurrentThread()
| * | | kernel/thread: Move thread exiting logic from ExitCurrentThread to svcExitThreadLioncash2019-03-162-8/+7
| | | | | | | | | | | | | | | | | | | | Puts the operation on global state in the same places as the rest of the svc calls.
| * | | kernel/thread: Migrate WaitCurrentThread_Sleep into the Thread interfaceLioncash2019-03-164-25/+24
| |/ / | | | | | | | | | | | | | | | Rather than make a global accessor for this sort of thing. We can make it a part of the thread interface itself. This allows getting rid of a hidden global accessor in the kernel code.
* | | Merge pull request #2230 from lioncash/globalbunnei2019-03-152-8/+9
|\ \ \ | | | | | | | | kernel/process: Remove use of global system accessors
| * | | kernel/process: Remove use of global system accessorsLioncash2019-03-132-8/+9
| |/ / | | | | | | | | | | | | Now that we pass in a reference to the system instance, we can utilize it to eliminate the global accessors in Process-related code.
* | | Merge pull request #2226 from lioncash/privatebunnei2019-03-133-13/+35
|\ \ \ | |/ / |/| | kernel/server_port: Make data members private
| * | kernel/server_port: Make data members privateLioncash2019-03-113-13/+35
| | | | | | | | | | | | | | | | | | | | | With this, all kernel objects finally have all of their data members behind an interface, making it nicer to reason about interactions with other code (as external code no longer has the freedom to totally alter internals and potentially messing up invariants).
* | | Merge pull request #2211 from lioncash/arbiterbunnei2019-03-127-63/+79
|\ \ \ | |/ / |/| | kernel: Make the address arbiter instance per-process
| * | kernel: Make the address arbiter instance per-processLioncash2019-03-086-26/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that we have the address arbiter extracted to its own class, we can fix an innaccuracy with the kernel. Said inaccuracy being that there isn't only one address arbiter. Each process instance contains its own AddressArbiter instance in the actual kernel. This fixes that and gets rid of another long-standing issue that could arise when attempting to create more than one process.
| * | kernel/svc: Move address arbiter signaling behind a unified API functionLioncash2019-03-083-22/+26
| | | | | | | | | | | | | | | | | | | | | Similar to how WaitForAddress was isolated to its own function, we can also move the necessary conditional checking into the address arbiter class itself, allowing us to hide the implementation details of it from public use.
| * | kernel/svc: Move address arbiter waiting behind a unified API functionLioncash2019-03-083-19/+24
| | | | | | | | | | | | | | | | | | Rather than let the service call itself work out which function is the proper one to call, we can make that a behavior of the arbiter itself, so we don't need to directly expose those implementation details.
* | | Merge pull request #2193 from lioncash/globalbunnei2019-03-102-9/+11
|\ \ \ | | | | | | | | kernel/scheduler: Pass in system instance in constructor
| * | | kernel/scheduler: Pass in system instance in constructorLioncash2019-03-042-9/+11
| | |/ | |/| | | | | | | | | | | | | | | | | | | Avoids directly relying on the global system instance and instead makes an arbitrary system instance an explicit dependency on construction. This also allows removing dependencies on some global accessor functions as well.
* | | Merge pull request #2210 from lioncash/optionalbunnei2019-03-083-46/+46
|\ \ \ | | | | | | | | kernel/hle_ipc: Convert std::shared_ptr IPC header instances to std::optional
| * | | kernel/hle_ipc: Convert std::shared_ptr IPC header instances to std::optionalLioncash2019-03-083-46/+46
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | There's no real need to use a shared lifetime here, since we don't actually expose them to anything else. This is also kind of an unnecessary use of the heap given the objects themselves are so small; small enough, in fact that changing over to optionals actually reduces the overall size of the HLERequestContext struct (818 bytes to 808 bytes).
* | | Merge pull request #2195 from lioncash/shared-globalbunnei2019-03-071-3/+2
|\ \ \ | |/ / |/| | kernel/shared_memory: Get rid of the use of global accessor functions within Create()
| * | kernel/shared_memory: Get rid of the use of global accessor functions within Create()Lioncash2019-03-041-3/+2
| |/ | | | | | | | | | | | | | | Given we already pass in a reference to the kernel that the shared memory instance is created under, we can just use that to check the current process, rather than using the global accessor functions. This allows removing direct dependency on the system instance entirely.
* | Merge pull request #2202 from lioncash/port-privbunnei2019-03-075-35/+77
|\ \ | | | | | | kernel/client_session, kernel/server_session: Make data members private
| * | kernel/server_session: Make data members privateLioncash2019-03-064-31/+72
| | | | | | | | | | | | | | | Makes it much nicer to locally reason about server session behavior, as part of its functionality isn't placed around other classes.
| * | kernel/client_session: Make data members privateLioncash2019-03-061-4/+5
| |/ | | | | | | | | These can be made private, as they aren't accessed in contexts that require them to be public.
* | Merge pull request #2197 from lioncash/includebunnei2019-03-072-5/+6
|\ \ | | | | | | core/hle/ipc: Remove unnecessary includes
| * | core/hle/ipc: Remove unnecessary includesLioncash2019-03-052-5/+6
| |/ | | | | | | | | | | | | | | | | | | | | Removes a few inclusion dependencies from the headers or replaces existing ones with ones that don't indirectly include the required headers. This allows removing an inclusion of core/memory.h, meaning that if the memory header is ever changed in the future, it won't result in rebuilding the entirety of the HLE services (as the IPC headers are used quite ubiquitously throughout the HLE service implementations).
* | Merge pull request #2199 from lioncash/arbiterbunnei2019-03-065-110/+181
|\ \ | | | | | | kernel/address_arbiter: Convert the address arbiter into a class
| * | kernel/address_arbiter: Pass in system instance to constructorLioncash2019-03-054-21/+39
| | | | | | | | | | | | | | | Allows getting rid of reliance on the global accessor functions and instead operating on the provided system instance.
| * | kernel/address_arbiter: Minor tidying upLioncash2019-03-051-18/+18
| | | | | | | | | | | | | | | - Invert conditions into guard clases where applicable. - Mark std::vector parameter of WakeThreads as const
| * | kernel/address_arbiter: Convert the address arbiter into a classLioncash2019-03-055-82/+135
| |/ | | | | | | | | | | Places all of the functions for address arbiter operation into a class. This will be necessary for future deglobalizing efforts related to both the memory and system itself.
* | Merge pull request #2194 from lioncash/membunnei2019-03-063-30/+66
|\ \ | | | | | | svc: Move memory range checking functions to the VMManager class
| * | vm_manager: Use range helpers in HeapAlloc() and HeapFree()Lioncash2019-03-041-4/+2
| | | | | | | | | | | | Significantly tidies up two guard conditionals.
| * | vm_manager: Provide address range checking functions for other memory regionsLioncash2019-03-042-4/+35
| | | | | | | | | | | | | | | Makes the interface uniform when it comes to checking various memory regions.
| * | svc: Migrate address range checking functions to VMManagerLioncash2019-03-043-23/+30
| |/ | | | | | | Provides a bit of a more proper interface for these functions.
* / kernel/thread: Remove obsolete TODO in Create()Lioncash2019-03-051-2/+0
|/ | | | This is a TODO carried over from Citra that doesn't apply here.
* kernel/handle_table: Make local variables as const where applicableLioncash2019-02-251-4/+5
| | | | Makes immutable state explicit.
* kernel/handle_table: Allow process capabilities to limit the handle table sizeLioncash2019-02-256-10/+54
| | | | | | | | | | The kernel allows restricting the total size of the handle table through the process capability descriptors. Until now, this functionality wasn't hooked up. With this, the process handle tables become properly restricted. In the case of metadata-less executables, the handle table will assume the maximum size is requested, preserving the behavior that existed before these changes.
* kernel/handle-table: In-class initialize data membersLioncash2019-02-252-3/+2
| | | | Directly initializes members where applicable.
* kernel/handle_table: Resolve truncation warningsLioncash2019-02-251-2/+2
| | | | | Avoids implicit truncation warnings from u32 -> u16 (the truncation is desirable behavior here).
* address_arbiter: Use nested namespaces where applicableLioncash2019-02-162-8/+4
| | | | | | A fairly trivial change. Other sections of the codebase use nested namespaces instead of separate namespaces here. This one must have just been overlooked.
* core_timing: Convert core timing into a classLioncash2019-02-165-21/+31
| | | | | | | | | | | Gets rid of the largest set of mutable global state within the core. This also paves a way for eliminating usages of GetInstance() on the System class as a follow-up. Note that no behavioral changes have been made, and this simply extracts the functionality into a class. This also has the benefit of making dependencies on the core timing functionality explicit within the relevant interfaces.
* core_timing: Rename CoreTiming namespace to Core::TimingLioncash2019-02-125-16/+17
| | | | | | Places all of the timing-related functionality under the existing Core namespace to keep things consistent, rather than having the timing utilities sitting in its own completely separate namespace.
* kernel: Remove the Timer classLioncash2019-02-016-227/+0
| | | | | | | | | | | | A holdover from citra, the Horizon kernel on the switch has no prominent kernel object that functions as a timer. At least not to the degree of sophistication that this class provided. As such, this can be removed entirely. This class also wasn't used at all in any meaningful way within the core, so this was just code sitting around doing nothing. This also allows removing a few things from the main KernelCore class that allows it to use slightly less resources overall (though very minor and not anything really noticeable).
* kernel/wait_object: Devirtualize functions related to manipulating the thread list directlyLioncash2019-01-301-3/+3
| | | | | | | | | No inheritors of the WaitObject class actually make use of their own implementations of these functions, so they can be made non-virtual. It's also kind of sketchy to allow overriding how the threads get added to the list anyways, given the kernel itself on the actual hardware doesn't seem to customize based off this.
* kernel/timer: Remove unnecessary WakeupAllWaitingThreads() overrideLioncash2019-01-302-6/+0
| | | | | This implementation just calls the base class variant of the function, so this isn't necessary.
* kernel/readable_event: Remove unnecessary WakeupAllWaitingThreads() overrideLioncash2019-01-302-6/+0
| | | | This just calls the base variant of the function, so it can be removed.
* kernel/svc: Log out uncaught C++ exceptions from svcBreakLioncash2019-01-271-0/+4
| | | | | | | | | | Looking into the implementation of the C++ standard facilities that seem to be within all modules, it appears that they use 7 as a break reason to indicate an uncaught C++ exception. This was primarily found via the third last function called within Horizon's equivalent of libcxxabi's demangling_terminate_handler(), which passes the value 0x80000007 to svcBreak.
* Removed pulse event typeDavid Marcec2019-01-043-7/+0
| | | | Pulse is considered a hack and nothing should be using it. We should completely remove it
* core/kernel: Remove unnecessary inclusionsLioncash2019-01-0111-12/+17
| | | | Gets rid of a few unnecessary header dependencies in some source files.
* kernel/svc: Correct misleading error message within CreateThread()Lioncash2018-12-311-2/+3
| | | | | | | | | | This is a bounds check to ensure that the thread priority is within the valid range of 0-64. If it exceeds 64, that doesn't necessarily mean that an actual priority of 64 was expected (it actually means whoever called the function screwed up their math). Instead clarify the message to indicate the allowed range of thread priorities.
* kernel/svc: Sanitize core number and thread priorities in CreateThread()Lioncash2018-12-311-6/+17
| | | | | | Now that we handle the kernel capability descriptors we can correct CreateThread to properly check against the core and priority masks like the actual kernel does.
* kernel/process: Rename GetAllowedProcessorMask() and GetAllowedThreadPriorityMask()Lioncash2018-12-312-11/+11
| | | | Makes them consistent with their kernel capability counterparts.
* kernel/svc: Simplify thread core ID sanitizing in CreateThreadLioncash2018-12-311-7/+1
| | | | | Rather than use a switch here, this can be collapsed into a simple range check, which is a little easier on the eyes.
* Merge pull request #1956 from lioncash/process-threadSebastian Valle2018-12-315-57/+51
|\ | | | | kernel/process: Start the main thread using the specified ideal core
| * kernel/process: Start the main thread using the specified ideal coreLioncash2018-12-281-2/+2
| | | | | | | | | | This matches kernel behavior in that processes are started using their specified ideal core, rather than always starting on core 0.
| * kernel: Rename 'default' CPU core to 'ideal' coreLioncash2018-12-284-21/+21
| | | | | | | | | | | | This makes the naming more closely match its meaning. It's just a preferred core, not a required default core. This also makes the usages of this term consistent across the thread and process implementations.
| * kernel/thread: Move process thread initialization into process.cppLioncash2018-12-283-36/+30
| | | | | | | | | | | | | | | | | | | | This function isn't a general purpose function that should be exposed to everything, given it's specific to initializing the main thread for a Process instance. Given that, it's a tad bit more sensible to place this within process.cpp, which keeps it visible only to the code that actually needs it.
* | Merge pull request #1847 from ogniK5377/backtrace-breakbunnei2018-12-301-0/+3
|\ \ | | | | | | Print backtrace on svcBreak
| * | Moved backtrace to ArmInterfaceDavid Marcec2018-12-193-11/+3
| | |
| * | Moved backtrace to ArmInterfaceDavid Marcec2018-12-031-14/+1
| | | | | | | | | | | | Added to both dynarmic and unicorn
| * | Print backtrace on svcBreakDavid Marcec2018-12-033-0/+24
| | | | | | | | | | | | When we get an svcBreak we get a backtrace now
* | | kernel/process: Remove most allocation functions from Process' interfaceLioncash2018-12-283-38/+19
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | In all cases that these functions are needed, the VMManager can just be retrieved and used instead of providing the same functions in Process' interface. This also makes it a little nicer dependency-wise, since it gets rid of cases where the VMManager interface was being used, and then switched over to using the interface for a Process instance. Instead, it makes all accesses uniform and uses the VMManager instance for all necessary tasks. All the basic memory mapping functions did was forward to the Process' VMManager instance anyways.
* | Merge pull request #1928 from lioncash/capsbunnei2018-12-276-123/+642
|\ \ | | | | | | kernel: Handle kernel capability descriptors
| * | kernel/process: Hook up the process capability parser to the process itselfLioncash2018-12-212-120/+18
| | | | | | | | | | | | | | | While we're at it, we can also toss out the leftover capability parsing from Citra.
| * | kernel/process_capability: Handle debug capability flagsLioncash2018-12-212-1/+18
| | |
| * | kernel/process_capability: Handle handle table capability flagsLioncash2018-12-212-1/+11
| | | | | | | | | | | | | | | This just specifies the handle table size. There's also a section of reserved bits that are checked against.
| * | kernel/process_capability: Handle kernel version capability flagsLioncash2018-12-212-1/+18
| | |
| * | kernel/process_capability: Handle program capability flagsLioncash2018-12-213-2/+29
| | |
| * | kernel/process_capability: Handle interrupt capability flagsLioncash2018-12-211-1/+21
| | | | | | | | | | | | | | | | | | Similar to the service capability flags, however, we currently don't emulate the GIC, so this currently handles all interrupts as being valid for the time being.
| * | kernel/process_capability: Handle syscall capability flagsLioncash2018-12-212-1/+29
| | |
| * | kernel/process_capability: Handle the priority mask and core mask flagsLioncash2018-12-212-1/+40
| | | | | | | | | | | | | | | | | | Handles the priority mask and core mask flags to allow building up the masks to determine the usable thread priorities and cores for a kernel process instance.
| * | kernel/process: Introduce process capability parsing skeletonLioncash2018-12-214-3/+466
| | | | | | | | | | | | | | | | | | | | | We've had the old kernel capability parser from Citra, however, this is unused code and doesn't actually map to how the kernel on the Switch does it. This introduces the basic functional skeleton for parsing process capabilities.
* | | kernel/vm_manager: Reset region attributes when unmapping a VMALioncash2018-12-271-0/+1
| | | | | | | | | | | | | | | Like the other members related to memory regions, the attributes need to be reset back to their defaults as well.
* | | Merge pull request #1849 from encounter/svcSetThreadActivitybunnei2018-12-264-6/+72
|\ \ \ | | | | | | | | svc: Implement SetThreadActivity (thread suspension)
| * | | svc: Implement SetThreadActivity (thread suspension)Luke Street2018-12-044-6/+72
| | | |
* | | | Merge pull request #1921 from ogniK5377/no-unitbunnei2018-12-211-0/+1
|\ \ \ \ | | | | | | | | | | Fixed uninitialized memory due to missing returns in canary
| * | | | Fixed uninitialized memory due to missing returns in canaryDavid Marcec2018-12-191-0/+1
| | | | | | | | | | | | | | | | | | | | Functions which are suppose to crash on non canary builds usually don't return anything which lead to uninitialized memory being used.
* | | | | Merge pull request #1925 from lioncash/pidbunnei2018-12-216-26/+57
|\ \ \ \ \ | |_|_|/ / |/| | | | kernel/{process, thread}: Amend behavior related to IDs
| * | | | kernel/svc: Handle thread handles within GetProcessIdLioncash2018-12-191-10/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a thread handle is passed to svcGetProcessId, the kernel attempts to access the process ID via the thread's instance's owning process. Technically, this function should also be handling the kernel debug objects as well, however we currently don't handle those kernel objects yet, so I've left a note via a comment about it to remind myself when implementing it in the future.
| * | | | kernel/kernel: Use correct initial PID for userland Process instancesLioncash2018-12-192-4/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Starts the process ID counter off at 81, which is what the kernel itself checks against internally when creating processes. It's actually supposed to panic if the PID is less than 81 for a userland process.
| * | | | kernel/svc: Correct output parameter for svcGetThreadIdLioncash2018-12-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | The service call uses a 64-bit value, just like svcGetProcessId. This amends the function signature accordingly.
| * | | | kernel/thread: Make thread_id a 64-bit valueLioncash2018-12-193-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | The kernel uses a 64-bit value for the thread ID, so we shouldn't be using a 32-bit value.
| * | | | kernel/svc: Correct output parameter for svcGetProcessIdLioncash2018-12-192-2/+10
| | | | | | | | | | | | | | | | | | | | | | | | | svcGetProcessId's out parameter is a pointer to a 64-bit value, not a 32-bit one.
| * | | | kernel/process: Make process_id a 64-bit valueLioncash2018-12-193-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | In the actual kernel, this is a 64-bit value, so we shouldn't be using a 32-bit type to handle it.
* | | | | Merge pull request #1907 from lioncash/attributebunnei2018-12-193-14/+279
|\ \ \ \ \ | |_|/ / / |/| | | | kernel/svc: Implement svcSetMemoryAttribute
| * | | | svc: Implement svcSetMemoryAttributeLioncash2018-12-191-5/+46
| | | | | | | | | | | | | | | | | | | | | | | | | With all the basic backing functionality implemented, we can now unstub svcSetMemoryAttribute.
| * | | | vm_manager: Add member function for setting memory attributes across an address rangeLioncash2018-12-192-0/+41
| | | | | | | | | | | | | | | | | | | | | | | | | This puts the backing functionality for svcSetMemoryAttribute in place, which will be utilized in a following change.
| * | | | vm_manager: Add member function for checking a memory range adheres to certain attributes, permissions and statesLioncash2018-12-192-0/+100
| | | | |
| * | | | vm_manager: Rename meminfo_state to stateLioncash2018-12-162-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | This is shorter and more concise. This also removes the now-innaccurate comment, as it's not returned wholesale to svcQueryMemory anymore.
| * | | | vm_manager: Add backing functionality for memory attributesLioncash2018-12-162-1/+85
| |/ / / | | | | | | | | | | | | | | | | | | | | Adds the barebones enumeration constants and functions in place to handle memory attributes, while also essentially leaving the attribute itself non-functional.
* / / / kernel/thread: Set default fpcrMerryMage2018-12-181-0/+3
|/ / /
* | | Merge pull request #1732 from DarkLordZach/yield-typesbunnei2018-12-154-9/+165
|\ \ \ | | | | | | | | svc: Implement yield types 0 and -1
| * | | svc: Avoid incorrect fast yield conditionZach Hilman2018-12-051-6/+1
| | | |
| * | | scheduler: Avoid manual Reschedule callZach Hilman2018-12-042-11/+11
| | | | | | | | | | | | This will automatically occur anyway when PrepareReschedule is called
| * | | scheduler: Only work steal higher priority threads from other coresZach Hilman2018-12-033-35/+24
| | | |
| * | | svc: Avoid performance-degrading unnecessary rescheduleZach Hilman2018-12-022-8/+6
| | | |
| * | | scheduler: Add explanations for YieldWith and WithoutLoadBalancingZach Hilman2018-11-225-77/+139
| | | |
| * | | svc: Implement yield types 0 and -1Zach Hilman2018-11-195-2/+114
| | | |
* | | | Merge pull request #1899 from lioncash/statebunnei2018-12-147-84/+188
|\ \ \ \ | | | | | | | | | | vm_manager/svc: Modify MemoryState enum, and correct error handling for svcQueryMemory
| * | | | svc: Enable svcQueryProcessMemoryLioncash2018-12-122-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | svcQueryProcessMemory is trivial to implement, given all the behavior necessary for it is present, it just needs a handler for it.
| * | | | svc: Write out the complete MemoryInfo structure in QueryProcessMemoryLioncash2018-12-121-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the previous change, the memory writing was moved into the service function itself, however it still had a problem, in that the entire MemoryInfo structure wasn't being written out, only the first 32 bytes of it were being written out. We still need to write out the trailing two reference count members and zero out the padding bits. Not doing this can result in wrong behavior in userland code in the following scenario: MemoryInfo info; // Put on the stack, not quaranteed to be zeroed out. svcQueryMemory(&info, ...); if (info.device_refcount == ...) // Whoops, uninitialized read. This can also cause the wrong thing to happen if the user code uses std::memcmp to compare the struct, with another one (questionable, but allowed), as the padding bits are not guaranteed to be a deterministic value. Note that the kernel itself also fully zeroes out the structure before writing it out including the padding bits.
| * | | | svc: Handle memory writing explicitly within QueryProcessMemoryLioncash2018-12-122-26/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Moves the memory writes directly into QueryProcessMemory instead of letting the wrapper function do it. It would be inaccurate to allow the handler to do it because there's cases where memory shouldn't even be written to. For example, if the given process handle is invalid. HOWEVER, if the memory writing is within the wrapper, then we have no control over if these memory writes occur, meaning in an error case, 68 bytes of memory randomly get trashed with zeroes, 64 of those being written to wherever the memory info address points to, and the remaining 4 being written wherever the page info address points to. One solution in this case would be to just conditionally check within the handler itself, but this is kind of smelly, given the handler shouldn't be performing conditional behavior itself, it's a behavior of the managed function. In other words, if you remove the handler from the equation entirely, does the function still retain its proper behavior? In this case, no. Now, we don't potentially trash memory from this function if an invalid query is performed.
| * | | | vm_manager: Correct ordering of last two struct members of MemoryInfoLioncash2018-12-121-2/+2
| | | | | | | | | | | | | | | | | | | | These should be swapped.
| * | | | vm_manager: Amend the returned values for invalid memory queries in QueryMemory()Lioncash2018-12-122-4/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The kernel returns a memory info instance with the base address set to the end of the address space, and the size of said block as 0 - address_space_end, it doesn't set both of said members to zero.
| * | | | vm_manager: Migrate memory querying to the VMManager interfaceLioncash2018-12-124-18/+33
| | | | | | | | | | | | | | | | | | | | | | | | | Gets rid of the need to directly access the managed VMAs outside of the memory manager itself just for querying memory.
| * | | | vm_manager: Migrate MemoryInfo and PageInfo to vm_manager.hLioncash2018-12-123-17/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gets the two structures out of an unrelated header and places them with the rest of the memory management code. This also corrects the structures. PageInfo appears to only contain a 32-bit flags member, and the extra padding word in MemoryInfo isn't necessary.
| * | | | vm_manager: Amend MemoryState enum membersLioncash2018-12-125-28/+111
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Amends the MemoryState enum to use the same values like the actual kernel does. Also provides the necessary operators to operate on them. This will be necessary in the future for implementing svcSetMemoryAttribute, as memory block state is checked before applying the attribute.
* | | | | Merge pull request #1900 from lioncash/wrapperbunnei2018-12-141-1/+1
|\ \ \ \ \ | | | | | | | | | | | | svc_wrap: Correct register index for a wrapper specialization
| * | | | | svc_wrap: Correct register index for a wrapper specializationLioncash2018-12-121-1/+1
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This would result in svcSetMemoryAttribute getting the wrong value for its third parameter. This is currently fine, given the service function is stubbed, however this will be unstubbed in a future change, so this needs to change.
* / / / / Fix Process object leak on emulation stopJens Schmer2018-12-123-13/+12
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Process object kept itself alive indefinitely because its handle_table contains a SharedMemory object which owns a reference to the same Process object, creating a circular ownership scenario. Break that up by storing only a non-owning pointer in the SharedMemory object.
* | | | Merge pull request #1872 from lioncash/proc-infoHexagon122018-12-101-0/+1
|\ \ \ \ | | | | | | | | | | kernel/process: Set ideal core from metadata
| * | | | kernel/process: Set ideal core from metadataLioncash2018-12-051-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | A very trivial change. If metadata is available, the process should use it to retrieve the desired core for the process to run on.
* | | | | Merge pull request #1876 from lioncash/vmabunnei2018-12-104-22/+36
|\ \ \ \ \ | | | | | | | | | | | | vm_manager: Make vma_map private
| * | | | | vm_manager: Make vma_map privateLioncash2018-12-064-22/+36
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was only ever public so that code could check whether or not a handle was valid or not. Instead of exposing the object directly and allowing external code to potentially mess with the map contents, we just provide a member function that allows checking whether or not a handle is valid. This makes all member variables of the VMManager class private except for the page table.
* | | | | kernel/svc: Correct behavior of svcResetSignal()Lioncash2018-12-051-4/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While partially correct, this service call allows the retrieved event to be null, as it also uses the same handle to check if it was referring to a Process instance. The previous two changes put the necessary machinery in place to allow for this, so we can simply call those member functions here and be done with it.
* | | | | kernel/process: Make Process a WaitObjectLioncash2018-12-053-6/+68
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Process instances can be waited upon for state changes. This is also utilized by svcResetSignal, which will be modified in an upcoming change. This simply puts all of the WaitObject related machinery in place.
* | | | | kernel/readable_event: Add member function for enforcing a strict reset contractLioncash2018-12-052-1/+22
|/ / / / | | | | | | | | | | | | | | | | | | | | svcResetSignal relies on the event instance to have already been signaled before attempting to reset it. If this isn't the case, then an error code has to be returned.
* | | | kernel/svc: Remove unused header inclusionLioncash2018-12-041-1/+0
| | | |
* | | | kernel/svc: Implement svcSignalEvent()Lioncash2018-12-041-1/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This function simply does a handle table lookup for a writable event instance identified by the given handle value. If a writable event cannot be found for the given handle, then an invalid handle error is returned. If a writable event is found, then it simply signals the event, as one would expect.
* | | | kernel/svc: Implement svcCreateEvent()Lioncash2018-12-042-1/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | svcCreateEvent operates by creating both a readable and writable event and then attempts to add both to the current process' handle table. If adding either of the events to the handle table fails, then the relevant error from the handle table is returned. If adding the readable event after the writable event to the table fails, then the writable event is removed from the handle table and the relevant error from the handle table is returned. Note that since we do not currently test resource limits, we don't check the resource limit table yet.
* | | | Merge pull request #1853 from lioncash/eventbunnei2018-12-045-10/+19
|\ \ \ \ | | | | | | | | | | kernel/object: Amend handle types to distinguish between readable and writable events
| * | | | kernel/object: Amend handle types to distinguish between readable and writable eventsLioncash2018-12-045-10/+19
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Two kernel object should absolutely never have the same handle ID type. This can cause incorrect behavior when it comes to retrieving object types from the handle table. In this case it allows converting a WritableEvent into a ReadableEvent and vice-versa, which is undefined behavior, since the object types are not the same. This also corrects ClearEvent() to check both kernel types like the kernel itself does.
* | | | kernel/handle_table: Amend reference to CTR-OS in Create()Lioncash2018-12-041-2/+3
| | | | | | | | | | | | | | | | Another hold-over from Citra.
* | | | kernel/svc: Implement the resource limit svcGetInfo optionLioncash2018-12-044-9/+34
|/ / / | | | | | | | | | | | | Allows a process to register the resource limit as part of its handle table.
* | | [Kernel::CreateThread] Match format specifiers to LOG_TRACE's argumentsV.Kalyuzhny2018-12-041-1/+1
| | |
* | | Merge pull request #1840 from lioncash/infobunnei2018-12-041-50/+100
|\ \ \ | | | | | | | | svc: Reorganize svcGetInfo, handle more error cases for existing implemented info categories
| * | | svc: Use the current process' handle table for retrieving the process instance to act uponLioncash2018-12-021-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The kernel uses the handle table of the current process to retrieve the process that should be used to retrieve certain information. To someone not familiar with the kernel, this might raise the question of "Ok, sounds nice, but doesn't this make it impossible to retrieve information about the current process?". No, it doesn't, because HandleTable instances in the kernel have the notion of a "pseudo-handle", where certain values allow the kernel to lookup objects outside of a given handle table. Currently, there's only a pseudo-handle for the current process (0xFFFF8001) and a pseudo-handle for the current thread (0xFFFF8000), so to retrieve the current process, one would just pass 0xFFFF8001 into svcGetInfo. The lookup itself in the handle table would be something like: template <typename T> T* Lookup(Handle handle) { if (handle == PSEUDO_HANDLE_CURRENT_PROCESS) { return CurrentProcess(); } if (handle == PSUEDO_HANDLE_CURRENT_THREAD) { return CurrentThread(); } return static_cast<T*>(&objects[handle]); } which, as is shown, allows accessing the current process or current thread, even if those two objects aren't actually within the HandleTable instance.
| * | | svc: Reorganize svcGetInfo, handle more error cases for existing implemented info categoriesLioncash2018-12-021-50/+99
| | |/ | |/| | | | | | | | | | | | | Our implementation of svcGetInfo was slightly incorrect in that we weren't doing proper error checking everywhere. Instead, reorganize it to be similar to how the kernel seems to do it.
* | | Merge pull request #1803 from DarkLordZach/k-able-eventbunnei2018-12-038-58/+163
|\ \ \ | |/ / |/| | kernel: Divide Event into ReadableEvent and WritableEvent
| * | hle_ipc: Refactor SleepClientThread to avoid ReadableEventZach Hilman2018-11-295-8/+10
| | |
| * | kernel/event: Reference ReadableEvent from WritableEventZach Hilman2018-11-298-125/+47
| | |
| * | core: Port all current usages of Event to Readable/WritableEventZach Hilman2018-11-291-5/+6
| | |
| * | hle_ipc: Use event pair for SleepClientThreadZach Hilman2018-11-292-19/+22
| | |
| * | kernel: Add named event tableZach Hilman2018-11-292-0/+30
| | | | | | | | | | | | Used to store ReadableEvents of all events on the system.
| * | kernel: Divide Event into ReadableEvent and WritableEventZach Hilman2018-11-295-59/+206
| | | | | | | | | | | | More hardware accurate. On the actual system, there is a differentiation between the signaler and signalee, they form a client/server relationship much like ServerPort and ClientPort.
| * | kernel/object: Add descriptions to ResetTypesZach Hilman2018-11-291-3/+3
| | |
* | | Fix debug buildLioncash2018-12-011-1/+1
|/ / | | | | | | | | A non-existent parameter was left in some formatting calls (the logging macro for which only does anything meaningful on debug builds)
* | Merge pull request #1801 from ogniK5377/log-before-executebunnei2018-11-291-24/+206
|\ \ | | | | | | Changed logging to be "Log before execution", Added more error logging, all services/svc should now log on some level
| * | Added comment on Main memory size for more clarityDavid Marcec2018-11-271-0/+1
| | |
| * | Made svcSetHeapSize and svcCreateSharedMemory more readableDavid Marcec2018-11-271-4/+4
| | |
| * | Reworked svcs slightly, improved error messages in AM and fsp_srvDavid Marcec2018-11-271-12/+20
| | |
| * | Improved error messages for SVCsDavid Marcec2018-11-261-76/+170
| | |
| * | Changed logging to be "Log before execution", Added more error logging, all services should now log on some levelDavid Marcec2018-11-261-11/+90
| | |
* | | svc: Implement svcSetResourceLimitLimitValue()Lioncash2018-11-271-1/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The opposite of the getter functions, this function sets the limit value for a particular ResourceLimit resource category, with the restriction that the new limit value must be equal to or greater than the current resource value. If this is violated, then ERR_INVALID_STATE is returned. e.g. Assume: current[Events] = 10; limit[Events] = 20; a call to this service function lowering the limit value to 10 would be fine, however, attempting to lower it to 9 in this case would cause an invalid state error.
* | | svc: Implement svcGetResourceLimitCurrentValue()Lioncash2018-11-271-16/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This kernel service function is essentially the exact same as svcGetResourceLimitLimitValue(), with the only difference being that it retrieves the current value for a given resource category using the provided resource limit handle, rather than retrieving the limiting value of that resource limit instance. Given these are exactly the same and only differ on returned values, we can extract the existing code for svcGetResourceLimitLimitValue() to handle both values.
* | | svc: Implement svcGetResourceLimitLimitValue()Lioncash2018-11-272-2/+33
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This kernel service function retrieves the maximum allowable value for a provided resource category for a given resource limit instance. Given we already have the functionality added to the resource limit instance itself, it's sufficient to just hook it up. The error scenarios for this are: 1. If an invalid resource category type is provided, then ERR_INVALID_ENUM is returned. 2. If an invalid handle is provided, then ERR_INVALID_HANDLE is returned (bad thing goes in, bad thing goes out, as one would expect). If neither of the above error cases occur, then the out parameter is provided with the maximum limit value for the given category and success is returned.
* | | svc: Implement svcCreateResourceLimit()Lioncash2018-11-272-1/+27
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This function simply creates a ResourceLimit instance and attempts to create a handle for it within the current process' handle table. If the kernal fails to either create the ResourceLimit instance or create a handle for the ResourceLimit instance, it returns a failure code (OUT_OF_RESOURCE, and HANDLE_TABLE_FULL respectively). Finally, it exits by providing the output parameter with the handle value for the ResourceLimit instance and returning that it was successful. Note: We do not return OUT_OF_RESOURCE because, if yuzu runs out of available memory, then new will currently throw. We *could* allocate the kernel instance with std::nothrow, however this would be inconsistent with how all other kernel objects are currently allocated.
* | svc: Return ERR_INVALID_ENUM_VALUE from svcGetInfoLuke Street2018-11-251-1/+2
| |
* | kernel/handle_table: Move private static functions into the cpp fileLioncash2018-11-222-7/+9
| | | | | | | | | | These don't depend on class state, and are effectively implementation details, so they can go into the cpp file .
* | kernel/handle_table: Restrict handle table size to 1024 entriesLioncash2018-11-221-5/+2
| | | | | | | | | | | | The previous handle table size is a holdover from Citra. The actual handle table construct on Horizon only allows for a maximum of 1024 entries.
* | kernel/handle_table: Default destructor in the cpp fileLioncash2018-11-222-0/+3
| | | | | | | | | | We don't need to potentially inline the teardown logic of all of the handle instances.
* | Merge pull request #1734 from lioncash/sharedbunnei2018-11-213-29/+45
|\ \ | | | | | | kernel/shared_memory: Make data members private, plus minor interface changes
| * | kernel/shared_memory: Make Map() and Unmap() take the target process by reference rather than as a pointerLioncash2018-11-193-12/+12
| | | | | | | | | | | | | | | | | | Both member functions assume the passed in target process will not be null. Instead of making this assumption implicit, we can change the functions to be references and enforce this at the type-system level.
| * | kernel/shared_memory: Add a const qualified member function overload for GetPointer()Lioncash2018-11-192-1/+12
| | | | | | | | | | | | | | | Given this doesn't mutate instance state, we can provide a const-qualified variant as well.
| * | kernel/shared_memory: Use 64-bit types for offset and size in CreateForAppletLioncash2018-11-192-2/+2
| | | | | | | | | | | | Keeps the interface consistent with the regular Create() function.
| * | kernel/shared_memory: Make GetPointer() take a std::size_t instead of a u32Lioncash2018-11-192-2/+2
| | | | | | | | | | | | | | | | | | | | | Makes the interface nicer to use in terms of 64-bit code, as it makes it less likely for one to get truncation warnings (and also makes sense in the context of the rest of the interface where 64-bit types are used for sizes and offsets
| * | kernel/shared_memory: Make data members privateLioncash2018-11-191-12/+17
| |/ | | | | | | | | | | Rather than allow unfettered access to the class internals, we hide all members by default and create and API that other code can operate against.
* | kernel/process: Move <random> include to the cpp fileLioncash2018-11-202-1/+1
| | | | | | | | | | | | <random> isn't necesary directly within the header and can be placed in the cpp file where its needed. Avoids propagating random generation utilities via a header file.
* | Merge pull request #1667 from DarkLordZach/swkbdbunnei2018-11-201-3/+33
|\ \ | | | | | | am: Implement HLE software keyboard applet
| * | am: Deglobalize software keyboard appletZach Hilman2018-11-181-4/+4
| | |
| * | svc: Implement svcCreateTransferMemoryZach Hilman2018-11-181-3/+33
| | | | | | | | | Seems to be used and created identically to SharedMemory, so just reuse that.
* | | kernel/resource_limit: Clean up interfaceLioncash2018-11-206-190/+81
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | Cleans out the citra/3DS-specific implementation details that don't apply to the Switch. Sets the stage for implementing ResourceLimit instances properly. While we're at it, remove the erroneous checks within CreateThread() and SetThreadPriority(). While these are indeed checked in some capacity, they are not checked via a ResourceLimit instance. In the process of moving out Citra-specifics, this also replaces the system ResourceLimit instance's values with ones from the Switch.
* | Merge pull request #1620 from DarkLordZach/ldr-robunnei2018-11-194-7/+9
|\ \ | | | | | | ldr_ro: Complete LDR:RO implementation
| * | ldr_ro: Add error check for memory allocation failureZach Hilman2018-11-183-6/+7
| | |
| * | process: Make MirrorMemory take state to map new memory asZach Hilman2018-11-151-1/+2
| | | | | | | | | | | | Credits to Subv
* | | Merge pull request #1728 from FearlessTobi/reset-signalMat M2018-11-181-1/+1
|\ \ \ | |_|/ |/| | svc: ResetSignal is not stubbed
| * | svc: ResetSignal is not stubbedTobias2018-11-181-1/+1
| | | | | | | | | https://user-images.githubusercontent.com/20753089/48677874-b8e01c80-eb7b-11e8-8043-b99faa29022c.PNG
* | | kernel/errors: Clean up error codesLioncash2018-11-162-62/+32
| | | | | | | | | | | | | | | | | | | | | | | | Similar to PR 1706, which cleans up the error codes for the filesystem code, but done for the kernel error codes. This removes the ErrCodes namespace and specifies the errors directly. This also fixes up any straggling lines of code that weren't using the named error codes where applicable.
* | | Merge pull request #1638 from FreddyFunk/SetMemoryPermission-StubbedMat M2018-11-162-1/+48
|\ \ \ | | | | | | | | Implement SetMemoryPermission
| * | | Implement SetMemoryPermissionFrederic Laing2018-11-061-3/+39
| | | |
| * | | Stubbed SetMemoryPermissionFrederic Laing2018-11-032-1/+12
| | | |
* | | | Merge pull request #1687 from lioncash/deduplicationbunnei2018-11-152-37/+13
|\ \ \ \ | |_|_|/ |/| | | kernel/thread: Deduplicate scheduler switching code
| * | | kernel/thread: Deduplicate scheduler switching codeLioncash2018-11-142-37/+13
| | | | | | | | | | | | | | | | | | | | The code in both places was the same verbatim, so we can extract it to a function to deduplicate the logic.
* | | | Merge pull request #1679 from DarkLordZach/deterministic-rng-2bunnei2018-11-143-1/+27
|\ \ \ \ | | | | | | | | | | svc: Use proper random entropy generation algorithm
| * | | | svc: Use proper random entropy generation algorithmZach Hilman2018-11-133-1/+27
| |/ / /
* | | | vm_manager: Unstub GetTotalHeapUsage()Lioncash2018-11-131-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | Now that we've moved all of the heap-related stuff to the VMManager class, we can unstub this function, as the necessary members are visible now.
* | | | kernel/process: Migrate heap-related memory management out of the process class and into the vm managerLioncash2018-11-134-84/+97
|/ / / | | | | | | | | | | | | Avoids a breach of responsibilities in the interface and keeps the direct code for memory management within the VMManager class.
* | | svc: Return random seed for svcGetInfo RandomEntropyZach Hilman2018-11-131-1/+2
| | |
* | | svcBreak now dumps information from the debug buffer passed (#1646)David2018-11-081-0/+28
|/ / | | | | | | | | | | | | | | * svcBreak now dumps information from the debug buffer passed info1 and info2 seem to somtimes hold an address to a buffer, this is usually 4 bytes or the size of the int and contains an error code. There's other circumstances where it can be something different so we hexdump these to examine them at a later date. * Addressed comments
* | general: Remove unused boost inclusions where applicableLioncash2018-10-301-2/+0
| | | | | | | | Cleans up unused includes and trims off some dependencies on externals.
* | global: Use std::optional instead of boost::optional (#1578)Frederic L2018-10-301-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * get rid of boost::optional * Remove optional references * Use std::reference_wrapper for optional references * Fix clang format * Fix clang format part 2 * Adressed feedback * Fix clang format and MacOS build
* | Merge pull request #1621 from lioncash/ipcbunnei2018-10-302-4/+8
|\ \ | | | | | | hle_ipc: Make GetDomainMessageHeader return a regular pointer
| * | hle_ipc: Add member function for querying the existence of a domain headerLioncash2018-10-302-1/+5
| | | | | | | | | | | | Gets rid of the need to call the getter and then check for null.
| * | hle_ipc: Make GetDomainMessageHeader return a regular pointerLioncash2018-10-302-3/+3
| |/ | | | | | | | | Nothing requires the shared owner ship here, so we can just return a plain pointer.
* / core: Make System references const where applicableLioncash2018-10-282-3/+3
|/
* svc: Localize the GetInfo enum class to the function itselfLioncash2018-10-262-32/+31
| | | | Nothing from this enum is intended to be used outside of this function.
* svc: Implement svcGetInfo command 0xF0000002Lioncash2018-10-266-4/+98
| | | | | | | | | | This retrieves: if (curr_thread == handle_thread) { result = total_thread_ticks + (hardware_tick_count - last_context_switch_ticks); } else if (curr_thread == handle_thread && sub_id == current_core_index) { result = hardware_tick_count - last_context_switch_ticks; }
* process: LoadModule should clear JIT instruction cache.bunnei2018-10-261-0/+6
|
* Kernel/Memory: Added a function to first a suitable guest address at which to allocate a region of a given size.bunnei2018-10-262-0/+28
|
* kernel/errors: Remove now-unused, unnecessary, error codesLioncash2018-10-241-8/+0
| | | | | | Now that we've gotten the innaccurate error codes out of the way, we can finally toss away a bunch of these, trimming down the error codes to ones that are actually used and knocking out two TODO comments.
* kernel/shared_memory: Return ERR_INVALID_MEMORY_PERMISSIONS instead of ERR_INVALID_COMBINATIONLioncash2018-10-241-4/+3
| | | | This is more consistent with what the kernel does.
* kernel/server_port: Simplify emptiness check within ShouldWait()Lioncash2018-10-241-1/+1
|
* kernel/server_port: Change error case return value in Accept() to ERR_NOT_FOUNDLioncash2018-10-242-3/+1
| | | | This is what the kernel does in this instance.
* kernel/error: Remove leftover 3DS error codesLioncash2018-10-241-5/+0
| | | | These are now entirely unused and can be removed.
* kernel/svc: Amend returned error code for invalid priorities in CreateThreadLioncash2018-10-241-1/+1
| | | | | Like with the previous change, the kernel doesn't return NOT_AUTHORIZED here. It returns INVALID_THREAD_PRIORITY.
* kernel/svc: Move and correct returned error code for invalid thread priorities in SetThreadPriority()Lioncash2018-10-241-5/+6
| | | | | | All priority checks are supposed to occur before checking the validity of the thread handle, we're also not supposed to return ERR_NOT_AUTHORIZED here.
* kernel/error: Add error code for invalid pointersLioncash2018-10-241-1/+1
| | | | | The kernel appears to return 0xE601 for this situation. Particularly in svcWaitSynchronization, svcReplyAndReceive, and svcGetThreadContext
* kernel/error: Add error code for closed sessionsLioncash2018-10-241-1/+3
| | | | The kernel appears to return 0xF601 for this case.
* Merge pull request #1551 from ogniK5377/improved-svcbreakbunnei2018-10-241-5/+51
|\ | | | | Added break types to svcBreak
| * Added assertion failed, reworked logging levelsDavid Marcec2018-10-231-16/+24
| |
| * Added break types to svcBreakDavid Marcec2018-10-231-4/+42
| | | | | | | | There seems to be more such as type 1, and 2. Unsure what these currently are but when a game hits them we can investigate and add the rest
* | Merge pull request #1540 from lioncash/handlebunnei2018-10-248-98/+95
|\ \ | |/ |/| kernel/process: Make the handle table per-process
| * kernel/process: Make the handle table per-processLioncash2018-10-208-98/+95
| | | | | | | | | | | | | | | | In the kernel, there isn't a singular handle table that everything gets tossed into or used, rather, each process gets its own handle table that it uses. This currently isn't an issue for us, since we only execute one process at the moment, but we may as well get this out of the way so it's not a headache later on.
* | svc: Fix vma boundary check in svcQueryMemoryLioncash2018-10-201-1/+1
|/ | | | | | This should be comparing against the queried process' vma_map, not the current process'. The only reason this hasn't become an issue yet is we currently only handle one process being active at any time.
* Merge pull request #1520 from lioncash/sanbunnei2018-10-203-3/+50
|\ | | | | svc: Add missing sanitizing checks for MapSharedMemory/UnmapSharedMemory
| * svc: Add missing sanitizing checks for MapSharedMemory/UnmapSharedMemoryLioncash2018-10-183-3/+50
| | | | | | | | | | | | | | | | Now that the changes clarifying the address spaces has been merged, we can wrap the checks that the kernel performs when mapping shared memory (and other forms of memory) into its own helper function and then use those within MapSharedMemory and UnmapSharedMemory to complete the sanitizing checks that are supposed to be done.
* | svc: Check for word alignment of addresses within svcArbitrateLock/svcArbitrateUnlockLioncash2018-10-181-0/+8
| | | | | | | | | | The kernel itself checks whether or not the provided addresses are word aligned before continuing, so we should be doing the same.
* | common: Move Is4KBAligned() to alignment.hLioncash2018-10-181-9/+7
|/ | | | | Aligning on 4KB pages isn't a Switch-specific thing, so this can be moved to common so it can be used with other things as well.
* Merge pull request #1498 from lioncash/aslrbunnei2018-10-184-28/+44
|\ | | | | svc: Clarify enum values for AddressSpaceBaseAddr and AddressSpaceSize in svcGetInfo()
| * svc: Clarify enum values for AddressSpaceBaseAddr and AddressSpaceSize in svcGetInfo()Lioncash2018-10-154-28/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | So, one thing that's puzzled me is why the kernel seemed to *not* use the direct code address ranges in some cases for some service functions. For example, in svcMapMemory, the full address space width is compared against for validity, but for svcMapSharedMemory, it compares against 0xFFE00000, 0xFF8000000, and 0x7FF8000000 as upper bounds, and uses either 0x200000 or 0x8000000 as the lower-bounds as the beginning of the compared range. Coincidentally, these exact same values are also used in svcGetInfo, and also when initializing the user address space, so this is actually retrieving the ASLR extents, not the extents of the address space in general.
* | core_cpu: Make Cpu scheduler instances unique_ptrs instead of shared_ptrsLioncash2018-10-154-15/+15
|/
* Merge pull request #1492 from lioncash/procbunnei2018-10-143-4/+50
|\ | | | | svc: Implement svcGetProcessInfo
| * svc: Implement svcGetProcessInfoLioncash2018-10-133-4/+50
| | | | | | | | | | | | | | A fairly basic service function, which only appears to currently support retrieving the process state. This also alters the ProcessStatus enum to contain all of the values that a kernel process seems to be able of reporting with regards to state.
* | Stop all threads on svcBreakDavid Marcec2018-10-141-0/+6
|/ | | | This should help diagnose crashes easier and prevent many users thinking that a game is still running when in fact it's just an audio thread still running(this is typically not killed when svcBreak is hit since the game expects us to do this)
* Merge pull request #1483 from lioncash/codesetbunnei2018-10-134-40/+14
|\ | | | | kernel/process: Make CodeSet a regular non-inherited object
| * kernel/process: Make CodeSet a regular non-inherited objectLioncash2018-10-124-40/+14
| | | | | | | | | | | | | | | | These only exist to ferry data into a Process instance and end up going out of scope quite early. Because of this, we can just make it a plain struct for holding things and just std::move it into the relevant function. There's no need to make this inherit from the kernel's Object type.
* | Merge pull request #1481 from lioncash/typobunnei2018-10-131-3/+3
|\ \ | | | | | | svc: Fix typos in sanitizing checks for MapMemory/UnmapMemory
| * | svc: Fix typos in sanitizing checks for MapMemory/UnmapMemoryLioncash2018-10-121-3/+3
| |/
* | Merge pull request #1467 from ogniK5377/svcbreak-type-fixbunnei2018-10-122-28/+36
|\ \ | | | | | | Fixed incorrect types for svcBreak
| * | Changed all casts in svc_wrap.h to be static_cast insteadDavid Marcec2018-10-101-25/+28
| | |
| * | Use a better name than "dont_kill_application"David Marcec2018-10-101-2/+2
| | | | | | | | | | | | signal_debugger seems like a more fitting name
| * | Fixed incorrect types for svcBreakDavid Marcec2018-10-102-3/+8
| | | | | | | | | | | | svcBreak reason should be a u32, not a u64.
* | | thread: Remove unnecessary memset from ResetThreadContext()Lioncash2018-10-121-4/+1
| |/ |/| | | | | | | | | Regular value initialization is adequate here for zeroing out data. It also has the benefit of not invoking undefined behavior if a non-trivial type is ever added to the struct for whatever reason.
* | svc: Add missing address range sanitizing checks to MapMemory/UnmapMemoryLioncash2018-10-112-12/+81
| | | | | | | | | | | | | | | | This adds the missing address range checking that the service functions do before attempting to map or unmap memory. Given that both service functions perform the same set of checks in the same order, we can wrap these into a function and just call it from both functions, which deduplicates a little bit of code.
* | kernel/thread: Use a regular pointer for the owner/current processLioncash2018-10-106-29/+29
|/ | | | | | | | | | | There's no real need to use a shared pointer in these cases, and only makes object management more fragile in terms of how easy it would be to introduce cycles. Instead, just do the simple thing of using a regular pointer. Much of this is just a hold-over from citra anyways. It also doesn't make sense from a behavioral point of view for a process' thread to prolong the lifetime of the process itself (the process is supposed to own the thread, not the other way around).
* Added bitfield instead of manually checking if the bit is setDavid Marcec2018-10-091-4/+12
|
* Actual kill execution when the bit isn't set, not the other way aroundDavid Marcec2018-10-091-1/+1
|
* svcBreak, Signalling to the debugger should not kill executionDavid Marcec2018-10-091-5/+12
| | | | When loading NROs, svcBreak is called to signal to the debugger that a new "module" is loaded. As no debugger is technically attached we shouldn't be killing the programs execution.
* Added forward define for ServerPortDavid Marcec2018-10-062-4/+6
|
* Ported #4296 from citraDavid Marcec2018-10-062-1/+6
| | | | This will allow us to easily remove the use of "NFC" in "System"
* kernel/mutex: Amend behavior of TransferMutexOwnership()Lioncash2018-10-061-1/+1
| | | | | | | | | This was the result of a typo accidentally introduced in e51d715700a35a8f14e5b804b6f7553c9a40888b. This restores the previous correct behavior. The behavior with the reference was incorrect and would cause some games to fail to boot.
* thread: Make the scheduler pointer a regular pointerbalika0112018-10-052-4/+4
| | | | | | | | | | | | | | Conceptually, it doesn't make sense for a thread to be able to persist the lifetime of a scheduler. A scheduler should be taking care of the threads; the threads should not be taking care of the scheduler. If the threads outlive the scheduler (or we simply don't actually terminate/shutdown the threads), then it should be considered a bug that we need to fix. Attributing this to balika011, as they opened #1317 to attempt to fix this in a similar way, but my refactoring of the kernel code caused quite a few conflicts.
* kernel/thread: Make all instance variables privateLioncash2018-10-0411-187/+363
| | | | | | | | | | | | | | | | | | | | Many of the member variables of the thread class aren't even used outside of the class itself, so there's no need to make those variables public. This change follows in the steps of the previous changes that made other kernel types' members private. The main motivation behind this is that the Thread class will likely change in the future as emulation becomes more accurate, and letting random bits of the emulator access data members of the Thread class directly makes it a pain to shuffle around and/or modify internals. Having all data members public like this also makes it difficult to reason about certain bits of behavior without first verifying what parts of the core actually use them. Everything being public also generally follows the tendency for changes to be introduced in completely different translation units that would otherwise be better introduced as an addition to the Thread class' public interface.
* kernel/svc: Implement svcGetThreadContext()Lioncash2018-09-303-2/+37
| | | | | | | | | Now that we have all of the rearranging and proper structure sizes in place, it's fairly trivial to implement svcGetThreadContext(). In the 64-bit case we can more or less just write out the context as is, minus some minor value sanitizing. In the 32-bit case we'll need to clear out the registers that wouldn't normally be accessible from a 32-bit AArch32 exectuable (or process).
* kernel/process: Add a data member to determine if a process is 64-bit or not.Lioncash2018-09-302-0/+11
| | | | | | | | | | | This will be necessary for the implementation of svcGetThreadContext(), as the kernel checks whether or not the process that owns the thread that has it context being retrieved is a 64-bit or 32-bit process. If the process is 32-bit, then the upper 15 general-purpose registers and upper 16 vector registers are cleared to zero (as AArch32 only has 15 GPRs and 16 128-bit vector registers. not 31 general-purpose registers and 32 128-bit vector registers like AArch64).
* kernel/process: Make data member variables privateLioncash2018-09-305-51/+96
| | | | | | | Makes the public interface consistent in terms of how accesses are done on a process object. It also makes it slightly nicer to reason about the logic of the process class, as we don't want to expose everything to external code.
* Merge pull request #1412 from lioncash/movebunnei2018-09-292-3/+2
|\ | | | | kernel/object: Remove unnecessary std::move from DynamicObjectCast()
| * kernel/object: Remove unnecessary std::move from DynamicObjectCast()Lioncash2018-09-282-3/+2
| | | | | | | | | | | | | | | | | | boost::static_pointer_cast for boost::intrusive_ptr (what SharedPtr is), takes its parameter by const reference. Given that, it means that this std::move doesn't actually do anything other than obscure what the function's actual behavior is, so we can remove this. To clarify, this would only do something if the parameter was either taking its argument by value, by non-const ref, or by rvalue-reference.
* | Merge pull request #1395 from lioncash/vmbunnei2018-09-297-53/+319
|\ \ | |/ |/| process/vm_manager: Initial modifications to load NPDM metadata
| * memory: Dehardcode the use of fixed memory range constantsLioncash2018-09-254-13/+17
| | | | | | | | | | | | | | | | The locations of these can actually vary depending on the address space layout, so we shouldn't be using these when determining where to map memory or be using them as offsets for calculations. This keeps all the memory ranges flexible and malleable based off of the virtual memory manager instance state.
| * svc: Report correct memory-related values within some of the cases in svcGetInfo()Lioncash2018-09-253-28/+41
| | | | | | | | | | | | Previously, these were reporting hardcoded values, but given the regions can change depending on the requested address spaces, these need to report the values that the memory manager contains.
| * memory: Dehardcode the use of a 36-bit address spaceLioncash2018-09-252-5/+16
| | | | | | | | | | Given games can also request a 32-bit or 39-bit address space, we shouldn't be hardcoding the address space range as 36-bit.
| * process/vm_manager: Amend API to allow reading parameters from NPDM metadataLioncash2018-09-244-10/+248
| | | | | | | | | | | | | | | | | | Rather than hard-code the address range to be 36-bit, we can derive the parameters from supplied NPDM metadata if the supplied exectuable supports it. This is the bare minimum necessary for this to be possible. The following commits will rework the memory code further to adjust to this.
* | Merge pull request #1399 from lioncash/schedbunnei2018-09-262-9/+9
|\ \ | | | | | | kernel/scheduler: Take ARM_Interface instances by reference
| * | kernel/scheduler: Take ARM_Interface instance by reference in the constructorLioncash2018-09-252-9/+9
| |/ | | | | | | | | It doesn't make sense to allow a scheduler to be constructed around a null pointer.
* | Merge pull request #1393 from tech4me/svcbunnei2018-09-251-7/+7
|\ \ | |/ |/| svc: Updated svc names
| * svc: Updated svc namestech4me2018-09-241-7/+7
| |
* | svc: Move most process termination code to its own function within ProcessLioncash2018-09-213-32/+56
| | | | | | | | | | Reduces the use of Process class members externally and keeps most code related to tearing down a process with the rest of the process code.
* | thread/process: Move TLS slot marking/freeing to the process classLioncash2018-09-214-68/+89
| | | | | | | | | | | | Allows making several members of the process class private, it also avoids going through Core::CurrentProcess() just to retrieve the owning process.
* | Merge pull request #1372 from lioncash/threadbunnei2018-09-213-5/+5
|\ \ | | | | | | kernel/thread: Use owner_process when setting the page table in SetupMainThread()
| * | kernel/thread: Use owner_process when setting the page table in SetupMainThread()Lioncash2018-09-213-5/+5
| |/ | | | | | | | | | | | | The owning process of a thread is required to exist before the thread, so we can enforce this API-wise by using a reference. We can also avoid the reliance on the system instance by using that parameter to access the page table that needs to be set.
* / arm_interface: Replace kernel vm_manager include with a forward declarationLioncash2018-09-211-0/+1
|/ | | | | | Avoids an unnecessary inclusion and also uncovers three places where indirect inclusions were relied upon, which allows us to also resolve those.
* Merge pull request #1346 from lioncash/svcbunnei2018-09-191-37/+36
|\ | | | | svc_wrap: Convert the PARAM macro into a function
| * svc_wrap: Convert the PARAM macro into a functionLioncash2018-09-181-37/+36
| | | | | | | | | | | | This can just be a regular function, getting rid of the need to also explicitly undef the define at the end of the file. Given FuncReturn() was already converted into a function, it's #undef can also be removed.
* | Merge pull request #1343 from lioncash/mutexbunnei2018-09-182-2/+10
|\ \ | | | | | | kernel/svc: Handle invalid address cases within svcArbitrateLock() and svcArbitrateUnlock()
| * | kernel/mutex: Replace ResultCode construction for invalid addresses with the named variantLioncash2018-09-181-2/+2
| | | | | | | | | | | | | | | | | | We already have a ResultCode constant for the case of an invalid address, so we can just use it instead of re-rolling that ResultCode type.
| * | kernel/svc: Handle error cases for svcArbitrateLock() and svcArbitrateUnlock()Lioncash2018-09-181-0/+8
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | The kernel does the equivalent of the following check before proceeding: if (address + 0x8000000000 < 0x7FFFE00000) { return ERR_INVALID_MEMORY_STATE; } which is essentially what our IsKernelVirtualAddress() function does. So we should also be checking for this. The kernel also checks if the given input addresses are 4-byte aligned, however our Mutex::TryAcquire() and Mutex::Release() functions already handle this, so we don't need to add code for this case.
* / arm_interface: Remove ARM11-isms from the CPU interfaceLioncash2018-09-181-2/+2
|/ | | | | | | | | This modifies the CPU interface to more accurately match an AArch64-supporting CPU as opposed to an ARM11 one. Two of the methods don't even make sense to keep around for this interface, as Adv Simd is used, rather than the VFP in the primary execution state. This is essentially a modernization change that should have occurred from the get-go.
* Merge pull request #1313 from lioncash/errorbunnei2018-09-171-1/+2
|\ | | | | kernel/errors: Amend error code for ERR_NOT_FOUND
| * kernel/errors: Amend error code for ERR_NOT_FOUNDLioncash2018-09-131-1/+2
| | | | | | | | | | This is the value returned by the kernel for svcConnectToNamedPort() if the named port cannot be found.
* | Merge pull request #1315 from lioncash/sizebunnei2018-09-172-19/+74
|\ \ | | | | | | kernel/svc: Handle a few error cases within memory-related functions
| * | kernel/svc: Sanitize creation of shared memory via svcCreateSharedMemory()Lioncash2018-09-141-2/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The kernel caps the size limit of shared memory to 8589930496 bytes (or (1GB - 512 bytes) * 8), so approximately 8GB, where every GB has a 512 byte sector taken off of it. It also ensures the shared memory is created with either read or read/write permissions for both permission types passed in, allowing the remote permissions to also be set as "don't care".
| * | kernel/svc: Sanitize addresses, permissions, and sizes within svcMapSharedMemory() and svcUnmapSharedMemory()Lioncash2018-09-141-17/+25
| | | | | | | | | | | | | | | | | | | | | | | | Part of the checking done by the kernel is to check if the given address and size are 4KB aligned, as well as checking if the size isn't zero. It also only allows mapping shared memory as readable or read/write, but nothing else, and so we shouldn't allow mapping as anything else either.
| * | kernel/svc: Sanitize addresses and sizes within svcMapMemory() and svcUnmapMemory()Lioncash2018-09-141-0/+23
| | | | | | | | | | | | | | | The kernel checks if the addresses and given size is 4KB aligned before continuing onwards to map the memory.
| * | kernel/svc: Sanitize heap sizes within svcSetHeapSize()Lioncash2018-09-142-0/+8
| |/ | | | | | | | | The kernel checks if the given size is a multiple of 2MB and <= to 4GB before going ahead and attempting to allocate that much memory.
* | Merge pull request #1328 from FearlessTobi/port-4192bunnei2018-09-171-1/+1
|\ \ | | | | | | Port #4192 from Citra: "svc: change unknown to thread in CreateThread"
| * | Port # #4192 from Citra: "svc: change unknown to thread in CreateThread"Valentin Vanelslande2018-09-151-1/+1
| | |
* | | Port #4182 from Citra: "Prefix all size_t with std::"fearlessTobi2018-09-1514-62/+65
|/ /
* / kernel/thread: Include thread-related enums within the kernel namespaceLioncash2018-09-131-6/+6
|/ | | | | | Previously, these were sitting outside of the Kernel namespace, which doesn't really make sense, given they're related to the Thread class which is within the Kernel namespace.
* Merge pull request #1303 from lioncash/errorbunnei2018-09-123-9/+11
|\ | | | | kernel/errors: Amend invalid thread priority and invalid processor ID error codes
| * svc: Return ERR_INVALID_PROCESSOR_ID in CreateThread() if an invalid processor ID is givenLioncash2018-09-121-2/+2
| | | | | | | | This is what the kernel does for an out-of-range processor ID.
| * kernel/errors: Correct error codes for invalid thread priority and invalid processor IDLioncash2018-09-123-7/+9
| |
* | svc: Do nothing if svcOutputDebugString() is given a length of zeroLioncash2018-09-121-0/+4
| | | | | | | | | | | | While unlikely, it does avoid constructing a std::string and unnecessarily calling into the memory code if a game or executable decides to be really silly about their logging.
* | svc: Correct parameter type for OutputDebugString()Lioncash2018-09-122-3/+3
|/ | | | This should be a u64 to represent size.
* core: Migrate current_process pointer to the kernelLioncash2018-09-072-0/+23
| | | | | | | | | | Given we now have the kernel as a class, it doesn't make sense to keep the current process pointer within the System class, as processes are related to the kernel. This also gets rid of a subtle case where memory wouldn't be freed on core shutdown, as the current_process pointer would never be reset, causing the pointed to contents to continue to live.
* service: Migrate global named port map to the KernelCore classLioncash2018-09-023-5/+49
| | | | | | Now that we have a class representing the kernel in some capacity, we now have a place to put the named port map, so we move it over and get rid of another piece of global state within the core.
* core/core: Replace includes with forward declarations where applicableLioncash2018-08-315-4/+12
| | | | | | | | | | | The follow-up to e2457418dae19b889b2ad85255bb95d4cd0e4bff, which replaces most of the includes in the core header with forward declarations. This makes it so that if any of the headers the core header was previously including change, then no one will need to rebuild the bulk of the core, due to core.h being quite a prevalent inclusion. This should make turnaround for changes much faster for developers.
* kernel: Eliminate kernel global stateLioncash2018-08-2932-405/+574
| | | | | | | | | | | | | | | | | | | | | | As means to pave the way for getting rid of global state within core, This eliminates kernel global state by removing all globals. Instead this introduces a KernelCore class which acts as a kernel instance. This instance lives in the System class, which keeps its lifetime contained to the lifetime of the System class. This also forces the kernel types to actually interact with the main kernel instance itself instead of having transient kernel state placed all over several translation units, keeping everything together. It also has a nice consequence of making dependencies much more explicit. This also makes our initialization a tad bit more correct. Previously we were creating a kernel process before the actual kernel was initialized, which doesn't really make much sense. The KernelCore class itself follows the PImpl idiom, which allows keeping all the implementation details sealed away from everything else, which forces the use of the exposed API and allows us to avoid any unnecessary inclusions within the main kernel header.
* Merge pull request #1177 from lioncash/errbunnei2018-08-284-12/+15
|\ | | | | kernel/error: Amend several error codes
| * kernel/error: Amend error code for ERR_MAX_CONNECTIONS_REACHEDLioncash2018-08-251-2/+4
| | | | | | | | | | | | We can make this error code an alias of the resource limit exceeded error code, allowing us to get rid of the lingering 3DS error code of the same type.
| * kernel/error: Amend error code for ERR_PORT_NAME_TOO_LONGLioncash2018-08-251-2/+1
| | | | | | | | | | We can treat this as an alias of TooLarge for documentation purposes. This also lets us get rid of another lingering 3DS-related error code.
| * kernel/error: Add error code for the handle table being fullLioncash2018-08-253-4/+4
| | | | | | | | | | This replaces the lingering 3DS constant with the proper one, and utilizes it within HandleTable's Create() member function.
| * kernel/error: Add error code for invalid memory permissionsLioncash2018-08-252-3/+4
| |
| * kernel/error: Correct kernel error code for invalid combinationLioncash2018-08-251-1/+2
| |
* | Merge pull request #1175 from lioncash/nsbunnei2018-08-284-6/+8
|\ \ | | | | | | core: Namespace all code in the arm subdirectory under the Core namespace
| * | core: Namespace all code in the arm subdirectory under the Core namespaceLioncash2018-08-254-6/+8
| |/ | | | | | | Gets all of these types and interfaces out of the global namespace.
* / svc: Return process title ID if queried in GetInfo()Lioncash2018-08-251-2/+1
|/ | | | | | We already have the variable itself set up to perform this task, so we can just return its value from the currently executing process instead of always stubbing it to zero.
* Merge pull request #1051 from B3n30/UnscheduleEventThreadsafebunnei2018-08-161-1/+1
|\ | | | | Core::CoreTiming: add UnscheduleEventThreadsafe
| * Core::CoreTiming: add UnscheduleEventThreadsafeB3n302018-08-131-1/+1
| |
* | kernel/server_session: Add IsSession() member functionLioncash2018-08-152-2/+7
| | | | | | | | | | | | Allows querying the inverse of IsDomain() to make things more readable. This will likely also be usable in the event of implementing ConvertDomainToSession().
* | kernel/svc: Log svcBreak parametersLioncash2018-08-151-2/+5
|/ | | | | | Given if we hit here all is lost, we should probably be logging the break reason code and associated information to distinguish between the causes.
* kernel/object: Tighten object against data racesLioncash2018-08-132-8/+9
| | | | | | | | | | Despite being covered by a global mutex, we should still ensure that the class handles its reference counts properly. This avoids potential shenanigans when it comes to data races. Given this is the root object that drives quite a bit of the kernel object hierarchy, ensuring we always have the correct behavior (and no races) is a good thing.
* Merge pull request #1043 from Subv/timingbunnei2018-08-131-1/+0
|\ | | | | Use an approximated amortized amount of ticks when advancing timing.
| * Kernel/SVC: Don't reschedule the current core when creating a new thread.Subv2018-08-131-1/+0
| | | | | | | | The current core may have nothing to do with the core where the new thread was scheduled to run. In case it's the same core, then the following PrepareReshedule call will take care of that.
* | Merge pull request #1036 from lioncash/threadbunnei2018-08-132-2/+2
|\ \ | | | | | | scheduler: Make HaveReadyThreads() a const member function
| * | scheduler: Make HaveReadyThreads() a const member functionLioncash2018-08-122-2/+2
| |/ | | | | | | | | This function doesn't modify instance state, so the const qualifier can be added to it.
* | Merge pull request #1042 from Subv/racesbunnei2018-08-131-2/+9
|\ \ | | | | | | Fixed a bunch of race conditions when running in multicore mode.
| * | Kernel/Threads: Lock the HLE mutex when executing the wakeup callback.Subv2018-08-131-0/+5
| | | | | | | | | | | | Another thread might be in the middle of a reschedule, thus altering the state of the schedulers.
| * | Kernel/Thread: Always use the threadsafe option when scheduling wakeups.Subv2018-08-131-2/+4
| |/ | | | | | | | | | | WakeAfterDelay might be called from any host thread, so err on the side of caution and use the thread-safe CoreTiming::ScheduleEventThreadsafe. Note that CoreTiming is still far from thread-safe, there may be more things we have to work on for it to be up to par with what we want.
* / Kernel/Mutex: Don't duplicate threads in the mutex waiter list.Subv2018-08-122-2/+22
|/ | | | | | | | | | Exit from AddMutexWaiter early if the thread is already waiting for a mutex owned by the owner thread. This accounts for the possibility of a thread that is waiting on a condition variable being awakened twice in a row. Also added more validation asserts. This should fix one of the random crashes in Breath Of The Wild.
* server_session: Provide more useful information and don't crash on bad IPC request.bunnei2018-08-121-0/+8
|
* hle_ipc: Make WriteToOutgoingCommandBuffer()'s reference parameter constLioncash2018-08-092-2/+2
| | | | | This function doesn't modify anything within the reference Thread instance.
* client_port: Make all data members privateLioncash2018-08-073-7/+21
| | | | | | | | These members don't need to be entirely exposed, we can instead expose an API to operate on them without directly needing to mutate them We can also guard against overflow/API misuse this way as well, given active_sessions is an unsigned value.
* kernel/event: Make data members privateLioncash2018-08-061-4/+8
| | | | | Instead we can simply provide accessors to the required data instead of giving external read/write access to the variables directly.
* address_arbiter: Return by value from GetThreadsWaitingOnAddress()Lioncash2018-08-051-15/+15
| | | | | In all cases the vector being supplied is empty, so we can just return by value in these instances.
* Merge pull request #914 from lioncash/codesetbunnei2018-08-042-15/+36
|\ | | | | kernel/process: Use accessors instead of class members for referencing segment array
| * kernel/process: Use std::array where applicableLioncash2018-08-031-1/+2
| |
| * kernel/process: Use accessors instead of class members for referencing segment arrayLioncash2018-08-032-15/+35
| | | | | | | | | | | | | | Using member variables for referencing the segments array increases the size of the class in memory for little benefit. The same behavior can be achieved through the use of accessors that just return the relevant segment.
* | kernel/thread: Fix potential crashes introduced in 26de4bb521b1ace7af76eff4f6956cb23ac0d58cLioncash2018-08-043-13/+38
|/ | | | | | This amends cases where crashes can occur that were missed due to the odd way the previous code was set up (using 3DS memory regions that don't exist).
* core/memory: Get rid of 3DS leftoversLioncash2018-08-039-302/+24
| | | | Removes leftover code from citra that isn't needed.
* Merge pull request #894 from lioncash/objectbunnei2018-08-0329-136/+164
|\ | | | | kernel: Move object class to its own source files
| * kernel: Move object class to its own source filesLioncash2018-08-0229-136/+164
| | | | | | | | | | | | General moving to keep kernel object types separate from the direct kernel code. Also essentially a preliminary cleanup before eliminating global kernel state in the kernel code.
* | Merge pull request #904 from lioncash/staticbunnei2018-08-031-8/+6
|\ \ | | | | | | kernel/thread: Minor changes
| * | kernel/thread: Make GetFreeThreadLocalSlot()'s loop indices size_tLioncash2018-08-021-8/+5
| | | | | | | | | | | | | | | | | | Avoids using a u32 to compare against a range of size_t, which can be a source of warnings. While we're at it, compress a std::tie into a structured binding.
| * | kernel/thread: Make GetFreeThreadLocalSlot() reference parameter a const referenceLioncash2018-08-021-1/+2
| | | | | | | | | | | | | | | This function only reads the data being referenced, it doesn't modify it, so we can turn the reference into a const reference.
| * | kernel/thread: Make GetFreeThreadLocalSlot() internally linkedLioncash2018-08-021-1/+1
| |/ | | | | | | | | This function isn't used outside of this translation unit, so we can make it internally linked.
* | kernel/vm_manager: Convert loop into std::any_of()Lioncash2018-08-021-4/+4
| |
* | kernel/vm_manager: Use const where applicableLioncash2018-08-023-19/+19
| | | | | | | | Makes our immutable state explicit.
* | kernel/vm_manager: Use the VAddr type alias in CarveVMA()Lioncash2018-08-021-2/+2
|/ | | | These two variables correspond to address ranges.
* kernel/thread: Remove unimplemented function prototypeLioncash2018-08-011-6/+0
| | | | | Given there's no implementation, we may as well remove the code entirely.
* Merge pull request #877 from lioncash/removebunnei2018-08-015-102/+0
|\ | | | | kernel: Remove unused object_address_table.cpp/.h
| * kernel: Remove unused object_address_table.cpp/.hLioncash2018-07-315-102/+0
| | | | | | | | | | | | These source files were entirely unused throughout the rest of the codebase. This also has the benefit of getting rid of a global variable as well.
* | kernel: Remove unnecessary includesLioncash2018-07-3122-27/+46
|/ | | | | Removes unnecessary direct dependencies in some headers and also gets rid of indirect dependencies that were being relied on to be included.
* kernel/timer: Make data members private where applicableLioncash2018-07-261-5/+17
| | | | | Instead, we can just expose functions that return the queryable state instead of letting anything modify it.
* Merge pull request #804 from lioncash/logMat M2018-07-251-1/+3
|\ | | | | svc: Log parameters in SetMemoryAttribute()
| * svc: Log parameters in SetMemoryAttribute()Lioncash2018-07-241-1/+3
| | | | | | | | Provides slightly more context than only logging out the address value.
* | Merge pull request #803 from MerryMage/core_timing_utilbunnei2018-07-252-0/+2
|\ \ | | | | | | core_timing: Split off utility functions into core_timing_util
| * | core_timing: Split off utility functions into core_timing_utilMerryMage2018-07-242-0/+2
| | |
* | | svc: Resolve sign comparison warnings in WaitSynchronization()Lioncash2018-07-241-4/+7
| |/ |/| | | | | | | The loop's induction variable was signed, but we were comparing against an unsigned variable.
* | Merge pull request #794 from lioncash/refbunnei2018-07-241-1/+1
|\ \ | |/ |/| mutex: Pass SharedPtr to GetHighestPriorityMutexWaitingThread() by reference
| * mutex: Pass SharedPtr to GetHighestPriorityMutexWaitingThread() by referenceLioncash2018-07-241-1/+1
| | | | | | | | | | The pointed to thread's members are simply observed in this case, so we don't need to copy it here.
* | hle_ipc: Make constructors explicit where applicableLioncash2018-07-241-1/+1
|/
* hle: Remove config_mem.h/.cppLioncash2018-07-233-13/+0
| | | | | This is just an unused hold-over from citra, so we can get rid of this to trim off an exposed global, among other things.
* hle: Remove shared_page.h/.cppLioncash2018-07-233-4/+0
| | | | This is a holdover from citra that's essentially unused.
* Kernel/SVC: Perform atomic accesses in SignalProcessWideKey as per the real kernel.Subv2018-07-221-7/+31
|
* Merge pull request #751 from Subv/tpidr_el0bunnei2018-07-213-0/+13
|\ | | | | CPU: Save and restore the TPIDR_EL0 system register on every context switch
| * CPU: Save and restore the TPIDR_EL0 system register on every context switch.Subv2018-07-213-0/+13
| | | | | | | | Note that there's currently a dynarmic bug preventing this register from being written.
* | thread: Convert ThreadStatus into an enum classLioncash2018-07-209-71/+70
|/ | | | | Makes the thread status strongly typed, so implicit conversions can't happen. It also makes it easier to catch mistakes at compile time.
* Merge pull request #726 from lioncash/overloadbunnei2018-07-202-6/+21
|\ | | | | hle_ipc: Introduce generic WriteBuffer overload for multiple container types
| * hle_ipc: Introduce generic WriteBuffer overload for multiple container typesLioncash2018-07-192-6/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This introduces a slightly more generic variant of WriteBuffer(). Notably, this variant doesn't constrain the arguments to only accepting std::vector instances. It accepts whatever adheres to the ContiguousContainer concept in the C++ standard library. This essentially means, std::array, std::string, and std::vector can be used directly with this interface. The interface no longer forces you to solely use containers that dynamically allocate. To ensure our overloads play nice with one another, we only enable the container-based WriteBuffer if the argument is not a pointer, otherwise we fall back to the pointer-based one.
* | Merge pull request #721 from lioncash/svcbunnei2018-07-201-3/+4
|\ \ | |/ |/| svc: Correct always true assertion case in SetThreadCoreMask
| * svc: Correct always true assertion case in SetThreadCoreMaskLioncash2018-07-191-3/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The reason this would never be true is that ideal_processor is a u8 and THREADPROCESSORID_DEFAULT is an s32. In this case, it boils down to how arithmetic conversions are performed before performing the comparison. If an unsigned value has a lesser conversion rank (aka smaller size) than the signed type being compared, then the unsigned value is promoted to the signed value (i.e. u8 -> s32 happens before the comparison). No sign-extension occurs here either. An alternative phrasing: Say we have a variable named core and it's given a value of -2. u8 core = -2; This becomes 254 due to the lack of sign. During integral promotion to the signed type, this still remains as 254, and therefore the condition will always be true, because no matter what value the u8 is given it will never be -2 in terms of 32 bits. Now, if one type was a s32 and one was a u32, this would be entirely different, since they have the same bit width (and the signed type would be converted to unsigned instead of the other way around) but would still have its representation preserved in terms of bits, allowing the comparison to be false in some cases, as opposed to being true all the time. --- We also get rid of two signed/unsigned comparison warnings while we're at it.
* | hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloadsLioncash2018-07-191-1/+1
|/ | | | | | | | | Previously, the buffer_index parameter was unused, causing all writes to use the buffer index of zero, which is not necessarily what is wanted all the time. Thankfully, all current usages don't use a buffer index other than zero, so this just prevents a bug before it has a chance to spring.
* Merge pull request #692 from lioncash/assignbunnei2018-07-191-1/+1
|\ | | | | address_arbiter: Correct assignment within an assertion statement in WakeThreads()
| * address_arbiter: Correct assignment within an assertion statement in WakeThreads()Lioncash2018-07-191-1/+1
| | | | | | | | | | | | This was introduced within 4f81bc4e1bd12e4df7410c6790ba818d8dbba9c0, and considering there's no comment indicating that this is intentional, this is very likely a bug.
* | Merge pull request #690 from lioncash/movebunnei2018-07-198-13/+21
|\ \ | | | | | | core/memory, core/hle/kernel: Use std::move where applicable
| * | core/memory, core/hle/kernel: Use std::move where applicableLioncash2018-07-198-13/+21
| |/ | | | | | | Avoids pointless copies
* | Merge pull request #688 from lioncash/commabunnei2018-07-191-22/+12
|\ \ | | | | | | vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()
| * | vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()Lioncash2018-07-191-22/+12
| |/ | | | | | | | | Without these, this would perform concatenation, which is definitely not what we want here.
* / core: Don't construct instance of Core::System, just to access its live instanceLioncash2018-07-191-6/+6
|/ | | | | | | | | This would result in a lot of allocations and related object construction, just to toss it all away immediately after the call. These are definitely not intentional, and it was intended that all of these should have been accessing the static function GetInstance() through the name itself, not constructed instances.
* Merge pull request #671 from MerryMage/clear-exclusive-statebunnei2018-07-171-0/+1
|\ | | | | scheduler: Clear exclusive state when switching contexts
| * scheduler: Clear exclusive state when switching contextsMerryMage2018-07-161-0/+1
| |
* | Merge pull request #672 from SciresM/to_address_fixbunnei2018-07-171-2/+4
|\ \ | | | | | | svc:: Fix bug in svcWaitForAddress
| * | Kernel/Arbiter: Fix bug in WaitIfLessThanMichael Scire2018-07-171-2/+4
| |/
* / nvflinger: Fix for BufferQueue event handling.bunnei2018-07-172-3/+11
|/
* No need to use ASSERT_MSG with an empty messageDavid Marcec2018-07-141-2/+2
|
* Update clang formatJames Rowe2018-07-036-38/+35
|
* Rename logging macro back to LOG_*James Rowe2018-07-0311-79/+79
|
* Merge pull request #579 from SciresM/masterbunnei2018-06-228-9/+295
|\ | | | | svc: Fully implement svcSignalToAddress and svcWaitForAddress
| * Kernel/Arbiters: Fix casts, cleanup comments/magic numbersMichael Scire2018-06-222-17/+16
| |
| * Add additional missing format.Michael Scire2018-06-222-21/+27
| |
| * Run clang-format on PR.Michael Scire2018-06-223-180/+181
| |
| * Kernel/Arbiters: HLE is atomic, adjust code to reflect that.Michael Scire2018-06-222-37/+13
| |
| * Kernel/Arbiters: Initialize arb_wait_address in thread struct.Michael Scire2018-06-212-1/+5
| |
| * Kernel/Arbiters: Clear WaitAddress in SignalToAddressMichael Scire2018-06-211-0/+1
| |
| * Kernel/Arbiters: Mostly implement SignalToAddressMichael Scire2018-06-214-10/+110
| |
| * Kernel/Arbiters: Implement WaitForAddressMichael Scire2018-06-214-6/+67
| |
| * Kernel/Arbiters: Add stubs for 4.x SignalToAddress/WaitForAddres SVCs.Michael Scire2018-06-217-9/+147
| |
* | IPC: skip empty buffer writemailwl2018-06-221-0/+5
|/ | | | prevent yuzu crash, if games, like Axiom Verge, trying to read 0 bytes from file
* Build: Fixed some MSVC warnings in various parts of the code.Subv2018-06-201-2/+2
|
* Merge pull request #572 from Armada651/user-except-stubbunnei2018-06-181-0/+5
|\ | | | | svc: Add a stub for UserExceptionContextAddr.
| * svc: Add a stub for UserExceptionContextAddr.Jules Blok2018-06-181-0/+5
| |
* | Kernel/Threads: A thread waking up by timeout from a WaitProcessWideKey may already have an assigned lock owner.Subv2018-06-021-2/+5
| | | | | | | | | | | | | | | | | | | | This situation may happen like so: Thread 1 with low priority calls WaitProcessWideKey with timeout. Thread 2 with high priority calls WaitProcessWideKey without timeout. Thread 3 calls SignalProcessWideKey - Thread 2 acquires the lock and awakens. - Thread 1 can't acquire the lock and is put to sleep with the lock owner being Thread 2. Thread 1's timeout expires, with the lock owner still being set to Thread 2.
* | Kernel/Thread: Corrected a typo that caused the affinity mask to never be changed.Subv2018-05-311-2/+2
| |
* | Kernel/SVC: Support special core values -2 and -3 in svcSetThreadCoreMask.Subv2018-05-312-1/+28
| | | | | | | | Also added some proper error handling.
* | Kernel/Thread: Corrected a typo in an assert about the processor id.Subv2018-05-301-1/+1
| |
* | Add & correct miscellaneous things (#470)greggameplayer2018-05-261-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | * add some InfoType * correct OpenApplicationProxy cmd number * add IDisplayController functions * fix clang-format * add more system languages
* | Merge pull request #454 from Subv/signal_processwidebunnei2018-05-231-83/+74
|\ \ | | | | | | Kernel/SVC: Signal the highest priority threads first in svcSignalProcessWideKey
| * | Kernel/SVC: Signal the highest priority threads first in svcSignalProcessWideKey.Subv2018-05-191-51/+68
| | |
| * | Kernel/Threads: Reschedule the proper core when operating on that core's threads.Subv2018-05-191-2/+6
| | |
| * | SVC: Removed unused WaitSynchronization1 functionSubv2018-05-191-30/+0
| | |
* | | Merge pull request #457 from Subv/mutex_waitersbunnei2018-05-211-1/+0
|\ \ \ | | | | | | | | Mutex: Do not assert when the mutex waiting threads list isn't empty on mutex release.
| * | | Mutex: Do not assert when the mutex waiting threads list isn't empty on mutex release.Subv2018-05-201-1/+0
| |/ / | | | | | | | | | A thread may own multiple mutexes at the same time, and only release one of them while other threads are waiting for the other mutexes.
* / / Added RequestWithContext & ControlWithContextDavid Marcec2018-05-171-1/+3
|/ /
* | thread: Rename mask to affinity_masks.bunnei2018-05-113-4/+4
| |
* | thread: Support core change on ResumeFromWait and improve ChangeCore.bunnei2018-05-111-37/+68
| |
* | scheduler: Protect scheduling functions with a global mutex.bunnei2018-05-112-0/+18
| |
* | thread: Initialize ideal_core and mask members.bunnei2018-05-111-0/+2
| |
* | threading: Reschedule only on cores that are necessary.bunnei2018-05-112-3/+3
| |
* | svc: Implement GetThreadCoreMask and SetThreadCoreMask.bunnei2018-05-111-7/+22
| |
* | thread: Implement ChangeCore function.bunnei2018-05-112-1/+58
| |
* | svc: SignalProcessWideKey should apply to all cores.bunnei2018-05-111-43/+50
| |
* | svc: Implement GetCurrentProcessorNumber.bunnei2018-05-111-2/+2
| |
* | core: Implement multicore support.bunnei2018-05-115-45/+65
| |
* | Merge pull request #431 from lioncash/fmtbunnei2018-05-026-49/+50
|\ \ | | | | | | general: Make formatting of logged hex values more straightforward
| * | general: Make formatting of logged hex values more straightforwardLioncash2018-05-026-49/+50
| | | | | | | | | | | | | | | | | | This makes the formatting expectations more obvious (e.g. any zero padding specified is padding that's entirely dedicated to the value being printed, not any pretty-printing that also gets tacked on).
* | | ipc: Add support for PopIpcInterface() method.bunnei2018-05-022-0/+15
|/ / | | | | | | - This can be used for domain objects as inputs to service functions.
* | GetSharedFontInOrderOfPriority (#381)David2018-05-012-23/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * GetSharedFontInOrderOfPriority * Update pl_u.cpp * Ability to use ReadBuffer and WriteBuffer with different buffer indexes, fixed up GetSharedFontInOrderOfPriority * switched to NGLOG * Update pl_u.cpp * Update pl_u.cpp * language_code is actually language code and not index * u32->u64 * final cleanups
* | core_timing: Namespace all functions and constants in core_timing's headerLioncash2018-04-302-3/+5
| | | | | | | | All of these variables and functions are related to timings and should be within the namespace.
* | string_util: Remove StringFromFormat() and related functionsLioncash2018-04-301-1/+1
| | | | | | | | Given we utilize fmt, we don't need to provide our own functions for formatting anymore
* | core: Replace usages of LOG_GENERIC with new fmt-capable equivalentsLioncash2018-04-273-6/+4
| |
* | general: Convert assertion macros over to be fmt-compatibleLioncash2018-04-274-9/+9
| |
* | kernel/shared_memory: Remove unnecessary semicolon at end of ConvertPermissions()Lioncash2018-04-261-1/+1
| | | | | | | | Functions don't need to be terminated by semicolons.
* | kernel: Migrate logging macros to fmt-compatible onesLioncash2018-04-2611-106/+109
| |
* | Merge pull request #370 from Subv/sync_primitivesbunnei2018-04-239-435/+228
|\ \ | | | | | | Kernel: Reworked the new kernel synchronization primitives.
| * | Kernel: Implemented mutex priority inheritance.Subv2018-04-234-10/+94
| | | | | | | | | | | | | | | | | | | | | Verified with a hwtest and implemented based on reverse engineering. Thread A's priority will get bumped to the highest priority among all the threads that are waiting for a mutex that A holds. Once A releases the mutex and ownership is transferred to B, A's priority will return to normal and B's priority will be bumped.
| * | Kernel: Use 0x2C as default main thread priority for homebrew and lone NRO/NSOsSubv2018-04-211-1/+1
| | |
| * | Qt: Update the WaitTree widget to show info about the current mutex of each thread.Subv2018-04-211-4/+0
| | |
| * | Kernel: Remove unused ConditionVariable class.Subv2018-04-215-148/+0
| | |
| * | Kernel: Remove old and unused Mutex code.Subv2018-04-214-209/+3
| | |
| * | Kernel: Properly implemented svcWaitProcessWideKey and svcSignalProcessWideKeySubv2018-04-211-83/+46
| | | | | | | | | | | | They work in tandem with guest code to provide synchronization primitives along with svcArbitrateLock/Unlock
| * | Kernel: Corrected the implementation of svcArbitrateLock and svcArbitrateUnlock.Subv2018-04-216-22/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Switch mutexes are no longer kernel objects, they are managed in userland and only use the kernel to handle the contention case. Mutex addresses store a special flag value (0x40000000) to notify the guest code that there are still some threads waiting for the mutex to be released. This flag is updated when a thread calls ArbitrateUnlock. TODO: * Fix svcWaitProcessWideKey * Fix svcSignalProcessWideKey * Remove the Mutex class.
* | | resource_limit: Make ResourceTypes an enum classLioncash2018-04-213-38/+38
|/ / | | | | | | Prevents enum identifiers from leaking into the surrounding scope.
* | common_funcs: Remove ARRAY_SIZE macroLioncash2018-04-201-1/+2
| | | | | | | | C++17 has non-member size() which we can just call where necessary.
* | Various service name fixes - part 2 (rebased) (#322)Hexagon122018-04-171-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Updated ACC with more service names * Updated SVC with more service names * Updated set with more service names * Updated sockets with more service names * Updated SPL with more service names * Updated time with more service names * Updated vi with more service names
* | vm_manager: Increase GetTotalMemoryUsage value.bunnei2018-04-151-1/+1
| | | | | | | | - Gets Binding of Isaac running.
* | svc: Stub out SetThreadActivity, GetThreadContext.bunnei2018-04-032-2/+19
| |
* | shared_memory: Remove incorrect 3ds-specific check.bunnei2018-04-031-12/+0
| |
* | hle_ipc, fsp_srv: Cleanup logging.bunnei2018-04-011-1/+1
| |
* | hle_ipc: Do not ensure write buffer size.bunnei2018-03-311-2/+5
| |
* | memory: Fix stack region.bunnei2018-03-312-3/+4
| |
* | svc: Stub GetThreadCoreMask.bunnei2018-03-302-3/+26
| |
* | Clang FixesN00byKing2018-03-192-5/+5
| |
* | More Warning cleanupsN00byKing2018-03-192-2/+2
| |
* | Clean Warnings (?)N00byKing2018-03-195-8/+8
| |
* | hle_ipc: Add SleepClientThread to block current thread within HLE routines.bunnei2018-03-192-0/+47
| |
* | hle_ipc: Use shared_ptr instead of unique_ptr to allow copies.bunnei2018-03-192-9/+9
| |
* | hle_ipc: Remove GetPointer(..) usage with WriteToOutgoingCommandBuffer.bunnei2018-03-192-5/+13
| |
* | thread: Add THREADSTATUS_WAIT_HLE_EVENT, remove THREADSTATUS_WAIT_ARB.bunnei2018-03-193-20/+6
| |
* | process: MirrorMemory should use MemoryState::Mapped.bunnei2018-03-171-1/+1
| |
* | process: Unmap previously allocated heap.bunnei2018-03-161-1/+3
| |
* | arm_interface: Support unmapping previously mapped memory.bunnei2018-03-161-0/+3
| |
* | svc: Use more correct values for GetInfo MapRegion and NewMapRegion.bunnei2018-03-163-29/+5
| |
* | kernel: Move stack region outside of application heap.bunnei2018-03-163-8/+3
| |
* | process: Fix stack memory state.bunnei2018-03-161-2/+4
| |
* | MemoryState: Add additional memory states and improve naming.bunnei2018-03-165-18/+45
| |
* | core: Move process creation out of global state.bunnei2018-03-149-33/+36
| |
* | Merge pull request #216 from Subv/savedatabunnei2018-03-022-9/+8
|\ \ | | | | | | Implemented the SaveData archive and MountSaveData.
| * | Kernel: Store the program id in the Process class instead of the CodeSet class.Subv2018-03-022-9/+8
| |/ | | | | | | There may be many CodeSets per Process, so it's wasteful and overcomplicated to store the program id in each of them.
* / thread: Clear the process list on shutdown.Jules Blok2018-02-271-1/+3
|/
* Merge pull request #207 from mailwl/duplicatesessionbunnei2018-02-272-5/+10
|\ | | | | IPC: add domain header to response if only it exists in request
| * Add warning if Domain request has no domain message headermailwl2018-02-201-0/+3
| |
| * Fix: change check for domain order and existance of domain message headermailwl2018-02-202-2/+2
| |
| * IPC: add domain header to response if only it exists in requestmailwl2018-02-202-5/+7
| |
* | Merge pull request #215 from N00byKing/umapsharedmmrybunnei2018-02-262-1/+17
|\ \ | | | | | | UnmapSharedMemory
| * | (Hopefully) Fix MinGW BuildN00byKing2018-02-251-1/+1
| | |
| * | Add UnmapSharedMemoryN00byKing2018-02-252-1/+17
| |/ | | | | | | | | | | | | | | C++11 requires spaces on the Identifier Add inttypes include clang
* / Stub more functionsmailwl2018-02-221-1/+11
|/
* scheduler: Cleanup based on PR feedback.bunnei2018-02-192-4/+3
|
* kernel: Use Scheduler class for threading.bunnei2018-02-183-172/+16
|
* kernel: Add Scheduler, which encapsulates the scheduling loading from Thread module.bunnei2018-02-182-0/+208
|
* kernel: Remove unused address_arbiter code.bunnei2018-02-184-197/+0
|
* Kernel/IPC: Add a small delay after each SyncRequest to prevent thread starvation.Subv2018-02-184-50/+63
| | | | | | | | Ported from citra PR #3091 The delay specified here is from a Nintendo 3DS, and should be measured in a Nintendo Switch. This change is enough to prevent Puyo Puyo Tetris's main thread starvation.
* Service/hid: stub some functionsmailwl2018-02-162-0/+53
|
* shared_memory: Remove some checks.bunnei2018-02-151-13/+0
|
* Merge pull request #188 from bunnei/refactor-buffer-descriptorbunnei2018-02-152-0/+59
|\ | | | | Refactor IPC buffer descriptor interface
| * hle_ipc: Remove const from WriteBuffer size.bunnei2018-02-142-2/+2
| |
| * hle_ipc: Add GetReadBufferSize and check write buffer size.bunnei2018-02-142-0/+10
| |
| * hle_ipc: Add helper functions for reading and writing buffers.bunnei2018-02-141-4/+2
| |
| * hle_ipc: Add helper functions for reading and writing buffers.bunnei2018-02-142-0/+51
| |
* | thread: Silence formatting specifier warningsLioncash2018-02-141-2/+3
| |
* | vm_manager: Silence formatting specifier warningsLioncash2018-02-141-5/+7
|/
* mutex: Update hasWaiters on release.bunnei2018-02-061-0/+1
|
* GetInfo: Implement IsCurrentProcessBeingDebugged.bunnei2018-02-041-0/+3
|
* WaitProcessWideKeyAtomic: Handle case where condition variable was already created.bunnei2018-02-043-13/+17
|
* svc: SharedMemory size should be 64-bits and cleanup.bunnei2018-02-033-11/+11
|
* ArbitrateLock: Assert that requesting_thread is current_thread.bunnei2018-02-031-0/+1
|
* shared_memory: Only mark addresses as invalid if they are within the heapshinyquagsire232018-01-301-1/+2
|
* Merge pull request #148 from MerryMage/feature/special-memorybunnei2018-01-272-6/+6
|\ | | | | memory: Replace all memory hooking with Special regions
| * memory: Replace all memory hooking with Special regionsMerryMage2018-01-272-6/+6
| |
* | server_session: Fix scenario where all domain handlers are closed.bunnei2018-01-251-3/+3
| |
* | hle: Rename RequestBuilder to ResponseBuilder.bunnei2018-01-251-1/+1
| |
* | ipc_helpers: Make interface domain agnostic and add header validation.bunnei2018-01-251-1/+12
| |
* | hle: Integrate Domain handling into ServerSession.bunnei2018-01-255-28/+66
| |
* | hle: Remove Domain and SyncObject kernel objects.bunnei2018-01-257-164/+2
| |
* | handle_table: Remove ConvertSessionToDomain.bunnei2018-01-252-17/+0
|/
* Format: Run the new clang format on everythingJames Rowe2018-01-2122-31/+32
|
* Added CreateSharedMemory & UNIMPLEMENTED() for non existent services. (#113)David2018-01-202-1/+22
| | | | | | | | | | | | * Added svcCreateSharedMemory * Services which are not implemented now throw UNIMPLEMENTED() * clang-format * changed perms to u32 * removed camelcase
* Fixes some cast warnings, partial port of citra #3064 (#106)River City Ransomware2018-01-202-2/+2
| | | | | | | | * Fixes some cast warnings, partially fixes citra #3064 * Converted casts to uint32_t to u32 * Ran clang-format
* svc: Fix svcGetInfo MapRegionBaseAddr.bunnei2018-01-193-1/+9
|
* svc: Add additional fields to MemoryInfo struct.bunnei2018-01-191-0/+4
|
* Stub PopLaunchParameter and implement Buffer C Descriptors reading on hle_ipc (#96)gdkchan2018-01-182-7/+33
| | | | | | | | | | * Stub PopLaunchParameter and implement Buffer C Descriptors reading * Address PR feedback * Ensure we push a u64 not a size_t * Fix formatting
* svc: Rename some entries to match their analogue on SwitchBrewLioncash2018-01-181-7/+7
| | | | Makes the codebase a little more consistent with regards to available documentation. Also amends the duplicate case where there was a similar entry at 0x72 named ConnectToPort.
* svc: Add CreateJitMemory and MapJitMemory svc stringsLioncash2018-01-181-2/+2
| | | | Makes the table match SwitchBrew for these entries
* svc: Clang-format fix.bunnei2018-01-171-6/+4
|
* hle_ipc: Clang format.bunnei2018-01-171-2/+3
|
* ipc: Implement domain command CloseVirtualHandle.bunnei2018-01-172-2/+28
|
* SVC: Correct some return values in svcGetInfo and added TitleId and PrivilegedProcessId stubs.Subv2018-01-171-6/+21
| | | | | # Conflicts: # src/core/hle/kernel/svc.cpp
* SVC: Add 4.0.0+ comment to GetInfoType enum values.Subv2018-01-171-0/+1
|
* IPC: Push domain objects as move handles when not in a domain.Subv2018-01-171-0/+8
|
* Merge pull request #52 from ogniK5377/fspbunnei2018-01-174-3/+35
|\ | | | | added more svcGetInfo pairs for 3.0.0+ support, Changed HEAP_SIZE and TLS_AREA_VADDR. changed mem usage & heap usage stub added, ISelfController, IApplication function stubs. Added SetThreadCoreMask
| * SetThreadCoreMask stub, time to implement fspDavid Marcec2018-01-161-1/+6
| |
| * Added more svcGetInfo pairsDavid Marcec2018-01-164-2/+29
| |
* | clang-formatMerryMage2018-01-166-18/+14
|/
* shared_memory: Minor fixes and cleanup.bunnei2018-01-141-6/+6
|
* svc: Implement svcMapSharedMemory.bunnei2018-01-142-1/+38
|
* kernel: Increase default stack size to 64K.bunnei2018-01-141-1/+1
|
* yuzu: Update license text to be consistent across project.bunnei2018-01-1314-14/+14
|
* core: Include <algorithm> where used.bunnei2018-01-121-0/+2
|
* core: Fix recent GCC build breaks.bunnei2018-01-121-2/+2
|
* svc: Implement GetSystemTick.bunnei2018-01-122-2/+21
|
* IPC: Corrected some definitions for the buffer C descriptor flags.Subv2018-01-112-1/+8
|
* svc: Stub ResetSignal and CreateTransferMemorySubv2018-01-112-3/+28
|
* svc: Stub SetMemoryAttributeSubv2018-01-112-0/+11
|
* Threads: Added enum values for the Switch's 4 cpu cores and implemented svcGetInfo(AllowedCpuIdBitmask)Subv2018-01-104-10/+25
|
* SVC: Fixed WaitSynchronization with multiple handles when none is immediately ready.Subv2018-01-091-7/+18
|
* SVC: Implemented CancelSynchronization.Subv2018-01-092-1/+19
|
* ErrorCodes: Updated the InvalidHandle and Timeout kernel error codes.Subv2018-01-091-2/+7
|
* SVC: Fixed WaitSynchronization with multiple handles when at least one of them is ready.Subv2018-01-092-3/+29
|
* kernel: Rename Semaphore to ConditionVariable.bunnei2018-01-098-159/+167
|
* mutex: Remove unused call to VerifyGuestState.bunnei2018-01-091-3/+0
|
* Kernel: Actually wake up the requested number of threads in Semaphore::Release.Subv2018-01-093-18/+16
| | | | | | Also properly keep track of data in guest memory, this fixes managing the semaphore from userland. It was found that Semaphores are actually Condition Variables, with Release(1) and Release(-1) being equivalent to notify_one and notify_all. We should change the name of the class to reflect this.
* Kernel: Properly keep track of mutex lock data in the guest memory. This fixes userland locking/unlocking.Subv2018-01-093-63/+60
|
* Kernel: Allow chaining WaitSynchronization calls inside a wakeup callback.Subv2018-01-094-30/+78
|
* CoreTiming: Reworked CoreTiming (cherry-picked from Citra #3119)B3n302018-01-092-9/+5
| | | | * CoreTiming: New CoreTiming; Add Test for CoreTiming
* IPC: Add functions to read the input move/copy objects from an IPC request.Subv2018-01-072-2/+26
|
* IPC: Don't attempt to read the command buffer if it holds a Close request.Subv2018-01-071-0/+5
|
* IPC Cleanup: Remove 3DS-specific code and translate copy, move and domain objects in IPC requests.Subv2018-01-072-74/+72
| | | | Popping objects from the buffer is still not implemented.
* IPC: Skip the entire u64 of the command id when receiving an IPC request.Subv2018-01-071-1/+2
| | | | Service code now doesn't have to deal with this.
* IPC: Use the correct size when pushing raw data to the command buffer and fixed pushing domain objects.Subv2018-01-072-3/+7
| | | | Domain object ids are always stored immediately after the raw data.
* svc: Implement svcSignalProcessWideKey.bunnei2018-01-072-4/+23
|
* semaphore: More changes for Switch.bunnei2018-01-072-11/+17
|
* wait_object: Refactor to allow waking up a single thread.bunnei2018-01-072-15/+28
|
* svc: Implement svcWaitProcessWideKeyAtomic.bunnei2018-01-062-1/+54
|
* semaphore: Updates for Switch.bunnei2018-01-062-21/+31
|
* svc: Implement WaitSynchronization for a single handle.bunnei2018-01-061-4/+24
|
* svc: Refactor LockMutex code to use WaitSynchronization1.bunnei2018-01-061-13/+45
|
* svc: Add missing string_util include.bunnei2018-01-051-0/+1
|
* arm: Remove SkyEye/Dyncom code that is ARMv6-only.bunnei2018-01-032-23/+11
|
* vm_manager: Use a more reasonable MAX_ADDRESS size.bunnei2018-01-031-5/+4
|
* svc: Remove unnecessary "svc" prefix to naming scheme.bunnei2018-01-031-106/+106
|
* hle: Move SVC code to kernel namespace.bunnei2018-01-033-0/+805
|
* vm_manager: Stub out a bunch of interfaces used by svcGetInfo.bunnei2018-01-012-1/+51
|
* core/video_core: Fix a bunch of u64 -> u32 warnings.bunnei2018-01-011-2/+2
|
* svc: Implement svcExitProcess.bunnei2018-01-012-7/+38
|
* svc: Implement svcLockMutex.bunnei2018-01-012-23/+95
|
* kernel: Add ObjectAddressTable class.bunnei2018-01-013-2/+101
|
* thread: Keep track of the initially created handle.bunnei2017-12-312-1/+5
| | | | This is kinda crufty, but we need it for now to update guest state variables.
* errors: Define missing kernel error codes.bunnei2017-12-311-0/+3
|
* svc: Implement svcUnmapMemory.bunnei2017-12-312-0/+7
|
* thread: Main thread should set thread handle to reg 1.bunnei2017-12-301-1/+4
|
* thread: Remove THUMB mode flag.bunnei2017-12-301-1/+1
|
* thread: Main thread should be ready by default, all others dormant.bunnei2017-12-301-4/+3
|
* kernel: Various 64-bit fixes in memory/process/threadbunnei2017-12-295-14/+14
|
* kernel: Fix implementation of ConvertSessionToDomain.bunnei2017-12-296-30/+67
|
* kernel: Add basic support for Domain object.bunnei2017-12-294-4/+110
|
* kernel: Add SyncObject primitive, use it for ClientSession.bunnei2017-12-292-8/+38
|
* process: Add method to mirror a memory region.bunnei2017-12-292-0/+27
|
* service: Return proper result code for IPC::CommandType::Close.bunnei2017-11-012-6/+7
|
* hle: Use Switch formatted result codes.bunnei2017-11-012-77/+22
|
* hle: Fix QueryMemory response for MemoryInfo.bunnei2017-10-204-115/+14
|
* hle_ipc: Only copy necessary fields for outgoing command buffer.bunnei2017-10-191-1/+1
|
* hle_ipc: Parse out buffer X/A/B/B descriptors from incoming command buffer.bunnei2017-10-192-14/+19
|
* hle: Implement ConvertSessionToDomain, various cleanups.bunnei2017-10-153-5/+31
|
* hle: Initial implementation of NX service framework and IPC.bunnei2017-10-152-70/+107
|
* Merge remote-tracking branch 'upstream/master' into nxbunnei2017-10-1018-103/+143
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | # Conflicts: # src/core/CMakeLists.txt # src/core/arm/dynarmic/arm_dynarmic.cpp # src/core/arm/dyncom/arm_dyncom.cpp # src/core/hle/kernel/process.cpp # src/core/hle/kernel/thread.cpp # src/core/hle/kernel/thread.h # src/core/hle/kernel/vm_manager.cpp # src/core/loader/3dsx.cpp # src/core/loader/elf.cpp # src/core/loader/ncch.cpp # src/core/memory.cpp # src/core/memory.h # src/core/memory_setup.h
| * Merge pull request #2977 from Subv/shmem_createbunnei2017-10-031-15/+12
| |\ | | | | | | SharedMemory: Don't take over and unmap the source memory block when creating a shared memory, just reference it
| | * Kernel/SharedMemory: Don't take over and unmap the source memory block when creating a shared memory, just reference it.Subv2017-10-021-15/+12
| | | | | | | | | | | | Also reference the right offset into the backing block for the requested address.
| * | Merge pull request #2971 from Subv/per_process_memopsSebastian Valle2017-10-012-0/+12
| |\ \ | | |/ | |/| Memory: Add overloads for ReadBlock and WriteBlock that operate on a specific process.
| | * Kernel/Thread: Added a helper function to get a thread's command buffer VAddr.Subv2017-10-012-0/+12
| | |
| * | Merge pull request #2967 from Subv/thread_wakeup_callbacksSebastian Valle2017-09-303-13/+26
| |\ \ | | |/ | |/| Kernel/Threads: When putting a thread to wait, specify a function to execute when it is awoken
| | * Kernel/Threads: When putting a thread to wait, specify a function to execute when it is awoken.Subv2017-09-283-13/+26
| | | | | | | | | | | | | | | | | | This change makes for a clearer (less confusing) path of execution in the scheduler, now the code to execute when a thread awakes is closer to the code that puts the thread to sleep (WaitSynch1, WaitSynchN). It also allows us to implement the special wake up behavior of ReplyAndReceive without hacking up WaitObject::WakeupAllWaitingThreads. If savestates are desired in the future, we can change this implementation to one similar to the CoreTiming event system, where we first register the callback functions at startup and assign their identifiers to the Thread callback variable instead of directly assigning a lambda to the wake up callback variable.
| * | Fixed type conversion ambiguityHuw Pascoe2017-09-309-23/+24
| | |
| * | Kernel/Thread: Allow specifying which process a thread belongs to when creating it.Subv2017-09-273-15/+19
| |/ | | | | | | Don't automatically assume that Thread::Create will only be called when the parent process is currently scheduled. This assumption will be broken when applets or system modules are loaded.
| * memory: Add GetCurrentPageTable/SetCurrentPageTableMerryMage2017-09-241-7/+4
| | | | | | | | Don't expose Memory::current_page_table as a global.
| * Merge pull request #2842 from Subv/switchable_page_tableB3n302017-09-155-30/+33
| |\ | | | | | | Kernel/Memory: Give each process its own page table and allow switching the current page table upon reschedule
| | * Kernel/Threads: Don't clear the CPU instruction cache when performing a context switch from an idle thread into a thread in the same process.Subv2017-09-151-1/+3
| | | | | | | | | | | | We were unnecessarily clearing the cache when going from Process A -> Idle -> Process A, this caused extreme performance regressions.
| | * Kernel/Memory: Changed GetPhysicalPointer so that it doesn't go through the current process' page table to obtain a pointer.Subv2017-09-152-25/+7
| | |
| | * Kernel/Memory: Switch the current page table when a new process is scheduled.Subv2017-09-101-0/+10
| | |
| | * Kernel/Memory: Give each Process its own page table.Subv2017-09-102-5/+14
| | | | | | | | | | | | The loader is in charge of setting the newly created process's page table as the main one during the loading process.
| * | Merge pull request #2839 from Subv/global_kernel_lockJames Rowe2017-08-241-1/+1
| |\ \ | | | | | | | | Kernel/HLE: Use a mutex to synchronize access to the HLE kernel state between the cpu thread and any other possible threads that might touch the kernel (network thread, etc).
| | * | Kernel/HLE: Use a mutex to synchronize access to the HLE kernel state between the cpu thread and any other possible threads that might touch the kernel (network thread, etc).Subv2017-08-221-1/+1
| | | | | | | | | | | | | | | | This mutex is acquired in SVC::CallSVC, ie, as soon as the guest application enters the HLE kernel, and should be acquired by the aforementioned threads before modifying kernel structures.
| * | | Merge pull request #2893 from Subv/not_schedule_main_threadbunnei2017-08-221-5/+1
| |\ \ \ | | | | | | | | | | Kernel/Threads: Don't immediately switch to the new main thread when loading a new process.
| | * | | Kernel/Threads: Don't immediately switch to the new main thread when loading a new process.Subv2017-08-221-5/+1
| | | |/ | | |/| | | | | | | | | | | | | This is necessary for loading multiple processes at the same time. The main thread will be automatically scheduled when necessary once the scheduler runs.
| * / | Warnings: Add UNREACHABLE macros to switches that contemplate all possible values.Subv2017-08-211-0/+3
| |/ /
* | | loader: Various improvements for NSO/NRO loaders.bunnei2017-10-102-4/+4
| | |
* | | nso: Refactor and allocate .bss section.bunnei2017-09-302-8/+10
| | |
* | | process: Support loading multiple codesets.bunnei2017-09-302-20/+27
| | |
* | | kernel: Various threading fixes to support 64-bit addressing.bunnei2017-09-302-8/+8
| | |
* | | core: Various changes to support 64-bit addressing.bunnei2017-09-302-21/+21
|/ /
* | Merge pull request #2799 from yuriks/virtual-cached-range-flushWeiyi Wang2017-07-221-1/+1
|\ \ | |/ |/| Add address conversion functions returning optional, Add function to flush virtual region from rasterizer cache
| * Memory: Make PhysicalToVirtualAddress return a boost::optionalYuri Kunde Schlesner2017-06-221-1/+1
| | | | | | | | And fix a few places in the code to take advantage of that.
* | Merge pull request #2793 from Subv/replyandreceiveSebastian Valle2017-06-304-11/+39
|\ \ | | | | | | Kernel/SVC: Partially implemented svcReplyAndReceive
| * | Kernel/SVC: Pass the current thread as a parameter to ClientSession::SendSyncRequest.Subv2017-06-292-3/+6
| | |
| * | Kernel/Sessions: Clean up the list of pending request threads of a session when the client endpoint is closed.Subv2017-06-261-0/+5
| | |
| * | Kernel/ServerSession: Keep track of which threads have issued sync requests.Subv2017-06-253-9/+29
| | |
* | | Kernel: Implement AcceptSession SVCYuri Kunde Schlesner2017-06-233-2/+26
| | |
* | | Kernel/IPC: Support translation of null handlesYuri Kunde Schlesner2017-06-211-7/+12
| |/ |/| | | | | | | Missed this in my first implementation. Thanks to @wwylele for pointing out that this was missing.
* | Merge pull request #2789 from yuriks/misc-kernelWeiyi Wang2017-06-211-0/+2
|\ \ | | | | | | Trivial no-op additions
| * | Kernel: Add comment about the extended linear heap areaYuri Kunde Schlesner2017-06-191-0/+2
| |/
* | Merge pull request #2790 from yuriks/remove-movefromYuri Kunde Schlesner2017-06-214-7/+7
|\ \ | | | | | | Remove ResultVal::MoveFrom
| * | ResultVal: Remove MoveFrom()Yuri Kunde Schlesner2017-06-194-7/+7
| |/ | | | | | | | | Replace it with std::move(result_val).Unwrap(), or Foo().Unwrap() in case you already have an rvalue.
* / Kernel/IPC: Make HLERequestContext usable from outside kernelYuri Kunde Schlesner2017-06-192-3/+9
|/
* Kernel/IPC: Use boost::small_vector for HLE context objectsYuri Kunde Schlesner2017-06-121-1/+3
|
* Kernel: Allow clearing request_objects to re-use buffer spaceYuri Kunde Schlesner2017-06-112-0/+11
| | | | | Reduces the necessary allocation to max(in_handles, out_handles) rather than (in_handles + out_handles).
* Kernel: Basic support for IPC translation for HLE servicesYuri Kunde Schlesner2017-06-112-6/+125
|
* Kernel: Add methods in HLERequestContext abstracting handle creationYuri Kunde Schlesner2017-06-112-0/+12
|
* ServiceFramework: Use separate copy of command bufferYuri Kunde Schlesner2017-06-111-3/+6
| | | | | | Copy the IPC command buffer to/from the request context before/after the handler is invoked. This is part of a move away from using global data for handling IPC requests.
* Merge pull request #2756 from yuriks/service-frameworkYuri Kunde Schlesner2017-06-092-6/+42
|\ | | | | New service framework
| * Service: Add new ServiceFramework framework for writing HLE servicesYuri Kunde Schlesner2017-06-082-2/+36
| | | | | | | | | | | | | | | | | | | | | | | | The old "Interface" class had a few problems such as using free functions (Which didn't allow you to write the service handler as if it were a regular class.) which weren't very extensible. (Only received one parameter with a pointer to the Interface object.) The new ServiceFramework aims to solve these problems by working with member functions and passing a generic context struct as parameter. This struct can be extended in the future without having to update all existing service implementations.
| * Kernel: Remove some unnecessary namespace qualificationsYuri Kunde Schlesner2017-06-061-4/+6
| |
* | Session: Remove/add some forward declarationsYuri Kunde Schlesner2017-06-082-1/+2
| |
* | Kernel: Ensure objects are kept alive during ClientSession disconnectionYuri Kunde Schlesner2017-06-081-7/+13
|/ | | | Fixes #2760
* Kernel: Add a dedicated SetHleHandler method to ServerPort/ServerSessionYuri Kunde Schlesner2017-06-067-33/+36
| | | | | | This allows attaching a HLE handle to a ServerPort at any point after it is created, allowing port/session creation to be generic between HLE and regular services.
* HLE: Move SessionRequestHandler from Service:: to Kernel::Yuri Kunde Schlesner2017-06-068-15/+90
| | | | | Most of the code that works with this is or will be in the kernel, so it's a more appropriate place for it to be.
* Kernel: Move HandleTable to a separate fileYuri Kunde Schlesner2017-05-3013-202/+234
|
* Kernel: Move WaitObject to a separate fileYuri Kunde Schlesner2017-05-3011-132/+173
| | | | | Now that HandleTable doesn't directly depend on WaitObject anymore, this can be separated from the main kernel.h header.
* Kernel: Removed HandleTable::GetWaitObjectYuri Kunde Schlesner2017-05-301-9/+0
| | | | | This isn't necessary anymore since plain Get works correctly for WaitObjects.
* Kernel: Extract dynamic Object pointer cast into its own functionYuri Kunde Schlesner2017-05-291-11/+24
|
* Kernel: Centralize error definitions in errors.hYuri Kunde Schlesner2017-05-2513-46/+133
|
* Merge pull request #2406 from Subv/session_disconnectYuri Kunde Schlesner2017-05-226-51/+82
|\ | | | | Kernel: Properly update port counters on session disconnection.
| * Kernel/Sessions: Remove the ClientSession::Create function.Subv2017-05-223-16/+3
| | | | | | | | It is not meant to be used by anything other than CreateSessionPair.
| * Kernel: Remove a now unused enum and variable regarding a session's status.Subv2017-05-152-8/+0
| |
| * Kernel: Use a Session object to keep track of the status of a Client/Server session pair.Subv2017-05-156-32/+84
| | | | | | | | Reduce the associated port's connection count when a ServerSession is destroyed.
* | Kernel: Map special regions according to ExHeaderYuri Kunde Schlesner2017-05-104-50/+102
| | | | | | | | | | | | | | This replaces the hardcoded VRAM/DSP mappings with ones made based on the ExHeader ARM11 Kernel caps list. While this has no visible effect for most applications (since they use a standard set of mappings) it does improve support for system modules and n3DS exclusives.
* | DSP: Create backing memory for entire DSP RAMYuri Kunde Schlesner2017-05-101-1/+6
|/ | | | Also move address space mapping out of video_core.
* Timer: restore missing signaled=true from #2421wwylele2017-02-271-0/+2
|
* Fix log entry in timer::signal (#2600)B3n302017-02-271-1/+1
|
* Doxygen: Amend minor issues (#2593)Mat M2017-02-271-1/+2
| | | | | | | | | Corrects a few issues with regards to Doxygen documentation, for example: - Incorrect parameter referencing. - Missing @param tags. - Typos in @param tags. and a few minor other issues.
* Merge pull request #2587 from yuriks/status-barYuri Kunde Schlesner2017-02-272-1/+1
|\ | | | | Replace built-in Profiler with indicators in status bar
| * Core: Remove unnecessary include in thread.hYuri Kunde Schlesner2017-02-272-1/+1
| |
* | Timers: Immediately signal the timer if it was started with an initial value of 0.Subv2017-02-222-16/+31
|/
* Threads: Check the process' resource limit for the max allowed priority when creating a thread and remove the priority clamping code.Subv2017-01-111-8/+2
|
* Thread: Added priority range checking to svcSetThreadPriority and removed priority clamping code from Thread::SetPriority.Subv2017-01-112-18/+4
|
* Merge pull request #2397 from Subv/pulsebunnei2017-01-105-13/+20
|\ | | | | Kernel: Implemented Pulse event and timers.
| * Kernel: Implemented Pulse event and timers.Subv2017-01-055-13/+20
| | | | | | | | Closes #1904
* | Merge pull request #2410 from Subv/sleepthreadbunnei2017-01-072-0/+9
|\ \ | | | | | | Don't yield execution in SleepThread(0) if there are no available threads to run
| * | Kernel: Don't attempt to yield execution in SleepThread(0) if there are no available threads to run.Subv2017-01-062-0/+9
| | | | | | | | | | | | With this we avoid an useless temporary deschedule of the current thread.
* | | Merge pull request #2396 from Subv/sema_acquirebunnei2017-01-071-1/+2
|\ \ \ | | | | | | | | Kernel/Semaphore: Fixed a regression in semaphore waits.
| * | | Kernel/Semaphore: Fixed a regression in semaphore waits.Subv2017-01-051-1/+2
| |/ / | | | | | | | | | | | | | | | The regression was caused by a missing check in #2260. The new behavior is consistent with the real kernel.
* | | Merge pull request #2408 from Subv/priority_boostingbunnei2017-01-061-27/+0
|\ \ \ | | | | | | | | Kernel: Removed the priority boost code for starved threads.
| * | | Kernel: Removed the priority boost code for starved threads.Subv2017-01-051-27/+0
| |/ / | | | | | | | | | | | | | | | After hwtesting and reverse engineering the kernel, it was found that the CTROS scheduler performs no priority boosting for threads like this, although some other forms of scheduling priority-starved threads might take place. For example, it was found that hardware interrupts might cause low-priority threads to run if the CPU is preempted in the middle of an SVC handler that deschedules the current (high priority) thread before scheduling it again.
* / / Kernel: Remove some unused functions.Subv2017-01-052-32/+0
|/ /
* | Kernel: Add some asserts to enforce the invariants in the scheduler.Subv2017-01-052-2/+13
| |
* | Kernel: Remove a thread from all of its waiting objects' waiting_threads list when it is awoken.Subv2017-01-051-18/+4
| | | | | | | | This fixes a potential bug where threads would not get removed from said list if they awoke after waiting with WaitSynchronizationN with wait_all = false
* | Kernel: Remove Thread::wait_objects_index and use wait_objects to hold all the objects that a thread is waiting on.Subv2017-01-053-10/+19
| |
* | Kernel: Use different thread statuses when a thread calls WaitSynchronization1 and WaitSynchronizationN with wait_all = true.Subv2017-01-042-13/+17
| | | | | | | | | | | | | | | | This commit removes the overly general THREADSTATUS_WAIT_SYNCH and replaces it with two more granular statuses: THREADSTATUS_WAIT_SYNCH_ANY when a thread waits on objects via WaitSynchronization1 or WaitSynchronizationN with wait_all = false. THREADSTATUS_WAIT_SYNCH_ALL when a thread waits on objects via WaitSynchronizationN with wait_all = true.
* | Kernel/Mutex: Propagate thread priority changes to other threads inheriting the priority via mutexesSubv2017-01-044-42/+54
| |
* | Kernel/Mutex: Update a mutex priority when a thread stops waiting on it.Subv2017-01-044-22/+39
| |
* | Kernel/Mutex: Implemented priority inheritance.Subv2017-01-044-22/+51
| | | | | | | | | | | | | | The implementation is based on reverse engineering of the 3DS's kernel. A mutex holder's priority will be temporarily boosted to the best priority among any threads that want to acquire any of its held mutexes. When the holder releases the mutex, it's priority will be boosted to the best priority among the threads that want to acquire any of its remaining held mutexes.
* | Kernel: Object ShouldWait and Acquire calls now take a thread as a parameter.Subv2017-01-0416-62/+50
| | | | | | | | This will be useful when implementing mutex priority inheritance.
* | Kernel/Synch: Do not attempt a reschedule on every syscall.Subv2017-01-041-0/+1
|/ | | | Not all syscalls should cause reschedules, this commit attempts to remedy that, however, it still does not cover all cases.
* ThreadContext: Move from "core" to "arm_interface".bunnei2016-12-222-4/+5
|
* core: Replace "AppCore" nomenclature with just "CPU".bunnei2016-12-221-3/+3
|
* core: Remove HLE module, consolidate code & various cleanups.bunnei2016-12-224-7/+3
|
* core: Consolidate core and system state, remove system module & cleanups.bunnei2016-12-221-3/+3
|
* Thread: remove the thread from the thread list when exitingwwylele2016-12-172-2/+14
|
* Kernel: remove object's waiting thread if it is deadwwylele2016-12-161-1/+2
|
* Merge pull request #2260 from Subv/schedulingbunnei2016-12-166-115/+102
|\ | | | | Threading: Reworked the way our scheduler works.
| * Fixed the codestyle to match our clang-format rules.Subv2016-12-142-8/+11
| |
| * Properly remove a thread from its wait_objects' waitlist when it is awoken by a timeout.Subv2016-12-102-1/+10
| |
| * WaitSynch: Removed unused variables and reduced SharedPtr copies.Subv2016-12-093-13/+11
| | | | | | | | | | | | Define a variable with the value of the sync timeout error code. Use a boost::flat_map instead of an unordered_map to hold the equivalence of objects and wait indices in a WaitSynchN call.
| * Use boost remove_erase_if instead of the erase-remove idiomSubv2016-12-071-2/+3
| |
| * Improved the algorithm for GetHighestPriorityReadyThread.Subv2016-12-071-14/+13
| |
| * Threading: Added some utility functions and const correctness.Subv2016-12-042-10/+22
| |
| * Threading: Reworked the way our scheduler works.Subv2016-12-046-111/+76
| | | | | | | | | | | | | | | | | | | | Threads will now be awakened when the objects they're waiting on are signaled, instead of repeating the WaitSynchronization call every now and then. The scheduler is now called once after every SVC call, and once after a thread is awakened from sleep by its timeout callback. This new implementation is based off reverse-engineering of the real kernel. See https://gist.github.com/Subv/02f29bd9f1e5deb7aceea1e8f019c8f4 for a more detailed description of how the real kernel handles rescheduling.
* | Fixed the codestyle to match our clang-format rules.Subv2016-12-147-33/+51
| |
* | Moved the HLE command buffer translation task to ServerSession instead of the HLE handler superclass.Subv2016-12-092-2/+23
| |
* | Added a framework for partially handling Session disconnections.Subv2016-12-084-9/+35
| | | | | | | | | | | | Further implementation will happen in a future commit. Fixes a regression.
* | Use std::move where appropriate.Subv2016-12-085-7/+13
| |
* | Return an error code when connecting to a saturated port.Subv2016-12-052-4/+11
| | | | | | | | The error code was taken from the 3DS kernel.
* | Split SessionRequestHandler::HandleSyncRequest into HandleSyncRequest, TranslateRequest and HandleSyncRequestImpl.Subv2016-12-052-0/+2
| | | | | | | | HandleSyncRequest now takes care of calling the command buffer translate function before actually invoking the command handler for HLE services.
* | Kernel: Remove the Redirection handle type.Subv2016-12-051-2/+0
| |
* | KServerPorts now have an HLE handler "template", which is inherited by all ServerSessions created from it.Subv2016-12-058-35/+60
| |
* | Declare empty ServerSession and ClientSession constructors as default.Subv2016-12-032-4/+4
| |
* | Fixed the rebase mistakes.Subv2016-12-017-51/+46
| |
* | A bit of a redesign.Subv2016-12-016-215/+24
| | | | | | | | | | | | | | Sessions and Ports are now detached from each other. HLE services are handled by means of a SessionRequestHandler class, Interface now inherits from this class. The File and Directory classes are no longer kernel objects, but SessionRequestHandlers instead, bound to a ServerSession when requested. File::OpenLinkFile now creates a new session pair and binds the File instance to it.
* | IPC/HLE: Associate the ClientSessions with their parent port's HLE interface if it exists.Subv2016-12-014-22/+15
| | | | | | | | Pass the triggering ServerSession to the HLE command handler to differentiate which session caused the request.
* | Kernel/HLE: Service::Interface no longer inherits from any Kernel object, and is now its own standalone class.Subv2016-12-012-8/+44
| | | | | | | | Interface is now used by aggregation in ClientPort, to forward service commands to their HLE implementation if needed.
* | fixup! Kernel/IPC: Use Ports and Sessions as the fundamental building block of Inter Process Communication.Subv2016-12-013-4/+5
| |
* | Kernel/IPC: Use Ports and Sessions as the fundamental building block of Inter Process Communication.Subv2016-12-017-56/+233
|/ | | | | | | All handles obtained via srv::GetServiceHandle or svcConnectToPort are references to ClientSessions. Service modules will wait on the counterpart of those ClientSessions (Called ServerSessions) using svcReplyAndReceive or svcWaitSynchronization[1|N], and will be awoken when a SyncRequest is performed. HLE Interfaces are now ClientPorts which override the HandleSyncRequest virtual member function to perform command handling immediately.
* Merge pull request #2196 from Subv/system_modeYuri Kunde Schlesner2016-11-282-6/+4
|\ | | | | Kernel/Loader: Grab the system mode from the NCCH ExHeader.
| * Kernel/Loader: Grab the system mode from the NCCH ExHeader.Subv2016-11-202-6/+4
| | | | | | | | | | | | | | 3dsx and elf files default to system mode 2 (96MB allocated to the application). This allows Home Menu to boot without modifications. Closes #1849
* | Kernel/Events: Log an error when trying to create Pulse events and timers.Subv2016-11-192-0/+10
|/ | | | Related to #1904
* Fix typosRicardo de Almeida Gonzaga2016-10-202-2/+2
|
* move ResetType to kernel.hwwylele2016-09-223-7/+6
|
* implement wait tree widgetwwylele2016-09-224-0/+16
|
* Use negative priorities to avoid special-casing the self-includeYuri Kunde Schlesner2016-09-2114-14/+14
|
* Remove empty newlines in #include blocks.Emmanuel Gil Peyrot2016-09-2129-74/+16
| | | | | | | This makes clang-format useful on those. Also add a bunch of forgotten transitive includes, which otherwise prevented compilation.
* Manually tweak source formatting and then re-run clang-formatYuri Kunde Schlesner2016-09-1915-64/+36
|
* Sources: Run clang-format on everything.Emmanuel Gil Peyrot2016-09-1830-419/+616
|
* arm: ResetContext shouldn't be part of ARM_Interface.bunnei2016-09-151-1/+17
|
* fix #1942 and adds a few IPC functions for descriptorsLectem2016-08-021-15/+103
|
* Merge pull request #1869 from wwylele/dont-be-lazyYuri Kunde Schlesner2016-06-291-2/+6
|\ | | | | Switch context to the same thread if necessary
| * Switch context on the same thread if necessarywwylele2016-05-301-2/+6
| |
* | Merge pull request #1867 from mailwl/srv-updatebunnei2016-06-291-0/+4
|\ \ | | | | | | srv: Update according 3dbrew
| * | Fix parameter name in EnableNotificationmailwl2016-05-311-0/+4
| |/
* | Merge pull request #1877 from wwylele/wait-fix-timeoutbunnei2016-06-181-0/+49
|\ \ | | | | | | Thread: update timeout when reruning WaitSynch
| * | Thread: update timeout when rerunning WaitSynchwwylele2016-06-041-0/+49
| |/
* | Kernel/SVC: Implemented svcCreatePort.Subv2016-06-114-2/+11
| |
* | Kernel: Added ClientPort and ServerPort classes.Subv2016-06-055-2/+135
|/ | | | This is part of an ongoing effort to implement support for multiple processes.
* Merge pull request #1692 from Subv/rm_getpointer2bunnei2016-05-301-1/+1
|\ | | | | Memory: Remove most usages of GetPointer
| * Kernel/Thread: Remove use of Memory::GetPointerMerryMage2016-05-211-1/+1
| |
* | Memory: Added necessary headers and removed unnecessary headerMerryMage2016-05-261-0/+1
|/
* Merge pull request #1800 from JayFoxRox/set-fpscrbunnei2016-05-181-0/+2
|\ | | | | Set fpscr for new threads
| * Set fpscr for new threadsJannik Vogel2016-05-171-0/+2
| |
* | Memory: Fixed a regression caused by #1695 and #1689.Subv2016-05-141-0/+3
|/ | | | | | Reserve enough space in the vector that holds the linear heap memory to prevent relocations of the backing memory when growing too much. Closes #1790
* Merge pull request #1689 from Subv/shmembunnei2016-05-134-67/+161
|\ | | | | Kernel: Implemented shared memory.
| * HLE/Applets: Give each applet its own block of heap memory, and use that when creating the framebuffer shared memory block.Subv2016-05-132-1/+30
| |
| * Kernel: Account for automatically-allocated shared memories in the amount of used linear heap memory.Subv2016-05-131-0/+5
| |
| * Kernel/SharedMemory: Log an error when Map fails.Subv2016-05-131-1/+10
| |
| * Kernel: Implemented shared memory permissions.Subv2016-05-132-9/+47
| |
| * Kernel/Memory: Remove the Shared Memory region from the legacy memory map.Subv2016-05-131-1/+0
| |
| * Kernel/SharedMemory: Properly implemented shared memory support.Subv2016-05-132-65/+79
| | | | | | | | | | | | | | Applications can request the kernel to allocate a piece of the linear heap for them when creating a shared memory object. Shared memory areas are now properly mapped into the target processes when calling svcMapMemoryBlock. Removed the APT Shared Font hack as it is no longer needed.
| * Kernel/SVC: Fixed the register order for svcCreateMemoryBlock.Subv2016-05-131-1/+1
| | | | | | | | R0 is used as the last parameter instead of R4.
* | Merge pull request #1695 from Subv/tls_allocbunnei2016-05-134-22/+74
|\ \ | |/ |/| Kernel/Threads: Dynamically allocate the TLS region for threads.
| * Kernel/Threads: Dynamically allocate the TLS region for threads in the BASE region of the linear heap.Subv2016-05-074-22/+74
| | | | | | | | | | | | Each thread gets a 0x200-byte area from the 0x1000-sized page, when all 8 thread slots in a single page are used up, the kernel allocates a new page to hold another 8 entries. This is consistent with what the real kernel does.
* | Merge pull request #1766 from Subv/log_cpubunnei2016-05-081-0/+2
|\ \ | | | | | | Kernel/Threading: Warn when a thread can be scheduled in the Syscore (Core 1)
| * | Kernel/Threading: Warn when a thread can be scheduled in the Syscore (Core 1).Subv2016-05-071-0/+2
| |/ | | | | | | We do not currently implement any cores other than the AppCore (Core 0).
* | Merge pull request #1762 from bunnei/globalbunnei2016-05-061-1/+2
|\ \ | |/ |/| hle: Get rid of direct global access to g_reschedule
| * hle: Get rid of global access to g_rescheduleLioncash2016-03-211-1/+2
| | | | | | | | | | This shouldn't be directly exposed if there's already a partial API that operates on it. We can just provide the rest of that API.
* | Merge pull request #1643 from MerryMage/make_uniqueMathew Maidment2016-04-061-1/+2
|\ \ | | | | | | Common: Remove Common::make_unique, use std::make_unique
| * | Common: Remove Common::make_unique, use std::make_uniqueMerryMage2016-04-051-1/+2
| |/
* / session: Make helper functions constexprLioncash2016-03-211-6/+6
|/
* svc: Move ResetType enum to the kernel event headerLioncash2016-03-132-2/+8
|
* svc: Make ResetType an enum classLioncash2016-03-122-2/+2
|
* Memory: Do correct Phys->Virt address translation for non-APP linheapYuri Kunde Schlesner2016-03-062-2/+5
|
* AudioCore: Skeleton ImplementationMerryMage2016-02-211-1/+4
| | | | | | | | | This commit: * Adds a new subproject, audio_core. * Defines structures that exist in DSP shared memory. * Hooks up various other parts of the emulator into audio core. This sets the foundation for a later HLE DSP implementation.
* BitField: Make trivially copyable and remove assignment operatorMerryMage2016-02-121-1/+1
|
* Memory: Implement MMIOMerryMage2016-01-302-4/+8
|
* HLE/SVC: Implement UnmapMemoryBlock.Subv2016-01-142-0/+28
| | | | This implementation will need to be (almost completely) changed when we implement multiprocess support.
* HLE/Timers: Reset OneShot timers when they are acquired instead of when they're triggered.Subv2015-12-301-3/+3
| | | | Closes #1139
* SVC: Fixed ArbitrateAddress to behave as it does on hardware.Subv2015-12-282-9/+18
| | | | This was verified with hwtests that i plan to upload later on.
* Kernel: Implement svcGetSystemInfoYuri Kunde Schlesner2015-12-014-0/+12
| | | | | This makes smealum/ctrulib@b96dd51d3349961189d4ab1bc2a5c45deff21c09 work with Citra.
* Silence -Wsign-compare warnings.Rohit Nirmal2015-10-071-1/+1
|
* general: Silence some warnings when using clangLioncash2015-09-161-2/+4
|
* General: Fix up doxygen commentsLioncash2015-09-103-6/+3
|
* Kernel: Fix wrong linear heap base on titles using newer kernelsYuri Kunde Schlesner2015-08-281-1/+1
| | | | Typo which sneaked in through review on #1025
* Kernel: Fix assertion failure when ControlMemory is called with size=0Yuri Kunde Schlesner2015-08-271-0/+8
|
* Core: Improve APT Shared Font hackYuri Kunde Schlesner2015-08-272-2/+27
| | | | Should fix invalid read loops in some games
* Kernel: Remove unused legacy heap MapBlock_* functionsYuri Kunde Schlesner2015-08-162-77/+0
|
* Kernel: Implement svcGetProcessInfo in a basic wayYuri Kunde Schlesner2015-08-163-1/+15
| | | | | This also adds some basic memory usage accounting. These two types are used by Super Smash Bros. during startup.
* Kernel: Add more infrastructure to support different memory layoutsYuri Kunde Schlesner2015-08-165-20/+138
| | | | | | This adds some structures necessary to support multiple memory regions in the future. It also adds support for different system memory types and the new linear heap mapping at 0x30000000.
* Move core/mem_map.{cpp,h} => core/hle/kernel/memory.{cpp,h}Yuri Kunde Schlesner2015-08-163-1/+160
|
* Memory: Move address type conversion routines to memory.cpp/hYuri Kunde Schlesner2015-08-161-1/+0
| | | | | These helpers aren't really part of the kernel, and mem_map.cpp/h is going to be moved there next.
* Process: Store kernel compatibility version during loadingYuri Kunde Schlesner2015-08-162-3/+7
|
* Kernel: Properly implement ControlMemory FREE and COMMITYuri Kunde Schlesner2015-08-164-23/+243
|
* VMManager: Introduce names for used ResultCodesYuri Kunde Schlesner2015-08-162-6/+11
|
* VMManager: Make LogLayout log level configurable as a parameterYuri Kunde Schlesner2015-08-163-5/+15
|
* VMManager: Change block offsets to size_tYuri Kunde Schlesner2015-08-162-3/+3
|
* dyncom: Rename armdefs.h to armstate.hLioncash2015-07-261-1/+1
|
* Kernel/Scheduling: Clean up a thread's wait_objects when its scheduled.Subv2015-07-211-0/+8
| | | | They'll be reset if needed during the next svcWaitSynchronization call (if there's any pending)
* Ensure all kernel objects are released during shutdownYuri Kunde Schlesner2015-07-171-7/+14
| | | | | | | | This commit fixes several kernel object leaks. The most severe of them was threads not being removed from the private handle table used for CoreTiming events. This resulted in Threads never being released, which in turn held references to Process, causing CodeSets to never be freed when loading other applications.
* Merge pull request #921 from linkmauve/fix-appletbunnei2015-07-122-0/+4
|\ | | | | Fix applet includes using iwyu
| * Core: Fix applet includes using iwyu.Emmanuel Gil Peyrot2015-07-122-0/+4
| |
* | Kernel: Add CodeSet case to Object::IsWaitableYuri Kunde Schlesner2015-07-121-0/+1
|/
* Core: Properly configure address space when loading a binaryYuri Kunde Schlesner2015-07-125-14/+88
| | | | | | The code now properly configures the process image to match the loaded binary segments (code, rodata, data) instead of just blindly allocating a large chunk of dummy memory.
* Kernel: Remove unused member from EventYuri Kunde Schlesner2015-07-122-2/+1
|
* Core: Cleanup file_sys includes.Emmanuel Gil Peyrot2015-06-281-1/+2
|
* Core: Cleanup core includes.Emmanuel Gil Peyrot2015-06-282-1/+2
|
* Common: Cleanup key_map includes.Emmanuel Gil Peyrot2015-06-284-6/+10
|
* Add helpers to create IPC command buffer headers and descriptorsYuri Kunde Schlesner2015-06-231-0/+34
|
* kernel: Fix svcWaitSynch to always acquire requested wait objects.bunnei2015-06-177-101/+37
|
* Merge pull request #810 from yuriks/memmapYuri Kunde Schlesner2015-05-302-0/+445
|\ | | | | Kernel: Add VMManager to manage process address spaces
| * Kernel: Add VMManager to manage process address spacesYuri Kunde Schlesner2015-05-272-0/+445
| | | | | | | | | | | | | | | | This enables more dynamic management of the process address space, compared to just directly configuring the page table for major areas. This will serve as the foundation upon which the rest of the Kernel memory management functions will be built.
* | Remove every trailing whitespace from the project (but externals).Emmanuel Gil Peyrot2015-05-295-11/+11
|/
* Kernel: Fix a warning introduced with ResourceLimit, and remove the fallback code to prevent it from happening again.Emmanuel Gil Peyrot2015-05-211-2/+1
|
* Kernel: Move reschedules from SVCs to actual mechanisms that reschedule.bunnei2015-05-216-0/+20
|
* Merge pull request #772 from lioncash/warnbunnei2015-05-181-3/+3
|\ | | | | core/video_core: Fix a few warnings when compiling on MSVC.
| * process: Get rid of warningsLioncash2015-05-141-3/+3
| | | | | | | | Sign mismatches and "forcing value to bool" warnings.
* | Core/ResourceLimits: Implemented the basic structure of ResourceLimits.Subv2015-05-156-1/+286
| | | | | | | | | | | | Implemented svcs GetResourceLimit, GetResourceLimitCurrentValues and GetResourceLimitLimitValues. Note that the resource limits do not currently keep track of used objects, since we have no way to distinguish between an object created by the application, and an object created by some HLE module once we're inside Kernel::T::Create.
* | Memmap: Re-organize memory function in two filesYuri Kunde Schlesner2015-05-156-6/+5
| | | | | | | | | | | | | | memory.cpp/h contains definitions related to acessing memory and configuring the address space mem_map.cpp/h contains higher-level definitions related to configuring the address space accoording to the kernel and allocating memory.
* | thread: Fix a conditional check in RescheduleLioncash2015-05-141-1/+1
|/
* Merge pull request #748 from Subv/tls_maxbunnei2015-05-123-7/+19
|\ | | | | Core/Memory: Add TLS support for creating up to 300 threads
| * Core/Memory: Add TLS support for creating up to 300 threadsSubv2015-05-123-7/+19
| |
* | Merge pull request #751 from yuriks/idle-threadbunnei2015-05-122-44/+19
|\ \ | | | | | | Thread: Remove the idle thread
| * | Thread: Remove the idle threadYuri Kunde Schlesner2015-05-122-44/+19
| | | | | | | | | | | | Instead just use nullptr to represent no thread is active.
* | | Merge pull request #757 from Subv/schedulingbunnei2015-05-121-0/+2
|\ \ \ | |_|/ |/| | Core/Scheduling: Prepare the new priority in the thread queue when svcSetPriority is called
| * | Core/Scheduling: Prepare the new priority in the thread queue when svcSetPriority is calledSubv2015-05-121-0/+2
| |/
* | Merge pull request #750 from Subv/process_svcYuri Kunde Schlesner2015-05-125-2/+15
|\ \ | |/ |/| Core/HLE: Implemented the SVCs GetProcessId and GetProcessIdOfThread
| * fixup!Subv2015-05-122-7/+3
| |
| * Core/HLE: Implemented the SVCs GetProcessId and GetProcessIdOfThreadSubv2015-05-115-2/+19
| |
* | Thread: Correctly set main thread initial stack positionYuri Kunde Schlesner2015-05-113-5/+4
|/
* Merge pull request #740 from yuriks/gsp-shmemarchshift2015-05-112-16/+37
|\ | | | | Fix crashes due to un-initialized GSP shared memory
| * Kernel: Zero-fill shared memory blocks when mappingYuri Kunde Schlesner2015-05-111-0/+8
| | | | | | | | | | | | This works around crashes related to GSP/HID/etc. shared memory blocks having garbage values. The proper fix requires proper management of mapped memory blocks in the process.
| * Kernel: Capture SharedMemory attributes at creation, not when mappingYuri Kunde Schlesner2015-05-112-16/+29
| |
* | fixup! Set the TLS address in the schedulerSubv2015-05-112-2/+7
| |
* | Core/Memory: Give every emulated thread it's own TLS area.Subv2015-05-113-4/+22
|/ | | | | The TLS area for thread T with id Ti is located at TLS_AREA_VADDR + (Ti - 1) * 0x200. This allows some games like Mario Kart 7 to continue further.
* Common: Remove the BIT macroYuri Kunde Schlesner2015-05-091-2/+2
| | | | | | | When the macro was introduced in 326ec51261299e48de97592631c02523da9c8118 it wasn't noticed that it conflicted in name with a heavily used macro inside of dyncom. This causes some compiler warnings. Since it's only lightly used, it was opted to simply remove the new macro.
* Memory: Re-organize and rename memory area address constantsYuri Kunde Schlesner2015-05-092-3/+4
|
* Kernel: Remove unused g_main_thread variableYuri Kunde Schlesner2015-05-093-5/+1
|
* Process: Rename StaticAddressMapping => AddressMappingYuri Kunde Schlesner2015-05-092-5/+5
|
* Process: Add more documentation to the class membersYuri Kunde Schlesner2015-05-091-2/+16
|
* Process: Use BitField to store process flagsYuri Kunde Schlesner2015-05-092-16/+24
|
* Process: Support parsing of exheader kernel capsYuri Kunde Schlesner2015-05-092-4/+72
|
* Kernel: Remove g_program_idYuri Kunde Schlesner2015-05-092-8/+0
| | | | This has been obsoleted by the field in Process.
* Kernel: Introduce skeleton Process class to hold process dataYuri Kunde Schlesner2015-05-094-19/+101
|
* Common: Remove common.hYuri Kunde Schlesner2015-05-079-8/+14
|
* Move typedefs from kernel.h to more appropriate placesYuri Kunde Schlesner2015-05-071-10/+1
|
* Kernel: Properly initialize and shutdown all modules.bunnei2015-05-024-9/+20
|
* Kernel: Use the correct format string for u64 hex.Emmanuel Gil Peyrot2015-04-141-1/+1
|
* SVC: Update various SVCs to cause a reschedule.bunnei2015-04-101-4/+0
| | | | - CreateMutex/ReleaseMutex/ReleaseSemaphore/SetTimer/CancelTimer/ArbitrateAddress
* Kernel: Implemented priority inheritance for mutexes.bunnei2015-04-103-4/+22
|
* Thread: Implement priority boost for starved threads.bunnei2015-04-102-22/+51
| | | | | | SVC: Return correct error code on invalid CreateThread processor ID. SVC: Assert when creating a thread with an invalid userland priority.
* Kernel: Fixed default thread priority.bunnei2015-04-102-5/+4
|
* Initialize base address to 0x0Gareth Higgins2015-04-091-0/+1
|
* Misc cleanup of common and related functionsarchshift2015-02-201-2/+3
|
* Build: Fixed some warningsSubv2015-02-123-4/+4
|
* Asserts: break/crash program, fit to style guide; log.h->assert.harchshift2015-02-117-15/+13
| | | | | | | Involves making asserts use printf instead of the log functions (log functions are asynchronous and, as such, the log won't be printed in time) As such, the log type argument was removed (printf obviously can't use it, and it's made obsolete by the file and line printing) Also removed some GEKKO cruft.
* Scheduler refactor Pt. 1Kevin Hartman2015-02-103-223/+258
| | | | | | | | | | | | | * Simplifies scheduling logic, specifically regarding thread status. It should be much clearer which statuses are valid for a thread at any given point in the system. * Removes dead code from thread.cpp. * Moves the implementation of resetting a ThreadContext to the corresponding core's implementation. Other changes: * Fixed comments in arm interfaces. * Updated comments in thread.cpp * Removed confusing, useless, functions like MakeReady() and ChangeStatus() from thread.cpp. * Removed stack_size from Thread. In the CTR kernel, the thread's stack would be allocated before thread creation.
* Mutex: Locks should be recursive.bunnei2015-02-102-16/+20
|
* core: Fix some warnings on OSXLioncash2015-02-031-1/+0
|
* Kernel: Stop creating useless Handles during object creationYuri Kunde Schlesner2015-02-0212-36/+17
| | | | | They're finally unnecessary, and will stop cluttering the application's handle table.
* Kernel: Make WaitObjects share ownership of Threads waiting on themYuri Kunde Schlesner2015-02-026-12/+17
| | | | | | | | | | | | | | | | During normal operation, a thread waiting on an WaitObject and the object hold mutual references to each other for the duration of the wait. If a process is forcefully terminated (The CTR kernel has a SVC to do this, TerminateProcess, though no equivalent exists for threads.) its threads would also be stopped and destroyed, leaving dangling pointers in the WaitObjects. The solution is to simply have the Thread remove itself from WaitObjects when it is stopped. The vector of Threads in WaitObject has also been changed to hold SharedPtrs, just in case. (Better to have a reference cycle than a crash.)
* Explicitly instantiate constructors/destructors for Kernel objectsYuri Kunde Schlesner2015-02-0216-8/+50
| | | | | | This should speed up compile times a bit, as well as enable more liberal use of forward declarations. (Due to SharedPtr not trying to emit the destructor anymore.)
* Mutex: Replace g_mutex_held_locks with a set inside ThreadYuri Kunde Schlesner2015-02-023-23/+18
|
* Kernel: Fix bug in HandleTable::CloseYuri Kunde Schlesner2015-02-021-1/+1
|
* Kernel: Remove Object::GetHandle (it's not used anymore :D)Yuri Kunde Schlesner2015-02-022-9/+1
|
* Kernel: Introduce unique Object ids for debuggingYuri Kunde Schlesner2015-02-024-8/+16
|
* Kernel: Use separate Handle tables for CoreTiming userdataYuri Kunde Schlesner2015-02-024-18/+25
| | | | This is to support the removal of GetHandle soon
* Kernel: Remove previous scheduled event when a Timer is re-SetYuri Kunde Schlesner2015-02-021-0/+3
|
* Thread: Modernize two functions that slipped through previous rebasesYuri Kunde Schlesner2015-02-023-15/+13
|
* arm: Clean up ARMul_StateLioncash2015-02-011-1/+1
| | | | Remove unnecessary/unused struct variables.
* shared_memory: Fix assignments in SharedMemory::MapLioncash2015-01-302-4/+4
|
* Kernel: Mark all appropriate kernel objects as "final"Yuri Kunde Schlesner2015-01-307-8/+7
|
* Remove result.h InvalidHandleYuri Kunde Schlesner2015-01-301-1/+2
| | | | | It was only being used in two places, where it was replaced by a local constant.
* Kernel: Convert Event to not use HandlesYuri Kunde Schlesner2015-01-302-83/+51
|
* Kernel: Convert Timer to (mostly) not use HandlesYuri Kunde Schlesner2015-01-302-104/+72
|
* Kernel: Convert Mutex to not use HandlesYuri Kunde Schlesner2015-01-302-101/+82
|
* Kernel: Convert AddressArbiter to not use HandlesYuri Kunde Schlesner2015-01-302-32/+31
|
* Kernel: Convert Semaphore to not use HandlesYuri Kunde Schlesner2015-01-302-61/+61
|
* Kernel: Convert SharedMemory to not use HandlesYuri Kunde Schlesner2015-01-302-71/+54
|
* Move VAddr/PAddr typedefs to kernel.hYuri Kunde Schlesner2015-01-301-0/+5
|
* Kernel: Remove useless/duplicated comments; mark functions staticYuri Kunde Schlesner2015-01-306-32/+8
|
* Thread: Fix WaitSynchronization1 to not set register 1 on thread wakeup.bunnei2015-01-222-22/+42
|
* Thread: Use std::find in CheckWait_WaitObject.bunnei2015-01-221-4/+5
|
* Mutex: Cleanup and remove redundant code.bunnei2015-01-223-47/+29
|
* Kernel: Renamed some functions for clarity.bunnei2015-01-227-10/+10
| | | | | - ReleaseNextThread->WakeupNextThread - ReleaseAllWaitingThreads->WakeupAllWaitingThreads.
* Kernel: Changed "ShouldWait" to return bool and "Acquire" to return void.bunnei2015-01-228-64/+39
|
* WaitObject: Renamed "Wait" to "ShouldWait", made "ShouldWait" and "Acquire" pure virtual.bunnei2015-01-228-21/+20
|
* Event: Fix implementation of "non-sticky" events.bunnei2015-01-221-0/+4
|
* Session: Change to a WaitObject.bunnei2015-01-223-2/+9
|
* Kernel: Reschedule on SignalEvent and SendSyncRequest, fix some bugs.bunnei2015-01-221-1/+1
|
* Mutex: Fix a bug where the thread should not wait if it already has the mutex.bunnei2015-01-221-1/+4
|
* Kernel: Moved Wait and Acquire to WaitObject, added way to retrieve a WaitObject safely.bunnei2015-01-223-18/+57
|
* AddressArbiter: Changed to Kernel::Object, big cleanup, removed code that made no sense.bunnei2015-01-224-35/+42
|
* Kernel: Get rid of WaitTypes and simplify lots of code, removing hacks.bunnei2015-01-228-112/+43
|
* WaitSynchronizationN: Refactor to fix several bugsbunnei2015-01-227-54/+49
| | | | | | - Separate wait checking from waiting the current thread - Resume thread when wait_all=true only if all objects are available at once - Set output to correct wait object index when there are duplicate handles
* Kernel: Separate WaitSynchronization into Wait and Acquire methods.bunnei2015-01-227-14/+54
|
* WaitSynchronizationN: Implement return valuesbunnei2015-01-229-56/+139
|
* Event: Fixed some bugs and cleanup (Subv)bunnei2015-01-222-54/+13
|
* Thread: Keep track of multiple wait objects.bunnei2015-01-223-16/+30
|
* Event: Get rid of permanent_lock hack.bunnei2015-01-222-36/+8
|
* WaitObject: Added RemoveWaitingThread, fixed a bug, and cleanup.bunnei2015-01-222-4/+17
|
* Kernel: Added WaitObject and changed "waitable" objects inherit from it.bunnei2015-01-228-71/+73
|
* core: Fix a few docstringsLioncash2015-01-202-2/+2
|
* AddrArbiter: Implement arbitration types 3 and 4.Subv2015-01-132-3/+20
|
* Merge pull request #466 from Subv/wakebunnei2015-01-111-0/+3
|\ | | | | Thread: Prevent waking a thread multiple times.
| * Thread: Prevent waking a thread multiple times.Subv2015-01-111-0/+3
| | | | | | | | If a thread was woken up by something, cancel the wakeup timeout.
* | Kernel: Start using boost::intrusive_ptr for lifetime managementYuri Kunde Schlesner2015-01-0910-76/+75
| |
* | Kernel: Don't re-assign object's handle when duplicating oneYuri Kunde Schlesner2015-01-092-2/+3
|/
* Thread: Fix nullptr access in a logging functionYuri Kunde Schlesner2015-01-091-1/+2
|
* Thread: Rename thread_queue => thread_listYuri Kunde Schlesner2015-01-091-6/+6
|
* Thread: Reduce use of Handles and move some funcs to inside the class.Yuri Kunde Schlesner2015-01-099-281/+190
|
* Kernel: Move Thread's definition to the header fileYuri Kunde Schlesner2015-01-093-53/+67
|
* Move ThreadContext to core/core.h and deal with the falloutYuri Kunde Schlesner2015-01-092-4/+6
|
* Merge pull request #255 from Subv/cbranch_3bunnei2015-01-095-1/+194
|\ | | | | Implemented timers
| * SVC: Implemented the Timer service calls.Subv2015-01-095-1/+194
| |
* | SVC: Fixed SleepThread.Subv2015-01-092-8/+39
| | | | | | | | It will now properly wait the specified number of nanoseconds and then wake up the thread.
* | Threads: Use a dummy idle thread when no other are ready.Subv2015-01-083-1/+35
| | | | | | | | This thread will not actually execute instructions, it will only advance the timing/events and try to yield immediately to the next ready thread, if there aren't any ready threads then it will be rescheduled and start its job again.
* | Common: Clean up ThreadQueueListYuri Kunde Schlesner2015-01-071-1/+1
|/ | | | | | | | Replace all the C-style complicated buffer management with a std::deque. In addition to making the code easier to understand it also adds support for non-POD IdTypes. Also clean the rest of the code to follow our code style.
* Merge pull request #407 from Subv/arbiterbunnei2015-01-051-0/+11
|\ | | | | AddressArbiter: Ported arbitration type 2 from 3dmoo.
| * AddressArbiter: Ported arbitration type 2 from 3dmoo.Subv2015-01-031-0/+11
| | | | | | | | (Thanks 3dmoo!)
* | Mutex: Add the calling thread to the waiting list when neededSubv2015-01-041-2/+2
|/ | | | This will happen when the mutex is already owned by another thread. Should fix some issues with games being stuck due to waiting threads not being awoken.
* Kernel: New handle managerYuri Kunde Schlesner2014-12-289-142/+189
| | | | | | | | | | | This handle manager more closely mirrors the behaviour of the CTR-OS one. In addition object ref-counts and support for DuplicateHandle have been added. Note that support for DuplicateHandle is still experimental, since parts of the kernel still use Handles internally, which will likely cause troubles if two different handles to the same object are used to e.g. wait on a synchronization primitive.
* Kernel: Replace GetStaticHandleType by HANDLE_TYPE constantsYuri Kunde Schlesner2014-12-288-15/+15
|
* Rename ObjectPool to HandleTableYuri Kunde Schlesner2014-12-288-41/+41
|
* Merge pull request #291 from purpasmart96/licensebunnei2014-12-2115-16/+16
|\ | | | | License change
| * License changepurpasmart962014-12-2115-16/+16
| |
* | Thread: Wait current thread on svc_SleepThreadbunnei2014-12-212-21/+33
| | | | | | | | | | | | - Removed unused VBLANK sleep mode - Added error log for bad context switch - Renamed VerifyWait to CheckWaitType to be more clear
* | Merge pull request #316 from yuriks/thread-handlebunnei2014-12-203-2/+16
|\ \ | | | | | | Kernel: Implement support for current thread pseudo-handle
| * | Kernel: Implement support for current thread pseudo-handleYuri Kunde Schlesner2014-12-203-2/+16
| | | | | | | | | | | | This boots a few (mostly Nintendo 1st party) games further.
* | | Clean up some warningsChin2014-12-202-5/+5
| |/ |/|
* | Merge pull request #185 from purpasmart96/mem_permbunnei2014-12-181-5/+9
|\ \ | | | | | | Kernel: Add missing permissions
| * | Kernel:Add missing permissions in shared memory & svcpurpasmart962014-11-191-5/+9
| | |
* | | Filesystem/Archives: Implemented the SaveData archiveSubv2014-12-182-0/+7
| |/ |/| | | | | | | | | | | | | | | | | The savedata for each game is stored in /savedata/<ProgramID> for NCCH files. ELF files and 3DSX files use the folder 0 because they have no ID information Got rid of the code duplication in File and Directory Files that deal with the host machine's file system now live in DiskFile, similarly for directories and DiskDirectory and archives with DiskArchive. FS_U: Use the correct error code when a file wasn't found
* | HLE: Rename namespaces to match move & fix initialization orderYuri Kunde Schlesner2014-12-161-5/+0
| |
* | HLE: Move kernel/archive.* to service/fs/Yuri Kunde Schlesner2014-12-163-534/+1
| |
* | Remove SyncRequest from K::Object and create a new K::Session typeYuri Kunde Schlesner2014-12-153-38/+75
| | | | | | | | | | | | | | This is a first step at fixing the conceptual insanity that is our handling of service and IPC calls. For now, interfaces still directly derived from Session because we don't have the infrastructure to do it properly. (That is, Processes and scheduling them.)
* | Kernel/Semaphore: Small style changeSubv2014-12-131-1/+1
| |
* | Kernel/Semaphores: Invert the available count checking.Subv2014-12-131-11/+9
| | | | | | | | Same semantics, idea by @yuriks
* | Kernel/Semaphores: Addressed some issues.Subv2014-12-132-32/+18
| |
* | Semaphore: Removed an unneeded functionSubv2014-12-131-5/+0
| |
* | Semaphores: Addressed some style issuesSubv2014-12-131-6/+5
| |
* | Semaphore: Implemented the initial_count parameter.Subv2014-12-132-5/+7
| |
* | SVC: Implemented ReleaseSemaphore.Subv2014-12-132-16/+64
| | | | | | | | This behavior was tested on hardware, however i'm still not sure what use the "initial_count" parameter has
* | SVC: Implemented svcCreateSemaphoreSubv2014-12-132-0/+98
| | | | | | | | | | ToDo: Implement svcReleaseSemaphore * Some testing against hardware needed
* | kernel: Remove unused log argumentsLioncash2014-12-131-3/+3
| |
* | Convert old logging calls to new logging macrosYuri Kunde Schlesner2014-12-136-72/+45
| |
* | Merge pull request #256 from Subv/mutexbunnei2014-12-113-37/+67
|\ \ | | | | | | Kernel/Mutex: Properly lock the mutex when a thread enters it
| * | Mutex: Remove some forward declarationsSubv2014-12-071-16/+15
| | | | | | | | | | | | Moved Mutex::WaitSynchronization to the end of the file.
| * | Mutex: Release all held mutexes when a thread exits.Subv2014-12-073-22/+56
| | |
| * | Mutex: Properly lock the mutex when a thread enters itSubv2014-12-061-12/+9
| | | | | | | | | | | | Also resume only the next immediate thread waiting for the mutex when it is released, instead of resuming them all.
* | | Thread: Fixed to wait on address when in arbitration.bunnei2014-12-093-11/+31
| | |
* | | Make OpenDirectory fail if the directory doesn't existarchshift2014-12-071-0/+5
|/ / | | | | | | | | | | | | This is in line with what the hardware itself does. It does this by splitting the initial directory opening into Directory.Open(), which will return false if a stat fails. Then, Archive::OpenDirectory will return nullptr, and archive.cpp will return an error code .
* | Merge pull request #250 from Subv/cbranch_2bunnei2014-12-052-0/+26
|\ \ | | | | | | SVC: Implemented GetThreadId.
| * | Threads: Remove a redundant function.Subv2014-12-041-9/+1
| | | | | | | | | | | | Use the next_thread_id variable directly.
| * | Threads: Implemented a sequential thread idSubv2014-12-042-4/+19
| | |
| * | SVC: Implemented GetThreadId.Subv2014-12-042-0/+19
| | | | | | | | | | | | For now threads are using their Handle value as their Id, it should not really cause any problems because Handle values are unique in Citra, but it should be changed. I left a ToDo there because this is not correct behavior as per hardware.
* | | Merge pull request #222 from archshift/renamexyzbunnei2014-12-052-33/+74
|\ \ \ | | | | | | | | Implemented RenameFile and RenameDirectory in FS:USER
| * | | Updated archive.cpp functions for proper error handlingarchshift2014-12-042-65/+36
| | | |
| * | | Implemented RenameDirectory in FS:USERarchshift2014-11-252-0/+35
| | | |
| * | | Implemented RenameFile in FS:USERarchshift2014-11-252-0/+35
| | | |
* | | | kernel: Shorten GetCountLioncash2014-12-041-6/+3
| | | |
* | | | kernel: Make some functions constLioncash2014-12-042-4/+4
| |/ / |/| |
* | | Merge pull request #225 from bunnei/fix-release-mutexbunnei2014-11-301-8/+7
|\ \ \ | | | | | | | | Mutex: Changed behavior to always release mutex for all threads.
| * | | Mutex: Changed behavior to always release mutex for all threads.bunnei2014-11-261-8/+7
| |/ /
* / / Thread: Check that thread is actually in "wait state" when verifying wait.bunnei2014-11-261-1/+1
|/ /
* | Use pointers instead of passing handles around in some functions.Yuri Kunde Schlesner2014-11-241-19/+15
| |
* | Remove duplicated docs/update them for changed parameters.Yuri Kunde Schlesner2014-11-249-78/+0
| |
* | HLE: Revamp error handling throrough the HLE codeYuri Kunde Schlesner2014-11-2413-201/+187
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | All service calls in the CTR OS return result codes indicating the success or failure of the call. Previous to this commit, Citra's HLE emulation of services and the kernel universally either ignored errors or returned dummy -1 error codes. This commit makes an initial effort to provide an infrastructure for error reporting and propagation which can be use going forward to make HLE calls accurately return errors as the original system. A few parts of the code have been updated to use the new system where applicable. One part of this effort is the definition of the `ResultCode` type, which provides facilities for constructing and parsing error codes in the structured format used by the CTR. The `ResultVal` type builds on `ResultCode` by providing a container for values returned by function that can report errors. It enforces that correct error checking will be done on function returns by preventing the use of the return value if the function returned an error code. Currently this change is mostly internal since errors are still suppressed on the ARM<->HLE border, as a temporary compatibility hack. As functionality is implemented and tested this hack can be eventually removed.
* | Merge pull request #191 from archshift/deletexyzbunnei2014-11-242-1/+47
|\ \ | | | | | | Added DeleteFile and DeleteDirectory functions to FS:USER and the archives.
| * | Added DeleteFile and DeleteDirectory functions to FS:USER and the archives.archshift2014-11-232-1/+47
| | |
* | | Merge pull request #211 from linkmauve/masterbunnei2014-11-1912-42/+42
|\ \ \ | | | | | | | | Remove trailing spaces from the entire project
| * | | Remove trailing spaces in every file but the ones imported from SkyEye, AOSP or generatedEmmanuel Gil Peyrot2014-11-1912-42/+42
| | | |
* | | | Merge pull request #208 from lioncash/staticsbunnei2014-11-191-22/+22
|\ \ \ \ | |/ / / |/| | | Add static to some variables
| * | | Add static to some variablesLioncash2014-11-191-22/+22
| |/ /
* / / Remove extraneous semicolonsLioncash2014-11-181-1/+1
|/ /
* | Archive: Fixed to not destroy archive handle on close.bunnei2014-11-181-3/+3
| |
* | Archive: Fixed close archive before freeing.bunnei2014-11-181-1/+1
| |
* | FS_User: Support FileSye::Path in a more generic way.bunnei2014-11-181-0/+11
| | | | | | | | added a todo to kernel archive
* | FileSys: Updated backend code to use FileSys::Path instead of string for paths.bunnei2014-11-182-10/+10
| |
* | Fix two format strings.Lioncash2014-11-141-1/+1
|/
* Added CreateDirectory function to service/fs.cpp, and in Archive.archshift2014-11-022-2/+25
|
* Fix some warningsSean2014-10-301-3/+3
|
* Add `override` keyword through the code.Yuri Kunde Schlesner2014-10-266-35/+35
| | | | This was automated using `clang-modernize`.
* FileSys: split the constructor into an Open method, in order to notify the opener something went wrong.Emmanuel Gil Peyrot2014-10-061-0/+3
| | | | Kernel: Return an invalid handle to OpenFile when it failed to open.
* FileSys/Kernel: Implement SetSize service call for File objects.Emmanuel Gil Peyrot2014-10-061-0/+8
|
* Use the citra user path for the sdmc directoryarchshift2014-09-211-2/+1
|
* Kernel: Implement the Close command for Archive, File and Directory.Emmanuel Gil Peyrot2014-09-172-0/+43
|
* Kernel: Add a Directory object and a getter for it from an Archive object.Emmanuel Gil Peyrot2014-09-173-0/+91
|
* Kernel: Add a File object and a getter for it from an Archive object.Emmanuel Gil Peyrot2014-09-172-0/+118
|
* Core: Get rid of unnecessary switch statement in KernelLioncash2014-09-151-41/+2
|
* core: Prune redundant includesarchshift2014-09-093-6/+0
|
* Threading: Fix thread starting to execute first instruction correctly.bunnei2014-08-281-0/+5
|
* Added FS functions to Archive and Archive_RomFSarchshift2014-08-231-3/+31
|
* Core: Use std::array for managing kernel object spaceLioncash2014-08-192-5/+5
| | | | These avoid relying on memset for clearing the arrays.
* Core: Alter the kernel string functions to use std::string instead of const char*.Lioncash2014-08-188-25/+22
| | | | Most functions already operate on std::strings. This also removes the need to manually null terminate thread names.
* Thread: Added more descriptive comment to WaitCurrentThread.bunnei2014-08-072-2/+10
|
* AddressArbiter: Removed unnecessary HLE::Reschedule.bunnei2014-08-061-1/+0
|
* AddressArbiter: Fixed bug with break statements missing from case statements.bunnei2014-08-061-0/+2
|
* Kernel: Updated Event and Mutex to specify handle that they are blocking for.bunnei2014-08-062-2/+2
|
* Kernel: Added preliminary support for address arbiters.bunnei2014-07-093-1/+124
| | | | | | | | AddressArbiter: Added documentation comment, fixed whitespace issue. AddressArbiter: Fixed incorrect comment, reordered if-statement to be more clear. SVC: Removed trailing whitespace.
* Thread: Added functions to resume threads from address arbitration.bunnei2014-07-092-0/+44
| | | | | | Thread: Cleaned up arbitrate address functions. Thread: Cleaned up ArbitrateAllThreads function.
* SharedMemory: Updated MapSharedMemory to use an enum for permissions.bunnei2014-07-052-6/+27
| | | | - Also added some safety checks to MapSharedMemory.
* Kernel: Added support for shared memory objects.bunnei2014-07-052-0/+132
| | | | SharedMemory: Added optional name field for tracking known objects.
* Archive: Added Init/Shutdown methods to reset kernel archive state.bunnei2014-07-053-0/+19
|
* FileSys: Added preliminary support for applications reading the RomFS archive.bunnei2014-07-052-10/+105
| | | | | | | | | | Archive: Fixed brace ugliness for neobrain :) FS: Commented out unused local variables to prevent warnings. ...But keeping them here for future use. archive_romfs: Removed unused #include.
* Kernel: Added stubbed code to support creation of kernel Archive objects.bunnei2014-06-273-0/+85
|
* Kernel: Removed unnecessary "#pragma once".bunnei2014-06-131-2/+0
|
* Kernel: Added freeing of kernel objects on emulator shutdown.bunnei2014-06-132-0/+10
|
* Event: Updated several log messages to be assertions.bunnei2014-06-131-16/+8
|
* Thread: Renamed occurrences of "t" to "thread" to improve readability.bunnei2014-06-131-48/+45
|
* Thread: Cleaned up VerifyWait, fixed issue where nullptr msg could unnecessarily be logged.bunnei2014-06-131-9/+7
|
* HLE: Removed usnused EatCycles function.bunnei2014-06-131-9/+0
|
* Thread: Moved position of * in arguments.bunnei2014-06-131-2/+2
|
* Thread: Updated VerifyWait to be more readable (but functionally the same).bunnei2014-06-131-4/+3
|
* HLE: Updated all uses of NULL to nullptr (to be C++11 compliant)bunnei2014-06-133-9/+9
|
* Kernel: Updated various kernel function "name" arguments to be const references.bunnei2014-06-134-6/+6
|
* HLE: Updated various handle debug assertions to be more clear.bunnei2014-06-132-3/+3
|
* Mutex: Moved ReleaseMutex iterator declaration to be inside while loop.bunnei2014-06-131-2/+1
|
* Kernel: Updated several member functions to be constbunnei2014-06-134-11/+11
|
* Thread: Fixed bug with ResetThread where cpu_registers[15] was being incorrectly setbunnei2014-06-131-1/+1
|
* Kernel: Made SyncRequest not pure virtual, with a default implementation of error (as this is not required for all kernel objects)bunnei2014-06-133-23/+4
|
* Kernel: Added real support for thread and event blockingbunnei2014-06-135-48/+165
| | | | | | | | | | | | | - SVC: Added ExitThread support - SVC: Added SignalEvent support - Thread: Added WAITTYPE_EVENT for waiting threads for event signals - Thread: Added support for blocking on other threads to finish (e.g. Thread::Join) - Thread: Added debug function for printing current threads ready for execution - Thread: Removed hack/broken thread ready state code from Kernel::Reschedule - Mutex: Moved WaitCurrentThread from SVC to Mutex::WaitSynchronization - Event: Added support for blocking threads on event signalling Kernel: Added missing algorithm #include for use of std::find on non-Windows platforms.
* kernel: changed current default thread priority back to 0x30 - I think this is more correctbunnei2014-06-051-1/+1
|
* svc: added optional name field to Event and Mutex (used for debugging)bunnei2014-06-034-8/+21
|
* kernel: moved position of * for GetTypeName and GetNamebunnei2014-06-031-2/+2
|
* svc: added GetThreadPriority and SetThreadPriority, added (incomplete) DuplicateHandle supportbunnei2014-06-022-0/+51
|
* kernel: changed main thread priority to default, updated Kernel::Reschedule to use PrepareReschedulebunnei2014-06-023-4/+6
|
* thread: updated Reschedule to sit at a synchronization barrier when no other threads are ready for executionbunnei2014-06-011-0/+18
|
* event: added a hackish ability to set an event as "locked" to its current state, cleaned up some commentsbunnei2014-06-012-4/+32
|
* mutex: fixed typo in ReleaseMutexbunnei2014-05-301-1/+3
|
* event: added support for ClearEvent, fixed a bug with CreateEvent, fixed some commentsbunnei2014-05-302-9/+14
|
* mutex: added preliminary SyncRequest/WaitSynchronization, added some comments/assertionsbunnei2014-05-281-0/+6
|
* event: fixed typos and updated CMakeListsbunnei2014-05-281-1/+1
|
* event: added SetEventLocked method to change status an events lockbunnei2014-05-282-0/+18
|
* kernel: added event module to support creation of CTR "Event" objectsbunnei2014-05-282-0/+119
|
* mutex: removed docstring comment that is no longer relevantbunnei2014-05-271-1/+0
|
* mutex: added additional docstringsbunnei2014-05-271-0/+2
|
* kernel: added WaitSynchronization method to Kernel::Objectbunnei2014-05-273-0/+29
|
* kernel: updated SyncRequest to take boolean thread wait result as a parameterbunnei2014-05-273-5/+20
|
* kernel: added enum for known CurrentThread and CurrentProcess handlesbunnei2014-05-271-0/+5
|
* kernel: add a SyncRequest method to KernelObject for use with svcSendSyncRequestbunnei2014-05-273-0/+11
|
* thread: renamed "WaitCurThread" to "WaitCurrentThread", removed unused "reason" argumentbunnei2014-05-232-4/+4
|
* thread: removed unused SwitchContext/Reschedule reason field, added missing arg parameter to SVC CreateThreadbunnei2014-05-232-4/+4
|
* kernel: refactored function naming to remove "__" prefixbunnei2014-05-235-62/+72
|
* thread: moved ThreadStatus/WaitType to header, added support for arg on CreateThread, added correct CPSR resetbunnei2014-05-232-35/+40
|
* thread: fixed bug where result of __NextThread was not being properly checked when NULLbunnei2014-05-221-1/+1
|
* mutex: refactored the interface to code to return a Mutex* handlebunnei2014-05-212-3/+13
|
* mutex: initial commit of HLE modulebunnei2014-05-212-0/+148
|
* kernel: fixed include, in general include "common.h" not "common_types.h"bunnei2014-05-211-1/+1
|
* thread: added correct lowest thread priority, added a thread priority check, and added some commentsbunnei2014-05-212-6/+10
|
* thread: exposed ResumeThreadFromWait function for use in other kernel modulesbunnei2014-05-212-8/+11
|
* thread: moved threading calls to the Kernel namespacebunnei2014-05-213-101/+115
|
* ARM_Interface: added SaveContext and LoadContext functions for HLE thread switchingbunnei2014-05-211-36/+2
|
* renamed "syscall" module to "svc" (more accurate naming)bunnei2014-05-211-1/+1
|
* thread: whitespace change - fixed * and & placementbunnei2014-05-212-27/+27
|
* - created a Kernel namespacebunnei2014-05-214-67/+79
| | | | | - cleaned up Kernel code a bit (moved stuff into namespace, fixed whitespace issues) - added handle types for all different CTROS handles
* thread: added declaration for __KernelReschedule to be used by syscall modulebunnei2014-05-201-0/+3
|
* - updated service(s) to be KernelObject'sbunnei2014-05-191-4/+5
| | | | - various cleanups
* - moved Handle/Result definitions to kernel.hbunnei2014-05-192-3/+2
| | | | - added ResetType enum
* changed a commentbunnei2014-05-172-2/+2
|
* - added enum ThreadProcessorIdbunnei2014-05-172-53/+107
| | | | | - reorganized some kernel thread functions - added placeholder __KernelWaitThread_Synchronization function
* - replaced KERNELOBJECT_MAX_NAME_LENGTH with KERNEL_MAX_NAME_LENGTHbunnei2014-05-173-8/+12
| | | | - added KERNEL_DEFAULT_STACK_SIZE definition (0x4000)
* completely gutted/refactored threading code to be simplerbunnei2014-05-162-658/+230
|
* changed "UID" to "Handle" to be a little more consistent with CTR namingbunnei2014-05-162-18/+21
|
* - added helper function for __KernelCreateThreadbunnei2014-05-152-4/+76
| | | | | - added __KernelSwitchToThread for enabling a thread - added __KernelRotateThreadReadyQueue
* changed primary thread priority to 0x30 - this is typical, not 0x31bunnei2014-05-151-1/+2
|
* fixed thread reset to not set stack addressbunnei2014-05-141-1/+1
|
* various cleanups / remove unused codebunnei2014-05-142-65/+29
|
* added a bunch of threading code, recycled from PPSSPP, with lots of hacks in for 3DS... doesn't really do much yet. Just a jumping off pointbunnei2014-05-142-70/+543
|
* - added __KernelLoadExec functionbunnei2014-05-142-13/+35
| | | | - fixed some logging
* added initial kernel/thread modulesbunnei2014-05-104-0/+527