summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorMorph <39850852+Morph1984@users.noreply.github.com>2020-07-16 11:22:51 +0200
committerMorph <39850852+Morph1984@users.noreply.github.com>2020-07-16 11:22:51 +0200
commitf66e3181dc3ead065330aa81a07e530643579f7f (patch)
tree49d44e16d7a5b30a80733a980cbdb1534f216231 /src
parentclang format (diff)
downloadyuzu-f66e3181dc3ead065330aa81a07e530643579f7f.tar
yuzu-f66e3181dc3ead065330aa81a07e530643579f7f.tar.gz
yuzu-f66e3181dc3ead065330aa81a07e530643579f7f.tar.bz2
yuzu-f66e3181dc3ead065330aa81a07e530643579f7f.tar.lz
yuzu-f66e3181dc3ead065330aa81a07e530643579f7f.tar.xz
yuzu-f66e3181dc3ead065330aa81a07e530643579f7f.tar.zst
yuzu-f66e3181dc3ead065330aa81a07e530643579f7f.zip
Diffstat (limited to 'src')
-rw-r--r--src/core/file_sys/registered_cache.cpp22
1 files changed, 19 insertions, 3 deletions
diff --git a/src/core/file_sys/registered_cache.cpp b/src/core/file_sys/registered_cache.cpp
index 92417ef70..37351c561 100644
--- a/src/core/file_sys/registered_cache.cpp
+++ b/src/core/file_sys/registered_cache.cpp
@@ -566,12 +566,13 @@ bool RegisteredCache::RemoveExistingEntry(u64 title_id) {
return res;
};
- // If an update exists, remove
+ // If an entry exists in the registered cache, remove it
if (HasEntry(title_id, ContentRecordType::Meta)) {
LOG_INFO(Loader,
- "Previous Update (v{}) for title_id={:016X} detected! Attempting to remove...",
+ "Previously installed entry (v{}) for title_id={:016X} detected! "
+ "Attempting to remove...",
GetEntryVersion(title_id).value_or(0), title_id);
- // Get all the ncas associated with the current update CNMT and delete them
+ // Get all the ncas associated with the current CNMT and delete them
const auto meta_old_id =
GetNcaIDFromMetadata(title_id, ContentRecordType::Meta).value_or(NcaID{});
const auto program_id =
@@ -612,7 +613,22 @@ InstallResult RegisteredCache::InstallEntry(const NSP& nsp, bool overwrite_if_ex
const auto meta_id_raw = (*meta_iter)->GetName().substr(0, 32);
const auto meta_id = Common::HexStringToArray<16>(meta_id_raw);
+ if ((*meta_iter)->GetSubdirectories().empty()) {
+ LOG_ERROR(Loader,
+ "The file you are attempting to install does not contain a section0 within the "
+ "metadata NCA and is therefore malformed. Verify that the file is valid.");
+ return InstallResult::ErrorMetaFailed;
+ }
+
const auto section0 = (*meta_iter)->GetSubdirectories()[0];
+
+ if (section0->GetFiles().empty()) {
+ LOG_ERROR(Loader,
+ "The file you are attempting to install does not contain a CNMT within the "
+ "metadata NCA and is therefore malformed. Verify that the file is valid.");
+ return InstallResult::ErrorMetaFailed;
+ }
+
const auto cnmt_file = section0->GetFiles()[0];
const CNMT cnmt(cnmt_file);