summaryrefslogtreecommitdiffstats
path: root/src/video_core/texture_cache
diff options
context:
space:
mode:
authorFernando Sahmkow <fsahmkow27@gmail.com>2021-07-19 04:32:03 +0200
committerFernando Sahmkow <fsahmkow27@gmail.com>2021-11-16 22:11:27 +0100
commitba18047e8d06584de0ce18cdbb303a6d9a8742aa (patch)
tree1c7c3cd54bc82de9d7a746ba1172f1fd013ab9b7 /src/video_core/texture_cache
parentShaderDecompiler: Add initial support for rescaling. (diff)
downloadyuzu-ba18047e8d06584de0ce18cdbb303a6d9a8742aa.tar
yuzu-ba18047e8d06584de0ce18cdbb303a6d9a8742aa.tar.gz
yuzu-ba18047e8d06584de0ce18cdbb303a6d9a8742aa.tar.bz2
yuzu-ba18047e8d06584de0ce18cdbb303a6d9a8742aa.tar.lz
yuzu-ba18047e8d06584de0ce18cdbb303a6d9a8742aa.tar.xz
yuzu-ba18047e8d06584de0ce18cdbb303a6d9a8742aa.tar.zst
yuzu-ba18047e8d06584de0ce18cdbb303a6d9a8742aa.zip
Diffstat (limited to 'src/video_core/texture_cache')
-rw-r--r--src/video_core/texture_cache/image_info.cpp3
-rw-r--r--src/video_core/texture_cache/texture_cache.h84
-rw-r--r--src/video_core/texture_cache/texture_cache_base.h3
3 files changed, 77 insertions, 13 deletions
diff --git a/src/video_core/texture_cache/image_info.cpp b/src/video_core/texture_cache/image_info.cpp
index 64fd7010a..022ca9033 100644
--- a/src/video_core/texture_cache/image_info.cpp
+++ b/src/video_core/texture_cache/image_info.cpp
@@ -41,6 +41,7 @@ ImageInfo::ImageInfo(const TICEntry& config) noexcept {
ASSERT(config.BaseLayer() == 0);
type = ImageType::e1D;
size.width = config.Width();
+ resources.layers = 1;
break;
case TextureType::Texture1DArray:
UNIMPLEMENTED_IF(config.BaseLayer() != 0);
@@ -82,10 +83,12 @@ ImageInfo::ImageInfo(const TICEntry& config) noexcept {
size.width = config.Width();
size.height = config.Height();
size.depth = config.Depth();
+ resources.layers = 1;
break;
case TextureType::Texture1DBuffer:
type = ImageType::Buffer;
size.width = config.Width();
+ resources.layers = 1;
break;
default:
UNREACHABLE_MSG("Invalid texture_type={}", static_cast<int>(config.texture_type.Value()));
diff --git a/src/video_core/texture_cache/texture_cache.h b/src/video_core/texture_cache/texture_cache.h
index 560da4f16..95a9e8fe9 100644
--- a/src/video_core/texture_cache/texture_cache.h
+++ b/src/video_core/texture_cache/texture_cache.h
@@ -242,24 +242,36 @@ void TextureCache<P>::UpdateRenderTargets(bool is_clear) {
const auto scale_up = [this](ImageId image_id) {
if (image_id != CORRUPT_ID) {
Image& image = slot_images[image_id];
- image.ScaleUp();
+ return ScaleUp(image);
}
+ return false;
};
for (size_t index = 0; index < NUM_RT; ++index) {
- scale_up(tmp_color_images[index]);
+ if (scale_up(tmp_color_images[index])) {
+ BindRenderTarget(&render_targets.color_buffer_ids[index],
+ FindColorBuffer(index, is_clear));
+ }
+ }
+ if (scale_up(tmp_depth_image)) {
+ BindRenderTarget(&render_targets.depth_buffer_id, FindDepthBuffer(is_clear));
}
- scale_up(tmp_depth_image);
} else {
const auto scale_down = [this](ImageId image_id) {
if (image_id != CORRUPT_ID) {
Image& image = slot_images[image_id];
- image.ScaleDown();
+ return ScaleDown(image);
}
+ return false;
};
for (size_t index = 0; index < NUM_RT; ++index) {
- scale_down(tmp_color_images[index]);
+ if (scale_down(tmp_color_images[index])) {
+ BindRenderTarget(&render_targets.color_buffer_ids[index],
+ FindColorBuffer(index, is_clear));
+ }
+ }
+ if (scale_down(tmp_depth_image)) {
+ BindRenderTarget(&render_targets.depth_buffer_id, FindDepthBuffer(is_clear));
}
- scale_down(tmp_depth_image);
}
// Rescale End
@@ -696,6 +708,47 @@ bool TextureCache<P>::ImageCanRescale(Image& image) {
}
template <class P>
+void TextureCache<P>::InvalidateScale(Image& image, bool invalidate_rt) {
+ const std::span<const ImageViewId> image_view_ids = image.image_view_ids;
+ if (invalidate_rt) {
+ auto& dirty = maxwell3d.dirty.flags;
+ dirty[Dirty::RenderTargets] = true;
+ dirty[Dirty::ZetaBuffer] = true;
+ for (size_t rt = 0; rt < NUM_RT; ++rt) {
+ dirty[Dirty::ColorBuffer0 + rt] = true;
+ }
+ for (const ImageViewId image_view_id : image_view_ids) {
+ std::ranges::replace(render_targets.color_buffer_ids, image_view_id, ImageViewId{});
+ if (render_targets.depth_buffer_id == image_view_id) {
+ render_targets.depth_buffer_id = ImageViewId{};
+ }
+ }
+ }
+ RemoveImageViewReferences(image_view_ids);
+ RemoveFramebuffers(image_view_ids);
+}
+
+template <class P>
+bool TextureCache<P>::ScaleUp(Image& image, bool invalidate_rt) {
+ const bool rescaled = image.ScaleUp();
+ if (!rescaled) {
+ return false;
+ }
+ InvalidateScale(image, invalidate_rt);
+ return true;
+}
+
+template <class P>
+bool TextureCache<P>::ScaleDown(Image& image, bool invalidate_rt) {
+ const bool rescaled = image.ScaleDown();
+ if (!rescaled) {
+ return false;
+ }
+ InvalidateScale(image, invalidate_rt);
+ return true;
+}
+
+template <class P>
ImageId TextureCache<P>::InsertImage(const ImageInfo& info, GPUVAddr gpu_addr,
RelaxedOptions options) {
std::optional<VAddr> cpu_addr = gpu_memory.GpuToCpuAddress(gpu_addr);
@@ -793,33 +846,32 @@ ImageId TextureCache<P>::JoinImages(const ImageInfo& info, GPUVAddr gpu_addr, VA
bool can_rescale =
(info.type == ImageType::e1D || info.type == ImageType::e2D) && info.block.depth == 0;
+ bool any_rescaled = false;
for (const ImageId sibling_id : all_siblings) {
if (!can_rescale) {
break;
}
Image& sibling = slot_images[sibling_id];
can_rescale &= ImageCanRescale(sibling);
+ any_rescaled |= True(sibling.flags & ImageFlagBits::Rescaled);
}
+ can_rescale &= any_rescaled;
+
if (can_rescale) {
for (const ImageId sibling_id : all_siblings) {
Image& sibling = slot_images[sibling_id];
- sibling.ScaleUp();
+ ScaleUp(sibling, true);
}
} else {
for (const ImageId sibling_id : all_siblings) {
Image& sibling = slot_images[sibling_id];
- sibling.ScaleDown();
+ ScaleDown(sibling, true);
}
}
const ImageId new_image_id = slot_images.insert(runtime, new_info, gpu_addr, cpu_addr);
Image& new_image = slot_images[new_image_id];
- if (can_rescale) {
- new_image.ScaleUp();
- } else {
- new_image.ScaleDown();
- }
if (!gpu_memory.IsContinousRange(new_image.gpu_addr, new_image.guest_size_bytes)) {
new_image.flags |= ImageFlagBits::Sparse;
@@ -840,6 +892,12 @@ ImageId TextureCache<P>::JoinImages(const ImageInfo& info, GPUVAddr gpu_addr, VA
// TODO: Only upload what we need
RefreshContents(new_image, new_image_id);
+ if (can_rescale) {
+ new_image.ScaleUp();
+ } else {
+ new_image.ScaleDown();
+ }
+
for (const ImageId overlap_id : overlap_ids) {
Image& overlap = slot_images[overlap_id];
if (overlap.info.num_samples != new_image.info.num_samples) {
diff --git a/src/video_core/texture_cache/texture_cache_base.h b/src/video_core/texture_cache/texture_cache_base.h
index a4a2c0832..042678786 100644
--- a/src/video_core/texture_cache/texture_cache_base.h
+++ b/src/video_core/texture_cache/texture_cache_base.h
@@ -327,6 +327,9 @@ private:
[[nodiscard]] bool IsFullClear(ImageViewId id);
bool ImageCanRescale(Image& image);
+ void InvalidateScale(Image& image, bool invalidate_rt = false);
+ bool ScaleUp(Image& image, bool invalidate_rt = false);
+ bool ScaleDown(Image& image, bool invalidate_rt = false);
Runtime& runtime;
VideoCore::RasterizerInterface& rasterizer;