summaryrefslogtreecommitdiffstats
path: root/src/video_core/renderer_opengl/pica_to_gl.h
diff options
context:
space:
mode:
authorYuri Kunde Schlesner <yuriks@yuriks.net>2017-06-14 06:28:13 +0200
committerGitHub <noreply@github.com>2017-06-14 06:28:12 +0200
commit5fe5ccac4250d5f001cc29838033e2fef63ebb6c (patch)
tree32224370753184eeca64cf9b055351ee599c9e94 /src/video_core/renderer_opengl/pica_to_gl.h
parentServices/UDS: Set the proper bit in the ConnectionStatus structure when creating a network. (#2738) (diff)
parentpica/rasterizer: implement/stub texture wrap mode 4-7 (diff)
downloadyuzu-5fe5ccac4250d5f001cc29838033e2fef63ebb6c.tar
yuzu-5fe5ccac4250d5f001cc29838033e2fef63ebb6c.tar.gz
yuzu-5fe5ccac4250d5f001cc29838033e2fef63ebb6c.tar.bz2
yuzu-5fe5ccac4250d5f001cc29838033e2fef63ebb6c.tar.lz
yuzu-5fe5ccac4250d5f001cc29838033e2fef63ebb6c.tar.xz
yuzu-5fe5ccac4250d5f001cc29838033e2fef63ebb6c.tar.zst
yuzu-5fe5ccac4250d5f001cc29838033e2fef63ebb6c.zip
Diffstat (limited to 'src/video_core/renderer_opengl/pica_to_gl.h')
-rw-r--r--src/video_core/renderer_opengl/pica_to_gl.h13
1 files changed, 13 insertions, 0 deletions
diff --git a/src/video_core/renderer_opengl/pica_to_gl.h b/src/video_core/renderer_opengl/pica_to_gl.h
index 93d7b0b71..70298e211 100644
--- a/src/video_core/renderer_opengl/pica_to_gl.h
+++ b/src/video_core/renderer_opengl/pica_to_gl.h
@@ -55,6 +55,12 @@ inline GLenum WrapMode(Pica::TexturingRegs::TextureConfig::WrapMode mode) {
GL_CLAMP_TO_BORDER, // WrapMode::ClampToBorder
GL_REPEAT, // WrapMode::Repeat
GL_MIRRORED_REPEAT, // WrapMode::MirroredRepeat
+ // TODO(wwylele): ClampToEdge2 and ClampToBorder2 are not properly implemented here. See the
+ // comments in enum WrapMode.
+ GL_CLAMP_TO_EDGE, // WrapMode::ClampToEdge2
+ GL_CLAMP_TO_BORDER, // WrapMode::ClampToBorder2
+ GL_REPEAT, // WrapMode::Repeat2
+ GL_REPEAT, // WrapMode::Repeat3
};
// Range check table for input
@@ -65,6 +71,13 @@ inline GLenum WrapMode(Pica::TexturingRegs::TextureConfig::WrapMode mode) {
return GL_CLAMP_TO_EDGE;
}
+ if (static_cast<u32>(mode) > 3) {
+ // It is still unclear whether mode 4-7 are valid, so log it if a game uses them.
+ // TODO(wwylele): telemetry should be added here so we can collect more info about which
+ // game uses this.
+ LOG_WARNING(Render_OpenGL, "Using texture wrap mode %u", static_cast<u32>(mode));
+ }
+
GLenum gl_mode = wrap_mode_table[mode];
// Check for dummy values indicating an unknown mode