summaryrefslogtreecommitdiffstats
path: root/src/core/hle/kernel/server_session.cpp
diff options
context:
space:
mode:
authorFernando Sahmkow <fsahmkow27@gmail.com>2019-11-26 12:13:04 +0100
committerGitHub <noreply@github.com>2019-11-26 12:13:04 +0100
commit59484442a0a7bf72f6b627a9b0672898314f2dad (patch)
tree2514317ed0d0ada5de3a219bdd1f5baa635760dc /src/core/hle/kernel/server_session.cpp
parentMerge pull request #3160 from DarkLordZach/opt-ea-clang-fmt (diff)
parentkernel: Fix reference management for client/server session. (diff)
downloadyuzu-59484442a0a7bf72f6b627a9b0672898314f2dad.tar
yuzu-59484442a0a7bf72f6b627a9b0672898314f2dad.tar.gz
yuzu-59484442a0a7bf72f6b627a9b0672898314f2dad.tar.bz2
yuzu-59484442a0a7bf72f6b627a9b0672898314f2dad.tar.lz
yuzu-59484442a0a7bf72f6b627a9b0672898314f2dad.tar.xz
yuzu-59484442a0a7bf72f6b627a9b0672898314f2dad.tar.zst
yuzu-59484442a0a7bf72f6b627a9b0672898314f2dad.zip
Diffstat (limited to 'src/core/hle/kernel/server_session.cpp')
-rw-r--r--src/core/hle/kernel/server_session.cpp18
1 files changed, 9 insertions, 9 deletions
diff --git a/src/core/hle/kernel/server_session.cpp b/src/core/hle/kernel/server_session.cpp
index 2994fa0ac..c7db21eb2 100644
--- a/src/core/hle/kernel/server_session.cpp
+++ b/src/core/hle/kernel/server_session.cpp
@@ -31,8 +31,6 @@ ServerSession::~ServerSession() {
if (parent->port) {
parent->port->ConnectionClosed();
}
-
- parent->server = nullptr;
}
ResultVal<std::shared_ptr<ServerSession>> ServerSession::Create(KernelCore& kernel,
@@ -46,11 +44,13 @@ ResultVal<std::shared_ptr<ServerSession>> ServerSession::Create(KernelCore& kern
}
bool ServerSession::ShouldWait(const Thread* thread) const {
- // Closed sessions should never wait, an error will be returned from svcReplyAndReceive.
- if (parent->client == nullptr)
- return false;
// Wait if we have no pending requests, or if we're currently handling a request.
- return pending_requesting_threads.empty() || currently_handling != nullptr;
+ if (auto client = parent->client.lock()) {
+ return pending_requesting_threads.empty() || currently_handling != nullptr;
+ }
+
+ // Closed sessions should never wait, an error will be returned from svcReplyAndReceive.
+ return {};
}
void ServerSession::Acquire(Thread* thread) {
@@ -192,9 +192,9 @@ ServerSession::SessionPair ServerSession::CreateSessionPair(KernelCore& kernel,
std::shared_ptr<ClientSession> client_session = std::make_shared<ClientSession>(kernel);
client_session->name = name + "_Client";
- std::shared_ptr<Session> parent(new Session);
- parent->client = client_session.get();
- parent->server = server_session.get();
+ std::shared_ptr<Session> parent = std::make_shared<Session>();
+ parent->client = client_session;
+ parent->server = server_session;
parent->port = std::move(port);
client_session->parent = parent;