summaryrefslogtreecommitdiffstats
path: root/src/core/hle/kernel/k_light_lock.cpp
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2021-06-11 20:03:55 +0200
committerGitHub <noreply@github.com>2021-06-11 20:03:55 +0200
commit0c0c1a039ec73937db4bc24e0bcbc478e3e6704b (patch)
tree54b9110b9b80047ed0bebd3982fdfccc51dda76d /src/core/hle/kernel/k_light_lock.cpp
parentMerge pull request #6450 from lat9nq/update-sdl (diff)
parentkernel: Unconditionally set thread state when appropriate (diff)
downloadyuzu-0c0c1a039ec73937db4bc24e0bcbc478e3e6704b.tar
yuzu-0c0c1a039ec73937db4bc24e0bcbc478e3e6704b.tar.gz
yuzu-0c0c1a039ec73937db4bc24e0bcbc478e3e6704b.tar.bz2
yuzu-0c0c1a039ec73937db4bc24e0bcbc478e3e6704b.tar.lz
yuzu-0c0c1a039ec73937db4bc24e0bcbc478e3e6704b.tar.xz
yuzu-0c0c1a039ec73937db4bc24e0bcbc478e3e6704b.tar.zst
yuzu-0c0c1a039ec73937db4bc24e0bcbc478e3e6704b.zip
Diffstat (limited to 'src/core/hle/kernel/k_light_lock.cpp')
-rw-r--r--src/core/hle/kernel/k_light_lock.cpp19
1 files changed, 5 insertions, 14 deletions
diff --git a/src/core/hle/kernel/k_light_lock.cpp b/src/core/hle/kernel/k_light_lock.cpp
index f974022e8..0896e705f 100644
--- a/src/core/hle/kernel/k_light_lock.cpp
+++ b/src/core/hle/kernel/k_light_lock.cpp
@@ -59,11 +59,7 @@ void KLightLock::LockSlowPath(uintptr_t _owner, uintptr_t _cur_thread) {
owner_thread->AddWaiter(cur_thread);
// Set thread states.
- if (cur_thread->GetState() == ThreadState::Runnable) {
- cur_thread->SetState(ThreadState::Waiting);
- } else {
- KScheduler::SetSchedulerUpdateNeeded(kernel);
- }
+ cur_thread->SetState(ThreadState::Waiting);
if (owner_thread->IsSuspended()) {
owner_thread->ContinueIfHasKernelWaiters();
@@ -73,10 +69,9 @@ void KLightLock::LockSlowPath(uintptr_t _owner, uintptr_t _cur_thread) {
// We're no longer waiting on the lock owner.
{
KScopedSchedulerLock sl{kernel};
- KThread* owner_thread = cur_thread->GetLockOwner();
- if (owner_thread) {
+
+ if (KThread* owner_thread = cur_thread->GetLockOwner(); owner_thread != nullptr) {
owner_thread->RemoveWaiter(cur_thread);
- KScheduler::SetSchedulerUpdateNeeded(kernel);
}
}
}
@@ -95,17 +90,13 @@ void KLightLock::UnlockSlowPath(uintptr_t _cur_thread) {
// Pass the lock to the next owner.
uintptr_t next_tag = 0;
- if (next_owner) {
+ if (next_owner != nullptr) {
next_tag = reinterpret_cast<uintptr_t>(next_owner);
if (num_waiters > 1) {
next_tag |= 0x1;
}
- if (next_owner->GetState() == ThreadState::Waiting) {
- next_owner->SetState(ThreadState::Runnable);
- } else {
- KScheduler::SetSchedulerUpdateNeeded(kernel);
- }
+ next_owner->SetState(ThreadState::Runnable);
if (next_owner->IsSuspended()) {
next_owner->ContinueIfHasKernelWaiters();