summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorbunnei <bunneidev@gmail.com>2021-01-25 07:54:37 +0100
committerbunnei <bunneidev@gmail.com>2021-01-29 06:42:26 +0100
commit3856564727e3efcf85fb0c1e5431cab22d818370 (patch)
tree589d4322c34c6ae15184b322b9302c33f1c34087
parenthle: kernel: threading: Fix bug with host thread naming. (diff)
downloadyuzu-3856564727e3efcf85fb0c1e5431cab22d818370.tar
yuzu-3856564727e3efcf85fb0c1e5431cab22d818370.tar.gz
yuzu-3856564727e3efcf85fb0c1e5431cab22d818370.tar.bz2
yuzu-3856564727e3efcf85fb0c1e5431cab22d818370.tar.lz
yuzu-3856564727e3efcf85fb0c1e5431cab22d818370.tar.xz
yuzu-3856564727e3efcf85fb0c1e5431cab22d818370.tar.zst
yuzu-3856564727e3efcf85fb0c1e5431cab22d818370.zip
-rw-r--r--src/core/hle/kernel/process.cpp4
-rw-r--r--src/core/hle/kernel/process.h6
-rw-r--r--src/core/hle/kernel/svc.cpp11
3 files changed, 15 insertions, 6 deletions
diff --git a/src/core/hle/kernel/process.cpp b/src/core/hle/kernel/process.cpp
index 9f4583b49..0edbfc4cc 100644
--- a/src/core/hle/kernel/process.cpp
+++ b/src/core/hle/kernel/process.cpp
@@ -138,7 +138,7 @@ std::shared_ptr<ResourceLimit> Process::GetResourceLimit() const {
void Process::IncrementThreadCount() {
ASSERT(num_threads >= 0);
- ++num_created_threads;
+ num_created_threads++;
if (const auto count = ++num_threads; count > peak_num_threads) {
peak_num_threads = count;
@@ -443,7 +443,7 @@ bool Process::IsSignaled() const {
Process::Process(Core::System& system)
: KSynchronizationObject{system.Kernel()},
page_table{std::make_unique<Memory::PageTable>(system)}, handle_table{system.Kernel()},
- address_arbiter{system}, condition_var{system}, system{system} {}
+ address_arbiter{system}, condition_var{system}, state_lock{system.Kernel()}, system{system} {}
Process::~Process() = default;
diff --git a/src/core/hle/kernel/process.h b/src/core/hle/kernel/process.h
index 11d78f3a8..26e647743 100644
--- a/src/core/hle/kernel/process.h
+++ b/src/core/hle/kernel/process.h
@@ -348,6 +348,10 @@ public:
void PinCurrentThread();
void UnpinCurrentThread();
+ KLightLock& GetStateLock() {
+ return state_lock;
+ }
+
///////////////////////////////////////////////////////////////////////////////////////////////
// Thread-local storage management
@@ -472,6 +476,8 @@ private:
KThread* exception_thread{};
+ KLightLock state_lock;
+
/// System context
Core::System& system;
};
diff --git a/src/core/hle/kernel/svc.cpp b/src/core/hle/kernel/svc.cpp
index dbef854f8..7fd514e9d 100644
--- a/src/core/hle/kernel/svc.cpp
+++ b/src/core/hle/kernel/svc.cpp
@@ -1450,11 +1450,14 @@ static ResultCode CreateThread(Core::System& system, Handle* out_handle, VAddr e
Svc::ResultInvalidPriority);
R_UNLESS(process.CheckThreadPriority(priority), Svc::ResultInvalidPriority);
- ASSERT(kernel.CurrentProcess()->GetResourceLimit()->Reserve(ResourceType::Threads, 1));
+ ASSERT(process.GetResourceLimit()->Reserve(ResourceType::Threads, 1));
- CASCADE_RESULT(std::shared_ptr<KThread> thread,
- KThread::Create(system, ThreadType::User, "", entry_point, priority, arg,
- core_id, stack_bottom, &process));
+ std::shared_ptr<KThread> thread;
+ {
+ KScopedLightLock lk{process.GetStateLock()};
+ CASCADE_RESULT(thread, KThread::Create(system, ThreadType::User, "", entry_point, priority,
+ arg, core_id, stack_bottom, &process));
+ }
const auto new_thread_handle = process.GetHandleTable().Create(thread);
if (new_thread_handle.Failed()) {