From e11e65b3d63fabd7c953cca07971364984021c3e Mon Sep 17 00:00:00 2001 From: Zach Hilman Date: Fri, 23 Nov 2018 11:00:33 -0500 Subject: applets: Correct event ResetTypes from OneShot to Sticky Fixes bugs relating to signalling in software keyboard. --- src/core/hle/service/am/applets/applets.cpp | 6 +++--- src/core/hle/service/am/applets/profile_select.cpp | 1 + src/core/hle/service/am/applets/profile_select.h | 4 ---- src/core/hle/service/am/applets/software_keyboard.cpp | 7 +------ src/yuzu/applets/profile_select.h | 2 +- 5 files changed, 6 insertions(+), 14 deletions(-) (limited to 'src') diff --git a/src/core/hle/service/am/applets/applets.cpp b/src/core/hle/service/am/applets/applets.cpp index 47da35537..7698ca819 100644 --- a/src/core/hle/service/am/applets/applets.cpp +++ b/src/core/hle/service/am/applets/applets.cpp @@ -16,11 +16,11 @@ namespace Service::AM::Applets { AppletDataBroker::AppletDataBroker() { auto& kernel = Core::System::GetInstance().Kernel(); state_changed_event = Kernel::WritableEvent::CreateEventPair( - kernel, Kernel::ResetType::OneShot, "ILibraryAppletAccessor:StateChangedEvent"); + kernel, Kernel::ResetType::Sticky, "ILibraryAppletAccessor:StateChangedEvent"); pop_out_data_event = Kernel::WritableEvent::CreateEventPair( - kernel, Kernel::ResetType::OneShot, "ILibraryAppletAccessor:PopDataOutEvent"); + kernel, Kernel::ResetType::Sticky, "ILibraryAppletAccessor:PopDataOutEvent"); pop_interactive_out_data_event = Kernel::WritableEvent::CreateEventPair( - kernel, Kernel::ResetType::OneShot, "ILibraryAppletAccessor:PopInteractiveDataOutEvent"); + kernel, Kernel::ResetType::Sticky, "ILibraryAppletAccessor:PopInteractiveDataOutEvent"); } AppletDataBroker::~AppletDataBroker() = default; diff --git a/src/core/hle/service/am/applets/profile_select.cpp b/src/core/hle/service/am/applets/profile_select.cpp index 750f0fdeb..4c7b45454 100644 --- a/src/core/hle/service/am/applets/profile_select.cpp +++ b/src/core/hle/service/am/applets/profile_select.cpp @@ -3,6 +3,7 @@ // Refer to the license.txt file included. #include + #include "common/assert.h" #include "common/string_util.h" #include "core/core.h" diff --git a/src/core/hle/service/am/applets/profile_select.h b/src/core/hle/service/am/applets/profile_select.h index c383527f4..787485f22 100644 --- a/src/core/hle/service/am/applets/profile_select.h +++ b/src/core/hle/service/am/applets/profile_select.h @@ -4,14 +4,10 @@ #pragma once -#include -#include #include #include "common/common_funcs.h" -#include "common/swap.h" #include "core/hle/service/acc/profile_manager.h" -#include "core/hle/service/am/am.h" #include "core/hle/service/am/applets/applets.h" namespace Service::AM::Applets { diff --git a/src/core/hle/service/am/applets/software_keyboard.cpp b/src/core/hle/service/am/applets/software_keyboard.cpp index 40984ffa9..981bdec51 100644 --- a/src/core/hle/service/am/applets/software_keyboard.cpp +++ b/src/core/hle/service/am/applets/software_keyboard.cpp @@ -38,12 +38,7 @@ static Core::Frontend::SoftwareKeyboardParameters ConvertToFrontendParameters( return params; } -SoftwareKeyboard::SoftwareKeyboard() { - // Some applets require this to be signalled on applet creation, some do not. Internally, this - // is done by a flag in the applet module, but for simplicity SoftwareKeyboard is one of the - // applets with this flag. - broker.SignalStateChanged(); -} +SoftwareKeyboard::SoftwareKeyboard() = default; SoftwareKeyboard::~SoftwareKeyboard() = default; diff --git a/src/yuzu/applets/profile_select.h b/src/yuzu/applets/profile_select.h index 9acb092f3..868573324 100644 --- a/src/yuzu/applets/profile_select.h +++ b/src/yuzu/applets/profile_select.h @@ -23,7 +23,7 @@ class QtProfileSelectionDialog final : public QDialog { Q_OBJECT public: - QtProfileSelectionDialog(QWidget* parent); + explicit QtProfileSelectionDialog(QWidget* parent); ~QtProfileSelectionDialog() override; void accept() override; -- cgit v1.2.3