From d3cb9201f1d34dd804a90cfe1f17142e5f4fa3b7 Mon Sep 17 00:00:00 2001 From: Fernando Sahmkow Date: Sat, 2 Jul 2022 15:45:38 +0200 Subject: Core timing: use only one thread. --- src/core/core_timing.cpp | 12 ++---------- src/core/core_timing.h | 2 -- 2 files changed, 2 insertions(+), 12 deletions(-) (limited to 'src') diff --git a/src/core/core_timing.cpp b/src/core/core_timing.cpp index 140578069..07b8e356b 100644 --- a/src/core/core_timing.cpp +++ b/src/core/core_timing.cpp @@ -61,12 +61,7 @@ void CoreTiming::Initialize(std::function&& on_thread_init_) { const auto empty_timed_callback = [](std::uintptr_t, std::chrono::nanoseconds) {}; ev_lost = CreateEvent("_lost_event", empty_timed_callback); if (is_multicore) { - const auto hardware_concurrency = std::thread::hardware_concurrency(); - size_t id = 0; - worker_threads.emplace_back(ThreadEntry, std::ref(*this), id++); - if (hardware_concurrency > 8) { - worker_threads.emplace_back(ThreadEntry, std::ref(*this), id++); - } + worker_threads.emplace_back(ThreadEntry, std::ref(*this), 0); } } @@ -228,14 +223,11 @@ std::optional CoreTiming::Advance() { event_queue.pop_back(); if (const auto event_type{evt.type.lock()}) { - sequence_mutex.lock(); + event_mutex.unlock(); - event_type->guard.lock(); - sequence_mutex.unlock(); const s64 delay = static_cast(GetGlobalTimeNs().count() - evt.time); event_type->callback(evt.user_data, std::chrono::nanoseconds{delay}); - event_type->guard.unlock(); event_mutex.lock(); pending_events.fetch_sub(1, std::memory_order_relaxed); diff --git a/src/core/core_timing.h b/src/core/core_timing.h index a86553e08..c52bffb3b 100644 --- a/src/core/core_timing.h +++ b/src/core/core_timing.h @@ -32,7 +32,6 @@ struct EventType { TimedCallback callback; /// A pointer to the name of the event. const std::string name; - mutable std::mutex guard; }; /** @@ -157,7 +156,6 @@ private: std::condition_variable wait_pause_cv; std::condition_variable wait_signal_cv; mutable std::mutex event_mutex; - mutable std::mutex sequence_mutex; std::atomic paused_state{}; bool is_paused{}; -- cgit v1.2.3