From be06b21f7bf23a1a5f9388a54c68309eea888063 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 6 Jul 2020 09:03:00 -0400 Subject: configure_graphics: Prevent unnecessary string copies in UpdateDeviceComboBox() Unlikely to impact performance at all, but this is essentially a "free" transformation, so why not? --- src/yuzu/configuration/configure_graphics.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/yuzu/configuration/configure_graphics.cpp b/src/yuzu/configuration/configure_graphics.cpp index 304625cd7..e8c8f5f20 100644 --- a/src/yuzu/configuration/configure_graphics.cpp +++ b/src/yuzu/configuration/configure_graphics.cpp @@ -112,7 +112,7 @@ void ConfigureGraphics::UpdateDeviceComboBox() { enabled = false; break; case Settings::RendererBackend::Vulkan: - for (const auto device : vulkan_devices) { + for (const auto& device : vulkan_devices) { ui->device->addItem(device); } ui->device->setCurrentIndex(vulkan_device); -- cgit v1.2.3 From 4f678284e208e3021f4e54e4583d95c4e8fcc2c6 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 6 Jul 2020 09:05:52 -0400 Subject: configure_graphics: Make use of qOverload in signals/slots While we're in the same area, we can make use of qOverload to tidy up some function pointer casts. --- src/yuzu/configuration/configure_graphics.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/yuzu/configuration/configure_graphics.cpp b/src/yuzu/configuration/configure_graphics.cpp index e8c8f5f20..431f51d73 100644 --- a/src/yuzu/configuration/configure_graphics.cpp +++ b/src/yuzu/configuration/configure_graphics.cpp @@ -28,9 +28,9 @@ ConfigureGraphics::ConfigureGraphics(QWidget* parent) SetConfiguration(); - connect(ui->api, static_cast(&QComboBox::currentIndexChanged), this, + connect(ui->api, qOverload(&QComboBox::currentIndexChanged), this, [this] { UpdateDeviceComboBox(); }); - connect(ui->device, static_cast(&QComboBox::activated), this, + connect(ui->device, qOverload(&QComboBox::activated), this, [this](int device) { UpdateDeviceSelection(device); }); connect(ui->bg_button, &QPushButton::clicked, this, [this] { -- cgit v1.2.3