From 98631b45b6012f997081dc76c6908dcba8df729b Mon Sep 17 00:00:00 2001 From: arades79 Date: Tue, 14 Feb 2023 19:14:29 -0500 Subject: remove constexpr from virtual function Signed-off-by: arades79 --- src/core/debugger/gdbstub_arch.cpp | 4 ++-- src/core/debugger/gdbstub_arch.h | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/core/debugger/gdbstub_arch.cpp b/src/core/debugger/gdbstub_arch.cpp index f3dd517bd..831c48513 100644 --- a/src/core/debugger/gdbstub_arch.cpp +++ b/src/core/debugger/gdbstub_arch.cpp @@ -41,7 +41,7 @@ static void PutSIMDRegister(std::array& simd_regs, size_t offset, const // For sample XML files see the GDB source /gdb/features // This XML defines what the registers are for this specific ARM device -constexpr std::string_view GDBStubA64::GetTargetXML() const { +std::string_view GDBStubA64::GetTargetXML() const { return R"( @@ -267,7 +267,7 @@ u32 GDBStubA64::BreakpointInstruction() const { return 0xd4200000; } -constexpr std::string_view GDBStubA32::GetTargetXML() const { +std::string_view GDBStubA32::GetTargetXML() const { return R"( diff --git a/src/core/debugger/gdbstub_arch.h b/src/core/debugger/gdbstub_arch.h index 1958fdf88..34530c788 100644 --- a/src/core/debugger/gdbstub_arch.h +++ b/src/core/debugger/gdbstub_arch.h @@ -16,7 +16,7 @@ namespace Core { class GDBStubArch { public: virtual ~GDBStubArch() = default; - virtual constexpr std::string_view GetTargetXML() const = 0; + virtual std::string_view GetTargetXML() const = 0; virtual std::string RegRead(const Kernel::KThread* thread, size_t id) const = 0; virtual void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const = 0; virtual std::string ReadRegisters(const Kernel::KThread* thread) const = 0; @@ -27,7 +27,7 @@ public: class GDBStubA64 final : public GDBStubArch { public: - constexpr std::string_view GetTargetXML() const override; + std::string_view GetTargetXML() const override; std::string RegRead(const Kernel::KThread* thread, size_t id) const override; void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const override; std::string ReadRegisters(const Kernel::KThread* thread) const override; @@ -47,7 +47,7 @@ private: class GDBStubA32 final : public GDBStubArch { public: - constexpr std::string_view GetTargetXML() const override; + std::string_view GetTargetXML() const override; std::string RegRead(const Kernel::KThread* thread, size_t id) const override; void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const override; std::string ReadRegisters(const Kernel::KThread* thread) const override; -- cgit v1.2.3