From 091e1411422c62ef358c8d3750a92735858b1a61 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 22 Sep 2021 18:10:36 -0400 Subject: core/profile_select: Avoid uninitialized read in SelectProfile() The default constructor of UUID doesn't initialize its data members, so we need to directly initialize it to be invalid. --- src/core/frontend/applets/profile_select.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/core/frontend/applets/profile_select.cpp b/src/core/frontend/applets/profile_select.cpp index 4c58c310f..3e4f90be2 100644 --- a/src/core/frontend/applets/profile_select.cpp +++ b/src/core/frontend/applets/profile_select.cpp @@ -13,7 +13,8 @@ ProfileSelectApplet::~ProfileSelectApplet() = default; void DefaultProfileSelectApplet::SelectProfile( std::function)> callback) const { Service::Account::ProfileManager manager; - callback(manager.GetUser(Settings::values.current_user.GetValue()).value_or(Common::UUID{})); + callback(manager.GetUser(Settings::values.current_user.GetValue()) + .value_or(Common::UUID{Common::INVALID_UUID})); LOG_INFO(Service_ACC, "called, selecting current user instead of prompting..."); } -- cgit v1.2.3