From eadc1ae1e7a4ce873467b9ea244af752f57ce5e7 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Mon, 5 Dec 2022 21:42:22 -0500 Subject: reporter: Pass by const reference where applicable Same behavior, but without memory churn. --- src/core/reporter.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'src/core/reporter.h') diff --git a/src/core/reporter.h b/src/core/reporter.h index 983a9545a..9fdb9d6c1 100644 --- a/src/core/reporter.h +++ b/src/core/reporter.h @@ -36,7 +36,7 @@ public: // Used by syscall svcBreak void SaveSvcBreakReport(u32 type, bool signal_debugger, u64 info1, u64 info2, - std::optional> resolved_buffer = {}) const; + const std::optional>& resolved_buffer = {}) const; // Used by HLE service handler void SaveUnimplementedFunctionReport(Kernel::HLERequestContext& ctx, u32 command_id, @@ -44,10 +44,10 @@ public: const std::string& service_name) const; // Used by stub applet implementation - void SaveUnimplementedAppletReport(u32 applet_id, u32 common_args_version, u32 library_version, - u32 theme_color, bool startup_sound, u64 system_tick, - std::vector> normal_channel, - std::vector> interactive_channel) const; + void SaveUnimplementedAppletReport( + u32 applet_id, u32 common_args_version, u32 library_version, u32 theme_color, + bool startup_sound, u64 system_tick, const std::vector>& normal_channel, + const std::vector>& interactive_channel) const; enum class PlayReportType { Old, @@ -56,7 +56,7 @@ public: System, }; - void SavePlayReport(PlayReportType type, u64 title_id, std::vector> data, + void SavePlayReport(PlayReportType type, u64 title_id, const std::vector>& data, std::optional process_id = {}, std::optional user_id = {}) const; // Used by error applet -- cgit v1.2.3