From 6125590a7b2bbad7d5efdfbab69ba86601e0769b Mon Sep 17 00:00:00 2001 From: Lioncash Date: Tue, 20 Apr 2021 12:57:45 -0400 Subject: log/backend: Use in-class initializer for FileBackend We can also avoid redundant constructions of the same string repeatedly. --- src/common/logging/backend.cpp | 10 ++++++---- src/common/logging/backend.h | 4 ++-- 2 files changed, 8 insertions(+), 6 deletions(-) (limited to 'src/common') diff --git a/src/common/logging/backend.cpp b/src/common/logging/backend.cpp index f0bb392c6..96efa977d 100644 --- a/src/common/logging/backend.cpp +++ b/src/common/logging/backend.cpp @@ -148,12 +148,14 @@ void ColorConsoleBackend::Write(const Entry& entry) { PrintColoredMessage(entry); } -FileBackend::FileBackend(const std::string& filename) : bytes_written(0) { - if (FS::Exists(filename + ".old.txt")) { - FS::Delete(filename + ".old.txt"); +FileBackend::FileBackend(const std::string& filename) { + const auto old_filename = filename + ".old.txt"; + + if (FS::Exists(old_filename)) { + FS::Delete(old_filename); } if (FS::Exists(filename)) { - FS::Rename(filename, filename + ".old.txt"); + FS::Rename(filename, old_filename); } // _SH_DENYWR allows read only access to the file for other programs. diff --git a/src/common/logging/backend.h b/src/common/logging/backend.h index 84a544ea4..9dd2589c3 100644 --- a/src/common/logging/backend.h +++ b/src/common/logging/backend.h @@ -94,8 +94,8 @@ public: void Write(const Entry& entry) override; private: - Common::FS::IOFile file; - std::size_t bytes_written; + FS::IOFile file; + std::size_t bytes_written = 0; }; /** -- cgit v1.2.3