From ea8d5ef5e81861e013b5c58189faeffe7d3a6f18 Mon Sep 17 00:00:00 2001 From: Morph <39850852+Morph1984@users.noreply.github.com> Date: Fri, 30 Jun 2023 00:54:23 -0400 Subject: sink_stream: Resolve heap buffer corruption due to out of bounds write Also, remove the use of ScratchBuffer when upmixing, as other channels may not be initialized with zeroed out data. --- src/audio_core/sink/sink_stream.h | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/audio_core/sink/sink_stream.h') diff --git a/src/audio_core/sink/sink_stream.h b/src/audio_core/sink/sink_stream.h index 98d72ace1..6a4996ca3 100644 --- a/src/audio_core/sink/sink_stream.h +++ b/src/audio_core/sink/sink_stream.h @@ -16,7 +16,6 @@ #include "common/polyfill_thread.h" #include "common/reader_writer_queue.h" #include "common/ring_buffer.h" -#include "common/scratch_buffer.h" #include "common/thread.h" namespace Core { @@ -256,8 +255,6 @@ private: /// Signalled when ring buffer entries are consumed std::condition_variable_any release_cv; std::mutex release_mutex; - /// Temporary buffer for appending samples when upmixing - Common::ScratchBuffer tmp_samples{}; }; using SinkStreamPtr = std::unique_ptr; -- cgit v1.2.3