From d28b942458693b018cd8cab338537bdff5570118 Mon Sep 17 00:00:00 2001
From: Chloe Marcec <dmarcecguzman@gmail.com>
Date: Thu, 11 Feb 2021 19:17:50 +1100
Subject: address issues

---
 src/audio_core/delay_line.cpp | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

(limited to 'src/audio_core/delay_line.cpp')

diff --git a/src/audio_core/delay_line.cpp b/src/audio_core/delay_line.cpp
index c8bc6e23e..f4e4dd8d2 100644
--- a/src/audio_core/delay_line.cpp
+++ b/src/audio_core/delay_line.cpp
@@ -1,15 +1,16 @@
+#include <cstring>
 #include "audio_core/delay_line.h"
 
 namespace AudioCore {
 DelayLineBase::DelayLineBase() = default;
 DelayLineBase::~DelayLineBase() = default;
 
-void DelayLineBase::Initialize(s32 _max_delay, float* src_buffer) {
+void DelayLineBase::Initialize(s32 max_delay_, float* src_buffer) {
     buffer = src_buffer;
-    buffer_end = buffer + _max_delay;
-    max_delay = _max_delay;
+    buffer_end = buffer + max_delay_;
+    max_delay = max_delay_;
     output = buffer;
-    SetDelay(_max_delay);
+    SetDelay(max_delay_);
     Clear();
 }
 
@@ -30,7 +31,7 @@ s32 DelayLineBase::GetMaxDelay() const {
 }
 
 f32 DelayLineBase::TapOut(s32 last_sample) {
-    float* ptr = input - (last_sample + 1);
+    const float* ptr = input - (last_sample + 1);
     if (ptr < buffer) {
         ptr += (max_delay + 1);
     }
@@ -81,13 +82,13 @@ void DelayLineBase::Reset() {
 DelayLineAllPass::DelayLineAllPass() = default;
 DelayLineAllPass::~DelayLineAllPass() = default;
 
-void DelayLineAllPass::Initialize(u32 delay, float _coeffcient, f32* src_buffer) {
-    DelayLineBase::Initialize(delay, src_buffer);
-    SetCoefficient(_coeffcient);
+void DelayLineAllPass::Initialize(u32 delay_, float coeffcient_, f32* src_buffer) {
+    DelayLineBase::Initialize(delay_, src_buffer);
+    SetCoefficient(coeffcient_);
 }
 
-void DelayLineAllPass::SetCoefficient(float _coeffcient) {
-    coefficient = _coeffcient;
+void DelayLineAllPass::SetCoefficient(float coeffcient_) {
+    coefficient = coeffcient_;
 }
 
 f32 DelayLineAllPass::Tick(f32 sample) {
-- 
cgit v1.2.3