From 0298b7bedd17f88430486dd502fb7923b1d10f26 Mon Sep 17 00:00:00 2001 From: Benjamin Barenblat Date: Sun, 2 Aug 2015 18:30:24 -0400 Subject: Use UNREACHABLE macro for impossible cases in previous commit Use the UNREACHABLE macro instead of `ASSERT(false, ...);`. --- src/common/logging/backend.cpp | 3 +-- src/common/logging/text_formatter.cpp | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/common/logging/backend.cpp b/src/common/logging/backend.cpp index 68580e1c0..0a081e7d4 100644 --- a/src/common/logging/backend.cpp +++ b/src/common/logging/backend.cpp @@ -80,8 +80,7 @@ const char* GetLevelName(Level log_level) { LVL(Error); LVL(Critical); case Level::Count: - ASSERT_MSG(false, "invalid log level"); - return "Unknown"; + UNREACHABLE(); } #undef LVL } diff --git a/src/common/logging/text_formatter.cpp b/src/common/logging/text_formatter.cpp index e3bb148bb..de195b0f7 100644 --- a/src/common/logging/text_formatter.cpp +++ b/src/common/logging/text_formatter.cpp @@ -84,7 +84,7 @@ void PrintColoredMessage(const Entry& entry) { case Level::Critical: // Bright magenta color = FOREGROUND_RED | FOREGROUND_BLUE | FOREGROUND_INTENSITY; break; case Level::Count: - ASSERT_MSG(false, "invalid log level"); break; + UNREACHABLE(); } SetConsoleTextAttribute(console_handle, color); @@ -105,7 +105,7 @@ void PrintColoredMessage(const Entry& entry) { case Level::Critical: // Bright magenta color = ESC "[1;35m"; break; case Level::Count: - ASSERT_MSG(false, "invalid log level"); break; + UNREACHABLE(); } fputs(color, stderr); -- cgit v1.2.3