| Commit message (Collapse) | Author | Files | Lines |
|
Given it's intended to be an internal implementation class, we can move
it into the cpp file to ensure that.
This also lets us move some header dependencies into the cpp file as
well.
|
|
|
|
- Removes a dependency on core and input_common from common.
|
|
fmt now automatically prints the numeric value of an enum class member
by default, so we don't need to use casts any more.
Reduces the line noise a bit.
|
|
Resolves variable shadowing scenarios up to the end of the OpenGL code
to make it nicer to review. The rest will be resolved in a following
commit.
|
|
Allows some implementations to avoid completely zeroing out the internal
buffer of the optional, and instead only set the validity byte within
the structure.
This also makes it consistent how we return empty optionals.
|
|
I made a request on the Xbyak issue tracker to allow some constructors
to be constexpr in order to avoid static constructors from needing to
execute for some of our register constants.
This request was implemented, so this updates Xbyak so that we can make
use of it.
|
|
Add an extra step in GPU initialization to be able to initialize render
backends with a valid GPU instance.
|
|
This was assigning the field to itself, which is a no-op. The size
doesn't change between its initial assignment and this one, so this is a
safe change to make.
|
|
Silences several compiler warnings about unused variables.
|
|
These functions are already in an anonymous namespace which makes the
functions internally linked.
|
|
Given the expression involves a 32-bit value, this simplifies down to
just: 0x3ffffff. This is likely a remnant from testing that was never
cleaned up.
Resolves a -Wshift-overflow warning.
|
|
The purpose of make_pair is generally to deduce the types within the
pair without explicitly specifying the types, so these usages were
generally unnecessary, particularly when the type is enforced by the
array declaration.
|
|
Resolves a -Wdocumentation warning.
|
|
Macro code is just uploaded sequentially from a starting address, however that does not mean the entry point for the macro is at that address. This PR adds preliminary support for executing macros in the middle of our cached code.
|
|
|
|
We already draw, so we can clear it
|
|
|
|
|
|
|
|
shl/shr only accept cl as their second argument
|
|
Previously dst wasn't being used.
|
|
Previously dst wasn't being used.
|
|
Removes a completely unused label and marks another variable as unused,
given it seems like it has potential uses in the future.
|
|
We can reduce the capture scope so that it's not possible for both "reg"
variables to clash with one another.
While we're at it, we can prevent unnecessary copies while we're at it.
|
|
|
|
|
|
|
|
The code generated for these ALU ops assume src_a and src_b are always valid.
|
|
Not required, as PARAMETERS can just be incremented directly.
|
|
|
|
All registers are now callee-save registers.
RBX and RBP selected for STATE and RESULT because these are most commonly accessed; this is to avoid the REX prefix.
RBP not used for STATE because there are some SIB restrictions, RBX emits smaller code.
|
|
Unnecessary since this is just an offset from STATE.
|
|
This can be passed in as an argument instead.
|
|
Unnecessary variable.
|
|
This Reg64 codepath has the exact same behaviour as the Reg32 one.
|
|
|
|
Fix build time issues on gcc. Confirmed through asan that avoiding this
initialization is safe.
|
|
|
|
|
|
|
|
Easier to read and will emit a jump table automatically.
|
|
|