summaryrefslogtreecommitdiffstats
path: root/src/video_core/command_classes (follow)
Commit message (Collapse)AuthorAgeFilesLines
* nvdec: Implement VA-API hardware video acceleration (#6713)yzct123452021-08-044-72/+170
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * nvdec: VA-API * Verify formatting * Forgot a semicolon for Windows * Clarify comment about AV_PIX_FMT_NV12 * Fix assert log spam from missing negation * vic: Remove forgotten debug code * Address lioncash's review * Mention VA-API is Intel/AMD * Address v1993's review * Hopefully fix CMakeLists style this time * vic: Improve cache locality * vic: Fix off-by-one error * codec: Async * codec: Forgot the GetValue() * nvdec: Address ameerj's review * codec: Fallback to CPU without VA-API support * cmake: Address lat9nq's review * cmake: Make VA-API optional * vaapi: Multiple GPU * Apply suggestions from code review Co-authored-by: Ameer J <52414509+ameerj@users.noreply.github.com> * nvdec: Address ameerj's review * codec: Use anonymous instead of static * nvdec: Remove enum and fix memory leak * nvdec: Address ameerj's review * codec: Remove preparation for threading Co-authored-by: Ameer J <52414509+ameerj@users.noreply.github.com>
* Merge pull request #6525 from ameerj/nvdec-fixesFernando S2021-07-151-11/+10
|\ | | | | nvdec: Fix Submit Ioctl data source, vic frame dimension computations
| * vic: Fix dimension compuation of YUV framesameerj2021-07-151-11/+10
| | | | | | | | Fixes out of bound memory crashes in Mario Golf
* | Merge pull request #6537 from Morph1984/warningsbunnei2021-07-062-15/+0
|\ \ | | | | | | general: Enforce multiple warnings in MSVC
| * | video_core: Remove #pragma warning directives for external headersMorph2021-06-282-15/+0
| | |
* | | Slightly refactor NVDEC and codecs for readability and safetyKelebek12021-07-019-354/+521
|/ /
* / codec,vic: Disable warnings in ffmpeg headersReinUsesLisp2021-06-262-4/+29
|/
* vp9: Avoid memcpy with null pointerslat9nq2021-04-051-7/+9
| | | | | | | | Avoid sending null pointer to memcpy as reported by Undefined Behaviour Sanitizer. Replaces the std::memcpy calls in SpliceVectors with std::copy calls. Opting to replace all the memcpy's with copy's. Co-authored-by: LC <mathew1800@gmail.com>
* rebase, fix name shadowing, more constameerj2021-02-131-5/+5
|
* streamline cdma_pusher/command_classesameerj2021-02-131-13/+5
|
* streamline cdma_pusher/command_classesameerj2021-02-133-48/+6
|
* nvdec cleanupameerj2021-02-133-11/+24
|
* video_core: Reimplement the buffer cacheReinUsesLisp2021-02-131-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Reimplement the buffer cache using cached bindings and page level granularity for modification tracking. This also drops the usage of shared pointers and virtual functions from the cache. - Bindings are cached, allowing to skip work when the game changes few bits between draws. - OpenGL Assembly shaders no longer copy when a region has been modified from the GPU to emulate constant buffers, instead GL_EXT_memory_object is used to alias sub-buffers within the same allocation. - OpenGL Assembly shaders stream constant buffer data using glProgramBufferParametersIuivNV, from NV_parameter_buffer_object. In theory this should save one hash table resolve inside the driver compared to glBufferSubData. - A new OpenGL stream buffer is implemented based on fences for drivers that are not Nvidia's proprietary, due to their low performance on partial glBufferSubData calls synchronized with 3D rendering (that some games use a lot). - Most optimizations are shared between APIs now, allowing Vulkan to cache more bindings than before, skipping unnecesarry work. This commit adds the necessary infrastructure to use Vulkan object from OpenGL. Overall, it improves performance and fixes some bugs present on the old cache. There are still some edge cases hit by some games that harm performance on some vendors, this are planned to be fixed in later commits.
* common/bit_util: Replace CLZ/CTZ operations with standardized onesLioncash2021-01-151-2/+2
| | | | Makes for less code that we need to maintain.
* remove inaccurate referenceAmeer J2021-01-071-1/+1
| | | Co-authored-by: LC <mathew1800@gmail.com>
* fix for nvdec disabled, cleanup host1xameerj2021-01-072-61/+9
|
* nvdec syncpt incorporationameerj2021-01-072-3/+5
| | | | laying the groundwork for async gpu, although this does not fully implement async nvdec operations
* general: Fix various spelling errorsMorph2021-01-021-1/+1
|
* video_core: Rewrite the texture cacheReinUsesLisp2020-12-301-4/+4
| | | | | | | | | | | | | | The current texture cache has several points that hurt maintainability and performance. It's easy to break unrelated parts of the cache when doing minor changes. The cache can easily forget valuable information about the cached textures by CPU writes or simply by its normal usage.The current texture cache has several points that hurt maintainability and performance. It's easy to break unrelated parts of the cache when doing minor changes. The cache can easily forget valuable information about the cached textures by CPU writes or simply by its normal usage. This commit aims to address those issues.
* video_core: Remove unnecessary enum class casting in logging messagesLioncash2020-12-072-3/+3
| | | | | | | fmt now automatically prints the numeric value of an enum class member by default, so we don't need to use casts any more. Reduces the line noise a bit.
* video_core: Resolve more variable shadowing scenarios pt.2Lioncash2020-12-051-20/+20
| | | | | | | Migrates the video core code closer to enabling variable shadowing warnings as errors. This primarily sorts out shadowing occurrences within the Vulkan code.
* Merge pull request #5124 from lioncash/video-shadowbunnei2020-12-052-2/+2
|\ | | | | video_core: Resolve more variable shadowing scenarios
| * video_core: Resolve more variable shadowing scenariosLioncash2020-12-042-2/+2
| | | | | | | | | | | | Resolves variable shadowing scenarios up to the end of the OpenGL code to make it nicer to review. The rest will be resolved in a following commit.
* | codec: Remove deprecated usage of AVCodecContext::refcounted_framesLioncash2020-12-041-1/+0
|/ | | | | | | | | | | | | | | | This was only necessary for use with the avcodec_decode_video2/avcoded_decode_audio4 APIs which are also deprecated. Given we use avcodec_send_packet/avcodec_receive_frame, this isn't necessary, this is even indicated directly within the FFmpeg API changes document here on 2017-09-26: https://github.com/FFmpeg/FFmpeg/blob/master/doc/APIchanges#L410 This prevents our code from breaking whenever we update to a newer version of FFmpeg in the future if they ever decide to fully remove this API member.
* vp9/vic: Resolve pessimizing movesLioncash2020-12-032-11/+11
| | | | | Removes the usage of moves that don't result in behavior different from a copy, or otherwise would prevent copy elision from occurring.
* Merge pull request #5002 from ameerj/nvdec-frameskipbunnei2020-12-0310-340/+234
|\ | | | | nvdec: Queue and display all decoded frames, cleanup decoders
| * Limit queue size to 10 framesameerj2020-11-261-0/+4
| | | | | | | | Workaround for ZLA, which seems to decode and queue twice as many frames as it displays.
| * Address PR feedbackameerj2020-11-264-32/+33
| | | | | | | | | | | | remove some redundant moves, make deleter match naming guidelines. Co-Authored-By: LC <712067+lioncash@users.noreply.github.com>
| * Queue decoded frames, cleanup decodersameerj2020-11-2510-338/+227
| |
* | codec: Fix `pragma GCC diagnostic pop` missing corresponding pushcomex2020-11-261-0/+1
|/
* nvdec: Make use of [[nodiscard]] where applicableLioncash2020-11-027-16/+16
| | | | | Prevents bugs from occurring where the results of a function are accidentally discarded
* vp9: Be explicit with copy and move operatorsLioncash2020-10-301-0/+18
| | | | | | It's deprecated in the language to autogenerate these if the destructor for a type is specified, so we can explicitly specify how we want these to be generated.
* vp9: Mark functions with [[nodiscard]] where applicableLioncash2020-10-302-13/+13
| | | | | Prevents values from mistakenly being discarded in cases where it's a bug to do so.
* vp9: Provide a default initializer for "hidden" memberLioncash2020-10-301-1/+1
| | | | | | | | | The API of VP9 exposes a WasFrameHidden() function which accesses this member. Given the constructor previously didn't initialize this member, it's a potential vector for an uninitialized read. Instead, we can initialize this to a deterministic value to prevent that from occurring.
* vp9: Make some member functions internally linkedLioncash2020-10-302-58/+54
| | | | | These helper functions don't directly modify any member state and can be hidden from view.
* Merge pull request #4837 from lioncash/nvdec-2bunnei2020-10-2913-88/+81
|\ | | | | nvdec: Minor tidying up
| * h264: Make WriteUe take a u32Lioncash2020-10-272-7/+8
| | | | | | | | Enforces the type of the desired value in calling code.
| * vp9: std::move buffer within ComposeFrameHeader()Lioncash2020-10-271-1/+1
| | | | | | | | We can move the buffer here to avoid a heap reallocation
| * vp9: Remove dead codeLioncash2020-10-271-6/+0
| |
| * vp9: Join declarations with assignmentsLioncash2020-10-271-7/+8
| |
| * vp9: Remove pessimizing movesLioncash2020-10-271-2/+2
| | | | | | | | The move will already occur without std::move.
| * vp9: Resolve variable shadowingLioncash2020-10-271-4/+4
| |
| * nvdec: Tidy up header includesLioncash2020-10-2713-62/+59
| | | | | | | | Prevents a few unnecessary inclusions.
* | Merge pull request #4838 from lioncash/syncmgrbunnei2020-10-292-9/+9
|\ \ | | | | | | sync_manager: Amend parameter order of calls to SyncptIncr constructor
| * | sync_manager: Amend parameter order of calls to SyncptIncr constructorLioncash2020-10-272-9/+9
| |/ | | | | | | Corrects some cases where the arguments would be incorrectly swapped.
* | Merge pull request #4848 from ReinUsesLisp/type-limitsLC2020-10-281-1/+1
|\ \ | | | | | | video_core: Enforce -Werror=type-limits
| * | video_core: Enforce -Werror=type-limitsReinUsesLisp2020-10-281-1/+1
| |/ | | | | | | Silences one warning and avoids introducing more in the future.
* / video_core: Enforce -Wredundant-move and -Wpessimizing-moveReinUsesLisp2020-10-281-1/+1
|/ | | | Silence three warnings and make them errors to avoid introducing more in the future.
* video_core: NVDEC Implementationameerj2020-10-2716-0/+2857
This commit aims to implement the NVDEC (Nvidia Decoder) functionality, with video frame decoding being handled by the FFmpeg library. The process begins with Ioctl commands being sent to the NVDEC and VIC (Video Image Composer) emulated devices. These allocate the necessary GPU buffers for the frame data, along with providing information on the incoming video data. A Submit command then signals the GPU to process and decode the frame data. To decode the frame, the respective codec's header must be manually composed from the information provided by NVDEC, then sent with the raw frame data to the ffmpeg library. Currently, H264 and VP9 are supported, with VP9 having some minor artifacting issues related mainly to the reference frame composition in its uncompressed header. Async GPU is not properly implemented at the moment. Co-Authored-By: David <25727384+ogniK5377@users.noreply.github.com>