summaryrefslogtreecommitdiffstats
path: root/src/input_common/sdl/sdl_impl.cpp (follow)
Commit message (Collapse)AuthorAgeFilesLines
* input_common/sdl/sdl_impl: Correct logging string in SDLState constructorLioncash2019-06-031-1/+1
| | | | | | If this path was ever taken, a runtime exception would occur due to the lack of a formatting specifier to insert the error code into the format string.
* input_common/sdl/sdl_impl: Move documentation comments to header where applicableLioncash2019-06-031-7/+0
| | | | | Places the documentation comments with the rest of SDLState's member function documentation.
* input_common/sdl/sdl_impl: Amend names for axes for SDLAnalogPollerLioncash2019-06-031-13/+13
| | | | Adds another underscore to clearly indicate the axis names.
* input_common/sdl/sdl_impl: Mark variables const where applicableLioncash2019-06-031-10/+11
| | | | | Make it explicit that these aren't modified elsewhere (either through functions by reference, or by other operations).
* input_common/sdl/sdl_impl: Mark SDLEventToButtonParamPackage() as staticLioncash2019-06-031-1/+1
| | | | | | Its prototype declared at the top of the translation unit contains the static qualifier, so the function itself should also contain it to make it a proper internally linked function.
* input_common/sdl/sdl_impl: Convert reinterpret_cast into a static_castLioncash2019-06-031-2/+4
| | | | It's valid to static_cast a void pointer back into its proper type.
* input_common/sdl/sdl_impl: Use insert_or_assign() where applicableLioncash2019-06-031-3/+3
| | | | | Same behavior, but without a potential need to unnecessarily default construct a value.
* input_common/sdl/sdl_impl: Simplify SDL_Joystick deleter handlingLioncash2019-06-031-15/+14
| | | | | | | | | The deleter can just be set in the constructor and maintained throughout the lifetime of the object. If a contained pointer is null, then the deleter won't execute, so this is safe to do. We don't need to swap it out with a version of a deleter that does nothing.
* input_common/sdl/sdl_impl: Resolve two sign conversion warningsLioncash2019-06-031-10/+16
| | | | Silences the final two warnings in SDL code.
* input_common/sdl: Remove unused header includes and forward declarationsLioncash2019-06-031-2/+0
| | | | | Gets rid of a few unnecessary inclusion dependencies. It also uncovered a few indirect inclusion dependencies being relied upon.
* input_common/sdl/sdl_impl: Use nested namespace specifiers where applicableLioncash2019-06-031-5/+2
|
* input_common/sdl/sdl_impl: Silence sign conversion warningsLioncash2019-05-311-3/+3
| | | | Makes the conversions explicit, as opposed to implicit.
* general: Use deducation guides for std::lock_guard and std::unique_lockLioncash2019-04-011-12/+14
| | | | | | | Since C++17, the introduction of deduction guides for locking facilities means that we no longer need to hardcode the mutex type into the locks themselves, making it easier to switch mutex types, should it ever be necessary in the future.
* input_common/sdl: Correct return values within implementations of GetPollers()Lioncash2019-03-181-1/+3
| | | | | In both cases, we weren't actually returning anything, which is undefined behavior.
* input_common/sdl: Use a type alias to shorten declaration of GetPollersLioncash2019-03-181-3/+2
| | | | Just makes the definitions a little bit more tidy.
* input_common/sdl_impl: Make lambda capture more specific in SDLState constructorLioncash2019-03-171-1/+1
| | | | | We don't need to universally capture by reference. We specifically just need to capture the this pointer.
* input_common/sdl_impl: Remove unnecessary std::chrono::duration constructionLioncash2019-03-171-1/+1
| | | | Specifying the time unit itself is sufficient here.
* input_common/sdl_impl: Remove unused variable in SDLState constructorLioncash2019-03-171-1/+0
|
* fixup! Joystick: Allow for background events; Add deadzone to SDLAnalogB3n302019-03-021-6/+17
|
* input/sdl: lock map mutex after SDL callWeiyi Wang2019-03-021-11/+17
| | | | Any SDL invocation can call the even callback on the same thread, which can call GetSDLJoystickBySDLID and eventually cause double lock on joystick_map_mutex. To avoid this, lock guard should be placed as closer as possible to the object accessing code, so that any SDL invocation is with the mutex unlocked
* Input: Remove global variables from SDL InputJames Rowe2019-03-021-85/+108
| | | | | | | | | Changes the interface as well to remove any unique methods that frontends needed to call such as StartJoystickEventHandler by conditionally starting the polling thread only if the frontend hasn't started it already. Additionally, moves all global state into a single SDLState class in order to guarantee that the destructors are called in the proper order
* Input: Copy current SDL.h/cpp files to implJames Rowe2019-03-021-0/+629
This should make reviewing much easier as you can then see what changed happened between the old file and the new one