| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
| |
Using this smaller type saves 512 bytes in the compiled executable.
|
| |
|
|
|
| |
This formats all copyright comments according to SPDX formatting guidelines.
Additionally, this resolves the remaining GPLv2 only licensed files by relicensing them to GPLv2.0-or-later.
|
| |
|
|
| |
This completes the removal of the old UUID implementation.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Alleviates the dependency on chrono for all files that include settings.h
|
| | |
|
| |\
| |
| | |
common/logging: Reduce dependent header include overhead
|
| | | |
|
| |/
|
|
| |
The service context helps to manage all created events and allows us to close them upon destruction.
|
| | |
|
| | |
|
| |
|
|
| |
The timezone info file can be within subdirectories (such as Asia/Tokyo), use GetFileRelative instead of GetFile to get files within subdirectories.
|
| |
|
|
| |
Transition to PascalCase for result names.
|
| |
|
|
|
|
| |
Now that we have most of core free of shadowing, we can enable the
warning as an error to catch anything that may be remaining and also
eliminate this class of logic bug entirely.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
Now all that remains is for kernel code to be 'shadow-free' and then
-Wshadow can be turned into an error.
|
| |
|
|
|
| |
Resolves a few localized instances of member variable shadowing. Brings
us a little closer to turning shadowing warnings into errors.
|
| |\
| |
| | |
time: Fix GetClockSnapshotFromSystemClockContext
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
This removes an incorrect alignment usage and corrects the positions of the popped parameters.
- Fixes Super Kirby Clash crashing on boot
|
| |/
|
|
| |
For consistency with the rest of the service implementations
|
| |
|
|
| |
- Removes a dependency on core and input_common from common.
|
| |\
| |
| | |
service: time: Setup the network clock with the local clock context
|
| | |
| |
| |
| | |
Setting the network time allows some time based events using the network clock to not reset.
|
| |\ \
| | |
| | | |
service: time: Fix CalculateStandardUserSystemClockDifferenceByUser
|
| | |/
| |
| |
| | |
CalculateStandardUserSystemClockDifferenceByUser passes in the ClockSnapshots through 2 input buffers and not as raw arguments. Fix this by reading the 2 input buffers instead of popping raw arguments.
|
| |/ |
|
| |\
| |
| | |
time: Assign the current time point to the ClockSnapshot
|
| | |
| |
| |
| | |
Fixes the timer in Super Smash Bros Ultimate's Spirit Board.
|
| |/
|
|
|
|
| |
CalculateSpanBetween passes in the ClockSnapshots through 2 input buffers and not as raw arguments. Fix this by reading the 2 input buffers instead of popping raw arguments.
Partially fixes Super Smash Bros. Ultimate's Spirit Board
|
| |\
| |
| | |
Kernel Rework: Memory updates and refactoring (Part 1)
|
| | | |
|
| |/
|
|
|
| |
After rewriting the resource limit, objects releasing reserved resources require a live kernel instance.
This commit fixes exceptions that occur due to the kernel being destroyed before some objects released their resources, allowing for a graceful exit.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
This requires making several types trivial and properly initialize
them whenever they are called.
|
| | |
|
| |
|
|
|
| |
Completely removes all usages of the global system instance within the
services code by passing in the using system instance to the services.
|
| | |
|
| |\
| |
| | |
service: time: Update current time with changes to RTC setting.
|
| | |
| |
| |
| | |
- This can be used to advance time, e.g. for Pokemon Sword/Shield pokejobs.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.
Fixes #4795
|
| |/
|
|
|
|
|
|
|
| |
Makes our error coverage a little more consistent across the board by
applying it to Linux side of things as well. This also makes it more
consistent with the warning settings in other libraries in the project.
This also updates httplib to 0.7.9, as there are several warning
cleanups made that allow us to enable several warnings as errors.
|
| |
|
|
| |
Prevents a useless self-assignment from occurring.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
* ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer
With the support of C++20, we can use concepts to deduce if a type is an STL container or not.
* More agressive concept for stl containers
* Add -fconcepts
* Move to common namespace
* Add Common::IsBaseOf
|
| |\
| |
| | |
service: Update function tables
|
| | | |
|
| |/
|
|
|
|
|
| |
This commit: Implements CPU Interrupts, Replaces Cycle Timing for Host
Timing, Reworks the Kernel's Scheduler, Introduce Idle State and
Suspended State, Recreates the bootmanager, Initializes Multicore
system.
|
| | |
|
| | |
|
| |\
| |
| | |
service/time: Remove reliance on the global system accessor
|
| | |
| |
| |
| |
| | |
Eliminates usages of the global system accessor and instead passes the
existing system instance into the interfaces.
|
| |\ \
| |/
|/| |
General: Resolve minor assorted warnings
|
| | |
| |
| |
| |
| | |
ttis and ats will never exceed the length of INT32_MAX in our case, so
this is safe.
|
| | |
| |
| |
| | |
This is already initialized within the class body.
|
| | |
| |
| |
| | |
This doesn't modify internal member state.
|
| | |
| |
| |
| |
| |
| | |
Many of these implementations are used to implement a polymorphic
interface. While not directly used polymorphically, this prevents
virtual destruction from ever becoming an issue.
|
| |/ |
|
| |\
| |
| | |
CMakeLists: Specify -Wextra on linux builds
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Allows reporting more cases where logic errors may exist, such as
implicit fallthrough cases, etc.
We currently ignore unused parameters, since we currently have many
cases where this is intentional (virtual interfaces).
While we're at it, we can also tidy up any existing code that causes
warnings. This also uncovered a few bugs as well.
|
| |/
|
|
| |
- Used by Animal Crossing: New Horizons.
|
| |
|
|
| |
- Used by Super Smash Bros. Ultimate.
|
| |
|
|
|
|
|
| |
There were cases where raw_data didn't contain enough
space to hold the zero terminator.
This was caught with -fsanitize=address.
|
| | |
|
| |
|
|
| |
- Used by Pokemon Mystery Dungeon.
|
| |
|
|
| |
- Fixes timestamp in ZLA and Astral Chain saves.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
service: Update function tables
|
| | |
| |
| |
| |
| |
| | |
Keeps the function tables up to date.
Updated based off information from Switchbrew.
|
| | |
| |
| |
| |
| |
| | |
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects.
- See https://github.com/citra-emu/citra/pull/4710 for details.
|
| |/
|
|
|
| |
These are fairly trivial to resolve and most of the changes entail
using RESULT_UNKNOWN over ResultCode(-1).
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This PR attempts to implement the shared memory provided by GetSharedMemoryNativeHandle. There is still more work to be done however that requires a rehaul of the current time module to handle clock contexts. This PR is mainly to get the basic functionality of the SharedMemory working and allow the use of addition to it whilst things get improved on.
Things to note:
Memory Barriers are used in the SharedMemory and a better solution would need to be done to implement this. Currently in this PR I’m faking the memory barriers as everything is sync and single threaded. They work by incrementing the counter and just populate the two data slots. On data reading, it will read the last added data.
Specific values in the shared memory would need to be updated periodically. This isn't included in this PR since we don't actively do this yet. In a later PR when time is refactored this should be done.
Finally, as we don't handle clock contexts. When time is refactored, we will need to update the shared memory for specific contexts. This PR does this already however since the contexts are all identical and not separated. We're just updating the same values for each context which in this case is empty.
Tiime:SetStandardUserSystemClockAutomaticCorrectionEnabled, Time:IsStandardUserSystemClockAutomaticCorrectionEnabled are also partially implemented in this PR. The reason the implementation is partial is because once again, a lack of clock contexts. This will be improved on in a future PR.
This PR closes issue #2556
|
| |
|
|
|
| |
Makes the casing consistent with all of our general function naming
conventions.
|
| |
|
|
|
| |
Makes the interface more type-safe and consistent in terms of return
values.
|
| |
|
|
| |
Updates function tables based off information from SwitchBrew.
|
| |
|
|
|
|
|
|
|
|
|
| |
Gets rid of the largest set of mutable global state within the core.
This also paves a way for eliminating usages of GetInstance() on the
System class as a follow-up.
Note that no behavioral changes have been made, and this simply extracts
the functionality into a class. This also has the benefit of making
dependencies on the core timing functionality explicit within the
relevant interfaces.
|
| |
|
|
|
|
| |
Places all of the timing-related functionality under the existing Core
namespace to keep things consistent, rather than having the timing
utilities sitting in its own completely separate namespace.
|
| | |
|
| | |
|
| |
|
|
| |
Moves some variables closer to their actual usage sites.
|
| | |
|
| | |
|
| |
|
|
| |
Seems pokemon calls this sometimes and it caused "random crashes"
|
| | |
|
| |
|
|
| |
Added instead of using a seperate PR to prevent conflicts
|
| | |
|
| |
|
|
| |
Needed by megaman 11
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a destructor isn't defaulted into a cpp file, it can cause the use
of forward declarations to seemingly fail to compile for non-obvious
reasons. It also allows inlining of the construction/destruction logic
all over the place where a constructor or destructor is invoked, which
can lead to code bloat. This isn't so much a worry here, given the
services won't be created and destroyed frequently.
The cause of the above mentioned non-obvious errors can be demonstrated
as follows:
------- Demonstrative example, if you know how the described error happens, skip forwards -------
Assume we have the following in the header, which we'll call "thing.h":
\#include <memory>
// Forward declaration. For example purposes, assume the definition
// of Object is in some header named "object.h"
class Object;
class Thing {
public:
// assume no constructors or destructors are specified here,
// or the constructors/destructors are defined as:
//
// Thing() = default;
// ~Thing() = default;
//
// ... Some interface member functions would be defined here
private:
std::shared_ptr<Object> obj;
};
If this header is included in a cpp file, (which we'll call "main.cpp"),
this will result in a compilation error, because even though no
destructor is specified, the destructor will still need to be generated by
the compiler because std::shared_ptr's destructor is *not* trivial (in
other words, it does something other than nothing), as std::shared_ptr's
destructor needs to do two things:
1. Decrement the shared reference count of the object being pointed to,
and if the reference count decrements to zero,
2. Free the Object instance's memory (aka deallocate the memory it's
pointing to).
And so the compiler generates the code for the destructor doing this inside main.cpp.
Now, keep in mind, the Object forward declaration is not a complete type. All it
does is tell the compiler "a type named Object exists" and allows us to
use the name in certain situations to avoid a header dependency. So the
compiler needs to generate destruction code for Object, but the compiler
doesn't know *how* to destruct it. A forward declaration doesn't tell
the compiler anything about Object's constructor or destructor. So, the
compiler will issue an error in this case because it's undefined
behavior to try and deallocate (or construct) an incomplete type and
std::shared_ptr and std::unique_ptr make sure this isn't the case
internally.
Now, if we had defaulted the destructor in "thing.cpp", where we also
include "object.h", this would never be an issue, as the destructor
would only have its code generated in one place, and it would be in a
place where the full class definition of Object would be visible to the
compiler.
---------------------- End example ----------------------------
Given these service classes are more than certainly going to change in
the future, this defaults the constructors and destructors into the
relevant cpp files to make the construction and destruction of all of
the services consistent and unlikely to run into cases where forward
declarations are indirectly causing compilation errors. It also has the
plus of avoiding the need to rebuild several services if destruction
logic changes, since it would only be necessary to recompile the single
cpp file.
|
| |
|
|
| |
Updates the ID of these based off the information on Switch Brew.
|
| |\
| |
| | |
time: Add the time:a service
|
| | |
| |
| |
| | |
Given we already have time:s and time:u, we should also have time:a
|
| | |
| |
| |
| | |
We can use one instance of the interface instead of duplicating code.
|
| |/ |
|
| |
|
|
|
| |
Prevents implicit construction and makes these lingering non-explicit
constructors consistent with the rest of the other classes in services.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This makes the formatting expectations more obvious (e.g. any zero padding specified
is padding that's entirely dedicated to the value being printed, not any pretty-printing
that also gets tacked on).
|
| |
|
|
| |
All of these variables and functions are related to timings and should be within the namespace.
|
| | |
|
| |
|
|
| |
Tidies up namespace declarations
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Updated ACC with more service names
* Updated SVC with more service names
* Updated set with more service names
* Updated sockets with more service names
* Updated SPL with more service names
* Updated time with more service names
* Updated vi with more service names
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
time: Stub out GetTotalLocationNameCount and some cleanup.
|
| | | |
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| |
|
