summaryrefslogtreecommitdiffstats
path: root/src/core/hle/service/sockets (follow)
Commit message (Collapse)AuthorAgeFilesLines
* sfdnsres: ensure lp1 is not resolvedLiam2023-08-282-2/+21
|
* sockets: avoid locking around socket session callsLiam2023-08-202-0/+8
|
* Improve behavior when sending to closed connectioncomex2023-08-162-0/+6
| | | | | | | | | | | - On Unix, this would previously kill the Yuzu process with SIGPIPE. Send MSG_NOSIGNAL to opt out of this. - Add support for the proper error code in this situation, EPIPE. - Windows has nonstandard behavior in this situation; translate it to the standard behavior. Kind of pointless, but isn't it nice to be correct?
* ssl: remove ResultVal useLiam2023-08-081-6/+3
|
* core: implement GetGaiStringErrorRequest, IContextRegistrarLiam2023-07-237-3/+68
|
* nsd: add GetApplicationServerEnvironmentTypeLiam2023-07-182-1/+17
|
* Updates:comex2023-07-022-22/+74
| | | | | - Address PR feedback. - Add SecureTransport backend for macOS.
* PR feedback + constificationcomex2023-06-263-18/+18
|
* Fix more Windows build errorscomex2023-06-261-2/+2
| | | | | I did test this beforehand, but not on MinGW, and the error that showed up on the msvc builder didn't happen for me...
* Fixes:comex2023-06-261-1/+1
| | | | | | | | | | | | | | | | - Add missing virtual destructor on `SSLBackend`. - On Windows, filter out `POLLWRBAND` (one of the new flags added) when calling `WSAPoll`, because despite the constant being defined on Windows, passing it calls `WSAPoll` to yield `EINVAL`. - Reduce OpenSSL version requirement to satisfy CI; I haven't tested whether it actually builds (or runs) against 1.1.1, but if not, I'll figure it out. - Change an instance of memcpy to memmove, even though the arguments cannot overlap, to avoid a [strange GCC error](https://github.com/yuzu-emu/yuzu/pull/10912#issuecomment-1606283351).
* Implement SSL servicecomex2023-06-259-186/+508
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This implements some missing network APIs including a large chunk of the SSL service, enough for Mario Maker (with an appropriate mod applied) to connect to the fan server [Open Course World](https://opencourse.world/). Connecting to first-party servers is out of scope of this PR and is a minefield I'd rather not step into. ## TLS TLS is implemented with multiple backends depending on the system's 'native' TLS library. Currently there are two backends: Schannel for Windows, and OpenSSL for Linux. (In reality Linux is a bit of a free-for-all where there's no one 'native' library, but OpenSSL is the closest it gets.) On macOS the 'native' library is SecureTransport but that isn't implemented in this PR. (Instead, all non-Windows OSes will use OpenSSL unless disabled with `-DENABLE_OPENSSL=OFF`.) Why have multiple backends instead of just using a single library, especially given that Yuzu already embeds mbedtls for cryptographic algorithms? Well, I tried implementing this on mbedtls first, but the problem is TLS policies - mainly trusted certificate policies, and to a lesser extent trusted algorithms, SSL versions, etc. ...In practice, the chance that someone is going to conduct a man-in-the-middle attack on a third-party game server is pretty low, but I'm a security nerd so I like to do the right security things. My base assumption is that we want to use the host system's TLS policies. An alternative would be to more closely emulate the Switch's TLS implementation (which is based on NSS). But for one thing, I don't feel like reverse engineering it. And I'd argue that for third-party servers such as Open Course World, it's theoretically preferable to use the system's policies rather than the Switch's, for two reasons 1. Someday the Switch will stop being updated, and the trusted cert list, algorithms, etc. will start to go stale, but users will still want to connect to third-party servers, and there's no reason they shouldn't have up-to-date security when doing so. At that point, homebrew users on actual hardware may patch the TLS implementation, but for emulators it's simpler to just use the host's stack. 2. Also, it's good to respect any custom certificate policies the user may have added systemwide. For example, they may have added custom trusted CAs in order to use TLS debugging tools or pass through corporate MitM middleboxes. Or they may have removed some CAs that are normally trusted out of paranoia. Note that this policy wouldn't work as-is for connecting to first-party servers, because some of them serve certificates based on Nintendo's own CA rather than a publicly trusted one. However, this could probably be solved easily by using appropriate APIs to adding Nintendo's CA as an alternate trusted cert for Yuzu's connections. That is not implemented in this PR because, again, first-party servers are out of scope. (If anything I'd rather have an option to _block_ connections to Nintendo servers, but that's not implemented here.) To use the host's TLS policies, there are three theoretical options: a) Import the host's trusted certificate list into a cross-platform TLS library (presumably mbedtls). b) Use the native TLS library to verify certificates but use a cross-platform TLS library for everything else. c) Use the native TLS library for everything. Two problems with option a). First, importing the trusted certificate list at minimum requires a bunch of platform-specific code, which mbedtls does not have built in. Interestingly, OpenSSL recently gained the ability to import the Windows certificate trust store... but that leads to the second problem, which is that a list of trusted certificates is [not expressive enough](https://bugs.archlinux.org/task/41909) to express a modern certificate trust policy. For example, Windows has the concept of [explicitly distrusted certificates](https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2012-r2-and-2012/dn265983(v=ws.11)), and macOS requires Certificate Transparency validation for some certificates with complex rules for when it's required. Option b) (using native library just to verify certs) is probably feasible, but it would miss aspects of TLS policy other than trusted certs (like allowed algorithms), and in any case it might well require writing more code, not less, compared to using the native library for everything. So I ended up at option c), using the native library for everything. What I'd *really* prefer would be to use a third-party library that does option c) for me. Rust has a good library for this, [native-tls](https://docs.rs/native-tls/latest/native_tls/). I did search, but I couldn't find a good option in the C or C++ ecosystem, at least not any that wasn't part of some much larger framework. I was surprised - isn't this a pretty common use case? Well, many applications only need TLS for HTTPS, and they can use libcurl, which has a TLS abstraction layer internally but doesn't expose it. Other applications only support a single TLS library, or use one of the aforementioned larger frameworks, or are platform-specific to begin with, or of course are written in a non-C/C++ language, most of which have some canonical choice for TLS. But there are also many applications that have a set of TLS backends just like this; it's just that nobody has gone ahead and abstracted the pattern into a library, at least not a widespread one. Amusingly, there is one TLS abstraction layer that Yuzu already bundles: the one in ffmpeg. But it is missing some features that would be needed to use it here (like reusing an existing socket rather than managing the socket itself). Though, that does mean that the wiki's build instructions for Linux (and macOS for some reason?) already recommend installing OpenSSL, so no need to update those. ## Other APIs implemented - Sockets: - GetSockOpt(`SO_ERROR`) - SetSockOpt(`SO_NOSIGPIPE`) (stub, I have no idea what this does on Switch) - `DuplicateSocket` (because the SSL sysmodule calls it internally) - More `PollEvents` values - NSD: - `Resolve` and `ResolveEx` (stub, good enough for Open Course World and probably most third-party servers, but not first-party) - SFDNSRES: - `GetHostByNameRequest` and `GetHostByNameRequestWithOptions` - `ResolverSetOptionRequest` (stub) ## Fixes - Parts of the socket code were previously allocating a `sockaddr` object on the stack when calling functions that take a `sockaddr*` (e.g. `accept`). This might seem like the right thing to do to avoid illegal aliasing, but in fact `sockaddr` is not guaranteed to be large enough to hold any particular type of address, only the header. This worked in practice because in practice `sockaddr` is the same size as `sockaddr_in`, but it's not how the API is meant to be used. I changed this to allocate an `sockaddr_in` on the stack and `reinterpret_cast` it. I could try to do something cleverer with `aligned_storage`, but casting is the idiomatic way to use these particular APIs, so it's really the system's responsibility to avoid any aliasing issues. - I rewrote most of the `GetAddrInfoRequest[WithOptions]` implementation. The old implementation invoked the host's getaddrinfo directly from sfdnsres.cpp, and directly passed through the host's socket type, protocol, etc. values rather than looking up the corresponding constants on the Switch. To be fair, these constants don't tend to actually vary across systems, but still... I added a wrapper for `getaddrinfo` in `internal_network/network.cpp` similar to the ones for other socket APIs, and changed the `GetAddrInfoRequest` implementation to use it. While I was at it, I rewrote the serialization to use the same approach I used to implement `GetHostByNameRequest`, because it reduces the number of size calculations. While doing so I removed `AF_INET6` support because the Switch doesn't support IPv6; it might be nice to support IPv6 anyway, but that would have to apply to all of the socket APIs. I also corrected the IPC wrappers for `GetAddrInfoRequest` and `GetAddrInfoRequestWithOptions` based on reverse engineering and hardware testing. Every call to `GetAddrInfoRequestWithOptions` returns *four* different error codes (IPC status, getaddrinfo error code, netdb error code, and errno), and `GetAddrInfoRequest` returns three of those but in a different order, and it doesn't really matter but the existing implementation was a bit off, as I discovered while testing `GetHostByNameRequest`. - The new serialization code is based on two simple helper functions: ```cpp template <typename T> static void Append(std::vector<u8>& vec, T t); void AppendNulTerminated(std::vector<u8>& vec, std::string_view str); ``` I was thinking there must be existing functions somewhere that assist with serialization/deserialization of binary data, but all I could find was the helper methods in `IOFile` and `HLERequestContext`, not anything that could be used with a generic byte buffer. If I'm not missing something, then maybe I should move the above functions to a new header in `common`... right now they're just sitting in `sfdnsres.cpp` where they're used. - Not a fix, but `SocketBase::Recv`/`Send` is changed to use `std::span<u8>` rather than `std::vector<u8>&` to avoid needing to copy the data to/from a vector when those methods are called from the TLS implementation.
* service: move hle_ipc from kernelLiam2023-03-014-71/+71
|
* Merge pull request #9832 from liamwhite/hle-mpliamwhite2023-03-013-16/+13
|\ | | | | service: HLE multiprocess
| * service: refactor server architectureLiam2023-02-213-16/+13
| | | | | | | | Converts services to have their own processes
* | core: Update service function tables to 16.0.0+Narr the Reg2023-02-251-0/+3
| |
* | net: translate ECONNRESET network errorMonsterDruide12023-02-212-0/+3
|/
* service: remove deleted servicesLiam2023-02-143-72/+0
|
* Revert "Merge pull request #9718 from yuzu-emu/revert-9508-hle-ipc-buffer-span"ameerj2023-02-033-20/+20
| | | | | This reverts commit 25fc5c0e1158cb8e81cbc769b24ad84032a1fbfd, reversing changes made to af20e25081f97d55b451606c87922e2b49f0d363.
* Revert "hle_ipc: Use std::span to avoid heap allocations/copies when calling ReadBuffer"liamwhite2023-02-023-20/+20
|
* hle_ipc: Rename ReadBufferSpan to ReadBufferameerj2022-12-292-10/+10
|
* bsd: Use std::span for read payloadsameerj2022-12-292-26/+26
| | | | Allows the use of HLERequestContext::ReadBufferSpan
* service: Use ReadBufferSpan where it is trivial to do soameerj2022-12-251-3/+3
|
* chore: fix some typosAndrea Pappacoda2022-09-231-1/+1
| | | | Fix some typos reported by Lintian
* core/bsd: Correctly unbind methods in destructorFearlessTobi2022-08-271-1/+5
| | | | Prevents yuzu from crashing when the BSD service is created a second time.
* core, network: Add ability to proxy socket packetsFearlessTobi2022-08-154-9/+52
|
* yuzu: Add ui files for multiplayer roomsFearlessTobi2022-07-254-5/+5
|
* Enable the use of MSG_DONTWAIT flag on RecvImplLink45652022-07-161-1/+19
|
* general: Convert source file copyright comments over to SPDXMorph2022-04-2312-36/+24
| | | | | This formats all copyright comments according to SPDX formatting guidelines. Additionally, this resolves the remaining GPLv2 only licensed files by relicensing them to GPLv2.0-or-later.
* service: sfdnsres: add missing includes for some BSDs after 82d46a974ad4Jan Beich2022-04-121-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | src/core/hle/service/sockets/sfdnsres.cpp: In function 'Service::Sockets::NetDbError Service::Sockets::AddrInfoErrorToNetDbError(s32)': src/core/hle/service/sockets/sfdnsres.cpp:66:10: error: 'EAI_NODATA' was not declared in this scope; did you mean 'EAI_NONAME'? 66 | case EAI_NODATA: | ^~~~~~~~~~ | EAI_NONAME src/core/hle/service/sockets/sfdnsres.cpp: In function 'std::vector<unsigned char> Service::Sockets::SerializeAddrInfo(const addrinfo*, s32, std::string_view)': src/core/hle/service/sockets/sfdnsres.cpp:127:53: error: 'sockaddr_in' does not name a type; did you mean 'SockAddrIn'? 127 | const auto addr = *reinterpret_cast<sockaddr_in*>(current->ai_addr); | ^~~~~~~~~~~ | SockAddrIn src/core/hle/service/sockets/sfdnsres.cpp:127:64: error: expected '>' before '*' token 127 | const auto addr = *reinterpret_cast<sockaddr_in*>(current->ai_addr); | ^ src/core/hle/service/sockets/sfdnsres.cpp:127:64: error: expected '(' before '*' token 127 | const auto addr = *reinterpret_cast<sockaddr_in*>(current->ai_addr); | ^ | ( src/core/hle/service/sockets/sfdnsres.cpp:127:65: error: expected primary-expression before '>' token 127 | const auto addr = *reinterpret_cast<sockaddr_in*>(current->ai_addr); | ^ src/core/hle/service/sockets/sfdnsres.cpp:127:84: error: expected ')' before ';' token 127 | const auto addr = *reinterpret_cast<sockaddr_in*>(current->ai_addr); | ^ | ) src/core/hle/service/sockets/sfdnsres.cpp:148:53: error: 'sockaddr_in6' does not name a type; did you mean 'SockAddrIn6'? 148 | const auto addr = *reinterpret_cast<sockaddr_in6*>(current->ai_addr); | ^~~~~~~~~~~~ | SockAddrIn6 src/core/hle/service/sockets/sfdnsres.cpp:148:65: error: expected '>' before '*' token 148 | const auto addr = *reinterpret_cast<sockaddr_in6*>(current->ai_addr); | ^ src/core/hle/service/sockets/sfdnsres.cpp:148:65: error: expected '(' before '*' token 148 | const auto addr = *reinterpret_cast<sockaddr_in6*>(current->ai_addr); | ^ | ( src/core/hle/service/sockets/sfdnsres.cpp:148:66: error: expected primary-expression before '>' token 148 | const auto addr = *reinterpret_cast<sockaddr_in6*>(current->ai_addr); | ^ src/core/hle/service/sockets/sfdnsres.cpp:148:85: error: expected ')' before ';' token 148 | const auto addr = *reinterpret_cast<sockaddr_in6*>(current->ai_addr); | ^ | )
* Merge pull request #8171 from tech-ticks/skyline-improvementsFernando S2022-04-104-5/+201
|\ | | | | Improvements for game modding with Skyline, DNS resolution
| * service: sfdnsres: Implement DNS address resolutiontech-ticks2022-04-082-5/+197
| |
| * service: bsd: Add keepalive socket optiontech-ticks2022-04-072-0/+4
| |
* | hle: service: bsd: Create a service thread where appropriate.bunnei2022-04-021-1/+2
|/
* core: Reduce unused includesameerj2022-03-191-1/+0
|
* bsd: Allow inexact match for address length in AcceptImplValeri2022-03-151-2/+2
| | | Minecraft passes in zero for length, but this should account for all possible cases
* core: Remove unused includesameerj2021-11-041-1/+0
|
* service: Reduce header include overheadMorph2021-10-073-4/+5
|
* service: bsd: Stub ReadMorph2021-09-251-6/+5
| | | | - Used by Diablo II: Resurrected
* service: bsd: Implement ReadMorph2021-09-242-1/+15
| | | | - Used by Diablo II: Resurrected
* general: Replace RESULT_SUCCESS with ResultSuccessMorph2021-06-022-17/+17
| | | | Transition to PascalCase for result names.
* sfdnsres: Use proper namesgerman772021-04-091-2/+2
|
* nsd: Update to 12.xgerman772021-04-091-0/+1
|
* ethc: Update to 12.xgerman772021-04-091-0/+1
|
* bsd: Avoid writing empty buffersMorph2021-03-161-2/+6
| | | | Silences log spam on empty buffer writes
* bsd: Remove usage of optional emplace() with no argumentsLioncash2021-02-091-2/+4
| | | | Clang 12 currently falls over in the face of this.
* bsd: Fix EventFd stubMorph2021-01-311-3/+3
|
* bsd: Fix GetSockOpt stubMorph2021-01-311-1/+5
|
* bsd: Stub EventFdameerj2021-01-312-1/+12
| | | | Used by Family Feud
* core: hle: kernel: Rename Thread to KThread.bunnei2021-01-291-1/+1
|
* Stub GetSockOptgerman2021-01-282-1/+17
|
* core: Silence warnings when compiling without assertsReinUsesLisp2021-01-051-0/+1
|
* hle: service: bsd: Update to work with service threads, removing SleepClientThread.bunnei2020-12-293-249/+45
|
* Merge pull request #5142 from comex/xx-poll-eventsRodrigo Locatti2020-12-094-40/+45
|\ | | | | network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an `enum class PollEvents`
| * network, sockets: Replace `POLL_IN`, `POLL_OUT`, etc. constants with an `enum class PollEvents`comex2020-12-074-40/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Actually, two enum classes, since for some reason there are two separate yet identical `PollFD` types used in the codebase. I get that one is ABI-compatible with the Switch while the other is an abstract type used for the host, but why not use `WSAPOLLFD` directly for the latter? Anyway, why make this change? Because on Apple platforms, `POLL_IN`, `POLL_OUT`, etc. (with an underscore) are defined as macros in <sys/signal.h>. (This is inherited from FreeBSD.) So defining a variable with the same name causes a compile error. I could just rename the variables, but while I was at it I thought I might as well switch to an enum for stronger typing. Also, change the type used for values copied directly to/from the `events` and `revents` fields of the host *native* `pollfd`/`WSASPOLLFD`, from `u32` to `short`, as `short` is the correct canonical type on both Unix and Windows.
* | core: Remove unnecessary enum casts in log callsLioncash2020-12-082-9/+9
|/ | | | | Follows the video core PR. fmt doesn't require casts for enum classes anymore, so we can remove quite a few casts.
* service: Eliminate usages of the global system instanceLioncash2020-11-279-38/+49
| | | | | Completely removes all usages of the global system instance within the services code by passing in the using system instance to the services.
* Revert "core: Fix clang build"bunnei2020-10-213-46/+30
|
* core: Fix clang buildLioncash2020-10-183-30/+46
| | | | | | | Recent changes to the build system that made more warnings be flagged as errors caused building via clang to break. Fixes #4795
* core/CMakeLists: Make some warnings errorsLioncash2020-10-132-10/+10
| | | | | | | | | Makes our error coverage a little more consistent across the board by applying it to Linux side of things as well. This also makes it more consistent with the warning settings in other libraries in the project. This also updates httplib to 0.7.9, as there are several warning cleanups made that allow us to enable several warnings as errors.
* General: Make use of std::nullopt where applicableLioncash2020-09-221-1/+1
| | | | | | | | Allows some implementations to avoid completely zeroing out the internal buffer of the optional, and instead only set the validity byte within the structure. This also makes it consistent how we return empty optionals.
* bsd: Resolve unused value within SendToImplLioncash2020-09-071-0/+1
| | | | | Previously the address provided to SendToImpl would never be propagated to SendTo(). This fixes that.
* bsd: Resolve sign comparison warningsLioncash2020-09-071-3/+3
|
* sockets_translate: Make use of designated initializersLioncash2020-09-071-12/+12
| | | | Same behavior, less typing.
* blocking_worker: Make use of templated lambdaLioncash2020-09-071-3/+2
| | | | | We can simplify this a little by explicitly specifying the typename for the lambda function.
* blocking_worker: Resolve -Wdocumentation warningLioncash2020-09-071-1/+1
|
* service/bsd: Handle Poll with no entries accuratelyReinUsesLisp2020-07-281-0/+5
| | | | | Testing shows that Poll called with zero entries returns -1 and signals an errno of zero.
* services/bsd: Implement most of bsd:sReinUsesLisp2020-07-284-54/+910
| | | | | | | | | | | | | This implements: Socket, Poll, Accept, Bind, Connect, GetPeerName, GetSockName, Listen, Fcntl, SetSockOpt, Shutdown, Recv, RecvFrom, Send, SendTo, Write, and Close The implementation was done referencing: SwIPC, switchbrew, testing with libnx and inspecting its code, general information about bsd sockets online, and analysing official software. Not everything from these service calls is implemented, but everything that is not implemented will be logged in some way.
* service/sockets: Add worker pool abstractionReinUsesLisp2020-07-281-0/+30
| | | | | Manage worker threads with an easy to use abstraction. We can expand this to support thread deletion in the future.
* service/sockets: Add worker abstraction to execute blocking calls asynchronouslyReinUsesLisp2020-07-281-0/+132
| | | | | | This abstraction allows executing blocking functions (like recvfrom on a socket configured for blocking) without blocking the service thread. It is intended to be used with SleepClientThread.
* service/sockets: Add translate functionsReinUsesLisp2020-07-282-0/+213
| | | | | These functions translate from Network enumerations/structures to guest enumerations/structures and viceversa.
* service/sockets: Add enumerations and structuresReinUsesLisp2020-07-282-0/+81
| | | | Add guest enumerations and structures used in socket services
* service: Update function tablesVolcaEM2020-06-293-11/+22
|
* service: Update function tablesLioncash2020-04-201-0/+1
| | | | | | Keeps the service function tables up to date. Updated based off information on SwitchBrew.
* bsd: Stub several more functions.bunnei2020-01-252-4/+48
| | | | - Required for Little Town Hero to boot further.
* service: Update function tablesLioncash2019-11-121-0/+5
| | | | | | Keeps the function tables up to date. Updated based off information from Switchbrew.
* service: Update service function tablesLioncash2019-04-111-0/+5
| | | | Updates function tables based off information from SwitchBrew.
* hle/service: Resolve unused variable warningsLioncash2019-04-041-2/+10
| | | | | | | | | In several places, we have request parsers where there's nothing to really parse, simply because the HLE function in question operates on buffers. In these cases we can just remove these instances altogether. In the other cases, we can retrieve the relevant members from the parser and at least log them out, giving them some use.
* hle/service: Default constructors and destructors in the cpp file where applicableLioncash2018-09-118-3/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a destructor isn't defaulted into a cpp file, it can cause the use of forward declarations to seemingly fail to compile for non-obvious reasons. It also allows inlining of the construction/destruction logic all over the place where a constructor or destructor is invoked, which can lead to code bloat. This isn't so much a worry here, given the services won't be created and destroyed frequently. The cause of the above mentioned non-obvious errors can be demonstrated as follows: ------- Demonstrative example, if you know how the described error happens, skip forwards ------- Assume we have the following in the header, which we'll call "thing.h": \#include <memory> // Forward declaration. For example purposes, assume the definition // of Object is in some header named "object.h" class Object; class Thing { public: // assume no constructors or destructors are specified here, // or the constructors/destructors are defined as: // // Thing() = default; // ~Thing() = default; // // ... Some interface member functions would be defined here private: std::shared_ptr<Object> obj; }; If this header is included in a cpp file, (which we'll call "main.cpp"), this will result in a compilation error, because even though no destructor is specified, the destructor will still need to be generated by the compiler because std::shared_ptr's destructor is *not* trivial (in other words, it does something other than nothing), as std::shared_ptr's destructor needs to do two things: 1. Decrement the shared reference count of the object being pointed to, and if the reference count decrements to zero, 2. Free the Object instance's memory (aka deallocate the memory it's pointing to). And so the compiler generates the code for the destructor doing this inside main.cpp. Now, keep in mind, the Object forward declaration is not a complete type. All it does is tell the compiler "a type named Object exists" and allows us to use the name in certain situations to avoid a header dependency. So the compiler needs to generate destruction code for Object, but the compiler doesn't know *how* to destruct it. A forward declaration doesn't tell the compiler anything about Object's constructor or destructor. So, the compiler will issue an error in this case because it's undefined behavior to try and deallocate (or construct) an incomplete type and std::shared_ptr and std::unique_ptr make sure this isn't the case internally. Now, if we had defaulted the destructor in "thing.cpp", where we also include "object.h", this would never be an issue, as the destructor would only have its code generated in one place, and it would be in a place where the full class definition of Object would be visible to the compiler. ---------------------- End example ---------------------------- Given these service classes are more than certainly going to change in the future, this defaults the constructors and destructors into the relevant cpp files to make the construction and destruction of all of the services consistent and unlikely to run into cases where forward declarations are indirectly causing compilation errors. It also has the plus of avoiding the need to rebuild several services if destruction logic changes, since it would only be necessary to recompile the single cpp file.
* service/sockets: Add ethc:c and ethc:i servicesLioncash2018-07-263-0/+64
|
* service/sockets: Add missing bsdcfg socket serviceLioncash2018-07-263-0/+29
|
* Services/BSD: Corrected the return for StartMonitoring according to SwIPC.Subv2018-07-141-2/+1
|
* Update clang formatJames Rowe2018-07-031-2/+1
|
* Rename logging macro back to LOG_*James Rowe2018-07-032-7/+7
|
* sockets: Move logging macros over to new fmt-compatible onesLioncash2018-04-242-7/+8
|
* service: Use nested namespace specifiers where applicableLioncash2018-04-208-32/+16
| | | | Tidies up namespace declarations
* Various service name fixes - part 2 (rebased) (#322)Hexagon122018-04-172-0/+26
| | | | | | | | | | | | | | | | * Updated ACC with more service names * Updated SVC with more service names * Updated set with more service names * Updated sockets with more service names * Updated SPL with more service names * Updated time with more service names * Updated vi with more service names
* Service/sockets: add bsd:s, nsd:a, nsd:u servicesmailwl2018-03-257-30/+92
|
* Stub am::SetScreenShotPermission, and bsd::StartMonitoring functionsmailwl2018-02-222-0/+11
|
* [WIP] sfdnsres: stub (#146)mailwl2018-01-304-2/+51
| | | sfdnsres: Add several stubs
* hle: Rename RequestBuilder to ResponseBuilder.bunnei2018-01-251-4/+4
|
* Start to implement/stub BSD:U and SFDNSRES services (#78)flerovium^-^2018-01-185-0/+152
* bsd: start stubbing bsd:u and sfdnsres * bsd: stubbed RegisterClient * bsd: attempt to get past socket() * bsd: fix some wrong assumptions about IPC * bsd: fix format specifiers * bsd: stubbed Connect() * bsd: stubbed SendTo() * made requested changes * sockets: respect alphabetical order at service installation * run clang-format * bsd: start stubbing bsd:u and sfdnsres * bsd: stubbed RegisterClient * bsd: attempt to get past socket() * bsd: fix some wrong assumptions about IPC * bsd: fix format specifiers * bsd: stubbed Connect() * bsd: stubbed SendTo() * made requested changes * sockets: respect alphabetical order at service installation * run clang-format * run clang-format (2)
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-01 14:58:00 +0200