summaryrefslogtreecommitdiffstats
path: root/src/core/hle/service/nvflinger (unfollow)
Commit message (Collapse)AuthorFilesLines
2023-02-03Revert "Merge pull request #9718 from yuzu-emu/revert-9508-hle-ipc-buffer-span"ameerj4-46/+51
This reverts commit 25fc5c0e1158cb8e81cbc769b24ad84032a1fbfd, reversing changes made to af20e25081f97d55b451606c87922e2b49f0d363.
2023-02-02Revert "hle_ipc: Use std::span to avoid heap allocations/copies when calling ReadBuffer"liamwhite4-51/+46
2023-01-12nvnflinger: correct swap interval handlingLiam2-5/+5
2022-12-29hle_ipc: Rename ReadBufferSpan to ReadBufferameerj1-1/+1
2022-12-25nvflinger: Split Parcel class into InputParcel and OutputParcelameerj4-46/+51
The usages of the Parcel class were already unique to either Read or Write operations. Avoids needing a vector of the input payload for the InputParcel use-case, instead it can remain as a span.
2022-11-29producer_listener: Add virtual destructor to IProducerListenerLioncash1-0/+1
Several member variables are shared_ptr's to this base class. Even though producer listeners are still unimplemented, this ensures we always have consistent deletion behavior once this ends up being used polymorphically.
2022-11-29buffer_item_consumer: Pass fence by const-ref in ReleaseBuffer()Lioncash3-4/+3
This isn't directly modified. Also allows rvalues to be used with it.
2022-11-29buffer_queue_consumer: std::move std::shared_ptr in Connect()Lioncash1-1/+1
Avoids an unnecessary reference count increment and decrement
2022-11-29consumer_base: Pass shared_ptr by const referenceLioncash2-6/+6
Avoids churning atomic reference count increments and decrements.
2022-11-29consumer_base: Remove redundant virtualLioncash1-5/+5
override already serves this purpose
2022-11-23general: fix compile for Apple ClangLiam1-0/+1
2022-11-15nvnflinger: fix lost wakeupLiam4-12/+16
2022-10-27nvnflinger: release queued handles immediately on disconnectionLiam1-0/+7
2022-10-27vi: implement CloseDisplayLiam2-0/+18
2022-10-23core: barrier service thread shutdownLiam2-4/+10
2022-10-13kernel: remove KWritableEventLiam3-7/+4
2022-10-06Nvflinger: correct duplication.Fernando Sahmkow2-2/+2
2022-10-06Core: Fix get nvmap object random crashVonChenPlus5-8/+30
2022-10-06VideoCore: Refactor fencing system.Fernando Sahmkow1-12/+3
2022-10-06VideoCore: Refactor syncing.Fernando Sahmkow1-2/+7
2022-10-06NVDRV: Fix Open/Close and make sure each device is correctly created.Fernando Sahmkow2-1/+7
2022-10-04common: remove "yuzu:" prefix from thread namesLiam1-1/+1
2022-09-26service: vi: Retrieve vsync event once per displayMorph2-5/+8
The display vsync event can only be retrieved once per display. Returns VI::ResultPermissionDenied if we attempt to retrieve the vsync event for the same display. Prevents games such as .hack//G.U. Last Recode from consuming all the handles in the handle table by spamming vsync event retrievals and allows it to go in game.
2022-08-02Rework multi-core vsyncKelebek12-17/+30
2022-07-17hle: service: nvflinger: Fix implicit conversion.bunnei1-1/+4
2022-07-17yuzu: settings: Remove framerate cap and merge unlocked framerate setting.bunnei1-8/+10
- These were all somewhat redundant.
2022-07-17hle: service: nvflinger: Factor speed limit into frame time calculation.bunnei1-1/+8
- This allows the %-based "Limit Speed Percent" setting to work with MC emulation. - This is already supported for SC emulation.
2022-07-15nvflinger: Polymorphic destructor requried for abstract class IBinderMerry1-0/+1
2022-07-10PRKelebek11-3/+3
2022-07-10Rework CoreTimingKelebek11-7/+6
2022-06-14common: Change semantics of UNREACHABLE to unconditionally crashLiam1-1/+1
2022-06-06hle: service: nvflinger: buffer_queue_consumer: Always free released buffers.bunnei3-31/+3
2022-04-23general: Convert source file copyright comments over to SPDXMorph29-69/+69
This formats all copyright comments according to SPDX formatting guidelines. Additionally, this resolves the remaining GPLv2 only licensed files by relicensing them to GPLv2.0-or-later.
2022-04-07core/hle: Standardize scoped_lock initializersMerry5-23/+23
2022-04-07core/hle: Replace lock_guard with scoped_lockMerry1-2/+2
2022-04-07fix: remove #pragma once in .cpp fileAndrea Pappacoda1-2/+0
2022-04-02hle: service: nvflinger: buffer_queue_producer: Cleanup & fixes.bunnei2-61/+42
2022-04-02hle: service: nvflinger: consumer_base: Cleanup & fixes.bunnei2-15/+17
2022-04-02hle: service: nvflinger: buffer_queue_producer: Cleanup & add GetReleasedBuffers.bunnei2-10/+38
2022-04-02hle: service: nvflinger: buffer_queue_core: Cleanup & fixes.bunnei2-3/+0
2022-04-02hle: service: nvflinger: Use correct logger namespace.bunnei1-2/+2
2022-03-26hle: service: nvflinger: buffer_queue: Remove AutoLock and fix free buffer tracking.bunnei5-181/+130
2022-03-26hle: service: nvflinger: buffer_queue_consumer: Use scoped_lock instead of unique_lock.bunnei1-2/+2
2022-03-26hle: service: nvflinger: consumer_base: Use scoped_lock instead of unique_lock.bunnei1-4/+4
2022-03-26hle: service: nvflinger: Remove unused BufferQueue.bunnei2-360/+0
2022-03-25hle: nvflinger: ConsumerBase: Mark ctor as explicit.bunnei1-1/+1
2022-03-25hle: nvdrv: nvdata: buffer_queue_producer: Minor cleanup.bunnei1-11/+11
2022-03-25hle: nvflinger: Remove unused unordered_map include.bunnei1-1/+0
2022-03-25hle: nvflinger: buffer_queue_consumer: AcquireBuffer: Fix typo.bunnei1-1/+1
2022-03-25hle: nvflinger: Merge Rect with Common::Rectangle.bunnei4-84/+9
2022-03-25hle: nvflinger: buffer_queue_core: Declare default dtor.bunnei2-0/+3
2022-03-25hle: nvflinger: buffer_queue_producer: DequeueBuffer: Remove unnecessary lock.bunnei1-3/+1
2022-03-25hle: nvflinger: consumer_base: StillTracking: Should be const.bunnei2-2/+3
2022-03-25hle: nvflinger: graphic_buffer_producer: Remove unnecessary pragma pack.bunnei1-2/+0
2022-03-25hle: nvflinger: parcel: Reserve token size.bunnei1-1/+2
2022-03-25hle: nvflinger: buffer_queue_core: StillTracking: Take const reference.bunnei4-7/+7
2022-03-25hle: nvflinger: buffer_queue_core: Cleanup locking.bunnei1-2/+2
2022-03-25hle: nvflinger: Use std::chrono for present_ns.bunnei7-25/+30
2022-03-25hle: nvflinger: Migrate android namespace -> Service::android.bunnei27-58/+55
2022-03-25hle: nvflinger: BufferQueueProducer: Handle SetPreallocatedBuffer with empty buffer.bunnei1-7/+10
- Used by Naruto Ultimate Ninja Storm.
2022-03-25hle: vi: Integrate new NVFlinger and HosBinderDriverServer service.bunnei2-52/+56
2022-03-25hle: nvflinger: Add implementation for HosBinderDriverServer service.bunnei2-0/+73
2022-03-25hle: nvflinger: Add implementation for BufferQueueProducer class.bunnei2-0/+1019
2022-03-25hle: nvflinger: Add implementation for BufferQueueCore class.bunnei2-0/+233
2022-03-25hle: nvflinger: Add implementation for BufferQueueConsumer class.bunnei2-0/+261
2022-03-25hle: nvflinger: Add implementation for QueueBufferInput and QueueBufferOutput structs.bunnei2-0/+98
2022-03-25hle: nvflinger: Add implementation for BufferItemConsumer class.bunnei2-0/+85
2022-03-25hle: nvflinger: Add implementation for ConsumerBase class.bunnei2-0/+188
2022-03-25hle: nvflinger: Add implementation for BufferSlot class.bunnei1-0/+39
2022-03-25hle: nvflinger: Add implementation for BufferItem class.bunnei1-0/+46
2022-03-25hle: nvflinger: Move implementation for Parcel to its own header.bunnei1-0/+171
2022-03-25hle: nvflinger: Add android buffer queue definitions to its own header.bunnei1-0/+21
2022-03-25hle: nvflinger: Add IBinder interface.bunnei1-0/+42
2022-03-25hle: nvflinger: Add IConsumerListener interface.bunnei1-0/+26
2022-03-25hle: nvflinger: Add ProducerListener interface.bunnei1-0/+16
2022-03-25hle: nvflinger: Add android window enumerations to its own header.bunnei1-0/+53
2022-03-25hle: nvflinger: Add android Status flags to its own header.bunnei1-0/+28
2022-03-25hle: nvflinger: Move BufferTransformFlags to its own header.bunnei1-0/+25
2022-03-25hle: nvflinger: Move PixelFormat to its own header.bunnei2-2/+23
2022-03-25hle: nvflinger: Add implementation for GraphicBuffer class.bunnei1-0/+100
2022-03-25hle: nvflinger: Add implementation for Fence class.bunnei1-0/+32
2022-03-25hle: nvflinger: Add implementation for Rect class.bunnei1-0/+75
2022-01-04Revert "Merge pull request #7668 from ameerj/fence-stop-token"ameerj1-2/+1
This reverts commit e7733544779f2706d108682dd027d44e7fa5ff4b, reversing changes made to abbbdc2bc027ed7af236625ae8427a46df63f7e7.
2022-01-03gpu: Use std::stop_token in WaitFence for VSync threadameerj1-1/+2
Fixes a hang that may occur when stopping emulation and the VSync thread is blocked on the syncpoint condition variable.
2021-12-28Remove invalid assertion statementFeng Chen1-3/+0
2021-12-28Implement few type in bufferqueue query methodFeng Chen2-0/+9
2021-11-04core: Remove unused includesameerj1-1/+0
2021-10-03nvflinger: Use jthread and stop_token for VSync threadameerj2-32/+8
Avoids a destruction data race that may occur on the vsync thread
2021-09-07nvflinger: Use external surface format for framebuffer creationameerj2-2/+4
The format member the IGBPBuffer may not always specify the correct desired format. Using the external format member ensures a valid format is provided when creating the framebuffer. Fixes homebrew using the wrong framebuffer format.
2021-09-05core: hle: service: buffer_queue: Improve management of KEvent.bunnei3-14/+24
2021-09-04core: hle: service: nvflinger/vi: Improve management of KEvent.bunnei2-6/+10
2021-08-26Revert "kernel: Various improvements to scheduler"bunnei4-34/+20
2021-08-07core: hle: service: buffer_queue: Improve management of KEvent.bunnei3-14/+24
2021-08-07core: hle: service: nvflinger/vi: Improve management of KEvent.bunnei2-6/+10
2021-07-24config, nvflinger: Add FPS cap settingameerj1-5/+6
Allows finer tuning of the FPS limit.
2021-06-17nvflinger: Add toggle to disable buffer swap interval limitsameerj1-0/+3
Enabling this setting will allow some titles to present more frames to the screen as they become available in the nvflinger buffer queue.
2021-05-16core: Make variable shadowing a compile-time errorLioncash4-5/+5
Now that we have most of core free of shadowing, we can enable the warning as an error to catch anything that may be remaining and also eliminate this class of logic bug entirely.
2021-05-06nvflinger: Create layers when they are queried but not foundameerj2-5/+35
Fixes Shantae softlock on boot.
2021-05-06hle: kernel: Remove deprecated Object class.bunnei2-2/+0
2021-05-06hle: kernel: Migrate KReadableEvent and KWritableEvent to KAutoObject.bunnei4-12/+12
2021-05-06hle: kernel: Ensure all kernel objects with KAutoObject are properly created.bunnei1-0/+1
2021-05-06hle: kernel: Migrate KEvent to KAutoObject.bunnei4-15/+15
2021-05-06hle: kernel: Refactor IPC interfaces to not use std::shared_ptr.bunnei2-1/+2
2021-04-26service: Eliminate cases of member shadowingLioncash1-7/+7
Resolves a few localized instances of member variable shadowing. Brings us a little closer to turning shadowing warnings into errors.
2021-04-15common: Move settings to common from core.bunnei1-1/+1
- Removes a dependency on core and input_common from common.
2021-02-05hle: kernel: Reimplement KReadableEvent and KWritableEvent.bunnei2-11/+14
2021-02-05hle: kernel: Rename WritableEvent to KWritableEvent.bunnei3-6/+6
2021-02-05hle: kernel: Rename ReadableEvent to KReadableEvent.bunnei4-7/+7
2021-01-11core: hle: Add missing calls to MicroProfileOnThreadExit.bunnei1-0/+4
2021-01-09core: Silence unhandled enum in switch warningsReinUsesLisp1-2/+4
2021-01-04buffer_queue: Protect queue_sequence list access with a mutexameerj2-13/+21
fixes a data race as this is an unprotected variable manipulated by multiple threads
2021-01-03hle: service: nvflinger: buffer_queue: Do not reset id/layer_id on Connect.bunnei1-2/+0
- This behavior is a mistake, fixes Katana Zero.
2020-12-29service: nvflinger: Improve synchronization for BufferQueue.bunnei4-11/+61
- Use proper mechanisms for blocking on DequeueBuffer. - Ensure service thread terminates on emulation Shutdown.
2020-12-29hle: service: nvflinger: Refactor locking and interfaces.bunnei2-15/+15
2020-12-18buffer_queue: better use of std::arrayameerj1-59/+46
2020-12-17Overwrite slots instead of queuing them, add disconnect signalameerj2-22/+22
Fix for Katana Zero and Yoshi's Crafted World
2020-12-08core: Remove unnecessary enum casts in log callsLioncash1-1/+1
Follows the video core PR. fmt doesn't require casts for enum classes anymore, so we can remove quite a few casts.
2020-11-01service: hle: nvflinger: Fix potential shutdown crash when GPU is destroyed.bunnei1-0/+4
2020-10-30General: Resolve a few missing initializer warningsLioncash1-0/+4
Resolves a few -Wmissing-initializer warnings.
2020-10-21Revert "core: Fix clang build"bunnei1-1/+1
2020-10-18core: Fix clang buildLioncash1-1/+1
Recent changes to the build system that made more warnings be flagged as errors caused building via clang to break. Fixes #4795
2020-10-14hle: service: vi: Implement BufferQueue::CancelBuffer.bunnei2-0/+15
- This is used by Super Mario 3D All-Stars.
2020-09-22General: Make use of std::nullopt where applicableLioncash1-3/+3
Allows some implementations to avoid completely zeroing out the internal buffer of the optional, and instead only set the validity byte within the structure. This also makes it consistent how we return empty optionals.
2020-08-13General: Tidy up clang-format warnings part 2Lioncash1-4/+6
2020-08-03buffer_queue: Make use of std::nulloptLioncash1-5/+6
Allows compilers to eliminate unnecessary zeroing out of the optional's buffer.
2020-08-03buffer_queue: Make use of designated initializersLioncash1-5/+5
2020-07-28core_timing: Make use of uintptr_t to represent user_dataLioncash1-1/+1
Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
2020-07-26nvflinger: Mark interface functions with return values as [[nodiscard]]Lioncash1-16/+14
Not using the return value of these functions are undeniably the source of a bug. This way we allow compilers to loudly make any future misuses evident.
2020-07-26nvflinger: Use return value of Lock()Lioncash2-2/+2
comex reported in #4424 that we were incorrectly discarding the return value of Lock() which is correct.
2020-07-16core_timing: Make TimedCallback take std::chrono::nanosecondsLioncash1-3/+3
Enforces our desired time units directly with a concrete type.
2020-07-16core_timing: Make use of std::chrono with ScheduleEventLioncash1-6/+9
2020-06-27NvFlinger: Clang Format.Fernando Sahmkow1-1/+1
2020-06-27Services/NvFlinger: Do vSync in a sepparate thread on Multicore.Fernando Sahmkow2-3/+60
2020-06-27NVFlinger: Lock race condition between CPU, Host Timing, VSync.Fernando Sahmkow2-0/+9
2020-06-27General: Recover Prometheus project from harddrive failure Fernando Sahmkow1-7/+6
This commit: Implements CPU Interrupts, Replaces Cycle Timing for Host Timing, Reworks the Kernel's Scheduler, Introduce Idle State and Suspended State, Recreates the bootmanager, Initializes Multicore system.
2020-05-16nv_flinger: Use enum for pixel format instead of u32David Marcec2-3/+11
2020-04-10Buffer queue: Correct behavior of free buffer.Fernando Sahmkow2-9/+33
This corrects the behavior of free buffer after witnessing it in an unrelated hardware test. I haven't found any games affected by it but in name of better accuracy we'll correct such behavior.
2020-04-10service/vi: Partially implement BufferQueue disconnectReinUsesLisp2-0/+8
2020-03-12NVFlinger: Do the microprofile Flip after processing a valid frame.Fernando Sahmkow1-2/+2
2020-02-12Core: Set all hardware emulation constants in a single file.Fernando Sahmkow1-3/+4
2020-01-04service: vi: Implement CloseLayer.bunnei2-0/+9
- Needed for Undertale.
2019-12-30video_core: Block in WaitFence.Markus Wick1-1/+1
This function is called rarely and blocks quite often for a long time. So don't waste power and let the CPU sleep. This might also increase the performance as the other cores might be allowed to clock higher.
2019-11-27core_timing: Use better reference tracking for EventType. (#3159)bunnei2-3/+3
* core_timing: Use better reference tracking for EventType. - Moves ownership of the event to the caller, ensuring we don't fire events for destroyed objects. - Removes need for unique names - we won't be using this for save states anyways.
2019-11-25kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. (#3154)bunnei4-6/+6
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. - See https://github.com/citra-emu/citra/pull/4710 for details.
2019-11-03kernel: events: Remove ResetType::Automatic.bunnei1-2/+1
- This does not actually seem to exist in the real kernel - games reset these automatically. # Conflicts: # src/core/hle/service/am/applets/applets.cpp # src/core/hle/service/filesystem/fsp_srv.cpp
2019-10-12nvflinger/buffer_queue: Remove use of a global system accessorLioncash3-4/+8
2019-10-05NvFlinger: Remove leftover from corrections and clang format.Fernando Sahmkow1-4/+0
2019-10-05NVFlinger: Reverse the change that only signaled events on buffer acquire.Fernando Sahmkow2-20/+1
This has been hardware tested and it seems that NVFlinger will still signal even if there are no buffers to present.
2019-10-05NvFlinger: Don't swap buffers if a frame is missing and always trigger event in sync gpu.Fernando Sahmkow1-1/+3
2019-10-05GPU_Async: Correct fences, display events and more.Fernando Sahmkow2-2/+21
This commit uses guest fences on vSync event instead of an articial fake fence we had. It also corrects to keep signaling display events while loading the game as the OS is suppose to send buffers to vSync during that time.
2019-10-05Nvdrv: Correct Async regression and avoid signaling empty buffer vsyncsFernando Sahmkow1-1/+7
2019-09-22RebaseDavid Marcec2-15/+13
2019-09-22Deglobalize System: ViDavid Marcec1-5/+5
2019-09-22Deglobalize System: NvFlingerDavid Marcec2-6/+7
2019-07-05NVServices: Address FeedbackFernando Sahmkow1-0/+1
2019-07-05NVServices: Styling, define constructors as explicit and correctionsFernando Sahmkow3-6/+5
2019-07-05NVFlinger: Correct GCC compile errorFernando Sahmkow2-9/+9
2019-07-05nvflinger: Make the force 30 fps still force 30 fpsFernando Sahmkow1-1/+1
2019-07-05nvflinger: Acquire buffers in the same order as they were queued.Fernando Sahmkow2-3/+11
2019-07-05nv_services: Correct buffer queue fencing and GPFifo fencingFernando Sahmkow2-5/+12
2019-07-05nvflinger: Implement swap intervalsFernando Sahmkow4-6/+18
2019-05-18core/kernel/object: Rename ResetType enum membersLioncash1-1/+1
Renames the members to more accurately indicate what they signify. "OneShot" and "Sticky" are kind of ambiguous identifiers for the reset types, and can be kind of misleading. Automatic and Manual communicate the kind of reset type in a clearer manner. Either the event is automatically reset, or it isn't and must be manually cleared. The "OneShot" and "Sticky" terminology is just a hold-over from Citra where the kernel had a third type of event reset type known as "Pulse". Given the Switch kernel only has two forms of event reset types, we don't need to keep the old terminology around anymore.
2019-04-09added a toggle to force 30fps modezarroboogs1-6/+10
2019-03-24core/core_timing: Make callback parameters consistentLioncash1-2/+2
In some cases, our callbacks were using s64 as a parameter, and in other cases, they were using an int, which is inconsistent. To make all callbacks consistent, we can just use an s64 as the type for late cycles, given it gets rid of the need to cast internally. While we're at it, also resolve some signed/unsigned conversions that were occurring related to the callback registration.
2019-03-07gpu: Refactor command and swap buffers interface for asynch.bunnei1-1/+1
2019-02-27common/math_util: Move contents into the Common namespaceLioncash2-3/+3
These types are within the common library, so they should be within the Common namespace.
2019-02-22service/nvflinger: Store BufferQueue instances as regular data membersLioncash2-7/+17
The NVFlinger service is already passed into services that need to guarantee its lifetime, so the BufferQueue instances will already live as long as they're needed. Making them std::shared_ptr instances in this case is unnecessary.
2019-02-21service/vi/vi_layer: Convert Layer struct into a classLioncash2-5/+5
Like the previous changes made to the Display struct, this prepares the Layer struct for changes to its interface. Given Layer will be given more invariants in the future, we convert it into a class to better signify that.
2019-02-21service/nvflinger: Move display specifics over to vi_displayLioncash2-34/+21
With the display and layer structures relocated to the vi service, we can begin giving these a proper interface before beginning to properly support the display types. This converts the display struct into a class and provides it with the necessary functions to preserve behavior within the NVFlinger class.
2019-02-20service/nvflinger: Relocate definitions of Layer and Display to the vi serviceLioncash2-57/+30
These are more closely related to the vi service as opposed to the intermediary nvflinger. This also places them in their relevant subfolder, as future changes to these will likely result in subclassing to represent various displays and services, as they're done within the service itself on hardware. The reasoning for prefixing the display and layer source files is to avoid potential clashing if two files with the same name are compiled (e.g. if 'display.cpp/.h' or 'layer.cpp/.h' is added to another service at any point), which MSVC will actually warn against. This prevents that case from occurring. This also presently coverts the std::array introduced within f45c25aabacc70861723a7ca1096a677bd987487 back to a std::vector to allow the forward declaration of the Display type. Forward declaring a type within a std::vector is allowed since the introduction of N4510 (http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4510.html) by Zhihao Yuan.
2019-02-16core_timing: Convert core timing into a classLioncash2-7/+11
Gets rid of the largest set of mutable global state within the core. This also paves a way for eliminating usages of GetInstance() on the System class as a follow-up. Note that no behavioral changes have been made, and this simply extracts the functionality into a class. This also has the benefit of making dependencies on the core timing functionality explicit within the relevant interfaces.
2019-02-12core_timing: Rename CoreTiming namespace to Core::TimingLioncash3-12/+8
Places all of the timing-related functionality under the existing Core namespace to keep things consistent, rather than having the timing utilities sitting in its own completely separate namespace.
2019-02-06service/nvflinger,service/vi: Handle failure cases with exposed APILioncash2-34/+79
Converts many of the Find* functions to return a std::optional<T> as opposed to returning the raw return values directly. This allows removing a few assertions and handles error cases like the service itself does.
2019-02-05service/nvflinger: Mark FindVsyncEvent() as a const member functionLioncash2-2/+2
This member function doesn't actually modify instance state, so it can be marked as a const member function.
2019-02-05service/nvflinger: Rename GetVsyncEvent() to FindVsyncEvent()Lioncash2-2/+2
This was missed within #2075. Renames the member function to make it consistent with the rest of the Find* functions.
2019-01-30service/nvflinger: Make FindBufferQueueId() a const member functionLioncash2-2/+26
This member function doesn't actually modify instance state, so it can be const-qualified.
2019-01-30service/nvflinger: Rename Get prefix on function to FindLioncash2-18/+18
This more accurately describes what the function is actually attempting to do (it's not a simple trivial getter).
2019-01-30nvflinger: Add the Null displayLioncash1-1/+2
In addition to the default, external, EDID, and internal displays, there's also a null display provided as well, which as the name suggests, does nothing but discard all commands given to it. This is provided for completeness.
2019-01-30nvflinger: Change log message in OpenDisplay to be a debug log instead of a warningLioncash1-1/+1
Opening a display isn't really a thing to warn about. It's an expected thing, so this can be a debug log. This also alters the string to indicate the display name better. Opening "Default" display reads a little nicer compared to Opening display Default.
2019-01-30nvflinger: Remove unnecessary header inclusionsLioncash1-2/+0
2019-01-30nvflinger: Mark locals const where applicableLioncash1-11/+11
Makes non-mutable state more explicit.
2019-01-30nvflinger: Use a std::array for the available displays instead of std::vectorLioncash2-7/+7
The built-in set of displays is fixed, so we can utilize an array instead of a vector here.
2019-01-03 Fixed botw deadlock(and possibly 30 fps games rendering too fast? needs testing to confirm)David Marcec1-1/+1
Upon investigating the issue with #1878, I found that games are the ones who handle the vsync event resetting and not us.
2018-11-29kernel/event: Reference ReadableEvent from WritableEventZach Hilman4-21/+13
2018-11-29core: Port all current usages of Event to Readable/WritableEventZach Hilman4-14/+42
2018-11-26Changed logging to be "Log before execution", Added more error logging, all services should now log on some levelDavid Marcec1-2/+3
2018-11-04Fix typo in BufferTransformFlagsFrederic Laing1-2/+2
2018-10-30global: Use std::optional instead of boost::optional (#1578)Frederic L3-13/+14
* get rid of boost::optional * Remove optional references * Use std::reference_wrapper for optional references * Fix clang format * Fix clang format part 2 * Adressed feedback * Fix clang format and MacOS build
2018-09-15Port #4182 from Citra: "Prefix all size_t with std::"fearlessTobi1-1/+1
2018-09-13service: Use nested namespace specifiers where applicableLioncash2-8/+4
There were a few places where nested namespace specifiers weren't being used where they could be within the service code. This amends that to make the namespacing a tiny bit more compact.
2018-09-11hle/service: Default constructors and destructors in the cpp file where applicableLioncash4-3/+8
When a destructor isn't defaulted into a cpp file, it can cause the use of forward declarations to seemingly fail to compile for non-obvious reasons. It also allows inlining of the construction/destruction logic all over the place where a constructor or destructor is invoked, which can lead to code bloat. This isn't so much a worry here, given the services won't be created and destroyed frequently. The cause of the above mentioned non-obvious errors can be demonstrated as follows: ------- Demonstrative example, if you know how the described error happens, skip forwards ------- Assume we have the following in the header, which we'll call "thing.h": \#include <memory> // Forward declaration. For example purposes, assume the definition // of Object is in some header named "object.h" class Object; class Thing { public: // assume no constructors or destructors are specified here, // or the constructors/destructors are defined as: // // Thing() = default; // ~Thing() = default; // // ... Some interface member functions would be defined here private: std::shared_ptr<Object> obj; }; If this header is included in a cpp file, (which we'll call "main.cpp"), this will result in a compilation error, because even though no destructor is specified, the destructor will still need to be generated by the compiler because std::shared_ptr's destructor is *not* trivial (in other words, it does something other than nothing), as std::shared_ptr's destructor needs to do two things: 1. Decrement the shared reference count of the object being pointed to, and if the reference count decrements to zero, 2. Free the Object instance's memory (aka deallocate the memory it's pointing to). And so the compiler generates the code for the destructor doing this inside main.cpp. Now, keep in mind, the Object forward declaration is not a complete type. All it does is tell the compiler "a type named Object exists" and allows us to use the name in certain situations to avoid a header dependency. So the compiler needs to generate destruction code for Object, but the compiler doesn't know *how* to destruct it. A forward declaration doesn't tell the compiler anything about Object's constructor or destructor. So, the compiler will issue an error in this case because it's undefined behavior to try and deallocate (or construct) an incomplete type and std::shared_ptr and std::unique_ptr make sure this isn't the case internally. Now, if we had defaulted the destructor in "thing.cpp", where we also include "object.h", this would never be an issue, as the destructor would only have its code generated in one place, and it would be in a place where the full class definition of Object would be visible to the compiler. ---------------------- End example ---------------------------- Given these service classes are more than certainly going to change in the future, this defaults the constructors and destructors into the relevant cpp files to make the construction and destruction of all of the services consistent and unlikely to run into cases where forward declarations are indirectly causing compilation errors. It also has the plus of avoiding the need to rebuild several services if destruction logic changes, since it would only be necessary to recompile the single cpp file.
2018-08-31core: Make the main System class use the PImpl idiomLioncash1-1/+2
core.h is kind of a massive header in terms what it includes within itself. It includes VFS utilities, kernel headers, file_sys header, ARM-related headers, etc. This means that changing anything in the headers included by core.h essentially requires you to rebuild almost all of core. Instead, we can modify the System class to use the PImpl idiom, which allows us to move all of those headers to the cpp file and forward declare the bulk of the types that would otherwise be included, reducing compile times. This change specifically only performs the PImpl portion.
2018-08-29kernel: Eliminate kernel global stateLioncash2-2/+5
As means to pave the way for getting rid of global state within core, This eliminates kernel global state by removing all globals. Instead this introduces a KernelCore class which acts as a kernel instance. This instance lives in the System class, which keeps its lifetime contained to the lifetime of the System class. This also forces the kernel types to actually interact with the main kernel instance itself instead of having transient kernel state placed all over several translation units, keeping everything together. It also has a nice consequence of making dependencies much more explicit. This also makes our initialization a tad bit more correct. Previously we were creating a kernel process before the actual kernel was initialized, which doesn't really make much sense. The KernelCore class itself follows the PImpl idiom, which allows keeping all the implementation details sealed away from everything else, which forces the use of the exposed API and allows us to avoid any unnecessary inclusions within the main kernel header.
2018-08-11video_core; Get rid of global g_toggle_framelimit_enabled variableLioncash1-0/+1
Instead, we make a struct for renderer settings and allow the renderer to update all of these settings, getting rid of the need for global-scoped variables. This also uncovered a few indirect inclusions for certain headers, which this commit also fixes.
2018-08-09buffer_queue: Make reference parameter of SetPreallocatedBuffer constLioncash2-2/+2
This is simply copied by value, so there's no need to make it a modifiable reference. While we're at it, make the names of the parameters match its definition.
2018-08-08nvdrv: Get rid of global std::weak_ptrLioncash2-3/+13
Rather than use global state, we can simply pass the instance into the NVFlinger instance directly.
2018-08-07nvflinger: Correct typo in name of composition eventLioncash1-1/+1
2018-08-07nvflinger: Get rid of indirect inclusionsLioncash2-1/+7
2018-08-07nvflinger: Use std::string_view in OpenDisplay()Lioncash2-2/+3
We don't need to use a std::string here, given all that's done is comparing the character sequence against another. This allows passing regular const char* without needing to heap allocate.
2018-08-04video_core: Eliminate the g_renderer global variableLioncash1-2/+4
We move the initialization of the renderer to the core class, while keeping the creation of it and any other specifics in video_core. This way we can ensure that the renderer is initialized and doesn't give unfettered access to the renderer. This also makes dependencies on types more explicit. For example, the GPU class doesn't need to depend on the existence of a renderer, it only needs to care about whether or not it has a rasterizer, but since it was accessing the global variable, it was also making the renderer a part of its dependency chain. By adjusting the interface, we can get rid of this dependency.
2018-08-02kernel: Move object class to its own source filesLioncash1-3/+2
General moving to keep kernel object types separate from the direct kernel code. Also essentially a preliminary cleanup before eliminating global kernel state in the kernel code.
2018-07-24core_timing: Split off utility functions into core_timing_utilMerryMage1-0/+1
2018-07-19nvflinger: Emplace Display instances directlyLioncash1-9/+4
We can use emplace_back to construct the Display instances directly, instead of constructing them separately and copying them, avoiding the need to copy std::string and std::vector instances that are part of the Display struct.
2018-07-18vi: Partially implement buffer crop parameters.bunnei3-3/+9
2018-07-17nvflinger: Fix for BufferQueue event handling.bunnei3-25/+6
2018-07-03Rename logging macro back to LOG_*James Rowe2-3/+3
2018-04-30core_timing: Namespace all functions and constants in core_timing's headerLioncash1-1/+1
All of these variables and functions are related to timings and should be within the namespace.
2018-04-24nvflinger: Move logging macros over to new fmt-compatible onesLioncash2-3/+3
2018-04-21Qt: Update the WaitTree widget to show info about the current mutex of each thread.Subv2-4/+8
2018-04-20service: Use nested namespace specifiers where applicableLioncash4-16/+8
Tidies up namespace declarations
2018-04-19nvflinger: Call MicroProfileFlip on NVFlinger::Compose.bunnei1-0/+3
2018-03-23renderer_opengl: Better handling of framebuffer transform flags.bunnei1-0/+2
2018-03-19vi: Remove DequeueBuffer and wait until next available buffer.bunnei2-6/+25
2018-03-17nvflinger: Remove superfluous buffer format check.bunnei1-3/+1
2018-03-03Vi: Signal the BufferQueue's Native Handle right after ReleaseBuffer is called.Subv1-0/+3
This prevents a thread starvation issue in Puyo Puyo Tetris. We should hwtest this behavior and figure out where exactly this event is signaled.
2018-02-14Fix fps counter to correctly measure frame end when there was no frame to drawJames Rowe1-0/+2
2018-02-12vi: Parse IGBPQueueBufferRequestParcel params and expose buffer flip vertical.bunnei3-3/+18
2018-02-10nvflinger: (Hack) Use first available buffer if none are found.bunnei1-1/+5
2018-02-05nvflinger: Signal BufferQueue native handle event.bunnei1-0/+1
- This gets BOTW booting.
2018-01-22VI: Move BufferQueue and NVFlinger to their own folder/namespace.Subv4-0/+423