| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Converts services to have their own processes
|
| | |
|
| | |
|
| |
|
|
|
| |
This reverts commit 25fc5c0e1158cb8e81cbc769b24ad84032a1fbfd, reversing
changes made to af20e25081f97d55b451606c87922e2b49f0d363.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
| |
This formats all copyright comments according to SPDX formatting guidelines.
Additionally, this resolves the remaining GPLv2 only licensed files by relicensing them to GPLv2.0-or-later.
|
| | |
|
| | |
|
| |
|
|
| |
This allows us to avoid including KProcess' header file in files that only need to get the current process' program id.
|
| | |
|
| |
|
|
| |
Gets rid of homebrew warnings using this func
|
| |
|
|
|
|
|
|
| |
This introduces a new setting Enable FS Access Log which saves the filesystem access log to sdmc:/FsAccessLog.txt
If this setting is not enabled, this will indicate to FS to not call OutputAccessLogToSdCard.
Fixes softlocks during loading in Xenoblade Chronicles 2 when certain DLC is enabled.
|
| | |
|
| |
|
| |
- Used by Mii Edit
|
| |
|
|
| |
Transition to PascalCase for result names.
|
| |
|
|
| |
Transition to PascalCase for result names.
|
| | |
|
| |
|
|
|
| |
Resolves a few localized instances of member variable shadowing. Brings
us a little closer to turning shadowing warnings into errors.
|
| | |
|
| | |
|
| |\
| |
| | |
fsp_srv: Implement OpenDataStorageWithProgramIndex
|
| | |
| |
| |
| | |
- Used by RollerCoaster Tycoon 3: Complete Edition
|
| |/
|
|
|
| |
Follows the video core PR. fmt doesn't require casts for enum classes
anymore, so we can remove quite a few casts.
|
| |
|
|
|
| |
Completely removes all usages of the global system instance within the
services code by passing in the using system instance to the services.
|
| |
|
|
|
|
|
| |
With this, only 19 usages of the global system instance remain within
the core library.
We're almost there.
|
| | |
|
| |
|
|
|
|
|
| |
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.
Fixes #4795
|
| |
|
|
| |
We can just log out the parameters in the meantime.
|
| |
|
|
|
| |
Initialize id to a deterministic value and also mark the unreachable
cases in the switch with UNREACHABLE().
|
| | |
|
| |
|
|
| |
Stub these 2 service commands required for Animal Crossing: New Horizons Update 1.4.0
|
| | |
|
| |
|
|
|
|
| |
Closes #3533
Turns out the functions were already implemented but just never added
|
| |
|
|
|
|
| |
Keeps the service function tables up to date.
Updated based off information on SwitchBrew.
|
| |
|
|
|
|
|
|
|
|
|
| |
Allows reporting more cases where logic errors may exist, such as
implicit fallthrough cases, etc.
We currently ignore unused parameters, since we currently have many
cases where this is intentional (virtual interfaces).
While we're at it, we can also tidy up any existing code that causes
warnings. This also uncovered a few bugs as well.
|
| | |
|
| |\
| |
| | |
core/memory: Deglobalize memory management code
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Amends a few interfaces to be able to handle the migration over to the
new Memory class by passing the class by reference as a function
parameter where necessary.
Notably, within the filesystem services, this eliminates two ReadBlock()
calls by using the helper functions of HLERequestContext to do that for
us.
|
| |/
|
|
|
| |
This can trivially be an enum class rather than a regular enum, making
it more strongly typed.
|
| |\
| |
| | |
service: Update function tables
|
| | |
| |
| |
| |
| |
| | |
Keeps the function tables up to date.
Updated based off information from Switchbrew.
|
| |/
|
|
|
| |
These are fairly trivial to resolve and most of the changes entail
using RESULT_UNKNOWN over ResultCode(-1).
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Returns some misc. data about logging to help the game determine if it should log.
|
| |
|
|
| |
Allows games to log data to the SD.
|
| |\
| |
| | |
service: Update service function tables
|
| | |
| |
| |
| | |
Updates function tables based off information from SwitchBrew.
|
| | |
| |
| |
| |
| | |
IDirectory's Read() function doesn't take any input parameters. It only
uses the output parameters that we already provide.
|
| |/
|
|
|
|
|
|
| |
These indicate options that alter how a read/write is performed.
Currently we don't need to handle these, as the only one that seems to
be used is for writes, but all the custom options ever seem to do is
immediate flushing, which we already do by default.
|
| |\
| |
| | |
service/fsp_srv: Update SaveDataInfo and SaveDataDescriptor structs
|
| | |
| |
| |
| |
| | |
The unknown member here is actually padding due to being passed as a
struct. We can do the same, and remove the need to pop a padding word.
|
| | |
| |
| |
| |
| | |
I realized that I updated the documentation on SwitchBrew a while ago,
but never actually updated the structs within yuzu.
|
| |/
|
|
|
|
|
|
|
| |
In several places, we have request parsers where there's nothing to
really parse, simply because the HLE function in question operates on
buffers. In these cases we can just remove these instances altogether.
In the other cases, we can retrieve the relevant members from the parser
and at least log them out, giving them some use.
|
| |
|
|
|
| |
This just acts as a basic setter for a given PID value and performs no
further checking, so we can just store the passed in value.
|
| |
|
|
| |
Updates function tables based off information provided by SwitchBrew.
|
| |\
| |
| | |
fsp_srv: Implement IStorage::GetSize
|
| | |
| |
| |
| | |
Takes no input and returns the size as a u64. Needed by Katamari Damacy Reroll to boot.
|
| |/
|
|
|
|
|
|
|
| |
Based off RE, the backing code only ever seems to use 0-2 as the range
of values 1 being a generic log enable, with 2 indicating logging should
go to the SD card. These are used as a set of flags internally.
Given we only care about receiving the log in general, we can just
always signify that we want logging in general.
|
| |\
| |
| | |
file_sys: Implement open source system archives
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is the same behavior-wise as DeleteDirectoryRecursively, with the
only difference being that it doesn't delete the top level directory in
the hierarchy, so given:
root_dir/
- some_dir/
- File.txt
- OtherFile.txt
The end result is just:
root_dir/
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
Keeps filesystem-related error codes in one spot.
|
| | |
| |
| | |
Returns the raw NACP bytes and the raw icon bytes into a title-provided buffer. Pulls from Registration Cache for control data, returning all zeros should it not exist.
|
| | |
| |
| |
| | |
An object to read SaveDataInfo objects, which describe a unique save on the system. This implementation iterates through all the directories in the save data space and uses the paths to reconstruct the metadata.
|
| |/
|
|
| |
Needed by Checkpoint. Returns an object that can iterate through all savedata on the system.
|
| | |
|
| | |
|
| |
|
|
|
| |
Adds new functions that have been given names to the table. Information
is based off what is provided on Switchbrew.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a destructor isn't defaulted into a cpp file, it can cause the use
of forward declarations to seemingly fail to compile for non-obvious
reasons. It also allows inlining of the construction/destruction logic
all over the place where a constructor or destructor is invoked, which
can lead to code bloat. This isn't so much a worry here, given the
services won't be created and destroyed frequently.
The cause of the above mentioned non-obvious errors can be demonstrated
as follows:
------- Demonstrative example, if you know how the described error happens, skip forwards -------
Assume we have the following in the header, which we'll call "thing.h":
\#include <memory>
// Forward declaration. For example purposes, assume the definition
// of Object is in some header named "object.h"
class Object;
class Thing {
public:
// assume no constructors or destructors are specified here,
// or the constructors/destructors are defined as:
//
// Thing() = default;
// ~Thing() = default;
//
// ... Some interface member functions would be defined here
private:
std::shared_ptr<Object> obj;
};
If this header is included in a cpp file, (which we'll call "main.cpp"),
this will result in a compilation error, because even though no
destructor is specified, the destructor will still need to be generated by
the compiler because std::shared_ptr's destructor is *not* trivial (in
other words, it does something other than nothing), as std::shared_ptr's
destructor needs to do two things:
1. Decrement the shared reference count of the object being pointed to,
and if the reference count decrements to zero,
2. Free the Object instance's memory (aka deallocate the memory it's
pointing to).
And so the compiler generates the code for the destructor doing this inside main.cpp.
Now, keep in mind, the Object forward declaration is not a complete type. All it
does is tell the compiler "a type named Object exists" and allows us to
use the name in certain situations to avoid a header dependency. So the
compiler needs to generate destruction code for Object, but the compiler
doesn't know *how* to destruct it. A forward declaration doesn't tell
the compiler anything about Object's constructor or destructor. So, the
compiler will issue an error in this case because it's undefined
behavior to try and deallocate (or construct) an incomplete type and
std::shared_ptr and std::unique_ptr make sure this isn't the case
internally.
Now, if we had defaulted the destructor in "thing.cpp", where we also
include "object.h", this would never be an issue, as the destructor
would only have its code generated in one place, and it would be in a
place where the full class definition of Object would be visible to the
compiler.
---------------------- End example ----------------------------
Given these service classes are more than certainly going to change in
the future, this defaults the constructors and destructors into the
relevant cpp files to make the construction and destruction of all of
the services consistent and unlikely to run into cases where forward
declarations are indirectly causing compilation errors. It also has the
plus of avoiding the need to rebuild several services if destruction
logic changes, since it would only be necessary to recompile the single
cpp file.
|
| | |
|
| | |
|
| |
|
|
|
| |
Avoids the need to rebuild these source files if the mode header
changes.
|
| |
|
|
|
|
|
|
| |
Avoids the need to rebuild multiple source files if the filesystem code
headers change.
This also gets rid of a few instances of indirect inclusions being
relied upon
|
| | |
|
| |
|
|
|
|
| |
Given elements inserted into a vector are zeroed out, we can just copy
MAX_LEN - 1 elements and the data will already be properly null
terminated.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current way were doing it would require copying a 768 character
buffer (part of the Entry struct) to the new element in the vector.
Given it's a plain array, std::move won't eliminate that.
Instead, we can emplace an instance directly into the destination buffer
and then fill it out, avoiding the need to perform any unnecessary
copies.
Given this is done in a loop, we can request the destination to allocate
all of the necessary memory ahead of time, avoiding the need to
potentially keep reallocating over and over on every few insertions into
the vector.
|
| |
|
|
|
|
|
| |
We can avoid constructing a std::vector here by simply passing a pointer
to the original data and the size of the copy we wish to perform to the
backend's Write() function instead, avoiding copying the data where it's
otherwise not needed.
|
| |
|
|
|
|
|
|
|
|
|
| |
We were using a second std::vector as a buffer to convert another
std::vector's data into a byte sequence, however we can just use
pointers to the original data and use them directly with WriteBuffer,
which avoids copying the data at all into a separate std::vector.
We simply cast the pointers to u8* (which is allowed by the standard,
given std::uint8_t is an alias for unsigned char on platforms that we
support).
|
| |
|
|
| |
Prevents implicit conversions.
|
| |
|
|
| |
Gets rid of relying on indirect inclusions.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Previously we were just copying the data whole-sale, even if the length
was less than the total data size. This effectively makes the
actual_data vector useless, which is likely not intended.
Instead, amend this to only copy the given length amount of data.
At the same time, we can avoid zeroing out the data before using it by
passing iterators to the constructor instead of a size.
|
| |
|
|
|
|
|
|
|
|
| |
* Virtual Filesystem
* Fix delete bug and documentate
* Review fixes + other stuff
* Fix puyo regression
|
| | |
|
| |\
| |
| | |
Services/FS: Return the correct error code when trying to mount a nonexistent savedata.
|
| | | |
|
| | |
| |
| |
| | |
This reverts commit 77c684c1140f6bf3fb7d4560d06d2efb1a2ee5e2.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* Add VfsFile and VfsDirectory classes
* Finish abstract Vfs classes
* Implement RealVfsFile (computer fs backend)
* Finish RealVfsFile and RealVfsDirectory
* Finished OffsetVfsFile
* More changes
* Fix import paths
* Major refactor
* Remove double const
* Use experimental/filesystem or filesystem depending on compiler
* Port partition_filesystem
* More changes
* More Overhaul
* FSP_SRV fixes
* Fixes and testing
* Try to get filesystem to compile
* Filesystem on linux
* Remove std::filesystem and document/test
* Compile fixes
* Missing include
* Bug fixes
* Fixes
* Rename v_file and v_dir
* clang-format fix
* Rename NGLOG_* to LOG_*
* Most review changes
* Fix TODO
* Guess 'main' to be Directory by filename
|
| |/ |
|
| |
|
|
| |
convert input buffer (std::vector<u8>) to string, stripping zero chars
|
| |
|
|
|
|
| |
This makes the formatting expectations more obvious (e.g. any zero padding specified
is padding that's entirely dedicated to the value being printed, not any pretty-printing
that also gets tacked on).
|
| | |
|
| | |
|
| |
|
|
| |
Tidies up namespace declarations
|
| |
|
|
| |
- Used by Binding of Isaac.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
FS: Implemented access to the SD card
|
| | | |
|
| | |
| |
| |
| | |
Note that the filter parameter is not yet implemented.
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
