summaryrefslogtreecommitdiffstats
path: root/src/core/hle/kernel (unfollow)
Commit message (Collapse)AuthorFilesLines
2022-10-19core: hle: kernel: svc_common: Add WaitInfinite & cleanup.bunnei1-2/+5
2022-10-13kernel: remove KWritableEventLiam11-155/+88
2022-10-12k_server_session: preliminary support for userspace server sessionsLiam6-47/+341
2022-10-12Add implementation of svcCreateSessionLiam2-1/+103
2022-10-04common: remove "yuzu:" prefix from thread namesLiam3-3/+3
2022-07-27chore: make yuzu REUSE compliantAndrea Pappacoda6-18/+12
[REUSE] is a specification that aims at making file copyright information consistent, so that it can be both human and machine readable. It basically requires that all files have a header containing copyright and licensing information. When this isn't possible, like when dealing with binary assets, generated files or embedded third-party dependencies, it is permitted to insert copyright information in the `.reuse/dep5` file. Oh, and it also requires that all the licenses used in the project are present in the `LICENSES` folder, that's why the diff is so huge. This can be done automatically with `reuse download --all`. The `reuse` tool also contains a handy subcommand that analyzes the project and tells whether or not the project is (still) compliant, `reuse lint`. Following REUSE has a few advantages over the current approach: - Copyright information is easy to access for users / downstream - Files like `dist/license.md` do not need to exist anymore, as `.reuse/dep5` is used instead - `reuse lint` makes it easy to ensure that copyright information of files like binary assets / images is always accurate and up to date To add copyright information of files that didn't have it I looked up who committed what and when, for each file. As yuzu contributors do not have to sign a CLA or similar I couldn't assume that copyright ownership was of the "yuzu Emulator Project", so I used the name and/or email of the commit author instead. [REUSE]: https://reuse.software Follow-up to 01cf05bc75b1e47beb08937439f3ed9339e7b254
2022-07-25kernel: unlayer CPU interrupt handlingLiam4-61/+34
2022-07-22Project AndioKelebek14-15/+68
2022-07-15KCodeMemory: Mark virtual methods as overrideMerry1-3/+3
2022-07-15kernel: Ensure all uses of disable_count are balancedLiam3-10/+21
2022-07-15kernel: be more careful about initialization path for HLE threadsLiam2-1/+8
2022-07-15kernel: fix single-core preemption pointsLiam4-11/+14
2022-07-15kernel: fix issues with single core modeLiam7-131/+120
2022-07-15kernel: use KScheduler from mesosphereLiam9-497/+490
2022-07-10PRKelebek11-2/+1
2022-07-10Rework CoreTimingKelebek12-13/+17
2022-07-10kernel: fix usage of waiter_list in FinalizeLiam1-3/+9
2022-07-02common/fiber: make fibers easier to useLiam4-19/+7
2022-06-30cpu_manager: properly check idle on return from preemptionLiam1-0/+5
2022-06-27core: kernel: Replace instances of KPageLinkedList with KPageGroupgerman7710-63/+62
2022-06-27core: Replace all instances of ResultCode with Resultgerman7750-689/+656
2022-06-26Re-add missing `case` and braces, and trim whitespacecomex1-1/+3
2022-06-26Update src/core/hle/kernel/svc.cppcomex1-6/+14
Co-authored-by: liamwhite <liamwhite@users.noreply.github.com>
2022-06-26Support InfoType_MesosphereCurrentProcesscomex1-0/+14
2022-06-25kernel: clean up waiting implementationLiam2-4/+5
2022-06-23kernel: make current thread pointer thread localLiam11-42/+60
2022-06-22KPageTable: Remove extraneous assertMorph1-1/+0
Since start is always 0 and VAddr is unsigned, we can safely remove this assert.
2022-06-18kernel: wait for threads to stop on pauseLiam3-0/+22
2022-06-16Implement ExitProcess svcNikita Strygin1-1/+2
Currently this just stops all the emulation This works under assumption that only application will try to use ExitProcess, with services not touching it If application exits - it quite makes sense to end the emulation
2022-06-16core/debugger: memory breakpoint supportLiam3-0/+77
2022-06-16kernel: fix some uses of disable_countLiam4-14/+7
2022-06-15kernel: notify debugger on break SVCLiam1-0/+7
2022-06-15core: centralize profile scope for DynarmicLiam1-3/+0
2022-06-14kernel: implement KProcess suspensionLiam6-37/+108
2022-06-14kernel: fix passthrough of local captures in lambdaLiam1-1/+3
2022-06-14kernel: ensure class token lambda exit is unreachableLiam1-0/+1
2022-06-14kernel: fix inconsistency in AutoObjectTraits macro definitionsLiam1-4/+7
2022-06-14common: Change semantics of UNREACHABLE to unconditionally crashLiam11-23/+19
2022-06-09kernel: fix KCodeMemory initializationLiam3-26/+118
2022-06-09CpuManager: simplify pausingLiam1-3/+1
2022-06-02core/debugger: Support reading guest thread namesLiam2-0/+14
2022-06-01core/debugger: Improved stepping mechanism and misc fixesLiam1-0/+15
2022-06-01core/debugger: Implement new GDB stub debuggerLiam1-0/+4
2022-04-24kernel: svc: Replace -1ULL with 0xFFFFFFFFFFFFFFFFMorph1-1/+1
Resolves the C4146 compiler warning on MSVC.
2022-04-23general: Convert source file copyright comments over to SPDXMorph120-378/+240
This formats all copyright comments according to SPDX formatting guidelines. Additionally, this resolves the remaining GPLv2 only licensed files by relicensing them to GPLv2.0-or-later.
2022-04-16hidbus: Implement hidbus and ringcongerman772-0/+24
2022-04-13service: jit: Implement the JIT serviceLiam1-3/+8
2022-04-12core: hle: kernel: k_thread: Rework dummy thread waiting.bunnei2-28/+21
2022-04-12hle: kernel: k_spin_lock: Remove unused ThreadPause.bunnei1-28/+0
2022-04-12hle: kernel: Use std::mutex instead of spin locks for most kernel locking.bunnei7-24/+15
2022-04-09hle: kernel: Invalidate entire icache in UnmapProcessMemory and UnmapCodeMemory (fixes #8174)tech-ticks3-4/+15
2022-04-08hle: kernel: Unify and integrate reference tracking for KServerPort/KServerSession.bunnei5-13/+45
- These are not managed elsewhere, and need to be tracked and closed on emulation shutdown.
2022-04-08hle: kernel: k_server_port: Release ref-counted host emulation members on Destroy.bunnei1-0/+3
2022-04-08hle: kernel: k_auto_object: Move unregister with kernel to after Destroy.bunnei1-3/+2
- Destructor is no longer invoked, so our object counting was off.
2022-04-08hle: kernel: hle_ipc: HasSessionRequestHandler: Check if domain handler is expired rather than locking.bunnei1-1/+1
2022-04-07core/hle: Replace lock_guard with scoped_lockMerry2-10/+10
2022-04-06k_system_control: Fix data racelat9nq1-3/+3
`return distribution(gen)` is a data race between a read and a write in two threads, reported by TSan. Remove static random number generators so they aren't using the same generator.
2022-04-04k_auto_object: Fix data racelat9nq1-1/+1
Change the memory order to acqure-release when we decrement the reference count. Prevents a race with line 89 reported by TSan.
2022-04-04k_thread: Fix data racelat9nq2-3/+4
TSan reports a data race between writing at cpp:1162 and reading at h:262. Make the thread_state atomic to prevent this.
2022-04-04k_process: Fix data racelat9nq1-1/+1
TSan reported a race between thread 36 and thread 34, a read at :225 and a write at :225 respectively. Make total_proces_running_time_ticks atomic to avoid this race.
2022-04-04kernel: Fix current_process racelat9nq1-4/+4
TSan reported a race at :258 and :803, so make current_process an atomic pointer.
2022-04-04k_scheduler_lock: Fix data racelat9nq1-1/+2
TSan reports a race between the main thread and T37 during IsLockedByCurrentThread and when it's set at the end of Lock(), respectively. Set owner_thread to an atomic pointer to fix it. Co-authored-by: bunnei <bunneidev@gmail.com>
2022-04-03dynarmic: Better interruptsmerry1-0/+1
2022-04-02hle: service: Add option for service interfaces to create or use the default thread.bunnei2-3/+16
2022-04-02hle: kernel: Create a default thread for services that do not need their own host thread.bunnei2-4/+26
2022-03-26hle: kernel: k_page_table: Fix implementations of LockForCodeMemory & UnlockForCodeMemory.bunnei1-48/+12
2022-03-26hle: kernel: k_page_table: Implement LockMemoryAndOpen & UnlockMemory.bunnei2-0/+124
2022-03-26hle: kernel: svc: MapProcessMemory: Fix usage of KPageLinkedList to use physical address space.bunnei1-2/+5
2022-03-26hle: kernel: svc: CreateCodeMemory: Remove log of 'out' host pointer.bunnei1-2/+2
- This does not seem terribly useful and is inconsistent with other usage.
2022-03-26hle: kernel: k_code_memory: Fix usage of KPageLinkedList to use physical address space.bunnei1-1/+2
2022-03-26hle: kernel: k_page_table: Implement MakeAndOpenPageGroup & MakePageGroup.bunnei2-0/+83
2022-03-26hle: kernel: k_page_table: Add IsHeapPhysicalAddress method.bunnei1-0/+8
2022-03-26hle: kernel: k_page_linked_list: Add Empty method.bunnei1-0/+4
2022-03-26hle: kernel: svc: UnmapProcessCodeMemory: Fix inverted alignment check.bunnei1-1/+1
2022-03-19core: Reduce unused includesameerj14-19/+2
2022-03-18general: Reduce core.h includesameerj3-7/+22
2022-03-18KHandleTable: Optimize table entry layoutMorph2-30/+12
Since the handle type is not being used, we can reduce the amount of space each entry takes up by 4 bytes.
2022-03-15core: hle: kernel: init_slab_setup: Move CalculateSlabHeapGapSize to global namespace.bunnei1-6/+6
2022-03-15core: hle: kernel: Allocate dummy threads on host thread storage.bunnei2-8/+6
- Fixes a crash where on subsequent boots, long-lived host threads would have their dummy threads freed.
2022-03-15core: hle: kernel: Downgrade dangling objects warning to debug.bunnei1-2/+2
- It is not impossible to leak kernel objects, so this is not really any issue anymore (albeit, still interesting).
2022-03-15core: hle: kernel: Make object list container global and ensure it is reset on each emulation session.bunnei1-7/+9
2022-03-15core: hle: kernel: Remove server session tracking.bunnei4-37/+1
- These are now allocated/managed by emulated memory, so we do not need to track and free them on shutdown.
2022-03-15core: hle: kernel: k_process: Remove handle table finalize, reset page table.bunnei1-3/+3
2022-03-15core: hle: kernel: k_process: Implement thread local storage accurately.bunnei3-111/+99
2022-03-15core: hle: kernel: k_page_table: Add implementations of MapPages, UnmapPages, and FindFreeArea for TLS.bunnei2-2/+141
2022-03-15core: hle: kernel: k_slab_heap: Refresh to use guest allocations.bunnei2-125/+107
2022-03-15core: hle: kernel: Update init_slab_heap, use device memory, and add KThreadLocalPage and KPageBuffer.bunnei4-55/+92
- Refreshes our slab initialization code to latest known behavior. - Moves all guest kernel slabs into emulated device memory. - Adds KThreadLocalPage and KPageBuffer, which we will use for accurate TLS management.
2022-03-15core: hle: kernel: k_page_buffer: Add KThreadLocalPage primitive.bunnei2-0/+177
2022-03-15core: hle: kernel: k_page_buffer: Add KPageBuffer primitive.bunnei1-0/+34
2022-03-15core: hle: kernel: k_thread: Ensure host Fiber is freed.bunnei1-0/+3
2022-03-15core: hle: kernel: k_server_session: Ensure SessionRequestManager is freed.bunnei1-0/+3
2022-03-15core: hle: kernel: k_thread: Update to reflect tree changes.bunnei1-3/+3
2022-03-15core: hle: kernel: Use weak_ptr where possible for SessionRequestHandler and SessionRequestManager.bunnei5-11/+22
2022-03-15core: hle: kernel: k_memory_layout: Update kernel slab memory sizes.bunnei1-3/+3
2022-03-15core: hle: kernel: svc_types: Add ThreadLocalRegionSize.bunnei1-0/+2
2022-03-15core: hle: kernel: k_condition_variable: Update to reflect tree changes.bunnei1-1/+1
2022-03-15core: hle: kernel: k_address_arbiter: Update to reflect tree changes.bunnei1-3/+3
2022-03-09hle: service: ldr: Use deterministic addresses when mapping NROs.bunnei1-5/+3
- Instead of randomization, choose in-order addresses for where to map NROs into memory. - This results in predictable behavior when debugging and consistent behavior when reproducing issues.
2022-03-08hle: kernel: KPageTable: Improve implementations of MapCodeMemory and UnmapCodeMemory.bunnei2-47/+116
- This makes these functions more accurate to the real HOS implementations. - Fixes memory access issues in Super Smash Bros. Ultimate that occur when un/mapping NROs.
2022-02-28hle: kernel: Re-create memory layout at initialization.bunnei1-41/+43
- As this can only be derived once.
2022-02-28hle: kernel: Remove unused pool locals.bunnei1-2/+0
2022-02-28hle: kernel: k_memory_manager: Rework for latest kernel behavior.bunnei6-173/+548
- Updates the KMemoryManager implementation against latest documentation. - Reworks KMemoryLayout to be accessed throughout the kernel. - Fixes an issue with pool sizes being incorrectly reported.
2022-02-27dynarmic: Inline exclusive memory accessesmerry1-2/+2
Inlines implementation of exclusive instructions into JITted code, improving performance of applications relying heavily on these instructions. We also fastmem these instructions for additional speed, with support for appropriate recompilation on fastmem failure. An unsafe optimization to disable the intercore global_monitor is also provided, should one wish to rely solely on cmpxchg semantics for safety. See also: merryhime/dynarmic#664
2022-02-27hle: kernel: k_page_heap: GetPhysicalAddr can be const.bunnei1-2/+1
2022-02-27hle: kernel: k_page_heap: Remove superfluous consexpr.bunnei2-4/+4
2022-02-27hle: kernel: k_page_heap: Various updates and improvements.bunnei2-155/+192
- KPageHeap tracks physical addresses, not virtual addresses. - Various updates and improvements to match latest documentation for this type.
2022-02-27hle: kernel: Add initial_process.h header.bunnei1-0/+23
2022-02-27hle: kernel: board: nx: Add k_memory_layout.h header.bunnei1-0/+13
2022-02-27hle: kernel: k_system_control: Add GetRealMemorySize and update GetKernelPhysicalBaseAddress.bunnei2-1/+12
2022-02-27hle: kernel: k_memory_layout: Add GetPhysicalLinearRegion.bunnei1-0/+4
2022-02-27hle: kernel: k_memory_region_types: Update for new regions.bunnei1-1/+9
2022-02-21hle: kernel: KSystemControl: Use 6GB memory layout when "use_extended_memory_layout" setting is enabled.bunnei1-20/+4
- This uses a larger 6GB DRAM memory layout, which is useful for some mods that require more memory.
2022-02-21core: hle: kernel: Remove resource limit hack for PhysicalMemory.bunnei1-7/+0
- With prior changes, we now report the correct amount of physical memory available to the emulated process.
2022-02-21core: hle: kernel: KProcess: Pass in KResourceLimit on process creation.bunnei2-7/+6
- This allows us to have a resource limit per process, rather than use the global system resource limit.
2022-02-21core: hle: kernel: KEvent: Pass in owner KProcess on event creation.bunnei3-11/+7
- This is necessary to ensure resource limits are freed from the right process.
2022-02-21core: hle: kernel: KResourceLimit: Add a helper function for creating a KResourceLimit for a process.bunnei2-0/+22
2022-02-19fixup! core: hle: kernel: KPageTable: Improve Un/MapPhysicalMemory.bunnei1-22/+2
2022-02-19core: hle: kernel: KPageTable: Fix UnmapPages.bunnei1-3/+2
- Fixes a logic bug in KPageTable::UnmapPages.
2022-02-19core: hle: kernel: KPageTable: Improve Un/MapPhysicalMemory.bunnei1-107/+432
- Improves the implementations of MapPhysicalMemory and UnmapPhysicalMemory to more closely reflect latest HOS.
2022-02-15kernel: svc: Add OutputDebugString32, CreateCodeMemory32, ControlCodeMemory32Sergi Granell2-4/+40
Very straightforward, they are just wrappers to the 64-bit version of the SVC.
2022-02-09svc: Set unique names for function tablesNarr the Reg1-77/+77
2022-02-09hle: kernel: KCodeMemory: Remove unused QueryMemory.bunnei1-1/+0
2022-02-09hle: kernel: KCodeMemory: Correct m_page_group number of pages.bunnei1-2/+3
Credits to @xerpi for finding this issue and pointing it out on #7519.
2022-02-04service: pm: Implement AtmosphereGetProcessInfotech-ticks1-1/+1
2022-02-02general: Replace NonCopyable struct with equivalentsLioncash6-100/+134
2022-02-02general: Move deleted copy/move constructor/assignment operators to public interfaceLioncash3-8/+6
This allows for better compiler errors, where the compiler will state a copy or move couldn't occur due to the relevant function being deleted. Previously a compiler would warn about the relevant function not being accessible (which, while true, isn't as informative as it could be).
2022-02-02hle: kernel: KPageTable: Migrate locks to KScopedLightLock.bunnei2-34/+46
- More accurately reflects real kernel behavior by using guest locks.
2022-02-01svc: Add 32 bit SynchronizePreemptionStateNarr the Reg1-1/+1
Used by Espgaluda II
2022-01-27hle: kernel: KScheduler: Fix deadlock with core waiting for a thread lock that has migrated.bunnei2-23/+24
- Previously, it was possible for a thread migration to occur from core A to core B. - Next, core B waits on a guest lock that must be released by a thread queued for core A. - Meanwhile, core A is still waiting on the core B's current thread lock - resulting in a deadlock. - Fix this by try-locking the thread lock. - Fixes softlocks in FF8 and Pokemon Legends Arceus.
2022-01-24kernel/k_affinity_mask: Remove duplicated assertLioncash1-2/+0
This is already checked inside GetCoreBit()
2022-01-23hle: kernel: KThread: Improve Increment/Decrement RunningThreadCount.bunnei3-24/+21
- Previously implementation was incorrect, and would occasionally underflow.
2022-01-23core: hle: kernel: KPageTable: Various improvements to MapPages and UnmapPages.bunnei1-22/+25
2022-01-23core: hle: kernel: KPageTable: MapProcessCode: Various cleanup.bunnei1-11/+12
2022-01-23core: hle: kernel: KPageTable: ReserveTransferMemory: Various cleanup.bunnei1-6/+6
2022-01-23core: hle: kernel: KPageTable: ResetTransferMemory: Various cleanup.bunnei1-6/+5
2022-01-23core: hle: kernel: KPageTable: SetMemoryAttribute: Various cleanup.bunnei1-2/+3
2022-01-22core: hle: kernel: KPageTable: Assert valid address on GetPhysicalAddr.bunnei1-1/+3
2022-01-22core: hle: kernel: KPageTable: Operate: Assert lock ownership.bunnei1-2/+2
2022-01-22core: hle: kernel: KPageTable: SetHeapSize: Cleanup & take physical memory lock.bunnei1-4/+7
2022-01-22core: hle: kernel: Refactor Un/MapPhysicalMemory to remove unnecessary methods.bunnei2-50/+39
2022-01-22core: hle: kernel: Rename Un/Map to Un/MapMeory.bunnei3-7/+6
2022-01-22hle: kernel: KThread: Ensure host (dummy) threads block on locking.bunnei4-0/+89
- But do not enter the priority queue, as otherwise they will be scheduled. - Allows dummy threads to use guest synchronization primitives.
2022-01-21hle: kernel: Remove redundant tracking of dummy threads.bunnei1-9/+3
- These are already tracked by kernel's registered_objects member.
2022-01-21hle: kernel: KThread: DummyThread can be waited, ensure wait_queue is not nullptr.bunnei1-6/+6
2022-01-21hle: kernel: KThread: Decrease DummyThread priority to ensure it is never scheduled.bunnei3-2/+5
2022-01-21hle: kernel: service_thread: Ensure dummy thread is closed & destroyed on thread exit.bunnei1-0/+5
2022-01-21hle: kernel: KServerSession: Remove hack for CompleteSyncRequest.bunnei1-11/+0
- This does not appear to be necessary anymore.
2022-01-21hle: kernel: KServerSession: Simplify CompleteSyncRequest EndWait.bunnei2-12/+2
- Considering is_thread_waiting is never set, so we can remove IsThreadWaiting. - KThread::EndWait will take the scheduler lock, so we can remove the redundant lock.
2022-01-21hle: kernel: KThread: Ensure dummy threads never call EndWait.bunnei1-0/+5
- These are only used by host threads for locking and will never have a wait_queue.
2022-01-21hle: kernel: KScheduler: Ensure dummy threads are never scheduled.bunnei1-0/+5
- These are only used by host threads for locking.
2022-01-21hle: kernel: KThread: Rename thread_type_for_debugging -> thread_type.bunnei2-4/+4
- This will be used to ensure that we do not schedule dummy threads.
2022-01-17hle: remove no-op codeValeri1-2/+0
Found by static analysis with PVS-Studio. Nobody seems to really know what was it doing there.
2022-01-15hle: kernel: k_memory_manager: Clear pages on allocation & free.bunnei5-16/+34
- Heap pages should be zero'd. - Also explicitly passed along heap allocation option.
2022-01-15core: hle: kernel: KThread: Integrate with KWorkerTask and implement DoWorkerTaskImpl.bunnei2-2/+28
- This is used to terminate a thread asynchronously after it has been exited. - This fixes a crash that can occur in Pokemon Sword/Shield because a thread is incorrectly closed on svcExitThread, then, the thread is destroyed on svcCloseHandle while it is still scheduled. - Instead, we now wait for the thread to no longer be scheduled on all cores before destroying it from KWorkerTaskManager, which is accurate to HOS behavior.
2022-01-15core: hle: kernel: KProcess: Integrate with KWorkerTask and add unimplemented DoWorkerTaskImpl.bunnei2-3/+9
2022-01-15core: hle: kernel: KThread: Replace Suspend with UpdateState & various updates.bunnei2-33/+26
- This makes our implementations of these more closely match HOS.
2022-01-15core: hle: kernel: Instantiate a kernel instance of KWorkerTaskManager.bunnei2-0/+18
2022-01-15core: hle: kernel: Add KWorkerTask and KWorkerTaskManager.bunnei3-0/+93
- These primitives are used to dispatch asynchronous kernel tasks from KThread and KProcess.
2022-01-15hle: kernel: Fix service_threads access to be thread safe V2.bunnei1-12/+11
- PR #7699 attempted to fix CreateServiceThread and ReleaseServiceThread to be thread safe, but inadvertently introduced a possible dead-lock. - With this PR, we use a worker thread to manage the service thread list, allowing it only to be accessed by a single thread, and guaranteeing threads will not destroy themselves. - Fixes a rare crash in Pokemon Sword/Shield, I've now run this game for ~12 hours non-stop and am quite confident this is a good solution for this issue.
2022-01-14hle: kernel: Fix service_threads access to be thread safe.bunnei1-7/+27
- CreateServiceThread and ReleaseServiceThread can be accessed by different threads, uses a lock to make this thread safe. - Fixes a rare crash in Pokemon Sword/Shield that can occur when a new service thread is being created while an old one is being destroyed.
2022-01-12hle: kernel: k_page_table: Update SetProcessMemoryPermission.bunnei5-42/+64
2022-01-12hle: kernel: k_page_table: ReadAndWrite -> UserReadWrite.bunnei2-17/+17
2022-01-12hle: kernel: k_page_table: Rename *ProcessCodeMemory -> *CodeMemory.bunnei3-6/+6
2022-01-08core: hle: kernel: svc: Updates to SetMemoryAttribute and SetMemoryPermission.bunnei3-45/+46
2022-01-08core: hle: kernel: k_page_table: Update CheckMemoryState.bunnei4-116/+166
2021-12-31core: hle: kernel: Implement thread pinning.bunnei9-14/+138
- We largely had the mechanics in place for thread pinning, this change hooks these up. - Validated with tests https://github.com/Atmosphere-NX/Atmosphere/blob/master/tests/TestSvc/source/test_thread_pinning.cpp.
2021-12-28core: hle: kernel: Updated implementation of svcSetHeapSize.bunnei6-83/+141
- Updates our svcSetHeapSize with latest HOS, furthermore allowing heap size to properly be extended/shrunk. - Validated with tests https://github.com/Atmosphere-NX/Atmosphere/blob/master/tests/TestSvc/source/test_set_heap_size.cpp.
2021-12-23core: hle: kernel: Implement SetMemoryPermission.bunnei4-1/+67
- Not seen in any games yet, but validated with kernel tests.
2021-12-23 core: hle: kernel: KThread: X18 should be a cryptographically random number.bunnei1-0/+2
- This was added with firmware 11.0.0 (https://switchbrew.org/wiki/11.0.0). - X18 is OR'd by kernel with 1, to make sure it is odd.
2021-12-22hle: kernel: svc: GetInfo: Fix error checking with IdleTickCount.bunnei1-14/+9
- Enforce tha the supplied handle is invalid, not valid. - This gets Witcher 3 booting.
2021-12-19kernel: Manually destroy the current process during shut downameerj1-1/+4
Avoids a memory leak.
2021-12-18core: hle: Remove global HLE lock.bunnei2-11/+0
- This was added early on as a hack to protect against some concurrency issues. - It's not clear that this serves any purpose anymore, and if it does, individual components should be fixed rather than using a global recursive mutex.
2021-12-13Remove erroneous #pragma onceValeri1-2/+0
2021-12-07Update k_code_memory.hitsmeft241-6/+6
2021-12-07make KCodeMemory::GetSourceAddress constitsmeft241-1/+1
Co-authored-by: Mai M. <mathew1800@gmail.com>
2021-12-07hle: kernel k_scheduler: EnableScheduling: Remove redundant GetCurrentThreadPointer calls.bunnei1-3/+5
2021-12-07hle: kernel k_process: Remove unnecessary .at usage with thread pinning methods.bunnei1-3/+3
2021-12-07hle: kernel: Remove unnecessary virtual specifier on NotifyAvailable.bunnei1-2/+2
2021-12-07hle: kernel: Remove unnecessary virtual specifier on EndWait.bunnei1-1/+1
2021-12-07hle: kernel: k_light_condition_variable: Revert unnecessary license comment changes.bunnei1-1/+1
2021-12-07hle: kernel: k_condition_variable: Revert unnecessary style changes.bunnei1-2/+2
2021-12-07hle: kernel: Remove unnecessary virtual specifier on CancelWait.bunnei6-14/+14
2021-12-07hle: kernel: service_thread: Force stop threads on destruction.bunnei1-1/+7
2021-12-07hle: kernel: k_light_lock: Implement CancelWait.bunnei1-5/+10
- Fixes a crash in Megadimension Neptunia VII.
2021-12-07hle: kernel: service_thread: Use std::jthread.bunnei1-18/+19
- Fixes a potential deadlock on service thread shutdown.
2021-12-07hle: kernel: k_thread: Skip reschedule on DisableDispatch with SC.bunnei1-0/+5
2021-12-07hle: kernel: k_thread: Rename sleeping_queue -> wait_queue.bunnei2-17/+13
2021-12-07hle: kernel: svc: Fix deadlock that can occur with single core.bunnei1-10/+8
2021-12-07hle: kernel: k_thread: Treat dummy threads as a special type.bunnei2-1/+4
2021-12-07hle: kernel: fix timing on thread preemptionFernandoS271-4/+2
2021-12-07hle: kernel: fix scheduling ops from HLE host thread.FernandoS271-3/+3
2021-12-07hle: kernel: Add a flag for indicating that the kernel is currently shutting down.bunnei6-0/+49
2021-12-07hle: kernel: KSynchronizationObject: Fix variable shadowing.bunnei1-8/+8
2021-12-07hle: kernel: Cleanup to match coding style.bunnei6-26/+21
2021-12-07hle: kernel: KProcess: Improvements for thread pinning.bunnei2-8/+26
2021-12-07hle: kernel: KThreadQueue: Remove deprecated code.bunnei1-63/+0
2021-12-07hle: kernel: KConditionVariable: Various updates & simplifications.bunnei2-121/+65
2021-12-07hle: kernel: KThread: Migrate to updated KThreadQueue (part 2).bunnei1-29/+19
2021-12-07hle: kernel: KThread: Migrate to updated KThreadQueue (part 1).bunnei3-60/+71
2021-12-07hle: kernel: KConditionVariable: Migrate to updated KThreadQueue.bunnei1-12/+55
2021-12-07hle: kernel: KServerSession: Migrate to updated KThreadQueue.bunnei2-5/+11
2021-12-07hle: kernel: KLightConditionVariable: Migrate to updated KThreadQueue.bunnei2-54/+86
2021-12-07hle: kernel: KLightLock: Migrate to updated KThreadQueue.bunnei2-35/+36
2021-12-07hle: kernel: KAddressArbiter: Migrate to updated KThreadQueue.bunnei1-43/+39
2021-12-07hle: kernel: KThread: Remove tracking of sync object from threads.bunnei6-41/+21
2021-12-07hle: kernel: Update KThreadQueue and migrate KSynchronizationObject.bunnei7-75/+250
2021-12-07core: hle: kernel: Disable dispatch count tracking on single core.bunnei2-4/+13
- This would have limited value, and would be a mess to handle properly.
2021-12-07core: hle: kernel: k_thread: Mark KScopedDisableDispatch as nodiscard.bunnei1-1/+1
2021-12-07core: hle: kernel: k_auto_object: Add GetName method.bunnei1-0/+4
- Useful purely for debugging.
2021-12-07core: hle: kernel: DisableDispatch on suspend threads.bunnei1-0/+3
2021-12-07core: hle: kernel: k_scheduler: Improve DisableScheduling and EnableScheduling.bunnei1-14/+9
2021-12-07core: hle: kernel: Use CurrentPhysicalCoreIndex as appropriate.bunnei1-6/+2
2021-12-07core: hle: kernel: k_scheduler: Remove unnecessary MakeCurrentProcess.bunnei1-5/+0
2021-12-07core: hle: kernel: k_scheduler: Improve ScheduleImpl.bunnei1-6/+7
2021-12-07core: hle: kernel: k_scheduler: Improve Unload.bunnei1-17/+29
2021-12-07core: hle: kernel: k_process: DisableDispatch on main thread.bunnei1-0/+1
2021-12-07core: hle: kernel: k_handle_table: Use KScopedDisableDispatch as necessary.bunnei2-0/+8
2021-12-07core: hle: kernel: k_thread: Add KScopedDisableDispatch.bunnei2-1/+47
2021-12-07core: hle: kernel: Ensure idle threads are closed before destroying scheduler.bunnei3-24/+22
2021-12-07core: hle: kernel: Reflect non-emulated threads as core 3.bunnei5-5/+17
2021-12-06fix formattingitsmeft241-1/+6
2021-12-06move private members below public membersitsmeft241-10/+11
2021-12-06fix formattingitsmeft241-4/+1
2021-12-06fix formattingitsmeft241-1/+1
Co-authored-by: Mai M. <mathew1800@gmail.com>
2021-12-06fix formattingitsmeft242-2/+2
2021-12-06Remove unnecessary includesitsmeft242-50/+13
2021-12-05Add copyright noticeitsmeft242-0/+8
2021-12-05kernel: svc: Implement Map/UnmapProcessMemory and Create/ControlCodeMemoryitsmeft2411-7/+636
Used by Skyline modding framework
2021-11-21kernel: svc: Move all IsValid functions to an anonymous namespaceMorph1-3/+15
2021-11-21kernel: svc: Implement SetProcessMemoryPermissionMorph1-1/+41
- Used by Skyline modding framework
2021-11-21kernel: KPageTable: Rename SetCodeMemoryPermission to SetProcessMemoryPermissionMorph3-4/+4
2021-11-18Fix crash on exit due to static scoped dummy threadsAdam Heinermann1-8/+14
2021-11-04general: Rename GetTitleID to GetProgramIDMorph2-3/+3
2021-11-04core: Fix transitive include build errorsameerj2-0/+4
2021-11-04core: Remove unused includesameerj37-87/+0
2021-11-03svc: Correct WaitSynchronization num_handles param typeMorph2-4/+4
num_handles is a s32
2021-11-02general: Remove MakeResult helpersMorph1-2/+2
This is made obsolete by the presence of implicit constructors.
2021-10-27Fix dangling kernel objects when exitingFeng Chen2-11/+13
2021-10-27Revert PR7009Feng Chen1-2/+2
2021-10-27Fix memory leakFeng Chen4-0/+38
2021-10-16SVC: Implement svcInfo:IdleTickCountFernando Sahmkow2-0/+22
Used by the Witcher 3
2021-10-13KPageTable: Perform ranged invalidation when unmapping code memoryMorph1-0/+2
Co-Authored-By: Fernando S. <1731197+FernandoS27@users.noreply.github.com>
2021-10-07kernel: hle_ipc: Foward declare KAutoObjectMorph2-1/+2
2021-10-02common/logging: Move Log::Entry declaration to a separate headerameerj1-0/+2
This reduces the load of requiring to include std::chrono in all files which include log.h
2021-09-29style: Remove extra space preceding the :: operatorMorph1-1/+1
2021-09-29Fix KShareMemory object leakFeng Chen4-3/+105
2021-09-25Fix KScopedAutoObject object leak when SendSyncRequestFeng Chen1-6/+8
2021-09-24general: Update style to clang-format-12ameerj4-27/+19
2021-09-11kernel: Add missing <functional> includeMorph1-0/+1
2021-08-26Revert "kernel: Various improvements to scheduler"bunnei13-151/+74
2021-08-19Fix check is thread current in GetThreadContextValeri1-1/+1
Misplaced break made it only check for the first core.
2021-08-16kernel: Optimize GetHostThreadIDBreadFish641-10/+13
2021-08-14core: hle: kernel: Disable dispatch count tracking on single core.bunnei2-4/+11
- This would have limited value, and would be a mess to handle properly.
2021-08-07core: hle: kernel: k_thread: Mark KScopedDisableDispatch as nodiscard.bunnei1-1/+1
2021-08-07core: hle: kernel: k_auto_object: Add GetName method.bunnei1-0/+4
- Useful purely for debugging.
2021-08-07core: hle: kernel: DisableDispatch on suspend threads.bunnei1-0/+3
2021-08-07core: hle: kernel: k_scheduler: Improve DisableScheduling and EnableScheduling.bunnei1-14/+9
2021-08-07core: hle: kernel: Use CurrentPhysicalCoreIndex as appropriate.bunnei1-6/+2
2021-08-07core: hle: kernel: k_scheduler: Remove unnecessary MakeCurrentProcess.bunnei1-5/+0
2021-08-07core: hle: kernel: k_scheduler: Improve ScheduleImpl.bunnei1-6/+7
2021-08-07core: hle: kernel: k_scheduler: Improve Unload.bunnei1-17/+29
2021-08-07core: hle: kernel: k_process: DisableDispatch on main thread.bunnei1-0/+1
2021-08-07core: hle: kernel: k_handle_table: Use KScopedDisableDispatch as necessary.bunnei2-0/+8
2021-08-07core: hle: kernel: k_thread: Add KScopedDisableDispatch.bunnei2-1/+47
2021-08-07core: hle: kernel: Ensure idle threads are closed before destroying scheduler.bunnei3-24/+22
2021-08-07core: hle: kernel: Reflect non-emulated threads as core 3.bunnei5-4/+15
2021-07-21hle: kernel: svc: Remove part of ExitProcess.bunnei1-5/+0
- ExitProcess is not actually implemented either way, and this needs more work before we implement.
2021-07-21hle: kernel: Track and release server sessions, and protect methods with locks.bunnei4-13/+82
2021-07-21hle: kernel: KProcess: Change process termination assert to a warning.bunnei1-1/+1
- Since we do not implement multiprocess right now, this should not be a crashing assert.
2021-07-21hle: kernel: Ensure current running process is closed.bunnei1-5/+6
2021-07-21hle: kernel: Ensure global handle table is finalized before closing.bunnei1-0/+1
2021-07-21kernel: svc: ConnectToNamedPort: Close extra reference to port.bunnei1-0/+1
2021-07-21hle: kernel: k_process: Close the handle table on shutdown.bunnei1-0/+3
2021-07-21hle: kernel: k_process: Close main thread reference after it is inserted into handle table.bunnei1-0/+3
2021-07-21hle: kernel: Ensure global handle table is initialized.bunnei1-0/+1
2021-07-21hle: kernel: Provide methods for tracking dangling kernel objects.bunnei4-2/+43
2021-06-24common: Replace common_sizes into user-literalsWunkolo7-58/+74
Removes common_sizes.h in favor of having `_KiB`, `_MiB`, `_GiB`, etc user-literals within literals.h. To keep the global namespace clean, users will have to use: ``` using namespace Common::Literals; ``` to access these literals.
2021-06-18kernel: Fix missing peak set in KResourceLimit::SetLimitValueMorph1-0/+1
2021-06-11kernel: Unconditionally set thread state when appropriateMorph2-23/+12
2021-06-11kernel: KLightConditionVariable: Update implementation to 12.xMorph2-14/+31
Updates the implementation of KLightConditionVariable to FW 12.x
2021-06-10hle: kernel: KClientPort: Add an assert for session count.bunnei1-0/+3
- Prevents us from over decrementing num_sessions.
2021-06-10hle: service: sm: Fix GetService setup of session & port.bunnei1-1/+1
2021-06-10hle: kernel: KServerSession: Fix client disconnected.bunnei2-8/+7
- Prevents a cloned session's handler from being overwritten by another disconnected session. - Fixes session handler nullptr asserts with Pokemon Sword & Shield.
2021-06-10kernel: svc: Add missing error check to CancelSynchronization.bunnei1-2/+2
- Avoids a potential crash if the handle is invalid, and also makes this code accurate to real kernel behavior.
2021-06-08hle: kernel: KServerSession: Work-around scenario where session is closed too early.bunnei1-7/+24
2021-06-08hle: kernel: hle_ipc: Ensure SessionRequestHandler is valid.bunnei3-5/+26
2021-06-08hle: kernel: Remove service thread manager and use weak_ptr.bunnei3-18/+8
- We no longer need to queue up service threads to be destroyed. - Fixes a race condition where a thread could be destroyed too early, which caused a crash in Pokemon Sword/Shield.
2021-06-07hle: kernel: KServerSession: Use ASSERT_MSG where appropriate.bunnei1-1/+1
2021-06-07hle: kernel: k_server_session: Return service thread by strong pointer.bunnei2-4/+4
2021-06-07hle: kernel: k_server_session: Ensure service thread is valid before dereference.bunnei1-1/+3
2021-06-07hle: kernel: hle_ipc: Use default destructor for SessionRequestManager.bunnei1-1/+1
2021-06-07hle: kernel: KAutoObjectWithListContainer: Use boost::instrusive::rbtree.bunnei11-22/+26
- Fixes some crashes introduced by our common intrusive red/black tree impl.
2021-06-05hle: kernel: Refactor to allocate a ServiceThread per service handler.bunnei8-32/+58
- Previously, we would allocate a thread per session, which adds new threads on CloneCurrentObject. - This results in race conditions with N sessions queuing requests to the same service interface. - Fixes Pokken Tournament DX crashes/softlocks, which were regressed by #6347.
2021-06-02general: Replace RESULT_UNKNOWN with ResultUnknownMorph1-2/+2
Transition to PascalCase for result names.
2021-06-02general: Replace RESULT_SUCCESS with ResultSuccessMorph24-157/+157
Transition to PascalCase for result names.
2021-05-29k_class_token: Use variable templates where applicableLioncash1-43/+36
Same behavior, less code.
2021-05-29kernel: Add missing override specifiersLioncash15-53/+48
Over the course of the kernel refactoring a tiny bit of missing overrides slipped through review, so we can add these. While we're at it, we can remove redundant virtual keywords where applicable as well.
2021-05-29Fix two GCC 11 warnings: Unneeded copies.Markus Wick1-1/+1
std::move created an unneeded copy. iterating without reference also created copies.
2021-05-29k_thread: Move dereference after null check in Initialize()Lioncash1-5/+5
Prevents a -Wnonnull warning on GCC.
2021-05-29hle: kernel: KSlabHeap: Allow host or guest allocations.bunnei2-11/+191
- Use host allocations for kernel memory, as this is not properly emulated yet. - Use guest allocations for TLS, as this needs to be backed by DeviceMemory.
2021-05-27core/arm_interface: Call SVC after end of dynarmic block.Markus Wick1-1/+0
So we can modify all of dynarmic states within SVC without ExceptionalExit. Especially as the ExceptionalExit hack is dropped on upstream dynarmic.
2021-05-25kernel: process_capability: Add MapRegion capabilityMorph2-0/+12
- Used by nx-hbloader
2021-05-21hle: kernel: service_thread: Take reference to KServerSession on service request.bunnei1-9/+5
2021-05-21hle: kernel: k_port: Use AcceptSession to ensure SessionList state is correct.bunnei1-1/+1
- Fixes a use-after-free, work-around until we fixup session/port management.
2021-05-21hle: kernel: Use host memory allocations for KSlabMemory.bunnei2-144/+20
- There are some issues with the current workaround, we will just use host memory until we have a complete kernel memory implementation.
2021-05-21Revert "WORKAROUND: Do not use slab heap while we track down issues with resource management."bunnei1-2/+2
This reverts commit f2c26443f85a3c3fd43137509368ba5c7ab80ee7.
2021-05-21hle: kernel: hle_ipc: Simplify incoming/outgoing move/copy/domain objects.bunnei2-42/+17
2021-05-21hle: kernel: Implement CloneCurrentObject and improve session management.bunnei8-73/+130
2021-05-21Revert "WORKAROUND: temp. disable session resource limits while we work out issues"bunnei2-5/+5
This reverts commit fc086f93b2165b5c210cb7dcd6c18ebe17f1fd7b.
2021-05-18KTransferMemory: Return size instead of size * PageSize in GetSize()Morph1-1/+1
size is already the size in bytes. We do not need to multiply it by the page size
2021-05-16hle_ipc: unsigned -> u32Morph1-7/+7
This is more concise and consistent with the rest of the codebase.
2021-05-16hle_ipc: Add a getter for PIDMorph2-2/+7
2021-05-16core: Make variable shadowing a compile-time errorLioncash16-32/+33
Now that we have most of core free of shadowing, we can enable the warning as an error to catch anything that may be remaining and also eliminate this class of logic bug entirely.
2021-05-11hle: kernel: hle_ipc: Fix outgoing IPC response size calculation.bunnei2-1/+14
2021-05-11WORKAROUND: temp. disable session resource limits while we work out issuesbunnei2-5/+5
2021-05-11WORKAROUND: Do not use slab heap while we track down issues with resource management.bunnei1-2/+2
2021-05-11hle: kernel: hle_ipc: Improve IPC code and add initial support for TIPC.bunnei2-81/+57
- Fixes our move handles implementation to actually move objects. - Simplifies the traditional IPC path.
2021-05-11hle: service: Implement IPC::CommandType::Close.bunnei1-2/+2
- This was not actually closing sessions before.
2021-05-11hle: kernel: svc: Update ConnectToNamedPort to use new CreateNamedServicePort interface.bunnei1-4/+3
2021-05-11hle: kernel: Implement named service ports using service interface factory.bunnei2-17/+22
- This allows us to create a new interface each time ConnectToNamedPort is called, removing the assumption that these are static.
2021-05-11hle: kernel: KClientPort: Cleanup comment format.bunnei1-1/+1
2021-05-11hle: kernel: Further cleanup and add TIPC helpers.bunnei2-4/+12
2021-05-11hle: ipc_helpers: Update IPC response generation for TIPC.bunnei1-2/+8
2021-05-09kernel: Delete unused filesgerman772-151/+0
2021-05-08kernel: Eliminate variable shadowingLioncash39-130/+128
Now that the large kernel refactor is merged, we can eliminate the remaining variable shadowing cases.
2021-05-06hle: kernel: KPageTable: CanContain should not be constexpr.bunnei2-2/+2
2021-05-06hle: kernel: Move slab resource counts to Kernel.bunnei4-33/+52
2021-05-06fixup! hle: kernel: Migrate more of KThread to KAutoObject.bunnei1-1/+1
2021-05-06kernel: svc: Remove unused RetrieveResourceLimitValue function.bunnei1-32/+0
2021-05-06hle: kernel: Fix un/sign mismatch errors with NUM_CPU_CORES.bunnei1-3/+3
2021-05-06fixup! hle: kernel: Add initial impl. of slab setup.bunnei1-6/+2
2021-05-06fixup! hle: kernel: Migrate to KHandleTable.bunnei1-0/+3
2021-05-06fixup! hle: kernel: Migrate more of KThread to KAutoObject.bunnei1-7/+0
2021-05-06fixup! hle: kernel: Migrate KReadableEvent and KWritableEvent to KAutoObject.bunnei2-2/+2
2021-05-06fixup! hle: kernel: Migrate to KHandleTable.bunnei1-1/+1
2021-05-06fixup! hle: kernel: Add initial impl. of KLinkedList.bunnei1-12/+12
2021-05-06fixup! hle: kernel: Migrate to KHandleTable.bunnei1-1/+1
2021-05-06fixup! hle: kernel: Migrate KPort, KClientPort, and KServerPort to KAutoObject.bunnei1-1/+1
2021-05-06fixup! hle: kernel: Migrate KSession, KClientSession, and KServerSession to KAutoObject.bunnei3-22/+28
2021-05-06fixup! hle: kernel: Migrate KSession, KClientSession, and KServerSession to KAutoObject.bunnei1-1/+1
2021-05-06fixup! hle: kernel: Migrate KPort, KClientPort, and KServerPort to KAutoObject.bunnei1-1/+1
2021-05-06fixup! hle: kernel: Migrate to KHandleTable.bunnei1-60/+58
2021-05-06fixup! hle: kernel: Add initial impl. of KAutoObjectWithListContainer.bunnei1-11/+9
2021-05-06fixup! hle: kernel: Add initial impl. of KAutoObjectWithListContainer.bunnei1-9/+2
2021-05-06fixup! hle: kernel: Add initial impl. of KAutoObject.bunnei1-46/+46
2021-05-06fixup! hle: kernel: Add initial impl. of KAutoObject.bunnei1-1/+1
2021-05-06fixup! hle: kernel: Add initial impl. of slab setup.bunnei1-8/+8
2021-05-06common: Rename NON_COPYABLE/NON_MOVABLE with YUZU_ prefix.bunnei3-7/+7
2021-05-06fixup! hle: kernel: Rename Process to KProcess.bunnei1-1/+1
2021-05-06fixup! hle: kernel: Migrate to KHandleTable.bunnei1-1/+1
2021-05-06fixup! hle: kernel: Improve MapSharedMemory and implement UnmapSharedMemory.bunnei1-3/+3
2021-05-06hle: kernel: svc: ConnectToNamedPort: Use KHandleTable::Reserve.bunnei1-3/+8
2021-05-06hle: kernel: Migrate to KHandleTable.bunnei19-375/+496
2021-05-06hle: kernel: KClassToken: Ensure class tokens are correct.bunnei1-1/+127
2021-05-06hle: kernel: Improve MapSharedMemory and implement UnmapSharedMemory.bunnei10-95/+210
2021-05-06hle: kernel: Rename Process to KProcess.bunnei30-135/+136
2021-05-06hle: kernel: Remove deprecated Object class.bunnei26-379/+13
2021-05-06hle: kernel: Do not shutdown twice on emulator close.bunnei1-3/+1
2021-05-06hle: kernel: Cleanup shutdown of persistent kernel objects.bunnei1-14/+12
2021-05-06hle: kernel: Migrate KPort, KClientPort, and KServerPort to KAutoObject.bunnei17-138/+413
2021-05-06hle: kernel: Migrate KServerPort to KAutoObject.bunnei4-37/+53
2021-05-06hle: kernel: Migrate KClientPort to KAutoObject.bunnei9-47/+72
2021-05-06hle: kernel: HandleTable: Remove deprecated APIs.bunnei5-106/+23
2021-05-06hle: kernel: Migrate KResourceLimit to KAutoObject.bunnei13-122/+197
2021-05-06hle: kernel: svc: Migrate WaitSynchronization.bunnei2-47/+78
2021-05-06hle: kernel: svc: Use new handle table API for Process.bunnei2-16/+17
2021-05-06hle: kernel: Migrate KTransferMemory to KAutoObject.bunnei8-53/+192
2021-05-06hle: kernel: Migrate KSession, KClientSession, and KServerSession to KAutoObject.bunnei21-316/+384
2021-05-06hle: kernel: svc: Migrate GetThreadContext, GetThreadCoreMask.bunnei1-2/+59
2021-05-06hle: kernel: svc: Migrate GetProcessId, CancelSynchronization, SetThreadActivity.bunnei1-13/+67
2021-05-06hle: kernel: KThread: Remove incorrect resource release.bunnei1-2/+1
2021-05-06hle: kernel: svc_results: Update naming..bunnei8-42/+43
2021-05-06hle: kernel: KThread: Add missing resource hint release.bunnei1-1/+1
2021-05-06hle: kernel: Migrate KReadableEvent and KWritableEvent to KAutoObject.bunnei9-107/+129
2021-05-06hle: kernel: Move slab heaps to their own container.bunnei2-10/+16
2021-05-06hle: kernel: Refactor several threads/events/sharedmemory to use slab heaps.bunnei6-51/+41
2021-05-06hle: kernel: Move slab heap management to KernelCore.bunnei7-64/+106
2021-05-06hle: kernel: Ensure all kernel objects with KAutoObject are properly created.bunnei2-0/+8
2021-05-06hle: kernel: Use unique_ptr for suspend and dummy threads.bunnei1-8/+8
2021-05-06hle: kernel: Migrate KEvent to KAutoObject.bunnei6-19/+56
2021-05-06hle: kernel: Migrate KSharedMemory to KAutoObject.bunnei9-72/+116
2021-05-06hle: kernel: Migrate KProcess to KAutoObject.bunnei11-47/+68
2021-05-06hle: kernel: Refactor IPC interfaces to not use std::shared_ptr.bunnei5-17/+22
2021-05-06hle: kernel: Migrate more of KThread to KAutoObject.bunnei16-289/+442
2021-05-06hle: kernel: svc: Migrate GetThreadPriority, StartThread, and ExitThread.bunnei1-21/+12
2021-05-06hle: kernel: svc: Migrate CreateThread.bunnei1-14/+21
2021-05-06hle: kernel: Migrate idle threads.bunnei2-13/+9
2021-05-06hle: kernel: Migrate KThread to KAutoObject.bunnei2-109/+91
2021-05-06hle: kernel: Add initial impl. of slab setup.bunnei2-0/+225
2021-05-06hle: kernel: Refactor out various KThread std::shared_ptr usage.bunnei9-54/+26
2021-05-06hle: kernel: Add initial impl. of KLinkedList.bunnei1-0/+233
2021-05-06hle: kernel: Add initial impl. of KSlabAllocated.bunnei1-0/+152
2021-05-06hle: kernel: Add initial impl. of KAutoObjectWithListContainer.bunnei2-0/+107
2021-05-06hle: kernel: Add initial impl. of KAutoObject.bunnei2-0/+304
2021-04-24hid: Implement SevenSixAxis and ConsoleSixAxisSensorgerman772-0/+7
2021-04-15hle_ipc: Add helper functions to get copy/move handlesMorph2-2/+16
2021-04-15common: Move settings to common from core.bunnei1-1/+1
- Removes a dependency on core and input_common from common.
2021-04-14k_resource_limit: Minor cleanup of member variables/headersameerj4-21/+13
2021-04-12kernel/process: Replace process resource limit instance with the kernel's resource limitameerj2-38/+27
This commit addresses the inaccurate behavior of kernel processes creating their own resource limit, rather than utilizing the kernel's system-wide resource limit instance.
2021-04-12k_thread: Remove [[nodiscard]] attribute from ClearWaitCancelled()Lioncash1-1/+1
This function has a void return value, so this attribute doesn't apply to it.
2021-04-07Amend bizarre clang-format suggestionsLioncash3-5/+5
2021-04-07k_scoped_scheduler_lock_and_sleep: Mark class as [[nodiscard]]Lioncash1-1/+1
Prevents logic bugs from slipping through.
2021-04-07k_scoped_lock: delete copy and move assignment operatorsLioncash1-2/+5
If we delete the copy and move constructor, we should also be deleting the copy and move assignment operators (and even if this were intended, it would be pretty odd to not document why it's done this way).
2021-04-07k_scoped_lock: Mark class as [[nodiscard]]Lioncash1-1/+1
Prevents logic bugs of the kind described in the previous commit from slipping through.
2021-04-07k_scheduler: Mark KScopedSchedulerLock as [[nodiscard]]Lioncash1-1/+1
Prevents logic bugs like: KScopedSchedulerLock{kernel}; instead of: KScopedSchedulerLock lk{kernel}; from slipping through.
2021-04-07kernel: Increase event and session countsameerj1-2/+2
12.x increased the number of available sessions and event resource counts
2021-04-07svc: Expand SVC tablesLioncash1-0/+132
12.x expanded the range of SVC entries from 0x7F to 0xBF (with all new entries being unused), so we can expand it to also match.
2021-04-07process_capability: Handle extended SVC rangeLioncash2-6/+1
12.x extended the range of SVC IDs, so we need to expand the range of bits that need to be tested. The upside of this is that we can eliminate a range check, given the whole range is used.
2021-03-27hle: kernel: Initialize preemption task after schedulers.bunnei1-1/+1
- Fixes a startup crash that occurs if CoreTiming tries to preempt before kernel initialization completes.
2021-03-24hle: kernel: Breakup InitializeMemoryLayout.bunnei1-3/+7
2021-03-24hle: kernel: k_memory_region_type: Minor code cleanup.bunnei1-13/+12
2021-03-24hle: kernel: k_memory_region: Minor code cleanup.bunnei1-7/+5
2021-03-24hle: kernel: k_memory_layout: Use pair instead of tuple.bunnei1-2/+4
2021-03-24hle: kernel: k_system_control: Remove unnecessary inline.bunnei1-4/+4
2021-03-24common: common_sizes: Move sizes to the Common namespace.bunnei4-45/+46
2021-03-21hle: kernel: Merge KMemoryRegionAttr and KMemoryRegionType.bunnei2-11/+9
- Fixes clang errors with mixed enum arithmetic.
2021-03-21hle: kernel: Remove unused variable.bunnei1-1/+0
2021-03-21hle: kernel: k_memory_region_type: Remove extra ".bunnei1-1/+1
2021-03-21hle: kernel: k_memory_layout: Move KMemoryRegionAllocator out of global.bunnei3-35/+47
2021-03-21hle: kernel: k_memory_layout: Derive memory regions based on board layout.bunnei5-56/+1031
2021-03-21common: common_sizes: Move Invalid to Size_* prefix and add missing values.bunnei1-14/+14
2021-03-21hle: kernel: k_memory_region: Refactor to simplify code.bunnei2-83/+89
2021-03-21hle: kernel: board: k_system_control: Extend to include memory region sizes.bunnei2-1/+125
2021-03-21hle: kernel: board: Add secure_monitor module.bunnei1-0/+26
2021-03-21common: Move common sizes to their own header for code reuse.bunnei1-13/+1
2021-03-21hle: kernel: k_address_space_info: Cleanup.bunnei1-9/+9
2021-03-21hle: kernel: Add k_trace module.bunnei1-0/+12
2021-03-21hle: kernel: KSystemControl: Update to reflect board-specific behavior.bunnei3-9/+39
2021-03-21hle: kernel: KMemoryManager: Add CalculateManagementOverheadSize.bunnei2-0/+26
2021-03-21hle: kernel: KMemoryManager: Add aliases.bunnei1-0/+4
2021-03-21hle: kernel: Add architecture and board specific memory regions.bunnei2-0/+72
2021-03-21hle: kernel: KMemoryRegion: Derive region values.bunnei1-0/+327
2021-03-21hle: kernel: Migrate some code from Common::SpinLock to KSpinLock.bunnei5-25/+25
2021-03-21hle: kernel: Add initial KMemoryRegionType module.bunnei2-18/+40
2021-03-21hle: kernel: Move KMemoryRegion to its own module and update.bunnei3-31/+321
2021-03-07common: Fiber: use a reference for YieldTo.bunnei1-8/+3
- Fixes another small leak.
2021-03-06hle: kernel: KThread: Rework dummy threads & fix memory leak.bunnei6-36/+65
- Dummy threads are created on thread local storage for all host threads. - Fixes a leak by removing creation of fibers, which are not applicable here.
2021-03-06Revert "core: Switch to unique_ptr for usage of Common::Fiber."bunnei5-24/+23
2021-02-27core: Switch to unique_ptr for usage of Common::Fiber.bunnei5-23/+24
- With using unique_ptr instead of shared_ptr, we have more explicit ownership of the context. - Fixes a memory leak due to circular reference of the shared pointer.
2021-02-21kernel: Fix resource release exception on exitameerj1-2/+7
After rewriting the resource limit, objects releasing reserved resources require a live kernel instance. This commit fixes exceptions that occur due to the kernel being destroyed before some objects released their resources, allowing for a graceful exit.
2021-02-19hle: kernel: Migrate PageHeap/PageTable to KPageHeap/KPageTable.bunnei13-130/+115
2021-02-19hle: kernel: Migrate MemoryManager to KMemoryManager.bunnei7-45/+46
2021-02-19hle: kernel: Migrate PageLinkedList to KPageLinkedList.bunnei7-37/+40
2021-02-19hle: kernel: Migrate to KMemoryBlock, KMemoryBlockManager, and others.bunnei16-461/+465
2021-02-19hle: kernel: Migrate SlabHeap to KSlabHeap.bunnei3-21/+20
2021-02-19hle: kernel: Migrate MemoryLayout to KMemoryLayout.bunnei4-30/+29
2021-02-19hle: kernel: Migrate AddressSpaceInfo to KAddressSpaceInfo.bunnei3-57/+52
2021-02-19hle: kernel: memory_manager: Rename AllocateContinuous to AllocateContinuous.bunnei2-4/+28
2021-02-19hle: kernel: KSystemControl does not belong in Memory namespace.bunnei5-27/+34
2021-02-19hle: kernel: memory: PageHeap: Migrate to KPageBitmap class.bunnei4-197/+23
2021-02-19hle: kernel: Add KPageBitmap class.bunnei1-0/+279
2021-02-19hle: kernel: system_control: Add function GenerateRandomU64.bunnei2-3/+5
2021-02-19hle: kernel: Add KSpinLock implementation.bunnei2-0/+87
2021-02-19hle: kernel: Rename SharedMemory to KSharedMemory.bunnei5-40/+40
2021-02-13kernel: More accurately reserve and release resourcesameerj6-14/+42
2021-02-13kernel: KScopedReservation implementationameerj5-26/+151
This implements KScopedReservation, allowing resource limit reservations to be more HW accurate, and release upon failure without requiring too many conditionals.
2021-02-13kernel: Unify result codes (#5890)Chloe19-251/+219
* kernel: Unify result codes Drop the usage of ERR_NAME convention in kernel for ResultName. Removed seperation between svc_results.h & errors.h as we mainly include both most of the time anyways. * oops * rename errors to svc_results
2021-02-06k_address_arbiter: Unfold R_UNLESS macrosLioncash1-5/+8
Allows for more descriptive error messages and also doesn't hide control-path exit returns from the reader.
2021-02-06k_address_arbiter: Remove unnecessary usages of std::addressofLioncash1-10/+10
This is a useful function in a generic context or with types that overload unary operator&. However, primitives and pointers will never do this, so we can opt for a more straightforward syntax.
2021-02-06k_address_arbiter: Remove dead codeLioncash1-40/+13
This code is never used, so we can remove it. It's in version control, so it can always be brought back when needed.
2021-02-06svc: Provide more detailed error logs for svc functionsLioncash1-59/+188
Allows SVC calls to have much more informative information during error cases. This also doesn't hide control flow returns from the reader.
2021-02-05hle: kernel: Drop R_UNLESS_NOLOG in favor of expanded if-statement.bunnei2-3/+11
2021-02-05hle: kernel: KAddressArbiter: Remove noisy error log.bunnei1-1/+1
2021-02-05hle: kernel: svc: Cleanup KEvent/KReadableEvent/KWritableEvent SVCs.bunnei5-69/+89
2021-02-05hle: kernel: Reimplement KReadableEvent and KWritableEvent.bunnei9-104/+82
2021-02-05hle: kernel: Implement KEvent.bunnei2-0/+89
2021-02-05hle: kernel: KAddressArbiter: Use R_UNLESS_NOLOG where applicable.bunnei1-1/+1
2021-02-05hle: kernel: Rename WritableEvent to KWritableEvent.bunnei6-21/+21
2021-02-05hle: kernel: Rename ReadableEvent to KReadableEvent.bunnei7-23/+23
2021-02-04k_affinity_mask: Avoid implicit truncation to boolLioncash1-1/+1
This can cause compiler warnings. Instead, we can explicitly add a boolean expression around it to naturally turn the result into a bool.
2021-02-04k_priority_queue: Unfold several declval usagesLioncash1-5/+5
Given these are only used as function existence checks, we can simplify some usages of declval, given they aren't particularly useful here. Reduces a few template instantiations, which at most reduces compile times a tiny bit.
2021-02-04k_priority_queue: Simplify affinity mask type aliasLioncash1-2/+2
We can make use of the _t variants of the templates to cut down on a little bit of verbosity.
2021-02-04k_priority_queue: Resolved reserved identifierLioncash1-2/+2
An identifier containing a starting underscore followed by a capital letter is reserved by the standard. It's trivial to avoid this by moving the underscore to the end of the identifier. While the likelihood of clashing here being minimal, we can turn a "should not break" scenario into a definitive "will not break" one, so why not?.
2021-02-03Simplify limitableresource namesChloe Marcec6-36/+29
2021-02-02Compile errorChloe Marcec1-1/+1
2021-02-02Address issuesChloe Marcec3-19/+15
2021-01-30fix compile errorChloe Marcec1-1/+1
2021-01-30cleanup commentingChloe Marcec1-2/+2
2021-01-30Drop m_ from lockChloe Marcec2-9/+9
2021-01-30Move to GetGlobalTimeNs, fix GetTotalPhysicalMemoryAvailableChloe Marcec3-9/+7
2021-01-30kernel: Rewrite resource limit to be more accurateChloe Marcec12-229/+354
Matches closer to hardware
2021-01-29hle: kernel: KLightLock: Fix several bugs.bunnei1-3/+3
2021-01-29hle: kernel: KThread: Release thread resource on thread exit.bunnei1-0/+1
2021-01-29yuzu: debugger: Ignore HLE threads.bunnei2-7/+13
2021-01-29hle: kernel: process: Add state lock.bunnei3-6/+15
2021-01-29hle: kernel: threading: Fix bug with host thread naming.bunnei1-3/+2
2021-01-29hle: kernel: k_scheduler_lock: Cleanup.bunnei1-3/+3
2021-01-29hle: kernel: Allocate a dummy KThread for each host thread, and use it for scheduling.bunnei7-41/+45
2021-01-29hle: kernel: k_scheduler: Use atomics for current_thread, etc.bunnei2-26/+28
2021-01-29hle: kernel: k_scheduler: Fix for single core mode.bunnei1-1/+2
2021-01-29kernel: Fix build errors.bunnei2-4/+9
2021-01-29hle: kernel: KScheduler: Introduce thread context_guard.bunnei2-3/+16
2021-01-29hle: kernel: Recode implementation of KThread to be more accurate.bunnei12-767/+1553
2021-01-29kernel: svc_types: Add ThreadActivity.bunnei1-0/+5
2021-01-29kernel: KSchedulerPriorityQueue: Lowest priority should be LowestThreadPriority.bunnei1-1/+1
2021-01-29kernel: k_light_lock: Simplify EmuThreadHandle implementation.bunnei4-23/+25
2021-01-29hle: kernel: TimeManager: Simplify to not rely on previous EmuThreadHandle implementation.bunnei6-69/+25
2021-01-29core: hle: kernel: object: Implement Finalize() virtual method.bunnei15-6/+29
2021-01-29core: hle: kernel: svc_results: Populate with several missing error codes.bunnei1-0/+3
2021-01-29core: hle: kernel: Implement KLightLock.bunnei2-0/+171
2021-01-29core: hle: kernel: Implement KThreadQueue.bunnei1-0/+81
2021-01-29hle: kernel: KThread: Clean up thread priorities.bunnei9-75/+41
2021-01-29hle: kernel: KThread: Reorganize thread priority defaults.bunnei7-27/+27
2021-01-29hle: kernel: KThread: Fix ThreadType definition.bunnei5-11/+12
2021-01-29hle: kernel: Move single core "phantom mode" out of KThread.bunnei3-10/+24
- This is a workaround that does not belong in a kernel primitive.
2021-01-29hle: kernel: KThread: Remove thread types that do not exist.bunnei4-44/+27
2021-01-29core: hle: kernel: Rename Thread to KThread.bunnei30-238/+237
2021-01-28hle_ipc: Add Can(Read, Write)BufferMorph2-0/+28
Allows us to test whether a buffer can be read from or written to memory
2021-01-15common/bit_util: Replace CLZ/CTZ operations with standardized onesLioncash4-8/+12
Makes for less code that we need to maintain.
2021-01-11hle: kernel: thread: Preserve thread wait reason for debugging only.bunnei7-1/+34
- This is decoupled from core functionality and used for debugging only.
2021-01-11hle: kernel: k_scheduler_lock: Fix shadowing errors.bunnei1-1/+1
2021-01-11core: hle: Integrate new KConditionVariable and KAddressArbiter implementations.bunnei13-1173/+503
2021-01-11core: hle: kernel: Update KAddressArbiter.bunnei2-0/+435
2021-01-11core: hle: kernel: Update KConditionVariable.bunnei3-0/+411
2021-01-11core: hle: kernel: Begin moving common SVC defintions to its own header.bunnei1-0/+13
2021-01-11hle: kernel: Remove unnecessary AddressArbiter definition.bunnei1-1/+0
2021-01-11hle: kernel: k_scheduler: Cleanup OnThreadPriorityChanged.bunnei2-6/+3
2021-01-11hle: kernel: Rename thread "status" to "state".bunnei1-2/+2
2021-01-11hle: kernel: thread: Replace ThreadStatus/ThreadSchedStatus with a single ThreadState.bunnei11-127/+97
- This is how the real kernel works, and is more accurate and simpler.
2021-01-11core: hle: kernel: Add some useful functions for checking kernel addresses.bunnei1-0/+19
2021-01-11core: hle: kernel: svc_types: Add type definitions for KAddressArbiter.bunnei1-0/+12
2021-01-11core: hle: kernel: Update KSynchronizationObject.bunnei29-596/+377
2021-01-11core: hle: kernel: Begin moving common SVC results to its own header.bunnei1-0/+20
2021-01-05core: Silence warnings when compiling without assertsReinUsesLisp1-0/+2
2021-01-02general: Fix various spelling errorsMorph3-15/+15
2020-12-30core/memory: Read and write page table atomicallyReinUsesLisp1-1/+1
Squash attributes into the pointer's integer, making them an uintptr_t pair containing 2 bits at the bottom and then the pointer. These bits are currently unused thanks to alignment requirements. Configure Dynarmic to mask out these bits on pointer reads. While we are at it, remove some unused attributes carried over from Citra. Read/Write and other hot functions use a two step unpacking process that is less readable to stop MSVC from emitting an extra AND instruction in the hot path: mov rdi,rcx shr rdx,0Ch mov r8,qword ptr [rax+8] mov rax,qword ptr [r8+rdx*8] mov rdx,rax -and al,3 and rdx,0FFFFFFFFFFFFFFFCh je Core::Memory::Memory::Impl::Read<unsigned char> mov rax,qword ptr [vaddr] movzx eax,byte ptr [rdx+rax]
2020-12-30hle: kernel: service_thread: Make thread naming more consistent.bunnei1-1/+1
2020-12-30hle: kernel: Manage service threads on another thread.bunnei1-9/+20
- This is to allow service threads to defer destruction of themselves.
2020-12-30hle: kernel: Manage host thread IDs using TLS.bunnei1-46/+31
- Avoids the need to have a large map of host to guest thread IDs.
2020-12-29k_priority_queue: Fix concepts usecomex1-3/+5
- For `std::same_as`, add missing include of `<concepts>`. - For `std::convertible_to`, create a replacement in `common/concepts.h` and use that instead. This would also be found in `<concepts>`, but unlike `std::same_as`, `std::convertible_to` is not yet implemented in libc++, LLVM's STL implementation - not even in master. (In fact, `std::same_as` is the *only* concept currently implemented. For some reason.)
2020-12-29Add missing include of "core/hle/kernel/kernel.h"comex1-0/+1
This is needed as the header invokes methods on KernelCore.
2020-12-29svc: demote SleepThread log to LOG_TRACEameerj1-1/+1
This log is called often, and introduces a lot of noise when debug logging is enabled, making it difficult to see other debug logs.
2020-12-29hle: kernel: Move ServiceThread ownership to KernelCore.bunnei4-5/+48
- Fixes a circular dependency which prevented threads from being released on shutdown.
2020-12-29hle: kernel: service_thread: Add thread name and take weak_ptr of ServerSession.bunnei3-11/+22
2020-12-29core: hle: kernel: Clear process list on boot.bunnei1-2/+2
2020-12-29core: kernel: Clear process list earlier.bunnei1-2/+2
2020-12-29hle: kernel: hle_ipc: Remove SleepClientThread.bunnei2-54/+0
- This was kind of hacky, and no longer is necessary with service threads.
2020-12-29hle: kernel: service_thread: Add parameter for thread pool size.bunnei3-7/+7
2020-12-29core: hle: server_session: Use separate threads for each service connection.bunnei5-23/+138
2020-12-08svc: Remove unnecessary castsLioncash1-35/+25
Simplifies and removes some casts. In all cases, these were generally widening from a 32-bit unsigned type to a 64-bit unsigned type, so no information would be lost from the conversion.
2020-12-08core: Remove unnecessary enum casts in log callsLioncash3-5/+4
Follows the video core PR. fmt doesn't require casts for enum classes anymore, so we can remove quite a few casts.
2020-12-07Fix "explicitly defaulted but implicitly deleted" warningcomex1-1/+1
`PhysicalCore`'s move assignment operator was declared as `= default`, but was implicitly deleted because `PhysicalCore` has fields of reference type. Switch to explicitly deleting it to avoid a Clang warning. The move *constructor* is still defaulted, and is required to exist due to the use of `std::vector<PhysicalCore>`.
2020-12-07core: Mark unused fields as [[maybe_unused]]comex1-2/+2
2020-12-06hle: kernel: Process: Various style fixes based on code review feedback.bunnei1-2/+2
2020-12-06hle: kernel: Thread: Various style fixes based on code review feedback.bunnei1-22/+25
2020-12-06hle: kernel: KScopedSchedulerLockAndSleep: Various style fixes based on code review feedback.bunnei1-6/+6
2020-12-06hle: kernel: KScopedLock: Various style fixes based on code review feedback.bunnei1-6/+8
2020-12-06hle: kernel: KAbstractSchedulerLock: Various style fixes based on code review feedback.bunnei1-9/+7
2020-12-06hle: kernel: KScheduler: Various style fixes based on code review feedback.bunnei2-50/+41
2020-12-06hle: kernel: KPriorityQueue: Various style fixes based on code review feedback.bunnei1-29/+36
2020-12-06hle: kernel: KAffinityMask: Various style fixes based on code review feedback.bunnei1-17/+13
2020-12-06hle: kernel: GlobalSchedulerContext: Various style fixes based on code review feedback.bunnei2-5/+10
2020-12-06hle: kernel: Use C++ style comments in KScheduler, etc.bunnei4-152/+136
2020-12-06kernel: KScopedSchedulerLockAndSleep: Remove unused ctor.bunnei1-13/+7
2020-12-06kernel: time_manager: Add missing lock guards.bunnei1-3/+10
2020-12-06hle: kernel: Migrate to KScopedSchedulerLock.bunnei14-48/+91
2020-12-06hle: kernel: Separate KScopedSchedulerLockAndSleep from k_scheduler.bunnei10-69/+71
2020-12-06hle: kernel: Separate KScheduler from GlobalSchedulerContext class.bunnei4-118/+138
2020-12-06hle: kernel: Rewrite scheduler implementation based on Mesopshere.bunnei19-1145/+1178
2020-12-06hle: kernel: physical_core: Clear exclusive state after each run.bunnei1-0/+1
- This is closer to pre-multicore behavior, and works a bit better.
2020-12-06hle: kernel: Port KAbstractSchedulerLock from Mesosphere.bunnei1-0/+76
2020-12-06hle: kernel: svc: Remove reschedule on svcBreak.bunnei1-5/+0
- This breaks things, and is unnecessary, since emulation will be done at this point.
2020-12-06hle: kernel: process: Add schedule count tracking, to be used for yield impl.bunnei1-0/+13
2020-12-06hle: kernel: svc: Remove unnecessary hack in svcSleep.bunnei1-7/+0
2020-12-06common: Port KPriorityQueue from Mesosphere.bunnei1-0/+443
2020-12-06hle: kernel: Port KAffinityMask from Mesosphere.bunnei5-14/+77
2020-12-05video_core: Resolve more variable shadowing scenarios pt.3Lioncash1-3/+3
Cleans out the rest of the occurrences of variable shadowing and makes any further occurrences of shadowing compiler errors.
2020-11-29kernel: scheduler: Minor cleanup to remove duplicated code.bunnei2-46/+14
2020-11-29kernel: time_manager: Protect access with a mutex.bunnei2-1/+5
2020-11-29hle: kernel: thread: Remove unused "Running" state.bunnei2-6/+0
2020-11-29core: arm: Implement InvalidateCacheRange for CPU cache invalidation.bunnei4-5/+21
2020-11-29hle: kernel: time_manager: Avoid a crash on process exit.bunnei1-1/+4
2020-11-29hle: kernel: AddressArbiter: Remove unused code.bunnei2-9/+0
2020-11-29hle: kernel: SynchronizationObject: Use atomic_bool for is_signaled.bunnei1-1/+2
2020-11-29common: fiber: Use boost::context instead of native fibers on Windows.bunnei1-1/+1
2020-11-29hle: kernel: multicore: Replace n-JITs impl. with 4 JITs.bunnei8-57/+97
2020-11-23svc: Remove unnecessary [[maybe_unused]] tagLioncash1-1/+1
The parameter is used in this function, so this suppression isn't necessary.
2020-11-08ipc_helpers: Remove usage of the global system instanceLioncash1-0/+6
Resolves numerous deprecation warnings throughout the codebase due to inclusion of this header. Now building core should be significantly less noisy (and also relying on less global state). This also uncovered quite a few modules that were relying on indirect includes, which have also been fixed.
2020-11-04core: Remove usage of unicornLioncash2-28/+5
Unicorn long-since lost most of its use, due to dynarmic gaining support for handling most instructions. At this point any further issues encountered should be used to make dynarmic better. This also allows us to remove our dependency on Python.
2020-10-29kernel/process: Add missing <ctime> includeMorph1-0/+1
Fixes compilation on MSVC
2020-10-27hle/kernel: Remove unused registered_core_threads to fix data racesReinUsesLisp1-5/+0
This member was only used on asserts and it triggered data races. Remove it to fix them.
2020-10-27kernel: Use the current time as the default RNG seedlat9nq1-1/+1
Use the current time, not zero, as the default RNG seed.
2020-10-21Revert "core: Fix clang build"bunnei18-114/+74
2020-10-21kernel: Fix build with recent compiler flag changesLioncash1-4/+8
This slipped through the cracks due to another change being merged before the compiler flag changes.
2020-10-18core: Fix clang buildLioncash18-74/+114
Recent changes to the build system that made more warnings be flagged as errors caused building via clang to break. Fixes #4795
2020-10-13kernel: Implement host thread register methods without lockingReinUsesLisp1-28/+38
Locks on GetCurrentHostThreadID were causing performance issues according to Visual Studio's profiler. It was consuming twice the time as arm_interface.Run(). The cost was not in the function itself but in the lockinig it required. Reimplement these functions using atomics and static storage instead of an unordered_map. This is a side effect to avoid locking and using linked lists for reads. Replace unordered_map with a linear search.
2020-10-13core/CMakeLists: Make some warnings errorsLioncash2-6/+6
Makes our error coverage a little more consistent across the board by applying it to Linux side of things as well. This also makes it more consistent with the warning settings in other libraries in the project. This also updates httplib to 0.7.9, as there are several warning cleanups made that allow us to enable several warnings as errors.
2020-09-14kernel: Remove all dependencies on the global system instanceLioncash5-11/+20
With this, the kernel finally doesn't depend directly on the global system instance anymore.
2020-08-26hle/scheduler: Fix data race in is_context_switch_pendingReinUsesLisp1-2/+6
As reported by tsan, SelectThreads could write to is_context_switch_pending holding a mutex while SwitchToCurrent reads it without holding any. It is assumed that the author didn't want an atomic here, so the code is reordered so that whenever is_context_switch_pending is read inside SwitchToContext, the mutex is locked.
2020-08-26hle/kernel: Fix data race in GetCurrentHostThreadIDReinUsesLisp1-1/+2
As reported by tsan, host_thread_ids could be read while any of the RegisterHostThread variants were called. To fix this, lock the register mutex when yuzu is running in multicore mode and GetCurrentHostThreadID is called.
2020-08-14kernel/scheduler: Mark SchedulerLock constructor as nodiscardLioncash1-1/+1
Allows the compiler to warn about cases where the constructor is used but then immediately discarded, which is a potential cause of locking/unlocking bugs.
2020-08-13General: Tidy up clang-format warnings part 2Lioncash2-30/+38
2020-08-05system_control: Make functions internally linked where applicableLioncash2-15/+11
These functions are only ever used internally as implementation details for GenerateRandomRange(), so these can be given internal linkage.
2020-08-05kernel: Remove unused variablesLioncash2-18/+11
Resolves a few compiler warnings.
2020-08-05scheduler: Resolve sign conversion warningLioncash1-1/+2
2020-08-05address_arbiter: Resolve sign conversion warningLioncash1-1/+1
Makes our type conversion explicit.
2020-08-03ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer (#4465)David1-14/+16
* ipc: Allow all trivially copyable objects to be passed directly into WriteBuffer With the support of C++20, we can use concepts to deduce if a type is an STL container or not. * More agressive concept for stl containers * Add -fconcepts * Move to common namespace * Add Common::IsBaseOf
2020-07-28core_timing: Make use of uintptr_t to represent user_dataLioncash3-8/+10
Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
2020-07-16kernel/thread: Remove unimplemented function prototypeLioncash1-2/+0
This isn't used, so it can be removed.
2020-07-16kernel: Remove unused variablesLioncash3-7/+2
Resolves some compiler warnings in the Linux build.
2020-07-16kernel: Add missing includeLioncash1-0/+1
2020-07-16cpu_manager: Mark function getters as staticLioncash3-7/+8
All these do are return std::function instances of static functions, so these can be used without an instance of the CPU manager.
2020-07-16core_timing: Make TimedCallback take std::chrono::nanosecondsLioncash3-3/+3
Enforces our desired time units directly with a concrete type.
2020-07-16core_timing: Make use of std::chrono with ScheduleEventLioncash3-5/+8
2020-07-15kernel/process: Move name and system context to the bottom of the member listLioncash1-6/+6
These aren't directly important or commonly used within the process, so we can move these to the bottom to allow everything else to be more likely to be within a cache line.
2020-07-15kernel/handle_table: Remove usages of the global system instanceLioncash4-8/+15
Removes even more usages of the global system instance, trimming away more dependencies on global variables and making them explicit in the interface.
2020-07-15kernel/thread: Remove global GetCurrentThread()Lioncash3-23/+7
This is only used in one place, so we can fold it into the calling code, eliminating a place for the global system instance to be used.
2020-07-13memory_layout: Remove unused data memberLioncash1-2/+0
This isn't used, so it can be removed entirely, shrinking the structure size by 8 bytes.
2020-07-13address_space_info: Use type alias to simplify codeLioncash1-14/+13
We can define an alias for the index arrays and then just reuse it to make the code nicer to read.
2020-07-13address_space_info: Make use of designated initializersLioncash2-46/+27
We can alter the structure so that we can use designated initializers in the array, eliminating the comments that indicate their field names.
2020-07-13kernel/scheduler: Use std::mutex instead of spin lockReinUsesLisp1-1/+1
Profiling shows that this is a highly contested mutex, causing dimishing results compared to a OS lock. std::mutex implementations can spin for a while before falling back to an OS lock. This avoids wasting precious CPU cycles in a no-op.
2020-07-10configuration: implement per-game configurations (#4098)lat9nq1-1/+1
* Switch game settings to use a pointer In order to add full per-game settings, we need to be able to tell yuzu to switch to using either the global or game configuration. Using a pointer makes it easier to switch. * configuration: add new UI without changing existing funcitonality The new UI also adds General, System, Graphics, Advanced Graphics, and Audio tabs, but as yet they do nothing. This commit keeps yuzu to the same functionality as originally branched. * configuration: Rename files These weren't included in the last commit. Now they are. * configuration: setup global configuration checkbox Global config checkbox now enables/disables the appropriate tabs in the game properties dialog. The use global configuration setting is now saved to the config, defaulting to true. This also addresses some changes requested in the PR. * configuration: swap to per-game config memory for properties dialog Does not set memory going in-game. Swaps to game values when opening the properties dialog, then swaps back when closing it. Uses a `memcpy` to swap. Also implements saving config files, limited to certain groups of configurations so as to not risk setting unsafe configurations. * configuration: change config interfaces to use config-specific pointers When a game is booted, we need to be able to open the configuration dialogs without changing the settings pointer in the game's emualtion. A new pointer specific to just the configuration dialogs can be used to separate changes to just those config dialogs without affecting the emulation. * configuration: boot a game using per-game settings Swaps values where needed to boot a game. * configuration: user correct config during emulation Creates a new pointer specifically for modifying the configuration while emulation is in progress. Both the regular configuration dialog and the game properties dialog now use the pointer Settings::config_values to focus edits to the correct struct. * settings: split Settings::values into two different structs By splitting the settings into two mutually exclusive structs, it becomes easier, as a developer, to determine how to use the Settings structs after per-game configurations is merged. Other benefits include only duplicating the required settings in memory. * settings: move use_docked_mode to Controls group `use_docked_mode` is set in the input settings and cannot be accessed from the system settings. Grouping it with system settings causes it to be saved with per-game settings, which may make transferring configs more difficult later on, especially since docked mode cannot be set from within the game properties dialog. * configuration: Fix the other yuzu executables and a regression In main.cpp, we have to get the title ID before the ROM is loaded, else the renderer will reflect only the global settings and now the user's game specific settings. * settings: use a template to duplicate memory for each setting Replaces the type of each variable in the Settings::Values struct with a new class that allows basic data reading and writing. The new struct Settings::Setting duplicates the data in memory and can manage global overrides per each setting. * configuration: correct add-ons config and swap settings when apropriate Any add-ons interaction happens directly through the global values struct. Swapping bewteen structs now also includes copying the necessary global configs that cannot be changed nor saved in per-game settings. General and System config menus now update based on whether it is viewing the global or per-game settings. * settings: restore old values struct No longer needed with the Settings::Setting class template. * configuration: implement hierarchical game properties dialog This sets the apropriate global or local data in each setting. * clang format * clang format take 2 can the docker container save this? * address comments and style issues * config: read and write settings with global awareness Adds new functions to read and write settings while keeping the global state in focus. Files now generated per-game are much smaller since often they only need address the global state. * settings: restore global state when necessary Upon closing a game or the game properties dialog, we need to restore all global settings to the original global state so that we can properly open the configuration dialog or boot a different game. * configuration: guard setting values incorrectly This disables setting values while a game is running if the setting is overwritten by a per game setting. * config: don't write local settings in the global config Simple guards to prevent writing the wrong settings in the wrong files. * configuration: add comments, assume less, and clang format No longer assumes that a disabled UI element means the global state is turned off, instead opting to directly answer that question. Still however assumes a game is running if it is in that state. * configuration: fix a logic error Should not be negated * restore settings' global state regardless of accept/cancel Fixes loading a properties dialog and causing the global config dialog to show local settings. * fix more logic errors Fixed the frame limit would set the global setting from the game properties dialog. Also strengthened the Settings::Setting member variables and simplified the logic in config reading (ReadSettingGlobal). * fix another logic error In my efforts to guard RestoreGlobalState, I accidentally negated the IsPowered condition. * configure_audio: set toggle_stretched_audio to tristate * fixed custom rtc and rng seed overwriting the global value * clang format * rebased * clang format take 4 * address my own review Basically revert unintended changes * settings: literal instead of casting "No need to cast, use 1U instead" Thanks, Morph! Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com> * Revert "settings: literal instead of casting " This reverts commit 95e992a87c898f3e882ffdb415bb0ef9f80f613f. * main: fix status buttons reporting wrong settings after stop emulation * settings: Log UseDockedMode in the Controls group This should have happened when use_docked_mode was moved over to the controls group internally. This just reflects this in the log. * main: load settings if the file has a title id In other words, don't exit if the loader has trouble getting a title id. * use a zero * settings: initalize resolution factor with constructor instead of casting * Revert "settings: initalize resolution factor with constructor instead of casting" This reverts commit 54c35ecb46a29953842614620f9b7de1aa9d5dc8. * configure_graphics: guard device selector when Vulkan is global Prevents the user from editing the device selector if Vulkan is the global renderer backend. Also resets the vulkan_device variable when the users switches back-and-forth between global and Vulkan. * address reviewer concerns Changes function variables to const wherever they don't need to be changed. Sets Settings::Setting to final as it should not be inherited from. Sets ConfigurationShared::use_global_text to static. Co-Authored-By: VolcaEM <volcaem@users.noreply.github.com> * main: load per-game settings after LoadROM This prevents `Restart Emulation` from restoring the global settings *after* the per-game settings were applied. Thanks to BSoDGamingYT for finding this bug. * Revert "main: load per-game settings after LoadROM" This reverts commit 9d0d48c52d2dcf3bfb1806cc8fa7d5a271a8a804. * main: only restore global settings when necessary Loading the per-game settings cannot happen after the ROM is loaded, so we have to specify when to restore the global state. Again thanks to BSoD for finding the bug. * configuration_shared: address reviewer concerns except operator overrides Dropping operator override usage in next commit. Co-Authored-By: LC <lioncash@users.noreply.github.com> * settings: Drop operator overrides from Setting template Requires using GetValue and SetValue explicitly. Also reverts a change that broke title ID formatting in the game properties dialog. * complete rebase * configuration_shared: translate "Use global configuration" Uses ConfigurePerGame to do so, since its usage, at least as of now, corresponds with ConfigurationShared. * configure_per_game: address reviewer concern As far as I understand, it prevents the program from unnecessarily copying strings. Co-Authored-By: LC <lioncash@users.noreply.github.com> Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com> Co-authored-by: VolcaEM <volcaem@users.noreply.github.com> Co-authored-by: LC <lioncash@users.noreply.github.com>
2020-06-29core_timing,scheduler: Use std::scoped_lock when possibleReinUsesLisp1-11/+10
Simplifies the cognitive load of procedures using locks and makes locks safe against exceptions.
2020-06-28Core/Common: Address Feedback.Fernando Sahmkow5-16/+17
2020-06-27SVC: Implement 32-bits wrappers and update Dynarmic.Fernando Sahmkow2-30/+273
2020-06-27SVC: Add GetCurrentProcessorNumber32, CreateTransferMemory32, SetMemoryAttribute32Fernando Sahmkow2-6/+39
2020-06-27SVC: Add GetThreadPriority32 & SetThreadPriority32Fernando Sahmkow2-2/+30
2020-06-27Common/Kernel: Corrections and small bug fixing.Fernando Sahmkow1-2/+2
2020-06-27Kernel: Correct Host Context on Threads and Scheduler.Fernando Sahmkow4-11/+11
2020-06-27Clang Format.Fernando Sahmkow4-12/+11
2020-06-27General: Cleanup legacy code.Fernando Sahmkow8-253/+5
2020-06-27Kernel/svcBreak: Implement CacheInvalidation for Singlecore and correct svcBreak.Fernando Sahmkow2-3/+13
2020-06-27HLE_IPC: Correct HLE Event behavior on timeout.Fernando Sahmkow3-1/+19
2020-06-27SingleCore: Improve Cycle timing Behavior and replace mutex in global scheduler for spinlock.Fernando Sahmkow2-2/+3
2020-06-27SingleCore: Use Cycle Timing instead of Host Timing.Fernando Sahmkow2-4/+13
2020-06-27Scheduler: Correct Reload/UnloadFernando Sahmkow2-3/+5
2020-06-27Thread: Release the ARM Interface on exitting.Fernando Sahmkow3-1/+8
2020-06-27General: Move ARM_Interface into Threads.Fernando Sahmkow8-119/+88
2020-06-27Core: Refactor ARM Interface.Fernando Sahmkow3-24/+43
2020-06-27SVC/ARM: Correct svcSendSyncRequest and cache ticks on arm interface.Fernando Sahmkow1-1/+1
2020-06-27SingleCore: Move Host Timing from a sepparate thread to main cpu thread.Fernando Sahmkow2-1/+10
2020-06-27ARM: Addapt to new Exclusive Monitor Interface.Fernando Sahmkow2-9/+4
2020-06-27Scheduler: Correct yielding interaction with SetThreadActivity.Fernando Sahmkow1-0/+15
2020-06-27General: Fix microprofile on dynarmic/svc, fix wait tree showing which threads were running.Fernando Sahmkow5-3/+51
2020-06-27General: Fix Stop functionFernando Sahmkow2-3/+20
2020-06-27Kernel: Rewind on SVC change.Fernando Sahmkow3-5/+16
2020-06-27Kernel: Preempt Single core on redudant yields.Fernando Sahmkow5-19/+40
2020-06-27CPU_Manager: Unload/Reload threads on preemption on SingleCoreFernando Sahmkow2-0/+52
2020-06-27Synchronization: Correct wide Assertion.Fernando Sahmkow1-2/+4
2020-06-27General: Initial Setup for Single Core.Fernando Sahmkow2-0/+22
2020-06-27Scheduler: Set last running time on thread.Fernando Sahmkow2-4/+2
2020-06-27Kernel: Corrections to TimeManager, Scheduler and Mutex.Fernando Sahmkow3-5/+5
2020-06-27Kernel: Fixes, corrections and asserts to scheduler and different svcs.Fernando Sahmkow8-38/+38
2020-06-27Scheduler: Correct yields.Fernando Sahmkow2-7/+25
2020-06-27Mutex: Revert workaround due to poor exclusive memory.Fernando Sahmkow1-9/+2
2020-06-27ARM/Memory: Correct Exclusive Monitor and Implement Exclusive Memory Writes.Fernando Sahmkow4-9/+10
2020-06-27SVC: WaitSynchronization add Termination Pending Result.Fernando Sahmkow2-1/+5
2020-06-27Scheduler: Remove arm_interface lock and a few corrections.Fernando Sahmkow1-7/+3
2020-06-27SVC: Correct SetThreadActivity.Fernando Sahmkow4-38/+59
2020-06-27SCC: Small corrections to CancelSynchronizationFernando Sahmkow3-2/+14
2020-06-27Scheduler: Correct locking for hle threads.Fernando Sahmkow1-1/+2
2020-06-27Scheduler: Fix HLE Threads on guardFernando Sahmkow1-4/+6
2020-06-27Scheduler: Protect on closed threads.Fernando Sahmkow1-7/+17
2020-06-27Scheduler: Correct assert.Fernando Sahmkow1-4/+2
2020-06-27Core: Correct rebase.Fernando Sahmkow1-6/+5
2020-06-27Scheduler: Release old thread fiber before trying to switch to the next thread fiber.Fernando Sahmkow2-11/+35
2020-06-27Mutex: Correct Result writting to clear exclusivity.Fernando Sahmkow1-3/+11
2020-06-27SVC: Correct svcWaitForAddress and svcSignalToAddress.Fernando Sahmkow4-68/+161
2020-06-27Scheduler: Correct Select Threads Step 2.Fernando Sahmkow1-0/+1
2020-06-27Kernel: Corrections to Scheduling.Fernando Sahmkow3-14/+15
2020-06-27Kernel: Correct Signal on Thread Death and Setup Sync Objects on Thread for DebuggingFernando Sahmkow3-15/+17
2020-06-27Core: Correct HLE Event Callbacks and other issues.Fernando Sahmkow5-37/+39
2020-06-27Process: Protect TLS region and Modules.Fernando Sahmkow1-0/+4
2020-06-27General: Add AssertsFernando Sahmkow3-0/+20
2020-06-27General: Add better safety for JIT use.Fernando Sahmkow2-1/+8
2020-06-27SVC: Correct races on physical core switching.Fernando Sahmkow1-5/+4
2020-06-27SVC: Add locks to the memory management.Fernando Sahmkow1-0/+21
2020-06-27SVC: Correct WaitSynchronization, WaitProcessWideKey, SignalProcessWideKey.Fernando Sahmkow9-33/+84
2020-06-27SVC: Cleanup old methods.Fernando Sahmkow1-13/+9
2020-06-27CPU_Manager: Reconfigre guest threads for dynamrmic downsidesFernando Sahmkow2-0/+5
2020-06-27SVC: Correct SendSyncRequest.Fernando Sahmkow7-52/+115
2020-06-27SVC: Correct ArbitrateUnlockFernando Sahmkow3-33/+37
2020-06-27SVC: Correct SignalEvent, ClearEvent, ResetSignal, WaitSynchronization, CancelSynchronization, ArbitrateLockFernando Sahmkow8-90/+134
2020-06-27SVC: Remove global HLE Lock.Fernando Sahmkow1-3/+0
2020-06-27SVC: Correct GetThreadPriority, SetThreadPriority, GetThreadCoreMask, SetThreadCoreMask, GetCurrentProcessorNumberFernando Sahmkow3-15/+11
2020-06-27SVC: Correct CreateThread, StartThread, ExitThread, SleepThread.Fernando Sahmkow3-37/+31
2020-06-27General: Recover Prometheus project from harddrive failure Fernando Sahmkow11-344/+679
This commit: Implements CPU Interrupts, Replaces Cycle Timing for Host Timing, Reworks the Kernel's Scheduler, Introduce Idle State and Suspended State, Recreates the bootmanager, Initializes Multicore system.
2020-06-25memory_manager: Remove useless assertionDavid Marcec1-1/+0
num_pages is an std::size_t. It will always be >= 0
2020-06-24Mark invalid IPC buffers as ASSERT_OR_EXECUTE_MSGDavid Marcec1-25/+22
Previously if applications would send faulty buffers(example homebrew) it would lead to us returning uninitalized data. Switching from ASSERT_MSG to ASSERT_OR_EXECUTE_MSG allows us to have a fail safe to prevent crashes but also continue execution without introducing undefined behavior
2020-06-18memory_manager: Explicitly specifcy std::min<size_t>MerryMage1-2/+2
2020-06-10kernel: Account for system resource size for memory usageDavid Marcec1-2/+4
GetTotalPhysicalMemoryAvailableWithoutSystemResource & GetTotalPhysicalMemoryUsedWithoutSystemResource seem to subtract the resource size from the usage.
2020-06-04Downgrade "handle not signaled" error to traceDavid Marcec1-1/+1
clogs logs quite a bit
2020-05-29kernel: ResourceLimit::Reserve remove useless while loopDavid Marcec1-5/+1
Timeout is a u64, it will always be >= 0
2020-05-03kernel/memory: Remove #pragma once within cpp fileLioncash1-2/+0
This isn't necessary in a cpp file and will cause warnings on clang.
2020-05-03kernel/memory: Remove unused includesLioncash7-8/+1
Prevents header churn and needing to recompile these files if these headers are ever changed in the future.
2020-05-03kernel/memory: Remove unused variables in memory_block_managerLioncash1-3/+0
Prevents unused variable warnings.
2020-05-03kernel/memory: Make use of std::array consistently in address_space_infoLioncash1-6/+6
This allows tuning standard library implementations to enable or disable range checks at runtime, which is nicer for debugging.
2020-05-03kernel/memory: Resolve -Wshadow warningsLioncash1-4/+4
Prevents variable name clashing.
2020-05-03kernel/memory: Amend potential encoding warningsLioncash6-12/+12
While èis generally representable in some language encodings, in some it isn't and will result in compilation warnings occurring. To remain friendly with other language's codepages on Windows, we normalize it to an ASCII e.
2020-05-03hle_ipc: Eliminate core memory globalsLioncash3-10/+16
We can just pass the required instances into the constructor of the request, eliminating all usages of the global system accessor.
2020-05-02readable_event: Remove unnecessary semicolon in Signal()Lioncash1-4/+6
Resolves a -Wextra-semi warning. While we're at it, we can invert the branch to form a guard clause, unindenting all of the contained code.
2020-04-29kernel: Don't fail silentlyDavid Marcec7-0/+51
2020-04-28kernel: Bad GetInfo ids should not be marked as stubsDavid Marcec1-2/+2
As we currently match hardware and don't return a successful result, these should be marked as errors instead of warnings and as stubs.
2020-04-24physical_core: Make use of std::make_unique instead of std::make_shared in ctorLioncash1-1/+3
We can also allow unicorn to be constructed in 32-bit mode or 64-bit mode to satisfy the need for both interpreter instances. Allows this code to compile successfully of non x86-64 architectures.
2020-04-24shared_memory: Amend doxygen referenceLioncash2-5/+5
Amends the parameter to match the documentation reference. Resolves a -Wdocumentation warning with clang.
2020-04-24svc: Re-add MapProcessCodeMemory/UnmapProcessCodeMemoryLioncash1-2/+138
These were lost in the re-implementation of the virtual memory manager.
2020-04-23svc: Remove unused variableLioncash1-3/+0
Since the VMM refactor, this is no longer used or needed.
2020-04-23page_table: Remove unused capturesLioncash1-2/+2
Any time the lambda function is called, the permission being used in the capture would be passed in as an argument to the lambda, so the capture is unnecessary.
2020-04-23kernel: memory: Improve implementation of device shared memory. (#3707)bunnei5-3/+105
* kernel: memory: Improve implementation of device shared memory. * fixup! kernel: memory: Improve implementation of device shared memory. * fixup! kernel: memory: Improve implementation of device shared memory.
2020-04-19thread: FPCR.FZ is likely not 1MerryMage1-2/+1
2020-04-18memory/slab_heap: Make use of static_cast over reinterpret_castLioncash1-2/+2
Casting from void* with static_cast is permitted by the standard, so we can just make use of that instead.
2020-04-17core: hle: Address various feedback & code cleanup.bunnei9-236/+139
- Should be no functional changes.
2020-04-17memory: Add copyright notice for Atmosphere where applicable.bunnei6-0/+18
2020-04-17kernel: Remove old VMManager class.bunnei2-1971/+0
2020-04-17kernel: memory: page_table: Simplify GetPhysicalAddr impl.bunnei2-5/+3
2020-04-17kernel: svc: Updates for new VMM.bunnei1-488/+116
- Includes removing some SVC impls. that are untested.
2020-04-17kernel: process: Updates for new VMM.bunnei2-79/+151
2020-04-17kernel: resource_limit: Reserve physical memory.bunnei1-1/+6
2020-04-17kernel: Initialize memory layout for new VMM.bunnei2-0/+159
2020-04-17core: system: Rename GetDeviceManager -> DeviceManager.bunnei1-1/+1
- More consistent with other system components.
2020-04-17kernel: transfer_memory: Refactor for new VMM.bunnei2-130/+16
2020-04-17kernel: shared_memory: Refactor for new VMM.bunnei2-220/+58
2020-04-17kernel: errors: Add ERR_OUT_OF_RESOURCES.bunnei1-0/+1
2020-04-17kernel: process_capability: Update to use Memory::PageTable.bunnei2-23/+25
2020-04-17kernel: memory: Add PageTable class, to manage process address space.bunnei2-0/+1508
2020-04-17kernel: memory: Add MemoryLayout class, to build physical memory layout.bunnei1-0/+73
2020-04-17kernel: memory: Add MemoryManager class, to manage page heaps.bunnei2-0/+274
2020-04-17kernel: memory: Add MemoryBlockManager class, to manage memory blocks.bunnei2-0/+254
2020-04-17kernel: memory: Add PageHeap class, to manage a heap of pages.bunnei2-0/+481
2020-04-17kernel: memory: Add PageLinkedList class, to manage a list of pages.bunnei1-0/+93
2020-04-17kernel: memory: Add system_control code, which will be used for ASLR support.bunnei2-0/+59
2020-04-17physical_memory: Add missing include for <vector>.bunnei1-0/+2
2020-04-17kernel: memory: Add MemoryBlock class, for managing memory blocks and their state.bunnei1-0/+315
2020-04-17kernel: memory: Add memory_types.h, for things that are commonly used in memory code.bunnei1-0/+18
2020-04-17kernel: memory: Add SlabHeap class, for managing memory heaps.bunnei1-0/+161
- This will be used for TLS pages, among other things.
2020-04-17kernel: memory: Add AddressSpaceInfo class, for managing the memory address space.bunnei2-0/+164
2020-04-17core: memory: Move to Core::Memory namespace.bunnei8-25/+29
- helpful to disambiguate Kernel::Memory namespace.
2020-04-17core: kernel: Add svc_types header to include SVC-specific types.bunnei2-0/+69
2020-04-17core: kernel: Move SVC to its own namesapce.bunnei2-6/+6
2020-04-17kernel: resource_limit: Improvements to implementation.bunnei2-12/+50
2020-04-17process: SetupMainThread: Zero out argument on process start.bunnei1-0/+2
2020-04-17hle_ipc: Remove std::size_t casts where applicableLioncash2-21/+23
These were added in the change that enabled -Wextra on linux builds so as not to introduce interface changes in the same change as a build-system flag addition. Now that the flags are enabled, we can freely change the interface to make these unnecessary.
2020-04-16CMakeLists: Specify -Wextra on linux buildsLioncash1-12/+12
Allows reporting more cases where logic errors may exist, such as implicit fallthrough cases, etc. We currently ignore unused parameters, since we currently have many cases where this is intentional (virtual interfaces). While we're at it, we can also tidy up any existing code that causes warnings. This also uncovered a few bugs as well.
2020-04-15CMakeLists: Make -Wreorder a compile-time errorLioncash1-1/+1
This can result in silent logic bugs within code, and given the amount of times these kind of warnings are caused, they should be flagged at compile-time so no new code is submitted with them.
2020-04-15kernel/thread: Resolve -Wswitch warningsLioncash1-0/+2
2020-03-03core: hle: Implement separate A32/A64 SVC interfaces.bunnei2-107/+380
2020-03-03core: Implement separate A32/A64 ARM interfaces.bunnei8-36/+73
2020-02-22Scheduler: Inline global scheduler in Scheduler Lock.Fernando Sahmkow1-4/+2
2020-02-22Kernel: Correct pending feedback.Fernando Sahmkow1-3/+4
2020-02-22Kernel: Address Feedback.Fernando Sahmkow6-30/+47
2020-02-22Kernel: Implement Scheduler locksFernando Sahmkow2-0/+89
2020-02-22Kernel: Implement Time Manager.Fernando Sahmkow4-1/+96
2020-02-22Kernel: Rename ThreadCallbackHandleTable and Setup Thread Ids on Kernel.Fernando Sahmkow4-24/+105
2020-02-22Kernel: Make global scheduler depend on KernelCoreFernando Sahmkow4-8/+24
2020-02-14Core: Address FeedbackFernando Sahmkow5-16/+27
2020-02-12address_arbiter: Collapse loops in InsertThread() and RemoveThread()Lioncash1-19/+17
Same behavior, but without the need to explicitly loop through everything manually.
2020-02-12address_arbiter: Simplify GetThreadsWaitingOnAddress()Lioncash2-10/+9
Simplifies the overall function and also allows for it to become a const-qualified member function.
2020-02-12kernel/thread: Remove trivial usages of the global system accessorLioncash1-2/+2
We can just use the kernel member variable directly instead of going through the system to obtain the same thing.
2020-02-12Core: Set all hardware emulation constants in a single file.Fernando Sahmkow3-19/+21
2020-02-11Kernel: Refactor synchronization to better match REFernando Sahmkow22-80/+210
2020-02-11Kernel: Change WaitObject to Synchronization object. In order to better reflect RE.Fernando Sahmkow19-71/+76
2020-02-06kernel: transfer_memory: Properly reserve and reset memory region.bunnei5-40/+116
2020-02-06wait_object: Make wait behavior only require one object to signal.Zach Hilman1-11/+2
- This was holdover from citra.
2020-02-06hle_ipc: Add error checking to read/write buffer access.bunnei1-8/+42
2020-01-31kernel/physical_core: Make use of std::unique_ptrLioncash2-4/+10
shared_ptr was used in 2d1984c20c75e03ec79eeb3806b12efa1679b977 due to a misunderstanding of how the language generates move constructors and move assignment operators. If a destructor is user-provided, then the compiler won't generate the move constructor and move assignment operators by default--they must be explicitly opted into. The reason for the compilation errors is due to the fact that the language will fall back to attempting to use the copy constructor/copy assignment operators if the respective move constructor or move assignment operator is unavailable. Given that we explicitly opt into them now, the the move constructor and move assignment operators will be generated as expected.
2020-01-31kernel/physical_core: Remove unused kernel reference member variableLioncash3-11/+7
This isn't used within the class, so it can be removed to simplify the overall interface. While we're in the same area, we can simplify a unique_ptr reset() call.
2020-01-27System: Address FeedbackFernando Sahmkow4-10/+20
2020-01-26Kernel: Remove a few global instances from the kernel.Fernando Sahmkow2-2/+2
2020-01-26Core: Refactor CpuCoreManager to CpuManager and Cpu to Core Manager.Fernando Sahmkow5-6/+2
This commit instends on better naming the new purpose of this classes.
2020-01-26ArmInterface: Delegate Exclusive monitor factory to exclusive monitor interfasce.Fernando Sahmkow1-15/+2
2020-01-25Core: Refactor CPU Management.Fernando Sahmkow4-12/+127
This commit moves ARM Interface and Scheduler handling into the kernel.
2020-01-24Kernel: Implement Physical Core.Fernando Sahmkow2-0/+81
2020-01-18core/memory: Create a special MapMemoryRegion for physical memory.Markus Wick2-3/+5
This allows us to create a fastmem arena within the memory.cpp helpers.
2020-01-18core/hle: Simplify PhysicalMemory usage in vm_manager.Markus Wick1-23/+11
2020-01-11core/kernel: Fix GetTotalPhysicalMemoryUsed.Markus Wick1-2/+2
module._memory was already moved over to a new shared_ptr. So code_memory_size was not increased at all. This lowers the heap space and so saves a bit of memory, usually between 50 to 100 MB. This fixes a regression of c0a01f3adc466d07fc27020048e82cca60988970
2019-12-11Kernel: Correct behavior of Address Arbiter threads. (#3165)Fernando Sahmkow3-24/+67
* Kernel: Correct behavior of Address Arbiter threads. This corrects arbitration threads to behave just like in Horizon OS. They are added into a container and released according to what priority they had when added. Horizon OS does not reorder them if their priority changes. * Kernel: Address Feedback.
2019-12-11kernel/svc: Correct function signature of SignalProcessWideKeyLioncash2-9/+6
This function doesn't actually return a result code, so we can amend the signature of it to match.
2019-12-08kernel: Remove unnecessary includesLioncash15-11/+17
Over the course of the changes to the kernel code, a few includes are no longer necessary, particularly with the change over to std::shared_ptr from Boost's intrusive_ptr.
2019-12-08kernel/svc: Provide implementations for svcDumpInfo/svcDumpInfoNewLioncash2-2/+24
These are fairly trivial to implement, we can just do nothing. This also provides a spot for us to potentially dump out any relevant info in the future (e.g. for debugging purposes with homebrew, etc). While we're at it, we can also correct the names of both of these supervisor calls.
2019-12-05CpuCore: Clear exclusive state after doing a run in dynarmic.Fernando Sahmkow1-1/+0
This commit corrects an error in which a Core could remain with an exclusive state after running, leaving space for possible race conditions between changing cores.
2019-11-28kernel: Implement a more accurate IPC dispatch.bunnei12-142/+214
2019-11-27core/memory; Migrate over SetCurrentPageTable() to the Memory classLioncash1-7/+11
Now that literally every other API function is converted over to the Memory class, we can just move the file-local page table into the Memory implementation class, finally getting rid of global state within the memory code.
2019-11-27core/memory: Migrate over Write{8, 16, 32, 64, Block} to the Memory classLioncash4-21/+25
The Write functions are used slightly less than the Read functions, which make these a bit nicer to move over. The only adjustments we really need to make here are to Dynarmic's exclusive monitor instance. We need to keep a reference to the currently active memory instance to perform exclusive read/write operations.
2019-11-27core/memory: Migrate over Read{8, 16, 32, 64, Block} to the Memory classLioncash4-22/+36
With all of the trivial parts of the memory interface moved over, we can get right into moving over the bits that are used. Note that this does require the use of GetInstance from the global system instance to be used within hle_ipc.cpp and the gdbstub. This is fine for the time being, as they both already rely on the global system instance in other functions. These will be removed in a change directed at both of these respectively. For now, it's sufficient, as it still accomplishes the goal of de-globalizing the memory code.
2019-11-27core/memory: Migrate over ReadCString() to the Memory classLioncash1-2/+4
This only had one usage spot, so this is fairly straightforward to convert over.
2019-11-27core/memory: Migrate over GetPointer()Lioncash1-1/+2
With all of the interfaces ready for migration, it's trivial to migrate over GetPointer().
2019-11-27core: Prepare various classes for memory read/write migrationLioncash5-6/+18
Amends a few interfaces to be able to handle the migration over to the new Memory class by passing the class by reference as a function parameter where necessary. Notably, within the filesystem services, this eliminates two ReadBlock() calls by using the helper functions of HLERequestContext to do that for us.
2019-11-27core/memory: Migrate over address checking functions to the new Memory classLioncash3-8/+8
A fairly straightforward migration. These member functions can just be mostly moved verbatim with minor changes. We already have the necessary plumbing in places that they're used. IsKernelVirtualAddress() can remain a non-member function, since it doesn't rely on class state in any form.
2019-11-27core/memory: Migrate over memory mapping functions to the new Memory classLioncash1-6/+7
Migrates all of the direct mapping facilities over to the new memory class. In the process, this also obsoletes the need for memory_setup.h, so we can remove it entirely from the project.
2019-11-27core_timing: Use better reference tracking for EventType. (#3159)bunnei2-7/+8
* core_timing: Use better reference tracking for EventType. - Moves ownership of the event to the caller, ensuring we don't fire events for destroyed objects. - Removes need for unique names - we won't be using this for save states anyways.
2019-11-26kernel: Fix reference management for client/server session.bunnei3-20/+18
- Fixes shutdown crash and crash in Pokemon SwSh.
2019-11-25kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. (#3154)bunnei36-299/+301
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. - See https://github.com/citra-emu/citra/pull/4710 for details.
2019-11-23Update svc.cppbunnei1-0/+1
2019-11-23svc: GetSystemTick should return cntpct_el0, not core ticks.bunnei1-1/+3
2019-11-21Kernel: Optimize condition variable threads management.Fernando Sahmkow4-24/+21
2019-11-21Kernel: Correct SignalProcessWideKeyFernando Sahmkow1-6/+2
When the target is 0, all threads must be processed.
2019-11-21Kernel: Correct behavior of Condition Variables to be more similar to real hardware.Fernando Sahmkow5-15/+74
This commit ensures cond var threads act exactly as they do in the real console. The original implementation uses an RBTree and the behavior of cond var threads is that at the same priority level they act like a FIFO.
2019-11-16Kernel: Correct Cancel Synchronization.Fernando Sahmkow3-2/+19
This commit corrects the behavior of cancel synchronization when the thread is running/ready and ensures the next wait is cancelled as it's suppose to.
2019-11-12kernel: Resolve sign conversion warningsLioncash4-72/+60
Uncovered a bug within Thread's SetCoreAndAffinityMask() where an unsigned variable (ideal_core) was being compared against "< 0", which would always be a false condition. We can also get rid of an unused function (GetNextProcessorId) which contained a sign mismatch warning.
2019-11-03kernel: readable_event: Signal only once.bunnei1-2/+4
2019-11-03kernel: events: Remove ResetType::Automatic.bunnei7-29/+4
- This does not actually seem to exist in the real kernel - games reset these automatically. # Conflicts: # src/core/hle/service/am/applets/applets.cpp # src/core/hle/service/filesystem/fsp_srv.cpp
2019-11-03kernel: readable_event: Initialize members.bunnei1-1/+1
2019-10-28scheduler: Mark parameter of AskForReselectionOrMarkRedundant() as constLioncash2-5/+5
This is only compared against, so it can be made const.
2019-10-28scheduler: Silence sign conversion warningsLioncash1-5/+5
2019-10-28scheduler: Initialize class members directly where applicableLioncash2-6/+4
Reduces the overall amount of code.
2019-10-28scheduler: Amend documentation commentsLioncash2-75/+59
Adjusts the formatting of a few of the comments an ensures they get recognized as proper Doxygen comments.
2019-10-15Kernel Thread: Cleanup THREADPROCESSORID_DONT_UPDATE.Fernando Sahmkow2-4/+1
2019-10-15Kernel: Address Feedback 2Fernando Sahmkow2-9/+6
2019-10-15Kernel: Clang FormatFernando Sahmkow2-5/+5
2019-10-15Kernel: Reverse global accessor removal.Fernando Sahmkow4-23/+9
2019-10-15Kernel: Address Feedback.Fernando Sahmkow6-67/+98
2019-10-15Kernel Scheduler: Make sure the global scheduler shutdowns correctly.Fernando Sahmkow3-0/+17
2019-10-15Kernel_Thread: Eliminate most global accessors.Fernando Sahmkow1-11/+11
2019-10-15KernelSVC: Assert that condition variable address is aligned to 4 bytes.Fernando Sahmkow1-0/+4
2019-10-15Kernel: Correct Paused schedulingFernando Sahmkow1-3/+1
2019-10-15Kernel: Corrections to Wait Objects clearing in which a thread could still be signalled after a timeout or a cancel.Fernando Sahmkow3-3/+4
2019-10-15Kernel: Correct redundant yields to only advance time forward.Fernando Sahmkow1-3/+5
2019-10-15Kernel: Corrections to ModifyByWaitingCountAndSignalToAddressIfEqualFernando Sahmkow1-5/+13
2019-10-15Kernel: Correct Results in Condition Variables and MutexesFernando Sahmkow3-24/+17
2019-10-15Kernel: Clang FormatFernando Sahmkow2-2/+3
2019-10-15Kernel: Remove global system accessor from WaitObjectFernando Sahmkow4-2/+17
2019-10-15Scheduler: Implement Yield Count and Core migration on Thread Preemption.Fernando Sahmkow2-5/+85
2019-10-15Scheduler: Corrections to YieldAndBalanceLoad and Yield bombing protection.Fernando Sahmkow2-8/+8
2019-10-15Kernel: Initial implementation of thread preemption.Fernando Sahmkow3-0/+30
2019-10-15Scheduler: Add protections for Yield bombingFernando Sahmkow5-24/+31
In case of redundant yields, the scheduler will now idle the core for it's timeslice, in order to avoid continuously yielding the same thing over and over.
2019-10-15Kernel: Style and CorrectionsFernando Sahmkow8-90/+130
2019-10-15Correct PrepareRescheduleFernando Sahmkow3-37/+20
2019-10-15Comment and reorganize the schedulerFernando Sahmkow2-98/+104
2019-10-15Add PrepareReschedule where required.Fernando Sahmkow3-16/+18
2019-10-15Correct compiling errors and addapt to the new interface.Fernando Sahmkow1-4/+1
2019-10-15Correct Supervisor Calls to work with the new scheduler,Fernando Sahmkow1-26/+41
2019-10-15Add interfacing to the Global SchedulerFernando Sahmkow2-0/+17
2019-10-15Addapt thread class to the new SchedulerFernando Sahmkow2-60/+237
2019-10-15Implement a new Core SchedulerFernando Sahmkow2-258/+411
2019-10-06core: Remove Core::CurrentProcess()Lioncash1-1/+1
This only encourages the use of the global system instance (which will be phased out long-term). Instead, we use the direct system function call directly to remove the appealing but discouraged short-hand.
2019-09-05kernel/vm_manager: Correct doxygen comment parameter tags for MapPhysicalMemory/UnmapPhysicalMemoryLioncash1-4/+4
Corrects the parameter names within the doxygen comments so that they resolve properly.
2019-09-05kernel/vm_manager: Move variables closer to usage spots in MapPhysicalMemory/UnmapPhysicalMemoryLioncash1-16/+10
Narrows the scope of variables down to where they're only necessary.
2019-08-30kernel/vm_manager: Correct behavior in failure case of UnmapPhysicalMemory()Lioncash1-0/+2
If an unmapping operation fails, we shouldn't be decrementing the amount of memory mapped and returning that the operation was successful. We should actually be returning the error code in this case.
2019-08-30kernel/vm_manager: Reserve memory ahead of time for slow path in MergeAdjacentVMALioncash1-1/+4
Avoids potentially expensive (depending on the size of the memory block) allocations by reserving the necessary memory before performing both insertions. This avoids scenarios where the second insert may cause a reallocation to occur.
2019-08-30kernel/vm_manager: std::move shared_ptr instance in MergeAdjacentVMALioncash1-1/+1
Avoids an unnecessary atomic reference count increment and decrement.
2019-08-30kernel/vm_manager: Deduplicate iterator creation in MergeAdjacentVMALioncash1-7/+10
Avoids needing to read the same long sequence of code in both code paths. Also makes it slightly nicer to read and debug, as the locals will be able to be shown in the debugger.
2019-08-30kernel/vm_manager: Simplify some std::vector constructor callsLioncash1-2/+2
Same behavior, one less magic constant to read.
2019-08-30kernel/vm_manager: Simplify some assertion messagesLioncash1-10/+10
Assertions already log out the function name, so there's no need to manually include the function name in the assertion strings.
2019-07-19Kernel: Address FeedbackFernando Sahmkow2-3/+9
2019-07-19VM_Manager: Align allocated memory to 256bytesFernando Sahmkow9-26/+42
This commit ensures that all backing memory allocated for the Guest CPU is aligned to 256 bytes. This due to how gpu memory works and the heavy constraints it has in the alignment of physical memory.
2019-07-18Kernel: Downgrade WaitForAddress and SignalToAddress messages to Trace.Fernando Sahmkow1-4/+4
This messages were originally set as warnning since few games used these svcs and it was needed for debugging. This is no longer the case.
2019-07-12Remove unicorn mappings/unmappingsMichael Scire1-19/+0
2019-07-11core/arm: Remove obsolete Unicorn memory mappingLioncash1-20/+0
This was initially necessary when AArch64 JIT emulation was in its infancy and all memory-related instructions weren't implemented. Given the JIT now has all of these facilities implemented, we can remove these functions from the CPU interface.
2019-07-11Restore memory perms on svcUnmapMemory/UnloadNroMichael Scire1-1/+8
Prior to PR, Yuzu did not restore memory to RW- on unmap of mirrored memory or unloading of NRO. (In fact, in the NRO case, the memory was unmapped instead of reprotected to --- on Load, so it was actually lost entirely...) This PR addresses that, and restores memory to RW- as it should. This fixes a crash in Super Smash Bros when creating a World of Light save for the first time, and possibly other games/circumstances.
2019-07-09Prevent merging of device mapped memory blocks.Michael Scire1-0/+5
This sets the DeviceMapped attribute for GPU-mapped memory blocks, and prevents merging device mapped blocks. This prevents memory mapped from the gpu from having its backing address changed by block coalesce.
2019-07-07Remove unused member function declarationMichael Scire1-9/+0
2019-07-07physmem: add helpers, cleanup logic.Michael Scire2-171/+170
2019-07-07clang-format fixesMichael Scire2-3/+3
2019-07-07address review commentaryMichael Scire5-36/+42
2019-07-07Implement MapPhysicalMemory/UnmapPhysicalMemoryMichael Scire6-20/+468
This implements svcMapPhysicalMemory/svcUnmapPhysicalMemory for Yuzu, which can be used to map memory at a desired address by games since 3.0.0. It also properly parses SystemResourceSize from NPDM, and makes information available via svcGetInfo. This is needed for games like Super Smash Bros. and Diablo 3 -- this PR's implementation does not run into the "ASCII reads" issue mentioned in the comments of #2626, which was caused by the following bugs in Yuzu's memory management that this PR also addresses: * Yuzu's memory coalescing does not properly merge blocks. This results in a polluted address space/svcQueryMemory results that would be impossible to replicate on hardware, which can lead to game code making the wrong assumptions about memory layout. * This implements better merging for AllocatedMemoryBlocks. * Yuzu's implementation of svcMirrorMemory unprotected the entire virtual memory range containing the range being mirrored. This could lead to games attempting to map data at that unprotected range/attempting to access that range after yuzu improperly unmapped it. * This PR fixes it by simply calling ReprotectRange instead of Reprotect.
2019-07-07kernel/process: Allocate the process' TLS region during initializationLioncash3-3/+14
Prior to execution within a process beginning, the process establishes its own TLS region for uses (as far as I can tell) related to exception handling. Now that TLS creation was decoupled from threads themselves, we can add this behavior to our Process class. This is also good, as it allows us to remove a stub within svcGetInfo, namely querying the address of that region.
2019-07-07kernel/process: Move main thread stack allocation to its own functionLioncash2-12/+17
Keeps this particular set of behavior isolated to its own function.
2019-07-06kernel/vm_manager: Rename 'new map' to 'stack'Lioncash3-37/+37
Provides a more accurate name for the memory region and also disambiguates between the map and new map regions of memory, making it easier to understand.
2019-07-06kernel/vm_manager: Handle stack/TLS IO region placement betterLioncash1-2/+13
Handles the placement of the stack a little nicer compared to the previous code, which was off in a few ways. e.g. The stack (new map) region, shouldn't be the width of the entire address space if the size of the region calculation ends up being zero. It should be placed at the same location as the TLS IO region and also have the same size. In the event the TLS IO region contains a size of zero, we should also be doing the same thing. This fixes our memory layout a little bit and also resolves some cases where assertions can trigger due to the memory layout being incorrect.
2019-07-04kernel/process: Default initialize all member variablesLioncash1-2/+2
Ensures a Process instance is always created with a deterministic initial state.
2019-07-04kernel/process: Decouple TLS handling from threadsLioncash4-66/+97
Extracts out all of the thread local storage management from thread instances themselves and makes the owning process handle the management of the memory. This brings the memory management slightly more in line with how the kernel handles these allocations. Furthermore, this also makes the TLS page management a little more readable compared to the lingering implementation that was carried over from Citra.
2019-07-04kernel/vm_manager: Add overload of FindFreeRegion() that operates on a boundaryLioncash2-13/+49
This will be necessary for making our TLS slot management slightly more straightforward. This can also be utilized for other purposes in the future. We can implement the existing simpler overload in terms of this one anyways, we just pass the beginning and end of the ASLR region as the boundaries.
2019-06-16Core_Timing: Make core_timing threadsafe by default.Fernando Sahmkow1-3/+3
The old implementation had faulty Threadsafe methods where events could be missing. This implementation unifies unsafe/safe methods and makes core timing thread safe overall.
2019-06-12kernel/vm_manager: Remove redundant Reset call in destructorLioncash1-3/+1
This is performing more work than would otherwise be necessary during VMManager's destruction. All we actually want to occur in this scenario is for any allocated memory to be freed, which will happen automatically as the VMManager instance goes out of scope. Anything else being done is simply unnecessary work.
2019-06-10kernel: Differentiate kernel and user processes when picking IDZach Hilman4-8/+25
This allows kernel internal type processes to be assigned IDs in the KIP range while userland processes are assigned in the user range.
2019-06-10kernel/process: Make Create()'s name parameter be taken by valueLioncash2-2/+2
Makes the interface more flexible in terms of how Create() may be called, while still allowing the parameter itself to be moved into.
2019-06-10kernel/svc: Implement TotalMemoryUsedWithoutMmHeap/TotalMemoryAvailableWithoutMmHeapLioncash3-2/+42
Given we don't currently implement the personal heap yet, the existing memory querying functions are essentially doing what the memory querying types introduced in 6.0.0 do. So, we can build the necessary machinery over the top of those and just use them as part of info types.
2019-06-10kernel/svc: Amend naming for TotalMemoryUsage in svcGetInfo()Lioncash3-6/+6
Disambiguates and makes the name a little more consistent with TotalPhysicalMemoryUsed.
2019-06-10kernel/svc: Remove duplicate enum entry in svcGetInfo()Lioncash1-2/+1
2019-06-05kernel/process: Remove unused boost header includeLioncash1-1/+0
Boost headers typically include a lot of other headers, so removing this can prevent a bit of unnecessary compiler churn when building.
2019-06-05core/core_timing_util: Use std::chrono types for specifying time unitsLioncash1-2/+2
Makes the interface more type-safe and consistent in terms of return values.
2019-05-25svc: Save report on call to svcBreakZach Hilman1-1/+7
2019-05-19Address review commentTobias1-1/+1
Co-Authored-By: Mat M. <mathew1800@gmail.com>
2019-05-19kernel/svc: Mark GetThreadList() and UnmapProcessCodeMemory() as internally linkedLioncash1-4/+4
These are only used from within this translation unit, so they don't need to have external linkage. They were intended to be marked with this anyways to be consistent with the other service functions.
2019-05-18core/kernel/object: Rename ResetType enum membersLioncash4-5/+6
Renames the members to more accurately indicate what they signify. "OneShot" and "Sticky" are kind of ambiguous identifiers for the reset types, and can be kind of misleading. Automatic and Manual communicate the kind of reset type in a clearer manner. Either the event is automatically reset, or it isn't and must be manually cleared. The "OneShot" and "Sticky" terminology is just a hold-over from Citra where the kernel had a third type of event reset type known as "Pulse". Given the Switch kernel only has two forms of event reset types, we don't need to keep the old terminology around anymore.
2019-05-18HLE/IPC: HLEContext can memorize the client thread and use it for SleepClientThreadWeiyi Wang3-8/+9
This reduces the boilerplate that services have to write out the current thread explicitly. Using current thread instead of client thread is also semantically incorrect, and will be a problem when we implement multicore (at which time there will be multiple current threads)
2019-04-29kernel/svc: Make svcCreateThread/svcStartThread/svcSleepThread/svcExitThread calls show up in the debug logLioncash1-4/+4
These are actually quite important indicators of thread lifetimes, so they should be going into the debug log, rather than being treated as misc info and delegated to the trace log.
2019-04-29kernel/svc: Reorganize svcSetThreadCoreMask()Lioncash1-32/+39
Makes the code much nicer to follow in terms of behavior and control flow. It also fixes a few bugs in the implementation. Notably, the thread's owner process shouldn't be accessed in order to retrieve the core mask or ideal core. This should be done through the current running process. The only reason this bug wasn't encountered yet is because we currently only support running one process, and thus every owner process will be the current process. We also weren't checking against the process' CPU core mask to see if an allowed core is specified or not. With this out of the way, it'll be less noisy to implement proper handling of the affinity flags internally within the kernel thread instances.
2019-04-29kernel/thread: Update thread processor ID flagsLioncash2-7/+16
Adds the missing flags to the enum and documents them.
2019-04-19kernel/svc: Name supervisor call 0x36Lioncash1-1/+1
This call was added to the SVC handlers in the 8.0.0 kernel, so we can finally give it a name.
2019-04-17kernel/thread: Unify wait synchronization typesLioncash6-38/+34
This is a holdover from Citra, where the 3DS has both WaitSynchronization1 and WaitSynchronizationN. The switch only has one form of wait synchronizing (literally WaitSynchonization). This allows us to throw out code that doesn't apply at all to the Switch kernel. Because of this unnecessary dichotomy within the wait synchronization utilities, we were also neglecting to properly handle waiting on multiple objects. While we're at it, we can also scrub out any lingering references to WaitSynchronization1/WaitSynchronizationN in comments, and change them to WaitSynchronization (or remove them if the mention no longer applies).
2019-04-17kernel/svc: Migrate svcCancelSynchronization behavior to a thread functionLioncash3-7/+17
The actual behavior of this function is slightly more complex than what we're currently doing within the supervisor call. To avoid dumping most of this behavior in the supervisor call itself, we can migrate this to another function.
2019-04-17kernel/wait_object: Make GetHighestPriorityReadyThread() a const member functionLioncash2-2/+2
This doesn't actually modify internal state of a wait object, so it can be const qualified.
2019-04-17kernel/vm_manager: Remove usages of global system accessorsLioncash3-7/+11
Makes the dependency on the system instance explicit within VMManager's interface.
2019-04-15svc: Specify handle value in thread's nameLioncash2-2/+10
Allows the handle to be seen alongside the entry point.
2019-04-15kernel/thread: Remove BoostPriority()Lioncash2-11/+0
This is a holdover from Citra that currently remains unused, so it can be removed from the Thread interface.
2019-04-14kernel/thread: Remove unused guest_handle member variableLioncash3-16/+7
This member variable is entirely unused. It was only set but never actually utilized. Given that, we can remove it to get rid of noise in the thread interface.
2019-04-13kernel/svc: Implement svcUnmapProcessCodeMemoryLioncash3-1/+143
Essentially performs the inverse of svcMapProcessCodeMemory. This unmaps the aliasing region first, then restores the general traits of the aliased memory. What this entails, is: - Restoring Read/Write permissions to the VMA. - Restoring its memory state to reflect it as a general heap memory region. - Clearing the memory attributes on the region.
2019-04-13kernel/svc: Implement svcMapProcessCodeMemoryLioncash4-1/+131
This is utilized for mapping code modules into memory. Notably, the ldr service would call this in order to map objects into memory.
2019-04-12core/core: Move process execution start to System's Load()Lioncash2-8/+11
This gives us significantly more control over where in the initialization process we start execution of the main process. Previously we were running the main process before the CPU or GPU threads were initialized (not good). This amends execution to start after all of our threads are properly set up.
2019-04-12core/process: Remove unideal page table setting from LoadFromMetadata()Lioncash1-5/+0
Initially required due to the split codepath with how the initial main process instance was initialized. We used to initialize the process like: Init() { main_process = Process::Create(...); kernel.MakeCurrentProcess(main_process.get()); } Load() { const auto load_result = loader.Load(*kernel.GetCurrentProcess()); if (load_result != Loader::ResultStatus::Success) { // Handle error here. } ... } which presented a problem. Setting a created process as the main process would set the page table for that process as the main page table. This is fine... until we get to the part that the page table can have its size changed in the Load() function via NPDM metadata, which can dictate either a 32-bit, 36-bit, or 39-bit usable address space. Now that we have full control over the process' creation in load, we can simply set the initial process as the main process after all the loading is done, reflecting the potential page table changes without any special-casing behavior. We can also remove the cache flushing within LoadModule(), as execution wouldn't have even begun yet during all usages of this function, now that we have the initialization order cleaned up.
2019-04-12core/cpu_core_manager: Create threads separately from initialization.Lioncash2-2/+7
Our initialization process is a little wonky than one would expect when it comes to code flow. We initialize the CPU last, as opposed to hardware, where the CPU obviously needs to be first, otherwise nothing else would work, and we have code that adds checks to get around this. For example, in the page table setting code, we check to see if the system is turned on before we even notify the CPU instances of a page table switch. This results in dead code (at the moment), because the only time a page table switch will occur is when the system is *not* running, preventing the emulated CPU instances from being notified of a page table switch in a convenient manner (technically the code path could be taken, but we don't emulate the process creation svc handlers yet). This moves the threads creation into its own member function of the core manager and restores a little order (and predictability) to our initialization process. Previously, in the multi-threaded cases, we'd kick off several threads before even the main kernel process was created and ready to execute (gross!). Now the initialization process is like so: Initialization: 1. Timers 2. CPU 3. Kernel 4. Filesystem stuff (kind of gross, but can be amended trivially) 5. Applet stuff (ditto in terms of being kind of gross) 6. Main process (will be moved into the loading step in a following change) 7. Telemetry (this should be initialized last in the future). 8. Services (4 and 5 should ideally be alongside this). 9. GDB (gross. Uses namespace scope state. Needs to be refactored into a class or booted altogether). 10. Renderer 11. GPU (will also have its threads created in a separate step in a following change). Which... isn't *ideal* per-se, however getting rid of the wonky intertwining of CPU state initialization out of this mix gets rid of most of the footguns when it comes to our initialization process.
2019-04-11kernel: Make handle type declarations constexprLioncash10-10/+10
Some objects declare their handle type as const, while others declare it as constexpr. This makes the const ones constexpr for consistency, and prevent unexpected compilation errors if these happen to be attempted to be used within a constexpr context.
2019-04-10kernel/server_session: Remove obsolete TODOsLioncash1-7/+2
These are holdovers from Citra.
2019-04-09kernel/process: Set page table when page table resizes occur.Lioncash1-0/+2
We need to ensure dynarmic gets a valid pointer if the page table is resized (the relevant pointers would be invalidated in this scenario). In this scenario, the page table can be resized depending on what kind of address space is specified within the NPDM metadata (if it's present).
2019-04-08kernel/svc: Deglobalize the supervisor call handlersLioncash3-322/+373
Adjusts the interface of the wrappers to take a system reference, which allows accessing a system instance without using the global accessors. This also allows getting rid of all global accessors within the supervisor call handling code. While this does make the wrappers themselves slightly more noisy, this will be further cleaned up in a follow-up. This eliminates the global system accessors in the current code while preserving the existing interface.
2019-04-07kernel: Handle page table switching within MakeCurrentProcess()Lioncash3-4/+2
Centralizes the page table switching to one spot, rather than making calling code deal with it everywhere.
2019-04-06kernel/server_session: Return a std::pair from CreateSessionPair()Lioncash3-8/+7
Keeps the return type consistent with the function name. While we're at it, we can also reduce the amount of boilerplate involved with handling these by using structured bindings.
2019-04-06kernel/server_port: Return a std::pair from CreatePortPair()Lioncash2-7/+7
Returns the same type that the function name describes.
2019-04-04kernel/svc: Properly sanitize mutex address in WaitProcessWideKeyAtomicLioncash1-0/+14
We need to be checking whether or not the given address is within the kernel address space or if the given address isn't word-aligned and bail in these scenarios instead of trashing any kernel state.
2019-04-03kernel/transfer_memory: Add accessors to data and sizesLioncash2-11/+31
Also amend erroneous use of size_t. We should be using u64 here.
2019-04-03kernel/server_session: Provide a GetName() overrideLioncash1-0/+4
Given server sessions can be given a name, we should allow retrieving it instead of using the default implementation of GetName(), which would just return "[UNKNOWN KERNEL OBJECT]".
2019-04-03kernel/object: Remove unused handle type entryLioncash2-2/+0
The AddressArbiter type isn't actually used, given the arbiter itself isn't a direct kernel object (or object that implements the wait object facilities). Given this, we can remove the enum entry entirely.
2019-04-02kernel/svc: Implement svcGetThreadListLioncash4-1/+70
Similarly like svcGetProcessList, this retrieves the list of threads from the current process. In the kernel itself, a process instance maintains a list of threads, which are used within this function. Threads are registered to a process' thread list at thread initialization, and unregistered from the list upon thread destruction (if said thread has a non-null owning process). We assert on the debug event case, as we currently don't implement kernel debug objects.
2019-04-02kernel/svc: Implement svcGetProcessListLioncash4-1/+53
This service function simply copies out a specified number of kernel process IDs, while simultaneously reporting the total number of processes.
2019-04-02process: Fix up compilationReinUsesLisp1-1/+1
2019-04-02kernel/thread: Make AllWaitObjectsReady() a const qualified member functionLioncash2-2/+2
Now that ShouldWait() is a const qualified member function, this one can be made const qualified as well, since it can handle passing a const qualified this pointer to ShouldWait().
2019-04-02kernel/wait_object: Make ShouldWait() take thread members by pointer-to-constLioncash11-11/+11
Given this is intended as a querying function, it doesn't make sense to allow the implementer to modify the state of the given thread.
2019-04-01kernel/thread: Avoid sign conversion within GetCommandBufferAddress()Lioncash1-2/+2
Previously this was performing a u64 + int sign conversion. When dealing with addresses, we should generally be keeping the arithmetic in the same signedness type. This also gets rid of the static lifetime of the constant, as there's no need to make a trivial type like this potentially live for the entire duration of the program.
2019-04-01kernel/thread: Make parameter of GetWaitObjectIndex() const qualifiedLioncash2-3/+3
The pointed to member is never actually modified, so it can be made const.
2019-04-01kernel/resource_limit: Remove the name member from resource limitsLioncash3-14/+6
This doesn't really provide any benefit to the resource limit interface. There's no way for callers to any of the service functions for resource limits to provide a custom name, so all created instances of resource limits other than the system resource limit would have a name of "Unknown". The system resource limit itself is already trivially identifiable from its limit values, so there's no real need to take up space in the object to identify one object meaningfully out of N total objects.
2019-04-01general: Use deducation guides for std::lock_guard and std::unique_lockLioncash2-2/+2
Since C++17, the introduction of deduction guides for locking facilities means that we no longer need to hardcode the mutex type into the locks themselves, making it easier to switch mutex types, should it ever be necessary in the future.
2019-03-30kernel/scheduler: Remove unused parameter to AddThread()Lioncash3-4/+4
This was made unused in b404fcdf1443b91ac9994c05ad1fe039fcd9675e, but the parameter itself wasn't removed.
2019-03-30kernel/scheduler: Use deduction guides on mutex locksLioncash1-8/+8
Since C++17, we no longer need to explicitly specify the type of the mutex within the lock_guard. The type system can now deduce these with deduction guides.
2019-03-29kernel/shared_memory: Remove unused core/memory.h includeLioncash1-1/+0
Nothing from this header is used, so we can remove this include, getting rid of a dependency on it.
2019-03-29kernel/shared_memory: Sanitize supplied size when unmappingLioncash3-4/+18
The kernel makes sure that the given size to unmap is always the same size as the entire region managed by the shared memory instance, otherwise it returns an error code signifying an invalid size. This is similarly done for transfer memory (which we already check for).
2019-03-29kernel/process: Report total physical memory used to svcGetInfoLioncash3-4/+11
Reports the (mostly) correct size through svcGetInfo now for queries to total used physical memory. This still doesn't correctly handle memory allocated via svcMapPhysicalMemory, however, we don't currently handle that case anyways.
2019-03-29kernel/process: Store the total size of the code memory loadedLioncash2-0/+5
This will be necessary to properly report the used memory size in svcGetInfo.
2019-03-28kernel/process: Store the main thread stack size to a data memberLioncash2-4/+7
This will be necessary in order to properly report memory usage within svcGetInfo.
2019-03-28kernel/process: Make Run's stack size parameter a u64Lioncash2-2/+2
This will make operating with the process-related SVC commands much nicer in the future (the parameter representing the stack size in svcStartProcess is a 64-bit value).
2019-03-28kernel/process: Ensure that given stack size is always page-alignedLioncash1-0/+4
The kernel always makes sure that the given stack size is aligned to page boundaries.
2019-03-27Fixes and corrections on formatting.Fernando Sahmkow1-6/+9
2019-03-27Use MultiLevelQueue instead of old ThreadQueueListFernando Sahmkow2-19/+24
2019-03-24core/core_timing: Make callback parameters consistentLioncash1-1/+1
In some cases, our callbacks were using s64 as a parameter, and in other cases, they were using an int, which is inconsistent. To make all callbacks consistent, we can just use an s64 as the type for late cycles, given it gets rid of the need to cast internally. While we're at it, also resolve some signed/unsigned conversions that were occurring related to the callback registration.
2019-03-24kernel/kernel: Remove unnecessary forward declarationLioncash1-3/+0
This is no longer necessary, as ResultVal isn't used anywhere in the header.
2019-03-24kernel/process: Remove unused AddressMapping structLioncash1-8/+0
Another leftover from citra that's now no longer necessary.
2019-03-24kernel/vm_manager: Handle shrinking of the heap size within SetHeapSize()Lioncash2-24/+46
One behavior that we weren't handling properly in our heap allocation process was the ability for the heap to be shrunk down in size if a larger size was previously requested. This adds the basic behavior to do so and also gets rid of HeapFree, as it's no longer necessary now that we have allocations and deallocations going through the same API function. While we're at it, fully document the behavior that this function performs.
2019-03-24kernel/vm_manager: Rename HeapAllocate to SetHeapSizeLioncash3-4/+3
Makes it more obvious that this function is intending to stand in for the actual supervisor call itself, and not acting as a general heap allocation function. Also the following change will merge the freeing behavior of HeapFree into this function, so leaving it as HeapAllocate would be misleading.
2019-03-24kernel/vm_manager: Handle case of identical calls to HeapAllocateLioncash1-0/+5
In cases where HeapAllocate is called with the same size of the current heap, we can simply do nothing and return successfully. This avoids doing work where we otherwise don't have to. This is also what the kernel itself does in this scenario.
2019-03-24kernel/vm_manager: Remove unused class variablesLioncash1-3/+0
Over time these have fallen out of use due to refactoring, so these can be removed.
2019-03-24kernel/vm_manager: Remove unnecessary heap_used data memberLioncash3-13/+2
This isn't required anymore, as all the kernel ever queries is the size of the current heap, not the total usage of it.
2019-03-24kernel/vm_manager: Tidy up heap allocation codeLioncash3-27/+37
Another holdover from citra that can be tossed out is the notion of the heap needing to be allocated in different addresses. On the switch, the base address of the heap will always be managed by the memory allocator in the kernel, so this doesn't need to be specified in the function's interface itself. The heap on the switch is always allocated with read/write permissions, so we don't need to add specifying the memory permissions as part of the heap allocation itself either. This also corrects the error code returned from within the function. If the size of the heap is larger than the entire heap region, then the kernel will report an out of memory condition.
2019-03-22kernel/codeset: Make CodeSet's memory data member a regular std::vectorLioncash2-4/+5
The use of a shared_ptr is an implementation detail of the VMManager itself when mapping memory. Because of that, we shouldn't require all users of the CodeSet to have to allocate the shared_ptr ahead of time. It's intended that CodeSet simply pass in the required direct data, and that the memory manager takes care of it from that point on. This means we just do the shared pointer allocation in a single place, when loading modules, as opposed to in each loader.
2019-03-21kernel/vm_manager: Rename CodeStatic/CodeMutable to Code and CodeData respectivelyLioncash3-17/+17
Makes it more evident that one is for actual code and one is for actual data. Mutable and static are less than ideal terms here, because read-only data is technically not mutable, but we were mapping it with that label.
2019-03-21kernel/vm_manager: Amend flag values for CodeMutableLioncash1-1/+1
This should actually be using the data flags, rather than the code flags.
2019-03-20kernel/process: Make MapSegment lambda reference parameter constLioncash1-1/+1
The segment itself isn't actually modified.
2019-03-20kernel: Move CodeSet structure to its own source filesLioncash4-44/+105
Given this is utilized by the loaders, this allows avoiding inclusion of the kernel process definitions where avoidable. This also keeps the loading format for all executable data separate from the kernel objects.
2019-03-20Fix crash caused by 2238.Fernando Sahmkow1-1/+2
2019-03-20Fix small bug that kept a thread as a condvar thread after being signalled.Fernando Sahmkow2-6/+8
2019-03-20Add CondVar Thread State.Fernando Sahmkow4-4/+6
2019-03-20Small fixes to address_arbiter to better match the IDB.Fernando Sahmkow2-5/+5
2019-03-17core: Move PageTable struct into Common.bunnei4-9/+10
2019-03-16kernel/thread: Actually remove the definition of ExitCurrentThread()Lioncash1-6/+0
This was intended to be removed in 51d7f6bffcc0498a47abc7de27bf0906fc523dae, but I guess I forgot to actually save the file like a dingus.
2019-03-16kernel/thread: Move thread exiting logic from ExitCurrentThread to svcExitThreadLioncash2-8/+7
Puts the operation on global state in the same places as the rest of the svc calls.
2019-03-16kernel/thread: Migrate WaitCurrentThread_Sleep into the Thread interfaceLioncash4-25/+24
Rather than make a global accessor for this sort of thing. We can make it a part of the thread interface itself. This allows getting rid of a hidden global accessor in the kernel code.
2019-03-16kernel/thread: Expand documentation of nominal_priority and current_priorityLioncash2-3/+11
Aims to disambiguate why each priority instance exists a little bit. While we're at it, also add an explanatory comment to UpdatePriority().
2019-03-16kernel/thread: Make bracing consistent within UpdatePriority()Lioncash1-2/+4
2019-03-16kernel/thread: Amend condition within UpdatePriority()Lioncash1-3/+3
This condition was checking against the nominal thread priority, whereas the kernel itself checks against the current priority instead. We were also assigning the nominal priority, when we should be assigning current_priority, which takes priority inheritance into account. This can lead to the incorrect priority being assigned to a thread. Given we recursively update the relevant threads, we don't need to go through the whole mutex waiter list. This matches what the kernel does as well (only accessing the first entry within the waiting list).
2019-03-16kernel/thread: Maintain priority ordering of added mutex waiting threadsLioncash1-14/+24
The kernel keeps the internal waiting list ordered by priority. This is trivial to do with std::find_if followed by an insertion.
2019-03-15core/hle/kernel/mutex: Remove usages of global system accessorsLioncash1-11/+15
Removes the use of global system accessors, and instead uses the explicit interface provided.
2019-03-15core/hle/kernel: Make Mutex a per-process class.Lioncash5-18/+47
Makes it an instantiable class like it is in the actual kernel. This will also allow removing reliance on global accessors in a following change, now that we can encapsulate a reference to the system instance in the class.
2019-03-13core/hle/kernel/svc: Implement svcUnmapTransferMemoryLioncash1-1/+48
Similarly, like svcMapTransferMemory, we can also implement svcUnmapTransferMemory fairly trivially as well.
2019-03-13core/hle/kernel/svc: Implement svcMapTransferMemoryLioncash1-1/+57
Now that transfer memory handling is separated from shared memory, we can implement svcMapTransferMemory pretty trivially.
2019-03-13core/hle/kernel: Split transfer memory handling out into its own classLioncash5-4/+175
Within the kernel, shared memory and transfer memory facilities exist as completely different kernel objects. They also have different validity checking as well. Therefore, we shouldn't be treating the two as the same kind of memory. They also differ in terms of their behavioral aspect as well. Shared memory is intended for sharing memory between processes, while transfer memory is intended to be for transferring memory to other processes. This breaks out the handling for transfer memory into its own class and treats it as its own kernel object. This is also important when we consider resource limits as well. Particularly because transfer memory is limited by the resource limit value set for it. While we currently don't handle resource limit testing against objects yet (but we do allow setting them), this will make implementing that behavior much easier in the future, as we don't need to distinguish between shared memory and transfer memory allocations in the same place.
2019-03-13kernel/process: Remove use of global system accessorsLioncash2-8/+9
Now that we pass in a reference to the system instance, we can utilize it to eliminate the global accessors in Process-related code.
2019-03-11kernel/server_port: Make data members privateLioncash3-13/+35
With this, all kernel objects finally have all of their data members behind an interface, making it nicer to reason about interactions with other code (as external code no longer has the freedom to totally alter internals and potentially messing up invariants).
2019-03-08kernel/hle_ipc: Convert std::shared_ptr IPC header instances to std::optionalLioncash3-46/+46
There's no real need to use a shared lifetime here, since we don't actually expose them to anything else. This is also kind of an unnecessary use of the heap given the objects themselves are so small; small enough, in fact that changing over to optionals actually reduces the overall size of the HLERequestContext struct (818 bytes to 808 bytes).
2019-03-08kernel: Make the address arbiter instance per-processLioncash6-26/+33
Now that we have the address arbiter extracted to its own class, we can fix an innaccuracy with the kernel. Said inaccuracy being that there isn't only one address arbiter. Each process instance contains its own AddressArbiter instance in the actual kernel. This fixes that and gets rid of another long-standing issue that could arise when attempting to create more than one process.
2019-03-08kernel/svc: Move address arbiter signaling behind a unified API functionLioncash3-22/+26
Similar to how WaitForAddress was isolated to its own function, we can also move the necessary conditional checking into the address arbiter class itself, allowing us to hide the implementation details of it from public use.
2019-03-08kernel/svc: Move address arbiter waiting behind a unified API functionLioncash3-19/+24
Rather than let the service call itself work out which function is the proper one to call, we can make that a behavior of the arbiter itself, so we don't need to directly expose those implementation details.
2019-03-06kernel/server_session: Make data members privateLioncash4-31/+72
Makes it much nicer to locally reason about server session behavior, as part of its functionality isn't placed around other classes.
2019-03-06kernel/client_session: Make data members privateLioncash1-4/+5
These can be made private, as they aren't accessed in contexts that require them to be public.
2019-03-05kernel/address_arbiter: Pass in system instance to constructorLioncash4-21/+39
Allows getting rid of reliance on the global accessor functions and instead operating on the provided system instance.
2019-03-05kernel/address_arbiter: Minor tidying upLioncash1-18/+18
- Invert conditions into guard clases where applicable. - Mark std::vector parameter of WakeThreads as const
2019-03-05kernel/address_arbiter: Convert the address arbiter into a classLioncash5-82/+135
Places all of the functions for address arbiter operation into a class. This will be necessary for future deglobalizing efforts related to both the memory and system itself.
2019-03-05vm_manager: Remove cheat-specific ranges from VMManagerZach Hilman2-25/+0
2019-03-05kernel/thread: Remove obsolete TODO in Create()Lioncash1-2/+0
This is a TODO carried over from Citra that doesn't apply here.
2019-03-05core/hle/ipc: Remove unnecessary includesLioncash2-5/+6
Removes a few inclusion dependencies from the headers or replaces existing ones with ones that don't indirectly include the required headers. This allows removing an inclusion of core/memory.h, meaning that if the memory header is ever changed in the future, it won't result in rebuilding the entirety of the HLE services (as the IPC headers are used quite ubiquitously throughout the HLE service implementations).
2019-03-05vm_manager: Add support for storing and getting main code regionZach Hilman2-0/+28
Used as root for one region of cheats, set by loader
2019-03-04vm_manager: Use range helpers in HeapAlloc() and HeapFree()Lioncash1-4/+2
Significantly tidies up two guard conditionals.
2019-03-04vm_manager: Provide address range checking functions for other memory regionsLioncash2-4/+35
Makes the interface uniform when it comes to checking various memory regions.
2019-03-04kernel/scheduler: Pass in system instance in constructorLioncash2-9/+11
Avoids directly relying on the global system instance and instead makes an arbitrary system instance an explicit dependency on construction. This also allows removing dependencies on some global accessor functions as well.
2019-03-04kernel/shared_memory: Get rid of the use of global accessor functions within Create()Lioncash1-3/+2
Given we already pass in a reference to the kernel that the shared memory instance is created under, we can just use that to check the current process, rather than using the global accessor functions. This allows removing direct dependency on the system instance entirely.
2019-03-04svc: Migrate address range checking functions to VMManagerLioncash3-23/+30
Provides a bit of a more proper interface for these functions.
2019-02-25kernel/handle_table: Make local variables as const where applicableLioncash1-4/+5
Makes immutable state explicit.
2019-02-25kernel/handle_table: Allow process capabilities to limit the handle table sizeLioncash6-10/+54
The kernel allows restricting the total size of the handle table through the process capability descriptors. Until now, this functionality wasn't hooked up. With this, the process handle tables become properly restricted. In the case of metadata-less executables, the handle table will assume the maximum size is requested, preserving the behavior that existed before these changes.
2019-02-25kernel/handle-table: In-class initialize data membersLioncash2-3/+2
Directly initializes members where applicable.
2019-02-25kernel/handle_table: Resolve truncation warningsLioncash1-2/+2
Avoids implicit truncation warnings from u32 -> u16 (the truncation is desirable behavior here).
2019-02-16address_arbiter: Use nested namespaces where applicableLioncash2-8/+4
A fairly trivial change. Other sections of the codebase use nested namespaces instead of separate namespaces here. This one must have just been overlooked.
2019-02-16core_timing: Convert core timing into a classLioncash5-21/+31
Gets rid of the largest set of mutable global state within the core. This also paves a way for eliminating usages of GetInstance() on the System class as a follow-up. Note that no behavioral changes have been made, and this simply extracts the functionality into a class. This also has the benefit of making dependencies on the core timing functionality explicit within the relevant interfaces.
2019-02-12core_timing: Rename CoreTiming namespace to Core::TimingLioncash5-16/+17
Places all of the timing-related functionality under the existing Core namespace to keep things consistent, rather than having the timing utilities sitting in its own completely separate namespace.
2019-02-01kernel: Remove the Timer classLioncash6-227/+0
A holdover from citra, the Horizon kernel on the switch has no prominent kernel object that functions as a timer. At least not to the degree of sophistication that this class provided. As such, this can be removed entirely. This class also wasn't used at all in any meaningful way within the core, so this was just code sitting around doing nothing. This also allows removing a few things from the main KernelCore class that allows it to use slightly less resources overall (though very minor and not anything really noticeable).
2019-01-30kernel/wait_object: Devirtualize functions related to manipulating the thread list directlyLioncash1-3/+3
No inheritors of the WaitObject class actually make use of their own implementations of these functions, so they can be made non-virtual. It's also kind of sketchy to allow overriding how the threads get added to the list anyways, given the kernel itself on the actual hardware doesn't seem to customize based off this.
2019-01-30kernel/timer: Remove unnecessary WakeupAllWaitingThreads() overrideLioncash2-6/+0
This implementation just calls the base class variant of the function, so this isn't necessary.
2019-01-30kernel/readable_event: Remove unnecessary WakeupAllWaitingThreads() overrideLioncash2-6/+0
This just calls the base variant of the function, so it can be removed.
2019-01-27kernel/svc: Log out uncaught C++ exceptions from svcBreakLioncash1-0/+4
Looking into the implementation of the C++ standard facilities that seem to be within all modules, it appears that they use 7 as a break reason to indicate an uncaught C++ exception. This was primarily found via the third last function called within Horizon's equivalent of libcxxabi's demangling_terminate_handler(), which passes the value 0x80000007 to svcBreak.
2019-01-04Removed pulse event typeDavid Marcec3-7/+0
Pulse is considered a hack and nothing should be using it. We should completely remove it
2019-01-01core/kernel: Remove unnecessary inclusionsLioncash11-12/+17
Gets rid of a few unnecessary header dependencies in some source files.
2018-12-31kernel/svc: Correct misleading error message within CreateThread()Lioncash1-2/+3
This is a bounds check to ensure that the thread priority is within the valid range of 0-64. If it exceeds 64, that doesn't necessarily mean that an actual priority of 64 was expected (it actually means whoever called the function screwed up their math). Instead clarify the message to indicate the allowed range of thread priorities.
2018-12-31kernel/svc: Sanitize core number and thread priorities in CreateThread()Lioncash1-6/+17
Now that we handle the kernel capability descriptors we can correct CreateThread to properly check against the core and priority masks like the actual kernel does.
2018-12-31kernel/process: Rename GetAllowedProcessorMask() and GetAllowedThreadPriorityMask()Lioncash2-11/+11
Makes them consistent with their kernel capability counterparts.
2018-12-31kernel/svc: Simplify thread core ID sanitizing in CreateThreadLioncash1-7/+1
Rather than use a switch here, this can be collapsed into a simple range check, which is a little easier on the eyes.
2018-12-28kernel/process: Start the main thread using the specified ideal coreLioncash1-2/+2
This matches kernel behavior in that processes are started using their specified ideal core, rather than always starting on core 0.
2018-12-28kernel: Rename 'default' CPU core to 'ideal' coreLioncash4-21/+21
This makes the naming more closely match its meaning. It's just a preferred core, not a required default core. This also makes the usages of this term consistent across the thread and process implementations.
2018-12-28kernel/thread: Move process thread initialization into process.cppLioncash3-36/+30
This function isn't a general purpose function that should be exposed to everything, given it's specific to initializing the main thread for a Process instance. Given that, it's a tad bit more sensible to place this within process.cpp, which keeps it visible only to the code that actually needs it.
2018-12-28kernel/process: Remove most allocation functions from Process' interfaceLioncash3-38/+19
In all cases that these functions are needed, the VMManager can just be retrieved and used instead of providing the same functions in Process' interface. This also makes it a little nicer dependency-wise, since it gets rid of cases where the VMManager interface was being used, and then switched over to using the interface for a Process instance. Instead, it makes all accesses uniform and uses the VMManager instance for all necessary tasks. All the basic memory mapping functions did was forward to the Process' VMManager instance anyways.
2018-12-27kernel/vm_manager: Reset region attributes when unmapping a VMALioncash1-0/+1
Like the other members related to memory regions, the attributes need to be reset back to their defaults as well.
2018-12-21kernel/process: Hook up the process capability parser to the process itselfLioncash2-120/+18
While we're at it, we can also toss out the leftover capability parsing from Citra.
2018-12-21kernel/process_capability: Handle debug capability flagsLioncash2-1/+18
2018-12-21kernel/process_capability: Handle handle table capability flagsLioncash2-1/+11
This just specifies the handle table size. There's also a section of reserved bits that are checked against.
2018-12-21kernel/process_capability: Handle kernel version capability flagsLioncash2-1/+18
2018-12-21kernel/process_capability: Handle program capability flagsLioncash3-2/+29
2018-12-21kernel/process_capability: Handle interrupt capability flagsLioncash1-1/+21
Similar to the service capability flags, however, we currently don't emulate the GIC, so this currently handles all interrupts as being valid for the time being.
2018-12-21kernel/process_capability: Handle syscall capability flagsLioncash2-1/+29
2018-12-21kernel/process_capability: Handle the priority mask and core mask flagsLioncash2-1/+40
Handles the priority mask and core mask flags to allow building up the masks to determine the usable thread priorities and cores for a kernel process instance.
2018-12-21kernel/process: Introduce process capability parsing skeletonLioncash4-3/+466
We've had the old kernel capability parser from Citra, however, this is unused code and doesn't actually map to how the kernel on the Switch does it. This introduces the basic functional skeleton for parsing process capabilities.
2018-12-19kernel/svc: Handle thread handles within GetProcessIdLioncash1-10/+23
If a thread handle is passed to svcGetProcessId, the kernel attempts to access the process ID via the thread's instance's owning process. Technically, this function should also be handling the kernel debug objects as well, however we currently don't handle those kernel objects yet, so I've left a note via a comment about it to remind myself when implementing it in the future.
2018-12-19svc: Implement svcSetMemoryAttributeLioncash1-5/+46
With all the basic backing functionality implemented, we can now unstub svcSetMemoryAttribute.
2018-12-19vm_manager: Add member function for setting memory attributes across an address rangeLioncash2-0/+41
This puts the backing functionality for svcSetMemoryAttribute in place, which will be utilized in a following change.
2018-12-19vm_manager: Add member function for checking a memory range adheres to certain attributes, permissions and statesLioncash2-0/+100
2018-12-19kernel/kernel: Use correct initial PID for userland Process instancesLioncash2-4/+14
Starts the process ID counter off at 81, which is what the kernel itself checks against internally when creating processes. It's actually supposed to panic if the PID is less than 81 for a userland process.
2018-12-19kernel/svc: Correct output parameter for svcGetThreadIdLioncash1-1/+1
The service call uses a 64-bit value, just like svcGetProcessId. This amends the function signature accordingly.
2018-12-19kernel/thread: Make thread_id a 64-bit valueLioncash3-5/+5
The kernel uses a 64-bit value for the thread ID, so we shouldn't be using a 32-bit value.
2018-12-19kernel/svc: Correct output parameter for svcGetProcessIdLioncash2-2/+10
svcGetProcessId's out parameter is a pointer to a 64-bit value, not a 32-bit one.
2018-12-19kernel/process: Make process_id a 64-bit valueLioncash3-6/+6
In the actual kernel, this is a 64-bit value, so we shouldn't be using a 32-bit type to handle it.
2018-12-19Moved backtrace to ArmInterfaceDavid Marcec3-11/+3
2018-12-19Fixed uninitialized memory due to missing returns in canaryDavid Marcec1-0/+1
Functions which are suppose to crash on non canary builds usually don't return anything which lead to uninitialized memory being used.
2018-12-18kernel/thread: Set default fpcrMerryMage1-0/+3
2018-12-16vm_manager: Rename meminfo_state to stateLioncash2-10/+9
This is shorter and more concise. This also removes the now-innaccurate comment, as it's not returned wholesale to svcQueryMemory anymore.
2018-12-16vm_manager: Add backing functionality for memory attributesLioncash2-1/+85
Adds the barebones enumeration constants and functions in place to handle memory attributes, while also essentially leaving the attribute itself non-functional.
2018-12-12svc: Enable svcQueryProcessMemoryLioncash2-1/+6
svcQueryProcessMemory is trivial to implement, given all the behavior necessary for it is present, it just needs a handler for it.
2018-12-12svc: Write out the complete MemoryInfo structure in QueryProcessMemoryLioncash1-0/+3
In the previous change, the memory writing was moved into the service function itself, however it still had a problem, in that the entire MemoryInfo structure wasn't being written out, only the first 32 bytes of it were being written out. We still need to write out the trailing two reference count members and zero out the padding bits. Not doing this can result in wrong behavior in userland code in the following scenario: MemoryInfo info; // Put on the stack, not quaranteed to be zeroed out. svcQueryMemory(&info, ...); if (info.device_refcount == ...) // Whoops, uninitialized read. This can also cause the wrong thing to happen if the user code uses std::memcmp to compare the struct, with another one (questionable, but allowed), as the padding bits are not guaranteed to be a deterministic value. Note that the kernel itself also fully zeroes out the structure before writing it out including the padding bits.
2018-12-12svc: Handle memory writing explicitly within QueryProcessMemoryLioncash2-26/+22
Moves the memory writes directly into QueryProcessMemory instead of letting the wrapper function do it. It would be inaccurate to allow the handler to do it because there's cases where memory shouldn't even be written to. For example, if the given process handle is invalid. HOWEVER, if the memory writing is within the wrapper, then we have no control over if these memory writes occur, meaning in an error case, 68 bytes of memory randomly get trashed with zeroes, 64 of those being written to wherever the memory info address points to, and the remaining 4 being written wherever the page info address points to. One solution in this case would be to just conditionally check within the handler itself, but this is kind of smelly, given the handler shouldn't be performing conditional behavior itself, it's a behavior of the managed function. In other words, if you remove the handler from the equation entirely, does the function still retain its proper behavior? In this case, no. Now, we don't potentially trash memory from this function if an invalid query is performed.
2018-12-12vm_manager: Correct ordering of last two struct members of MemoryInfoLioncash1-2/+2
These should be swapped.
2018-12-12svc_wrap: Correct register index for a wrapper specializationLioncash1-1/+1
This would result in svcSetMemoryAttribute getting the wrong value for its third parameter. This is currently fine, given the service function is stubbed, however this will be unstubbed in a future change, so this needs to change.
2018-12-12vm_manager: Amend the returned values for invalid memory queries in QueryMemory()Lioncash2-4/+7
The kernel returns a memory info instance with the base address set to the end of the address space, and the size of said block as 0 - address_space_end, it doesn't set both of said members to zero.
2018-12-12vm_manager: Migrate memory querying to the VMManager interfaceLioncash4-18/+33
Gets rid of the need to directly access the managed VMAs outside of the memory manager itself just for querying memory.
2018-12-12vm_manager: Migrate MemoryInfo and PageInfo to vm_manager.hLioncash3-17/+16
Gets the two structures out of an unrelated header and places them with the rest of the memory management code. This also corrects the structures. PageInfo appears to only contain a 32-bit flags member, and the extra padding word in MemoryInfo isn't necessary.
2018-12-12vm_manager: Amend MemoryState enum membersLioncash5-28/+111
Amends the MemoryState enum to use the same values like the actual kernel does. Also provides the necessary operators to operate on them. This will be necessary in the future for implementing svcSetMemoryAttribute, as memory block state is checked before applying the attribute.
2018-12-12Fix Process object leak on emulation stopJens Schmer3-13/+12
The Process object kept itself alive indefinitely because its handle_table contains a SharedMemory object which owns a reference to the same Process object, creating a circular ownership scenario. Break that up by storing only a non-owning pointer in the SharedMemory object.
2018-12-06vm_manager: Make vma_map privateLioncash4-22/+36
This was only ever public so that code could check whether or not a handle was valid or not. Instead of exposing the object directly and allowing external code to potentially mess with the map contents, we just provide a member function that allows checking whether or not a handle is valid. This makes all member variables of the VMManager class private except for the page table.
2018-12-05kernel/process: Set ideal core from metadataLioncash1-0/+1
A very trivial change. If metadata is available, the process should use it to retrieve the desired core for the process to run on.
2018-12-05svc: Avoid incorrect fast yield conditionZach Hilman1-6/+1
2018-12-05kernel/svc: Correct behavior of svcResetSignal()Lioncash1-4/+11
While partially correct, this service call allows the retrieved event to be null, as it also uses the same handle to check if it was referring to a Process instance. The previous two changes put the necessary machinery in place to allow for this, so we can simply call those member functions here and be done with it.
2018-12-05kernel/process: Make Process a WaitObjectLioncash3-6/+68
Process instances can be waited upon for state changes. This is also utilized by svcResetSignal, which will be modified in an upcoming change. This simply puts all of the WaitObject related machinery in place.
2018-12-05kernel/readable_event: Add member function for enforcing a strict reset contractLioncash2-1/+22
svcResetSignal relies on the event instance to have already been signaled before attempting to reset it. If this isn't the case, then an error code has to be returned.
2018-12-04kernel/svc: Remove unused header inclusionLioncash1-1/+0
2018-12-04kernel/svc: Implement svcSignalEvent()Lioncash1-1/+16
This function simply does a handle table lookup for a writable event instance identified by the given handle value. If a writable event cannot be found for the given handle, then an invalid handle error is returned. If a writable event is found, then it simply signals the event, as one would expect.
2018-12-04kernel/svc: Implement svcCreateEvent()Lioncash2-1/+42
svcCreateEvent operates by creating both a readable and writable event and then attempts to add both to the current process' handle table. If adding either of the events to the handle table fails, then the relevant error from the handle table is returned. If adding the readable event after the writable event to the table fails, then the writable event is removed from the handle table and the relevant error from the handle table is returned. Note that since we do not currently test resource limits, we don't check the resource limit table yet.
2018-12-04kernel/object: Amend handle types to distinguish between readable and writable eventsLioncash5-10/+19
Two kernel object should absolutely never have the same handle ID type. This can cause incorrect behavior when it comes to retrieving object types from the handle table. In this case it allows converting a WritableEvent into a ReadableEvent and vice-versa, which is undefined behavior, since the object types are not the same. This also corrects ClearEvent() to check both kernel types like the kernel itself does.
2018-12-04kernel/handle_table: Amend reference to CTR-OS in Create()Lioncash1-2/+3
Another hold-over from Citra.
2018-12-04kernel/svc: Implement the resource limit svcGetInfo optionLioncash4-9/+34
Allows a process to register the resource limit as part of its handle table.
2018-12-04svc: Implement SetThreadActivity (thread suspension)Luke Street4-6/+72
2018-12-04[Kernel::CreateThread] Match format specifiers to LOG_TRACE's argumentsV.Kalyuzhny1-1/+1
2018-12-04scheduler: Avoid manual Reschedule callZach Hilman2-11/+11
This will automatically occur anyway when PrepareReschedule is called
2018-12-03scheduler: Only work steal higher priority threads from other coresZach Hilman3-35/+24
2018-12-03Moved backtrace to ArmInterfaceDavid Marcec1-14/+1
Added to both dynarmic and unicorn
2018-12-03Print backtrace on svcBreakDavid Marcec3-0/+24
When we get an svcBreak we get a backtrace now
2018-12-02svc: Use the current process' handle table for retrieving the process instance to act uponLioncash1-1/+2
The kernel uses the handle table of the current process to retrieve the process that should be used to retrieve certain information. To someone not familiar with the kernel, this might raise the question of "Ok, sounds nice, but doesn't this make it impossible to retrieve information about the current process?". No, it doesn't, because HandleTable instances in the kernel have the notion of a "pseudo-handle", where certain values allow the kernel to lookup objects outside of a given handle table. Currently, there's only a pseudo-handle for the current process (0xFFFF8001) and a pseudo-handle for the current thread (0xFFFF8000), so to retrieve the current process, one would just pass 0xFFFF8001 into svcGetInfo. The lookup itself in the handle table would be something like: template <typename T> T* Lookup(Handle handle) { if (handle == PSEUDO_HANDLE_CURRENT_PROCESS) { return CurrentProcess(); } if (handle == PSUEDO_HANDLE_CURRENT_THREAD) { return CurrentThread(); } return static_cast<T*>(&objects[handle]); } which, as is shown, allows accessing the current process or current thread, even if those two objects aren't actually within the HandleTable instance.
2018-12-02svc: Reorganize svcGetInfo, handle more error cases for existing implemented info categoriesLioncash1-50/+99
Our implementation of svcGetInfo was slightly incorrect in that we weren't doing proper error checking everywhere. Instead, reorganize it to be similar to how the kernel seems to do it.
2018-12-02svc: Avoid performance-degrading unnecessary rescheduleZach Hilman2-8/+6
2018-12-01Fix debug buildLioncash1-1/+1
A non-existent parameter was left in some formatting calls (the logging macro for which only does anything meaningful on debug builds)
2018-11-29hle_ipc: Refactor SleepClientThread to avoid ReadableEventZach Hilman5-8/+10
2018-11-29kernel/event: Reference ReadableEvent from WritableEventZach Hilman8-125/+47
2018-11-29core: Port all current usages of Event to Readable/WritableEventZach Hilman1-5/+6
2018-11-29hle_ipc: Use event pair for SleepClientThreadZach Hilman2-19/+22
2018-11-29kernel: Add named event tableZach Hilman2-0/+30
Used to store ReadableEvents of all events on the system.
2018-11-29kernel: Divide Event into ReadableEvent and WritableEventZach Hilman5-59/+206
More hardware accurate. On the actual system, there is a differentiation between the signaler and signalee, they form a client/server relationship much like ServerPort and ClientPort.
2018-11-29kernel/object: Add descriptions to ResetTypesZach Hilman1-3/+3
2018-11-27svc: Implement svcSetResourceLimitLimitValue()Lioncash1-1/+36
The opposite of the getter functions, this function sets the limit value for a particular ResourceLimit resource category, with the restriction that the new limit value must be equal to or greater than the current resource value. If this is violated, then ERR_INVALID_STATE is returned. e.g. Assume: current[Events] = 10; limit[Events] = 20; a call to this service function lowering the limit value to 10 would be fine, however, attempting to lower it to 9 in this case would cause an invalid state error.
2018-11-27svc: Implement svcGetResourceLimitCurrentValue()Lioncash1-16/+49
This kernel service function is essentially the exact same as svcGetResourceLimitLimitValue(), with the only difference being that it retrieves the current value for a given resource category using the provided resource limit handle, rather than retrieving the limiting value of that resource limit instance. Given these are exactly the same and only differ on returned values, we can extract the existing code for svcGetResourceLimitLimitValue() to handle both values.
2018-11-27svc: Implement svcGetResourceLimitLimitValue()Lioncash2-2/+33
This kernel service function retrieves the maximum allowable value for a provided resource category for a given resource limit instance. Given we already have the functionality added to the resource limit instance itself, it's sufficient to just hook it up. The error scenarios for this are: 1. If an invalid resource category type is provided, then ERR_INVALID_ENUM is returned. 2. If an invalid handle is provided, then ERR_INVALID_HANDLE is returned (bad thing goes in, bad thing goes out, as one would expect). If neither of the above error cases occur, then the out parameter is provided with the maximum limit value for the given category and success is returned.
2018-11-27svc: Implement svcCreateResourceLimit()Lioncash2-1/+27
This function simply creates a ResourceLimit instance and attempts to create a handle for it within the current process' handle table. If the kernal fails to either create the ResourceLimit instance or create a handle for the ResourceLimit instance, it returns a failure code (OUT_OF_RESOURCE, and HANDLE_TABLE_FULL respectively). Finally, it exits by providing the output parameter with the handle value for the ResourceLimit instance and returning that it was successful. Note: We do not return OUT_OF_RESOURCE because, if yuzu runs out of available memory, then new will currently throw. We *could* allocate the kernel instance with std::nothrow, however this would be inconsistent with how all other kernel objects are currently allocated.
2018-11-27Added comment on Main memory size for more clarityDavid Marcec1-0/+1
2018-11-27Made svcSetHeapSize and svcCreateSharedMemory more readableDavid Marcec1-4/+4
2018-11-27Reworked svcs slightly, improved error messages in AM and fsp_srvDavid Marcec1-12/+20
2018-11-26Improved error messages for SVCsDavid Marcec1-76/+170
2018-11-26Changed logging to be "Log before execution", Added more error logging, all services should now log on some levelDavid Marcec1-11/+90
2018-11-25svc: Return ERR_INVALID_ENUM_VALUE from svcGetInfoLuke Street1-1/+2
2018-11-22scheduler: Add explanations for YieldWith and WithoutLoadBalancingZach Hilman5-77/+139
2018-11-22kernel/handle_table: Move private static functions into the cpp fileLioncash2-7/+9
These don't depend on class state, and are effectively implementation details, so they can go into the cpp file .
2018-11-22kernel/handle_table: Restrict handle table size to 1024 entriesLioncash1-5/+2
The previous handle table size is a holdover from Citra. The actual handle table construct on Horizon only allows for a maximum of 1024 entries.
2018-11-22kernel/handle_table: Default destructor in the cpp fileLioncash2-0/+3
We don't need to potentially inline the teardown logic of all of the handle instances.
2018-11-20kernel/process: Move <random> include to the cpp fileLioncash2-1/+1
<random> isn't necesary directly within the header and can be placed in the cpp file where its needed. Avoids propagating random generation utilities via a header file.
2018-11-20kernel/resource_limit: Clean up interfaceLioncash6-190/+81
Cleans out the citra/3DS-specific implementation details that don't apply to the Switch. Sets the stage for implementing ResourceLimit instances properly. While we're at it, remove the erroneous checks within CreateThread() and SetThreadPriority(). While these are indeed checked in some capacity, they are not checked via a ResourceLimit instance. In the process of moving out Citra-specifics, this also replaces the system ResourceLimit instance's values with ones from the Switch.
2018-11-19kernel/shared_memory: Make Map() and Unmap() take the target process by reference rather than as a pointerLioncash3-12/+12
Both member functions assume the passed in target process will not be null. Instead of making this assumption implicit, we can change the functions to be references and enforce this at the type-system level.
2018-11-19kernel/shared_memory: Add a const qualified member function overload for GetPointer()Lioncash2-1/+12
Given this doesn't mutate instance state, we can provide a const-qualified variant as well.
2018-11-19kernel/shared_memory: Use 64-bit types for offset and size in CreateForAppletLioncash2-2/+2
Keeps the interface consistent with the regular Create() function.
2018-11-19kernel/shared_memory: Make GetPointer() take a std::size_t instead of a u32Lioncash2-2/+2
Makes the interface nicer to use in terms of 64-bit code, as it makes it less likely for one to get truncation warnings (and also makes sense in the context of the rest of the interface where 64-bit types are used for sizes and offsets
2018-11-19kernel/shared_memory: Make data members privateLioncash1-12/+17
Rather than allow unfettered access to the class internals, we hide all members by default and create and API that other code can operate against.
2018-11-19svc: Implement yield types 0 and -1Zach Hilman5-2/+114
2018-11-18svc: ResetSignal is not stubbedTobias1-1/+1
https://user-images.githubusercontent.com/20753089/48677874-b8e01c80-eb7b-11e8-8043-b99faa29022c.PNG
2018-11-18am: Deglobalize software keyboard appletZach Hilman1-4/+4
2018-11-18svc: Implement svcCreateTransferMemoryZach Hilman1-3/+33
Seems to be used and created identically to SharedMemory, so just reuse that.
2018-11-18ldr_ro: Add error check for memory allocation failureZach Hilman3-6/+7
2018-11-16kernel/errors: Clean up error codesLioncash2-62/+32
Similar to PR 1706, which cleans up the error codes for the filesystem code, but done for the kernel error codes. This removes the ErrCodes namespace and specifies the errors directly. This also fixes up any straggling lines of code that weren't using the named error codes where applicable.
2018-11-15process: Make MirrorMemory take state to map new memory asZach Hilman1-1/+2
Credits to Subv
2018-11-14kernel/thread: Deduplicate scheduler switching codeLioncash2-37/+13
The code in both places was the same verbatim, so we can extract it to a function to deduplicate the logic.
2018-11-13vm_manager: Unstub GetTotalHeapUsage()Lioncash1-2/+1
Now that we've moved all of the heap-related stuff to the VMManager class, we can unstub this function, as the necessary members are visible now.
2018-11-13kernel/process: Migrate heap-related memory management out of the process class and into the vm managerLioncash4-84/+97
Avoids a breach of responsibilities in the interface and keeps the direct code for memory management within the VMManager class.
2018-11-13svc: Use proper random entropy generation algorithmZach Hilman3-1/+27
2018-11-13svc: Return random seed for svcGetInfo RandomEntropyZach Hilman1-1/+2
2018-11-08svcBreak now dumps information from the debug buffer passed (#1646)David1-0/+28
* svcBreak now dumps information from the debug buffer passed info1 and info2 seem to somtimes hold an address to a buffer, this is usually 4 bytes or the size of the int and contains an error code. There's other circumstances where it can be something different so we hexdump these to examine them at a later date. * Addressed comments
2018-11-06Implement SetMemoryPermissionFrederic Laing1-3/+39
2018-11-03Stubbed SetMemoryPermissionFrederic Laing2-1/+12
2018-10-30general: Remove unused boost inclusions where applicableLioncash1-2/+0
Cleans up unused includes and trims off some dependencies on externals.
2018-10-30global: Use std::optional instead of boost::optional (#1578)Frederic L1-4/+4
* get rid of boost::optional * Remove optional references * Use std::reference_wrapper for optional references * Fix clang format * Fix clang format part 2 * Adressed feedback * Fix clang format and MacOS build
2018-10-30hle_ipc: Add member function for querying the existence of a domain headerLioncash2-1/+5
Gets rid of the need to call the getter and then check for null.
2018-10-30hle_ipc: Make GetDomainMessageHeader return a regular pointerLioncash2-3/+3
Nothing requires the shared owner ship here, so we can just return a plain pointer.
2018-10-28core: Make System references const where applicableLioncash2-3/+3
2018-10-26svc: Localize the GetInfo enum class to the function itselfLioncash2-32/+31
Nothing from this enum is intended to be used outside of this function.
2018-10-26svc: Implement svcGetInfo command 0xF0000002Lioncash6-4/+98
This retrieves: if (curr_thread == handle_thread) { result = total_thread_ticks + (hardware_tick_count - last_context_switch_ticks); } else if (curr_thread == handle_thread && sub_id == current_core_index) { result = hardware_tick_count - last_context_switch_ticks; }
2018-10-26process: LoadModule should clear JIT instruction cache.bunnei1-0/+6
2018-10-26Kernel/Memory: Added a function to first a suitable guest address at which to allocate a region of a given size.bunnei2-0/+28
2018-10-24kernel/errors: Remove now-unused, unnecessary, error codesLioncash1-8/+0
Now that we've gotten the innaccurate error codes out of the way, we can finally toss away a bunch of these, trimming down the error codes to ones that are actually used and knocking out two TODO comments.
2018-10-24kernel/shared_memory: Return ERR_INVALID_MEMORY_PERMISSIONS instead of ERR_INVALID_COMBINATIONLioncash1-4/+3
This is more consistent with what the kernel does.
2018-10-24kernel/server_port: Simplify emptiness check within ShouldWait()Lioncash1-1/+1
2018-10-24kernel/server_port: Change error case return value in Accept() to ERR_NOT_FOUNDLioncash2-3/+1
This is what the kernel does in this instance.
2018-10-24kernel/error: Remove leftover 3DS error codesLioncash1-5/+0
These are now entirely unused and can be removed.
2018-10-24kernel/svc: Amend returned error code for invalid priorities in CreateThreadLioncash1-1/+1
Like with the previous change, the kernel doesn't return NOT_AUTHORIZED here. It returns INVALID_THREAD_PRIORITY.
2018-10-24kernel/svc: Move and correct returned error code for invalid thread priorities in SetThreadPriority()Lioncash1-5/+6
All priority checks are supposed to occur before checking the validity of the thread handle, we're also not supposed to return ERR_NOT_AUTHORIZED here.
2018-10-24kernel/error: Add error code for invalid pointersLioncash1-1/+1
The kernel appears to return 0xE601 for this situation. Particularly in svcWaitSynchronization, svcReplyAndReceive, and svcGetThreadContext
2018-10-24kernel/error: Add error code for closed sessionsLioncash1-1/+3
The kernel appears to return 0xF601 for this case.
2018-10-23Added assertion failed, reworked logging levelsDavid Marcec1-16/+24
2018-10-23Added break types to svcBreakDavid Marcec1-4/+42
There seems to be more such as type 1, and 2. Unsure what these currently are but when a game hits them we can investigate and add the rest
2018-10-20kernel/process: Make the handle table per-processLioncash8-98/+95
In the kernel, there isn't a singular handle table that everything gets tossed into or used, rather, each process gets its own handle table that it uses. This currently isn't an issue for us, since we only execute one process at the moment, but we may as well get this out of the way so it's not a headache later on.
2018-10-20svc: Fix vma boundary check in svcQueryMemoryLioncash1-1/+1
This should be comparing against the queried process' vma_map, not the current process'. The only reason this hasn't become an issue yet is we currently only handle one process being active at any time.
2018-10-18svc: Check for word alignment of addresses within svcArbitrateLock/svcArbitrateUnlockLioncash1-0/+8
The kernel itself checks whether or not the provided addresses are word aligned before continuing, so we should be doing the same.
2018-10-18common: Move Is4KBAligned() to alignment.hLioncash1-9/+7
Aligning on 4KB pages isn't a Switch-specific thing, so this can be moved to common so it can be used with other things as well.
2018-10-18svc: Add missing sanitizing checks for MapSharedMemory/UnmapSharedMemoryLioncash3-3/+50
Now that the changes clarifying the address spaces has been merged, we can wrap the checks that the kernel performs when mapping shared memory (and other forms of memory) into its own helper function and then use those within MapSharedMemory and UnmapSharedMemory to complete the sanitizing checks that are supposed to be done.
2018-10-15core_cpu: Make Cpu scheduler instances unique_ptrs instead of shared_ptrsLioncash4-15/+15
2018-10-15svc: Clarify enum values for AddressSpaceBaseAddr and AddressSpaceSize in svcGetInfo()Lioncash4-28/+44
So, one thing that's puzzled me is why the kernel seemed to *not* use the direct code address ranges in some cases for some service functions. For example, in svcMapMemory, the full address space width is compared against for validity, but for svcMapSharedMemory, it compares against 0xFFE00000, 0xFF8000000, and 0x7FF8000000 as upper bounds, and uses either 0x200000 or 0x8000000 as the lower-bounds as the beginning of the compared range. Coincidentally, these exact same values are also used in svcGetInfo, and also when initializing the user address space, so this is actually retrieving the ASLR extents, not the extents of the address space in general.
2018-10-14Stop all threads on svcBreakDavid Marcec1-0/+6
This should help diagnose crashes easier and prevent many users thinking that a game is still running when in fact it's just an audio thread still running(this is typically not killed when svcBreak is hit since the game expects us to do this)
2018-10-13svc: Implement svcGetProcessInfoLioncash3-4/+50
A fairly basic service function, which only appears to currently support retrieving the process state. This also alters the ProcessStatus enum to contain all of the values that a kernel process seems to be able of reporting with regards to state.
2018-10-12kernel/process: Make CodeSet a regular non-inherited objectLioncash4-40/+14
These only exist to ferry data into a Process instance and end up going out of scope quite early. Because of this, we can just make it a plain struct for holding things and just std::move it into the relevant function. There's no need to make this inherit from the kernel's Object type.
2018-10-12thread: Remove unnecessary memset from ResetThreadContext()Lioncash1-4/+1
Regular value initialization is adequate here for zeroing out data. It also has the benefit of not invoking undefined behavior if a non-trivial type is ever added to the struct for whatever reason.
2018-10-12svc: Fix typos in sanitizing checks for MapMemory/UnmapMemoryLioncash1-3/+3
2018-10-11svc: Add missing address range sanitizing checks to MapMemory/UnmapMemoryLioncash2-12/+81
This adds the missing address range checking that the service functions do before attempting to map or unmap memory. Given that both service functions perform the same set of checks in the same order, we can wrap these into a function and just call it from both functions, which deduplicates a little bit of code.
2018-10-10kernel/thread: Use a regular pointer for the owner/current processLioncash6-29/+29
There's no real need to use a shared pointer in these cases, and only makes object management more fragile in terms of how easy it would be to introduce cycles. Instead, just do the simple thing of using a regular pointer. Much of this is just a hold-over from citra anyways. It also doesn't make sense from a behavioral point of view for a process' thread to prolong the lifetime of the process itself (the process is supposed to own the thread, not the other way around).
2018-10-10Changed all casts in svc_wrap.h to be static_cast insteadDavid Marcec1-25/+28
2018-10-10Use a better name than "dont_kill_application"David Marcec1-2/+2
signal_debugger seems like a more fitting name
2018-10-10Fixed incorrect types for svcBreakDavid Marcec2-3/+8
svcBreak reason should be a u32, not a u64.
2018-10-09Added bitfield instead of manually checking if the bit is setDavid Marcec1-4/+12
2018-10-09Actual kill execution when the bit isn't set, not the other way aroundDavid Marcec1-1/+1
2018-10-09svcBreak, Signalling to the debugger should not kill executionDavid Marcec1-5/+12
When loading NROs, svcBreak is called to signal to the debugger that a new "module" is loaded. As no debugger is technically attached we shouldn't be killing the programs execution.
2018-10-06Added forward define for ServerPortDavid Marcec2-4/+6
2018-10-06Ported #4296 from citraDavid Marcec2-1/+6
This will allow us to easily remove the use of "NFC" in "System"
2018-10-06kernel/mutex: Amend behavior of TransferMutexOwnership()Lioncash1-1/+1
This was the result of a typo accidentally introduced in e51d715700a35a8f14e5b804b6f7553c9a40888b. This restores the previous correct behavior. The behavior with the reference was incorrect and would cause some games to fail to boot.
2018-10-05thread: Make the scheduler pointer a regular pointerbalika0112-4/+4
Conceptually, it doesn't make sense for a thread to be able to persist the lifetime of a scheduler. A scheduler should be taking care of the threads; the threads should not be taking care of the scheduler. If the threads outlive the scheduler (or we simply don't actually terminate/shutdown the threads), then it should be considered a bug that we need to fix. Attributing this to balika011, as they opened #1317 to attempt to fix this in a similar way, but my refactoring of the kernel code caused quite a few conflicts.
2018-10-04kernel/thread: Make all instance variables privateLioncash11-187/+363
Many of the member variables of the thread class aren't even used outside of the class itself, so there's no need to make those variables public. This change follows in the steps of the previous changes that made other kernel types' members private. The main motivation behind this is that the Thread class will likely change in the future as emulation becomes more accurate, and letting random bits of the emulator access data members of the Thread class directly makes it a pain to shuffle around and/or modify internals. Having all data members public like this also makes it difficult to reason about certain bits of behavior without first verifying what parts of the core actually use them. Everything being public also generally follows the tendency for changes to be introduced in completely different translation units that would otherwise be better introduced as an addition to the Thread class' public interface.
2018-09-30kernel/svc: Implement svcGetThreadContext()Lioncash3-2/+37
Now that we have all of the rearranging and proper structure sizes in place, it's fairly trivial to implement svcGetThreadContext(). In the 64-bit case we can more or less just write out the context as is, minus some minor value sanitizing. In the 32-bit case we'll need to clear out the registers that wouldn't normally be accessible from a 32-bit AArch32 exectuable (or process).
2018-09-30kernel/process: Add a data member to determine if a process is 64-bit or not.Lioncash2-0/+11
This will be necessary for the implementation of svcGetThreadContext(), as the kernel checks whether or not the process that owns the thread that has it context being retrieved is a 64-bit or 32-bit process. If the process is 32-bit, then the upper 15 general-purpose registers and upper 16 vector registers are cleared to zero (as AArch32 only has 15 GPRs and 16 128-bit vector registers. not 31 general-purpose registers and 32 128-bit vector registers like AArch64).
2018-09-30kernel/process: Make data member variables privateLioncash5-51/+96
Makes the public interface consistent in terms of how accesses are done on a process object. It also makes it slightly nicer to reason about the logic of the process class, as we don't want to expose everything to external code.
2018-09-28kernel/object: Remove unnecessary std::move from DynamicObjectCast()Lioncash2-3/+2
boost::static_pointer_cast for boost::intrusive_ptr (what SharedPtr is), takes its parameter by const reference. Given that, it means that this std::move doesn't actually do anything other than obscure what the function's actual behavior is, so we can remove this. To clarify, this would only do something if the parameter was either taking its argument by value, by non-const ref, or by rvalue-reference.
2018-09-25kernel/scheduler: Take ARM_Interface instance by reference in the constructorLioncash2-9/+9
It doesn't make sense to allow a scheduler to be constructed around a null pointer.
2018-09-25memory: Dehardcode the use of fixed memory range constantsLioncash4-13/+17
The locations of these can actually vary depending on the address space layout, so we shouldn't be using these when determining where to map memory or be using them as offsets for calculations. This keeps all the memory ranges flexible and malleable based off of the virtual memory manager instance state.
2018-09-25svc: Report correct memory-related values within some of the cases in svcGetInfo()Lioncash3-28/+41
Previously, these were reporting hardcoded values, but given the regions can change depending on the requested address spaces, these need to report the values that the memory manager contains.
2018-09-25memory: Dehardcode the use of a 36-bit address spaceLioncash2-5/+16
Given games can also request a 32-bit or 39-bit address space, we shouldn't be hardcoding the address space range as 36-bit.
2018-09-24process/vm_manager: Amend API to allow reading parameters from NPDM metadataLioncash4-10/+248
Rather than hard-code the address range to be 36-bit, we can derive the parameters from supplied NPDM metadata if the supplied exectuable supports it. This is the bare minimum necessary for this to be possible. The following commits will rework the memory code further to adjust to this.
2018-09-24svc: Updated svc namestech4me1-7/+7
2018-09-21svc: Move most process termination code to its own function within ProcessLioncash3-32/+56
Reduces the use of Process class members externally and keeps most code related to tearing down a process with the rest of the process code.
2018-09-21thread/process: Move TLS slot marking/freeing to the process classLioncash4-68/+89
Allows making several members of the process class private, it also avoids going through Core::CurrentProcess() just to retrieve the owning process.
2018-09-21kernel/thread: Use owner_process when setting the page table in SetupMainThread()Lioncash3-5/+5
The owning process of a thread is required to exist before the thread, so we can enforce this API-wise by using a reference. We can also avoid the reliance on the system instance by using that parameter to access the page table that needs to be set.
2018-09-21arm_interface: Replace kernel vm_manager include with a forward declarationLioncash1-0/+1
Avoids an unnecessary inclusion and also uncovers three places where indirect inclusions were relied upon, which allows us to also resolve those.
2018-09-18svc_wrap: Convert the PARAM macro into a functionLioncash1-37/+36
This can just be a regular function, getting rid of the need to also explicitly undef the define at the end of the file. Given FuncReturn() was already converted into a function, it's #undef can also be removed.
2018-09-18arm_interface: Remove ARM11-isms from the CPU interfaceLioncash1-2/+2
This modifies the CPU interface to more accurately match an AArch64-supporting CPU as opposed to an ARM11 one. Two of the methods don't even make sense to keep around for this interface, as Adv Simd is used, rather than the VFP in the primary execution state. This is essentially a modernization change that should have occurred from the get-go.
2018-09-18kernel/mutex: Replace ResultCode construction for invalid addresses with the named variantLioncash1-2/+2
We already have a ResultCode constant for the case of an invalid address, so we can just use it instead of re-rolling that ResultCode type.
2018-09-18kernel/svc: Handle error cases for svcArbitrateLock() and svcArbitrateUnlock()Lioncash1-0/+8
The kernel does the equivalent of the following check before proceeding: if (address + 0x8000000000 < 0x7FFFE00000) { return ERR_INVALID_MEMORY_STATE; } which is essentially what our IsKernelVirtualAddress() function does. So we should also be checking for this. The kernel also checks if the given input addresses are 4-byte aligned, however our Mutex::TryAcquire() and Mutex::Release() functions already handle this, so we don't need to add code for this case.
2018-09-15Port # #4192 from Citra: "svc: change unknown to thread in CreateThread"Valentin Vanelslande1-1/+1
2018-09-15Port #4182 from Citra: "Prefix all size_t with std::"fearlessTobi14-62/+65
2018-09-14kernel/svc: Sanitize creation of shared memory via svcCreateSharedMemory()Lioncash1-2/+18
The kernel caps the size limit of shared memory to 8589930496 bytes (or (1GB - 512 bytes) * 8), so approximately 8GB, where every GB has a 512 byte sector taken off of it. It also ensures the shared memory is created with either read or read/write permissions for both permission types passed in, allowing the remote permissions to also be set as "don't care".
2018-09-14kernel/svc: Sanitize addresses, permissions, and sizes within svcMapSharedMemory() and svcUnmapSharedMemory()Lioncash1-17/+25
Part of the checking done by the kernel is to check if the given address and size are 4KB aligned, as well as checking if the size isn't zero. It also only allows mapping shared memory as readable or read/write, but nothing else, and so we shouldn't allow mapping as anything else either.
2018-09-14kernel/svc: Sanitize addresses and sizes within svcMapMemory() and svcUnmapMemory()Lioncash1-0/+23
The kernel checks if the addresses and given size is 4KB aligned before continuing onwards to map the memory.
2018-09-14kernel/svc: Sanitize heap sizes within svcSetHeapSize()Lioncash2-0/+8
The kernel checks if the given size is a multiple of 2MB and <= to 4GB before going ahead and attempting to allocate that much memory.
2018-09-13kernel/errors: Amend error code for ERR_NOT_FOUNDLioncash1-1/+2
This is the value returned by the kernel for svcConnectToNamedPort() if the named port cannot be found.
2018-09-13kernel/thread: Include thread-related enums within the kernel namespaceLioncash1-6/+6
Previously, these were sitting outside of the Kernel namespace, which doesn't really make sense, given they're related to the Thread class which is within the Kernel namespace.
2018-09-12svc: Return ERR_INVALID_PROCESSOR_ID in CreateThread() if an invalid processor ID is givenLioncash1-2/+2
This is what the kernel does for an out-of-range processor ID.
2018-09-12kernel/errors: Correct error codes for invalid thread priority and invalid processor IDLioncash3-7/+9
2018-09-12svc: Do nothing if svcOutputDebugString() is given a length of zeroLioncash1-0/+4
While unlikely, it does avoid constructing a std::string and unnecessarily calling into the memory code if a game or executable decides to be really silly about their logging.
2018-09-12svc: Correct parameter type for OutputDebugString()Lioncash2-3/+3
This should be a u64 to represent size.
2018-09-07core: Migrate current_process pointer to the kernelLioncash2-0/+23
Given we now have the kernel as a class, it doesn't make sense to keep the current process pointer within the System class, as processes are related to the kernel. This also gets rid of a subtle case where memory wouldn't be freed on core shutdown, as the current_process pointer would never be reset, causing the pointed to contents to continue to live.
2018-09-02service: Migrate global named port map to the KernelCore classLioncash3-5/+49
Now that we have a class representing the kernel in some capacity, we now have a place to put the named port map, so we move it over and get rid of another piece of global state within the core.
2018-08-31core/core: Replace includes with forward declarations where applicableLioncash5-4/+12
The follow-up to e2457418dae19b889b2ad85255bb95d4cd0e4bff, which replaces most of the includes in the core header with forward declarations. This makes it so that if any of the headers the core header was previously including change, then no one will need to rebuild the bulk of the core, due to core.h being quite a prevalent inclusion. This should make turnaround for changes much faster for developers.
2018-08-29kernel: Eliminate kernel global stateLioncash32-405/+574
As means to pave the way for getting rid of global state within core, This eliminates kernel global state by removing all globals. Instead this introduces a KernelCore class which acts as a kernel instance. This instance lives in the System class, which keeps its lifetime contained to the lifetime of the System class. This also forces the kernel types to actually interact with the main kernel instance itself instead of having transient kernel state placed all over several translation units, keeping everything together. It also has a nice consequence of making dependencies much more explicit. This also makes our initialization a tad bit more correct. Previously we were creating a kernel process before the actual kernel was initialized, which doesn't really make much sense. The KernelCore class itself follows the PImpl idiom, which allows keeping all the implementation details sealed away from everything else, which forces the use of the exposed API and allows us to avoid any unnecessary inclusions within the main kernel header.
2018-08-25kernel/error: Amend error code for ERR_MAX_CONNECTIONS_REACHEDLioncash1-2/+4
We can make this error code an alias of the resource limit exceeded error code, allowing us to get rid of the lingering 3DS error code of the same type.
2018-08-25kernel/error: Amend error code for ERR_PORT_NAME_TOO_LONGLioncash1-2/+1
We can treat this as an alias of TooLarge for documentation purposes. This also lets us get rid of another lingering 3DS-related error code.
2018-08-25kernel/error: Add error code for the handle table being fullLioncash3-4/+4
This replaces the lingering 3DS constant with the proper one, and utilizes it within HandleTable's Create() member function.
2018-08-25kernel/error: Add error code for invalid memory permissionsLioncash2-3/+4
2018-08-25kernel/error: Correct kernel error code for invalid combinationLioncash1-1/+2
2018-08-25svc: Return process title ID if queried in GetInfo()Lioncash1-2/+1
We already have the variable itself set up to perform this task, so we can just return its value from the currently executing process instead of always stubbing it to zero.
2018-08-25core: Namespace all code in the arm subdirectory under the Core namespaceLioncash4-6/+8
Gets all of these types and interfaces out of the global namespace.
2018-08-15kernel/server_session: Add IsSession() member functionLioncash2-2/+7
Allows querying the inverse of IsDomain() to make things more readable. This will likely also be usable in the event of implementing ConvertDomainToSession().
2018-08-15kernel/svc: Log svcBreak parametersLioncash1-2/+5
Given if we hit here all is lost, we should probably be logging the break reason code and associated information to distinguish between the causes.
2018-08-13Core::CoreTiming: add UnscheduleEventThreadsafeB3n301-1/+1
2018-08-13kernel/object: Tighten object against data racesLioncash2-8/+9
Despite being covered by a global mutex, we should still ensure that the class handles its reference counts properly. This avoids potential shenanigans when it comes to data races. Given this is the root object that drives quite a bit of the kernel object hierarchy, ensuring we always have the correct behavior (and no races) is a good thing.
2018-08-13Kernel/SVC: Don't reschedule the current core when creating a new thread.Subv1-1/+0
The current core may have nothing to do with the core where the new thread was scheduled to run. In case it's the same core, then the following PrepareReshedule call will take care of that.
2018-08-13Kernel/Threads: Lock the HLE mutex when executing the wakeup callback.Subv1-0/+5
Another thread might be in the middle of a reschedule, thus altering the state of the schedulers.
2018-08-13Kernel/Thread: Always use the threadsafe option when scheduling wakeups.Subv1-2/+4
WakeAfterDelay might be called from any host thread, so err on the side of caution and use the thread-safe CoreTiming::ScheduleEventThreadsafe. Note that CoreTiming is still far from thread-safe, there may be more things we have to work on for it to be up to par with what we want.
2018-08-12Kernel/Mutex: Don't duplicate threads in the mutex waiter list.Subv2-2/+22
Exit from AddMutexWaiter early if the thread is already waiting for a mutex owned by the owner thread. This accounts for the possibility of a thread that is waiting on a condition variable being awakened twice in a row. Also added more validation asserts. This should fix one of the random crashes in Breath Of The Wild.
2018-08-12scheduler: Make HaveReadyThreads() a const member functionLioncash2-2/+2
This function doesn't modify instance state, so the const qualifier can be added to it.
2018-08-12server_session: Provide more useful information and don't crash on bad IPC request.bunnei1-0/+8
2018-08-09hle_ipc: Make WriteToOutgoingCommandBuffer()'s reference parameter constLioncash2-2/+2
This function doesn't modify anything within the reference Thread instance.
2018-08-07client_port: Make all data members privateLioncash3-7/+21
These members don't need to be entirely exposed, we can instead expose an API to operate on them without directly needing to mutate them We can also guard against overflow/API misuse this way as well, given active_sessions is an unsigned value.
2018-08-06kernel/event: Make data members privateLioncash1-4/+8
Instead we can simply provide accessors to the required data instead of giving external read/write access to the variables directly.
2018-08-05address_arbiter: Return by value from GetThreadsWaitingOnAddress()Lioncash1-15/+15
In all cases the vector being supplied is empty, so we can just return by value in these instances.
2018-08-04kernel/thread: Fix potential crashes introduced in 26de4bb521b1ace7af76eff4f6956cb23ac0d58cLioncash3-13/+38
This amends cases where crashes can occur that were missed due to the odd way the previous code was set up (using 3DS memory regions that don't exist).
2018-08-03kernel/process: Use std::array where applicableLioncash1-1/+2
2018-08-03kernel/process: Use accessors instead of class members for referencing segment arrayLioncash2-15/+35
Using member variables for referencing the segments array increases the size of the class in memory for little benefit. The same behavior can be achieved through the use of accessors that just return the relevant segment.
2018-08-03core/memory: Get rid of 3DS leftoversLioncash9-302/+24
Removes leftover code from citra that isn't needed.
2018-08-02kernel/vm_manager: Convert loop into std::any_of()Lioncash1-4/+4
2018-08-02kernel/vm_manager: Use const where applicableLioncash3-19/+19
Makes our immutable state explicit.
2018-08-02kernel/vm_manager: Use the VAddr type alias in CarveVMA()Lioncash1-2/+2
These two variables correspond to address ranges.
2018-08-02kernel/thread: Make GetFreeThreadLocalSlot()'s loop indices size_tLioncash1-8/+5
Avoids using a u32 to compare against a range of size_t, which can be a source of warnings. While we're at it, compress a std::tie into a structured binding.
2018-08-02kernel/thread: Make GetFreeThreadLocalSlot() reference parameter a const referenceLioncash1-1/+2
This function only reads the data being referenced, it doesn't modify it, so we can turn the reference into a const reference.
2018-08-02kernel/thread: Make GetFreeThreadLocalSlot() internally linkedLioncash1-1/+1
This function isn't used outside of this translation unit, so we can make it internally linked.
2018-08-02kernel: Move object class to its own source filesLioncash29-136/+164
General moving to keep kernel object types separate from the direct kernel code. Also essentially a preliminary cleanup before eliminating global kernel state in the kernel code.
2018-08-01kernel/thread: Remove unimplemented function prototypeLioncash1-6/+0
Given there's no implementation, we may as well remove the code entirely.
2018-07-31kernel: Remove unused object_address_table.cpp/.hLioncash5-102/+0
These source files were entirely unused throughout the rest of the codebase. This also has the benefit of getting rid of a global variable as well.
2018-07-31kernel: Remove unnecessary includesLioncash22-27/+46
Removes unnecessary direct dependencies in some headers and also gets rid of indirect dependencies that were being relied on to be included.
2018-07-26kernel/timer: Make data members private where applicableLioncash1-5/+17
Instead, we can just expose functions that return the queryable state instead of letting anything modify it.
2018-07-24svc: Resolve sign comparison warnings in WaitSynchronization()Lioncash1-4/+7
The loop's induction variable was signed, but we were comparing against an unsigned variable.
2018-07-24svc: Log parameters in SetMemoryAttribute()Lioncash1-1/+3
Provides slightly more context than only logging out the address value.
2018-07-24core_timing: Split off utility functions into core_timing_utilMerryMage2-0/+2
2018-07-24mutex: Pass SharedPtr to GetHighestPriorityMutexWaitingThread() by referenceLioncash1-1/+1
The pointed to thread's members are simply observed in this case, so we don't need to copy it here.
2018-07-24hle_ipc: Make constructors explicit where applicableLioncash1-1/+1
2018-07-23hle: Remove config_mem.h/.cppLioncash3-13/+0
This is just an unused hold-over from citra, so we can get rid of this to trim off an exposed global, among other things.
2018-07-23hle: Remove shared_page.h/.cppLioncash3-4/+0
This is a holdover from citra that's essentially unused.
2018-07-22Kernel/SVC: Perform atomic accesses in SignalProcessWideKey as per the real kernel.Subv1-7/+31
2018-07-21CPU: Save and restore the TPIDR_EL0 system register on every context switch.Subv3-0/+13
Note that there's currently a dynarmic bug preventing this register from being written.
2018-07-20thread: Convert ThreadStatus into an enum classLioncash9-71/+70
Makes the thread status strongly typed, so implicit conversions can't happen. It also makes it easier to catch mistakes at compile time.
2018-07-19hle_ipc: Introduce generic WriteBuffer overload for multiple container typesLioncash2-6/+21
This introduces a slightly more generic variant of WriteBuffer(). Notably, this variant doesn't constrain the arguments to only accepting std::vector instances. It accepts whatever adheres to the ContiguousContainer concept in the C++ standard library. This essentially means, std::array, std::string, and std::vector can be used directly with this interface. The interface no longer forces you to solely use containers that dynamically allocate. To ensure our overloads play nice with one another, we only enable the container-based WriteBuffer if the argument is not a pointer, otherwise we fall back to the pointer-based one.
2018-07-19svc: Correct always true assertion case in SetThreadCoreMaskLioncash1-3/+4
The reason this would never be true is that ideal_processor is a u8 and THREADPROCESSORID_DEFAULT is an s32. In this case, it boils down to how arithmetic conversions are performed before performing the comparison. If an unsigned value has a lesser conversion rank (aka smaller size) than the signed type being compared, then the unsigned value is promoted to the signed value (i.e. u8 -> s32 happens before the comparison). No sign-extension occurs here either. An alternative phrasing: Say we have a variable named core and it's given a value of -2. u8 core = -2; This becomes 254 due to the lack of sign. During integral promotion to the signed type, this still remains as 254, and therefore the condition will always be true, because no matter what value the u8 is given it will never be -2 in terms of 32 bits. Now, if one type was a s32 and one was a u32, this would be entirely different, since they have the same bit width (and the signed type would be converted to unsigned instead of the other way around) but would still have its representation preserved in terms of bits, allowing the comparison to be false in some cases, as opposed to being true all the time. --- We also get rid of two signed/unsigned comparison warnings while we're at it.
2018-07-19hle_ipc: Amend usage of buffer_index within one of HLERequestContext's WriteBuffer() overloadsLioncash1-1/+1
Previously, the buffer_index parameter was unused, causing all writes to use the buffer index of zero, which is not necessarily what is wanted all the time. Thankfully, all current usages don't use a buffer index other than zero, so this just prevents a bug before it has a chance to spring.
2018-07-19address_arbiter: Correct assignment within an assertion statement in WakeThreads()Lioncash1-1/+1
This was introduced within 4f81bc4e1bd12e4df7410c6790ba818d8dbba9c0, and considering there's no comment indicating that this is intentional, this is very likely a bug.
2018-07-19vm_manager: Add missing commas to string literal array elements in GetMemoryStateName()Lioncash1-22/+12
Without these, this would perform concatenation, which is definitely not what we want here.
2018-07-19core/memory, core/hle/kernel: Use std::move where applicableLioncash8-13/+21
Avoids pointless copies
2018-07-19core: Don't construct instance of Core::System, just to access its live instanceLioncash1-6/+6
This would result in a lot of allocations and related object construction, just to toss it all away immediately after the call. These are definitely not intentional, and it was intended that all of these should have been accessing the static function GetInstance() through the name itself, not constructed instances.
2018-07-17nvflinger: Fix for BufferQueue event handling.bunnei2-3/+11
2018-07-17Kernel/Arbiter: Fix bug in WaitIfLessThanMichael Scire1-2/+4
2018-07-16scheduler: Clear exclusive state when switching contextsMerryMage1-0/+1
2018-07-14No need to use ASSERT_MSG with an empty messageDavid Marcec1-2/+2
2018-07-03Update clang formatJames Rowe6-38/+35
2018-07-03Rename logging macro back to LOG_*James Rowe11-79/+79
2018-06-22IPC: skip empty buffer writemailwl1-0/+5
prevent yuzu crash, if games, like Axiom Verge, trying to read 0 bytes from file
2018-06-22Kernel/Arbiters: Fix casts, cleanup comments/magic numbersMichael Scire2-17/+16
2018-06-22Add additional missing format.Michael Scire2-21/+27
2018-06-22Run clang-format on PR.Michael Scire3-180/+181
2018-06-22Kernel/Arbiters: HLE is atomic, adjust code to reflect that.Michael Scire2-37/+13
2018-06-21Kernel/Arbiters: Initialize arb_wait_address in thread struct.Michael Scire2-1/+5
2018-06-21Kernel/Arbiters: Clear WaitAddress in SignalToAddressMichael Scire1-0/+1
2018-06-21Kernel/Arbiters: Mostly implement SignalToAddressMichael Scire4-10/+110
2018-06-21Kernel/Arbiters: Implement WaitForAddressMichael Scire4-6/+67
2018-06-21Kernel/Arbiters: Add stubs for 4.x SignalToAddress/WaitForAddres SVCs.Michael Scire7-9/+147
2018-06-20Build: Fixed some MSVC warnings in various parts of the code.Subv1-2/+2
2018-06-18svc: Add a stub for UserExceptionContextAddr.Jules Blok1-0/+5
2018-06-02Kernel/Threads: A thread waking up by timeout from a WaitProcessWideKey may already have an assigned lock owner.Subv1-2/+5
This situation may happen like so: Thread 1 with low priority calls WaitProcessWideKey with timeout. Thread 2 with high priority calls WaitProcessWideKey without timeout. Thread 3 calls SignalProcessWideKey - Thread 2 acquires the lock and awakens. - Thread 1 can't acquire the lock and is put to sleep with the lock owner being Thread 2. Thread 1's timeout expires, with the lock owner still being set to Thread 2.
2018-05-31Kernel/Thread: Corrected a typo that caused the affinity mask to never be changed.Subv1-2/+2
2018-05-31Kernel/SVC: Support special core values -2 and -3 in svcSetThreadCoreMask.Subv2-1/+28
Also added some proper error handling.
2018-05-30Kernel/Thread: Corrected a typo in an assert about the processor id.Subv1-1/+1
2018-05-26Add & correct miscellaneous things (#470)greggameplayer1-0/+3
* add some InfoType * correct OpenApplicationProxy cmd number * add IDisplayController functions * fix clang-format * add more system languages
2018-05-20Mutex: Do not assert when the mutex waiting threads list isn't empty on mutex release.Subv1-1/+0
A thread may own multiple mutexes at the same time, and only release one of them while other threads are waiting for the other mutexes.
2018-05-19Kernel/SVC: Signal the highest priority threads first in svcSignalProcessWideKey.Subv1-51/+68
2018-05-19Kernel/Threads: Reschedule the proper core when operating on that core's threads.Subv1-2/+6
2018-05-19SVC: Removed unused WaitSynchronization1 functionSubv1-30/+0
2018-05-17Added RequestWithContext & ControlWithContextDavid Marcec1-1/+3
2018-05-11thread: Rename mask to affinity_masks.bunnei3-4/+4
2018-05-11thread: Support core change on ResumeFromWait and improve ChangeCore.bunnei1-37/+68
2018-05-11scheduler: Protect scheduling functions with a global mutex.bunnei2-0/+18
2018-05-11thread: Initialize ideal_core and mask members.bunnei1-0/+2
2018-05-11threading: Reschedule only on cores that are necessary.bunnei2-3/+3
2018-05-11svc: Implement GetThreadCoreMask and SetThreadCoreMask.bunnei1-7/+22
2018-05-11thread: Implement ChangeCore function.bunnei2-1/+58
2018-05-11svc: SignalProcessWideKey should apply to all cores.bunnei1-43/+50
2018-05-11svc: Implement GetCurrentProcessorNumber.bunnei1-2/+2
2018-05-11core: Implement multicore support.bunnei5-45/+65
2018-05-02general: Make formatting of logged hex values more straightforwardLioncash6-49/+50
This makes the formatting expectations more obvious (e.g. any zero padding specified is padding that's entirely dedicated to the value being printed, not any pretty-printing that also gets tacked on).
2018-05-02ipc: Add support for PopIpcInterface() method.bunnei2-0/+15
- This can be used for domain objects as inputs to service functions.
2018-05-01GetSharedFontInOrderOfPriority (#381)David2-23/+27
* GetSharedFontInOrderOfPriority * Update pl_u.cpp * Ability to use ReadBuffer and WriteBuffer with different buffer indexes, fixed up GetSharedFontInOrderOfPriority * switched to NGLOG * Update pl_u.cpp * Update pl_u.cpp * language_code is actually language code and not index * u32->u64 * final cleanups
2018-04-30core_timing: Namespace all functions and constants in core_timing's headerLioncash2-3/+5
All of these variables and functions are related to timings and should be within the namespace.
2018-04-30string_util: Remove StringFromFormat() and related functionsLioncash1-1/+1
Given we utilize fmt, we don't need to provide our own functions for formatting anymore
2018-04-27core: Replace usages of LOG_GENERIC with new fmt-capable equivalentsLioncash3-6/+4
2018-04-27general: Convert assertion macros over to be fmt-compatibleLioncash4-9/+9
2018-04-26kernel/shared_memory: Remove unnecessary semicolon at end of ConvertPermissions()Lioncash1-1/+1
Functions don't need to be terminated by semicolons.
2018-04-26kernel: Migrate logging macros to fmt-compatible onesLioncash11-106/+109
2018-04-23Kernel: Implemented mutex priority inheritance.Subv4-10/+94
Verified with a hwtest and implemented based on reverse engineering. Thread A's priority will get bumped to the highest priority among all the threads that are waiting for a mutex that A holds. Once A releases the mutex and ownership is transferred to B, A's priority will return to normal and B's priority will be bumped.
2018-04-21Kernel: Use 0x2C as default main thread priority for homebrew and lone NRO/NSOsSubv1-1/+1
2018-04-21Qt: Update the WaitTree widget to show info about the current mutex of each thread.Subv1-4/+0
2018-04-21Kernel: Remove unused ConditionVariable class.Subv5-148/+0
2018-04-21Kernel: Remove old and unused Mutex code.Subv4-209/+3
2018-04-21Kernel: Properly implemented svcWaitProcessWideKey and svcSignalProcessWideKeySubv1-83/+46
They work in tandem with guest code to provide synchronization primitives along with svcArbitrateLock/Unlock
2018-04-21Kernel: Corrected the implementation of svcArbitrateLock and svcArbitrateUnlock.Subv6-22/+126
Switch mutexes are no longer kernel objects, they are managed in userland and only use the kernel to handle the contention case. Mutex addresses store a special flag value (0x40000000) to notify the guest code that there are still some threads waiting for the mutex to be released. This flag is updated when a thread calls ArbitrateUnlock. TODO: * Fix svcWaitProcessWideKey * Fix svcSignalProcessWideKey * Remove the Mutex class.
2018-04-21resource_limit: Make ResourceTypes an enum classLioncash3-38/+38
Prevents enum identifiers from leaking into the surrounding scope.
2018-04-20common_funcs: Remove ARRAY_SIZE macroLioncash1-1/+2
C++17 has non-member size() which we can just call where necessary.
2018-04-17Various service name fixes - part 2 (rebased) (#322)Hexagon121-8/+8
* Updated ACC with more service names * Updated SVC with more service names * Updated set with more service names * Updated sockets with more service names * Updated SPL with more service names * Updated time with more service names * Updated vi with more service names
2018-04-15vm_manager: Increase GetTotalMemoryUsage value.bunnei1-1/+1
- Gets Binding of Isaac running.
2018-04-03svc: Stub out SetThreadActivity, GetThreadContext.bunnei2-2/+19
2018-04-03shared_memory: Remove incorrect 3ds-specific check.bunnei1-12/+0
2018-04-01hle_ipc, fsp_srv: Cleanup logging.bunnei1-1/+1
2018-03-31hle_ipc: Do not ensure write buffer size.bunnei1-2/+5
2018-03-31memory: Fix stack region.bunnei2-3/+4
2018-03-30svc: Stub GetThreadCoreMask.bunnei2-3/+26
2018-03-19Clang FixesN00byKing2-5/+5
2018-03-19More Warning cleanupsN00byKing2-2/+2
2018-03-19Clean Warnings (?)N00byKing5-8/+8
2018-03-19hle_ipc: Add SleepClientThread to block current thread within HLE routines.bunnei2-0/+47
2018-03-19hle_ipc: Use shared_ptr instead of unique_ptr to allow copies.bunnei2-9/+9
2018-03-19hle_ipc: Remove GetPointer(..) usage with WriteToOutgoingCommandBuffer.bunnei2-5/+13
2018-03-19thread: Add THREADSTATUS_WAIT_HLE_EVENT, remove THREADSTATUS_WAIT_ARB.bunnei3-20/+6
2018-03-17process: MirrorMemory should use MemoryState::Mapped.bunnei1-1/+1
2018-03-16process: Unmap previously allocated heap.bunnei1-1/+3
2018-03-16arm_interface: Support unmapping previously mapped memory.bunnei1-0/+3
2018-03-16svc: Use more correct values for GetInfo MapRegion and NewMapRegion.bunnei3-29/+5
2018-03-16kernel: Move stack region outside of application heap.bunnei3-8/+3
2018-03-16process: Fix stack memory state.bunnei1-2/+4
2018-03-16MemoryState: Add additional memory states and improve naming.bunnei5-18/+45
2018-03-14core: Move process creation out of global state.bunnei9-33/+36
2018-03-02Kernel: Store the program id in the Process class instead of the CodeSet class.Subv2-9/+8
There may be many CodeSets per Process, so it's wasteful and overcomplicated to store the program id in each of them.
2018-02-27thread: Clear the process list on shutdown.Jules Blok1-1/+3
2018-02-25(Hopefully) Fix MinGW BuildN00byKing1-1/+1
2018-02-25Add UnmapSharedMemoryN00byKing2-1/+17
C++11 requires spaces on the Identifier Add inttypes include clang
2018-02-22Stub more functionsmailwl1-1/+11
2018-02-20Add warning if Domain request has no domain message headermailwl1-0/+3
2018-02-20Fix: change check for domain order and existance of domain message headermailwl2-2/+2
2018-02-20IPC: add domain header to response if only it exists in requestmailwl2-5/+7
2018-02-19scheduler: Cleanup based on PR feedback.bunnei2-4/+3
2018-02-18kernel: Use Scheduler class for threading.bunnei3-172/+16
2018-02-18kernel: Add Scheduler, which encapsulates the scheduling loading from Thread module.bunnei2-0/+208
2018-02-18kernel: Remove unused address_arbiter code.bunnei4-197/+0
2018-02-18 Kernel/IPC: Add a small delay after each SyncRequest to prevent thread starvation.Subv4-50/+63
Ported from citra PR #3091 The delay specified here is from a Nintendo 3DS, and should be measured in a Nintendo Switch. This change is enough to prevent Puyo Puyo Tetris's main thread starvation.
2018-02-16Service/hid: stub some functionsmailwl2-0/+53
2018-02-15shared_memory: Remove some checks.bunnei1-13/+0
2018-02-14hle_ipc: Remove const from WriteBuffer size.bunnei2-2/+2
2018-02-14thread: Silence formatting specifier warningsLioncash1-2/+3
2018-02-14vm_manager: Silence formatting specifier warningsLioncash1-5/+7
2018-02-14hle_ipc: Add GetReadBufferSize and check write buffer size.bunnei2-0/+10
2018-02-14hle_ipc: Add helper functions for reading and writing buffers.bunnei1-4/+2
2018-02-14hle_ipc: Add helper functions for reading and writing buffers.bunnei2-0/+51
2018-02-06mutex: Update hasWaiters on release.bunnei1-0/+1
2018-02-04GetInfo: Implement IsCurrentProcessBeingDebugged.bunnei1-0/+3
2018-02-04WaitProcessWideKeyAtomic: Handle case where condition variable was already created.bunnei3-13/+17
2018-02-03svc: SharedMemory size should be 64-bits and cleanup.bunnei3-11/+11
2018-02-03ArbitrateLock: Assert that requesting_thread is current_thread.bunnei1-0/+1
2018-01-30shared_memory: Only mark addresses as invalid if they are within the heapshinyquagsire231-1/+2
2018-01-27memory: Replace all memory hooking with Special regionsMerryMage2-6/+6
2018-01-25server_session: Fix scenario where all domain handlers are closed.bunnei1-3/+3
2018-01-25hle: Rename RequestBuilder to ResponseBuilder.bunnei1-1/+1
2018-01-25ipc_helpers: Make interface domain agnostic and add header validation.bunnei1-1/+12
2018-01-25hle: Integrate Domain handling into ServerSession.bunnei5-28/+66
2018-01-25hle: Remove Domain and SyncObject kernel objects.bunnei7-164/+2
2018-01-25handle_table: Remove ConvertSessionToDomain.bunnei2-17/+0
2018-01-21Format: Run the new clang format on everythingJames Rowe22-31/+32
2018-01-20Added CreateSharedMemory & UNIMPLEMENTED() for non existent services. (#113)David2-1/+22
* Added svcCreateSharedMemory * Services which are not implemented now throw UNIMPLEMENTED() * clang-format * changed perms to u32 * removed camelcase
2018-01-20Fixes some cast warnings, partial port of citra #3064 (#106)River City Ransomware2-2/+2
* Fixes some cast warnings, partially fixes citra #3064 * Converted casts to uint32_t to u32 * Ran clang-format
2018-01-19svc: Fix svcGetInfo MapRegionBaseAddr.bunnei3-1/+9
2018-01-19svc: Add additional fields to MemoryInfo struct.bunnei1-0/+4
2018-01-18Stub PopLaunchParameter and implement Buffer C Descriptors reading on hle_ipc (#96)gdkchan2-7/+33
* Stub PopLaunchParameter and implement Buffer C Descriptors reading * Address PR feedback * Ensure we push a u64 not a size_t * Fix formatting
2018-01-18svc: Rename some entries to match their analogue on SwitchBrewLioncash1-7/+7
Makes the codebase a little more consistent with regards to available documentation. Also amends the duplicate case where there was a similar entry at 0x72 named ConnectToPort.
2018-01-18svc: Add CreateJitMemory and MapJitMemory svc stringsLioncash1-2/+2
Makes the table match SwitchBrew for these entries
2018-01-17svc: Clang-format fix.bunnei1-6/+4
2018-01-17hle_ipc: Clang format.bunnei1-2/+3
2018-01-17ipc: Implement domain command CloseVirtualHandle.bunnei2-2/+28
2018-01-17SVC: Correct some return values in svcGetInfo and added TitleId and PrivilegedProcessId stubs.Subv1-6/+21
# Conflicts: # src/core/hle/kernel/svc.cpp
2018-01-17SVC: Add 4.0.0+ comment to GetInfoType enum values.Subv1-0/+1
2018-01-17IPC: Push domain objects as move handles when not in a domain.Subv1-0/+8
2018-01-16SetThreadCoreMask stub, time to implement fspDavid Marcec1-1/+6
2018-01-16Added more svcGetInfo pairsDavid Marcec4-2/+29
2018-01-16clang-formatMerryMage6-18/+14
2018-01-14shared_memory: Minor fixes and cleanup.bunnei1-6/+6
2018-01-14svc: Implement svcMapSharedMemory.bunnei2-1/+38
2018-01-14kernel: Increase default stack size to 64K.bunnei1-1/+1
2018-01-13yuzu: Update license text to be consistent across project.bunnei14-14/+14
2018-01-12core: Include <algorithm> where used.bunnei1-0/+2
2018-01-12core: Fix recent GCC build breaks.bunnei1-2/+2
2018-01-12svc: Implement GetSystemTick.bunnei2-2/+21
2018-01-11IPC: Corrected some definitions for the buffer C descriptor flags.Subv2-1/+8
2018-01-11svc: Stub ResetSignal and CreateTransferMemorySubv2-3/+28
2018-01-11svc: Stub SetMemoryAttributeSubv2-0/+11
2018-01-10Threads: Added enum values for the Switch's 4 cpu cores and implemented svcGetInfo(AllowedCpuIdBitmask)Subv4-10/+25
2018-01-09SVC: Fixed WaitSynchronization with multiple handles when none is immediately ready.Subv1-7/+18
2018-01-09SVC: Implemented CancelSynchronization.Subv2-1/+19
2018-01-09ErrorCodes: Updated the InvalidHandle and Timeout kernel error codes.Subv1-2/+7
2018-01-09SVC: Fixed WaitSynchronization with multiple handles when at least one of them is ready.Subv2-3/+29
2018-01-09kernel: Rename Semaphore to ConditionVariable.bunnei8-159/+167
2018-01-09mutex: Remove unused call to VerifyGuestState.bunnei1-3/+0
2018-01-09Kernel: Actually wake up the requested number of threads in Semaphore::Release.Subv3-18/+16
Also properly keep track of data in guest memory, this fixes managing the semaphore from userland. It was found that Semaphores are actually Condition Variables, with Release(1) and Release(-1) being equivalent to notify_one and notify_all. We should change the name of the class to reflect this.
2018-01-09Kernel: Properly keep track of mutex lock data in the guest memory. This fixes userland locking/unlocking.Subv3-63/+60
2018-01-09Kernel: Allow chaining WaitSynchronization calls inside a wakeup callback.Subv4-30/+78
2018-01-09CoreTiming: Reworked CoreTiming (cherry-picked from Citra #3119)B3n302-9/+5
* CoreTiming: New CoreTiming; Add Test for CoreTiming
2018-01-07IPC: Add functions to read the input move/copy objects from an IPC request.Subv2-2/+26
2018-01-07IPC: Don't attempt to read the command buffer if it holds a Close request.Subv1-0/+5
2018-01-07IPC Cleanup: Remove 3DS-specific code and translate copy, move and domain objects in IPC requests.Subv2-74/+72
Popping objects from the buffer is still not implemented.
2018-01-07IPC: Skip the entire u64 of the command id when receiving an IPC request.Subv1-1/+2
Service code now doesn't have to deal with this.
2018-01-07IPC: Use the correct size when pushing raw data to the command buffer and fixed pushing domain objects.Subv2-3/+7
Domain object ids are always stored immediately after the raw data.
2018-01-07svc: Implement svcSignalProcessWideKey.bunnei2-4/+23
2018-01-07semaphore: More changes for Switch.bunnei2-11/+17
2018-01-07wait_object: Refactor to allow waking up a single thread.bunnei2-15/+28
2018-01-06svc: Implement svcWaitProcessWideKeyAtomic.bunnei2-1/+54
2018-01-06semaphore: Updates for Switch.bunnei2-21/+31
2018-01-06svc: Implement WaitSynchronization for a single handle.bunnei1-4/+24
2018-01-06svc: Refactor LockMutex code to use WaitSynchronization1.bunnei1-13/+45
2018-01-05svc: Add missing string_util include.bunnei1-0/+1
2018-01-03arm: Remove SkyEye/Dyncom code that is ARMv6-only.bunnei2-23/+11
2018-01-03vm_manager: Use a more reasonable MAX_ADDRESS size.bunnei1-5/+4
2018-01-03svc: Remove unnecessary "svc" prefix to naming scheme.bunnei1-106/+106
2018-01-03hle: Move SVC code to kernel namespace.bunnei3-0/+805
2018-01-01vm_manager: Stub out a bunch of interfaces used by svcGetInfo.bunnei2-1/+51
2018-01-01core/video_core: Fix a bunch of u64 -> u32 warnings.bunnei1-2/+2
2018-01-01svc: Implement svcExitProcess.bunnei2-7/+38
2018-01-01svc: Implement svcLockMutex.bunnei2-23/+95
2018-01-01kernel: Add ObjectAddressTable class.bunnei3-2/+101
2017-12-31thread: Keep track of the initially created handle.bunnei2-1/+5
This is kinda crufty, but we need it for now to update guest state variables.
2017-12-31errors: Define missing kernel error codes.bunnei1-0/+3
2017-12-31svc: Implement svcUnmapMemory.bunnei2-0/+7
2017-12-30thread: Main thread should set thread handle to reg 1.bunnei1-1/+4
2017-12-30thread: Remove THUMB mode flag.bunnei1-1/+1
2017-12-30thread: Main thread should be ready by default, all others dormant.bunnei1-4/+3
2017-12-29kernel: Various 64-bit fixes in memory/process/threadbunnei5-14/+14
2017-12-29kernel: Fix implementation of ConvertSessionToDomain.bunnei6-30/+67
2017-12-29kernel: Add basic support for Domain object.bunnei4-4/+110
2017-12-29kernel: Add SyncObject primitive, use it for ClientSession.bunnei2-8/+38
2017-12-29process: Add method to mirror a memory region.bunnei2-0/+27
2017-11-01service: Return proper result code for IPC::CommandType::Close.bunnei2-6/+7
2017-11-01hle: Use Switch formatted result codes.bunnei2-77/+22
2017-10-20hle: Fix QueryMemory response for MemoryInfo.bunnei4-115/+14
2017-10-19hle_ipc: Only copy necessary fields for outgoing command buffer.bunnei1-1/+1
2017-10-19hle_ipc: Parse out buffer X/A/B/B descriptors from incoming command buffer.bunnei2-14/+19
2017-10-15hle: Implement ConvertSessionToDomain, various cleanups.bunnei3-5/+31
2017-10-15hle: Initial implementation of NX service framework and IPC.bunnei2-70/+107
2017-10-10loader: Various improvements for NSO/NRO loaders.bunnei2-4/+4
2017-10-02Kernel/SharedMemory: Don't take over and unmap the source memory block when creating a shared memory, just reference it.Subv1-15/+12
Also reference the right offset into the backing block for the requested address.
2017-10-01Kernel/Thread: Added a helper function to get a thread's command buffer VAddr.Subv2-0/+12
2017-09-30nso: Refactor and allocate .bss section.bunnei2-8/+10
2017-09-30process: Support loading multiple codesets.bunnei2-20/+27
2017-09-30kernel: Various threading fixes to support 64-bit addressing.bunnei2-8/+8
2017-09-30core: Various changes to support 64-bit addressing.bunnei2-21/+21
2017-09-30Fixed type conversion ambiguityHuw Pascoe9-23/+24
2017-09-28Kernel/Threads: When putting a thread to wait, specify a function to execute when it is awoken.Subv3-13/+26
This change makes for a clearer (less confusing) path of execution in the scheduler, now the code to execute when a thread awakes is closer to the code that puts the thread to sleep (WaitSynch1, WaitSynchN). It also allows us to implement the special wake up behavior of ReplyAndReceive without hacking up WaitObject::WakeupAllWaitingThreads. If savestates are desired in the future, we can change this implementation to one similar to the CoreTiming event system, where we first register the callback functions at startup and assign their identifiers to the Thread callback variable instead of directly assigning a lambda to the wake up callback variable.
2017-09-27Kernel/Thread: Allow specifying which process a thread belongs to when creating it.Subv3-15/+19
Don't automatically assume that Thread::Create will only be called when the parent process is currently scheduled. This assumption will be broken when applets or system modules are loaded.
2017-09-24memory: Add GetCurrentPageTable/SetCurrentPageTableMerryMage1-7/+4
Don't expose Memory::current_page_table as a global.
2017-09-15Kernel/Threads: Don't clear the CPU instruction cache when performing a context switch from an idle thread into a thread in the same process.Subv1-1/+3
We were unnecessarily clearing the cache when going from Process A -> Idle -> Process A, this caused extreme performance regressions.
2017-09-15Kernel/Memory: Changed GetPhysicalPointer so that it doesn't go through the current process' page table to obtain a pointer.Subv2-25/+7
2017-09-10Kernel/Memory: Switch the current page table when a new process is scheduled.Subv1-0/+10
2017-09-10Kernel/Memory: Give each Process its own page table.Subv2-5/+14
The loader is in charge of setting the newly created process's page table as the main one during the loading process.
2017-08-22Kernel/HLE: Use a mutex to synchronize access to the HLE kernel state between the cpu thread and any other possible threads that might touch the kernel (network thread, etc).Subv1-1/+1
This mutex is acquired in SVC::CallSVC, ie, as soon as the guest application enters the HLE kernel, and should be acquired by the aforementioned threads before modifying kernel structures.
2017-08-22Kernel/Threads: Don't immediately switch to the new main thread when loading a new process.Subv1-5/+1
This is necessary for loading multiple processes at the same time. The main thread will be automatically scheduled when necessary once the scheduler runs.
2017-08-21Warnings: Add UNREACHABLE macros to switches that contemplate all possible values.Subv1-0/+3
2017-06-29Kernel/SVC: Pass the current thread as a parameter to ClientSession::SendSyncRequest.Subv2-3/+6
2017-06-26Kernel/Sessions: Clean up the list of pending request threads of a session when the client endpoint is closed.Subv1-0/+5
2017-06-25Kernel/ServerSession: Keep track of which threads have issued sync requests.Subv3-9/+29
2017-06-23Kernel: Implement AcceptSession SVCYuri Kunde Schlesner3-2/+26
2017-06-22Memory: Make PhysicalToVirtualAddress return a boost::optionalYuri Kunde Schlesner1-1/+1
And fix a few places in the code to take advantage of that.
2017-06-21Kernel/IPC: Support translation of null handlesYuri Kunde Schlesner1-7/+12
Missed this in my first implementation. Thanks to @wwylele for pointing out that this was missing.
2017-06-19ResultVal: Remove MoveFrom()Yuri Kunde Schlesner4-7/+7
Replace it with std::move(result_val).Unwrap(), or Foo().Unwrap() in case you already have an rvalue.
2017-06-19Kernel: Add comment about the extended linear heap areaYuri Kunde Schlesner1-0/+2
2017-06-19Kernel/IPC: Make HLERequestContext usable from outside kernelYuri Kunde Schlesner2-3/+9
2017-06-12Kernel/IPC: Use boost::small_vector for HLE context objectsYuri Kunde Schlesner1-1/+3
2017-06-11Kernel: Allow clearing request_objects to re-use buffer spaceYuri Kunde Schlesner2-0/+11
Reduces the necessary allocation to max(in_handles, out_handles) rather than (in_handles + out_handles).
2017-06-11Kernel: Basic support for IPC translation for HLE servicesYuri Kunde Schlesner2-6/+125
2017-06-11Kernel: Add methods in HLERequestContext abstracting handle creationYuri Kunde Schlesner2-0/+12
2017-06-11ServiceFramework: Use separate copy of command bufferYuri Kunde Schlesner1-3/+6
Copy the IPC command buffer to/from the request context before/after the handler is invoked. This is part of a move away from using global data for handling IPC requests.
2017-06-08Session: Remove/add some forward declarationsYuri Kunde Schlesner2-1/+2
2017-06-08Kernel: Ensure objects are kept alive during ClientSession disconnectionYuri Kunde Schlesner1-7/+13
Fixes #2760
2017-06-08Service: Add new ServiceFramework framework for writing HLE servicesYuri Kunde Schlesner2-2/+36
The old "Interface" class had a few problems such as using free functions (Which didn't allow you to write the service handler as if it were a regular class.) which weren't very extensible. (Only received one parameter with a pointer to the Interface object.) The new ServiceFramework aims to solve these problems by working with member functions and passing a generic context struct as parameter. This struct can be extended in the future without having to update all existing service implementations.
2017-06-06Kernel: Remove some unnecessary namespace qualificationsYuri Kunde Schlesner1-4/+6
2017-06-06Kernel: Add a dedicated SetHleHandler method to ServerPort/ServerSessionYuri Kunde Schlesner7-33/+36
This allows attaching a HLE handle to a ServerPort at any point after it is created, allowing port/session creation to be generic between HLE and regular services.
2017-06-06HLE: Move SessionRequestHandler from Service:: to Kernel::Yuri Kunde Schlesner8-15/+90
Most of the code that works with this is or will be in the kernel, so it's a more appropriate place for it to be.
2017-05-30Kernel: Move HandleTable to a separate fileYuri Kunde Schlesner13-202/+234
2017-05-30Kernel: Move WaitObject to a separate fileYuri Kunde Schlesner11-132/+173
Now that HandleTable doesn't directly depend on WaitObject anymore, this can be separated from the main kernel.h header.
2017-05-30Kernel: Removed HandleTable::GetWaitObjectYuri Kunde Schlesner1-9/+0
This isn't necessary anymore since plain Get works correctly for WaitObjects.
2017-05-29Kernel: Extract dynamic Object pointer cast into its own functionYuri Kunde Schlesner1-11/+24
2017-05-25Kernel: Centralize error definitions in errors.hYuri Kunde Schlesner13-46/+133
2017-05-22Kernel/Sessions: Remove the ClientSession::Create function.Subv3-16/+3
It is not meant to be used by anything other than CreateSessionPair.
2017-05-15Kernel: Remove a now unused enum and variable regarding a session's status.Subv2-8/+0
2017-05-15Kernel: Use a Session object to keep track of the status of a Client/Server session pair.Subv6-32/+84
Reduce the associated port's connection count when a ServerSession is destroyed.
2017-05-10Kernel: Map special regions according to ExHeaderYuri Kunde Schlesner4-50/+102
This replaces the hardcoded VRAM/DSP mappings with ones made based on the ExHeader ARM11 Kernel caps list. While this has no visible effect for most applications (since they use a standard set of mappings) it does improve support for system modules and n3DS exclusives.
2017-05-10DSP: Create backing memory for entire DSP RAMYuri Kunde Schlesner1-1/+6
Also move address space mapping out of video_core.
2017-02-27Timer: restore missing signaled=true from #2421wwylele1-0/+2
2017-02-27Fix log entry in timer::signal (#2600)B3n301-1/+1
2017-02-27Doxygen: Amend minor issues (#2593)Mat M1-1/+2
Corrects a few issues with regards to Doxygen documentation, for example: - Incorrect parameter referencing. - Missing @param tags. - Typos in @param tags. and a few minor other issues.
2017-02-27Core: Remove unnecessary include in thread.hYuri Kunde Schlesner2-1/+1
2017-02-22Timers: Immediately signal the timer if it was started with an initial value of 0.Subv2-16/+31
2017-01-11Threads: Check the process' resource limit for the max allowed priority when creating a thread and remove the priority clamping code.Subv1-8/+2
2017-01-11Thread: Added priority range checking to svcSetThreadPriority and removed priority clamping code from Thread::SetPriority.Subv2-18/+4
2017-01-06Kernel: Don't attempt to yield execution in SleepThread(0) if there are no available threads to run.Subv2-0/+9
With this we avoid an useless temporary deschedule of the current thread.
2017-01-05Kernel: Remove some unused functions.Subv2-32/+0
2017-01-05Kernel: Removed the priority boost code for starved threads.Subv1-27/+0
After hwtesting and reverse engineering the kernel, it was found that the CTROS scheduler performs no priority boosting for threads like this, although some other forms of scheduling priority-starved threads might take place. For example, it was found that hardware interrupts might cause low-priority threads to run if the CPU is preempted in the middle of an SVC handler that deschedules the current (high priority) thread before scheduling it again.
2017-01-05Kernel: Implemented Pulse event and timers.Subv5-13/+20
Closes #1904
2017-01-05Kernel/Semaphore: Fixed a regression in semaphore waits.Subv1-1/+2
The regression was caused by a missing check in #2260. The new behavior is consistent with the real kernel.
2017-01-05Kernel: Add some asserts to enforce the invariants in the scheduler.Subv2-2/+13
2017-01-05Kernel: Remove a thread from all of its waiting objects' waiting_threads list when it is awoken.Subv1-18/+4
This fixes a potential bug where threads would not get removed from said list if they awoke after waiting with WaitSynchronizationN with wait_all = false
2017-01-05Kernel: Remove Thread::wait_objects_index and use wait_objects to hold all the objects that a thread is waiting on.Subv3-10/+19
2017-01-04Kernel: Use different thread statuses when a thread calls WaitSynchronization1 and WaitSynchronizationN with wait_all = true.Subv2-13/+17
This commit removes the overly general THREADSTATUS_WAIT_SYNCH and replaces it with two more granular statuses: THREADSTATUS_WAIT_SYNCH_ANY when a thread waits on objects via WaitSynchronization1 or WaitSynchronizationN with wait_all = false. THREADSTATUS_WAIT_SYNCH_ALL when a thread waits on objects via WaitSynchronizationN with wait_all = true.
2017-01-04Kernel/Mutex: Propagate thread priority changes to other threads inheriting the priority via mutexesSubv4-42/+54
2017-01-04Kernel/Mutex: Update a mutex priority when a thread stops waiting on it.Subv4-22/+39
2017-01-04Kernel/Mutex: Implemented priority inheritance.Subv4-22/+51
The implementation is based on reverse engineering of the 3DS's kernel. A mutex holder's priority will be temporarily boosted to the best priority among any threads that want to acquire any of its held mutexes. When the holder releases the mutex, it's priority will be boosted to the best priority among the threads that want to acquire any of its remaining held mutexes.
2017-01-04Kernel: Object ShouldWait and Acquire calls now take a thread as a parameter.Subv16-62/+50
This will be useful when implementing mutex priority inheritance.
2017-01-04Kernel/Synch: Do not attempt a reschedule on every syscall.Subv1-0/+1
Not all syscalls should cause reschedules, this commit attempts to remedy that, however, it still does not cover all cases.
2016-12-22ThreadContext: Move from "core" to "arm_interface".bunnei2-4/+5
2016-12-22core: Replace "AppCore" nomenclature with just "CPU".bunnei1-3/+3
2016-12-22core: Remove HLE module, consolidate code & various cleanups.bunnei4-7/+3
2016-12-22core: Consolidate core and system state, remove system module & cleanups.bunnei1-3/+3
2016-12-17Thread: remove the thread from the thread list when exitingwwylele2-2/+14
2016-12-16Kernel: remove object's waiting thread if it is deadwwylele1-1/+2
2016-12-14Fixed the codestyle to match our clang-format rules.Subv7-33/+51
2016-12-14Fixed the codestyle to match our clang-format rules.Subv2-8/+11
2016-12-10Properly remove a thread from its wait_objects' waitlist when it is awoken by a timeout.Subv2-1/+10
2016-12-09Moved the HLE command buffer translation task to ServerSession instead of the HLE handler superclass.Subv2-2/+23
2016-12-09WaitSynch: Removed unused variables and reduced SharedPtr copies.Subv3-13/+11
Define a variable with the value of the sync timeout error code. Use a boost::flat_map instead of an unordered_map to hold the equivalence of objects and wait indices in a WaitSynchN call.
2016-12-08Added a framework for partially handling Session disconnections.Subv4-9/+35
Further implementation will happen in a future commit. Fixes a regression.
2016-12-08Use std::move where appropriate.Subv5-7/+13
2016-12-07Use boost remove_erase_if instead of the erase-remove idiomSubv1-2/+3
2016-12-07Improved the algorithm for GetHighestPriorityReadyThread.Subv1-14/+13
2016-12-05Return an error code when connecting to a saturated port.Subv2-4/+11
The error code was taken from the 3DS kernel.
2016-12-05Split SessionRequestHandler::HandleSyncRequest into HandleSyncRequest, TranslateRequest and HandleSyncRequestImpl.Subv2-0/+2
HandleSyncRequest now takes care of calling the command buffer translate function before actually invoking the command handler for HLE services.
2016-12-05Kernel: Remove the Redirection handle type.Subv1-2/+0
2016-12-05KServerPorts now have an HLE handler "template", which is inherited by all ServerSessions created from it.Subv8-35/+60
2016-12-04Threading: Added some utility functions and const correctness.Subv2-10/+22
2016-12-04Threading: Reworked the way our scheduler works.Subv6-111/+76
Threads will now be awakened when the objects they're waiting on are signaled, instead of repeating the WaitSynchronization call every now and then. The scheduler is now called once after every SVC call, and once after a thread is awakened from sleep by its timeout callback. This new implementation is based off reverse-engineering of the real kernel. See https://gist.github.com/Subv/02f29bd9f1e5deb7aceea1e8f019c8f4 for a more detailed description of how the real kernel handles rescheduling.
2016-12-03Declare empty ServerSession and ClientSession constructors as default.Subv2-4/+4
2016-12-01Fixed the rebase mistakes.Subv7-51/+46
2016-12-01A bit of a redesign.Subv6-215/+24
Sessions and Ports are now detached from each other. HLE services are handled by means of a SessionRequestHandler class, Interface now inherits from this class. The File and Directory classes are no longer kernel objects, but SessionRequestHandlers instead, bound to a ServerSession when requested. File::OpenLinkFile now creates a new session pair and binds the File instance to it.
2016-12-01IPC/HLE: Associate the ClientSessions with their parent port's HLE interface if it exists.Subv4-22/+15
Pass the triggering ServerSession to the HLE command handler to differentiate which session caused the request.
2016-12-01Kernel/HLE: Service::Interface no longer inherits from any Kernel object, and is now its own standalone class.Subv2-8/+44
Interface is now used by aggregation in ClientPort, to forward service commands to their HLE implementation if needed.
2016-12-01fixup! Kernel/IPC: Use Ports and Sessions as the fundamental building block of Inter Process Communication.Subv3-4/+5
2016-12-01 Kernel/IPC: Use Ports and Sessions as the fundamental building block of Inter Process Communication.Subv7-56/+233
All handles obtained via srv::GetServiceHandle or svcConnectToPort are references to ClientSessions. Service modules will wait on the counterpart of those ClientSessions (Called ServerSessions) using svcReplyAndReceive or svcWaitSynchronization[1|N], and will be awoken when a SyncRequest is performed. HLE Interfaces are now ClientPorts which override the HandleSyncRequest virtual member function to perform command handling immediately.
2016-11-20Kernel/Loader: Grab the system mode from the NCCH ExHeader.Subv2-6/+4
3dsx and elf files default to system mode 2 (96MB allocated to the application). This allows Home Menu to boot without modifications. Closes #1849
2016-11-19Kernel/Events: Log an error when trying to create Pulse events and timers.Subv2-0/+10
Related to #1904
2016-10-20Fix typosRicardo de Almeida Gonzaga2-2/+2
2016-09-22move ResetType to kernel.hwwylele3-7/+6
2016-09-22implement wait tree widgetwwylele4-0/+16
2016-09-21Use negative priorities to avoid special-casing the self-includeYuri Kunde Schlesner14-14/+14
2016-09-21Remove empty newlines in #include blocks.Emmanuel Gil Peyrot29-74/+16
This makes clang-format useful on those. Also add a bunch of forgotten transitive includes, which otherwise prevented compilation.
2016-09-19Manually tweak source formatting and then re-run clang-formatYuri Kunde Schlesner15-64/+36
2016-09-18Sources: Run clang-format on everything.Emmanuel Gil Peyrot30-419/+616
2016-09-15arm: ResetContext shouldn't be part of ARM_Interface.bunnei1-1/+17
2016-08-02fix #1942 and adds a few IPC functions for descriptorsLectem1-15/+103
2016-06-11Kernel/SVC: Implemented svcCreatePort.Subv4-2/+11
2016-06-05Kernel: Added ClientPort and ServerPort classes.Subv5-2/+135
This is part of an ongoing effort to implement support for multiple processes.
2016-06-04Thread: update timeout when rerunning WaitSynchwwylele1-0/+49
2016-05-31Fix parameter name in EnableNotificationmailwl1-0/+4
2016-05-30Switch context on the same thread if necessarywwylele1-2/+6
2016-05-26Memory: Added necessary headers and removed unnecessary headerMerryMage1-0/+1
2016-05-21Kernel/Thread: Remove use of Memory::GetPointerMerryMage1-1/+1
2016-05-17Set fpscr for new threadsJannik Vogel1-0/+2
2016-05-14Memory: Fixed a regression caused by #1695 and #1689.Subv1-0/+3
Reserve enough space in the vector that holds the linear heap memory to prevent relocations of the backing memory when growing too much. Closes #1790
2016-05-13HLE/Applets: Give each applet its own block of heap memory, and use that when creating the framebuffer shared memory block.Subv2-1/+30
2016-05-13Kernel: Account for automatically-allocated shared memories in the amount of used linear heap memory.Subv1-0/+5
2016-05-13Kernel/SharedMemory: Log an error when Map fails.Subv1-1/+10
2016-05-13Kernel: Implemented shared memory permissions.Subv2-9/+47
2016-05-13Kernel/Memory: Remove the Shared Memory region from the legacy memory map.Subv1-1/+0
2016-05-13Kernel/SharedMemory: Properly implemented shared memory support.Subv2-65/+79
Applications can request the kernel to allocate a piece of the linear heap for them when creating a shared memory object. Shared memory areas are now properly mapped into the target processes when calling svcMapMemoryBlock. Removed the APT Shared Font hack as it is no longer needed.
2016-05-13Kernel/SVC: Fixed the register order for svcCreateMemoryBlock.Subv1-1/+1
R0 is used as the last parameter instead of R4.
2016-05-07Kernel/Threading: Warn when a thread can be scheduled in the Syscore (Core 1).Subv1-0/+2
We do not currently implement any cores other than the AppCore (Core 0).
2016-05-07Kernel/Threads: Dynamically allocate the TLS region for threads in the BASE region of the linear heap.Subv4-22/+74
Each thread gets a 0x200-byte area from the 0x1000-sized page, when all 8 thread slots in a single page are used up, the kernel allocates a new page to hold another 8 entries. This is consistent with what the real kernel does.
2016-04-05Common: Remove Common::make_unique, use std::make_uniqueMerryMage1-1/+2
2016-03-21session: Make helper functions constexprLioncash1-6/+6
2016-03-21hle: Get rid of global access to g_rescheduleLioncash1-1/+2
This shouldn't be directly exposed if there's already a partial API that operates on it. We can just provide the rest of that API.
2016-03-13svc: Move ResetType enum to the kernel event headerLioncash2-2/+8
2016-03-12svc: Make ResetType an enum classLioncash2-2/+2
2016-03-06Memory: Do correct Phys->Virt address translation for non-APP linheapYuri Kunde Schlesner2-2/+5
2016-02-21AudioCore: Skeleton ImplementationMerryMage1-1/+4
This commit: * Adds a new subproject, audio_core. * Defines structures that exist in DSP shared memory. * Hooks up various other parts of the emulator into audio core. This sets the foundation for a later HLE DSP implementation.
2016-02-12BitField: Make trivially copyable and remove assignment operatorMerryMage1-1/+1
2016-01-30Memory: Implement MMIOMerryMage2-4/+8
2016-01-14HLE/SVC: Implement UnmapMemoryBlock.Subv2-0/+28
This implementation will need to be (almost completely) changed when we implement multiprocess support.
2015-12-30HLE/Timers: Reset OneShot timers when they are acquired instead of when they're triggered.Subv1-3/+3
Closes #1139
2015-12-28SVC: Fixed ArbitrateAddress to behave as it does on hardware.Subv2-9/+18
This was verified with hwtests that i plan to upload later on.
2015-12-01Kernel: Implement svcGetSystemInfoYuri Kunde Schlesner4-0/+12
This makes smealum/ctrulib@b96dd51d3349961189d4ab1bc2a5c45deff21c09 work with Citra.
2015-10-07Silence -Wsign-compare warnings.Rohit Nirmal1-1/+1
2015-09-16general: Silence some warnings when using clangLioncash1-2/+4
2015-09-10General: Fix up doxygen commentsLioncash3-6/+3
2015-08-28Kernel: Fix wrong linear heap base on titles using newer kernelsYuri Kunde Schlesner1-1/+1
Typo which sneaked in through review on #1025
2015-08-27Kernel: Fix assertion failure when ControlMemory is called with size=0Yuri Kunde Schlesner1-0/+8
2015-08-27Core: Improve APT Shared Font hackYuri Kunde Schlesner2-2/+27
Should fix invalid read loops in some games
2015-08-16Kernel: Remove unused legacy heap MapBlock_* functionsYuri Kunde Schlesner2-77/+0
2015-08-16Kernel: Implement svcGetProcessInfo in a basic wayYuri Kunde Schlesner3-1/+15
This also adds some basic memory usage accounting. These two types are used by Super Smash Bros. during startup.
2015-08-16Kernel: Add more infrastructure to support different memory layoutsYuri Kunde Schlesner5-20/+138
This adds some structures necessary to support multiple memory regions in the future. It also adds support for different system memory types and the new linear heap mapping at 0x30000000.
2015-08-16Move core/mem_map.{cpp,h} => core/hle/kernel/memory.{cpp,h}Yuri Kunde Schlesner3-1/+160
2015-08-16Memory: Move address type conversion routines to memory.cpp/hYuri Kunde Schlesner1-1/+0
These helpers aren't really part of the kernel, and mem_map.cpp/h is going to be moved there next.
2015-08-16Process: Store kernel compatibility version during loadingYuri Kunde Schlesner2-3/+7
2015-08-16Kernel: Properly implement ControlMemory FREE and COMMITYuri Kunde Schlesner4-23/+243
2015-08-16VMManager: Introduce names for used ResultCodesYuri Kunde Schlesner2-6/+11
2015-08-16VMManager: Make LogLayout log level configurable as a parameterYuri Kunde Schlesner3-5/+15
2015-08-16VMManager: Change block offsets to size_tYuri Kunde Schlesner2-3/+3
2015-07-26dyncom: Rename armdefs.h to armstate.hLioncash1-1/+1
2015-07-21Kernel/Scheduling: Clean up a thread's wait_objects when its scheduled.Subv1-0/+8
They'll be reset if needed during the next svcWaitSynchronization call (if there's any pending)
2015-07-17Ensure all kernel objects are released during shutdownYuri Kunde Schlesner1-7/+14
This commit fixes several kernel object leaks. The most severe of them was threads not being removed from the private handle table used for CoreTiming events. This resulted in Threads never being released, which in turn held references to Process, causing CodeSets to never be freed when loading other applications.
2015-07-12Kernel: Add CodeSet case to Object::IsWaitableYuri Kunde Schlesner1-0/+1
2015-07-12Core: Fix applet includes using iwyu.Emmanuel Gil Peyrot2-0/+4
2015-07-12Core: Properly configure address space when loading a binaryYuri Kunde Schlesner5-14/+88
The code now properly configures the process image to match the loaded binary segments (code, rodata, data) instead of just blindly allocating a large chunk of dummy memory.
2015-07-12Kernel: Remove unused member from EventYuri Kunde Schlesner2-2/+1
2015-06-28Core: Cleanup file_sys includes.Emmanuel Gil Peyrot1-1/+2
2015-06-28Core: Cleanup core includes.Emmanuel Gil Peyrot2-1/+2
2015-06-28Common: Cleanup key_map includes.Emmanuel Gil Peyrot4-6/+10
2015-06-23Add helpers to create IPC command buffer headers and descriptorsYuri Kunde Schlesner1-0/+34
2015-06-17kernel: Fix svcWaitSynch to always acquire requested wait objects.bunnei7-101/+37
2015-05-29Remove every trailing whitespace from the project (but externals).Emmanuel Gil Peyrot5-11/+11
2015-05-27Kernel: Add VMManager to manage process address spacesYuri Kunde Schlesner2-0/+445
This enables more dynamic management of the process address space, compared to just directly configuring the page table for major areas. This will serve as the foundation upon which the rest of the Kernel memory management functions will be built.
2015-05-21Kernel: Fix a warning introduced with ResourceLimit, and remove the fallback code to prevent it from happening again.Emmanuel Gil Peyrot1-2/+1
2015-05-21Kernel: Move reschedules from SVCs to actual mechanisms that reschedule.bunnei6-0/+20
2015-05-15Core/ResourceLimits: Implemented the basic structure of ResourceLimits.Subv6-1/+286
Implemented svcs GetResourceLimit, GetResourceLimitCurrentValues and GetResourceLimitLimitValues. Note that the resource limits do not currently keep track of used objects, since we have no way to distinguish between an object created by the application, and an object created by some HLE module once we're inside Kernel::T::Create.
2015-05-15Memmap: Re-organize memory function in two filesYuri Kunde Schlesner6-6/+5
memory.cpp/h contains definitions related to acessing memory and configuring the address space mem_map.cpp/h contains higher-level definitions related to configuring the address space accoording to the kernel and allocating memory.
2015-05-14process: Get rid of warningsLioncash1-3/+3
Sign mismatches and "forcing value to bool" warnings.
2015-05-14thread: Fix a conditional check in RescheduleLioncash1-1/+1
2015-05-12Thread: Remove the idle threadYuri Kunde Schlesner2-44/+19
Instead just use nullptr to represent no thread is active.
2015-05-12Core/Memory: Add TLS support for creating up to 300 threadsSubv3-7/+19
2015-05-12Core/Scheduling: Prepare the new priority in the thread queue when svcSetPriority is calledSubv1-0/+2
2015-05-12fixup!Subv2-7/+3
2015-05-11Core/HLE: Implemented the SVCs GetProcessId and GetProcessIdOfThreadSubv5-2/+19
2015-05-11Thread: Correctly set main thread initial stack positionYuri Kunde Schlesner3-5/+4
2015-05-11fixup! Set the TLS address in the schedulerSubv2-2/+7
2015-05-11Core/Memory: Give every emulated thread it's own TLS area.Subv3-4/+22
The TLS area for thread T with id Ti is located at TLS_AREA_VADDR + (Ti - 1) * 0x200. This allows some games like Mario Kart 7 to continue further.
2015-05-11Kernel: Zero-fill shared memory blocks when mappingYuri Kunde Schlesner1-0/+8
This works around crashes related to GSP/HID/etc. shared memory blocks having garbage values. The proper fix requires proper management of mapped memory blocks in the process.
2015-05-11Kernel: Capture SharedMemory attributes at creation, not when mappingYuri Kunde Schlesner2-16/+29
2015-05-09Common: Remove the BIT macroYuri Kunde Schlesner1-2/+2
When the macro was introduced in 326ec51261299e48de97592631c02523da9c8118 it wasn't noticed that it conflicted in name with a heavily used macro inside of dyncom. This causes some compiler warnings. Since it's only lightly used, it was opted to simply remove the new macro.
2015-05-09Memory: Re-organize and rename memory area address constantsYuri Kunde Schlesner2-3/+4
2015-05-09Kernel: Remove unused g_main_thread variableYuri Kunde Schlesner3-5/+1
2015-05-09Process: Rename StaticAddressMapping => AddressMappingYuri Kunde Schlesner2-5/+5
2015-05-09Process: Add more documentation to the class membersYuri Kunde Schlesner1-2/+16
2015-05-09Process: Use BitField to store process flagsYuri Kunde Schlesner2-16/+24
2015-05-09Process: Support parsing of exheader kernel capsYuri Kunde Schlesner2-4/+72
2015-05-09Kernel: Remove g_program_idYuri Kunde Schlesner2-8/+0
This has been obsoleted by the field in Process.
2015-05-09Kernel: Introduce skeleton Process class to hold process dataYuri Kunde Schlesner4-19/+101
2015-05-07Common: Remove common.hYuri Kunde Schlesner9-8/+14
2015-05-07Move typedefs from kernel.h to more appropriate placesYuri Kunde Schlesner1-10/+1
2015-05-02Kernel: Properly initialize and shutdown all modules.bunnei4-9/+20
2015-04-14Kernel: Use the correct format string for u64 hex.Emmanuel Gil Peyrot1-1/+1
2015-04-10SVC: Update various SVCs to cause a reschedule.bunnei1-4/+0
- CreateMutex/ReleaseMutex/ReleaseSemaphore/SetTimer/CancelTimer/ArbitrateAddress
2015-04-10Kernel: Implemented priority inheritance for mutexes.bunnei3-4/+22
2015-04-10Thread: Implement priority boost for starved threads.bunnei2-22/+51
SVC: Return correct error code on invalid CreateThread processor ID. SVC: Assert when creating a thread with an invalid userland priority.
2015-04-10Kernel: Fixed default thread priority.bunnei2-5/+4
2015-04-09Initialize base address to 0x0Gareth Higgins1-0/+1
2015-02-20Misc cleanup of common and related functionsarchshift1-2/+3
2015-02-12Build: Fixed some warningsSubv3-4/+4
2015-02-11Asserts: break/crash program, fit to style guide; log.h->assert.harchshift7-15/+13
Involves making asserts use printf instead of the log functions (log functions are asynchronous and, as such, the log won't be printed in time) As such, the log type argument was removed (printf obviously can't use it, and it's made obsolete by the file and line printing) Also removed some GEKKO cruft.
2015-02-10Scheduler refactor Pt. 1Kevin Hartman3-223/+258
* Simplifies scheduling logic, specifically regarding thread status. It should be much clearer which statuses are valid for a thread at any given point in the system. * Removes dead code from thread.cpp. * Moves the implementation of resetting a ThreadContext to the corresponding core's implementation. Other changes: * Fixed comments in arm interfaces. * Updated comments in thread.cpp * Removed confusing, useless, functions like MakeReady() and ChangeStatus() from thread.cpp. * Removed stack_size from Thread. In the CTR kernel, the thread's stack would be allocated before thread creation.
2015-02-10Mutex: Locks should be recursive.bunnei2-16/+20
2015-02-03core: Fix some warnings on OSXLioncash1-1/+0
2015-02-02Kernel: Stop creating useless Handles during object creationYuri Kunde Schlesner12-36/+17
They're finally unnecessary, and will stop cluttering the application's handle table.
2015-02-02Kernel: Make WaitObjects share ownership of Threads waiting on themYuri Kunde Schlesner6-12/+17
During normal operation, a thread waiting on an WaitObject and the object hold mutual references to each other for the duration of the wait. If a process is forcefully terminated (The CTR kernel has a SVC to do this, TerminateProcess, though no equivalent exists for threads.) its threads would also be stopped and destroyed, leaving dangling pointers in the WaitObjects. The solution is to simply have the Thread remove itself from WaitObjects when it is stopped. The vector of Threads in WaitObject has also been changed to hold SharedPtrs, just in case. (Better to have a reference cycle than a crash.)
2015-02-02Explicitly instantiate constructors/destructors for Kernel objectsYuri Kunde Schlesner16-8/+50
This should speed up compile times a bit, as well as enable more liberal use of forward declarations. (Due to SharedPtr not trying to emit the destructor anymore.)
2015-02-02Mutex: Replace g_mutex_held_locks with a set inside ThreadYuri Kunde Schlesner3-23/+18
2015-02-02Kernel: Fix bug in HandleTable::CloseYuri Kunde Schlesner1-1/+1
2015-02-02Kernel: Remove Object::GetHandle (it's not used anymore :D)Yuri Kunde Schlesner2-9/+1
2015-02-02Kernel: Introduce unique Object ids for debuggingYuri Kunde Schlesner4-8/+16
2015-02-02Kernel: Use separate Handle tables for CoreTiming userdataYuri Kunde Schlesner4-18/+25
This is to support the removal of GetHandle soon
2015-02-02Kernel: Remove previous scheduled event when a Timer is re-SetYuri Kunde Schlesner1-0/+3
2015-02-02Thread: Modernize two functions that slipped through previous rebasesYuri Kunde Schlesner3-15/+13
2015-02-01arm: Clean up ARMul_StateLioncash1-1/+1
Remove unnecessary/unused struct variables.
2015-01-30shared_memory: Fix assignments in SharedMemory::MapLioncash2-4/+4
2015-01-30Kernel: Mark all appropriate kernel objects as "final"Yuri Kunde Schlesner7-8/+7
2015-01-30Remove result.h InvalidHandleYuri Kunde Schlesner1-1/+2
It was only being used in two places, where it was replaced by a local constant.
2015-01-30Kernel: Convert Event to not use HandlesYuri Kunde Schlesner2-83/+51
2015-01-30Kernel: Convert Timer to (mostly) not use HandlesYuri Kunde Schlesner2-104/+72
2015-01-30Kernel: Convert Mutex to not use HandlesYuri Kunde Schlesner2-101/+82
2015-01-30Kernel: Convert AddressArbiter to not use HandlesYuri Kunde Schlesner2-32/+31
2015-01-30Kernel: Convert Semaphore to not use HandlesYuri Kunde Schlesner2-61/+61
2015-01-30Kernel: Convert SharedMemory to not use HandlesYuri Kunde Schlesner2-71/+54
2015-01-30Move VAddr/PAddr typedefs to kernel.hYuri Kunde Schlesner1-0/+5
2015-01-30Kernel: Remove useless/duplicated comments; mark functions staticYuri Kunde Schlesner6-32/+8
2015-01-22Thread: Fix WaitSynchronization1 to not set register 1 on thread wakeup.bunnei2-22/+42
2015-01-22Thread: Use std::find in CheckWait_WaitObject.bunnei1-4/+5
2015-01-22Mutex: Cleanup and remove redundant code.bunnei3-47/+29
2015-01-22Kernel: Renamed some functions for clarity.bunnei7-10/+10
- ReleaseNextThread->WakeupNextThread - ReleaseAllWaitingThreads->WakeupAllWaitingThreads.
2015-01-22Kernel: Changed "ShouldWait" to return bool and "Acquire" to return void.bunnei8-64/+39
2015-01-22WaitObject: Renamed "Wait" to "ShouldWait", made "ShouldWait" and "Acquire" pure virtual.bunnei8-21/+20
2015-01-22Event: Fix implementation of "non-sticky" events.bunnei1-0/+4
2015-01-22Session: Change to a WaitObject.bunnei3-2/+9
2015-01-22Kernel: Reschedule on SignalEvent and SendSyncRequest, fix some bugs.bunnei1-1/+1
2015-01-22Mutex: Fix a bug where the thread should not wait if it already has the mutex.bunnei1-1/+4
2015-01-22Kernel: Moved Wait and Acquire to WaitObject, added way to retrieve a WaitObject safely.bunnei3-18/+57
2015-01-22AddressArbiter: Changed to Kernel::Object, big cleanup, removed code that made no sense.bunnei4-35/+42
2015-01-22Kernel: Get rid of WaitTypes and simplify lots of code, removing hacks.bunnei8-112/+43
2015-01-22WaitSynchronizationN: Refactor to fix several bugsbunnei7-54/+49
- Separate wait checking from waiting the current thread - Resume thread when wait_all=true only if all objects are available at once - Set output to correct wait object index when there are duplicate handles
2015-01-22Kernel: Separate WaitSynchronization into Wait and Acquire methods.bunnei7-14/+54
2015-01-22WaitSynchronizationN: Implement return valuesbunnei9-56/+139
2015-01-22Event: Fixed some bugs and cleanup (Subv)bunnei2-54/+13
2015-01-22Thread: Keep track of multiple wait objects.bunnei3-16/+30
2015-01-22Event: Get rid of permanent_lock hack.bunnei2-36/+8
2015-01-22WaitObject: Added RemoveWaitingThread, fixed a bug, and cleanup.bunnei2-4/+17
2015-01-22Kernel: Added WaitObject and changed "waitable" objects inherit from it.bunnei8-71/+73
2015-01-20core: Fix a few docstringsLioncash2-2/+2
2015-01-13AddrArbiter: Implement arbitration types 3 and 4.Subv2-3/+20
2015-01-11Thread: Prevent waking a thread multiple times.Subv1-0/+3
If a thread was woken up by something, cancel the wakeup timeout.
2015-01-09Kernel: Start using boost::intrusive_ptr for lifetime managementYuri Kunde Schlesner10-76/+75
2015-01-09Kernel: Don't re-assign object's handle when duplicating oneYuri Kunde Schlesner2-2/+3
2015-01-09Thread: Fix nullptr access in a logging functionYuri Kunde Schlesner1-1/+2
2015-01-09Thread: Rename thread_queue => thread_listYuri Kunde Schlesner1-6/+6
2015-01-09Thread: Reduce use of Handles and move some funcs to inside the class.Yuri Kunde Schlesner9-281/+190
2015-01-09Kernel: Move Thread's definition to the header fileYuri Kunde Schlesner3-53/+67
2015-01-09Move ThreadContext to core/core.h and deal with the falloutYuri Kunde Schlesner2-4/+6
2015-01-09SVC: Implemented the Timer service calls.Subv5-1/+194
2015-01-09SVC: Fixed SleepThread.Subv2-8/+39
It will now properly wait the specified number of nanoseconds and then wake up the thread.
2015-01-08Threads: Use a dummy idle thread when no other are ready.Subv3-1/+35
This thread will not actually execute instructions, it will only advance the timing/events and try to yield immediately to the next ready thread, if there aren't any ready threads then it will be rescheduled and start its job again.
2015-01-07Common: Clean up ThreadQueueListYuri Kunde Schlesner1-1/+1
Replace all the C-style complicated buffer management with a std::deque. In addition to making the code easier to understand it also adds support for non-POD IdTypes. Also clean the rest of the code to follow our code style.
2015-01-04Mutex: Add the calling thread to the waiting list when neededSubv1-2/+2
This will happen when the mutex is already owned by another thread. Should fix some issues with games being stuck due to waiting threads not being awoken.
2015-01-03AddressArbiter: Ported arbitration type 2 from 3dmoo.Subv1-0/+11
(Thanks 3dmoo!)
2014-12-28Kernel: New handle managerYuri Kunde Schlesner9-142/+189
This handle manager more closely mirrors the behaviour of the CTR-OS one. In addition object ref-counts and support for DuplicateHandle have been added. Note that support for DuplicateHandle is still experimental, since parts of the kernel still use Handles internally, which will likely cause troubles if two different handles to the same object are used to e.g. wait on a synchronization primitive.
2014-12-28Kernel: Replace GetStaticHandleType by HANDLE_TYPE constantsYuri Kunde Schlesner8-15/+15
2014-12-28Rename ObjectPool to HandleTableYuri Kunde Schlesner8-41/+41
2014-12-21License changepurpasmart9615-16/+16
2014-12-21Thread: Wait current thread on svc_SleepThreadbunnei2-21/+33
- Removed unused VBLANK sleep mode - Added error log for bad context switch - Renamed VerifyWait to CheckWaitType to be more clear
2014-12-20Clean up some warningsChin2-5/+5
2014-12-20Kernel: Implement support for current thread pseudo-handleYuri Kunde Schlesner3-2/+16
This boots a few (mostly Nintendo 1st party) games further.
2014-12-18Filesystem/Archives: Implemented the SaveData archiveSubv2-0/+7
The savedata for each game is stored in /savedata/<ProgramID> for NCCH files. ELF files and 3DSX files use the folder 0 because they have no ID information Got rid of the code duplication in File and Directory Files that deal with the host machine's file system now live in DiskFile, similarly for directories and DiskDirectory and archives with DiskArchive. FS_U: Use the correct error code when a file wasn't found
2014-12-16HLE: Rename namespaces to match move & fix initialization orderYuri Kunde Schlesner1-5/+0
2014-12-16HLE: Move kernel/archive.* to service/fs/Yuri Kunde Schlesner3-534/+1
2014-12-15Remove SyncRequest from K::Object and create a new K::Session typeYuri Kunde Schlesner3-38/+75
This is a first step at fixing the conceptual insanity that is our handling of service and IPC calls. For now, interfaces still directly derived from Session because we don't have the infrastructure to do it properly. (That is, Processes and scheduling them.)
2014-12-13Kernel/Semaphore: Small style changeSubv1-1/+1
2014-12-13Kernel/Semaphores: Invert the available count checking.Subv1-11/+9
Same semantics, idea by @yuriks
2014-12-13Kernel/Semaphores: Addressed some issues.Subv2-32/+18
2014-12-13Semaphore: Removed an unneeded functionSubv1-5/+0
2014-12-13Semaphores: Addressed some style issuesSubv1-6/+5
2014-12-13Semaphore: Implemented the initial_count parameter.Subv2-5/+7
2014-12-13SVC: Implemented ReleaseSemaphore.Subv2-16/+64
This behavior was tested on hardware, however i'm still not sure what use the "initial_count" parameter has
2014-12-13SVC: Implemented svcCreateSemaphoreSubv2-0/+98
ToDo: Implement svcReleaseSemaphore * Some testing against hardware needed
2014-12-13kernel: Remove unused log argumentsLioncash1-3/+3
2014-12-13Convert old logging calls to new logging macrosYuri Kunde Schlesner6-72/+45
2014-12-09Thread: Fixed to wait on address when in arbitration.bunnei3-11/+31
2014-12-07Make OpenDirectory fail if the directory doesn't existarchshift1-0/+5
This is in line with what the hardware itself does. It does this by splitting the initial directory opening into Directory.Open(), which will return false if a stat fails. Then, Archive::OpenDirectory will return nullptr, and archive.cpp will return an error code .
2014-12-07Mutex: Remove some forward declarationsSubv1-16/+15
Moved Mutex::WaitSynchronization to the end of the file.
2014-12-07Mutex: Release all held mutexes when a thread exits.Subv3-22/+56
2014-12-06Mutex: Properly lock the mutex when a thread enters itSubv1-12/+9
Also resume only the next immediate thread waiting for the mutex when it is released, instead of resuming them all.
2014-12-04Threads: Remove a redundant function.Subv1-9/+1
Use the next_thread_id variable directly.
2014-12-04Threads: Implemented a sequential thread idSubv2-4/+19
2014-12-04Updated archive.cpp functions for proper error handlingarchshift2-65/+36
2014-12-04SVC: Implemented GetThreadId.Subv2-0/+19
For now threads are using their Handle value as their Id, it should not really cause any problems because Handle values are unique in Citra, but it should be changed. I left a ToDo there because this is not correct behavior as per hardware.
2014-12-04kernel: Shorten GetCountLioncash1-6/+3
2014-12-04kernel: Make some functions constLioncash2-4/+4
2014-11-26Thread: Check that thread is actually in "wait state" when verifying wait.bunnei1-1/+1
2014-11-26Mutex: Changed behavior to always release mutex for all threads.bunnei1-8/+7
2014-11-25Implemented RenameDirectory in FS:USERarchshift2-0/+35
2014-11-25Implemented RenameFile in FS:USERarchshift2-0/+35
2014-11-24Use pointers instead of passing handles around in some functions.Yuri Kunde Schlesner1-19/+15
2014-11-24Remove duplicated docs/update them for changed parameters.Yuri Kunde Schlesner9-78/+0
2014-11-24HLE: Revamp error handling throrough the HLE codeYuri Kunde Schlesner13-201/+187
All service calls in the CTR OS return result codes indicating the success or failure of the call. Previous to this commit, Citra's HLE emulation of services and the kernel universally either ignored errors or returned dummy -1 error codes. This commit makes an initial effort to provide an infrastructure for error reporting and propagation which can be use going forward to make HLE calls accurately return errors as the original system. A few parts of the code have been updated to use the new system where applicable. One part of this effort is the definition of the `ResultCode` type, which provides facilities for constructing and parsing error codes in the structured format used by the CTR. The `ResultVal` type builds on `ResultCode` by providing a container for values returned by function that can report errors. It enforces that correct error checking will be done on function returns by preventing the use of the return value if the function returned an error code. Currently this change is mostly internal since errors are still suppressed on the ARM<->HLE border, as a temporary compatibility hack. As functionality is implemented and tested this hack can be eventually removed.
2014-11-23Added DeleteFile and DeleteDirectory functions to FS:USER and the archives.archshift2-1/+47
2014-11-19Remove trailing spaces in every file but the ones imported from SkyEye, AOSP or generatedEmmanuel Gil Peyrot12-42/+42
2014-11-19Add static to some variablesLioncash1-22/+22
2014-11-19Kernel:Add missing permissions in shared memory & svcpurpasmart961-5/+9
2014-11-18Remove extraneous semicolonsLioncash1-1/+1
2014-11-18Archive: Fixed to not destroy archive handle on close.bunnei1-3/+3
2014-11-18Archive: Fixed close archive before freeing.bunnei1-1/+1
2014-11-18FS_User: Support FileSye::Path in a more generic way.bunnei1-0/+11
added a todo to kernel archive
2014-11-18FileSys: Updated backend code to use FileSys::Path instead of string for paths.bunnei2-10/+10
2014-11-14Fix two format strings.Lioncash1-1/+1
2014-11-02Added CreateDirectory function to service/fs.cpp, and in Archive.archshift2-2/+25
2014-10-30Fix some warningsSean1-3/+3
2014-10-26Add `override` keyword through the code.Yuri Kunde Schlesner6-35/+35
This was automated using `clang-modernize`.
2014-10-06FileSys: split the constructor into an Open method, in order to notify the opener something went wrong.Emmanuel Gil Peyrot1-0/+3
Kernel: Return an invalid handle to OpenFile when it failed to open.
2014-10-06FileSys/Kernel: Implement SetSize service call for File objects.Emmanuel Gil Peyrot1-0/+8
2014-09-21Use the citra user path for the sdmc directoryarchshift1-2/+1
2014-09-17Kernel: Implement the Close command for Archive, File and Directory.Emmanuel Gil Peyrot2-0/+43
2014-09-17Kernel: Add a Directory object and a getter for it from an Archive object.Emmanuel Gil Peyrot3-0/+91
2014-09-17Kernel: Add a File object and a getter for it from an Archive object.Emmanuel Gil Peyrot2-0/+118
2014-09-15Core: Get rid of unnecessary switch statement in KernelLioncash1-41/+2
2014-09-09core: Prune redundant includesarchshift3-6/+0
2014-08-31Threading: Fix thread starting to execute first instruction correctly.bunnei1-0/+5
2014-08-28Threading: Fix thread starting to execute first instruction correctly.bunnei1-0/+5
2014-08-23Added FS functions to Archive and Archive_RomFSarchshift1-3/+31
2014-08-19Core: Use std::array for managing kernel object spaceLioncash2-5/+5
These avoid relying on memset for clearing the arrays.
2014-08-18Core: Alter the kernel string functions to use std::string instead of const char*.Lioncash8-25/+22
Most functions already operate on std::strings. This also removes the need to manually null terminate thread names.
2014-08-07Thread: Added more descriptive comment to WaitCurrentThread.bunnei2-2/+10
2014-08-06AddressArbiter: Removed unnecessary HLE::Reschedule.bunnei1-1/+0
2014-08-06AddressArbiter: Fixed bug with break statements missing from case statements.bunnei1-0/+2
2014-08-06Kernel: Updated Event and Mutex to specify handle that they are blocking for.bunnei2-2/+2
2014-07-09Kernel: Added preliminary support for address arbiters.bunnei3-1/+124
AddressArbiter: Added documentation comment, fixed whitespace issue. AddressArbiter: Fixed incorrect comment, reordered if-statement to be more clear. SVC: Removed trailing whitespace.
2014-07-09Thread: Added functions to resume threads from address arbitration.bunnei2-0/+44
Thread: Cleaned up arbitrate address functions. Thread: Cleaned up ArbitrateAllThreads function.
2014-07-05SharedMemory: Updated MapSharedMemory to use an enum for permissions.bunnei2-6/+27
- Also added some safety checks to MapSharedMemory.
2014-07-05Kernel: Added support for shared memory objects.bunnei2-0/+132
SharedMemory: Added optional name field for tracking known objects.
2014-07-05Archive: Added Init/Shutdown methods to reset kernel archive state.bunnei3-0/+19
2014-07-05FileSys: Added preliminary support for applications reading the RomFS archive.bunnei2-10/+105
Archive: Fixed brace ugliness for neobrain :) FS: Commented out unused local variables to prevent warnings. ...But keeping them here for future use. archive_romfs: Removed unused #include.
2014-06-27Kernel: Added stubbed code to support creation of kernel Archive objects.bunnei3-0/+85
2014-06-13Kernel: Removed unnecessary "#pragma once".bunnei1-2/+0
2014-06-13Kernel: Added freeing of kernel objects on emulator shutdown.bunnei2-0/+10
2014-06-13Event: Updated several log messages to be assertions.bunnei1-16/+8
2014-06-13Thread: Renamed occurrences of "t" to "thread" to improve readability.bunnei1-48/+45
2014-06-13Thread: Cleaned up VerifyWait, fixed issue where nullptr msg could unnecessarily be logged.bunnei1-9/+7
2014-06-13HLE: Removed usnused EatCycles function.bunnei1-9/+0
2014-06-13Thread: Moved position of * in arguments.bunnei1-2/+2
2014-06-13Thread: Updated VerifyWait to be more readable (but functionally the same).bunnei1-4/+3
2014-06-13HLE: Updated all uses of NULL to nullptr (to be C++11 compliant)bunnei3-9/+9
2014-06-13Kernel: Updated various kernel function "name" arguments to be const references.bunnei4-6/+6
2014-06-13HLE: Updated various handle debug assertions to be more clear.bunnei2-3/+3
2014-06-13Mutex: Moved ReleaseMutex iterator declaration to be inside while loop.bunnei1-2/+1
2014-06-13Kernel: Updated several member functions to be constbunnei4-11/+11
2014-06-13Thread: Fixed bug with ResetThread where cpu_registers[15] was being incorrectly setbunnei1-1/+1
2014-06-13Kernel: Made SyncRequest not pure virtual, with a default implementation of error (as this is not required for all kernel objects)bunnei3-23/+4
2014-06-13Kernel: Added real support for thread and event blockingbunnei5-48/+165
- SVC: Added ExitThread support - SVC: Added SignalEvent support - Thread: Added WAITTYPE_EVENT for waiting threads for event signals - Thread: Added support for blocking on other threads to finish (e.g. Thread::Join) - Thread: Added debug function for printing current threads ready for execution - Thread: Removed hack/broken thread ready state code from Kernel::Reschedule - Mutex: Moved WaitCurrentThread from SVC to Mutex::WaitSynchronization - Event: Added support for blocking threads on event signalling Kernel: Added missing algorithm #include for use of std::find on non-Windows platforms.
2014-06-05kernel: changed current default thread priority back to 0x30 - I think this is more correctbunnei1-1/+1
2014-06-03svc: added optional name field to Event and Mutex (used for debugging)bunnei4-8/+21
2014-06-03kernel: moved position of * for GetTypeName and GetNamebunnei1-2/+2
2014-06-02svc: added GetThreadPriority and SetThreadPriority, added (incomplete) DuplicateHandle supportbunnei2-0/+51
2014-06-02kernel: changed main thread priority to default, updated Kernel::Reschedule to use PrepareReschedulebunnei3-4/+6
2014-06-01thread: updated Reschedule to sit at a synchronization barrier when no other threads are ready for executionbunnei1-0/+18
2014-06-01event: added a hackish ability to set an event as "locked" to its current state, cleaned up some commentsbunnei2-4/+32
2014-05-30mutex: fixed typo in ReleaseMutexbunnei1-1/+3
2014-05-30event: added support for ClearEvent, fixed a bug with CreateEvent, fixed some commentsbunnei2-9/+14
2014-05-28mutex: added preliminary SyncRequest/WaitSynchronization, added some comments/assertionsbunnei1-0/+6
2014-05-28event: fixed typos and updated CMakeListsbunnei1-1/+1
2014-05-28event: added SetEventLocked method to change status an events lockbunnei2-0/+18
2014-05-28kernel: added event module to support creation of CTR "Event" objectsbunnei2-0/+119
2014-05-27mutex: removed docstring comment that is no longer relevantbunnei1-1/+0
2014-05-27mutex: added additional docstringsbunnei1-0/+2
2014-05-27kernel: added WaitSynchronization method to Kernel::Objectbunnei3-0/+29
2014-05-27kernel: updated SyncRequest to take boolean thread wait result as a parameterbunnei3-5/+20
2014-05-27kernel: added enum for known CurrentThread and CurrentProcess handlesbunnei1-0/+5
2014-05-27kernel: add a SyncRequest method to KernelObject for use with svcSendSyncRequestbunnei3-0/+11
2014-05-23thread: renamed "WaitCurThread" to "WaitCurrentThread", removed unused "reason" argumentbunnei2-4/+4
2014-05-23thread: removed unused SwitchContext/Reschedule reason field, added missing arg parameter to SVC CreateThreadbunnei2-4/+4
2014-05-23kernel: refactored function naming to remove "__" prefixbunnei5-62/+72
2014-05-23thread: moved ThreadStatus/WaitType to header, added support for arg on CreateThread, added correct CPSR resetbunnei2-35/+40
2014-05-22thread: fixed bug where result of __NextThread was not being properly checked when NULLbunnei1-1/+1
2014-05-21mutex: refactored the interface to code to return a Mutex* handlebunnei2-3/+13
2014-05-21mutex: initial commit of HLE modulebunnei2-0/+148
2014-05-21kernel: fixed include, in general include "common.h" not "common_types.h"bunnei1-1/+1
2014-05-21thread: added correct lowest thread priority, added a thread priority check, and added some commentsbunnei2-6/+10
2014-05-21thread: exposed ResumeThreadFromWait function for use in other kernel modulesbunnei2-8/+11
2014-05-21thread: moved threading calls to the Kernel namespacebunnei3-101/+115
2014-05-21ARM_Interface: added SaveContext and LoadContext functions for HLE thread switchingbunnei1-36/+2
2014-05-21renamed "syscall" module to "svc" (more accurate naming)bunnei1-1/+1
2014-05-21thread: whitespace change - fixed * and & placementbunnei2-27/+27
2014-05-21- created a Kernel namespacebunnei4-67/+79
- cleaned up Kernel code a bit (moved stuff into namespace, fixed whitespace issues) - added handle types for all different CTROS handles
2014-05-20thread: added declaration for __KernelReschedule to be used by syscall modulebunnei1-0/+3
2014-05-19- updated service(s) to be KernelObject'sbunnei1-4/+5
- various cleanups
2014-05-19- moved Handle/Result definitions to kernel.hbunnei2-3/+2
- added ResetType enum
2014-05-17changed a commentbunnei2-2/+2
2014-05-17- added enum ThreadProcessorIdbunnei2-53/+107
- reorganized some kernel thread functions - added placeholder __KernelWaitThread_Synchronization function
2014-05-17- replaced KERNELOBJECT_MAX_NAME_LENGTH with KERNEL_MAX_NAME_LENGTHbunnei3-8/+12
- added KERNEL_DEFAULT_STACK_SIZE definition (0x4000)
2014-05-16completely gutted/refactored threading code to be simplerbunnei2-658/+230
2014-05-16changed "UID" to "Handle" to be a little more consistent with CTR namingbunnei2-18/+21
2014-05-15- added helper function for __KernelCreateThreadbunnei2-4/+76
- added __KernelSwitchToThread for enabling a thread - added __KernelRotateThreadReadyQueue
2014-05-15changed primary thread priority to 0x30 - this is typical, not 0x31bunnei1-1/+2
2014-05-14fixed thread reset to not set stack addressbunnei1-1/+1
2014-05-14various cleanups / remove unused codebunnei2-65/+29
2014-05-14added a bunch of threading code, recycled from PPSSPP, with lots of hacks in for 3DS... doesn't really do much yet. Just a jumping off pointbunnei2-70/+543
2014-05-14- added __KernelLoadExec functionbunnei2-13/+35
- fixed some logging
2014-05-10added initial kernel/thread modulesbunnei4-0/+527
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 07:53:41 +0200