| Commit message (Collapse) | Author | Files | Lines |
|
Brings us closer to enabling -Wshadow as an error in the core code.
|
|
Makes use of the VirtualDir and VirtualFile aliases across the board
instead of having a few isolated places that don't use it.
|
|
Cleans out the rest of the occurrences of variable shadowing and makes
any further occurrences of shadowing compiler errors.
|
|
We can add a helper function to make creation of these files nicer.
While we're at it, we can eliminate an unnecessary std::array copy in
the constructor. This makes the overhead on some of these functions way
less intensive, given some arrays were quite large.
e.g. The timezone location names are 9633 bytes in size.
|
|
|
|
Allows using constexpr/static const data with VFS.
|
|
When writing VFS, it initally seemed useful to include a function to in-place convert container files into directories in one homogenous directory structure, but re-evaluating it now there have been plenty of chances to use it and there has always been a better way. Removing as it is unused and likely will not be used.
|
|
Given we just recently had a patch backport this from citra, let's try
and keep the convention uniform.
|
|
|
|
Maps a vector into the VFS interface.
|
|
Several classes have a lot of non-trivial members within them, or don't
but likely should have the destructor defaulted in the cpp file for
future-proofing/being more friendly to forward declarations.
Leaving the destructor unspecified allows the compiler to inline the
destruction code all over the place, which is generally undesirable from
a code bloat perspective.
|
|
struct should be used when the data type is very simple or otherwise has
no invariants associated with it. Given these are used to form a
hierarchy, class should be used instead.
|
|
|
|
|