| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |\
| |
| | |
Do not try to pause core timing from the audio thread when using single-core
|
| | | |
|
| |\ \
| | |
| | | |
audio_renderer: Make GetCommandBuffer() take a u32
|
| | |/
| |
| |
| |
| |
| | |
This function is only ever called with unsigned types, and all of the
other interface functions take session_id as a u32, so this makes the
class a little more consistent.
|
| | |
| |
| |
| | |
Moves the include into the cpp file to lessen header dependencies.
|
| | |
| |
| |
| | |
We can just use a local here to get rid of a second cast.
|
| | |
| |
| |
| |
| | |
Prevents unnecessary reallocations in the event the captured variables
are larger than the internal std::function buffer.
|
| | |
| |
| |
| |
| | |
Allows us to get rid of some unnecessary forward declarations and
includes.
|
| | |
| |
| |
| | |
This isn't used, so it can be removed.
|
| |/
|
|
| |
This isn't used by the class, so this can be removed for the time being.
|
| |\
| |
| | |
audio_core: Mark several member functions as const
|
| | |
| |
| |
| | |
This is just being copied and isn't modified at all.
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
These two don't modify member state.
|
| | |
| |
| |
| |
| |
| |
| | |
This doesn't modify member state.
We can also mark the parameter of AppendError as const as well, since it
isn't modified.
|
| | |
| |
| |
| | |
This doesn't modify instance state.
|
| | | |
|
| | |
| |
| |
| | |
These functions don't modify class state, so we can mark them as such
|
| | |
| |
| |
| | |
These don't affect class state, so we can mark them as such.
|
| | |
| |
| |
| |
| | |
This function doesn't modify the passed in buffer, so we can make that
explicit.
|
| | |
| |
| |
| | |
Simplifies the indexing code a little bit.
|
| | |
| |
| |
| |
| | |
These functions don't modify the passed in audio buffers, so we can
signify that in the interface.
|
| |\ \
| |/
|/| |
audio_device: Make AudioDeviceName constructor constexpr
|
| | |
| |
| |
| | |
These member functions don't modify any internal state.
|
| | |
| |
| |
| |
| |
| |
| |
| | |
These are used as read-only arrays, so we can make the data read-only
and available at compile-time.
Now constructing an AudioDevice no longer needs to initialize some
tables
|
| |\ \
| | |
| | | |
Remove pause callbacks from coretiming
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
audio_core: Amend documentation comment tags
|
| | | |/
| |/|
| | |
| | |
| | | |
Resolves a wackload of -Wdocumentation warnings due to mismatching tags
and whatnot.
|
| | | |
| | |
| | |
| | | |
Provides equivalent behavior while being significantly smaller.
|
| | | |
| | |
| | |
| | | |
These functions don't modify the parameters.
|
| |/ /
| |
| |
| |
| | |
Same behavior, but also silences a -Wcast-qual warning, since the second
cast casts away const.
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[REUSE] is a specification that aims at making file copyright
information consistent, so that it can be both human and machine
readable. It basically requires that all files have a header containing
copyright and licensing information. When this isn't possible, like
when dealing with binary assets, generated files or embedded third-party
dependencies, it is permitted to insert copyright information in the
`.reuse/dep5` file.
Oh, and it also requires that all the licenses used in the project are
present in the `LICENSES` folder, that's why the diff is so huge.
This can be done automatically with `reuse download --all`.
The `reuse` tool also contains a handy subcommand that analyzes the
project and tells whether or not the project is (still) compliant,
`reuse lint`.
Following REUSE has a few advantages over the current approach:
- Copyright information is easy to access for users / downstream
- Files like `dist/license.md` do not need to exist anymore, as
`.reuse/dep5` is used instead
- `reuse lint` makes it easy to ensure that copyright information of
files like binary assets / images is always accurate and up to date
To add copyright information of files that didn't have it I looked up
who committed what and when, for each file. As yuzu contributors do not
have to sign a CLA or similar I couldn't assume that copyright ownership
was of the "yuzu Emulator Project", so I used the name and/or email of
the commit author instead.
[REUSE]: https://reuse.software
Follow-up to 01cf05bc75b1e47beb08937439f3ed9339e7b254
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
yuzu: Make variable shadowing a compile-time error
|
| | |
| |
| |
| | |
Removing this as we don't enforce unused parameter warnings elsewhere in the project, and explicitly specify -Wno-unused-parameter in the main CMakeLists.
|
| | |
| |
| |
| | |
Now that the entire project is free of variable shadowing, we can enforce this as a compile time error to prevent any further introduction of this logic bug.
|
| |/ |
|
| |
|
|
| |
Using this smaller type saves 1024 bytes in the compiled executable.
|
| |
|
|
|
| |
This formats all copyright comments according to SPDX formatting guidelines.
Additionally, this resolves the remaining GPLv2 only licensed files by relicensing them to GPLv2.0-or-later.
|
| |
|
|
| |
Also drop the SoundTouch dependency
|
| |
|
|
|
|
|
| |
Update CURRENT_PROCESS_REVISION from REV9 to REVA.
Used by Nintendo Entertainment System - Nintendo Switch Online 6.0.0 and
Super Nintendo Entertainment System - Nintendo Switch Online 3.0.0.
|
| | |
|
| | |
|
| |
|
|
| |
This reduces the load of requiring to include std::chrono in all files which include log.h
|
| |\
| |
| | |
audio_core: Replace NaN mix volume samples with silence
|
| | |
| |
| |
| | |
Fixes Xenoblade Chronicles 2 blowing out the audio.
|
| |\ \
| | |
| | | |
general: Move most settings' defaults and labels into their definition
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Creates a new BasicSettings class in common/settings, and forces setting
a default and label for each setting that uses it in common/settings.
Moves defaults and labels from both frontends into common settings.
Creates a helper function in each frontend to facillitate reading the
settings now with the new default and label properties.
Settings::Setting is also now a subclass of Settings::BasicSetting. Also
adds documentation for both Setting and BasicSetting.
|
| |\ \ \
| |_|/
|/| | |
Support more PCM formats
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Many games report 6 channel output while only providing data for 2. We only output 2-channel audio regardless, and in the downmixing, front left/right only provide 36% of their volume. This is done assuming all of the other channels also contain valid data, but in many games they don't. This PR alters the downmixing to preserve front left/right, so volume is not lost.
This improves volume in Link's Awakening, New Super Mario Bros U, Disgaea 6, Super Kirby Clash.
|
| |/ /
| |
| |
| | |
Treats (un)signed comparison mismatches as errors to be consistent with MSVC
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
Currently, processing of audio samples is called from AudioRenderer's Update method, using a fixed 4 buffers to process the given samples. Games call Update at variable rates, depending on framerate and/or sample count, which causes inconsistency in audio processing. From what I've seen, 60 FPS games update every ~0.004s, but 30 FPS/160 sample games update somewhere between 0.02 and 0.04, 5-10x slower. Not enough samples get fed to the backend, leading to a lot of audio skipping.
This PR seeks to address this by de-coupling the audio consumption and the audio update. Update remains the same without calling for buffer queuing, and the consume now schedules itself to run based on the sample rate and count.
|
| |/
|
|
| |
- This is used in fw 12.x.x games.
|
| |
|
|
|
| |
* Add missing includes
* Add array
|
| |
|
|
| |
Used in Ninja Gaiden games.
|
| | |
|
| | |
|
| |
|
|
| |
Transition to PascalCase for result names.
|
| |
|
|
| |
- Removes a dependency on core and input_common from common.
|
| | |
|
| | |
|
| |
|
|
| |
Most notable fix is the voices in Fire Emblem Three Houses
|
| |\
| |
| | |
Prevent over scheduling audio events and add motion update unschedule event
|
| | | |
|
| | |
| |
| |
| | |
As this is causing issues in a few games, it's best to have it disabled until it's completely implemented
|
| | |
| |
| |
| | |
Fixes Devil May Cry
|
| |/
|
|
|
| |
This requires making several types trivial and properly initialize
them whenever they are called.
|
| |
|
|
| |
INSERT_PADDING_BYTES_NOINIT is more descriptive of the underlying behavior.
|
| |\
| |
| | |
Make the coding conventions more consistant
|
| | |
| |
| |
| |
| | |
lut_index had 0 added when nothing was supposed to be added
despite this, index was not added to 0 when nothing was supposed to be added...
|
| | |
| |
| |
| | |
- This makes it such that we can safely access service members from CoreTiming thread.
|
| |/ |
|
| | |
|
| |\
| |
| | |
audio_core: Make shadowing and unused parameters errors
|
| | |
| |
| |
| | |
Moves the audio code closer to enabling warnings as errors in general.
|
| |/
|
|
| |
It's unused and doesn't need to be initialized
|
| | |
|
| |
|
|
|
|
| |
Preliminary work for upmixing & general cleanup. Fixes basic issues in games such as Shovel Knight and slightly improves the LEGO games. Upmixing stitll needs to be implemented.
Audio levels in a few games will be fixed as we now use the downmix coefficients when possible instead of supplying our own
|
| |
|
|
| |
Resolves the clang build issue in a more unintrusive way.
|
| | |
|
| |
|
|
|
|
|
| |
Recent changes to the build system that made more warnings be flagged as
errors caused building via clang to break.
Fixes #4795
|
| |
|
|
| |
Normalizes the warnings shared between audio_core and core.
|
| |\
| |
| | |
codec: Make lookup table static constexpr
|
| | |
| |
| |
| |
| | |
Allows compilers to elide needing to push these values on the stack
every time the function is called.
|
| | |
| |
| |
| |
| | |
Allows compilers to elide needing to push these values on the stack
every time the function is called.
|
| |\ \
| | |
| | | |
cubeb_sink: Use static_cast instead of reinterpret_cast in DataCallback()
|
| | |/
| |
| |
| |
| | |
Conversions from void* to the proper data type are well-defined and
supported by static_cast. We don't need to use reinterpret_cast here.
|
| |\ \
| | |
| | | |
audio_core: Resolve sign conversion warnings
|
| | | |
| | |
| | |
| | |
| | |
| | | |
While were at it, we can also enable sign conversion warnings and other
common warnings as errors to prevent these from creeping back into the
codebase.
|
| | |/
| |
| |
| |
| | |
While we're at it we can make the destructor of the base class virtual
to ensure that any polymorphism issues never occur.
|
| |\ \
| | |
| | | |
audio_core: Remove unnecessary inclusions
|
| | |/
| |
| |
| |
| | |
Same behavior, but removes header dependencies where they don't need to
be.
|
| |/ |
|
| |
|
|
|
|
|
|
| |
In a lot of cases, we can make use of const references rather than
non-const references.
While we're in the area we can silence some truncation and sign
conversion warnings.
|
| | |
|
| |\
| |
| | |
audio_core: Apollo Part 1, AudioRenderer refactor
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| |/
|
|
| |
Makes the interface future-proofed for supporting other platforms in the event we ever support platforms with differing pointer sizes. This way, we have a type in place that is always guaranteed to be able to represent a pointer exactly.
|
| |
|
|
| |
Enforces our desired time units directly with a concrete type.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Switch game settings to use a pointer
In order to add full per-game settings, we need to be able to tell yuzu to switch
to using either the global or game configuration. Using a pointer makes it easier
to switch.
* configuration: add new UI without changing existing funcitonality
The new UI also adds General, System, Graphics, Advanced Graphics,
and Audio tabs, but as yet they do nothing. This commit keeps yuzu
to the same functionality as originally branched.
* configuration: Rename files
These weren't included in the last commit. Now they are.
* configuration: setup global configuration checkbox
Global config checkbox now enables/disables the appropriate tabs in the game
properties dialog. The use global configuration setting is now saved to the
config, defaulting to true. This also addresses some changes requested in the PR.
* configuration: swap to per-game config memory for properties dialog
Does not set memory going in-game. Swaps to game values when opening the
properties dialog, then swaps back when closing it. Uses a `memcpy` to swap.
Also implements saving config files, limited to certain groups of configurations
so as to not risk setting unsafe configurations.
* configuration: change config interfaces to use config-specific pointers
When a game is booted, we need to be able to open the configuration dialogs
without changing the settings pointer in the game's emualtion. A new pointer
specific to just the configuration dialogs can be used to separate changes
to just those config dialogs without affecting the emulation.
* configuration: boot a game using per-game settings
Swaps values where needed to boot a game.
* configuration: user correct config during emulation
Creates a new pointer specifically for modifying the configuration while
emulation is in progress. Both the regular configuration dialog and the game
properties dialog now use the pointer Settings::config_values to focus edits to
the correct struct.
* settings: split Settings::values into two different structs
By splitting the settings into two mutually exclusive structs, it becomes easier,
as a developer, to determine how to use the Settings structs after per-game
configurations is merged. Other benefits include only duplicating the required
settings in memory.
* settings: move use_docked_mode to Controls group
`use_docked_mode` is set in the input settings and cannot be accessed from the
system settings. Grouping it with system settings causes it to be saved with
per-game settings, which may make transferring configs more difficult later on,
especially since docked mode cannot be set from within the game properties
dialog.
* configuration: Fix the other yuzu executables and a regression
In main.cpp, we have to get the title ID before the ROM is loaded, else the
renderer will reflect only the global settings and now the user's game specific
settings.
* settings: use a template to duplicate memory for each setting
Replaces the type of each variable in the Settings::Values struct with a new
class that allows basic data reading and writing. The new struct
Settings::Setting duplicates the data in memory and can manage global overrides
per each setting.
* configuration: correct add-ons config and swap settings when apropriate
Any add-ons interaction happens directly through the global values struct.
Swapping bewteen structs now also includes copying the necessary global configs
that cannot be changed nor saved in per-game settings. General and System config
menus now update based on whether it is viewing the global or per-game settings.
* settings: restore old values struct
No longer needed with the Settings::Setting class template.
* configuration: implement hierarchical game properties dialog
This sets the apropriate global or local data in each setting.
* clang format
* clang format take 2
can the docker container save this?
* address comments and style issues
* config: read and write settings with global awareness
Adds new functions to read and write settings while keeping the global state in
focus. Files now generated per-game are much smaller since often they only need
address the global state.
* settings: restore global state when necessary
Upon closing a game or the game properties dialog, we need to restore all global
settings to the original global state so that we can properly open the
configuration dialog or boot a different game.
* configuration: guard setting values incorrectly
This disables setting values while a game is running if the setting is
overwritten by a per game setting.
* config: don't write local settings in the global config
Simple guards to prevent writing the wrong settings in the wrong files.
* configuration: add comments, assume less, and clang format
No longer assumes that a disabled UI element means the global state is turned
off, instead opting to directly answer that question. Still however assumes a
game is running if it is in that state.
* configuration: fix a logic error
Should not be negated
* restore settings' global state regardless of accept/cancel
Fixes loading a properties dialog and causing the global config dialog to show
local settings.
* fix more logic errors
Fixed the frame limit would set the global setting from the game properties
dialog. Also strengthened the Settings::Setting member variables and simplified
the logic in config reading (ReadSettingGlobal).
* fix another logic error
In my efforts to guard RestoreGlobalState, I accidentally negated the IsPowered
condition.
* configure_audio: set toggle_stretched_audio to tristate
* fixed custom rtc and rng seed overwriting the global value
* clang format
* rebased
* clang format take 4
* address my own review
Basically revert unintended changes
* settings: literal instead of casting
"No need to cast, use 1U instead"
Thanks, Morph!
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
* Revert "settings: literal instead of casting
"
This reverts commit 95e992a87c898f3e882ffdb415bb0ef9f80f613f.
* main: fix status buttons reporting wrong settings after stop emulation
* settings: Log UseDockedMode in the Controls group
This should have happened when use_docked_mode was moved over to the controls group
internally. This just reflects this in the log.
* main: load settings if the file has a title id
In other words, don't exit if the loader has trouble getting a title id.
* use a zero
* settings: initalize resolution factor with constructor instead of casting
* Revert "settings: initalize resolution factor with constructor instead of casting"
This reverts commit 54c35ecb46a29953842614620f9b7de1aa9d5dc8.
* configure_graphics: guard device selector when Vulkan is global
Prevents the user from editing the device selector if Vulkan is the global
renderer backend. Also resets the vulkan_device variable when the users
switches back-and-forth between global and Vulkan.
* address reviewer concerns
Changes function variables to const wherever they don't need to be changed. Sets Settings::Setting to final as it should not be inherited from. Sets ConfigurationShared::use_global_text to static.
Co-Authored-By: VolcaEM <volcaem@users.noreply.github.com>
* main: load per-game settings after LoadROM
This prevents `Restart Emulation` from restoring the global settings *after* the per-game settings were applied. Thanks to BSoDGamingYT for finding this bug.
* Revert "main: load per-game settings after LoadROM"
This reverts commit 9d0d48c52d2dcf3bfb1806cc8fa7d5a271a8a804.
* main: only restore global settings when necessary
Loading the per-game settings cannot happen after the ROM is loaded, so we have to specify when to restore the global state. Again thanks to BSoD for finding the bug.
* configuration_shared: address reviewer concerns except operator overrides
Dropping operator override usage in next commit.
Co-Authored-By: LC <lioncash@users.noreply.github.com>
* settings: Drop operator overrides from Setting template
Requires using GetValue and SetValue explicitly. Also reverts a change that broke title ID formatting in the game properties dialog.
* complete rebase
* configuration_shared: translate "Use global configuration"
Uses ConfigurePerGame to do so, since its usage, at least as of now, corresponds with ConfigurationShared.
* configure_per_game: address reviewer concern
As far as I understand, it prevents the program from unnecessarily copying strings.
Co-Authored-By: LC <lioncash@users.noreply.github.com>
Co-authored-by: Morph <39850852+Morph1984@users.noreply.github.com>
Co-authored-by: VolcaEM <volcaem@users.noreply.github.com>
Co-authored-by: LC <lioncash@users.noreply.github.com>
|
| |
|
|
| |
Timestretcher seems to be broken
|
| |
|
|
| |
Fixes the issue with needing the timestretcher for multicore.
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
Fixes ZLA softlock
|
| | |
|
| | |
|
| |
|
|
| |
Supersedes #3738 and #3321
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
* audio_renderer: Preliminary BehaviorInfo
* clang format
* Fixed IsRevisionSupported
* fixed IsValidRevision
* Fixed logic error & spelling errors & crash
* Addressed issues
|
| |
|
|
| |
- helpful to disambiguate Kernel::Memory namespace.
|
| |
|
|
|
|
| |
According to Ryujinx, REV8 only added changes on Performance buffer and Wavebuffer DSP command generation.
As we don't support any of those, we can just increment the revision number for now.
|
| |
|
|
|
|
|
|
| |
Previously, when performing downmixing, we would discard all channels except the left and right one.
This implementation respects them when mixing down to Stereo.
It is taken from this document: http://www.atsc.org/wp-content/uploads/2015/03/A52-201212-17.pdf.
Fixes Luigis Mansion 3 cutscene and Bayonetta audio.
|
| |
|
|
|
| |
- Fixes audio crackling in Crash Team Racing Nitro-Fueled, Super Mario Odyssey, and others.
- Addresses followup issues from #3310.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
With all of the trivial parts of the memory interface moved over, we can
get right into moving over the bits that are used.
Note that this does require the use of GetInstance from the global
system instance to be used within hle_ipc.cpp and the gdbstub. This is
fine for the time being, as they both already rely on the global system
instance in other functions. These will be removed in a change directed
at both of these respectively.
For now, it's sufficient, as it still accomplishes the goal of
de-globalizing the memory code.
|
| |
|
|
|
|
|
|
|
|
| |
Amends a few interfaces to be able to handle the migration over to the
new Memory class by passing the class by reference as a function
parameter where necessary.
Notably, within the filesystem services, this eliminates two ReadBlock()
calls by using the helper functions of HLERequestContext to do that for
us.
|
| |
|
|
|
|
|
| |
* core_timing: Use better reference tracking for EventType.
- Moves ownership of the event to the caller, ensuring we don't fire events for destroyed objects.
- Removes need for unique names - we won't be using this for save states anyways.
|
| |
|
|
|
|
| |
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects.
- See https://github.com/citra-emu/citra/pull/4710 for details.
|
| | |
|
| |
|
|
| |
Added framecount
|
| | |
|
| | |
|
| |
|
|
| |
Creating multiple "AudioRenderer" threads cause the previous thread to be overwritten. The thread will name be renamed to AudioRenderer-InstanceX, where X is the current instance number.
|
| | |
|
| |
|
|
|
|
| |
We shouldn't be incrementing if wave buffers are empty. They are considered invalid/unused wave buffers.
This fixes the issue of certain sounds looping when they shouldn't
|
| |\
| |
| | |
Core_Timing: Make core_timing threadsafe by default.
|
| | |
| |
| |
| |
| |
| | |
The old implementation had faulty Threadsafe methods where events could
be missing. This implementation unifies unsafe/safe methods and makes
core timing thread safe overall.
|
| | | |
|
| |/
|
|
| |
IPC-100 was changed to InitializeApplicationInfoOld instead of InitializeApplicationInfo. IPC-150 makes an indentical call to IPC-100 however does extra processing. They should not have the same name as it's quite confusing to debug.
|
| |
|
|
|
| |
Makes the interface more type-safe and consistent in terms of return
values.
|
| |
|
|
|
|
|
|
|
|
|
| |
In some cases, our callbacks were using s64 as a parameter, and in other
cases, they were using an int, which is inconsistent.
To make all callbacks consistent, we can just use an s64 as the type for
late cycles, given it gets rid of the need to cast internally.
While we're at it, also resolve some signed/unsigned conversions that
were occurring related to the callback registration.
|
| |
|
|
| |
This behavior also needs to be visible for MinGW builds as well.
|
| |
|
|
|
| |
cubeb now requires that COM explicitly be initialized on the thread
prior to calling cubeb_init.
|
| |
|
|
|
|
|
|
|
| |
Provides names for previously unknown entries (aside from the two u8
that appear to be padding bytes, and a single word that also appears
to be reserved or padding).
This will be useful in subsequent changes when unstubbing behavior related
to the audio renderer services.
|
| |
|
|
|
| |
Ensures that all member variables are initialized in a deterministic
manner across the board.
|
| |
|
|
|
| |
CubebSinkStream inherits from a base class with a virtual destructor, so
override can be appended to CubebSinkStream's destructor.
|
| |
|
|
|
|
| |
The name of the parameter was shadowing the member variable of the same
name. Instead, alter the name of the parameter to prevent said
shadowing.
|
| |
|
|
|
| |
The assignments here were performing an implicit truncation from int to
s16. Make it explicit that this is desired behavior.
|
| |
|
|
| |
This way proper const/non-const selection can occur.
|
| |
|
|
|
|
|
|
|
|
|
| |
Gets rid of the largest set of mutable global state within the core.
This also paves a way for eliminating usages of GetInstance() on the
System class as a follow-up.
Note that no behavioral changes have been made, and this simply extracts
the functionality into a class. This also has the benefit of making
dependencies on the core timing functionality explicit within the
relevant interfaces.
|
| |
|
|
|
|
| |
Places all of the timing-related functionality under the existing Core
namespace to keep things consistent, rather than having the timing
utilities sitting in its own completely separate namespace.
|
| |
|
|
|
| |
According to documentation, if the argument of std::exp is zero, one is returned.
However we want the return value to be also zero in this case so no audio is played.
|
| | |
|
| |
|
|
|
|
| |
These two macros being used in tandem were used prior to the
introduction of UNIMPLEMENTED and UNIMPLEMENTED_MSG. This provides
equivalent behavior, just with less typing/reading involved.
|
| |\
| |
| | |
audio_core: Make g_sink_details internally linked
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We can hide the direct array from external view and instead provide
functions to retrieve the necessary info. This has the benefit of
completely hiding the makeup of the SinkDetails structure from the rest
of the code.
Given that this makes the array hidden, we can also make the array
constexpr by altering the members slightly. This gets rid of several
static constructor calls related to std::vector and std::function.
Now we don't have heap allocations here that need to occur before the
program can even enter main(). It also has the benefit of saving a
little bit of heap space, but this doesn't matter too much, since the
savings in that regard are pretty tiny.
|
| |/ |
|
| | |
|
| | |
|
| |
|
|
|
| |
This was created with the unfinished resampling PR in mind.
As the resampling is now on the audio thread, we don't need to care about this here any more.
|
| | |
|
| |
|
|
| |
We already ignore them on listing devices. We should do the same when selecting devices. This fix a crash when opening a specific device while there is a null device in the list
|
| |
|
|
| |
This is only stored to, but never read from.
|
| | |
|
| | |
|
| |
|
|
|
| |
Softlock explanation:
after effects are initialized in smo, nothing actually changes the state. It expects the state to always be initialized. With the previous testing, updating the states much like how we handle the memory pools continue to have the softlock(which is why I said it probably wasn't effects) after further examination it seems like effects need to be initialized but the state remains unchanged until further notice. For now, assertions are added for the aux buffers to see if they update, unable to check as I haven't gotten smo to actually update them yet.
|
| | |
|
| |
|
|
|
|
| |
Preserves the meaning/type-safetiness of the stream state instead of
making it an opaque u32. This makes it usable for other things outside
of the service HLE context.
|
| | |
|
| |
|
|
| |
This function is called too many times and makes the debug logging basically unusable due to the spam.
|
| |
|
|
| |
This isn't used within this header and isn't necessary.
|
| |
|
|
|
| |
Avoids propagating includes in headers where it's not necessary to do
so.
|
| |
|
|
|
|
|
|
|
| |
Avoids including unnecessary headers within the audio_renderer.h header,
lessening the likelihood of needing to rebuild source files including
this header if they ever change.
Given std::vector allows forward declaring contained types, we can move
VoiceState to the cpp file and hide the implementation entirely.
|
| |\
| |
| | |
audio_core/time_stretch: Silence truncation warnings in Process()
|
| | |
| |
| |
| | |
The SoundTouch API only accepts uint amount of samples.
|
| |\ \
| | |
| | | |
cubeb_sink: Get rid of variable shadowing within CubebSink's constructor
|
| | |/
| |
| |
| |
| | |
The parameter of the lambda was shadowing the variable that was being
assigned to.
|
| |\ \
| | |
| | | |
cubeb_sink: Correct context name in ListCubebSinkDevices()
|
| | |/
| |
| |
| | |
This ain't Citra.
|
| |/ |
|
| |\
| |
| | |
audio_core/sink_details: Change std::string parameter into std::string_view
|
| | |
| |
| |
| |
| | |
The given string is only ever used for lookup and comparison, so we can
just utilize a non-owning view to string data here
|
| |\ \
| |/
|/| |
audio_core: Add audio stretching support
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| | |
This reduces clicking in output audio should we underrun.
|
| | | |
|
| | | |
|
| |/ |
|
| |
|
|
|
|
| |
Blame the subsystems which deserve the blame :)
The updated list is not complete, just the ones I've spotted on random sampling the stack trace.
|
| |
|
|
|
| |
Previously this would cause warnings about implicit conversions to s16
from a double
|
| |\
| |
| | |
audio_core: Interpolate
|
| | | |
|
| | | |
|
| | | |
|
| |/ |
|
| | |
|
| |
|
|
| |
GetAudioRendererSampleRate is set as a "STUB" as a game could check if the sample rate it sent and the sample rate it wants don't match. Just a thought of something which could happen so keeping it as stub for the mean time
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
sink_details: std::move std::function instances
|
| | |
| |
| |
| |
| | |
We can just use type aliases to avoid needing to write the same long
type twice
|
| | |
| |
| |
| |
| | |
Given std::function is allowed to potentially allocate, these should be
std::move'd to prevent potential reallocation (should that ever happen).
|
| |/
|
|
|
| |
This makes the Buffer::Tag usage consistent with the Stream class's
prototype of GetTagsAndReleaseBuffers().
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
| |
* CoreTiming: New CoreTiming; Add Test for CoreTiming
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
| |
The current code inserts and deletes elements from the beginning of the audio buffer, which is very inefficient in an std::vector.
Profiling was done using VisualStudio2017's Performance Analyzer in Super Mario 3D Land.
Before this change: AudioInterp::Linear had 14.14% of the runtime (inclusive) and most of that time was spent in std::vector's insert implementation.
After this change: AudioInterp::Linear has 0.36% of the runtime (inclusive)
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Modules didn't correctly define their dependencies before, which relied
on the frontends implicitly including every module for linking to
succeed.
Also changed every target_link_libraries call to specify visibility of
dependencies to avoid leaking definitions to dependents when not
necessary.
|
| |
|
|
| |
Also move address space mapping out of video_core.
|
| |
|
|
|
|
|
|
|
| |
Corrects a few issues with regards to Doxygen documentation, for example:
- Incorrect parameter referencing.
- Missing @param tags.
- Typos in @param tags.
and a few minor other issues.
|
| |
|
|
|
| |
* Support looping HLE audio
* DSP: Fix dirty bit clears, handle nonmonotonically incrementing IDs
* DSP: Add start offset support
|
| |
|
|
|
|
|
|
|
|
|
|
| |
```
In file included from citra/src/audio_core/sink_details.cpp:11:
citra/src/./audio_core/sdl2_sink.h:25:10: warning: 'SetDevice' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
void SetDevice(int device_id);
^
citra/src/./audio_core/sink.h:39:18: note: overridden virtual function is here
virtual void SetDevice(int device_id) = 0;
^
```
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Initial Commit
Added Device logic to Sinks
Started on UI for selecting devices
Removed redundant import
* Audio Core: Complete Device Switching
Complete the device switching implementation by allowing the output
device to be loaded, changed and saved through the configurations menu.
Worked with the Sink abstraction and tuned the "Device Selection"
configuration so that the Device List is automatically populated when
the Sink is changed.
This hopefully addresses the concerns and recommendations mentioned in
the comments of the PR.
* Clean original implementation.
* Refactor GetSinkDetails
|
| | |
|
| |
|
|
|
| |
Previously there was a split where some of the services were in the
Service namespace and others were not.
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
| |
This makes clang-format useful on those.
Also add a bunch of forgotten transitive includes, which otherwise
prevented compilation.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Closes #2049.
Signed-off-by: MerryMage <MerryMage@users.noreply.github.com>
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
* AudioCore: Implement time stretcher
* fixup! AudioCore: Implement time stretcher
* fixup! fixup! AudioCore: Implement time stretcher
* fixup! fixup! fixup! AudioCore: Implement time stretcher
* fixup! fixup! fixup! fixup! AudioCore: Implement time stretcher
* fixup! fixup! fixup! fixup! fixup! AudioCore: Implement time stretcher
|
| |
|
|
| |
Silences two warnings on OSX.
|
| | |
|
| |\
| |
| | |
AudioCore: SDL2 Sink
|
| | | |
|
| | | |
|
| |/ |
|
| | |
|
| | |
|
| | |
|
| |\
| |
| | |
AudioCore: CurrentRegion() -> ReadRegion(), WriteRegion()
|
| | | |
|
| |\ \
| | |
| | | |
AudioCore: Implement interpolation
|
| | | | |
|
| |\ \ \
| | | |
| | | | |
AudioCore: Move samples_per_frame and num_sources into hle/common.h
|
| | | |/
| |/| |
|
| |\ \ \
| |/ /
|/| | |
Externals: Add soundtouch
|
| | |/ |
|
| | | |
|
| | | |
|
| |/ |
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Pipe 2 is a DSP pipe that is used to initialize both the DSP hardware (the
application signals to the DSP to initialize) and the application (the DSP
provides the memory location of structures in the shared memory region).
|
|
|
This commit:
* Adds a new subproject, audio_core.
* Defines structures that exist in DSP shared memory.
* Hooks up various other parts of the emulator into audio core.
This sets the foundation for a later HLE DSP implementation.
|
