diff options
author | bunnei <bunneidev@gmail.com> | 2021-09-28 19:46:56 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-09-28 19:46:56 +0200 |
commit | 24c0dde958136268729e56eb024ff4db8a269f38 (patch) | |
tree | 15ef18c6fe51a5dc20081fa7372893ae10518a3f /src/video_core/vulkan_common/vulkan_device.cpp | |
parent | Merge pull request #7096 from german77/update_13.0.0 (diff) | |
parent | vk_texture_cache: Disable cube compatibility flag on non-mesa AMD GCN4 and earlier (diff) | |
download | yuzu-24c0dde958136268729e56eb024ff4db8a269f38.tar yuzu-24c0dde958136268729e56eb024ff4db8a269f38.tar.gz yuzu-24c0dde958136268729e56eb024ff4db8a269f38.tar.bz2 yuzu-24c0dde958136268729e56eb024ff4db8a269f38.tar.lz yuzu-24c0dde958136268729e56eb024ff4db8a269f38.tar.xz yuzu-24c0dde958136268729e56eb024ff4db8a269f38.tar.zst yuzu-24c0dde958136268729e56eb024ff4db8a269f38.zip |
Diffstat (limited to '')
-rw-r--r-- | src/video_core/vulkan_common/vulkan_device.cpp | 25 |
1 files changed, 15 insertions, 10 deletions
diff --git a/src/video_core/vulkan_common/vulkan_device.cpp b/src/video_core/vulkan_common/vulkan_device.cpp index c2ec9f76a..6388ed2eb 100644 --- a/src/video_core/vulkan_common/vulkan_device.cpp +++ b/src/video_core/vulkan_common/vulkan_device.cpp @@ -588,22 +588,27 @@ Device::Device(VkInstance instance_, vk::PhysicalDevice physical_, VkSurfaceKHR ext_extended_dynamic_state = false; } } - sets_per_pool = 64; - if (driver_id == VK_DRIVER_ID_AMD_PROPRIETARY || driver_id == VK_DRIVER_ID_AMD_OPEN_SOURCE) { + + const bool is_amd = + driver_id == VK_DRIVER_ID_AMD_PROPRIETARY || driver_id == VK_DRIVER_ID_AMD_OPEN_SOURCE; + if (is_amd) { // AMD drivers need a higher amount of Sets per Pool in certain circunstances like in XC2. sets_per_pool = 96; - } - - const bool is_amd = driver_id == VK_DRIVER_ID_AMD_PROPRIETARY || - driver_id == VK_DRIVER_ID_MESA_RADV || - driver_id == VK_DRIVER_ID_AMD_OPEN_SOURCE; - if (ext_sampler_filter_minmax && is_amd) { - // Disable ext_sampler_filter_minmax on AMD GCN4 and lower as it is broken. + // Disable VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT on AMD GCN4 and lower as it is broken. if (!is_float16_supported) { LOG_WARNING( Render_Vulkan, - "Blacklisting AMD GCN4 and lower for VK_EXT_SAMPLER_FILTER_MINMAX_EXTENSION_NAME"); + "AMD GCN4 and earlier do not properly support VK_IMAGE_CREATE_CUBE_COMPATIBLE_BIT"); + has_broken_cube_compatibility = true; + } + } + const bool is_amd_or_radv = is_amd || driver_id == VK_DRIVER_ID_MESA_RADV; + if (ext_sampler_filter_minmax && is_amd_or_radv) { + // Disable ext_sampler_filter_minmax on AMD GCN4 and lower as it is broken. + if (!is_float16_supported) { + LOG_WARNING(Render_Vulkan, + "Blacklisting AMD GCN4 and earlier for VK_EXT_sampler_filter_minmax"); ext_sampler_filter_minmax = false; } } |