diff options
author | Charles Lombardo <clombardo169@gmail.com> | 2023-10-13 21:08:39 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-10-13 21:08:39 +0200 |
commit | 4a9240599a21c78b957e3a738d2282d4ffa30129 (patch) | |
tree | d9472976c091428048b3da2fe93a885194caa9f7 | |
parent | Improvement in Directory Path Detection for Shortcuts (#11749) (diff) | |
parent | android: Fix incorrect assumption for driver installation validation (diff) | |
download | yuzu-4a9240599a21c78b957e3a738d2282d4ffa30129.tar yuzu-4a9240599a21c78b957e3a738d2282d4ffa30129.tar.gz yuzu-4a9240599a21c78b957e3a738d2282d4ffa30129.tar.bz2 yuzu-4a9240599a21c78b957e3a738d2282d4ffa30129.tar.lz yuzu-4a9240599a21c78b957e3a738d2282d4ffa30129.tar.xz yuzu-4a9240599a21c78b957e3a738d2282d4ffa30129.tar.zst yuzu-4a9240599a21c78b957e3a738d2282d4ffa30129.zip |
Diffstat (limited to '')
-rw-r--r-- | src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriverManagerFragment.kt | 25 |
1 files changed, 13 insertions, 12 deletions
diff --git a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriverManagerFragment.kt b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriverManagerFragment.kt index 10b1d3547..df21d74b2 100644 --- a/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriverManagerFragment.kt +++ b/src/android/app/src/main/java/org/yuzu/yuzu_emu/fragments/DriverManagerFragment.kt @@ -26,6 +26,7 @@ import org.yuzu.yuzu_emu.model.DriverViewModel import org.yuzu.yuzu_emu.model.HomeViewModel import org.yuzu.yuzu_emu.utils.FileUtil import org.yuzu.yuzu_emu.utils.GpuDriverHelper +import java.io.File import java.io.IOException class DriverManagerFragment : Fragment() { @@ -154,29 +155,29 @@ class DriverManagerFragment : Fragment() { R.string.installing_driver, false ) { + val driverPath = + "${GpuDriverHelper.driverStoragePath}/${FileUtil.getFilename(result)}" + val driverFile = File(driverPath) + // Ignore file exceptions when a user selects an invalid zip try { - GpuDriverHelper.copyDriverToInternalStorage(result) + if (!GpuDriverHelper.copyDriverToInternalStorage(result)) { + throw IOException("Driver failed validation!") + } } catch (_: IOException) { + if (driverFile.exists()) { + driverFile.delete() + } return@newInstance getString(R.string.select_gpu_driver_error) } - val driverData = GpuDriverHelper.customDriverData - if (driverData.name == null) { - return@newInstance getString(R.string.select_gpu_driver_error) - } - + val driverData = GpuDriverHelper.getMetadataFromZip(driverFile) val driverInList = driverViewModel.driverList.value.firstOrNull { it.second == driverData } if (driverInList != null) { return@newInstance getString(R.string.driver_already_installed) } else { - driverViewModel.addDriver( - Pair( - "${GpuDriverHelper.driverStoragePath}/${FileUtil.getFilename(result)}", - driverData - ) - ) + driverViewModel.addDriver(Pair(driverPath, driverData)) driverViewModel.setNewDriverInstalled(true) } return@newInstance Any() |