diff options
author | Fernando Sahmkow <fsahmkow27@gmail.com> | 2021-07-14 19:04:45 +0200 |
---|---|---|
committer | Fernando Sahmkow <fsahmkow27@gmail.com> | 2021-07-15 02:02:08 +0200 |
commit | 1ae4b684fff380035b468086586159a231237ed7 (patch) | |
tree | 0f2d3bba4c07670b4d4b5cc56a506635f8cb08a7 | |
parent | GPUMemoryManager: Force inmediate invalidation when writting block. (diff) | |
download | yuzu-1ae4b684fff380035b468086586159a231237ed7.tar yuzu-1ae4b684fff380035b468086586159a231237ed7.tar.gz yuzu-1ae4b684fff380035b468086586159a231237ed7.tar.bz2 yuzu-1ae4b684fff380035b468086586159a231237ed7.tar.lz yuzu-1ae4b684fff380035b468086586159a231237ed7.tar.xz yuzu-1ae4b684fff380035b468086586159a231237ed7.tar.zst yuzu-1ae4b684fff380035b468086586159a231237ed7.zip |
Diffstat (limited to '')
-rw-r--r-- | src/video_core/buffer_cache/buffer_cache.h | 14 | ||||
-rw-r--r-- | src/video_core/engines/maxwell_dma.cpp | 5 | ||||
-rw-r--r-- | src/video_core/memory_manager.cpp | 2 |
3 files changed, 10 insertions, 11 deletions
diff --git a/src/video_core/buffer_cache/buffer_cache.h b/src/video_core/buffer_cache/buffer_cache.h index 9399bcfea..7373cb62d 100644 --- a/src/video_core/buffer_cache/buffer_cache.h +++ b/src/video_core/buffer_cache/buffer_cache.h @@ -172,7 +172,7 @@ public: [[nodiscard]] bool IsRegionGpuModified(VAddr addr, size_t size); /// Return true when a region is registered on the cache - [[nodiscard]] bool IsRegionRegistered(VAddr addr, size_t size) const; + [[nodiscard]] bool IsRegionRegistered(VAddr addr, size_t size); /// Return true when a CPU region is modified from the CPU [[nodiscard]] bool IsRegionCpuModified(VAddr addr, size_t size); @@ -503,10 +503,6 @@ bool BufferCache<P>::DMACopy(GPUVAddr src_address, GPUVAddr dest_address, u64 am auto& src_buffer = slot_buffers[buffer_a]; auto& dest_buffer = slot_buffers[buffer_b]; SynchronizeBuffer(src_buffer, *cpu_src_address, static_cast<u32>(amount)); - const VAddr aligned_dst = Common::AlignUp(*cpu_dest_address, 64); - const u64 diff = aligned_dst - *cpu_dest_address; - const u64 new_amount = diff > amount ? 0 : amount - diff; - dest_buffer.UnmarkRegionAsCpuModified(aligned_dst, Common::AlignDown(new_amount, 64)); SynchronizeBuffer(dest_buffer, *cpu_dest_address, static_cast<u32>(amount)); std::array copies{BufferCopy{ .src_offset = src_buffer.Offset(*cpu_src_address), @@ -552,21 +548,19 @@ bool BufferCache<P>::DMAClear(GPUVAddr dst_address, u64 amount, u32 value) { return false; } - const IntervalType subtract_interval{*cpu_dst_address, *cpu_dst_address + amount * sizeof(u32)}; + const size_t size = amount * sizeof(u32); + const IntervalType subtract_interval{*cpu_dst_address, *cpu_dst_address + size}; ClearDownload(subtract_interval); common_ranges.subtract(subtract_interval); - const size_t size = amount * sizeof(u32); BufferId buffer; do { has_deleted_buffers = false; buffer = FindBuffer(*cpu_dst_address, static_cast<u32>(size)); } while (has_deleted_buffers); - auto& dest_buffer = slot_buffers[buffer]; const u32 offset = static_cast<u32>(*cpu_dst_address - dest_buffer.CpuAddr()); runtime.ClearBuffer(dest_buffer, offset, size, value); - dest_buffer.UnmarkRegionAsCpuModified(*cpu_dst_address, size); return true; } @@ -828,7 +822,7 @@ bool BufferCache<P>::IsRegionGpuModified(VAddr addr, size_t size) { } template <class P> -bool BufferCache<P>::IsRegionRegistered(VAddr addr, size_t size) const { +bool BufferCache<P>::IsRegionRegistered(VAddr addr, size_t size) { const VAddr end_addr = addr + size; const u64 page_end = Common::DivCeil(end_addr, PAGE_SIZE); for (u64 page = addr >> PAGE_BITS; page < page_end;) { diff --git a/src/video_core/engines/maxwell_dma.cpp b/src/video_core/engines/maxwell_dma.cpp index 0ae6692f9..c51776466 100644 --- a/src/video_core/engines/maxwell_dma.cpp +++ b/src/video_core/engines/maxwell_dma.cpp @@ -4,6 +4,7 @@ #include "common/assert.h" #include "common/logging/log.h" +#include "common/microprofile.h" #include "common/settings.h" #include "core/core.h" #include "video_core/engines/maxwell_3d.h" @@ -12,6 +13,9 @@ #include "video_core/renderer_base.h" #include "video_core/textures/decoders.h" +MICROPROFILE_DECLARE(GPU_DMAEngine); +MICROPROFILE_DEFINE(GPU_DMAEngine, "GPU", "DMA Engine", MP_RGB(224, 224, 128)); + namespace Tegra::Engines { using namespace Texture; @@ -43,6 +47,7 @@ void MaxwellDMA::CallMultiMethod(u32 method, const u32* base_start, u32 amount, } void MaxwellDMA::Launch() { + MICROPROFILE_SCOPE(GPU_DMAEngine); LOG_TRACE(Render_OpenGL, "DMA copy 0x{:x} -> 0x{:x}", static_cast<GPUVAddr>(regs.offset_in), static_cast<GPUVAddr>(regs.offset_out)); diff --git a/src/video_core/memory_manager.cpp b/src/video_core/memory_manager.cpp index 2bc97ec30..d2b9d5f2b 100644 --- a/src/video_core/memory_manager.cpp +++ b/src/video_core/memory_manager.cpp @@ -327,7 +327,7 @@ void MemoryManager::WriteBlock(GPUVAddr gpu_dest_addr, const void* src_buffer, s // Invalidate must happen on the rasterizer interface, such that memory is always // synchronous when it is written (even when in asynchronous GPU mode). - rasterizer->UnmapMemory(dest_addr, copy_amount); + rasterizer->InvalidateRegion(dest_addr, copy_amount); system.Memory().WriteBlockUnsafe(dest_addr, src_buffer, copy_amount); } |