From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001
From: peterbell10 <peterbell10@live.co.uk>
Date: Thu, 14 May 2020 23:15:35 +0100
Subject: Enable some more clang-tidy linter checks (#4738)

* Avoid inefficient AString -> c_str() -> AString round trip

* Avoid redundant string init expressions

* Avoid unnecessary return, continue, etc.

* Add .clang-format to help with clang-tidy fix-its

* Avoid unnecessary passing by value

* Avoid unnecessary local copying

* Avoid copying in range-for loops

* Avoid over-complicated boolean expressions

* Some violations missed by my local clang-tidy

* Allow unnecessary continue statements

* Add brackets

* Another expression missed locally

* Move BindingsProcessor call into clang-tidy.sh and add space

* Fix pushd not found error

* Different grouping of CheckBlockInteractionRate
---
 src/RCONServer.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/RCONServer.cpp')

diff --git a/src/RCONServer.cpp b/src/RCONServer.cpp
index 2c65658cb..dbce003b3 100644
--- a/src/RCONServer.cpp
+++ b/src/RCONServer.cpp
@@ -124,7 +124,7 @@ cRCONServer::cRCONServer(cServer & a_Server) :
 
 cRCONServer::~cRCONServer()
 {
-	for (auto srv: m_ListenServers)
+	for (const auto & srv: m_ListenServers)
 	{
 		srv->Close();
 	}
@@ -153,7 +153,7 @@ void cRCONServer::Initialize(cSettingsRepositoryInterface & a_Settings)
 	AStringVector Ports = ReadUpgradeIniPorts(a_Settings, "RCON", "Ports", "PortsIPv4", "PortsIPv6", "25575");
 
 	// Start listening on each specified port:
-	for (auto port: Ports)
+	for (const auto & port: Ports)
 	{
 		UInt16 PortNum;
 		if (!StringToInteger(port, PortNum))
-- 
cgit v1.2.3