From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- clang-tidy.sh | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'clang-tidy.sh') diff --git a/clang-tidy.sh b/clang-tidy.sh index 43da93618..86a71521b 100755 --- a/clang-tidy.sh +++ b/clang-tidy.sh @@ -6,10 +6,14 @@ FIXES_FILE="tidy-fixes.yaml" REGEX="/cuberite/src/\.?[^\.]" ARGS="-header-filter $REGEX -quiet -export-fixes $FIXES_FILE "$@" $REGEX" +# Generate the compilation database mkdir -p tidy-build cd tidy-build cmake --target Cuberite -DCMAKE_EXPORT_COMPILE_COMMANDS=ON .. +# Ensure LuaState_Typedefs.inc has been generated +(cd ../src/Bindings && lua BindingsProcessor.lua) + if run-clang-tidy $ARGS; then echo "clang-tidy: No violations found" else -- cgit v1.2.3