summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMike Hunsinger <mike.hunsinger@gmail.com>2014-01-24 03:54:00 +0100
committerMike Hunsinger <mike.hunsinger@gmail.com>2014-01-24 03:54:00 +0100
commit11948b1d4b98e0147217eef2928a2391c2d8e958 (patch)
tree1d9e526f979f9e15e09331e688a740abae7c1a2d
parentRemoved extra line (diff)
downloadcuberite-11948b1d4b98e0147217eef2928a2391c2d8e958.tar
cuberite-11948b1d4b98e0147217eef2928a2391c2d8e958.tar.gz
cuberite-11948b1d4b98e0147217eef2928a2391c2d8e958.tar.bz2
cuberite-11948b1d4b98e0147217eef2928a2391c2d8e958.tar.lz
cuberite-11948b1d4b98e0147217eef2928a2391c2d8e958.tar.xz
cuberite-11948b1d4b98e0147217eef2928a2391c2d8e958.tar.zst
cuberite-11948b1d4b98e0147217eef2928a2391c2d8e958.zip
-rw-r--r--MCServer/Plugins/APIDump/Hooks/OnPlayerTossingItem.lua4
-rw-r--r--src/Entities/Player.cpp6
-rw-r--r--src/Entities/Player.h6
-rw-r--r--src/UI/Window.cpp22
4 files changed, 18 insertions, 20 deletions
diff --git a/MCServer/Plugins/APIDump/Hooks/OnPlayerTossingItem.lua b/MCServer/Plugins/APIDump/Hooks/OnPlayerTossingItem.lua
index 2b65294ef..48aac2aa0 100644
--- a/MCServer/Plugins/APIDump/Hooks/OnPlayerTossingItem.lua
+++ b/MCServer/Plugins/APIDump/Hooks/OnPlayerTossingItem.lua
@@ -19,8 +19,8 @@ return
Returns = [[
If the function returns false or no value, other plugins' callbacks are called and finally MCServer
creates the pickup for the item and tosses it, using {{cPlayer}}:TossHeldItem, {{cPlayer}}:TossEquippedItem,
- or {{cPlayer}}:TossPickup. If the function returns true, no other callbacks are called for this event
- and MCServer doesn't toss the item.
+ or {{cPlayer}}:TossPickup. If the function returns true, no other callbacks are called for this event
+ and MCServer doesn't toss the item.
]],
}, -- HOOK_PLAYER_TOSSING_ITEM
}
diff --git a/src/Entities/Player.cpp b/src/Entities/Player.cpp
index ca39d4d9d..64cd334d1 100644
--- a/src/Entities/Player.cpp
+++ b/src/Entities/Player.cpp
@@ -1389,8 +1389,8 @@ void cPlayer::TossHeldItem(char a_Amount)
}
}
- double vX = 0, vY = 0, vZ = 0;
- EulerToVector(-GetYaw(), GetPitch(), vZ, vX, vY);
+ double vX = 0, vY = 0, vZ = 0;
+ EulerToVector(-GetYaw(), GetPitch(), vZ, vX, vY);
vY = -vY * 2 + 1.f;
m_World->SpawnItemPickups(Drops, GetPosX(), GetEyeHeight(), GetPosZ(), vX * 3, vY * 3, vZ * 3, true); // 'true' because created by player
}
@@ -1402,7 +1402,7 @@ void cPlayer::TossHeldItem(char a_Amount)
void cPlayer::TossPickup(const cItem & a_Item)
{
cItems Drops;
- Drops.push_back(a_Item);
+ Drops.push_back(a_Item);
double vX = 0, vY = 0, vZ = 0;
EulerToVector(-GetYaw(), GetPitch(), vZ, vX, vY);
diff --git a/src/Entities/Player.h b/src/Entities/Player.h
index 71033ab77..7925e70a1 100644
--- a/src/Entities/Player.h
+++ b/src/Entities/Player.h
@@ -214,13 +214,13 @@ public:
/// Returns the full color code to use for this player, based on their primary group or set in m_Color
AString GetColor(void) const;
- // tosses the item in the selected hotbar slot
+ /** tosses the item in the selected hotbar slot */
void TossEquippedItem(char a_Amount = 1);
- // tosses the item held in hand (when in UI windows)
+ /** tosses the item held in hand (when in UI windows) */
void TossHeldItem(char a_Amount = 1);
- // tosses a pickup newly created from a_Item
+ /** tosses a pickup newly created from a_Item */
void TossPickup(const cItem & a_Item);
/// Heals the player by the specified amount of HPs (positive only); sends health update
diff --git a/src/UI/Window.cpp b/src/UI/Window.cpp
index 3d23dfd07..4261a58d9 100644
--- a/src/UI/Window.cpp
+++ b/src/UI/Window.cpp
@@ -171,7 +171,6 @@ void cWindow::Clicked(
)
{
cPluginManager * PlgMgr = cRoot::Get()->GetPluginManager();
-
if (a_WindowID != m_WindowID)
{
LOGWARNING("%s: Wrong window ID (exp %d, got %d) received from \"%s\"; ignoring click.", __FUNCTION__, m_WindowID, a_WindowID, a_Player.GetName().c_str());
@@ -182,16 +181,15 @@ void cWindow::Clicked(
{
case caRightClickOutside:
{
- if (PlgMgr->CallHookPlayerTossingItem(a_Player))
+ if (PlgMgr->CallHookPlayerTossingItem(a_Player))
{
// A plugin doesn't agree with the tossing. The plugin itself is responsible for handling the consequences (possible inventory mismatch)
return;
}
-
- if (a_Player.IsGameModeCreative())
- {
- a_Player.TossPickup(a_ClickedItem);
- }
+ if (a_Player.IsGameModeCreative())
+ {
+ a_Player.TossPickup(a_ClickedItem);
+ }
// Toss one of the dragged items:
a_Player.TossHeldItem();
@@ -205,10 +203,10 @@ void cWindow::Clicked(
return;
}
- if (a_Player.IsGameModeCreative())
- {
- a_Player.TossPickup(a_ClickedItem);
- }
+ if (a_Player.IsGameModeCreative())
+ {
+ a_Player.TossPickup(a_ClickedItem);
+ }
// Toss all dragged items:
a_Player.TossHeldItem(a_Player.GetDraggingItem().m_ItemCount);
@@ -288,7 +286,7 @@ bool cWindow::ClosedByPlayer(cPlayer & a_Player, bool a_CanRefuse)
if (a_Player.IsDraggingItem())
{
LOGD("Player holds item! Dropping it...");
- a_Player.TossHeldItem(a_Player.GetDraggingItem().m_ItemCount);
+ a_Player.TossHeldItem(a_Player.GetDraggingItem().m_ItemCount);
}
cClientHandle * ClientHandle = a_Player.GetClientHandle();