From 4a01f36d210491e78765b5f6875ecd840f8c3b1e Mon Sep 17 00:00:00 2001 From: Tao Bao Date: Fri, 26 Apr 2019 23:41:49 -0700 Subject: tests: Merge recovery_component_test into recovery_unit_test. Most of the tests in component/ are in fact unit tests. And it doesn't look practically beneficial to distinguish between the two: - They have the same test setup; - We always run both (recovery_unit_test and recovery_component_test) at the same time; - Breaking any of them would be equally bad. This CL merges the tests in recovery_component_test into recovery_unit_test to save the effort to maintain both. Test: Run recovery_unit_test on marlin (via `adb sync data`). Test: `atest recovery_unit_test` Change-Id: I93ff32e7219cd83425a4bcfe5613978a8dd48d75 --- tests/component/update_verifier_test.cpp | 219 ------------------------------- 1 file changed, 219 deletions(-) delete mode 100644 tests/component/update_verifier_test.cpp (limited to 'tests/component/update_verifier_test.cpp') diff --git a/tests/component/update_verifier_test.cpp b/tests/component/update_verifier_test.cpp deleted file mode 100644 index e27e58c22..000000000 --- a/tests/component/update_verifier_test.cpp +++ /dev/null @@ -1,219 +0,0 @@ -/* - * Copyright (C) 2017 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -#include - -#include -#include -#include -#include - -#include -#include -#include -#include -#include - -#include "care_map.pb.h" - -using namespace std::string_literals; - -class UpdateVerifierTest : public ::testing::Test { - protected: - void SetUp() override { - std::string verity_mode = android::base::GetProperty("ro.boot.veritymode", ""); - verity_supported = android::base::EqualsIgnoreCase(verity_mode, "enforcing"); - - care_map_prefix_ = care_map_dir_.path + "/care_map"s; - care_map_pb_ = care_map_dir_.path + "/care_map.pb"s; - care_map_txt_ = care_map_dir_.path + "/care_map.txt"s; - // Overrides the the care_map_prefix. - verifier_.set_care_map_prefix(care_map_prefix_); - - property_id_ = "ro.build.fingerprint"; - fingerprint_ = android::base::GetProperty(property_id_, ""); - // Overrides the property_reader if we cannot read the given property on the device. - if (fingerprint_.empty()) { - fingerprint_ = "mock_fingerprint"; - verifier_.set_property_reader([](const std::string& /* id */) { return "mock_fingerprint"; }); - } - } - - void TearDown() override { - unlink(care_map_pb_.c_str()); - unlink(care_map_txt_.c_str()); - } - - // Returns a serialized string of the proto3 message according to the given partition info. - std::string ConstructProto( - std::vector>& partitions) { - recovery_update_verifier::CareMap result; - for (const auto& partition : partitions) { - recovery_update_verifier::CareMap::PartitionInfo info; - if (partition.find("name") != partition.end()) { - info.set_name(partition.at("name")); - } - if (partition.find("ranges") != partition.end()) { - info.set_ranges(partition.at("ranges")); - } - if (partition.find("id") != partition.end()) { - info.set_id(partition.at("id")); - } - if (partition.find("fingerprint") != partition.end()) { - info.set_fingerprint(partition.at("fingerprint")); - } - - *result.add_partitions() = info; - } - - return result.SerializeAsString(); - } - - bool verity_supported; - UpdateVerifier verifier_; - - TemporaryDir care_map_dir_; - std::string care_map_prefix_; - std::string care_map_pb_; - std::string care_map_txt_; - - std::string property_id_; - std::string fingerprint_; -}; - -TEST_F(UpdateVerifierTest, verify_image_no_care_map) { - ASSERT_FALSE(verifier_.ParseCareMap()); -} - -TEST_F(UpdateVerifierTest, verify_image_text_format) { - // This test relies on dm-verity support. - if (!verity_supported) { - GTEST_LOG_(INFO) << "Test skipped on devices without dm-verity support."; - return; - } - - std::string content = "system\n2,0,1"; - ASSERT_TRUE(android::base::WriteStringToFile(content, care_map_txt_)); - // CareMap in text format is no longer supported. - ASSERT_FALSE(verifier_.ParseCareMap()); -} - -TEST_F(UpdateVerifierTest, verify_image_empty_care_map) { - ASSERT_FALSE(verifier_.ParseCareMap()); -} - -TEST_F(UpdateVerifierTest, verify_image_protobuf_care_map_smoke) { - // This test relies on dm-verity support. - if (!verity_supported) { - GTEST_LOG_(INFO) << "Test skipped on devices without dm-verity support."; - return; - } - - std::vector> partitions = { - { - { "name", "system" }, - { "ranges", "2,0,1" }, - { "id", property_id_ }, - { "fingerprint", fingerprint_ }, - }, - }; - - std::string proto = ConstructProto(partitions); - ASSERT_TRUE(android::base::WriteStringToFile(proto, care_map_pb_)); - ASSERT_TRUE(verifier_.ParseCareMap()); - ASSERT_TRUE(verifier_.VerifyPartitions()); -} - -TEST_F(UpdateVerifierTest, verify_image_protobuf_care_map_missing_name) { - // This test relies on dm-verity support. - if (!verity_supported) { - GTEST_LOG_(INFO) << "Test skipped on devices without dm-verity support."; - return; - } - - std::vector> partitions = { - { - { "ranges", "2,0,1" }, - { "id", property_id_ }, - { "fingerprint", fingerprint_ }, - }, - }; - - std::string proto = ConstructProto(partitions); - ASSERT_TRUE(android::base::WriteStringToFile(proto, care_map_pb_)); - ASSERT_FALSE(verifier_.ParseCareMap()); -} - -TEST_F(UpdateVerifierTest, verify_image_protobuf_care_map_bad_ranges) { - // This test relies on dm-verity support. - if (!verity_supported) { - GTEST_LOG_(INFO) << "Test skipped on devices without dm-verity support."; - return; - } - - std::vector> partitions = { - { - { "name", "system" }, - { "ranges", "3,0,1" }, - { "id", property_id_ }, - { "fingerprint", fingerprint_ }, - }, - }; - - std::string proto = ConstructProto(partitions); - ASSERT_TRUE(android::base::WriteStringToFile(proto, care_map_pb_)); - ASSERT_FALSE(verifier_.ParseCareMap()); -} - -TEST_F(UpdateVerifierTest, verify_image_protobuf_empty_fingerprint) { - // This test relies on dm-verity support. - if (!verity_supported) { - GTEST_LOG_(INFO) << "Test skipped on devices without dm-verity support."; - return; - } - - std::vector> partitions = { - { - { "name", "system" }, - { "ranges", "2,0,1" }, - }, - }; - - std::string proto = ConstructProto(partitions); - ASSERT_TRUE(android::base::WriteStringToFile(proto, care_map_pb_)); - ASSERT_FALSE(verifier_.ParseCareMap()); -} - -TEST_F(UpdateVerifierTest, verify_image_protobuf_fingerprint_mismatch) { - // This test relies on dm-verity support. - if (!verity_supported) { - GTEST_LOG_(INFO) << "Test skipped on devices without dm-verity support."; - return; - } - - std::vector> partitions = { - { - { "name", "system" }, - { "ranges", "2,0,1" }, - { "id", property_id_ }, - { "fingerprint", "unsupported_fingerprint" }, - }, - }; - - std::string proto = ConstructProto(partitions); - ASSERT_TRUE(android::base::WriteStringToFile(proto, care_map_pb_)); - ASSERT_FALSE(verifier_.ParseCareMap()); -} -- cgit v1.2.3