From 1d156b988244660739c56803c87576f0403569ac Mon Sep 17 00:00:00 2001 From: Tao Bao Date: Wed, 2 May 2018 12:43:18 -0700 Subject: screen_ui: Drop the dependency on common.h. Remove the use of fopen_path() in screen_ui.cpp, as this is the only place that requires the dependency on common.h. The mounting work should be done by the caller. Also change the parameter in RecoveryUI::ShowFile() from const char* to const std::string&. Test: mmma -j bootable/recovery Test: Build and boot into recovery image on angler. Choose 'View recovery logs'. Change-Id: I8e63f14a8e2b12b856e5a92476e4226cd6ea39fb --- stub_ui.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'stub_ui.h') diff --git a/stub_ui.h b/stub_ui.h index 3c36fcfb1..362aab443 100644 --- a/stub_ui.h +++ b/stub_ui.h @@ -17,6 +17,9 @@ #ifndef RECOVERY_STUB_UI_H #define RECOVERY_STUB_UI_H +#include +#include + #include "ui.h" // Stub implementation of RecoveryUI for devices without screen. @@ -51,7 +54,7 @@ class StubRecoveryUI : public RecoveryUI { va_end(ap); } void PrintOnScreenOnly(const char* /* fmt */, ...) override {} - void ShowFile(const char* /* filename */) override {} + void ShowFile(const std::string& /* filename */) override {} // menu display int ShowMenu(const char* const* /* headers */, const char* const* /* items */, -- cgit v1.2.3