From a1ad19f0b7895e85ce7792594c8e37a6d3c92d6b Mon Sep 17 00:00:00 2001 From: that Date: Sat, 8 Nov 2014 01:18:44 +0100 Subject: mtp: get rid of string streams, reduces binary size a bit Change-Id: Iaa91eaac8269f02783c904d890641861ec747d11 --- mtp/node.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) (limited to 'mtp/node.cpp') diff --git a/mtp/node.cpp b/mtp/node.cpp index 1bca1d96f..207a37a08 100755 --- a/mtp/node.cpp +++ b/mtp/node.cpp @@ -14,9 +14,7 @@ * limitations under the License. */ -#include #include -#include #include #include #include @@ -103,13 +101,9 @@ void Node::addProperties(const std::string& path, int storageID) { MTPD("addProperties: handle: %u, filename: '%s'\n", handle, getName().c_str()); struct stat st; int mFormat = 0; - uint64_t puid; + uint64_t puid = ((uint64_t)storageID << 32) + handle; off_t file_size = 0; - std::string mtpidStr = static_cast( &(std::ostringstream() << handle) )->str(); - std::string storageIDStr = static_cast( &(std::ostringstream() << storageID) )->str(); - std::string puidStr = storageIDStr + mtpidStr; - if ( ! (std::istringstream(puidStr) >> puid) ) puid = 0; mFormat = MTP_FORMAT_UNDEFINED; // file if (lstat(path.c_str(), &st) == 0) { file_size = st.st_size; @@ -129,6 +123,7 @@ void Node::addProperties(const std::string& path, int storageID) { // TODO: we can't really support persistent UIDs without a persistent DB. // probably a combination of volume UUID + st_ino would come close. // doesn't help for fs with no native inodes numbers like fat though... + // however, Microsoft's own impl (Zune, etc.) does not support persistent UIDs either addProperty(MTP_PROPERTY_NAME, 0, getName().c_str(), MTP_TYPE_STR); addProperty(MTP_PROPERTY_DISPLAY_NAME, 0, getName().c_str(), MTP_TYPE_STR); addProperty(MTP_PROPERTY_DATE_ADDED, st.st_mtime, "", MTP_TYPE_UINT64); -- cgit v1.2.3