From dd78982d580aa61c39bfd13940140e5830f489b2 Mon Sep 17 00:00:00 2001 From: Tao Bao Date: Mon, 26 Nov 2018 16:28:07 -0800 Subject: minui: GRSurface::Create() computes data_size on its own. GRSurface::Create() doesn't need to rely on caller specifying the buffer size, as it can compute that info based on the given args. This CL also uses `size_t` for all the parameters in GRSurface::Create(). Test: Run recovery_unit_test on marlin. Test: Build and boot into blueline recovery. `Run graphics test`. Test: Build and boot into blueline charger mode. Change-Id: Idec9381079196abf13553a475006fefcfca10950 --- minui/graphics_fbdev.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'minui/graphics_fbdev.cpp') diff --git a/minui/graphics_fbdev.cpp b/minui/graphics_fbdev.cpp index 93e4420d3..8d9c9741d 100644 --- a/minui/graphics_fbdev.cpp +++ b/minui/graphics_fbdev.cpp @@ -32,8 +32,8 @@ #include "minui/minui.h" -std::unique_ptr GRSurfaceFbdev::Create(int width, int height, int row_bytes, - int pixel_bytes) { +std::unique_ptr GRSurfaceFbdev::Create(size_t width, size_t height, + size_t row_bytes, size_t pixel_bytes) { // Cannot use std::make_unique to access non-public ctor. return std::unique_ptr(new GRSurfaceFbdev(width, height, row_bytes, pixel_bytes)); } @@ -130,7 +130,7 @@ GRSurface* MinuiBackendFbdev::Init() { fb_fd = std::move(fd); SetDisplayedFramebuffer(0); - printf("framebuffer: %d (%d x %d)\n", fb_fd.get(), gr_draw->width, gr_draw->height); + printf("framebuffer: %d (%zu x %zu)\n", fb_fd.get(), gr_draw->width, gr_draw->height); Blank(true); Blank(false); -- cgit v1.2.3