From d5b26d61e72c63b22224a87c5a54380f9d2ce3b6 Mon Sep 17 00:00:00 2001 From: Vojtech Bocek Date: Thu, 6 Mar 2014 22:56:13 +0100 Subject: Fix "\n\n" string in gui_print(), remove unused gui_print_overwrite() Change-Id: Ib23354a706013c8cee6665c720fa3b890f3fb3de Signed-off-by: Vojtech Bocek --- gui/console.cpp | 54 ++++++++---------------------------------------------- gui/gui.h | 1 - 2 files changed, 8 insertions(+), 47 deletions(-) diff --git a/gui/console.cpp b/gui/console.cpp index f0d76c646..aae30a40b 100644 --- a/gui/console.cpp +++ b/gui/console.cpp @@ -46,60 +46,22 @@ extern "C" void gui_print(const char *fmt, ...) return; } - for (start = next = buf; *next != '\0'; next++) + for (start = next = buf; *next != '\0';) { if (*next == '\n') { *next = '\0'; - next++; + gConsole.push_back(start); - std::string line = start; - gConsole.push_back(line); - start = next; - - // Handle the normal \n\0 case - if (*next == '\0') - return; + start = ++next; } + else + ++next; } - std::string line = start; - gConsole.push_back(line); - return; -} - -extern "C" void gui_print_overwrite(const char *fmt, ...) -{ - char buf[512]; // We're going to limit a single request to 512 bytes - - va_list ap; - va_start(ap, fmt); - vsnprintf(buf, 512, fmt, ap); - va_end(ap); - fputs(buf, stdout); - - // Pop the last line, and we can continue - if (!gConsole.empty()) gConsole.pop_back(); - - char *start, *next; - for (start = next = buf; *next != '\0'; next++) - { - if (*next == '\n') - { - *next = '\0'; - next++; - - std::string line = start; - gConsole.push_back(line); - start = next; - - // Handle the normal \n\0 case - if (*next == '\0') - return; - } - } - std::string line = start; - gConsole.push_back(line); + // The text after last \n (or whole string if there is no \n) + if(*start) + gConsole.push_back(start); return; } diff --git a/gui/gui.h b/gui/gui.h index fc3c0c47a..10bf6ce2a 100644 --- a/gui/gui.h +++ b/gui/gui.h @@ -25,7 +25,6 @@ int gui_loadResources(); int gui_start(); int gui_startPage(const char* page_name); void gui_print(const char *fmt, ...); -void gui_print_overwrite(const char *fmt, ...); #endif // _GUI_HEADER -- cgit v1.2.3