summaryrefslogtreecommitdiffstats
path: root/install.cpp
diff options
context:
space:
mode:
authorTao Bao <tbao@google.com>2018-12-20 18:44:06 +0100
committerTao Bao <tbao@google.com>2018-12-20 19:46:06 +0100
commit3d69f0df961b8a79d247ca91dc272c60e504b538 (patch)
treec08c10e3acf70606bf61e1d68b582f72f0aa1572 /install.cpp
parentMerge changes from topic "vintf_object_recovery_mount" (diff)
downloadandroid_bootable_recovery-3d69f0df961b8a79d247ca91dc272c60e504b538.tar
android_bootable_recovery-3d69f0df961b8a79d247ca91dc272c60e504b538.tar.gz
android_bootable_recovery-3d69f0df961b8a79d247ca91dc272c60e504b538.tar.bz2
android_bootable_recovery-3d69f0df961b8a79d247ca91dc272c60e504b538.tar.lz
android_bootable_recovery-3d69f0df961b8a79d247ca91dc272c60e504b538.tar.xz
android_bootable_recovery-3d69f0df961b8a79d247ca91dc272c60e504b538.tar.zst
android_bootable_recovery-3d69f0df961b8a79d247ca91dc272c60e504b538.zip
Diffstat (limited to '')
-rw-r--r--install.cpp10
1 files changed, 3 insertions, 7 deletions
diff --git a/install.cpp b/install.cpp
index ce3d4f6ad..9d8943f7d 100644
--- a/install.cpp
+++ b/install.cpp
@@ -395,12 +395,8 @@ static int try_update_binary(const std::string& package, ZipArchiveHandle zip, b
// update attempt.
//
- // Convert the vector to a NULL-terminated char* array suitable for execv.
- const char* chr_args[args.size() + 1];
- chr_args[args.size()] = nullptr;
- for (size_t i = 0; i < args.size(); i++) {
- chr_args[i] = args[i].c_str();
- }
+ // Convert the std::string vector to a NULL-terminated char* vector suitable for execv.
+ auto chr_args = StringVectorToNullTerminatedArray(args);
pid_t pid = fork();
@@ -415,7 +411,7 @@ static int try_update_binary(const std::string& package, ZipArchiveHandle zip, b
if (pid == 0) {
umask(022);
close(pipefd[0]);
- execv(chr_args[0], const_cast<char**>(chr_args));
+ execv(chr_args[0], chr_args.data());
// Bug: 34769056
// We shouldn't use LOG/PLOG in the forked process, since they may cause
// the child process to hang. This deadlock results from an improperly