summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTao Bao <tbao@google.com>2015-09-03 19:21:02 +0200
committerAndroid Git Automerger <android-git-automerger@android.com>2015-09-03 19:21:02 +0200
commit834c92b7b145b0ae1800f869170e9ae6d2834fef (patch)
treeae2128dbfcf5899d6e335376daec2caf12dd6c1c
parentam 1b3195cb: am 4c223f4e: Merge "Add slot_suffix field to struct bootloader_message." (diff)
parentrecovery: Fix the bug that truncates menu entries. (diff)
downloadandroid_bootable_recovery-834c92b7b145b0ae1800f869170e9ae6d2834fef.tar
android_bootable_recovery-834c92b7b145b0ae1800f869170e9ae6d2834fef.tar.gz
android_bootable_recovery-834c92b7b145b0ae1800f869170e9ae6d2834fef.tar.bz2
android_bootable_recovery-834c92b7b145b0ae1800f869170e9ae6d2834fef.tar.lz
android_bootable_recovery-834c92b7b145b0ae1800f869170e9ae6d2834fef.tar.xz
android_bootable_recovery-834c92b7b145b0ae1800f869170e9ae6d2834fef.tar.zst
android_bootable_recovery-834c92b7b145b0ae1800f869170e9ae6d2834fef.zip
-rw-r--r--wear_ui.cpp7
1 files changed, 6 insertions, 1 deletions
diff --git a/wear_ui.cpp b/wear_ui.cpp
index 4ae42c467..55b7afc8f 100644
--- a/wear_ui.cpp
+++ b/wear_ui.cpp
@@ -482,7 +482,12 @@ void WearRecoveryUI::StartMenu(const char* const * headers, const char* const *
if (text_rows > 0 && text_cols > 0) {
menu_headers_ = headers;
size_t i = 0;
- for (; i < text_rows && items[i] != nullptr; i++) {
+ // "i < text_rows" is removed from the loop termination condition,
+ // which is different from the one in ScreenRecoveryUI::StartMenu().
+ // Because WearRecoveryUI supports scrollable menu, it's fine to have
+ // more entries than text_rows. The menu may be truncated otherwise.
+ // Bug: 23752519
+ for (; items[i] != nullptr; i++) {
strncpy(menu[i], items[i], text_cols - 1);
menu[i][text_cols - 1] = '\0';
}