summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristopher Ferris <cferris@google.com>2021-10-12 16:54:09 +0200
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2021-10-12 16:54:09 +0200
commite188d18ec2c519157d4230aa29187d4060787d44 (patch)
treece9f74d8a787c028454658b3d957fa394e5f780c
parent[automerger skipped] Merge "Merge Android 12" am: 436a520a57 -s ours am: 60c3c08aa4 -s ours am: aaccc6518d -s ours am: 3ba15f2799 -s ours (diff)
parentDo not write past end of inotify event structure. am: 187a6ec548 am: 8346be7882 (diff)
downloadandroid_bootable_recovery-e188d18ec2c519157d4230aa29187d4060787d44.tar
android_bootable_recovery-e188d18ec2c519157d4230aa29187d4060787d44.tar.gz
android_bootable_recovery-e188d18ec2c519157d4230aa29187d4060787d44.tar.bz2
android_bootable_recovery-e188d18ec2c519157d4230aa29187d4060787d44.tar.lz
android_bootable_recovery-e188d18ec2c519157d4230aa29187d4060787d44.tar.xz
android_bootable_recovery-e188d18ec2c519157d4230aa29187d4060787d44.tar.zst
android_bootable_recovery-e188d18ec2c519157d4230aa29187d4060787d44.zip
-rw-r--r--minui/events.cpp8
1 files changed, 5 insertions, 3 deletions
diff --git a/minui/events.cpp b/minui/events.cpp
index 87f811225..863ac7474 100644
--- a/minui/events.cpp
+++ b/minui/events.cpp
@@ -29,7 +29,9 @@
#include <functional>
#include <memory>
+#include <string>
+#include <android-base/strings.h>
#include <android-base/unique_fd.h>
#include "minui/minui.h"
@@ -118,12 +120,12 @@ static int inotify_cb(int fd, __unused uint32_t epevents) {
}
offset += sizeof(inotify_event) + pevent->len;
- pevent->name[pevent->len] = '\0';
- if (strncmp(pevent->name, "event", 5)) {
+ std::string event_name(pevent->name, pevent->len);
+ if (!android::base::StartsWith(event_name, "event")) {
continue;
}
- android::base::unique_fd dfd(openat(dirfd(dir.get()), pevent->name, O_RDONLY));
+ android::base::unique_fd dfd(openat(dirfd(dir.get()), event_name.c_str(), O_RDONLY));
if (dfd == -1) {
break;
}