summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTao Bao <tbao@google.com>2019-03-29 23:43:09 +0100
committerTao Bao <tbao@google.com>2019-03-29 23:50:02 +0100
commitbc982a4f8845e5fa0cd2630ddcc3d8f70066b083 (patch)
treed95e3fdd35b47bb80c6b06bd65344c1eb2582afb
parentMerge "Move install to separate module" (diff)
downloadandroid_bootable_recovery-bc982a4f8845e5fa0cd2630ddcc3d8f70066b083.tar
android_bootable_recovery-bc982a4f8845e5fa0cd2630ddcc3d8f70066b083.tar.gz
android_bootable_recovery-bc982a4f8845e5fa0cd2630ddcc3d8f70066b083.tar.bz2
android_bootable_recovery-bc982a4f8845e5fa0cd2630ddcc3d8f70066b083.tar.lz
android_bootable_recovery-bc982a4f8845e5fa0cd2630ddcc3d8f70066b083.tar.xz
android_bootable_recovery-bc982a4f8845e5fa0cd2630ddcc3d8f70066b083.tar.zst
android_bootable_recovery-bc982a4f8845e5fa0cd2630ddcc3d8f70066b083.zip
Diffstat (limited to '')
-rw-r--r--common.h9
-rw-r--r--recovery.cpp15
-rw-r--r--recovery_ui/include/recovery_ui/device.h4
3 files changed, 3 insertions, 25 deletions
diff --git a/common.h b/common.h
index 22b2f0a0d..9cb44bd37 100644
--- a/common.h
+++ b/common.h
@@ -14,11 +14,7 @@
* limitations under the License.
*/
-#ifndef RECOVERY_COMMON_H
-#define RECOVERY_COMMON_H
-
-#include <stdarg.h>
-#include <stdio.h>
+#pragma once
#include <string>
@@ -39,9 +35,6 @@ extern std::string stage;
// The reason argument provided in "--reason=".
extern const char* reason;
-void ui_print(const char* format, ...) __printflike(1, 2);
-
bool is_ro_debuggable();
bool SetUsbConfig(const std::string& state);
-#endif // RECOVERY_COMMON_H
diff --git a/recovery.cpp b/recovery.cpp
index 421bc12f2..02cc53c2c 100644
--- a/recovery.cpp
+++ b/recovery.cpp
@@ -24,7 +24,6 @@
#include <limits.h>
#include <linux/fs.h>
#include <linux/input.h>
-#include <stdarg.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
@@ -746,20 +745,6 @@ static void print_property(const char* key, const char* name, void* /* cookie */
printf("%s=%s\n", key, name);
}
-void ui_print(const char* format, ...) {
- std::string buffer;
- va_list ap;
- va_start(ap, format);
- android::base::StringAppendV(&buffer, format, ap);
- va_end(ap);
-
- if (ui != nullptr) {
- ui->Print("%s", buffer.c_str());
- } else {
- fputs(buffer.c_str(), stdout);
- }
-}
-
static bool is_battery_ok(int* required_battery_level) {
using android::hardware::health::V1_0::BatteryStatus;
using android::hardware::health::V2_0::get_health_service;
diff --git a/recovery_ui/include/recovery_ui/device.h b/recovery_ui/include/recovery_ui/device.h
index cfa914e77..3c44510c8 100644
--- a/recovery_ui/include/recovery_ui/device.h
+++ b/recovery_ui/include/recovery_ui/device.h
@@ -93,8 +93,8 @@ class Device {
// Performs a recovery action selected from the menu. 'menu_position' will be the index of the
// selected menu item, or a non-negative value returned from HandleMenuKey(). The menu will be
- // hidden when this is called; implementations can call ui_print() to print information to the
- // screen. If the menu position is one of the builtin actions, you can just return the
+ // hidden when this is called; implementations can call GetUI()->Print() to print information to
+ // the screen. If the menu position is one of the builtin actions, you can just return the
// corresponding enum value. If it is an action specific to your device, you actually perform it
// here and return NO_ACTION.
virtual BuiltinAction InvokeMenuItem(size_t menu_position);