From 13144a08e496b89b34093ffd3d810d3442df3c44 Mon Sep 17 00:00:00 2001 From: peterbell10 Date: Thu, 14 May 2020 23:15:35 +0100 Subject: Enable some more clang-tidy linter checks (#4738) * Avoid inefficient AString -> c_str() -> AString round trip * Avoid redundant string init expressions * Avoid unnecessary return, continue, etc. * Add .clang-format to help with clang-tidy fix-its * Avoid unnecessary passing by value * Avoid unnecessary local copying * Avoid copying in range-for loops * Avoid over-complicated boolean expressions * Some violations missed by my local clang-tidy * Allow unnecessary continue statements * Add brackets * Another expression missed locally * Move BindingsProcessor call into clang-tidy.sh and add space * Fix pushd not found error * Different grouping of CheckBlockInteractionRate --- src/HTTP/HTTPMessage.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/HTTP/HTTPMessage.h') diff --git a/src/HTTP/HTTPMessage.h b/src/HTTP/HTTPMessage.h index 20deab5ab..f73957748 100644 --- a/src/HTTP/HTTPMessage.h +++ b/src/HTTP/HTTPMessage.h @@ -126,7 +126,7 @@ public: bool DoesAllowKeepAlive(void) const { return m_AllowKeepAlive; } /** Attaches any kind of data to this request, to be later retrieved by GetUserData(). */ - void SetUserData(cUserDataPtr a_UserData) { m_UserData = a_UserData; } + void SetUserData(cUserDataPtr a_UserData) { m_UserData = std::move(a_UserData); } /** Returns the data attached to this request by the class client. */ cUserDataPtr GetUserData(void) { return m_UserData; } -- cgit v1.2.3